Re: [Qemu-devel] [PATCH 4/4] e1000e: Rename "subsys_ven" property to "subsys-vendor"

2016-10-27 Thread Dmitry Fleytman
> On 26 Oct 2016, at 22:21 PM, Eduardo Habkost wrote: > > Follow the usual QOM property naming style, and make the property > name clearer. > > This breaks command-line compatibility, but I am assuming the > property is not being used in production by anybody. I’m basically Ok with this patch

[Qemu-devel] [PATCH COLO-Frame (Base) v23 03/18] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-27 Thread zhanghailiang
Add a new migration state: MIGRATION_STATUS_COLO. Migration source side enters this state after the first live migration successfully finished if COLO is enabled by command 'migrate_set_capability x-colo on'. We reuse migration thread, so the process of checkpointing will be handled in migration t

[Qemu-devel] [PATCH COLO-Frame (Base) v23 18/18] MAINTAINERS: Add maintainer for COLO framework related files

2016-10-27 Thread zhanghailiang
Add myself as co-maintainer of COLO framework, so that I can get CC'ed on future patches and bugs for this feature. Signed-off-by: zhanghailiang --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b01fec0..484e8b8 100644 --- a/MAINTAINERS +

[Qemu-devel] [PATCH COLO-Frame (Base) v23 02/18] COLO: migrate COLO related info to secondary node

2016-10-27 Thread zhanghailiang
We can determine whether or not VM in destination should go into COLO mode by referring to the info that was migrated. We skip this section if COLO is not enabled (i.e. migrate_set_capability colo off), so that, It doesn't break compatibility with migration no matter whether users configure the --

Re: [Qemu-devel] [PATCH 3/4] e1000e: Rename "disable_vnet_hdr" property to "vnet"

2016-10-27 Thread Dmitry Fleytman
> On 26 Oct 2016, at 22:21 PM, Eduardo Habkost wrote: > > The original commit that introduced e1000e (6f3fbe4e) mentioned a > property called "vnet". The actual property name added by the > patch is "disable_vnet_hdr". Rename the property so that: > > 1) we avoid confusing double-negatives li

[Qemu-devel] [PATCH COLO-Frame (Base) v23 12/18] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover

2016-10-27 Thread zhanghailiang
We leave users to choose whatever heartbeat solution they want, if the heartbeat is lost, or other errors they detect, they can use experimental command 'x_colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations accordingly. For example, if the command is sent to the Primary side

[Qemu-devel] [PATCH COLO-Frame (Base) v23 09/18] COLO: Load VMState into QIOChannelBuffer before restore it

2016-10-27 Thread zhanghailiang
We should not destroy the state of SVM (Secondary VM) until we receive the complete data of PVM's state, in case the primary fails in the process of sending the state, so we cache the VM's state in secondary side before load it into SVM. Besides, we should call qemu_system_reset() before load VM s

[Qemu-devel] [PATCH COLO-Frame (Base) v23 14/18] COLO: Implement the process of failover for primary VM

2016-10-27 Thread zhanghailiang
For primary side, if COLO gets failover request from users. To be exact, gets 'x_colo_lost_heartbeat' command. COLO thread will exit the loop while the failover BH does the cleanup work and resumes VM. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Re

Re: [Qemu-devel] [PATCH v2 2/2] qapi: allow blockdev-add for NFS

2016-10-27 Thread Ashijeet Acharya
On Wed, Oct 26, 2016 at 3:19 PM, Kevin Wolf wrote: > Am 25.10.2016 um 23:16 hat Eric Blake geschrieben: >> On 10/24/2016 02:27 PM, Ashijeet Acharya wrote: >> > Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to >> > support blockdev-add for NFS network protocol driver. Also make

[Qemu-devel] [PATCH COLO-Frame (Base) v23 16/18] docs: Add documentation for COLO feature

2016-10-27 Thread zhanghailiang
Introduce the design of COLO, and how to test it. Signed-off-by: zhanghailiang Reviewed-by: Amit Shah --- v22: - Add Reviewed-by tag v21: - Fix some minor typos and grammar from Eric --- docs/COLO-FT.txt | 189 +++ 1 file changed, 189 insertio

[Qemu-devel] [PATCH COLO-Frame (Base) v23 08/18] COLO: Send PVM state to secondary side when do checkpoint

2016-10-27 Thread zhanghailiang
VM checkpointing is to synchronize the state of PVM to SVM, just like migration does, we re-use save helpers to achieve migrating PVM's state to Secondary side. COLO need to cache the data of VM's state in the secondary side before synchronize it to SVM. COLO need the size of the data to determine

Re: [Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-27 Thread Markus Armbruster
Jeff Cody writes: > On Wed, Oct 26, 2016 at 09:33:30PM +, Buddhi Madhav wrote: >> >> >> On 10/25/16, 9:41 PM, "Jeff Cody" wrote: >> >> >On Tue, Oct 25, 2016 at 03:02:07PM -0700, Ashish Mittal wrote: >> >> This patch adds support for a new block device type called "vxhs". >> >> Source code

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-27 Thread Alexey Kardashevskiy
On 18/10/16 08:22, Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for the devices which are IOMMU capable. > Mediated device only uses IOMMU APIs, the underlying hardware can be > managed by an IOMMU domain. > > Aim of this change is: > - To use most of the code of TYPE1 IOMMU driver for

Re: [Qemu-devel] [PATCH v1] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-27 Thread Daniel P. Berrange
On Wed, Oct 26, 2016 at 09:33:30PM +, Buddhi Madhav wrote: > > > On 10/25/16, 9:41 PM, "Jeff Cody" wrote: > > >On Tue, Oct 25, 2016 at 03:02:07PM -0700, Ashish Mittal wrote: > >> This patch adds support for a new block device type called "vxhs". > >> Source code for the library that this co

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-27 Thread Daniel P. Berrange
On Wed, Oct 26, 2016 at 03:23:05PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git > > Sample command line using JSON syntax: >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v23 18/18] MAINTAINERS: Add maintainer for COLO framework related files

2016-10-27 Thread Amit Shah
On (Thu) 27 Oct 2016 [14:43:09], zhanghailiang wrote: > Add myself as co-maintainer of COLO framework, so that > I can get CC'ed on future patches and bugs for this feature. > > Signed-off-by: zhanghailiang Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] "block: use aio_bh_schedule_oneshot" breaks ibm-vscsi

2016-10-27 Thread Paolo Bonzini
On 27/10/2016 05:30, Alexey Kardashevskiy wrote: > Hi, > > I just discovered that fffb6e12233002c26c0ee9ff92fa87927cd779f2 broke > ibm-vscsi, the guest booting stops (I waited for a minute) at: > > [0.809286] ibmvscsi 7101: SRP_VERSION: 16.a > [0.809766] ibmvscsi 7101: Maximum I

Re: [Qemu-devel] [PATCH v5 4/9] record/replay: add network support

2016-10-27 Thread Paolo Bonzini
On 27/10/2016 05:36, Jason Wang wrote: > > > On 2016年09月26日 16:08, Pavel Dovgalyuk wrote: >> This patch adds support of recording and replaying network packets in >> irount rr mode. >> >> Record and replay for network interactions is performed with the >> network filter. >> Each backend must ha

Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce framework and device emulation

2016-10-27 Thread Gonglei (Arei)
Hi Michael, Warm reminder: The dependency (crypto stuff) of virito-crypto patch series had been merged, so the building failure was gone. Regards, -Gonglei > -Original Message- > From: no-re...@patchew.org [mailto:no-re...@patchew.org] > Sent: Thursday, October 20, 2016 8:26 PM > To:

Re: [Qemu-devel] [PATCH v2 3/6] target-ppc: add vrldnmi and vrlwmi instructions

2016-10-27 Thread Nikunj A Dadhania
David Gibson writes: >> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c >> index dca4798..b54cd7c 100644 >> --- a/target-ppc/int_helper.c >> +++ b/target-ppc/int_helper.c >> @@ -1717,6 +1717,52 @@ void helper_vrsqrtefp(CPUPPCState *env, ppc_avr_t *r, >> ppc_avr_t *b) >> } >>

Re: [Qemu-devel] [PATCH v2 5/6] target-ppc: add vprtyb[w/d/q] instructions

2016-10-27 Thread Nikunj A Dadhania
Richard Henderson writes: > On 10/26/2016 08:47 PM, David Gibson wrote: >>> > +void helper_vprtybq(ppc_avr_t *r, ppc_avr_t *b) >>> > +{ >>> > +int i; >>> > +uint8_t s = 0; >>> > +for (i = 0; i < 16; i++) { >>> > +s ^= (b->u8[i] & 1); >>> > +} >>> > +r->u64[LO_IDX] = (!

[Qemu-devel] [PATCH] 9pfs: don't BUG_ON() if fid is already opened

2016-10-27 Thread Greg Kurz
A buggy or malicious guest could pass the id of an already opened fid and cause QEMU to abort. Let's return EINVAL to the guest instead. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p

Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option

2016-10-27 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Marc-André Lureau writes: > > > This option does nothing since commit 06ac27f. Deprecate it. > > > > Signed-off-by: Marc-André Lureau > > --- > > vl.c | 11 +++ > > include/monitor/monitor.h | 2 +- > > qemu-options

Re: [Qemu-devel] [PATCH v12 10/19] block: Add QMP support for streaming to an intermediate layer

2016-10-27 Thread Kevin Wolf
Am 26.10.2016 um 19:23 hat Alberto Garcia geschrieben: > On Wed 26 Oct 2016 04:58:00 PM CEST, Kevin Wolf wrote: > > Am 26.10.2016 um 12:29 hat Alberto Garcia geschrieben: > >> This patch makes the 'device' parameter of the 'block-stream' command > >> accept a node name that is not a root node. > >

Re: [Qemu-devel] [PATCH v2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-10-27 Thread ashish mittal
Hi Daniel, >> >I think this version still does not address Daniel's concerns regarding a >> >QAPI schema for vxhs. >> >> We are working on QAPI schema changes and will submit them in separate >> patch. > > They should be part of the main patch, not a separate patch as they are > a pre-requisite fo

Re: [Qemu-devel] [PATCH v12 10/19] block: Add QMP support for streaming to an intermediate layer

2016-10-27 Thread Alberto Garcia
On Thu 27 Oct 2016 10:58:04 AM CEST, Kevin Wolf wrote: >> >> +# The node that receives the data is called the top image, can be >> >> located in >> >> +# any part of the chain (but always above the base image; see below) and >> >> can be >> >> +# specified using its device or node name. >> >> +#

[Qemu-devel] [PATCH v3 0/2] block: allow blockdev-add for NFS

2016-10-27 Thread Ashijeet Acharya
Previously posted series patches: v2: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg05844.html v1: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg04487.html This series adds blockdev-add support for NFS block driver. Patch 1 helps to prepare NFS driver to make use of several

[Qemu-devel] [PATCH v3 1/2] block/nfs: Introduce runtime_opts in NFS

2016-10-27 Thread Ashijeet Acharya
Make NFS block driver use various fine grained runtime_opts. Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two new functions nfs_parse_filename() and nfs_parse_uri() to help parsing the URI. Signed-off-by: Ashijeet Acharya --- block/nfs.c | 331

[Qemu-devel] [PATCH 01/20] replication: interrupt failover if the main device is closed

2016-10-27 Thread Paolo Bonzini
Without this change, there is a race condition in tests/test-replication. Depending on how fast the failover job (active commit) runs, there is a chance of two bad things happening: 1) replication_done can be called after the secondary has been closed and hence when the BDRVReplicationState is not

[Qemu-devel] [PATCH 06/20] qed: Implement .bdrv_drain

2016-10-27 Thread Paolo Bonzini
From: Fam Zheng The "need_check_timer" is used to clear the "NEED_CHECK" flag in the image header after a grace period once metadata update has finished. To comply with the bdrv_drain semantics, we should make sure it remains deleted once .bdrv_drain is called. The change to qed_need_check_timer

[Qemu-devel] [PATCH 02/20] blockjob: introduce .drain callback for jobs

2016-10-27 Thread Paolo Bonzini
This is required to decouple block jobs from running in an AioContext. With multiqueue block devices, a BlockDriverState does not really belong to a single AioContext. The solution is to first wait until all I/O operations are complete; then loop in the main thread for the block job to complete e

[Qemu-devel] [PATCH v3 2/2] qapi: allow blockdev-add for NFS

2016-10-27 Thread Ashijeet Acharya
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to support blockdev-add for NFS network protocol driver. Also make a new struct NFSServer to support tcp connection. Signed-off-by: Ashijeet Acharya --- qapi/block-core.json | 77 +--

[Qemu-devel] [PATCH 08/20] nfs: move nfs_set_events out of the while loops

2016-10-27 Thread Paolo Bonzini
nfs_set_events only needs to be called once before entering the while loop; afterwards, nfs_process_read and nfs_process_write take care of it. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/nfs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/b

[Qemu-devel] [PATCH v3 00/20] dataplane: remove RFifoLock

2016-10-27 Thread Paolo Bonzini
The only difference from v2 is the disappearing of bdrv_aio_pdiscard, bdrv_aio_ioctl and bdrv_ioctl. Thanks, Paolo Fam Zheng (1): qed: Implement .bdrv_drain Paolo Bonzini (19): replication: interrupt failover if the main device is closed blockjob: introduce .drain callback for jobs mirr

[Qemu-devel] [PATCH 05/20] block: change drain to look only at one child at a time

2016-10-27 Thread Paolo Bonzini
bdrv_requests_pending is checking children to also wait until internal requests (such as metadata writes) have completed. However, checking children is in general overkill. Children requests can be of two kinds: - requests caused by an operation on bs, e.g. a bdrv_aio_write to bs causing a write

[Qemu-devel] [PATCH 07/20] block: introduce BDRV_POLL_WHILE

2016-10-27 Thread Paolo Bonzini
We want the BDS event loop to run exclusively in the iothread that owns the BDS's AioContext. This macro will provide the synchronization between the two event loops; for now it just wraps the common idiom of a while loop around aio_poll. Signed-off-by: Paolo Bonzini --- block/block-backend.c |

[Qemu-devel] [PATCH 10/20] sheepdog: use BDRV_POLL_WHILE

2016-10-27 Thread Paolo Bonzini
This is important when the sheepdog driver works on a BlockDriverState that is attached to an I/O thread other than the main thread. Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 64 +++- 1 file changed, 35 insertions(+), 29 deletions(-)

[Qemu-devel] [PATCH 03/20] mirror: use bdrv_drained_begin/bdrv_drained_end

2016-10-27 Thread Paolo Bonzini
Ensure that there are no changes between the last check to bdrv_get_dirty_count and the switch to the target. There is already a bdrv_drained_end call, we only need to ensure that bdrv_drained_begin is not called twice. Signed-off-by: Paolo Bonzini --- block/mirror.c | 35 ++

[Qemu-devel] [PATCH 11/20] aio: introduce qemu_get_current_aio_context

2016-10-27 Thread Paolo Bonzini
This will be used by BDRV_POLL_WHILE (and thus by bdrv_drain) to choose how to wait for I/O completion. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/block/aio.h | 18 ++ iothread.c | 9 + stubs/Makefile.objs | 1 + stubs/iothread.c| 8 +

[Qemu-devel] [PATCH 04/20] block: add BDS field to count in-flight requests

2016-10-27 Thread Paolo Bonzini
Unlike tracked_requests, this field also counts throttled requests, and remains non-zero if an AIO operation needs a BH to be "really" completed. With this change, it is no longer necessary to have a dummy BdrvTrackedRequest for requests that are never serialising, and it is no longer necessary to

[Qemu-devel] [PATCH 12/20] iothread: detach all block devices before stopping them

2016-10-27 Thread Paolo Bonzini
Soon bdrv_drain will not call aio_poll itself on iothreads. If block devices are left hanging off the iothread's AioContext, there will be no one to do I/O for those poor devices. Signed-off-by: Paolo Bonzini --- iothread.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ioth

[Qemu-devel] [PATCH 17/20] block: only call aio_poll on the current thread's AioContext

2016-10-27 Thread Paolo Bonzini
aio_poll is not thread safe; for example bdrv_drain can hang if the last in-flight I/O operation is completed in the I/O thread after the main thread has checked bs->in_flight. The bug remains latent as long as all of it is called within aio_context_acquire/aio_context_release, but this will chang

[Qemu-devel] [PATCH 09/20] nfs: use BDRV_POLL_WHILE

2016-10-27 Thread Paolo Bonzini
This will make it possible to use nfs_get_allocated_file_size on a file that is not in the main AioContext. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/nfs.c | 46 -- 1 file changed, 28 insertions(+), 18 deletions(-) diff --gi

[Qemu-devel] [PATCH 13/20] replication: pass BlockDriverState to reopen_backing_file

2016-10-27 Thread Paolo Bonzini
This will be needed in the next patch to retrieve the AioContext. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/replication.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/block/replication.c b/block/replication.c index a2747e7.

[Qemu-devel] [PATCH 14/20] block: prepare bdrv_reopen_multiple to release AioContext

2016-10-27 Thread Paolo Bonzini
After the next patch bdrv_drain_all will have to be called without holding any AioContext. Prepare to do this by adding an AioContext argument to bdrv_reopen_multiple. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block.c | 4 ++-- block/commit.c| 2 +- bl

[Qemu-devel] [PATCH 19/20] qemu-thread: introduce QemuRecMutex

2016-10-27 Thread Paolo Bonzini
GRecMutex is new in glib 2.32, so we cannot use it. Introduce a recursive mutex in qemu-thread instead, which will be used instead of RFifoLock. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- include/qemu/thread-posix.h | 6 ++ include/qemu/thread-wi

[Qemu-devel] [PATCH 15/20] qemu-io: acquire AioContext

2016-10-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-io-cmds.c | 4 1 file changed, 4 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index dbe0413..4750e9a 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -2216,6 +2216,7 @@ static const cmdinfo_t help_cmd = { bool qemuio_command(BlockBac

[Qemu-devel] [PATCH 16/20] qemu-img: call aio_context_acquire/release around block job

2016-10-27 Thread Paolo Bonzini
This will be needed by bdrv_reopen_multiple, which calls bdrv_drain_all and thus will *release* the AioContext. Signed-off-by: Paolo Bonzini --- qemu-img.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index afcd51f..ac7f40d 100644 --- a/qemu-img.c +++ b/qemu-

[Qemu-devel] [PATCH 20/20] aio: convert from RFifoLock to QemuRecMutex

2016-10-27 Thread Paolo Bonzini
It is simpler and a bit faster, and QEMU does not need the contention callbacks (and thus the fairness) anymore. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- async.c | 8 ++--- include/block/aio.h | 3 +- include/qemu/rfifolock.h | 54 -

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

2016-10-27 Thread Wei Liu
On Thu, Oct 27, 2016 at 12:03:42PM +0100, Wei Liu wrote: > Cc Sander > > On Thu, Oct 27, 2016 at 12:54:02PM +0200, Igor Mammedov wrote: > > On Wed, 26 Oct 2016 16:22:34 +0100 > > Wei Liu wrote: > > > > > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > > > On Tue, 25 Oct 2016 1

[Qemu-devel] [PATCH 18/20] iothread: release AioContext around aio_poll

2016-10-27 Thread Paolo Bonzini
This is the first step towards having fine-grained critical sections in dataplane threads, which will resolve lock ordering problems between address_space_* functions (which need the BQL when doing MMIO, even after we complete RCU-based dispatch) and the AioContext. Because AioContext does not use

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

2016-10-27 Thread Wei Liu
Cc Sander On Thu, Oct 27, 2016 at 12:54:02PM +0200, Igor Mammedov wrote: > On Wed, 26 Oct 2016 16:22:34 +0100 > Wei Liu wrote: > > > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > > On Tue, 25 Oct 2016 18:28:04 +0100 > > > Wei Liu wrote: > > > > > > > Xen's toolstack is i

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-27 Thread Halil Pasic
On 10/26/2016 07:33 PM, Jianjun Duan wrote: >>> +#define QTAILQ_FIRST_OFFSET 0 >>> >> +#define QTAILQ_LAST_OFFSET (sizeof(void *)) >> > >> > OK, you might want to add some asserts somewhere in a .c just to >> > catch if >> > any of these offsets change

[Qemu-devel] [Bug 1636770] Re: mouse wheel works only with -usbdevice tablet

2016-10-27 Thread Bug Report
** Description changed: 2.7.0 - tested with windows 10 + tested with windows 10 1607 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1636770 Title: mouse wheel works only with -usbdevice tablet

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

2016-10-27 Thread Igor Mammedov
On Wed, 26 Oct 2016 16:22:34 +0100 Wei Liu wrote: > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > On Tue, 25 Oct 2016 18:28:04 +0100 > > Wei Liu wrote: > > > > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > > > building if running on Xen. > > >

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

2016-10-27 Thread Igor Mammedov
On Wed, 26 Oct 2016 16:22:34 +0100 Wei Liu wrote: > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > On Tue, 25 Oct 2016 18:28:04 +0100 > > Wei Liu wrote: > > > > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > > > building if running on Xen. > > >

[Qemu-devel] [PATCH v1 1/1] block/gluster: memory usage: use one glfs instance per volume

2016-10-27 Thread Prasanna Kumar Kalever
Currently, for every drive accessed via gfapi we create a new glfs instance (call glfs_new() followed by glfs_init()) which could consume memory in few 100 MB's, from the table below it looks like for each instance ~300 MB VSZ was consumed Before: --- Disks VSZ RSS 1 1098728 187756

Re: [Qemu-devel] [Xen-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

2016-10-27 Thread Igor Mammedov
On Thu, 27 Oct 2016 12:10:58 +0100 Wei Liu wrote: > On Thu, Oct 27, 2016 at 12:03:42PM +0100, Wei Liu wrote: > > Cc Sander > > > > On Thu, Oct 27, 2016 at 12:54:02PM +0200, Igor Mammedov wrote: > > > On Wed, 26 Oct 2016 16:22:34 +0100 > > > Wei Liu wrote: > > > > > > > On Wed, Oct 26, 2016

[Qemu-devel] [PATCH] raw-posix: Rename 'raw_s' to 'rs'

2016-10-27 Thread Fam Zheng
It is too confusing because it sounds like a BDRVRawState variable. Suggested-by: Max Reitz Signed-off-by: Fam Zheng --- block/raw-posix.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/block/raw-posix.c b/block/raw-

Re: [Qemu-devel] [Xen-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

2016-10-27 Thread Wei Liu
On Thu, Oct 27, 2016 at 01:26:49PM +0200, Igor Mammedov wrote: > On Thu, 27 Oct 2016 12:10:58 +0100 > Wei Liu wrote: > > > On Thu, Oct 27, 2016 at 12:03:42PM +0100, Wei Liu wrote: > > > Cc Sander > > > > > > On Thu, Oct 27, 2016 at 12:54:02PM +0200, Igor Mammedov wrote: > > > > On Wed, 26 Oct

Re: [Qemu-devel] [PATCH 4/4] e1000e: Rename "subsys_ven" property to "subsys-vendor"

2016-10-27 Thread Eduardo Habkost
On Thu, Oct 27, 2016 at 09:45:27AM +0300, Dmitry Fleytman wrote: [...] > > @@ -524,7 +524,6 @@ static int e1000e_post_load(void *opaque, int > > version_id) > > E1000EState *s = opaque; > > > > trace_e1000e_cb_post_load(); > > - > > This hunk should not be in this patch. Sorry, this is

Re: [Qemu-devel] [PATCH 1/4] e1000e: Use regular DEFINE_PROP_ macros for properties

2016-10-27 Thread Eduardo Habkost
On Thu, Oct 27, 2016 at 09:38:28AM +0300, Dmitry Fleytman wrote: > > > On 27 Oct 2016, at 06:12 AM, Jason Wang wrote: > > > > > > > > On 2016年10月27日 03:21, Eduardo Habkost wrote: > >> Instead of hacking custom PropertyInfo structs, use the regular > >> DEFINE_PROP_ macros for the e1000e proper

Re: [Qemu-devel] [PATCH 2/4] e1000e: No need to validate configuration on migration

2016-10-27 Thread Eduardo Habkost
On Thu, Oct 27, 2016 at 09:42:53AM +0300, Dmitry Fleytman wrote: > > > On 26 Oct 2016, at 22:21 PM, Eduardo Habkost wrote: > > > > The user (or management software) is responsible for keeping the > > same configuration on both sides while migrating. Remove the > > configuration validation code a

Re: [Qemu-devel] [PULL 00/23] M68k part1 patches

2016-10-27 Thread Peter Maydell
On 25 October 2016 at 20:02, Laurent Vivier wrote: > The following changes since commit ede0cbeb7892bdf4a19128853a3a3c61a17fb068: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-10-25' > into staging (2016-10-25 17:03:11 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PULL 00/23] M68k part1 patches

2016-10-27 Thread Laurent Vivier
Le 27/10/2016 à 13:45, Peter Maydell a écrit : > On 25 October 2016 at 20:02, Laurent Vivier wrote: >> The following changes since commit ede0cbeb7892bdf4a19128853a3a3c61a17fb068: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-10-25' >> into staging (2016-10-25 17:03:1

[Qemu-devel] [Bug 974229] Re: qemu-kvm-1.0: segfault using vnc-console => not threadsafe!

2016-10-27 Thread Thomas Huth
The QEMU versions mentioned in this ticket are quite old already ... can you still reproduce this with the latest version of QEMU? If so, please also provide the exact command line parameters that you used to start QEMU, and the steps you took afterwards to get to the crash? Thanks! ** Changed in:

Re: [Qemu-devel] [PULL 00/23] M68k part1 patches

2016-10-27 Thread Peter Maydell
On 27 October 2016 at 12:47, Laurent Vivier wrote: > > > Le 27/10/2016 à 13:45, Peter Maydell a écrit : >> On 25 October 2016 at 20:02, Laurent Vivier wrote: >>> The following changes since commit ede0cbeb7892bdf4a19128853a3a3c61a17fb068: >>> >>> Merge remote-tracking branch 'remotes/armbru/tag

[Qemu-devel] [PATCH] MAINTAINERS: update M68K entry

2016-10-27 Thread Laurent Vivier
Add myself to be the M68K maintainer. Signed-off-by: Laurent Vivier --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b01fec0..7d73748 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -133,7 +133,8 @@ F: include/hw/lm32/ F: tests/

Re: [Qemu-devel] [PATCH v2 2/2] gdbstub: Fix vCont behaviour

2016-10-27 Thread Pedro Alves
On 10/26/2016 08:56 AM, Christian Borntraeger wrote: > On 10/14/2016 01:53 PM, Claudio Imbrenda wrote: >> When GDB issues a "vCont", QEMU was not handling it correctly when >> multiple VCPUs are active. >> For vCont, for each thread (VCPU), it can be specified whether to >> single step, continue or

[Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Gerd Hoffmann
--- ui/Makefile.objs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index dc936f1..62f4cf3 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -17,6 +17,9 @@ common-obj-$(CONFIG_CURSES) += curses.o common-obj-$(CONFIG_VNC) += $(vnc-obj-y) common-ob

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v7 2/3] migration: migrate QTAILQ

2016-10-27 Thread Paolo Bonzini
On 26/10/2016 18:58, Jianjun Duan wrote: >> > >> > Seems you partially adopted Paolo's suggestion for improving the >> > macros. Is there a particular reason why you did not follow it more >> > closely? I find the solution with field_at_offset(base, offset, type) >> > more readable than with RAW

Re: [Qemu-devel] "block: use aio_bh_schedule_oneshot" breaks ibm-vscsi

2016-10-27 Thread Alexey Kardashevskiy
On 27/10/16 18:57, Paolo Bonzini wrote: > > > On 27/10/2016 05:30, Alexey Kardashevskiy wrote: >> Hi, >> >> I just discovered that fffb6e12233002c26c0ee9ff92fa87927cd779f2 broke >> ibm-vscsi, the guest booting stops (I waited for a minute) at: >> >> [0.809286] ibmvscsi 7101: SRP_VERSION:

Re: [Qemu-devel] [PATCH V2 RESEND] docs: add PCIe devices placement guidelines

2016-10-27 Thread Marcel Apfelbaum
On 10/17/2016 05:07 PM, Laszlo Ersek wrote: On 10/17/16 14:07, Gerd Hoffmann wrote: Hi, {26} Another remark (important to me) in this section: the document doesn't state firmware expectations. It's clear the firmware is expected to reserve no IO space for PCI Express Downstream Ports and Roo

[Qemu-devel] [Bug 1193628] Re: Undefined References

2016-10-27 Thread Thomas Huth
QEMU 1.1.0 is not maintained anymore, so closing this as "Won't fix". ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1193628 Title: Undefined Ref

[Qemu-devel] [Bug 1579327] Re: emulation of vexpress-a9 vexpress-a15 in multicore mode seems to be broken

2016-10-27 Thread Nicolae Rosia
I can confirm this bug with vexpress-a9. I have tested with the following versions: QEMU emulator version 2.4.1 (qemu-2.4.1-11.fc23), Copyright (c) 2003-2008 Fabrice Bellard QEMU emulator version 2.7.0, Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers Here are the reproduc

Re: [Qemu-devel] [PATCH 1/3] Add dots keypresses support to the baum braille device

2016-10-27 Thread Gerd Hoffmann
On Mi, 2016-10-26 at 17:14 +0200, Samuel Thibault wrote: > Gerd Hoffmann, on Wed 26 Oct 2016 14:37:14 +0200, wrote: > > On So, 2016-10-23 at 21:54 +0200, Samuel Thibault wrote: > > > Signed-off-by: Samuel Thibault > > > > Hmm, this one throws strange errors at me: > > > > kraxel@nilsson ~/projec

[Qemu-devel] Problems with recent char changes (mux, slirp)

2016-10-27 Thread Dr. David Alan Gilbert
Hi Marc-André, I've got a bunch of different failures in current head that seem to bisect down to your recent char changes. Lets start with the main symptoms; 1) Slirp guestfwd is broken, start an nc with: nc -l 127.0.0.1 and then qemu with: -netdev user,id=unet,guestfwd=tcp

Re: [Qemu-devel] [PATCH v2 0/3] Improve truncation behavior of memory-backend-file

2016-10-27 Thread Paolo Bonzini
On 27/10/2016 06:22, Haozhong Zhang wrote: > For a mmeory backend file, e.g. > -object memory-backend-file,mem-path=foo,size=SZ,... > the size of the backend file 'foo' is specified by the 'size' > option. If the specified size 'SZ' does not match the actual size of > file 'foo', QEMU will tr

Re: [Qemu-devel] [PATCH V2 RESEND] docs: add PCIe devices placement guidelines

2016-10-27 Thread Marcel Apfelbaum
On 10/14/2016 02:36 PM, Laszlo Ersek wrote: On 10/13/16 16:05, Marcel Apfelbaum wrote: On 10/13/2016 04:52 PM, Marcel Apfelbaum wrote: Proposes best practices on how to use PCI Express/PCI device in PCI Express based machines and explain the reasoning behind them. Signed-off-by: Marcel Apfelba

Re: [Qemu-devel] [PATCH 1/2] vus: Introduce vhost-user-scsi host device

2016-10-27 Thread Paolo Bonzini
On 26/10/2016 17:26, Felipe Franciosi wrote: > This commit introduces a vhost-user device for SCSI. This is based > on the existing vhost-scsi implementation, but done over vhost-user > instead. It also uses a chardev to connect to the backend. Unlike > vhost-scsi (today), VMs using vhost-user-sc

Re: [Qemu-devel] [PATCH] gtk: fix compilation warning with gtk 3.22.2

2016-10-27 Thread Gerd Hoffmann
On Mi, 2016-10-26 at 17:35 +0200, Alberto Garcia wrote: > On Wed 26 Oct 2016 05:21:08 PM CEST, Alberto Garcia wrote: > > +#else > > +{ > > +screen_width = gdk_screen_get_width(screen); > > +screen_height = gdk_screen_get_height(screen); > > +} > > +#endif >

Re: [Qemu-devel] [PATCH 2/2] vus: Introduce a vhost-user-scsi sample application

2016-10-27 Thread Paolo Bonzini
On 26/10/2016 17:26, Felipe Franciosi wrote: > This commit introduces a vhost-user-scsi backend sample application. It > must be linked with libiscsi and libvhost-user. > > To use it, compile with: > make tests/vhost-user-scsi > > And run as follows: > tests/vhost-user-scsi -u /tmp/vus.sock -i

[Qemu-devel] [PATCH] qemu-iotests: Fix typo for NFS with IMGOPTSSYNTAX

2016-10-27 Thread Kevin Wolf
Commit 076003f5 added configuration for NFS with IMGOPTSSYNTAX enabled, but it didn't use the right variable name: $TEST_DIR_OPTS doesn't exist. This fixes the mistake. However, this doesn't make anything work that was broken before: The only way to get IMGOPTSSYNTAX is with -luks, but the combina

Re: [Qemu-devel] [PATCH v10 07/19] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-10-27 Thread Jike Song
On 10/27/2016 05:29 AM, Kirti Wankhede wrote: > Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input > argument. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: I885fd4cd4a9f66f4ee2c1caf58267464ec239f52 > --- > drivers/vfio/vfio_iommu_type1.c | 25 ++

[Qemu-devel] [PATCH] ui/gtk: Fix non-working DELETE key

2016-10-27 Thread Thomas Huth
GTK generates key events for the delete key with key->string[0] = 0x7f ... but this does not work right with the readline_handle_byte() function in util/readline.c, since this treats the keycode 127 as backspace. So let's add a special case for the GTK delete key to make this key behave right in th

Re: [Qemu-devel] [PATCH 2/4] e1000e: No need to validate configuration on migration

2016-10-27 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Thu, Oct 27, 2016 at 09:42:53AM +0300, Dmitry Fleytman wrote: > > > > > On 26 Oct 2016, at 22:21 PM, Eduardo Habkost wrote: > > > > > > The user (or management software) is responsible for keeping the > > > same configuration on both sides whil

[Qemu-devel] [PATCH v7 1/2] raw_bsd: add offset and size options

2016-10-27 Thread Tomáš Golembiovský
Added two new options 'offset' and 'size'. This makes it possible to use only part of the file as a device. This can be used e.g. to limit the access only to single partition in a disk image or use a disk inside a tar archive (like OVA). When 'size' is specified we do our best to honour it. Signe

[Qemu-devel] [PATCH v7 0/2] Add 'offset' and 'size' options

2016-10-27 Thread Tomáš Golembiovský
v6 -> v7: - added tests v5 -> v6: - fix alignment check condition - when size is not specified and device size is being used take offset into account v4 -> v5: - added two missing overflow checks - comments from Eric Blake: - renamed 'fail' label to 'end' - fixed optional fields in JSON sch

[Qemu-devel] [PATCH v7 2/2] qemu-iotests: test 'offset' and 'size' options in raw driver

2016-10-27 Thread Tomáš Golembiovský
Signed-off-by: Tomáš Golembiovský --- tests/qemu-iotests/171 | 170 tests/qemu-iotests/171.out | 173 + tests/qemu-iotests/group | 1 + 3 files changed, 344 insertions(+) create mode 100755 tests/qem

Re: [Qemu-devel] [PATCH v10 07/19] vfio iommu type1: Update argument of vaddr_get_pfn()

2016-10-27 Thread Kirti Wankhede
On 10/27/2016 5:41 PM, Jike Song wrote: > On 10/27/2016 05:29 AM, Kirti Wankhede wrote: >> Update arguments of vaddr_get_pfn() to take struct mm_struct *mm as input >> argument. >> >> Signed-off-by: Kirti Wankhede >> Signed-off-by: Neo Jia >> Change-Id: I885fd4cd4a9f66f4ee2c1caf58267464ec239f52

Re: [Qemu-devel] [PULL 0/9] Net patches

2016-10-27 Thread Peter Maydell
On 26 October 2016 at 03:24, Jason Wang wrote: > The following changes since commit ede0cbeb7892bdf4a19128853a3a3c61a17fb068: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-10-25' > into staging (2016-10-25 17:03:11 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-10-27 Thread Kirti Wankhede
On 10/27/2016 12:50 PM, Alexey Kardashevskiy wrote: > On 18/10/16 08:22, Kirti Wankhede wrote: >> VFIO IOMMU drivers are designed for the devices which are IOMMU capable. >> Mediated device only uses IOMMU APIs, the underlying hardware can be >> managed by an IOMMU domain. >> >> Aim of this chang

Re: [Qemu-devel] [PATCH v2 16/18] target-mips: Use the new extract op

2016-10-27 Thread Yongbok Kim
On 18/10/2016 16:10, Richard Henderson wrote: > Use extract for EXT and DEXT. > > Signed-off-by: Richard Henderson > --- > target-mips/translate.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index d8

Re: [Qemu-devel] [PATCH 2/2] vus: Introduce a vhost-user-scsi sample application

2016-10-27 Thread Felipe Franciosi
Hello, > On 27 Oct 2016, at 13:16, Paolo Bonzini wrote: > > > > On 26/10/2016 17:26, Felipe Franciosi wrote: >> This commit introduces a vhost-user-scsi backend sample application. It >> must be linked with libiscsi and libvhost-user. >> >> To use it, compile with: >> make tests/vhost-user-sc

Re: [Qemu-devel] [PATCH v7 00/16] nbd: efficient write zeroes

2016-10-27 Thread Paolo Bonzini
On 14/10/2016 20:33, Eric Blake wrote: > Also available as a tag at: > git fetch git://repo.or.cz/qemu/ericb.git nbd-zero-v7 > > v5 was here, but missed 2.7 freeze: > https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg04053.html > > Since then, I've rebased the series, and the bulk of the

[Qemu-devel] [PATCH v3] ppc: allow certain HV interrupts to be delivered to guests

2016-10-27 Thread Nicholas Piggin
ppc hypervisors have delivered system reset and machine check exception interrupts to guests in some situations (e.g., see FWNMI feature of LoPAPR, or NMI injection in QEMU). These exceptions are architected to set the HV bit in hardware, however when injected into a guest, the HV bit should be cl

[Qemu-devel] [PULL v1 02/11] io: Use qio_channel_has_feature() where applicable

2016-10-27 Thread Daniel P. Berrange
From: Felipe Franciosi Parts of the code have been testing QIOChannel features directly with a logical AND. This patch makes it all consistent by using the qio_channel_has_feature() function to test if a feature is present. Signed-off-by: Felipe Franciosi Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PULL v1 00/11] Merge qio 2016/10/27

2016-10-27 Thread Daniel P. Berrange
The following changes since commit da158a86c407fa7b9da848b571356a26809d8df9: Merge remote-tracking branch 'remotes/berrange/tags/pull-qcrypto-2016-10-20-1' into staging (2016-10-20 14:46:19 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qio-2016-10-

[Qemu-devel] [PULL v1 01/11] io: Fix double shift usages on QIOChannel features

2016-10-27 Thread Daniel P. Berrange
From: Felipe Franciosi When QIOChannels were introduced in 666a3af9, the feature bits were already defined shifted. However, when using them, the code was shifting them again. The incorrect use was consistent until 74b6ce43, where QIO_CHANNEL_FEATURE_LISTEN was defined shifted but tested unshifte

[Qemu-devel] [PULL v1 06/11] io: add ability to set a name for IO channels

2016-10-27 Thread Daniel P. Berrange
The GSource object has ability to have a name, which is useful when debugging performance problems with the mainloop event callbacks that take too long. By associating a name with a QIOChannel object, we can then set the name on any GSource associated with the channel. Reviewed-by: Eric Blake Sig

  1   2   3   4   5   >