Re: [Qemu-devel] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-10-17 Thread Thomas Huth
On 14.10.2016 19:38, Peter Maydell wrote: > On 14 October 2016 at 09:27, Greg Kurz wrote: >> On Fri, 14 Oct 2016 09:28:35 +1100 >> David Gibson wrote: >> >>> On Thu, Oct 13, 2016 at 12:57:19PM +0100, Peter Maydell wrote: On 13 October 2016 at 12:54, Peter Maydell wrote: More gene

Re: [Qemu-devel] [PATCH 02/18] blockjob: introduce .drain callback for jobs

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 12:02, Stefan Hajnoczi wrote: > On Thu, Oct 13, 2016 at 07:34:06PM +0200, Paolo Bonzini wrote: >> +static void backup_drain(BlockJob *job) >> +{ >> +BackupBlockJob *s = container_of(job, BackupBlockJob, common); >> + >> +/* Need to keep a reference in case blk_drain triggers

Re: [Qemu-devel] [PATCH 07/18] block: introduce bdrv_poll_while and bdrv_wakeup

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 12:25, Stefan Hajnoczi wrote: > On Thu, Oct 13, 2016 at 07:34:11PM +0200, Paolo Bonzini wrote: >> @@ -485,9 +474,14 @@ void bdrv_inc_in_flight(BlockDriverState *bs) >> atomic_inc(&bs->in_flight); >> } >> >> +void bdrv_wakeup(BlockDriverState *bs) >> +{ >> +} > > Please writ

Re: [Qemu-devel] [PATCH 15/18] block: only call aio_poll on the current thread's AioContext

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 18:40, Stefan Hajnoczi wrote: > > void bdrv_wakeup(BlockDriverState *bs) > > { > > +if (bs->wakeup) { > > +aio_bh_schedule_oneshot(qemu_get_aio_context(), dummy_bh_cb, NULL); > > +} > > } > > Why use a dummy BH instead of aio_notify()? Originally I used aio_bh_s

Re: [Qemu-devel] [PATCH v4 10/20] ppc/xics: Make the ICSState a list

2016-10-17 Thread Cédric Le Goater
On 10/17/2016 01:53 AM, David Gibson wrote: > On Fri, Oct 14, 2016 at 09:35:46AM +0200, Cédric Le Goater wrote: >> On 10/14/2016 07:32 AM, David Gibson wrote: >>> On Mon, Oct 03, 2016 at 09:24:46AM +0200, Cédric Le Goater wrote: From: Benjamin Herrenschmidt Instead of an array of fi

Re: [Qemu-devel] [PATCH v6 00/35] cmpxchg-based emulation of atomics

2016-10-17 Thread Alex Bennée
Emilio G. Cota writes: > On Tue, Oct 11, 2016 at 14:40:26 -0500, Richard Henderson wrote: >> Sixth time is the charm, right? This time I'm certain that it >> compiles with centos6, and contains the previously missing update >> from Emilio to atomic_add-bench. > > For patches 03-16 (including th

Re: [Qemu-devel] [PATCH v4 17/20] ppc/pnv: Add cut down PSI bridge model and hookup external interrupt

2016-10-17 Thread Cédric Le Goater
On 10/17/2016 01:52 AM, David Gibson wrote: > On Fri, Oct 14, 2016 at 10:07:53AM +0200, Cédric Le Goater wrote: --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -318,15 +318,24 @@ static void ppc_powernv_reset(void) * have a CPLD that will collect the SerIRQ and shoot them as a

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Thomas Huth
On 14.10.2016 20:58, Michael Tokarev wrote: > Hi. > > This commit: c9bc3437a905b660561a26cd4ecc64579843267b > Author: Richard Henderson > Date: Tue Jun 21 17:32:12 2016 -0700 > > linux-user: Provide safe_syscall for s390x > > does not build on debian unstable porterbox for s390x, with > t

Re: [Qemu-devel] [PATCH] include/qemu: Add documentation to functions in include/qemu/id.h

2016-10-17 Thread Paolo Bonzini
On 16/10/2016 23:03, Veronia Bahaa wrote: > Add documentation to the functions id_generate and id_wellformed in > include/qemu/id.h > > Signed-off-by: Veronia Bahaa > --- > include/qemu/id.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/include/qemu/id.h

Re: [Qemu-devel] [PATCH v4 09/12] iotests.py: Add qemu_nbd function

2016-10-17 Thread Kevin Wolf
Am 15.10.2016 um 19:17 hat Max Reitz geschrieben: > On 13.10.2016 15:11, Kevin Wolf wrote: > > Am 28.09.2016 um 22:55 hat Max Reitz geschrieben: > >> Signed-off-by: Max Reitz > >> --- > >> tests/qemu-iotests/iotests.py | 8 > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/test

Re: [Qemu-devel] bug introduced by "block: Move throttling fields from BDS to BB"

2016-10-17 Thread Alberto Garcia
On Fri 14 Oct 2016 04:11:46 PM CEST, Paolo Bonzini wrote: > Here is next_throttle_token: > > -ThrottleGroup *tg = container_of(blk_bs(blk)->throttle_state, > - ThrottleGroup, ts); > +BlockBackendPublic *blkp = blk_get_public(blk); > +ThrottleGroup *tg

Re: [Qemu-devel] [PATCH v2 3/4] fdc: Move qdev properties to FloppyDrive

2016-10-17 Thread Kevin Wolf
Am 15.10.2016 um 00:32 hat John Snow geschrieben: > On 09/30/2016 03:39 PM, Kevin Wolf wrote: > >This makes the FloppyDrive qdev object actually useful: Now that it has > >all properties that don't belong to the controller, you can actually > >use '-device floppy' and get a working result. > > > >C

Re: [Qemu-devel] [PATCH] vfio: fix duplicate function call

2016-10-17 Thread Cao jin
Hi, On 10/14/2016 11:50 PM, Alex Williamson wrote: On Fri, 14 Oct 2016 19:16:59 +0800 Cao jin wrote: When vfio device is reset(encounter FLR, or bus reset), if need to do bus reset(vfio_pci_hot_reset_one is called), vfio_pci_pre_reset & vfio_pci_post_reset will be called twice. Signed-off-by

Re: [Qemu-devel] [PATCH 00/18] dataplane: remove RFifoLock (including almost all previously sent patches)

2016-10-17 Thread Christian Borntraeger
On 10/13/2016 07:34 PM, Paolo Bonzini wrote: > This patch reorganizes aio_poll callers to establish new rules for > dataplane locking. The idea is that I/O operations on a dataplane > BDS (i.e. one where the AioContext is not the main one) do not call > aio_poll anymore. Instead, they wait for th

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-17 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > On 10/14/16 10:25, Dr. David Alan Gilbert wrote: > > * Stefan Weil (s...@weilnetz.de) wrote: > > > Instead of allocating a VMStateDescription for each NIC instance, > > > the code now uses a single constant VMStateDescription for all > > > instances. That i

Re: [Qemu-devel] [PATCH v2 10/11] blockjob: refactor backup_start as backup_job_create

2016-10-17 Thread Fam Zheng
On Tue, 10/11 11:35, Kevin Wolf wrote: > > >By the way, why did we allow to add a 'bitmap' option for DriveBackup > > >without adding it to BlockdevBackup at the same time? > > > > I don't remember. I'm not sure anyone ever audited it to convince > > themselves it was a useful or safe thing to do.

[Qemu-devel] CVE-2016-5403 results in a bug

2016-10-17 Thread yue
hi, all: i apply this patch, https://git.centos.org/blob/rpms!!qemu-kvm/6078803a0db76660aef491907f795bb23ad33357/SOURCES!kvm-virtio-error-out-if-guest-exceeds-virtqueue-size.patch;jsessionid=124pfc40q9ejezgb0b5qrnv6m#L33 . but this patch always results in a bug(bug?). a vm always exits wit

Re: [Qemu-devel] [PATCH 00/18] dataplane: remove RFifoLock (including almost all previously sent patches)

2016-10-17 Thread Paolo Bonzini
> On 10/13/2016 07:34 PM, Paolo Bonzini wrote: > > This patch reorganizes aio_poll callers to establish new rules for > > dataplane locking. The idea is that I/O operations on a dataplane > > BDS (i.e. one where the AioContext is not the main one) do not call > > aio_poll anymore. Instead, they w

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-17 Thread Pradeep Jagadeesh
Hi Alberto, On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: --- a/fsdev/qemu-fsdev-opts.c +++ b/fsdev/qemu-fsdev-opts.c @@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = { }, { .name =

[Qemu-devel] [PATCH V4] colo-proxy: fix memory leak

2016-10-17 Thread Zhang Chen
Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. v3: - rebase this patch for upstream codes v2: - use traces instead of fprintf in colo-compare.c v1: - initial patch Zhang Chen (1): colo-proxy: fix memory leak net/colo-compare.c

[Qemu-devel] [PATCH V4] colo-proxy: fix memory leak

2016-10-17 Thread Zhang Chen
Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. Signed-off-by: Zhang Chen --- net/colo-compare.c| 34 +++--- net/filter-rewriter.c | 17 + net/trace-events | 1 + 3 files changed, 21 insertion

[Qemu-devel] [Bug 1634069] [NEW] Exclude keys from grab

2016-10-17 Thread Constantine
Public bug reported: Feature request: pressing every time a shortcut to release grab for switching windows/desktops is pretty annoying, especially for users of tiling WMs. QEMU have to have a way to specify keys or shortcuts (possibly something like "everything with the specified modifier key"),

Re: [Qemu-devel] invtsc + migration + TSC scaling

2016-10-17 Thread Marcelo Tosatti
On Fri, Oct 14, 2016 at 06:20:31PM -0300, Eduardo Habkost wrote: > I have been wondering: should we allow live migration with the > invtsc flag enabled, if TSC scaling is available on the > destination? TSC scaling and invtsc flag, yes. > > For reference, this is what the Intel SDM says about in

[Qemu-devel] [Bug 1634069] Re: Exclude keys from grab

2016-10-17 Thread Constantine
Alternatively/additionally it would be nice to be able to disable keys grabbing at all. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1634069 Title: Exclude keys from grab Status in QEMU: New B

[Qemu-devel] [PATCH v8 11/11] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer

2016-10-17 Thread Gonglei
This patch includes two parts: Cryptodev Backends and virtio-crypto stuff. I can maintain cryptodev backends which introduced by myself. For virtio-crypto stuff, I can share the work with Michael (The whole virtio supporter). Signed-off-by: Gonglei --- MAINTAINERS | 13 + 1 file chan

[Qemu-devel] [PATCH v8 10/11] cryptodev: introduce an unified wrapper for crypto operation

2016-10-17 Thread Gonglei
We use an opaque point to the VirtIOCryptoReq which can support different packets based on different algorithms. Signed-off-by: Gonglei --- backends/cryptodev.c | 28 ++-- hw/virtio/virtio-crypto.c | 10 +- include/sysemu/cryptodev.h | 13 +++-- 3 f

[Qemu-devel] [PATCH v8 09/11] virtio-crypto: add data queue processing handler

2016-10-17 Thread Gonglei
Introduces VirtIOCryptoReq structure to store crypto request so that we can support synchronous and asynchronous crypto operation in the future. At present, we only support cipher and algorithm chaining. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 358

[Qemu-devel] [PATCH v8 02/11] cryptodev: add symmetric algorithm operation stuff

2016-10-17 Thread Gonglei
This patch adds session operation and crypto operation stuff in the cryptodev backend, including function pointers and corresponding structures. Signed-off-by: Gonglei --- backends/cryptodev.c | 45 ++ include/sysemu/cryptodev.h | 149 ++

[Qemu-devel] [PATCH v8 01/11] cryptodev: introduce cryptodev backend interface

2016-10-17 Thread Gonglei
cryptodev backend interface is used to realize the active work for virtual crypto device. This patch only add the framework, doesn't include specific operations. Signed-off-by: Gonglei --- backends/Makefile.objs | 2 + backends/cryptodev.c | 176 +

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/1] block: improve error handling in raw_open

2016-10-17 Thread Kevin Wolf
Am 14.10.2016 um 17:59 hat Stefan Hajnoczi geschrieben: > On Tue, Oct 11, 2016 at 04:12:35PM +0200, Halil Pasic wrote: > > Make raw_open for POSIX more consistent in handling errors by setting > > the error object also when qemu_open fails. The error object was set > > generally set in case of erro

Re: [Qemu-devel] [PATCH] target-i386: Don't cpu->migratable field when filtering features

2016-10-17 Thread Ján Tomko
On Fri, Oct 14, 2016 at 04:28:14PM -0300, Eduardo Habkost wrote: When explicitly enabling unmigratable flags using "-cpu host" (e.g. "-cpu host,+invtsc"), the requested feature won't be enabled because cpu->migratable is true by default. [...] Signed-off-by: Eduardo Habkost --- target-i386

Re: [Qemu-devel] [PULL v2 19/20] trace: introduce a formal group name for trace events

2016-10-17 Thread Greg Kurz
On Thu, 13 Oct 2016 15:58:55 +0200 Paolo Bonzini wrote: > On 12/10/2016 10:47, Stefan Hajnoczi wrote: > > +def make_group_name(filename): > > +dirname = os.path.realpath(os.path.dirname(filename)) > > +basedir = os.path.join(os.path.dirname(__file__), os.pardir) > > +basedir = os.path

[Qemu-devel] [PATCH v5 0/6] tests: enable virtio tests on SPAPR

2016-10-17 Thread Laurent Vivier
This series enables virtio tests on SPAPR by starting machines using qtest_pc_boot() or qtest_spapr_boot() to use the good libqos PCI framework (pc or spapr). It adds also some byte-swapping in virtio-pci.c as PCI is always little-endian and the endianness of the virtio device depends on the endia

[Qemu-devel] [PATCH v5 1/6] tests: fix memory leak in virtio-scsi-test

2016-10-17 Thread Laurent Vivier
vs is allocated in qvirtio_scsi_pci_init() and never freed. Signed-off-by: Laurent Vivier Reviewed-by: Greg Kurz --- tests/virtio-scsi-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c index 79088bb..94d75b1 100644 --- a/tests/virtio-

[Qemu-devel] [PATCH v5 2/6] tests: don't check if qtest_spapr_boot() returns NULL

2016-10-17 Thread Laurent Vivier
qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot() and qtest_vboot() calls g_malloc(), and g_malloc() never fails: if memory allocation fails, the application is terminated. Signed-off-by: Laurent Vivier --- tests/libqos/libqos.c | 2 ++ tests/rtas-test.c | 1 - 2 files chang

[Qemu-devel] [PATCH v5 4/6] tests: rename target_big_endian() as qvirtio_is_big_endian()

2016-10-17 Thread Laurent Vivier
Move the definition to libqos/virtio.h as it must be used only with virtio functions. Add a QVirtioDevice parameter as it will be needed to know if the virtio device is using virtio 1.0 specification and thus is always little-endian (to do) Signed-off-by: Laurent Vivier Reviewed-by: Greg Kurz -

[Qemu-devel] [PATCH v5 3/6] tests: move QVirtioBus pointer into QVirtioDevice

2016-10-17 Thread Laurent Vivier
This allows to not have to pass bus and device for every virtio functions. Signed-off-by: Laurent Vivier Reviewed-by: Greg Kurz --- tests/libqos/virtio-mmio.c | 1 + tests/libqos/virtio-pci.c | 2 + tests/libqos/virtio.c | 77 +++- tests/libqos/virtio.h | 51

Re: [Qemu-devel] [PATCH v5 1/6] tests: fix memory leak in virtio-scsi-test

2016-10-17 Thread Thomas Huth
On 17.10.2016 12:30, Laurent Vivier wrote: > vs is allocated in qvirtio_scsi_pci_init() and never freed. > > Signed-off-by: Laurent Vivier > Reviewed-by: Greg Kurz > --- > tests/virtio-scsi-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/virtio-scsi-test.c b/tests/virtio-

[Qemu-devel] [PATCH v5 5/6] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests

2016-10-17 Thread Laurent Vivier
This patch replaces calls to qtest_start() and qtest_end() by calls to qtest_pc_boot() and qtest_shutdown(). This allows to initialize memory allocator and PCI interface functions. This will ease to enable virtio tests on other architectures by only adding a specific qtest_XXX_boot() (like qtest_s

Re: [Qemu-devel] [PATCH v5 2/6] tests: don't check if qtest_spapr_boot() returns NULL

2016-10-17 Thread Thomas Huth
On 17.10.2016 12:30, Laurent Vivier wrote: > qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot() > and qtest_vboot() calls g_malloc(), > and g_malloc() never fails: > if memory allocation fails, the application is terminated. > > Signed-off-by: Laurent Vivier > --- > tests/libqos/

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Michael Tokarev
17.10.2016 11:26, Thomas Huth пишет: > On 14.10.2016 20:58, Michael Tokarev wrote: >> Hi. >> >> This commit: c9bc3437a905b660561a26cd4ecc64579843267b >> Author: Richard Henderson >> Date: Tue Jun 21 17:32:12 2016 -0700 >> >> linux-user: Provide safe_syscall for s390x >> >> does not build on

[Qemu-devel] [PATCH v5 6/6] tests: enable virtio tests on SPAPR

2016-10-17 Thread Laurent Vivier
but disable MSI-X tests on SPAPR as we can't check the result (the memory region used on PC is not readable on SPAPR). Signed-off-by: Laurent Vivier --- tests/Makefile.include| 3 ++- tests/libqos/virtio-pci.c | 24 ++-- tests/virtio-9p-test.c| 12 +++- tests

[Qemu-devel] is there a way to optimize vhost of virtio-net

2016-10-17 Thread yue
hi, jasowang: according to my test , the vm's network performance is just 20% of physical ethernet, the thread of vhost easily eat up 100% cpu when under pressure. when using multi queue(two queues) the performance goes up by 50%, but it uses more threads. if we can come to a conclusion th

[Qemu-devel] [PATCH v8 08/11] virtio-crypto: add control queue handler

2016-10-17 Thread Gonglei
Realize the symmetric algorithm control queue handler, including plain cipher and chainning algorithms. Currently the control queue is used to create and close session for symmetric algorithm. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 290 +++

[Qemu-devel] [PATCH v8 07/11] virtio-crypto: set capacity of algorithms supported

2016-10-17 Thread Gonglei
Expose the capacity of algorithms supported by virtio crypto device to the frontend driver using pci configuration space. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 40 ++- include/hw/virtio/virtio-crypto.h | 11 +++ 2 files changed

[Qemu-devel] [PATCH v8 03/11] virtio-crypto: introduce virtio_crypto.h

2016-10-17 Thread Gonglei
Introduce the virtio_crypto.h which follows virtio-crypto specification. Signed-off-by: Gonglei --- include/standard-headers/linux/virtio_crypto.h | 420 + 1 file changed, 420 insertions(+) create mode 100644 include/standard-headers/linux/virtio_crypto.h diff --git a/i

[Qemu-devel] [PATCH v8 06/11] virtio-crypto-pci: add virtio crypto pci support

2016-10-17 Thread Gonglei
This patch adds virtio-crypto-pci, which is the pci proxy for the virtio crypto device. Signed-off-by: Gonglei --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-crypto-pci.c | 77 +++ hw/virtio/virtio-pci.h| 15 + 3 files changed,

[Qemu-devel] [PATCH v8 05/11] virtio-crypto: add virtio crypto device emulation

2016-10-17 Thread Gonglei
Introduce the virtio crypto realization, I'll finish the core code in the following patches. The thoughts came from virtio net realization. For more information see: http://qemu-project.org/Features/VirtioCrypto Signed-off-by: Gonglei --- hw/virtio/Makefile.objs | 1 + hw/

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Michael Tokarev
17.10.2016 13:39, Michael Tokarev wrote: > (cc is gcc 6.2.0) > > I've no idea which -march is the default and what choices are available. $ gcc -march=? gcc: error: unrecognized argument in option '-march=?' gcc: note: valid arguments to '-march=' are: g5 g6 native z10 z13 z196 z9-109 z9-ec z900

[Qemu-devel] [PATCH v8 04/11] cryptodev: introduce a new cryptodev backend

2016-10-17 Thread Gonglei
The new cryptodev backend named cryptodev-builtin, which realized by QEMU cipher APIs. These APIs can be backed by either nettle or gcrypt. Signed-off-by: Gonglei --- backends/Makefile.objs | 1 + backends/cryptodev-builtin.c | 351 +++ qemu-option

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Thomas Huth
On 17.10.2016 12:49, Michael Tokarev wrote: > 17.10.2016 13:39, Michael Tokarev wrote: > >> (cc is gcc 6.2.0) >> >> I've no idea which -march is the default and what choices are available. > > $ gcc -march=? > gcc: error: unrecognized argument in option '-march=?' > gcc: note: valid arguments to

Re: [Qemu-devel] [PATCH] include/qemu: Add documentation to functions in include/qemu/id.h

2016-10-17 Thread Markus Armbruster
Veronia Bahaa writes: > Add documentation to the functions id_generate and id_wellformed in > include/qemu/id.h > > Signed-off-by: Veronia Bahaa > --- > include/qemu/id.h | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/include/qemu/id.h b/include/qemu/id.h >

[Qemu-devel] [PATCH v8 00/11] virtio-crypto: introduce framework and device emulation

2016-10-17 Thread Gonglei
Hi, The virtio crypto is a virtual crypto device as well as a kind of virtual hardware accelerator for virtual machines. The encryption and decryption requests are placed in the data queue and handled by the real crypto accelerators finally. The second queue is the control queue used to create or

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Michael Tokarev
17.10.2016 13:53, Thomas Huth wrote: > On 17.10.2016 12:49, Michael Tokarev wrote: >> 17.10.2016 13:39, Michael Tokarev wrote: >> >>> (cc is gcc 6.2.0) >>> >>> I've no idea which -march is the default and what choices are available. >> >> $ gcc -march=? >> gcc: error: unrecognized argument in optio

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Michael Tokarev
17.10.2016 13:49, Michael Tokarev wrote: > 17.10.2016 13:39, Michael Tokarev wrote: > >> (cc is gcc 6.2.0) >> >> I've no idea which -march is the default and what choices are available. > > $ gcc -march=? > gcc: error: unrecognized argument in option '-march=?' > gcc: note: valid arguments to '-m

Re: [Qemu-devel] [PATCH v8 00/11] virtio-crypto: introduce framework and device emulation

2016-10-17 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v8 00/11] virtio-crypto: introduce framework and device emulation Type: series Message-id: 14766

Re: [Qemu-devel] Provide safe_syscall for s390x

2016-10-17 Thread Christian Borntraeger
On 10/17/2016 10:26 AM, Thomas Huth wrote: > On 14.10.2016 20:58, Michael Tokarev wrote: >> Hi. >> >> This commit: c9bc3437a905b660561a26cd4ecc64579843267b >> Author: Richard Henderson >> Date: Tue Jun 21 17:32:12 2016 -0700 >> >> linux-user: Provide safe_syscall for s390x >> >> does not bui

Re: [Qemu-devel] [PULL 00/15] Migration v2

2016-10-17 Thread Peter Maydell
On 14 October 2016 at 16:28, Juan Quintela wrote: > The following changes since commit 6aa5a3679449cdf0b6fe5a6829b22e642ded57fd: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161013-1' into > staging (2016-10-13 14:27:58 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] machine: Fix replacement of '_' by '-' in machine property names

2016-10-17 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Oct 13, 2016 at 06:44:14PM +0200, Markus Armbruster wrote: >> machine_set_property() replaces '_' by '-' in the property name. >> Except it fails to replace an initial '_'. Screwed up in commit >> b0ddb8b. Reproducer: "-M pc,__foo_bar=true" produces "Property >

Re: [Qemu-devel] [PATCH v3 1/3] exec: split cpu_exec_init()

2016-10-17 Thread Igor Mammedov
On Sat, 15 Oct 2016 00:52:47 +0200 Laurent Vivier wrote: > Put in cpu_exec_initfn() what initializes the CPU, > and let in cpu_exec_init() what adds it to the environment. s/let/leave/ > > As cpu_exec_initfn() is called by all XX_cpu_initfn() maybe add comma before "call it" > call it > directly

Re: [Qemu-devel] bug introduced by "block: Move throttling fields from BDS to BB"

2016-10-17 Thread Kevin Wolf
Am 17.10.2016 um 10:49 hat Alberto Garcia geschrieben: > On Fri 14 Oct 2016 04:11:46 PM CEST, Paolo Bonzini wrote: > > Here is next_throttle_token: > > > > -ThrottleGroup *tg = container_of(blk_bs(blk)->throttle_state, > > - ThrottleGroup, ts); > > +Block

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

2016-10-17 Thread Igor Mammedov
On Sat, 15 Oct 2016 00:52:48 +0200 Laurent Vivier wrote: > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > Remove all the cannot_destroy_with_object_finalize_yet as > unsafe references have been moved to cpu_exec_realizefn(). > (tested with QOM command provided by commit 4c315c

Re: [Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it

2016-10-17 Thread Kevin Wolf
Am 16.10.2016 um 00:30 hat Max Reitz geschrieben: > > +static InetSocketAddress *ssh_config(BDRVSSHState *s, QDict *options, > > + Error **errp) > > +{ > > +InetSocketAddress *inet = NULL; > > +QDict *addr = NULL; > > +QObject *crumpled_addr = NULL; >

Re: [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH

2016-10-17 Thread Kevin Wolf
Am 15.10.2016 um 11:04 hat Ashijeet Acharya geschrieben: > Previously posted series patches: > v1: http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg02137.html One general remark: The subject line should still include the PATCH keyword, so it should be like "[PATCH v2 0/5] Allow blockdev-

Re: [Qemu-devel] [PATCH v3 3/3] exec: call cpu_exec_exit() from a CPU unrealize common function

2016-10-17 Thread Igor Mammedov
On Sat, 15 Oct 2016 00:52:49 +0200 Laurent Vivier wrote: > As cpu_exec_exit() mirrors the cpu_exec_realizefn(), > rename it as cpu_exec_unrealizefn(). > > Create and register a cpu_common_unrealizefn() function for > the CPU device class and call cpu_exec_unrealizefn() from > this function. > >

Re: [Qemu-devel] [PATCH v5 3/6] tests: move QVirtioBus pointer into QVirtioDevice

2016-10-17 Thread Thomas Huth
On 17.10.2016 12:30, Laurent Vivier wrote: > This allows to not have to pass bus and device for every virtio functions. > > Signed-off-by: Laurent Vivier > Reviewed-by: Greg Kurz > --- > tests/libqos/virtio-mmio.c | 1 + > tests/libqos/virtio-pci.c | 2 + > tests/libqos/virtio.c | 77

Re: [Qemu-devel] [PATCH v5 4/6] tests: rename target_big_endian() as qvirtio_is_big_endian()

2016-10-17 Thread Thomas Huth
On 17.10.2016 12:30, Laurent Vivier wrote: > Move the definition to libqos/virtio.h as it must be used > only with virtio functions. > > Add a QVirtioDevice parameter as it will be needed to > know if the virtio device is using virtio 1.0 specification > and thus is always little-endian (to do) >

Re: [Qemu-devel] [PATCH v5 2/6] tests: don't check if qtest_spapr_boot() returns NULL

2016-10-17 Thread Greg Kurz
On Mon, 17 Oct 2016 12:30:20 +0200 Laurent Vivier wrote: > qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot() > and qtest_vboot() calls g_malloc(), > and g_malloc() never fails: > if memory allocation fails, the application is terminated. > > Signed-off-by: Laurent Vivier > ---

Re: [Qemu-devel] [PULL v2 0/4] Docker patches

2016-10-17 Thread Peter Maydell
On 17 October 2016 at 03:10, Fam Zheng wrote: > The following changes since commit 6aa5a3679449cdf0b6fe5a6829b22e642ded57fd: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161013-1' into > staging (2016-10-13 14:27:58 +0100) > > are available in the git repository at: > > g..

Re: [Qemu-devel] [PATCH V2 RESEND] docs: add PCIe devices placement guidelines

2016-10-17 Thread Gerd Hoffmann
Hi, > {26} Another remark (important to me) in this section: the document > doesn't state firmware expectations. It's clear the firmware is expected > to reserve no IO space for PCI Express Downstream Ports and Root Ports, > but what about MMIO? > > We discussed this at length with Alex, but I

[Qemu-devel] [PATCH/RFC] vl: add no-panic option

2016-10-17 Thread Christian Borntraeger
Some testcase will trigger a guest panic state. For testing purposes it can be useful to exit QEMU anyway. Signed-off-by: Christian Borntraeger --- qemu-options.hx | 9 + vl.c| 6 ++ 2 files changed, 15 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 0

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 03/10] arm/arm64: smp: support more than 8 cpus

2016-10-17 Thread Andrew Jones
On Tue, Aug 30, 2016 at 04:28:52PM +0200, Auger Eric wrote: > Hi Drew, > > Proper commit message? > ... also selects the vgic model corresponding to the host Sure > > Reviewed-by: Alex Bennée > > Signed-off-by: Andrew Jones > > --- > > arm/run | 19 --- > > a

[Qemu-devel] [PATCH v3 1/2] ACPI: Add IORT Structure definition

2016-10-17 Thread Eric Auger
From: Prem Mallappa ACPI Spec 6.0 introduces IO Remapping Table Structure. This patch introduces the definitions required to describe the IO relationship between the PCIe root complex and the ITS. This conforms to: "IO Remapping Table System Software on ARM Platforms", Document number: ARM DEN 0

[Qemu-devel] [PATCH v3 2/2] ARM: Virt: ACPI: Build an IORT table with RC and ITS nodes

2016-10-17 Thread Eric Auger
From: Prem Mallappa This patch builds an IORT table that features a root complex node and an ITS node. This complements the ITS description in the ACPI MADT table and allows vhost-net on ACPI guest. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger --- v2 -> v3: - used sizeof(*iort) as n

[Qemu-devel] [PATCH v3 0/2] ACPI IORT generation for ITS support

2016-10-17 Thread Eric Auger
This series completes the support of MSIs for ACPI guest featuring an ITS. It generates an ACPI IORT table which describes the IO relationship between the root complex and the ITS. This typically enables vhost-net support on such guest. The series applies on top of Drew's [PATCH 0/2] couple ITS s

Re: [Qemu-devel] [PATCH v4 09/13] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode

2016-10-17 Thread Radim Krčmář
2016-10-14 13:21+0200, Igor Mammedov: > Signed-off-by: Igor Mammedov > --- Reviewed-by: Radim Krčmář > v4: > - restore kvm_has_x2apic_api() and use it to avoid side-effects >of kvm_enable_x2apic(). x2APIC API will be enabled by iommu >if it's present or not enabled at all. > v3: > - d

Re: [Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it

2016-10-17 Thread Ashijeet Acharya
On Sun, Oct 16, 2016 at 4:00 AM, Max Reitz wrote: > On 15.10.2016 11:04, Ashijeet Acharya wrote: >> Add InetSocketAddress compatibility to SSH driver. >> >> Add a new option "server" to the SSH block driver which then accepts >> a InetSocketAddress. >> >> "host" and "port" are supported as legacy

Re: [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH

2016-10-17 Thread Ashijeet Acharya
On Mon, Oct 17, 2016 at 4:59 PM, Kevin Wolf wrote: > Am 15.10.2016 um 11:04 hat Ashijeet Acharya geschrieben: >> Previously posted series patches: >> v1: http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg02137.html > > One general remark: The subject line should still include the PATCH >

Re: [Qemu-devel] [PATCH v3 0/2] ACPI IORT generation for ITS support

2016-10-17 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v3 0/2] ACPI IORT generation for ITS support Type: series Message-id: 1476707466-14300-1-git-send

Re: [Qemu-devel] [PATCH/RFC] vl: add no-panic option

2016-10-17 Thread Paolo Bonzini
> Some testcase will trigger a guest panic state. For testing purposes > it can be useful to exit QEMU anyway. I wonder if this should be done by default *unless* -no-shutdown is provided. This would require some planning (and delay this to 2.9, in all likelihood), but it probably would be pretty

Re: [Qemu-devel] [PATCH/RFC] vl: add no-panic option

2016-10-17 Thread Christian Borntraeger
On 10/17/2016 02:50 PM, Paolo Bonzini wrote: >> Some testcase will trigger a guest panic state. For testing purposes >> it can be useful to exit QEMU anyway. > > I wonder if this should be done by default *unless* -no-shutdown is > provided. This would require some planning (and delay this to 2.9

Re: [Qemu-devel] [PULL 00/16] ppc-for-2.8 queue 20161017

2016-10-17 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161017 > > for you to fetch changes up to 357d1e3bc7d2d80e5271bc4f3ac8537e30dc8046: > > spapr: Improved placement of PCI host bridges in

Re: [Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it

2016-10-17 Thread Kevin Wolf
Am 17.10.2016 um 14:33 hat Ashijeet Acharya geschrieben: > On Sun, Oct 16, 2016 at 4:00 AM, Max Reitz wrote: > > On 15.10.2016 11:04, Ashijeet Acharya wrote: > >> Add InetSocketAddress compatibility to SSH driver. > >> > >> Add a new option "server" to the SSH block driver which then accepts > >>

Re: [Qemu-devel] [PATCH v2 0/5] linux-user: Several Mips-related patches

2016-10-17 Thread Riku Voipio
On Wed, Oct 12, 2016 at 02:30:20PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > v2 -> v3: > > - Updated commit message for patch 5. > > v1 -> v2: > > - Added patches 1 and 2. > - Omitted patch on sysfs(); this patch will be treated separately, > as it is

Re: [Qemu-devel] [PATCH/RFC] vl: add no-panic option

2016-10-17 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH/RFC] vl: add no-panic option Type: series Message-id: 1476706440-112198-1-git-send-email-borntrae...@de.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

Re: [Qemu-devel] [PATCH v3 0/2] linux-user: preadv and pwritev emulation support

2016-10-17 Thread Riku Voipio
On Tue, Oct 11, 2016 at 11:52:45AM +0200, Dejan Jovicevic wrote: > v2 -> v3: > - Changed from safe_syscall4() to safe_syscall5() to rightly fit the > kernel implementation of preadv() and pwritev(). > - Modified commit message. > > v1 -> v2: > - Being that both of these system

Re: [Qemu-devel] [kvm-unit-tests PATCH v3 06/10] arm/arm64: add initial gicv2 support

2016-10-17 Thread Andrew Jones
On Thu, Sep 01, 2016 at 12:20:06PM +0200, Auger Eric wrote: > > > On 15/07/2016 15:00, Andrew Jones wrote: > > Add some gicv2 support. This just adds init and enable > > functions, allowing unit tests to start messing with it. > > > > Signed-off-by: Andrew Jones > > --- > > arm/Makefile.common

Re: [Qemu-devel] A question about this commit "char: convert from GIOChannel to QIOChannel"

2016-10-17 Thread Paolo Bonzini
- Original Message - > From: "wangyunjian" > To: berra...@redhat.com, pbonz...@redhat.com, qemu-devel@nongnu.org > Cc: "caihe" > Sent: Monday, October 17, 2016 3:02:32 PM > Subject: A question about this commit "char: convert from GIOChannel to > QIOChannel" > > Commit 9894dc0cdcc397e

[Qemu-devel] A question about this commit "char: convert from GIOChannel to QIOChannel"

2016-10-17 Thread wangyunjian
Commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 “char: convert from GIOChannel to QIOChannel”, about the below code segment: ・・・ ・・・ @@ -3107,22 +2965,16 @@ static void tcp_chr_close(CharDriverState *chr) s->reconnect_timer = 0; } qapi_free_SocketAddress(s->addr); -if (s->f

[Qemu-devel] [PULL 03/22] linux-user: Fix mq_open() syscall support

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic Conversion of file creation flags (O_CREAT, ...) from target to host was missing. Also, this patch implements better error handling. Signed-off-by: Aleksandar Markovic Signed-off-by: Riku Voipio --- linux-user/syscall.c | 16 +--- 1 file changed, 9 inser

[Qemu-devel] [PULL 08/22] linux-user: sparc64: Use correct target SHMLBA in shmat()

2016-10-17 Thread riku . voipio
From: Peter Maydell In commit 40df8c0c0722 support was added for target-specific handling of SHMLBA. Unfortunately the sparc64-specific part of the change got lost somewhere between the patch being posted to the list and going into master: http://patchwork.ozlabs.org/patch/646980/ http://patchw

[Qemu-devel] [PULL 02/22] linux-user: Add support for ustat() syscall

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic This patch implements Qemu user mode ustat() syscall support. Syscall ustat() returns information about a mounted filesystem. Its declaration is: int ustat(dev_t dev, struct ustat *ubuf); Its Linux kernel implementation is at fs/compat.c, line 334. The Qemu implemen

[Qemu-devel] [PULL 01/22] linux-user: Add support for adjtimex() syscall

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic This patch implements Qemu user mode adjtimex() syscall support. Syscall adjtimex() reads and optionally sets parameters for a clock adjustment algorithm used in network synchonization or similar scenarios. Its declaration is: int adjtimex(struct timex *buf); The cor

[Qemu-devel] [PULL 00/22] linux-user changes

2016-10-17 Thread riku . voipio
From: Riku Voipio The following changes since commit 7bf59dfec4234e75e31b3f397374cb5bab1a5b2c: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.8-20161017' into staging (2016-10-17 12:59:54 +0100) are available in the git repository at: git://git.linaro.org/people/r

[Qemu-devel] [PULL 11/22] linux-user: Don't use alloca() for epoll_wait's epoll event array

2016-10-17 Thread riku . voipio
From: Peter Maydell The epoll event array which epoll_wait() allocates has a size determined by the guest which could potentially be quite large. Use g_try_new() rather than alloca() so that we can fail more cleanly if the guest hands us an oversize value. (ENOMEM is not a documented return value

[Qemu-devel] [PULL 07/22] linux-user: Remove a duplicate item from strace.list

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic There is a duplicate item in strace.list. It is benign, but it shouldn't be there, since it may lead to confusion and even bugs in the future. It is the only duplicate in strace.list. This patch removes it. Signed-off-by: Aleksandar Markovic Signed-off-by: Riku Voipio

[Qemu-devel] [PULL 04/22] linux-user: Fix msgrcv() and msgsnd() syscalls support

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic If syscalls msgrcv() and msgsnd() fail, they return E2BIG, EACCES, EAGAIN, EFAULT, EIDRM, EINTR, EINVAL, ENOMEM, or ENOMSG. By examining negative scenarios of these syscalls for Mips, it was established that ENOMSG does not have the same value accross all platforms, but

[Qemu-devel] [PULL 06/22] linux-user: Fix syslog() syscall support

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic There are currently several problems related to syslog() support. For example, if the second argument "bufp" of target syslog() syscall is NULL, the current implementation always returns error code EFAULT. However, NULL is a perfectly valid value for the second argument

[Qemu-devel] [PULL 09/22] linux-user: add kcmp() syscall

2016-10-17 Thread riku . voipio
From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a3e7d51..bcd97ba 100644 --- a/linux-user/syscall.

[Qemu-devel] [PULL 05/22] linux-user: Fix socketcall() syscall support

2016-10-17 Thread riku . voipio
From: Aleksandar Markovic Since not all Linux host platforms support socketcall() (most notably Intel), do_socketcall() function in Qemu's syscalls.c is implemented to mirror the corespondant implementation of socketcall() in Linux kernel, and to utilise individual socket operations that are supp

  1   2   3   4   >