Re: [Qemu-devel] [PATCH 1/2] accel: allows to select the "best" accelerator

2016-10-05 Thread Thomas Huth
On 04.10.2016 19:16, Paolo Bonzini wrote: > > > On 04/10/2016 16:18, Thomas Huth wrote: >> Using only tcg has also some disadvantages: For some tests, it's >> interesting to know whether they also work properly with KVM (e.g. >> migration tests), and only using tcg by default slows do

Re: [Qemu-devel] [PATCH V6 1/2] arm64: Add an option to turn on/off vPMU support

2016-10-05 Thread Andrew Jones
On Tue, Oct 04, 2016 at 05:38:53PM -0400, Wei Huang wrote: > This patch adds a pmu=[on/off] option to enable/disable vPMU support > in guest vCPU. This option is only available for cortex-a57/cortex-53/ > host under both TCG and KVM modes, but unavailable on ARMv7 and other > processors. It allows

Re: [Qemu-devel] [PATCH V6 2/2] arm: virt: add PMU property to mach-virt machine type

2016-10-05 Thread Andrew Jones
On Tue, Oct 04, 2016 at 05:38:54PM -0400, Wei Huang wrote: > CPU vPMU is now turned off by default, but it was ON in virt-2.7 > machine type. To solve this problem, this patch adds a PMU option > in machine state, which is used to control CPU's vPMU status. This > PMU option is not exposed to comma

Re: [Qemu-devel] [PATCH 1/2] accel: allows to select the "best" accelerator

2016-10-05 Thread Paolo Bonzini
On 05/10/2016 03:13, Michael S. Tsirkin wrote: > On Tue, Oct 04, 2016 at 07:16:49PM +0200, Paolo Bonzini wrote: >> >> >> On 04/10/2016 16:18, Thomas Huth wrote: >>> Using only tcg has also some disadvantages: For some tests, it's >>> interesting to know whether they also work properly wit

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] libqos: add PPC64 PCI support

2016-10-05 Thread Greg Kurz
On Wed, 5 Oct 2016 12:14:05 +1100 David Gibson wrote: > On Tue, Oct 04, 2016 at 08:58:35AM +0200, Greg Kurz wrote: > > On Tue, 4 Oct 2016 11:24:54 +1100 > > David Gibson wrote: > > > > > On Mon, Oct 03, 2016 at 04:03:14PM +0200, Greg Kurz wrote: > > > > On Mon, 3 Oct 2016 13:23:27 +0200 > >

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Use POWER8 by default for the pseries-2.8 machine

2016-10-05 Thread Thomas Huth
On 05.10.2016 02:07, David Gibson wrote: > On Tue, Oct 04, 2016 at 02:55:44PM +0200, Thomas Huth wrote: >> A couple of distributors are compiling their distributions >> with "-mcpu=power8" for ppc64le these days, so the user sooner >> or later runs into a crash there when not explicitely specifying

Re: [Qemu-devel] [PATCH v12 2/2] docs: Add a generic loader explanation document

2016-10-05 Thread Markus Armbruster
Alistair Francis writes: > On Tue, Oct 4, 2016 at 12:56 AM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Thu, Sep 29, 2016 at 10:36 PM, Markus Armbruster >>> wrote: Alistair Francis writes: > On Thu, Sep 29, 2016 at 2:24 AM, Markus Armbruster > wrote: >>

[Qemu-devel] [PATCH v2] hw/ppc/spapr: Use POWER8 by default for the pseries-2.8 machine

2016-10-05 Thread Thomas Huth
A couple of distributors are compiling their distributions with "-mcpu=power8" for ppc64le these days, so the user sooner or later runs into a crash there when not explicitely specifying the "-cpu POWER8" option to QEMU (which is currently using POWER7 for the "pseries" machine by default). Due to

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict' failed.", because the qdict i

Re: [Qemu-devel] [PATCH 1/2] accel: allows to select the "best" accelerator

2016-10-05 Thread Paolo Bonzini
On 05/10/2016 09:00, Thomas Huth wrote: > On 04.10.2016 19:16, Paolo Bonzini wrote: >> >> >> On 04/10/2016 16:18, Thomas Huth wrote: >>> Using only tcg has also some disadvantages: For some tests, it's >>> interesting to know whether they also work properly with KVM (e.g. >>> migratio

Re: [Qemu-devel] backup notifier fail policy

2016-10-05 Thread Kevin Wolf
Am 04.10.2016 um 18:02 hat Stefan Hajnoczi geschrieben: > On Tue, Oct 04, 2016 at 01:55:30PM +0200, Kevin Wolf wrote: > > Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: > > > On 10/04/2016 12:34 PM, Kevin Wolf wrote: > > > > Am 04.10.2016 um 11:23 hat Stefan Hajnoczi geschrieben: > > > >> O

Re: [Qemu-devel] [PATCH v4 2/3] qapi: fix crash when a parameter is missing

2016-10-05 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Calling: >> >> { "execute": "qom-set", >> "arguments": { "path": "/machine", "property": "rtc-time" } } >> >> Will crash with: >> >> qapi/qapi-visit-core.c:277: visit_type_any: Assertion `!err != !*obj' >> failed > > This is actually a

Re: [Qemu-devel] [PATCH v4 2/3] qapi: fix crash when a parameter is missing

2016-10-05 Thread Marc-André Lureau
Hi Markus - Original Message - > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Calling: > >> > >> { "execute": "qom-set", > >> "arguments": { "path": "/machine", "property": "rtc-time" } } > >> > >> Will crash with: > >> > >> qapi/qapi-visit-core.c:277: visit_type

Re: [Qemu-devel] [PATCH 1/2] migration: report an error giving the failed field

2016-10-05 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > When a field fails to load (typically due to a limit > check, or a call to a get/put) report the device and field > to give an indication of the cause. > > Signed-off-by: Dr. David Alan Gilbert > --- > migration/vmstate.

Re: [Qemu-devel] [PATCH 2/2] migration: Report values for comparisons

2016-10-05 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Report the values when a comparison fails; together with > the previous patch that prints the device and field names > this should give a good idea of why loading the migration failed. > > Signed-off-by: Dr. David Alan Gil

Re: [Qemu-devel] [PATCH 0/3] RDMA error handling

2016-10-05 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > lp: https://bugs.launchpad.net/qemu/+bug/1545052 > > The RDMA code tends to hang if the destination dies > in the wrong place; this series doesn't completely fix > that, but in cases where the destination knows there's >

Re: [Qemu-devel] [PATCH 0/3] RDMA error handling

2016-10-05 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > lp: https://bugs.launchpad.net/qemu/+bug/1545052 > > > > The RDMA code tends to hang if the destination dies > > in the wrong place; this series doesn't completely fix

Re: [Qemu-devel] [PATCH 1/3] migrate: Fix cpu-throttle-increment regression in HMP

2016-10-05 Thread Juan Quintela
Eric Blake wrote: > Commit 69ef1f3 accidentally broke migrate_set_parameter's ability > to set the cpu-throttle-increment to anything other than the > default, because it forgot to parse the user's string into an > integer. > > CC: qemu-sta...@nongnu.org > Signed-off-by: Eric Blake > --- > hmp.c

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-10-05 Thread Marcel Apfelbaum
On 10/04/2016 08:54 PM, Laine Stump wrote: On 10/04/2016 12:10 PM, Laine Stump wrote: On 10/04/2016 11:40 AM, Laszlo Ersek wrote: Small correction to your wording though: you don't want to attach the DMI-PCI bridge to the PXB device, but to the extra root bus provided by the PXB. This made

Re: [Qemu-devel] [PATCH 2/3] migrate: Share common MigrationParameters struct

2016-10-05 Thread Juan Quintela
Eric Blake wrote: > It is rather verbose, and slightly error-prone, to repeat > the same set of parameters for input (migrate-set-parameters) > as for output (query-migrate-parameters), where the only > difference is whether the members are optional. We can just > document that the optional membe

Re: [Qemu-devel] [PATCH 3/3] migrate: Use boxed qapi for migrate-set-parameters

2016-10-05 Thread Juan Quintela
Eric Blake wrote: > Now that QAPI makes it easy to pass a struct around, we don't > have to declare as many parameters or local variables. > > Signed-off-by: Eric Blake Reviewed-by: Juan Quintela NCEEE I hated that function parameters list. Thanks very much.

[Qemu-devel] [PATCH 0/3] block: Extend QMP events for anonymous BlockBackends

2016-10-05 Thread Kevin Wolf
We have two QMP events that include only a BlockBackend name and that are therefore useless with anonymous BBs. This series adds a node-name/qdev ID to them. Kevin Wolf (3): block: Add node name to BLOCK_IO_ERROR event block-backend: Remember if attached device is non-qdev block: Add qdev ID

[Qemu-devel] [PATCH 3/3] block: Add qdev ID to DEVICE_TRAY_MOVED

2016-10-05 Thread Kevin Wolf
The event currently only contains the BlockBackend name. However, with anonymous BlockBackends, this is always the empty string. Add the qdev ID (or if none was given, the QOM path) so that the user can still see which device caused the event. Event generation has to be moved from bdrv_eject() to

[Qemu-devel] [PATCH 1/3] block: Add node name to BLOCK_IO_ERROR event

2016-10-05 Thread Kevin Wolf
The event currently only contains the BlockBackend name. However, with anonymous BlockBackends, this is always the empty string. Add the node name so that the user can still see which block device caused the event. Signed-off-by: Kevin Wolf --- block/block-backend.c | 5 +++-- docs/qmp-events.tx

[Qemu-devel] [PATCH 2/3] block-backend: Remember if attached device is non-qdev

2016-10-05 Thread Kevin Wolf
Almost all block devices are qdevified by now. This allows us to go back from the BlockBackend to the DeviceState. xen_disk is the last device that is missing. We'll remember in the BlockBackend if a xen_disk is attached and can then disable any features that require going from a BB to the DeviceSt

[Qemu-devel] [PATCH] usb: fix serial generator

2016-10-05 Thread Gerd Hoffmann
snprintf return value is *not* the number of chars written into the buffer, but the number of chars needed. So in case the buffer is too small you can go alloc a bigger one and try again. But that also means you can't simply use the return value for the next snprintf call without checking beforeh

[Qemu-devel] [PATCH 2/2] nbd: add zero-init parameter

2016-10-05 Thread Denis V. Lunev
From: Denis Plotnikov When using a nbd block device, the info about necessity of prior disk zeroing could significantly improve the speed of certain operations (e.g. backups). This patch also will allow to preserve QCOW2 images during migration. Management software now may specify zero-init opti

[Qemu-devel] [PATCH 1/2] nbd: change option parsing scheme

2016-10-05 Thread Denis V. Lunev
From: Denis Plotnikov This is a preparatory commit to make code more generic. We are going to add more options in the next patch. Signed-off-by: Denis Plotnikov Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Kevin Wolf CC: Max Reitz --- block/nbd.c | 143 ++

Re: [Qemu-devel] [PATCH 0/3] migrate: simplify migrate-set-parameters

2016-10-05 Thread Juan Quintela
Eric Blake wrote: > As promised earlier today, here's a patch series to simplify how one > calls into qmp_migrate_set_parameters(). With this in place, > Ashijeet's patches for the back-compat functions would look like: > > void qmp_migrate_set_speed(int64_t valuebw, Error **errp) > { > Migra

[Qemu-devel] [PATCH 0/2] nbd: add zero-init parameter

2016-10-05 Thread Denis V. Lunev
When using a nbd block device, the info about necessity of prior disk zeroing could significantly improve the speed of certain operations (e.g. backups). This patch also will allow to preserve QCOW2 images during migration. Management software now may specify zero-init option and thus abscent area

Re: [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c

2016-10-05 Thread Juan Quintela
Ashijeet Acharya wrote: > This patch fixes the out-of-bounds check of migration parameters in > qmp_migrate_set_parameters() for cpu-throttle-initial and > cpu-throttle-increment by adding a return statement for both as they > were broken since their introduction in 2.5 via commit 1626fee. > Due t

[Qemu-devel] [Bug 1628971] Re: -netdev user: guestfwd doesn't work

2016-10-05 Thread T. Huth
Not sure whether this is really a bug or working as intended - but apparently, the server IP address from the guest point of view (before the NAT) has to be in the same subnet as the guest itself. So everything should work fine if you use something like this in your first example: -netdev 'user,i

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use bdrv_add_before_write_notifier

2016-10-05 Thread Kevin Wolf
Am 04.10.2016 um 10:49 hat Paolo Bonzini geschrieben: > Register the notifier using the specific API for block devices. > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] Virtual Machine Generation ID

2016-10-05 Thread Igor Mammedov
On Tue, 4 Oct 2016 15:51:40 -0700 Ed Swierk wrote: > On Thu, Sep 15, 2016 at 5:36 PM, Michael S. Tsirkin wrote: > > On Thu, Sep 15, 2016 at 05:23:28PM -0700, Ed Swierk wrote: > >> I'm wondering what it will take to finish up work on vmgenid. > >> > >> https://lists.gnu.org/archive/html/qemu-de

Re: [Qemu-devel] [PATCH v6 04/20] trace: convert code to use event iterators

2016-10-05 Thread Lluís Vilanova
Daniel P Berrange writes: > This converts the HMP/QMP monitor API implementations > and some internal trace control methods to use the new > trace event iterator APIs. > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Daniel P. Berrange Reviewed-by: Lluís Vilanova > --- > monitor.c

Re: [Qemu-devel] [PATCH] Postcopy vs xbzrle: Don't send xbzrle pages once in postcopy [for 2.8]

2016-10-05 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > xbzrle relies on reading pages that have already been sent > to the destination and then applying the modifications; we can't > do that in postcopy because the destination may well have > modified the page already or the p

Re: [Qemu-devel] [PATCH] usb: fix serial generator

2016-10-05 Thread Thomas Huth
On 05.10.2016 11:33, Gerd Hoffmann wrote: > snprintf return value is *not* the number of chars written into the > buffer, but the number of chars needed. So in case the buffer is too > small you can go alloc a bigger one and try again. But that also means > you can't simply use the return value f

Re: [Qemu-devel] [PATCH v6 20/20] trace: introduce a formal group name for trace events

2016-10-05 Thread Lluís Vilanova
Daniel P Berrange writes: > The declarations in the generated-tracers.h file are > assuming there's only ever going to be one instance > of this header, as they are not namespaced. When we > have one header per event group, if a single source > file needs to include multiple sets of trace events,

Re: [Qemu-devel] [PATCH 2/2] migration/postcopy: Explicitly disallow huge pages

2016-10-05 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Sep 29, 2016 at 08:09:38PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > At the moment postcopy will fail as soon as qemu tries to register > > userfault on the RAMBlock pages that are backed by hu

[Qemu-devel] [PATCH] Put the copyright information on a separate line

2016-10-05 Thread Thomas Huth
The output string QEMU with "--version" is very long, it does not fit into a normal line of a terminal window anymore. By putting the copyright information on a separate line instead, the output looks much nicer. Signed-off-by: Thomas Huth --- Note: I'm not sure whether there is a technical or l

Re: [Qemu-devel] [PATCH 0/2] nbd: add zero-init parameter

2016-10-05 Thread Paolo Bonzini
On 05/10/2016 11:33, Denis V. Lunev wrote: > When using a nbd block device, the info about necessity of prior disk > zeroing could significantly improve the speed of certain operations > (e.g. backups). > > This patch also will allow to preserve QCOW2 images during migration. > Management softwa

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > These 2 tests exhibit two qmp bugs fixed by the previous patches. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Daniel P. Berrange > Reviewed-by: Eric Blake > --- > tests/test-qemu-qmp.c | 69 > ++ > tests/Mak

Re: [Qemu-devel] [PATCH 1/2] nbd: change option parsing scheme

2016-10-05 Thread Paolo Bonzini
I reviewed this patch before noticing that the overall idea is not what Kevin suggested, so I'm sending it out anyway. Further comments from Kevin and Max might come since I am not familiar with the current conventions on parsing block device options. On 05/10/2016 11:33, Denis V. Lunev wrote: >

Re: [Qemu-devel] [PATCH 2/2] migration/postcopy: Explicitly disallow huge pages

2016-10-05 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Thu, Sep 29, 2016 at 08:09:38PM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> At the moment postcopy will fail as soon as qemu tries to register >> userfault on the RAMBlock pages that are backed by hugepages. >> However, the

Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-05 Thread Aleksandar Markovic
Yes, we could replace TARGET_NR_fadvise64 with TARGET_NR_fadvise64_64 in Mips32 syscall numbers definition list, and expect the same effect. I just prefer to leave original symbols for syscall numbers, as they are defined in kernel headers, unless there is a compelling reason not to do it. But,

Re: [Qemu-devel] [PATCH RFC] docs: add PCIe devices placement guidelines

2016-10-05 Thread Marcel Apfelbaum
On 10/04/2016 07:25 PM, Laine Stump wrote: On 10/04/2016 11:45 AM, Alex Williamson wrote: On Tue, 4 Oct 2016 15:59:11 +0100 "Daniel P. Berrange" wrote: On Mon, Sep 05, 2016 at 06:24:48PM +0200, Laszlo Ersek wrote: On 09/01/16 15:22, Marcel Apfelbaum wrote: +2.3 PCI only hierarchy +=

Re: [Qemu-devel] [RFC] Tracing guest register usage

2016-10-05 Thread Lluís Vilanova
Richard Henderson writes: > On 09/30/2016 08:13 AM, Lluís Vilanova wrote: >>> (2) an internal state change >>> to DisasContext, reflected in INDEX_op_insn_start, with no changes to any >>> TCG >>> registers. So you'll not actually be tracking eflags at all. >> >> I don't follow what you mean. A

Re: [Qemu-devel] [QEMU PATCH v5 1/6] migration: alternative way to set instance_id in SaveStateEntry

2016-10-05 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > In QOM(QEMU Object Model) migrated objects are identified with instance_id > which is calculated automatically using their path in the QOM composition > tree. For some objects, this path could change from source to target in > migration. To migrate

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > These 2 tests exhibit two qmp bugs fixed by the previous patches. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Daniel P. Berrange > > Reviewed-by: Eric Blake > > --- > > tests/test-qemu-qmp.c | 69 > > ++

Re: [Qemu-devel] [Bug 1625295] Re: qemu-arm dies with libarmmem inside ld.so.preload

2016-10-05 Thread Stu
Awesome, thanks :) On 4 October 2016 at 15:55, Peter Maydell wrote: > Now fixed in QEMU master, commit 9b6a3ea7a69959416. > > > ** Changed in: qemu >Status: In Progress => Fix Committed > > -- > You received this bug notification because you are subscribed to the bug > report. > https://

Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props

2016-10-05 Thread Christian Borntraeger
On 09/29/2016 05:23 PM, Markus Armbruster wrote: > Xiao Long Jiang writes: > >> Hi, >> >> I have tested this patch on arch s390 system. It works fine. :-) > > May I credit your help by adding > > Tested-by: Xiao Long Jiang > > to the commit message? China has a some holiday, so do not ex

Re: [Qemu-devel] [PATCH 0/2] nbd: add zero-init parameter

2016-10-05 Thread Denis V. Lunev
On 10/05/2016 12:55 PM, Paolo Bonzini wrote: > > On 05/10/2016 11:33, Denis V. Lunev wrote: >> When using a nbd block device, the info about necessity of prior disk >> zeroing could significantly improve the speed of certain operations >> (e.g. backups). >> >> This patch also will allow to preserve

[Qemu-devel] [PATCH v2 1/1] nbd: add zero-init parameter

2016-10-05 Thread Denis V. Lunev
When using a nbd block device, the info about necessity of prior disk zeroing could significantly improve the speed of certain operations (e.g. backups). This patch also will allow to preserve QCOW2 images during migration. Management software now may specify zero-init option and thus abscent area

[Qemu-devel] [Bug 1630527] [NEW] qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

2016-10-05 Thread dcb
Public bug reported: qemu/hw/i386/amd_iommu.c:188]: (error) Shifting 32-bit value by 64 bits is undefined behaviour Source code is uint64_t mask = ((1 << length) - 1) << bitpos; Maybe better code uint64_t mask = ((1ULL << length) - 1) << bitpos; ** Affects: qemu Importance: Undec

Re: [Qemu-devel] [PATCH 0/2] block: introduce and use aio_bh_schedule_oneshot

2016-10-05 Thread Kevin Wolf
Am 03.10.2016 um 18:14 hat Paolo Bonzini geschrieben: > This simplifies a bit using the bottom half API in the common > case of one-shot bottom halves, that are created once per usage. > This patch comes from the multiqueue series. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] docs/xbzrle: correction

2016-10-05 Thread Juan Quintela
Cao jin wrote: > 1. Default cache size is 64MB. > 2. Semantics correction. > > Signed-off-by: Cao jin Reviewed-by: Juan Quintela applied thanks

Re: [Qemu-devel] [Qemu-block] [PATCH] Put the copyright information on a separate line

2016-10-05 Thread Kevin Wolf
Am 05.10.2016 um 11:54 hat Thomas Huth geschrieben: > The output string QEMU with "--version" is very long, it does > not fit into a normal line of a terminal window anymore. By > putting the copyright information on a separate line instead, > the output looks much nicer. > > Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

2016-10-05 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Oct 03, 2016 at 20:42:43 +0100, Alex Bennée wrote: >> >> Richard Henderson writes: >> >> > Add all of cmpxchg, op_fetch, fetch_op, and xchg. >> > Handle both endian-ness, and sizes up to 8. >> > Handle expanding non-atomically, when emulating in serial. >> > >>

Re: [Qemu-devel] [PATCH v2 1/1] nbd: add zero-init parameter

2016-10-05 Thread Kevin Wolf
Am 05.10.2016 um 12:57 hat Denis V. Lunev geschrieben: > When using a nbd block device, the info about necessity of prior disk > zeroing could significantly improve the speed of certain operations > (e.g. backups). > > This patch also will allow to preserve QCOW2 images during migration. > Managem

Re: [Qemu-devel] [QEMU PATCH v5 2/6] migration: spapr_drc: defined VMStateDescription struct

2016-10-05 Thread Dr. David Alan Gilbert
* Jianjun Duan (du...@linux.vnet.ibm.com) wrote: > To manage hotplug/unplug of dynamic resources such as PCI cards, > memory, and CPU on sPAPR guests, a firmware abstraction known as > a Dynamic Resource Connector (DRC) is used to assign a particular > dynamic resource to the guest, and provide an

Re: [Qemu-devel] [PATCH v4 14/35] tcg: Add atomic128 helpers

2016-10-05 Thread Alex Bennée
Richard Henderson writes: > Force the use of cmpxchg16b on x86_64. > > Wikipedia suggests that only very old AMD64 (circa 2004) did not have > this instruction. Further, it's required by Windows 8 so no new cpus > will ever omit it. > > If we truely care about these, then we could check this at

Re: [Qemu-devel] [PATCH v4 16/35] tcg: Emit barriers with parallel_cpus

2016-10-05 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/tcg-op.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index cdd61d6..bb2bfee 100644 > --- a/tcg/tcg-op.c > +++ b/tcg/tcg-

Re: [Qemu-devel] [PATCH v4 25/35] target-i386: remove helper_lock()

2016-10-05 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > It's been superseded by the atomic helpers. > > The use of the atomic helpers provides a significant performance and > scalability > improvement. Below is the result of running the atomic_add-test > microbenchmark with: > $ x86_64-linux-

[Qemu-devel] [PATCH] 9pfs: allocate space for guest originated empty strings

2016-10-05 Thread Greg Kurz
From: Li Qiang If a guest sends an empty string paramater to any 9P operation, the current code unmarshals it into a V9fsString equal to { .size = 0, .data = NULL }. This is unfortunate because it can cause NULL pointer dereference to happen at various locations in the 9pfs code. And we don't wa

[Qemu-devel] [PATCH] trace: Add missing execution mode of guest events

2016-10-05 Thread Lluís Vilanova
Add missing execution mode documentation for the 'guest_cpu_enter' and 'guest_cpu_reset' events. Signed-off-by: Lluís Vilanova --- trace-events |2 ++ 1 file changed, 2 insertions(+) diff --git a/trace-events b/trace-events index 1a4e092..6764124 100644 --- a/trace-events +++ b/trace-events

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-05 Thread Amit Shah
On (Fri) 30 Sep 2016 [14:27:26], Hailiang Zhang wrote: > On 2016/9/30 13:53, Amit Shah wrote: > >In the meanwhile, can you check why the autobuilder fails to compile > >with your patchset? > > > > Yes, It was related to the 9th patch, where i used %lu to print value of > 'uint64_t' type > which

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-05 Thread Peter Maydell
On 4 October 2016 at 16:43, David Gibson wrote: > On Tue, Oct 04, 2016 at 01:36:09PM +0100, Peter Maydell wrote: >> The difficulty with this patch is that it's hard to tell whether >> it's really required, or if this is just adding an extra layer >> of byteswapping that should really be done in so

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > These 2 tests exhibit two qmp bugs fixed by the previous patches. >> > >> > Signed-off-by: Marc-André Lureau >> > Reviewed-by: Daniel P. Berrange >> > Reviewed-by: Eric Blake >> > --- >> > t

Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-05 Thread Peter Maydell
On 5 October 2016 at 03:02, Aleksandar Markovic wrote: > Yes, we could replace TARGET_NR_fadvise64 with TARGET_NR_fadvise64_64 > in Mips32 syscall numbers definition list, and expect the same effect. > I just prefer to leave original symbols for syscall numbers, as they > are defined in kernel he

Re: [Qemu-devel] [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend

2016-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2016 at 03:19:44AM +, Gonglei (Arei) wrote: > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Tuesday, October 04, 2016 12:32 AM > > Subject: Re: [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend > > > > On Wed, Sep 28,

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v4 07/13] virtio-crypto: set capacity of algorithms supported

2016-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2016 at 03:30:42AM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: virtio-...@lists.oasis-open.org > > [mailto:virtio-...@lists.oasis-open.org] > > On Behalf Of Stefan Hajnoczi > > Sent: Tuesday, October 04, 2016 5:46 PM > > Subject: [virtio-dev] Re: [PATCH

[Qemu-devel] [PATCH] tests/pxe: Use -nodefaults to speed up ppc64/ipv6 pxe test

2016-10-05 Thread Thomas Huth
SLOF is unfortunately quite slow when running with TCG, so the pxe test is also performing rather slow here. By using "-nodefaults" we can disable some devices (vscsi) that we are not interested in here, so that SLOF does not have to scan them during boot and thus starts up a little bit faster. The

Re: [Qemu-devel] backup notifier fail policy

2016-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2016 at 10:12:57AM +0200, Kevin Wolf wrote: > Am 04.10.2016 um 18:02 hat Stefan Hajnoczi geschrieben: > > On Tue, Oct 04, 2016 at 01:55:30PM +0200, Kevin Wolf wrote: > > > Am 04.10.2016 um 12:41 hat Denis V. Lunev geschrieben: > > > > On 10/04/2016 12:34 PM, Kevin Wolf wrote: > > >

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Marc-André Lureau
Hi - Original Message - -snip- > > I'd be willing to take this as is with a suitable TODO comment > explaining where we want to go with this file. Perhaps > > /* > * This program tests QMP commands that aren't interesting enough to > * warrant their own test program. > * > * TODO T

Re: [Qemu-devel] [PATCH] Put the copyright information on a separate line

2016-10-05 Thread Eric Blake
On 10/05/2016 04:54 AM, Thomas Huth wrote: > The output string QEMU with "--version" is very long, it does > not fit into a normal line of a terminal window anymore. By > putting the copyright information on a separate line instead, > the output looks much nicer. > > Signed-off-by: Thomas Huth >

[Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

2016-10-05 Thread Radim Krčmář
The MMIO based interface to APIC doesn't work well with MSIs that have upper address bits set (remapped x2APIC MSIs). A specialized interface is a quick and dirty way to avoid the shortcoming. Reviewed-by: Igor Mammedov Signed-off-by: Radim Krčmář --- v4: r-b Igor v2: change apic_send_msi() to

[Qemu-devel] [PATCH v4 0/8] intel_iommu: fix EIM

2016-10-05 Thread Radim Krčmář
v3: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg08292.html The x2APIC mode works on >=2.8 machine types with this series and <2.7 remain compatible (aka broken). If the 2.7 compatibility layer, [7/8], is deemed acceptable, then it should be squashed into [6/8] to avoid a bisection

[Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM

2016-10-05 Thread Radim Krčmář
Cluster x2APIC cannot work without KVM's x2apic API when the maximal APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we forbid other APICs and also the old KVM case with less than 9, to simplify the code. There is no point in enabling EIM in forbidden APICs, so we keep it ena

[Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in realize

2016-10-05 Thread Radim Krčmář
* there no point in configuring the device if realization is going to fail, so move the check to the beginning, * create a separate function for the check, * use error_setg() instead error_report(). Reviewed-by: Igor Mammedov Signed-off-by: Radim Krčmář --- v4: r-b Igor v3: * use error_setg [P

[Qemu-devel] [PATCH v4 5/8] intel_iommu: add OnOffAuto intr_eim as "eim" property

2016-10-05 Thread Radim Krčmář
The default (auto) emulates the current behavior. A user can now control EIM like -device intel-iommu,intremap=on,eim=off Reviewed-by: Igor Mammedov Signed-off-by: Radim Krčmář --- v4: * r-b Igor * added an example to the commit message v3: * use error_setg [Paolo] * shorten the code [Pete

[Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class()

2016-10-05 Thread Radim Krčmář
Every configuration has only up to one APIC class and we'll be extending the class with a function that can be called without an instanced object, so a direct access to the class is convenient. This patch will break compilation if some code uses apic_get_class() with CONFIG_USER_ONLY. Suggested-b

[Qemu-devel] [PATCH v4 8/8] target-i386/kvm: cache the return value of kvm_enable_x2apic()

2016-10-05 Thread Radim Krčmář
Assume that KVM would have returned the same on subsequent runs. Abstract the memoizaiton pattern into macros and call it memorize as adding the r makes it less obscure. Signed-off-by: Radim Krčmář --- v4: * changed the name to memorize [Igor] * remove useless underscores in macro arguments *

[Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type

2016-10-05 Thread Radim Krčmář
QEMU 2.7 allowed EIM even in configurations that were forbidden in the last patch because they were not working, like old KVM or userspace APIC. In order to keep backward compatibility, we again allow guests to misbehave in non-obvious ways, and make it the default for old machine types. A user c

Re: [Qemu-devel] [PATCH] tests/pxe: Use -nodefaults to speed up ppc64/ipv6 pxe test

2016-10-05 Thread Laurent Vivier
On 05/10/2016 14:52, Thomas Huth wrote: > SLOF is unfortunately quite slow when running with TCG, so > the pxe test is also performing rather slow here. By using > "-nodefaults" we can disable some devices (vscsi) that we > are not interested in here, so that SLOF does not have to > scan them dur

[Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic

2016-10-05 Thread Radim Krčmář
The MMIO interface to APIC only allowed 8 bit addresses, which is not enough for 32 bit addresses from EIM remapping. Intel stored upper 24 bits in the high MSI address, so use the same technique. The technique is also used in KVM MSI interface. Other APICs are unlikely to handle those upper bits.

Re: [Qemu-devel] [PATCH] usb: fix serial generator

2016-10-05 Thread Eric Blake
On 10/05/2016 04:33 AM, Gerd Hoffmann wrote: > snprintf return value is *not* the number of chars written into the > buffer, but the number of chars needed. So in case the buffer is too > small you can go alloc a bigger one and try again. But that also means > you can't simply use the return valu

Re: [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by reset

2016-10-05 Thread Greg Kurz
On Tue, 27 Sep 2016 11:08:53 +0100 Stefan Hajnoczi wrote: > On Mon, Sep 19, 2016 at 02:28:02PM +0100, Stefan Hajnoczi wrote: > > virtio-blk and virtio-serial need to free VirtQueueElements during device > > reset. Simply calling g_free(elem) is not enough because the scatter-gather > > list shou

Re: [Qemu-devel] [PATCH 1/2] async: add aio_bh_schedule_oneshot

2016-10-05 Thread Stefan Hajnoczi
On Mon, Oct 03, 2016 at 06:14:15PM +0200, Paolo Bonzini wrote: > qemu_bh_delete is already clearing bh->scheduled at the same time > as it's setting bh->deleted. Since it's not using any memory > barriers, there is no synchronization going on for bh->deleted, > and this makes the bh->deleted check

Re: [Qemu-devel] [PATCH v2 1/1] nbd: add zero-init parameter

2016-10-05 Thread Eric Blake
On 10/05/2016 05:57 AM, Denis V. Lunev wrote: > When using a nbd block device, the info about necessity of prior disk > zeroing could significantly improve the speed of certain operations > (e.g. backups). > > This patch also will allow to preserve QCOW2 images during migration. 'allow to' is not

Re: [Qemu-devel] [PATCH 2/2] block: use aio_bh_schedule_oneshot

2016-10-05 Thread Stefan Hajnoczi
On Mon, Oct 03, 2016 at 06:14:16PM +0200, Paolo Bonzini wrote: > This simplifies bottom half handlers by removing calls to qemu_bh_delete and > thus removing the need to stash the bottom half pointer in the opaque > datum. > > Signed-off-by: Paolo Bonzini > --- > block/archipelago.c | 5 +

Re: [Qemu-devel] [PATCH v4 29/35] target-arm: emulate SWP with atomic_xchg helper

2016-10-05 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > Message-Id: <1467054136-10430-25-git-send-email-c...@braap.org> > Signed-off-by: Richard Henderson > --- > target-arm/translate.c | 25 + > 1 file changed, 13 insertions(+), 12 dele

[Qemu-devel] [PATCH 2/2] coccinelle: use object_new_with_class() in obvious cases

2016-10-05 Thread Radim Krčmář
object_new_with_class(class) does a better job than object_new(object_class_get_name(class)), because object_class_get_name() lost the class->type and object_new() looked it up again from the name. Manually changed vl.c to fit into 80 character line. Signed-off-by: Radim Krčmář --- hw/arm/exyno

[Qemu-devel] [PATCH 0/2] qom+coccinelle: add and use object_new_with_class()

2016-10-05 Thread Radim Krčmář
This series performs a simple replacement of object_new(object_class_get_name(class)) by object_new_with_class(class) in the spirit of existing object_new_with_type(). Cc: Igor Mitsyanko Cc: Peter Maydell Cc: Rob Herring Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: "Andreas Färber" Cc:

[Qemu-devel] [PATCH 1/2] qom: add object_new_with_class()

2016-10-05 Thread Radim Krčmář
object_new_with_object_class() was a close contender for the name, but it is longer, the type system will catch possible errors, and the only reasonable replacement would be a polymorphic function that would not break existing users. Signed-off-by: Radim Krčmář --- include/qom/object.h | 12

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 16/17] docs: Add documentation for COLO feature

2016-10-05 Thread Eric Blake
On 09/29/2016 03:46 AM, zhanghailiang wrote: > Introduce the design of COLO, and how to test it. > > Signed-off-by: zhanghailiang > --- > docs/COLO-FT.txt | 190 > +++ > 1 file changed, 190 insertions(+) > create mode 100644 docs/COLO-FT.txt

Re: [Qemu-devel] [PATCH v4 27/35] target-arm: Rearrange aa32 load and store functions

2016-10-05 Thread Alex Bennée
Richard Henderson writes: > Stop specializing on TARGET_LONG_BITS == 32; unconditionally allocate > a temp and expand with tcg_gen_extu_i32_tl. Split out gen_aa32_addr, > gen_aa32_frob64, gen_aa32_ld_i32 and gen_aa32_st_i32 as separate interfaces. > > Signed-off-by: Richard Henderson Reviewed

Re: [Qemu-devel] [PATCH v4 28/35] target-arm: emulate LL/SC using cmpxchg helpers

2016-10-05 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Emulating LL/SC with cmpxchg is not correct, since it can > suffer from the ABA problem. Portable parallel code, however, > is written assuming only cmpxchg--and not LL/SC--is available. > This means that in practice emulating LL/SC with cm

Re: [Qemu-devel] [PATCH v2 02/11] blockjob: centralize QMP event emissions

2016-10-05 Thread Kevin Wolf
Am 01.10.2016 um 00:00 hat John Snow geschrieben: > There's no reason to leave this to blockdev; we can do it in blockjobs > directly and get rid of an extra callback for most users. > > Signed-off-by: John Snow > --- > blockdev.c | 37 ++--- > blockjob.c | 16 +++

[Qemu-devel] [PULL 03/15] migration/rdma: Pass qemu_file errors across link

2016-10-05 Thread Juan Quintela
From: "Dr. David Alan Gilbert" If we fail for some reason (e.g. a mismatched RAMBlock) and it's set the qemu_file error flag, pass that error back to the peer so it can clean up rather than waiting for some higher level progress. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael R. Hin

[Qemu-devel] [PULL 04/15] migration: Make failed migration load set file error

2016-10-05 Thread Juan Quintela
From: "Dr. David Alan Gilbert" If an error occurs in a section load, set the file error flag so that the transport can get notified to do a cleanup. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael R. Hines Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/save

  1   2   3   >