Eric Blake <ebl...@redhat.com> wrote:
> As promised earlier today, here's a patch series to simplify how one
> calls into qmp_migrate_set_parameters(). With this in place,
> Ashijeet's patches for the back-compat functions would look like:
>
> void qmp_migrate_set_speed(int64_t valuebw, Error **errp)
> {
> MigrationParameters *p = {
> .has_max_bandwidth = true,
> .max_bandwidth = valuebw,
> };
> qmp_migrate_set_parameters(&p, errp);
> }
>
> This series is a net reduction in lines, so it has to be good, right? :)
it is always nice. Especially because they were ugly lines.
Applied.
>
> Oh, and I found (and fixed) a 2.7 regression while touching this stuff.
>
> Eric Blake (3):
> migrate: Fix cpu-throttle-increment regression in HMP
> migrate: Share common MigrationParameters struct
> migrate: Use boxed qapi for migrate-set-parameters
>
> qapi-schema.json | 86
> +++++++++++++++++----------------------------------
> hmp.c | 50 ++++++++++++++++--------------
> migration/migration.c | 72 ++++++++++++++++++++----------------------
> 3 files changed, 88 insertions(+), 120 deletions(-)
