[Qemu-devel] [PATCH v2 1/6] libqos: add PPC64 PCI support

2016-09-27 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- tests/Makefile.include | 1 + tests/libqos/pci-pc.c| 22 tests/libqos/pci-spapr.c | 280 +++ tests/libqos/pci-spapr.h | 17 +++ tests/libqos/pci.c | 22 +++- tests/libqos/rtas.c | 45

[Qemu-devel] [PATCH v2 5/6] qtest: define target cpu endianness conversion function

2016-09-27 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- tests/libqtest.h | 57 1 file changed, 57 insertions(+) diff --git a/tests/libqtest.h b/tests/libqtest.h index 4be1f77..4c47f2d 100644 --- a/tests/libqtest.h +++ b/tests/libqtest.h @@ -17,6 +17,7 @@ #ifnd

[Qemu-devel] [PATCH v2 6/6] tests: enable ohci/uhci/xhci tests on PPC64

2016-09-27 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- tests/Makefile.include| 8 +++- tests/libqos/usb.c| 2 +- tests/usb-hcd-uhci-test.c | 24 3 files changed, 24 insertions(+), 10 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index bca2cbc..41

[Qemu-devel] [PATCH v2 4/6] qtest: evaluate endianness of the target in qtest_init()

2016-09-27 Thread Laurent Vivier
This allows to store it and not have to rescan the list each time we need it. Signed-off-by: Laurent Vivier --- tests/libqos/virtio-pci.c | 2 +- tests/libqtest.c | 96 +-- tests/libqtest.h | 16 ++-- tests/virtio-blk-test.c |

[Qemu-devel] [PATCH 2/2] migration: Report values for comparisons

2016-09-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Report the values when a comparison fails; together with the previous patch that prints the device and field names this should give a good idea of why loading the migration failed. Signed-off-by: Dr. David Alan Gilbert --- migration/vmstate.c | 8 1 file

[Qemu-devel] [PATCH v2 2/6] libqos: add PCI management in qtest_vboot()/qtest_shutdown()

2016-09-27 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- tests/e1000e-test.c | 2 +- tests/i440fx-test.c | 2 +- tests/ide-test.c| 2 +- tests/ivshmem-test.c| 2 +- tests/libqos/ahci.c | 2 +- tests/libqos/libqos-pc.c| 5 - tests/libqos/libqos-spapr.c | 5 -

[Qemu-devel] [PATCH 0/2] Add error reporting in migration

2016-09-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" At the moment if you use a VMSTATE_*_EQUAL macro and the value doesn't match you just get an error about the section that failed e.g. qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu' qemu-system-ppc64: load of migration failed: Inva

[Qemu-devel] [PATCH v2 3/6] libqos: use generic qtest_shutdown()

2016-09-27 Thread Laurent Vivier
Machine specific shutdown function can be registered by the machine specific qtest_XXX_boot() if needed. So we will not have to test twice the architecture (on boot and on shutdown) if the test can be run on several architectures. Signed-off-by: Laurent Vivier --- tests/libqos/libqos-pc.c|

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

2016-09-27 Thread Denis V. Lunev
On 09/27/2016 08:04 PM, Paolo Bonzini wrote: > > On 27/09/2016 15:28, Denis V. Lunev wrote: >> On 09/27/2016 03:07 PM, Paolo Bonzini wrote: >>> - Original Message - From: "Denis V. Lunev" To: "Paolo Bonzini" Cc: "Vladimir Sementsov-Ogievskiy" , qemu-devel@nongnu.org,

Re: [Qemu-devel] [PATCH 09/18] target-riscv: Add FMADD, FMSUB, FNMADD, FNMSUB Instructions,

2016-09-27 Thread Richard Henderson
On 09/26/2016 03:56 AM, Sagar Karandikar wrote: > +/* adapted from Spike's decode.h:set_fp_exceptions */ > +#define set_fp_exceptions() do { \ > +env->csr[CSR_FFLAGS] |= > softfloat_flags_to_riscv(get_float_exception_flags(\ > +&env->fp_status)); \ > +set_float_

Re: [Qemu-devel] [PATCH v2 0/6] tests: enable ohci/uhci/xhci tests on PPC64

2016-09-27 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1475002559-392-1-git-send-email-lviv...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/6] tests: enable ohci/uhci/xhci tests on PPC64 === TEST SCRIPT BEGIN === #!/bin/bash BAS

Re: [Qemu-devel] [PATCH 08/18] target-riscv: Add Atomic Instructions

2016-09-27 Thread Richard Henderson
On 09/26/2016 03:56 AM, Sagar Karandikar wrote: > +static inline void gen_atomic(DisasContext *ctx, uint32_t opc, > + int rd, int rs1, int rs2) > +{ > +/* TODO: handle aq, rl bits? - for now just get rid of them: */ > +opc = MASK_OP_ATOMIC_NO_AQ_RL(opc); We have alread

Re: [Qemu-devel] 9p as rootfs

2016-09-27 Thread mar.krzeminski
So for some reason kernel expect that 9pfs channel will be named /dev/root (root= seem to be ignored). Working command line: Kernel: /root=/dev/root rootfstype=9p rootflags=trans=virtio rw/ Qemu: /-device virtio-9p-device,fsdev=host_fs,mount_tag=/dev/root -fsdev local,id=host_fs,security_model=

Re: [Qemu-devel] [PATCH v3 1/3] qemu-nbd: Add --fork option

2016-09-27 Thread Max Reitz
On 27.09.2016 11:04, Kevin Wolf wrote: > Am 25.08.2016 um 18:30 hat Max Reitz geschrieben: >> Using the --fork option, one can make qemu-nbd fork the worker process. >> The original process will exit on error of the worker or once the worker >> enters the main loop. >> >> Suggested-by: Sascha Silbe

Re: [Qemu-devel] [PULL 00/18] Block layer patches

2016-09-27 Thread Peter Maydell
On 27 September 2016 at 06:53, Kevin Wolf wrote: > The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2016-09-26 19:47:00 +0100) > > are available in the git repository at: > > > git://r

Re: [Qemu-devel] [PATCH v2 3/7] block/qapi: Move 'aio' option to file driver

2016-09-27 Thread Max Reitz
On 27.09.2016 10:20, Kevin Wolf wrote: > Am 26.09.2016 um 18:49 hat Max Reitz geschrieben: >> On 23.09.2016 16:32, Kevin Wolf wrote: >>> The option whether or not to use a native AIO interface really isn't a >>> generic option for all drivers, but only applies to the native file >>> protocols. This

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > > > I assume that if using Version 1 that the bit will be ignored > > Yes, but I will just quo

Re: [Qemu-devel] [PATCH 6/7] target-i386: xsave: Calculate set of xsave components on realize

2016-09-27 Thread Eduardo Habkost
On Fri, Sep 23, 2016 at 04:45:35PM -0300, Eduardo Habkost wrote: [...] > @@ -2971,6 +2952,29 @@ static void x86_cpu_adjust_feat_level(X86CPU *cpu, > FeatureWord w) > } > } > > +/* Calculate XSAVE components based on the configured CPU feature flags */ > +static void x86_cpu_enable_xsave_co

[Qemu-devel] [PULL 00/20] x86 and machine queue, 2016-09-27

2016-09-27 Thread Eduardo Habkost
The following changes since commit 333ec4ca6a9f604331e2349cb91e9635f65d6462: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2016-09-27 16:23:08 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request for y

[Qemu-devel] [PULL 02/20] target-i386: Add a marker to end of the region zeroed on reset

2016-09-27 Thread Eduardo Habkost
Instead of using cpuid_level, use an empty struct as a marker (like we already did with {start,end}_init_save). This will avoid accidentaly resetting the wrong fields if we change the field ordering on CPUX86State. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cp

[Qemu-devel] [PULL 06/20] target-i386: Enable CPUID[0x8000000A] if SVM is enabled

2016-09-27 Thread Eduardo Habkost
SVM needs CPUID[0x800A] to be available. So if SVM is enabled in a CPU model or explicitly in the command-line, adjust CPUID xlevel to expose the CPUID[0x800A] leaf. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 tests/test-x86

[Qemu-devel] [PULL 10/20] target-i386: xsave: Calculate enabled components only once

2016-09-27 Thread Eduardo Habkost
Instead of checking both env->features and ena_mask at two different places in the CPUID code, initialize ena_mask based on the features that are enabled for the CPU, and then clear unsupported bits based on kvm_arch_get_supported_cpuid(). The results should be exactly the same, but it will make i

[Qemu-devel] [PULL 03/20] tests: Add test code for CPUID level/xlevel handling

2016-09-27 Thread Eduardo Habkost
Add test code that will check if the automatic CPUID level changes are working as expected. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- tests/.gitignore | 1 + tests/Makefile.include| 2 + tests/test-x86-cpuid-compat.c | 108 +++

[Qemu-devel] [PULL 01/20] target-i386: Remove unused X86CPUDefinition::xlevel2 field

2016-09-27 Thread Eduardo Habkost
No CPU model in builtin_x86_defs has xlevel2 set, so it is always zero. Delete the field. Note that this is not an user-visible change. It doesn't remove the ability to set xlevel2 on the command-line, it just removes an unused field in builtin_x86_defs. Reviewed-by: Richard Henderson Signed-off

[Qemu-devel] [PULL 07/20] linux-user: remove #define smp_{cores, threads}

2016-09-27 Thread Eduardo Habkost
From: Marc-André Lureau Those are unneeded now that CPUState nr_{cores,threads} is always initialized. Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Acked-by: David Gibson Signed-off-by: Eduardo Habkost --- include/sysemu/cpus.h | 5 + target-i386/cpu.c |

[Qemu-devel] [PULL 15/20] target-i386: Remove has_msr_mtrr global variable

2016-09-27 Thread Eduardo Habkost
The global variable is not necessary because we can check the CPU feature flags directly. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index a0e42

[Qemu-devel] [PULL 11/20] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX, EDX} calculation

2016-09-27 Thread Eduardo Habkost
Instead of assigning individual bits in a loop, just copy the values from ena_mask. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9968581

[Qemu-devel] [PULL 05/20] target-i386: Automatically set level/xlevel/xlevel2 when needed

2016-09-27 Thread Eduardo Habkost
Instead of requiring users and management software to be aware of required CPUID level/xlevel/xlevel2 values for each feature, automatically increase those values when features need them. This was already done for CPUID[7].EBX, and is now made generic for all CPUID feature flags. Unit test include

[Qemu-devel] [PULL 04/20] tests: Test CPUID level handling for old machines

2016-09-27 Thread Eduardo Habkost
We're going to change the way level/xlevel/xlevel2 are handled when enabling features, but we need to keep the old behavior on existing machine types. Add test cases for that. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- tests/test-x86-cpuid-compat.c | 13 + 1 f

[Qemu-devel] [PULL 09/20] target-i386: Don't try to enable PT State xsave component

2016-09-27 Thread Eduardo Habkost
The code that calculates the set of supported XSAVE components on CPUID looks at ext_save_areas to find out which components should be enabled. However, if there are zeroed entries in the ext_save_areas array, the ((env->features[esa->feature] & esa->bits) == esa->bits) check will always succeed

[Qemu-devel] [PULL 08/20] target-i386: Move feature name arrays inside FeatureWordInfo

2016-09-27 Thread Eduardo Habkost
It makes it easier to guarantee the arrays are the right size, and to find information when looking at the code. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 370 +- 1 file changed, 170 insertions(+), 2

[Qemu-devel] [PULL 18/20] target-i386: Clear KVM CPUID features if KVM is disabled

2016-09-27 Thread Eduardo Habkost
This will ensure all checks for features[FEAT_KVM] in the code will be correct in case the KVM CPUID leaf is completely disabled. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target-i386/cpu.c b/target-i3

[Qemu-devel] [PULL 20/20] sysbus: Remove ignored return value of FindSysbusDeviceFunc

2016-09-27 Thread Eduardo Habkost
From: David Gibson Functions of type FindSysbusDeviceFunc currently return an integer. However, this return value is always ignored by the caller in find_sysbus_device(). This changes the function type to return void, to avoid confusion over the function semantics. Signed-off-by: David Gibson

[Qemu-devel] [PULL 12/20] target-i386: xsave: Helper function to calculate xsave area size

2016-09-27 Thread Eduardo Habkost
Move the xsave area size calculation from cpu_x86_cpuid() inside its own function. While doing it, change it to use the XSAVE area struct sizes for the initial size, instead of the magic 0x240 number. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22 +

[Qemu-devel] [PULL 13/20] target-i386: xsave: Calculate set of xsave components on realize

2016-09-27 Thread Eduardo Habkost
Instead of doing complex calculations and calling kvm_arch_get_supported_cpuid() inside cpu_x86_cpuid(), calculate the set of required XSAVE components earlier, at realize time. Signed-off-by: Eduardo Habkost Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cpu.c |

[Qemu-devel] [PULL 16/20] target-i386: Remove has_msr_hv_apic global variable

2016-09-27 Thread Eduardo Habkost
The global variable is not necessary because we can check cpu->hyperv_vapic directly. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 5118562..

[Qemu-devel] [PULL 14/20] target-i386: Move xsave component mask to features array

2016-09-27 Thread Eduardo Habkost
This will reuse the existing check/enforce logic in x86_cpu_filter_features() to check the xsave component bits against GET_SUPPORTED_CPUID. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 42 -- target-i386/cpu.h |

[Qemu-devel] [PULL 17/20] target-i386: Remove has_msr_hv_tsc global variable

2016-09-27 Thread Eduardo Habkost
The global variable is not necessary because we can check cpu->hyperv_time directly. We just need to ensure cpu->hyperv_time will be cleared if the feature is not really being exposed to the guest due to missing KVM_CAP_HYPERV_TIME capability. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Ha

[Qemu-devel] [PULL 19/20] target-i386: Remove has_msr_* global vars for KVM features

2016-09-27 Thread Eduardo Habkost
The global variables are not necessary because we can check KVM feature flags in X86CPU directly. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/target-i386/kvm.c b/target

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-27 Thread Eduardo Habkost
On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote: > On 09/22/2016 01:42 PM, Eduardo Habkost wrote: [...] > > In the case of the inject-nmi QMP command, I need to understand > > what "default CPU" is supposed to mean in the inject-nmi > > documentation. Maybe it can be changed to use th

Re: [Qemu-devel] [PATCH v2 7/9] util/qht: atomically set b->hashes

2016-09-27 Thread Alex Bennée
Emilio G. Cota writes: > On Thu, Sep 22, 2016 at 11:13:14 +0100, Alex Bennée wrote: >> ThreadSanitizer detects a possible race between reading/writing the >> hashes. As ordering semantics are already documented for qht we just >> need to ensure a race can't tear the hash value so we can use the

Re: [Qemu-devel] url http://git.qemu.org/git/qemu.git no longer works

2016-09-27 Thread Jeff Cody
On Tue, Sep 27, 2016 at 02:24:22PM -0400, James Hanley wrote: > > On Sep 27, 2016, at 2:16 PM, Jeff Cody wrote: > > > >> On Tue, Sep 27, 2016 at 12:17:31PM -0400, James Hanley wrote: > >> Well - it's acting differently... It just hangs now... > > > > Let it run a bit longer, it most likely is

Re: [Qemu-devel] Default CPU for NMI injection (QMP and IPMI)

2016-09-27 Thread Christian Borntraeger
On 09/27/2016 10:51 PM, Eduardo Habkost wrote: > On Thu, Sep 22, 2016 at 02:49:35PM -0500, Corey Minyard wrote: >> On 09/22/2016 01:42 PM, Eduardo Habkost wrote: > [...] >>> In the case of the inject-nmi QMP command, I need to understand >>> what "default CPU" is supposed to mean in the inject-nmi

Re: [Qemu-devel] [PATCH 0/2] Add error reporting in migration

2016-09-27 Thread John Snow
On 09/27/2016 02:56 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" At the moment if you use a VMSTATE_*_EQUAL macro and the value doesn't match you just get an error about the section that failed e.g. qemu-system-ppc64: error while loading state for instance 0x0 of

Re: [Qemu-devel] [PATCH v14 01/19] qdict: implement a qdict_crumple method for un-flattening a dict

2016-09-27 Thread Eric Blake
On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: > The qdict_flatten() method will take a dict whose elements are > further nested dicts/lists and flatten them by concatenating > keys. > > The qdict_crumple() method aims to do the reverse, taking a flat > qdict, and turning it into a set of neste

[Qemu-devel] [PATCH 2/2] target-microblaze: Cleanup dec_mul

2016-09-27 Thread Richard Henderson
Use tcg_gen_mul_tl for muli and mul instructions. Use tcg_gen_muls2_tl for mulh instruction. Use tcg_gen_mulu2_tl for mulhu instruction. Use tcg_gen_mulsu2_tl for mulhsu instruction. Note that this last fixes a bug, in that mulhsu was previously treating both operands as signed, instead of treatin

[Qemu-devel] [PATCH 0/2] tcg: Add tcg_gen_mulsu2_*

2016-09-27 Thread Richard Henderson
While reviewing the recent riscv patch set, I made a suggestion to copy some of the bits from tcg_gen_muls2_i64 in order to implement the mulhsu instruction. However, I noticed that the same operation is present in another target, so I thought that it would be better to have this as a standard ope

[Qemu-devel] [PATCH 1/2] tcg: Add tcg_gen_mulsu2_{i32,i64,tl}

2016-09-27 Thread Richard Henderson
This multiply has one signed input and one unsigned input, producing the full double-width result. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 43 +++ tcg/tcg-op.h | 4 2 files changed, 47 insertions(+) diff --git a/tcg/tcg-op.c b/tcg/tcg-op

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-27 Thread Paolo Bonzini
- Original Message - > From: "Radim Krčmář" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "Peter Xu" , "Igor Mammedov" > , "Richard Henderson" > , "Eduardo Habkost" , "Michael S. > Tsirkin" > Sent: Tuesday, September 27, 2016 4:01:39 PM > Subject: Re: [PATCH 5/5] intel_iommu: do

Re: [Qemu-devel] [PATCH v14 03/19] option: allow qemu_opts_to_qdict to merge repeated options

2016-09-27 Thread Eric Blake
On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: > If given an option string such as > > size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind > > the qemu_opts_to_qdict() method will currently overwrite > the values for repeated option keys, so only the last > value is in the returned dict: > >

Re: [Qemu-devel] [PATCH v14 04/19] qapi: add trace events for visitor

2016-09-27 Thread Eric Blake
On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: > Allow tracing of the operation of visitors Ooooh, shiny! > > Signed-off-by: Daniel P. Berrange > --- > Makefile.objs | 1 + > qapi/qapi-visit-core.c | 27 +++ > qapi/trace-events | 33 +++

Re: [Qemu-devel] [PATCH v14 07/19] qapi: don't pass two copies of TestInputVisitorData to tests

2016-09-27 Thread Eric Blake
On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: > The input_visitor_test_add() method was accepting an instance > of 'TestInputVisitorData' and passing it as the 'user_data' > parameter to test functions. The main 'TestInputVisitorData' > instance that was actually used, was meanwhile being alloc

Re: [Qemu-devel] [PATCH v14 07/19] qapi: don't pass two copies of TestInputVisitorData to tests

2016-09-27 Thread Eric Blake
On 09/27/2016 05:10 PM, Eric Blake wrote: > On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: >> The input_visitor_test_add() method was accepting an instance >> of 'TestInputVisitorData' and passing it as the 'user_data' >> parameter to test functions. The main 'TestInputVisitorData' >> instance t

Re: [Qemu-devel] Making cputlb.c operations safe for MTTCG

2016-09-27 Thread Alex Bennée
Paolo Bonzini writes: > On 02/08/2016 08:37, Alex Bennée wrote: >>> - in notdirty_mem_write, care must be put in the ordering of >>> tb_invalidate_phys_page_fast (which itself calls tlb_unprotect_code and >>> takes the tb_lock in tb_invalidate_phys_page_range) and tlb_set_dirty. >>> At least it

Re: [Qemu-devel] [PATCH v3] ide: Fix memory leak in ide_register_restart_cb()

2016-09-27 Thread John Snow
On 09/27/2016 12:53 PM, Ashijeet Acharya wrote: Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which

Re: [Qemu-devel] Making cputlb.c operations safe for MTTCG

2016-09-27 Thread Emilio G. Cota
On Tue, Sep 27, 2016 at 18:16:45 +0200, Paolo Bonzini wrote: > Anyhow, the next step is to merge either cmpxchg-based atomics > or iothread-free single-threaded TCG. Either will do. :) > > I think that even iothread-free single-threaded TCG requires this > TLB stuff, because the iothread's addres

Re: [Qemu-devel] Making cputlb.c operations safe for MTTCG

2016-09-27 Thread Alex Bennée
Emilio G. Cota writes: > On Tue, Sep 27, 2016 at 18:16:45 +0200, Paolo Bonzini wrote: >> Anyhow, the next step is to merge either cmpxchg-based atomics >> or iothread-free single-threaded TCG. Either will do. :) >> >> I think that even iothread-free single-threaded TCG requires this >> TLB stuf

Re: [Qemu-devel] Making cputlb.c operations safe for MTTCG

2016-09-27 Thread Richard Henderson
On 09/27/2016 03:29 PM, Emilio G. Cota wrote: What's a quick-and-dirty way to disable the fast-path TLB lookups? Alex: you told me the monitor has an option for this, but I can't find it. I'm looking for something that'd go in tcg/i386 to simply bypass the fast path. There is no easy way. If y

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-27 Thread Stephen Hemminger
On Tue, 27 Sep 2016 11:11:58 +0800 Yuanhan Liu wrote: > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > > > I assume that if using Version 1 that the bit will be ignored > > Yes, but I will just quot

[Qemu-devel] [PATCH 4/7] nios2: Add IIC interrupt controller emulation

2016-09-27 Thread Marek Vasut
From: Chris Wulff Add the Altera Nios2 internal interrupt controller model. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- hw/intc/Makefile.objs | 1 + hw/intc/nios2_iic.c | 103 +

[Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-09-27 Thread Marek Vasut
From: Chris Wulff Add the Altera timer model. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- hw/timer/Makefile.objs | 1 + hw/timer/altera_timer.c | 236 2 fil

[Qemu-devel] [PATCH 7/7] nios2: Add support for Nios-II R1

2016-09-27 Thread Marek Vasut
Add remaining bits of the Altera NiosII R1 support into qemu, which is documentation, MAINTAINERS file entry, configure bits, arch_init and configuration files for both linux-user (userland binaries) and softmmu (hardware emulation). Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva

Re: [Qemu-devel] [PULL 00/20] x86 and machine queue, 2016-09-27

2016-09-27 Thread Peter Maydell
On 27 September 2016 at 13:12, Eduardo Habkost wrote: > The following changes since commit 333ec4ca6a9f604331e2349cb91e9635f65d6462: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2016-09-27 16:23:08 +0100) > > are available in the git repository at: >

[Qemu-devel] [PATCH 3/7] nios2: Add usermode binaries emulation

2016-09-27 Thread Marek Vasut
Add missing bits for qemu-user required for emulating Altera Nios2 userspace binaries. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- include/elf.h | 2 + linux-user/elfload.c |

Re: [Qemu-devel] Making cputlb.c operations safe for MTTCG

2016-09-27 Thread Alex Bennée
Richard Henderson writes: > On 09/27/2016 03:29 PM, Emilio G. Cota wrote: >> What's a quick-and-dirty way to disable the fast-path TLB lookups? >> Alex: you told me the monitor has an option for this, but I can't >> find it. I'm looking for something that'd go in tcg/i386 to simply >> bypass the

[Qemu-devel] [PATCH 6/7] nios2: Add Altera 10M50 GHRD emulation

2016-09-27 Thread Marek Vasut
Add the Altera 10M50 Nios2 GHRD model. This allows emulating the 10M50 development kit with the Nios2 GHRD loaded in the FPGA. It is possible to boot Linux kernel and run userspace, thus far only from initrd as storage support is not yet implemented. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc

[Qemu-devel] [PATCH 2/7] nios2: Add architecture emulation support

2016-09-27 Thread Marek Vasut
From: Chris Wulff Add support for emulating Altera NiosII R1 architecture into qemu. This patch is based on previous work by Chris Wulff from 2012 and updated to latest mainline QEMU. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves

[Qemu-devel] [PATCH V2 1/7] nios2: Add disas entries

2016-09-27 Thread Marek Vasut
Add nios2 disassembler support. This patch is composed from binutils files from commit "Opcodes and assembler support for Nios II R2". The files from binutils used in this patch are: include/opcode/nios2.h include/opcode/nios2r1.h include/opcode/nios2r2.h opcodes/nios2-opc.c op

Re: [Qemu-devel] [PATCH] linux-user: fix tcg/mmap test

2016-09-27 Thread Peter Maydell
On 19 September 2016 at 01:24, Marc-André Lureau wrote: > tests/tcg/mmap test fails with values other than default target page > size. When creating a map beyond EOF, extra anonymous pages are added up > to the target page boundary. Currently, this operation is performed only > when qemu_real_host

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Greg Ungerer
On 27/09/16 23:27, Laurent Vivier wrote: > Le 27/09/2016 à 15:22, Greg Ungerer a écrit : >> Hi Laurent, >> >> On 27/09/16 18:11, Laurent Vivier wrote: >>> Le 27/09/2016 à 09:33, Thomas Huth a écrit : On 27.09.2016 03:29, Greg Ungerer wrote: > The shipping default setting for the Freescale

[Qemu-devel] [PATCHv2] m68k: change default system clock for m5208evb

2016-09-27 Thread Greg Ungerer
The shipping default setting for the Freescale M5208EVB board is to run the CPU at 166.67MHz. The current qemu emulation code for this board is defaulting to 66MHz. This results in time appearing to run way to slowly. So a "sleep 5" in a standard ColdFire Linux build takes almost 15 seconds in real

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Peter Maydell
On 27 September 2016 at 16:49, Greg Ungerer wrote: > On 27/09/16 23:27, Laurent Vivier wrote: >> It is better because 166.67 MHZ is clearly a rounded value computed from >> the period: 10/600 = 166.... > > Perhaps it is, but again it is not documented that way.

Re: [Qemu-devel] Making cputlb.c operations safe for MTTCG

2016-09-27 Thread Richard Henderson
On 09/27/2016 04:32 PM, Alex Bennée wrote: Richard Henderson writes: On 09/27/2016 03:29 PM, Emilio G. Cota wrote: What's a quick-and-dirty way to disable the fast-path TLB lookups? Alex: you told me the monitor has an option for this, but I can't find it. I'm looking for something that'd go

Re: [Qemu-devel] Qtest virtio interfaces don't support virtio-1.0 devices

2016-09-27 Thread Gonglei (Arei)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Wednesday, September 28, 2016 12:27 AM > To: Stefan Hajnoczi > Cc: Gonglei (Arei); Cornelia Huck; qemu-devel@nongnu.org; Gerd Hoffmann; > Wubin (H); m...@redhat.com > Subject: Re: [Qemu-devel] Qtest virtio in

Re: [Qemu-devel] [PATCH v3 0/3] crypto: add ctr mode support and little inprovement

2016-09-27 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 27, 2016 8:50 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Wubin (H) > Subject: Re: [PATCH v3 0/3] crypto: add ctr mode support and little > inprovement > > On Tue, Sep 27, 20

Re: [Qemu-devel] [Qemu-block] [PATCH v24 00/12] Block replication for continuous checkpoints

2016-09-27 Thread wangweiwei
在 2016年09月12日 22:11, Stefan Hajnoczi 写道: On Mon, Aug 08, 2016 at 03:50:27PM +0100, Stefan Hajnoczi wrote: On Wed, Jul 27, 2016 at 03:01:41PM +0800, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the de

Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

2016-09-27 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 27, 2016 6:15 PM > To: Fam Zheng > Cc: Gonglei (Arei); pbonz...@redhat.com; John Snow; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel >

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Greg Ungerer
On 28/09/16 10:22, Peter Maydell wrote: > On 27 September 2016 at 16:49, Greg Ungerer wrote: >> On 27/09/16 23:27, Laurent Vivier wrote: >>> It is better because 166.67 MHZ is clearly a rounded value computed from >>> the period: 10/600 = 166.... >> >> Perhaps i

[Qemu-devel] [PULL 0/1] tags/xen-20160927-tag

2016-09-27 Thread Stefano Stabellini
t tags/xen-20160927-tag for you to fetch changes up to b6eb9b45f7307638ff166401721ae6d0401e1d67: qdisk - hw/block/xen_disk: grant copy implementation (2016-09-27 18:18:55 -0700) Xen

[Qemu-devel] [PULL 1/1] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-27 Thread Stefano Stabellini
From: Paulina Szubarczyk Copy data operated on during request from/to local buffers to/from the grant references. Before grant copy operation local buffers must be allocated what is done by calling ioreq_init_copy_buffers. For the 'read' operation, first, the qemu device invokes the read operati

Re: [Qemu-devel] Questions about gcc linker errors in crypto sub-directory

2016-09-27 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 27, 2016 8:52 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: Questions about gcc linker errors in crypto sub-directory > > On Mon, Sep 26, 2016 at 09:19:36AM +, G

Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

2016-09-27 Thread Fam Zheng
On Wed, 09/28 01:31, Gonglei (Arei) wrote: > # ./tests/virtio-net-test > ** > ERROR:tests/libqtest.c:561:qtest_get_arch: assertion failed: (qemu != NULL) > Aborted (core dumped) > > # ./tests/virtio-blk-test > ** > ERROR:tests/libqtest.c:561:qtest_get_arch: assertion failed: (qemu != NULL) > Abort

Re: [Qemu-devel] [Qemu-block] [PATCH v24 11/12] support replication driver in blockdev-add

2016-09-27 Thread wangweiwei
在 2016年09月12日 22:01, Stefan Hajnoczi 写道: On Mon, Aug 15, 2016 at 05:32:19PM +0800, Changlong Xie wrote: On 08/15/2016 04:37 PM, Kevin Wolf wrote: Am 15.08.2016 um 03:49 hat Changlong Xie geschrieben: On 08/09/2016 05:08 PM, Kevin Wolf wrote: Am 27.07.2016 um 09:01 hat Changlong Xie geschriebe

Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

2016-09-27 Thread Gonglei (Arei)
> -Original Message- > From: Fam Zheng [mailto:f...@redhat.com] > Sent: Wednesday, September 28, 2016 9:45 AM > To: Gonglei (Arei) > Cc: Daniel P. Berrange; pbonz...@redhat.com; John Snow; > qemu-devel@nongnu.org; Wubin (H) > Subject: Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-27 Thread Markus Armbruster
Alistair Francis writes: > On Tue, Sep 27, 2016 at 8:40 AM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> It does whatever cpu_physical_memory_write_rom (and hence >>> cpu_memory_rw_debug, which has more callers) do. >>> What happens when you try to monkey-patch and address that

Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

2016-09-27 Thread Fam Zheng
On Wed, 09/28 01:54, Gonglei (Arei) wrote: > What do you mean about the realpath? Can we use it to set the environment > variable? Basically just guess where QTEST_QEMU_BINARY is based on argv[0]. Fam

Re: [Qemu-devel] [PATCH] 9pfs: make unmarshal V9fsString more robust

2016-09-27 Thread 李强
On 2016-09-28 0:40 GMT+08:00 Greg Kurz wrote: > > Talking about robustness was appropriate for your previous patches, but > it does not really apply here since v9fs_iov_vunmarshal() does not have > any issue with empty strings actually. > > I've changed the title to: > > 9pfs: allocate space for

Re: [Qemu-devel] [PATCH 0/2] Add error reporting in migration

2016-09-27 Thread Markus Armbruster
John Snow writes: > On 09/27/2016 02:56 PM, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> At the moment if you use a VMSTATE_*_EQUAL macro and the value >> doesn't match you just get an error about the section that failed >> >> e.g. >> qemu-system-ppc64: error whi

Re: [Qemu-devel] [PATCH v2 1/3] coroutine: add qemu_coroutine_entered() function

2016-09-27 Thread Fam Zheng
On Tue, 09/27 16:18, Stefan Hajnoczi wrote: > See the doc comments for a description of this new coroutine API. > > Signed-off-by: Stefan Hajnoczi > --- > include/qemu/coroutine.h | 13 + > util/qemu-coroutine.c| 5 + > 2 files changed, 18 insertions(+) > > diff --git a/inc

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-09-27 Thread Yuanhan Liu
On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > > > > I assume that i

Re: [Qemu-devel] [PATCH v2 2/6] intc/i8259: implement InterruptStatsProvider interface

2016-09-27 Thread David Gibson
On Tue, Sep 27, 2016 at 08:49:47PM +0200, Hervé Poussineau wrote: > Le 27/09/2016 à 06:11, David Gibson a écrit : > > On Mon, Sep 26, 2016 at 10:23:24PM +0200, Hervé Poussineau wrote: > > > Signed-off-by: Hervé Poussineau > > > --- > > > hw/intc/i8259.c | 37 +

Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure

2016-09-27 Thread David Gibson
On Tue, Sep 27, 2016 at 07:54:37AM +0200, Cédric Le Goater wrote: > On 09/27/2016 04:35 AM, David Gibson wrote: > > On Mon, Sep 26, 2016 at 06:11:36PM +0200, Cédric Le Goater wrote: > >> On 09/23/2016 04:46 AM, David Gibson wrote: > >>> On Thu, Sep 22, 2016 at 10:25:59AM +0200, Cédric Le Goater wro

Re: [Qemu-devel] [PATCH] tests: Test IPv6 and ppc64 in the PXE tester

2016-09-27 Thread David Gibson
On Tue, Sep 27, 2016 at 09:17:19AM +0200, Thomas Huth wrote: > On 27.09.2016 06:17, David Gibson wrote: > > On Mon, Sep 26, 2016 at 10:17:46PM +0200, Thomas Huth wrote: > >> The firmware of the pseries machine, SLOF, is able to load files via > >> IPv6 networking, too. So to test both, network boot

Re: [Qemu-devel] [PATCH v2 2/3] test-coroutine: test qemu_coroutine_entered()

2016-09-27 Thread Fam Zheng
On Tue, 09/27 16:18, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > tests/test-coroutine.c | 42 ++ > 1 file changed, 42 insertions(+) > > diff --git a/tests/test-coroutine.c b/tests/test-coroutine.c > index 6431dd6..abd97c2 100644 > --- a

Re: [Qemu-devel] [PATCH v2 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Fam Zheng
On Tue, 09/27 16:18, Stefan Hajnoczi wrote: > Commit 0ed93d84edabc7656f5c998ae1a346fe8b94ca54 ("linux-aio: process > completions from ioq_submit()") added an optimization that processes > completions each time ioq_submit() returns with requests in flight. > This commit introduces a "Co-routine re-e

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 6/6] tests: enable ohci/uhci/xhci tests on PPC64

2016-09-27 Thread David Gibson
On Tue, Sep 27, 2016 at 08:55:59PM +0200, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > tests/Makefile.include| 8 +++- > tests/libqos/usb.c| 2 +- > tests/usb-hcd-uhci-test.c | 24 > 3 files changed, 24 insertions(+), 10 deletions(-) >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/6] qtest: define target cpu endianness conversion function

2016-09-27 Thread David Gibson
On Tue, Sep 27, 2016 at 08:55:58PM +0200, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > tests/libqtest.h | 57 > > 1 file changed, 57 insertions(+) > > diff --git a/tests/libqtest.h b/tests/libqtest.h > index 4be1f77..4c47

Re: [Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Fam Zheng
On Tue, 09/27 19:55, Roman Penyaev wrote: > > The bug is 100% deterministic. Just boot up a guest with -drive > > format=qcow2,aio=native. > > It turns out to be that everything is broken. I started all my > tests with format=raw,aio=native and immediately got coroutine > recursive. That is com

Re: [Qemu-devel] [PATCH] pci-testdev: enhance to support new testcases

2016-09-27 Thread Peter Xu
On Tue, Sep 27, 2016 at 06:13:29AM -0400, Paolo Bonzini wrote: > > > Take my example: IOMMU unit test would want the guest to send DMA/IRQ > > request from the device's perspective. In that case, we would like to > > "tell" the pci-testdev about where to write the DMA, and what data to > > write s

Re: [Qemu-devel] [PULL 00/28] Misc patches for 2016-09-26

2016-09-27 Thread Peter Xu
On Tue, Sep 27, 2016 at 06:11:59AM -0400, Paolo Bonzini wrote: > > > I think we should keep it as it is, because Jason's patchset will only > > support intel-iommu, not amd-iommu. For now, it won't have problem > > (just like Intel IOMMU one). But after Jason's patch is merged, people > > will be

<    1   2   3   4   5   >