On 09/27/2016 05:10 PM, Eric Blake wrote: > On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: >> The input_visitor_test_add() method was accepting an instance >> of 'TestInputVisitorData' and passing it as the 'user_data' >> parameter to test functions. The main 'TestInputVisitorData' >> instance that was actually used, was meanwhile being allocated >> automatically by the test framework fixture setup. >> >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> >> --- >> tests/test-qobject-input-visitor.c | 76 >> ++++++++++++++++---------------------- >> 1 file changed, 32 insertions(+), 44 deletions(-) >> > > Reviewed-by: Eric Blake <ebl...@redhat.com> >
Having said that, I note that ALL callers now pass NULL for user_data. If you plan on using it later in the series for something other than NULL for some of the (new?) tests added at that point, it would be wise to say so in the commit message; if not, I would suggest eliminating the parameter altogether. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
