[Qemu-devel] [PULL V2 27/27] imx_fec: fix error in qemu_send_packet argument

2016-09-27 Thread Jason Wang
From: Paolo Bonzini This uses the wrong frame size for packets composed of multiple descriptors. Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 1c415ab..5

Re: [Qemu-devel] [PATCH v3 07/10] ppc/pnv: add XSCOM infrastructure

2016-09-27 Thread Benjamin Herrenschmidt
On Tue, 2016-09-27 at 11:10 +0200, Cédric Le Goater wrote: > >  > > > > > > +PowerPCCPU *cpu = POWERPC_CPU(cs); > > > +CPUPPCState *env = &cpu->env; > > > + > > > +cpu_synchronize_state(cs); > > > +env->spr[SPR_HMER] |= hmer_bits; > > > + > > > +/* XXX Need a CPU helper to set

Re: [Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

2016-09-27 Thread Fam Zheng
On Tue, 09/27 11:17, Daniel P. Berrange wrote: > > Too bad that this seems to be too big a hammer that breaks the way gcov was > > used: 1) the "rm *.gcda" command now runs in each test, so it's harder to > > get an overall coverage report; 2) there is a risk that the parallism may > > corrupt thos

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Stefan Hajnoczi
On Wed, Sep 21, 2016 at 09:19:44PM +0300, Roy Shterman wrote: > iSER is a new transport layer supported in Libiscsi, > iSER provides a zero-copy RDMA capable interface that can > improve performance. > > New API is introduced in abstracion of the Libiscsi transport layer. > In order to use the new

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

2016-09-27 Thread Denis V. Lunev
On 09/27/2016 01:15 PM, Paolo Bonzini wrote: >> We could go in a different direction and export flag >> 'has_zero_init' which will report that the storage is >> initialized with all zeroes at the moment. In this >> case mirroring code will not fall into this >> branch. > Why don't you add the zero_

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Rafael David Tinoco
> On Sep 27, 2016, at 05:36, Daniel P. Berrange wrote: > > On Tue, Sep 27, 2016 at 03:06:21AM +, Rafael David Tinoco wrote: >> Commit: 35f9b6ef3acc9d0546c395a566b04e63ca84e302 added a fallback >> mechanism for systems not supporting memfd_create syscall (started >> being supported since 3.17

Re: [Qemu-devel] [PATCH] libqos: fix qvring_init()

2016-09-27 Thread Stefan Hajnoczi
On Mon, Sep 26, 2016 at 05:24:10PM +0200, Laurent Vivier wrote: > "vq->desc[i].addr" is a 64bit value, > so write it with writeq(), not writew(). > > struct vring_desc { > __virtio64 addr; > __virtio32 len; > __virtio16 flags; > __virtio16 next; > }; > > Signed-off-by: Laurent Viv

Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
On Tue, 09/27 17:33, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use ca

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Marc-André Lureau
Hi - Original Message - > > > On Sep 27, 2016, at 05:36, Daniel P. Berrange wrote: > > > > On Tue, Sep 27, 2016 at 03:06:21AM +, Rafael David Tinoco wrote: > > We should not have QEMU creating unpredictabile filenames in the > > first place - any filenames should be determined by li

[Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
We already specified BDRV_O_UNMAP when opening images in 'qemu-img commit', but didn't turn on the "unmap" in the active commit job. This patch fixes that so that zeroed clusters in top image can be discarded which is desired in the virt-sparsify use case, where a temporary overlay is created and f

Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Kevin Wolf
Am 27.09.2016 um 13:04 hat Fam Zheng geschrieben: > On Tue, 09/27 17:33, Fam Zheng wrote: > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > commit', but didn't turn on the "unmap" in the active commit job. This > > patch fixes that so that zeroed clusters in top image can b

Re: [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
On Tue, 09/27 13:15, Kevin Wolf wrote: > Am 27.09.2016 um 13:04 hat Fam Zheng geschrieben: > > On Tue, 09/27 17:33, Fam Zheng wrote: > > > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > > > commit', but didn't turn on the "unmap" in the active commit job. This > > > patch fixe

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released

2016-09-27 Thread Peter Lieven
Am 27.09.2016 um 12:28 schrieb Peter Lieven: Am 16.09.2016 um 15:56 schrieb Peter Lieven: Am 13.09.2016 um 20:04 schrieb Michael Roth: Quoting Peter Lieven (2016-09-13 10:52:04) Am 13.09.2016 um 17:42 schrieb Stefan Hajnoczi: On Thu, Sep 08, 2016 at 03:58:26PM -0500, Michael Roth wrote: Quot

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Rafael David Tinoco
Hello! > On Sep 27, 2016, at 08:13, Marc-André Lureau wrote: > >> Note that the filename, per se, is not as important as other files, >> since qemu won't provide it for being accessed by external programs, and, >> deletes the file, while keeping the descriptor, right after its creation >> (due t

Re: [Qemu-devel] [PATCH] virtio-serial: virtio console emergency write support

2016-09-27 Thread Sascha Silbe
Dear Amit, Amit Shah writes: > On (Wed) 21 Sep 2016 [14:17:48], Sascha Silbe wrote: >> Add support for the virtio 1.0 "emergency write" >> (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. This is useful for early guest >> debugging and might be used in cases where the guest crashes so badly >> that it ca

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Roy Shterman
On 9/27/2016 1:28 PM, Stefan Hajnoczi wrote: On Wed, Sep 21, 2016 at 09:19:44PM +0300, Roy Shterman wrote: iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API is introduced in abstracion of the Libiscsi tr

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Peter Lieven
Am 27.09.2016 um 13:37 schrieb Roy Shterman: On 9/27/2016 1:28 PM, Stefan Hajnoczi wrote: On Wed, Sep 21, 2016 at 09:19:44PM +0300, Roy Shterman wrote: iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API

Re: [Qemu-devel] How to add my implementation of the fmadds instruction to QEMU

2016-09-27 Thread Peter Maydell
On 26 September 2016 at 18:05, G 3 wrote: > I made my own experimental implementation of the fmadds instruction that I > would like to add to QEMU. How would I do this? > > My implementation would probably look like this: > > void fmadds(float *frD, float frA, float frC, float frB) > { > *

[Qemu-devel] [PATCH] 9pfs: make unmarshal V9fsString more robust

2016-09-27 Thread Li Qiang
From: Li Qiang In 9pfs function v9fs_iov_vunmarshal, it will not allocate space for empty string. This will cause several NULL pointer dereference issues. this patch fix this issue. Signed-off-by: Li Qiang --- fsdev/9p-iov-marshal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup

2016-09-27 Thread Marc-André Lureau
Hi On Thu, Aug 11, 2016 at 1:16 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau < > marcandre.lur...@gmail.com> wrote: > >> ping >> > > 2nd ping, probably for-2.8 now > 3rd ping, those are 2 one-liners, don't be shy :) thanks

[Qemu-devel] [PATCH 2/8] s390x/pci: assign msix io region for each pci device

2016-09-27 Thread Christian Borntraeger
From: Yi Min Zhao For efficiency we now assign one msix io region for each pci device and provide it with the pointer to the zPCI device as opaque parameter. In addition, we remove msix address space and add msix io region as a subregion to the root memory region of pci device. Signed-off-by: Yi

[Qemu-devel] [PATCH 5/8] pc-bios/s390-ccw: enable subchannel for IPL I/O devices

2016-09-27 Thread Christian Borntraeger
From: Dong Jia Shi IPL should cause the IPL I/O device to become enabled. So when handling the IPL program, we should set the E (Enable) bit. However, virtio-ccw does not know whether it's dealing with an IPL device or not. Since trying to perform I/O on a disabled device doesn't make any sense,

[Qemu-devel] [PATCH 8/8] s390x/kvm: fix build against qemu_uuid

2016-09-27 Thread Christian Borntraeger
commit 9c5ce8db2e5c ("vl: Switch qemu_uuid to QemuUUID") changed most users of qemu_uuid but not all. Fix a build error on s390/kvm. Cc: Fam Zheng Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/kvm.c b

[Qemu-devel] [PATCH 1/8] s390x/pci: re-arrange variable declarations

2016-09-27 Thread Christian Borntraeger
From: Pierre Morel Pull mr variable declarations at the top of the functions instead of mixing them up with the code. This is in preparation for followup patches. Signed-off-by: Pierre Morel Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/s390-pci-inst.c | 6

[Qemu-devel] [PATCH 7/8] s390x/css: {c, h, t, r, x}sch: require enable AND device number valid

2016-09-27 Thread Christian Borntraeger
From: Sascha Silbe According to the PoP, subchannels are only considered operational if they are enabled _and_ the device number is valid. With the current checks being enabled _or_ having a valid device number was sufficient. This caused qemu to allow IO on subchannels that were not enabled. Fi

[Qemu-devel] [PATCH 3/8] s390x/pci: code cleanup

2016-09-27 Thread Christian Borntraeger
From: Yi Min Zhao Now that each S390 PCI device uses an IO region as MSIX region. The code in s390_translate_iommu() will never be triggered. Let's remove it. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel Signed-off-by: Christian Borntraeger --- hw/s390x/s390-pci-bus.c | 11 --

[Qemu-devel] [PATCH 4/8] s390x/kvm: Fix potential deadlock in sigp handling

2016-09-27 Thread Christian Borntraeger
If two VCPUs exit at the same time and target each other with a sigp, both could run into a deadlock as run_on_cpu on CPU0 will free the BQL when starting the CPU1 target routine. CPU1 will run its sigp initiater for CPU0 before handling the run_on_cpu requests, thus resulting in a dead lock. As a

[Qemu-devel] [PATCH 6/8] pc-bios/s390-ccw.img: rebuild image

2016-09-27 Thread Christian Borntraeger
Contains: - pc-bios/s390-ccw: enable subchannel for IPL I/O devices Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw.img | Bin 26440 -> 26392 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 089f6ba5e924c17796cccac4e

[Qemu-devel] [PATCH 0/8] next patches for s390x/kvm

2016-09-27 Thread Christian Borntraeger
Here is the next bunch of s390 patches. I plan to send a pull request at the end of the week. Code can also be found on git://github.com/borntraeger/qemu.git tags/s390x-20160927 Couple of s390x patches: - some PCI cleanups - fix

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Roy Shterman
On 9/27/2016 2:52 PM, Paolo Bonzini wrote: On 27/09/2016 13:37, Roy Shterman wrote: +iscsi_url = iscsi_parse_full_url(iscsi, uri_string_unescape(filename, -1, NULL)); if (iscsi_url == NULL) { -error_setg(errp, "Failed to parse URL : %s", filename); +error_setg(errp,

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-27 Thread Paolo Bonzini
On 26/09/2016 21:58, riku.voi...@linaro.org wrote: > From: Riku Voipio > > Linux-user and bsd-user code needs lots of arch-specific ifdefs, > so disable the warning. > > Signed-off-by: Riku Voipio > --- > scripts/checkpatch.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Paolo Bonzini
On 27/09/2016 13:37, Roy Shterman wrote: >>> >>> +iscsi_url = iscsi_parse_full_url(iscsi, >>> uri_string_unescape(filename, -1, NULL)); >>> if (iscsi_url == NULL) { >>> -error_setg(errp, "Failed to parse URL : %s", filename); >>> +error_setg(errp, "Failed to parse URL :

[Qemu-devel] [PATCH v3 2/2] vmstateify tsc210x

2016-09-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I'm now saving all 3 of the pll entries; only 2 were saved before. There are a couple of times that were previously stored as offsets from 'now' calculated before saving; with vmstate it's easier to store the 'now' and fix it up on reload. Signed-off-by: Dr. David

Re: [Qemu-devel] [SeaBIOS] [PATCH 5/5] [wip] sercon: initial split-output implementation

2016-09-27 Thread Gerd Hoffmann
On Fr, 2016-07-15 at 10:35 -0400, Kevin O'Connor wrote: > On Fri, Jul 15, 2016 at 01:49:49PM +0200, Gerd Hoffmann wrote: > > > Finally, one high level observation is that we know there are a number > > > of quirks in various vgabios emulators. For example, we know some > > > emulators don't handle

Re: [Qemu-devel] [PATCH V9 1/7] oslib-posix: add helpers for stack alloc and free

2016-09-27 Thread Kevin Wolf
Am 27.09.2016 um 11:58 hat Peter Lieven geschrieben: > the allocated stack will be adjusted to the minimum supported stack size > by the OS and rounded up to be a multiple of the system pagesize. > Additionally an architecture dependent guard page is added to the stack > to catch stack overflows. >

[Qemu-devel] [PATCH] 9pfs: fix potential host memory leak in v9fs_read

2016-09-27 Thread Li Qiang
From: Li Qiang In 9pfs read dispatch function, it doesn't free two QEMUIOVector object thus causing potential memory leak. This patch avoid this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index

[Qemu-devel] [PATCH v3 0/2] vmstateify a bunch of rare devices

2016-09-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Two more register_savevm users converted to vmstate. This is split out from an earlier series where some of the others have gone in. Note I've not been able to test the changes (other than build); I've not got any model that uses them that successfully migrates eve

[Qemu-devel] [PATCH v3 1/2] vmstateify tsc2005

2016-09-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I've converted the fields in it's main data structure to fixed size types in ways that look sane. Signed-off-by: Dr. David Alan Gilbert --- Note I haven't got one of these devices to compare with or know much about them. --- hw/input/tsc2005.c | 190

[Qemu-devel] [PATCH 1/6] aspeed: rename the smc object to fmc

2016-09-27 Thread Cédric Le Goater
The Aspeed SoC has three different types of SMC (Static Memory Controller) controllers: the SMC (legacy), the FMC (the new one) and the SPI for the host PNOR. The FMC and the SPI models are now converging on the AST2500 SoC and the SMC, which was still available on the AST2400 SoC, was removed. Th

Re: [Qemu-devel] [PATCH V9 1/7] oslib-posix: add helpers for stack alloc and free

2016-09-27 Thread Peter Lieven
Am 27.09.2016 um 13:59 schrieb Kevin Wolf: Am 27.09.2016 um 11:58 hat Peter Lieven geschrieben: the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added to

[Qemu-devel] [PATCH 0/6] aspeed: add support for the ast2500 SMC controllers

2016-09-27 Thread Cédric Le Goater
Hello, The Aspeed AST2500 has one 'SPI' controller for the BMC firmware and two 'SPI' for the host firmware. All controllers have now the same set of registers compatible with the AST2400 'FMC' controller and the legacy 'SMC' controller is fully gone. This serie adds support for the second SPI co

[Qemu-devel] [PATCH 3/6] aspeed: extend the number of host SPI controllers

2016-09-27 Thread Cédric Le Goater
The AST2500 SoC has two. Let's prepare ground for the next changes which will add the required definitions for the second host SPI controller. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 2 +- hw/arm/aspeed_soc.c | 44 +--- i

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

2016-09-27 Thread Denis V. Lunev
On 09/26/2016 03:46 PM, Vladimir Sementsov-Ogievskiy wrote: > This extension allows big requests for TRIM and WRITE_ZEROES through > special 'shift' parameter, which means that offset and length should be > shifted left by several bits. > > This is needed for efficient clearing large regions of the

[Qemu-devel] [PATCH 6/6] aspeed: add support for the SMC segment registers

2016-09-27 Thread Cédric Le Goater
The SMC controller on the Aspeed SoC has a set of registers to configure the mapping of each flash module in the SoC address space. Writing to these registers triggers a remap of the memory region and the spec requires a certain number of checks before doing so. Signed-off-by: Cédric Le Goater --

[Qemu-devel] [PATCH 2/6] aspeed: move the flash module mapping address under the controller definition

2016-09-27 Thread Cédric Le Goater
This will ease the definition of the new controllers for the AST2500 SoC and also ease the support of the segment registers, which provide a way to reconfigure the mapping window of each slave. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed_soc.c | 9 - hw/ssi/aspeed_smc.c

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

2016-09-27 Thread Paolo Bonzini
- Original Message - > From: "Denis V. Lunev" > To: "Paolo Bonzini" > Cc: "Vladimir Sementsov-Ogievskiy" , > qemu-devel@nongnu.org, qemu-bl...@nongnu.org, > nbd-gene...@lists.sourceforge.net, a...@alex.org.uk, ebl...@redhat.com, > kw...@redhat.com, stefa...@redhat.com, > w...@uter.be

[Qemu-devel] [PATCH 4/6] aspeed: add support for the AST2500 SoC SMC controllers

2016-09-27 Thread Cédric Le Goater
The SMC controllers on the Aspeed AST2500 SoC are very similar to the ones found on the AST2400. The differences are on the number of supported flash modules and their default mappings in the SoC address space. The Aspeed AST2500 has one SPI controller for the BMC firmware and two for the host fir

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Paolo Bonzini
> On 9/27/2016 2:52 PM, Paolo Bonzini wrote: > > On 27/09/2016 13:37, Roy Shterman wrote: > > > > > +iscsi_url = iscsi_parse_full_url(iscsi, > > > > > uri_string_unescape(filename, -1, NULL)); > > > > >if (iscsi_url == NULL) { > > > > > -error_setg(errp, "Failed to parse URL :

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] tests: enable ohci/uhci/xhci tests on PPC64

2016-09-27 Thread Laurent Vivier
On 27/09/2016 09:43, Laurent Vivier wrote: > > > On 27/09/2016 05:53, David Gibson wrote: >> On Mon, Sep 26, 2016 at 04:10:49PM +0200, Laurent Vivier wrote: > >>> void qusb_pci_init_one(QPCIBus *pcibus, struct qhc *hc, uint32_t devfn, >>> int bar) >>> { >>> hc->dev = qpci_device_find(p

[Qemu-devel] [PATCH 5/6] aspeed: create mapping regions for the maximum number of slaves

2016-09-27 Thread Cédric Le Goater
The SMC controller on the Aspeed SoC has a set of registers to configure the mapping of each flash module in the SoC address space. These mapping windows are configurable even though no SPI slave is attached to the controller. Also rewrite a bit the comments in the code on this topic. Signed-off-

Re: [Qemu-devel] [PATCH 1/3] virtio: add virtio_detach_element()

2016-09-27 Thread Ladi Prosek
On Tue, Sep 27, 2016 at 12:08 PM, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2016 at 09:32:40AM +0200, Ladi Prosek wrote: >> On Mon, Sep 19, 2016 at 3:28 PM, Stefan Hajnoczi wrote: >> > During device res> > +/* virtqueue_discard: >> > + * @vq: The #VirtQueue >> > + * @elem: The #VirtQueueElement >>

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-09-27 Thread Chunguang Li
> -原始邮件- > 发件人: "Dr. David Alan Gilbert" > 发送时间: 2016年9月27日 星期二 > 收件人: "Chunguang Li" > 抄送: qemu-devel@nongnu.org, amit.s...@redhat.com, pbonz...@redhat.com, > stefa...@redhat.com, quint...@redhat.com > 主题: Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty > after

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 07:13:55AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > > > > On Sep 27, 2016, at 05:36, Daniel P. Berrange wrote: > > > > > > On Tue, Sep 27, 2016 at 03:06:21AM +, Rafael David Tinoco wrote: > > > We should not have QEMU creating unpredi

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Sep 27, 2016 at 07:13:55AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > > > > > On Sep 27, 2016, at 05:36, Daniel P. Berrange > > > > wrote: > > > > > > > > On Tue, Sep 27, 2016 at 03:06:21AM +, Rafael David Tin

Re: [Qemu-devel] [Bug 1626972] Re: [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 11:01:10AM -, Rafael David Tinoco wrote: > > On Sep 27, 2016, at 05:36, Daniel P. Berrange wrote: > > > > On Tue, Sep 27, 2016 at 03:06:21AM +, Rafael David Tinoco wrote: > >> Commit: 35f9b6ef3acc9d0546c395a566b04e63ca84e302 added a fallback > >> mechanism for syst

Re: [Qemu-devel] [PATCH 8/8] s390x/kvm: fix build against qemu_uuid

2016-09-27 Thread Fam Zheng
On Tue, 09/27 13:48, Christian Borntraeger wrote: > commit 9c5ce8db2e5c ("vl: Switch qemu_uuid to QemuUUID") changed most > users of qemu_uuid but not all. Fix a build error on s390/kvm. > > Cc: Fam Zheng > Signed-off-by: Christian Borntraeger > --- > target-s390x/kvm.c | 2 +- > 1 file changed

Re: [Qemu-devel] [PATCH 0/5] target-i386: Eliminate unnecessary has_msr_* global variables

2016-09-27 Thread Eduardo Habkost
On Tue, Sep 27, 2016 at 04:51:54AM -0400, Paolo Bonzini wrote: > - Original Message - > > From: "Eduardo Habkost" > > To: "Paolo Bonzini" , "Marcelo Tosatti" > > > > Cc: k...@vger.kernel.org, qemu-devel@nongnu.org > > Sent: Tuesday, September 27, 2016 12:24:05 AM > > Subject: [PATCH 0/5]

Re: [Qemu-devel] [PATCH v2 0/3] pc: compat macroses fixes/cleanups

2016-09-27 Thread Eduardo Habkost
On Tue, Sep 27, 2016 at 11:32:13AM +0200, Igor Mammedov wrote: > On Mon, 19 Sep 2016 10:32:32 +0200 > Igor Mammedov wrote: > > > Changes since v1: > > - drop 'pc: fix regression introduced by adding 2.8 machine' > >it's not needed > > - cleanup old style compat chaining > > - add missing H

Re: [Qemu-devel] [PATCH 0/7] target-i386: xsave CPUID handling refactor

2016-09-27 Thread Eduardo Habkost
On Fri, Sep 23, 2016 at 04:45:29PM -0300, Eduardo Habkost wrote: > This series refactor the xsave CPUID handling so it won't > silently disable any XSAVE components on CPUID[0xD] in case the > host doesn't support it. It will instead use the exisitng > check/enforce logic for filtering the CPUID bi

Re: [Qemu-devel] [PATCH v3 0/3] crypto: add ctr mode support and little inprovement

2016-09-27 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 09:32:10AM +, Gonglei (Arei) wrote: > Hi Daniel, > > I'll post virtio-crypto v4 based on this patch set. > Would you please merge it if it's ok? Thanks. > > Regards, > -Gonglei > > > > -Original Message- > > From: Gonglei (Arei) > > Sent: Monday, September 2

Re: [Qemu-devel] [PATCH v2 0/6] target-i386: Increase CPUID level/xlevel/xlevel2 automatically

2016-09-27 Thread Eduardo Habkost
On Thu, Sep 22, 2016 at 11:53:43AM -0300, Eduardo Habkost wrote: > This series fixes the inconsistency between CPUID[7].EBX features > and all the rest of the configurable CPU features. This ensures > that level/xlevel/xlevel2 will be set to appropriate values > depending on the set of features ena

Re: [Qemu-devel] Questions about gcc linker errors in crypto sub-directory

2016-09-27 Thread Daniel P. Berrange
On Mon, Sep 26, 2016 at 09:19:36AM +, Gonglei (Arei) wrote: > > > > > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Monday, September 26, 2016 5:14 PM > > To: Gonglei (Arei) > > Cc: qemu-devel@nongnu.org > > Subject: Re: Questions about

Re: [Qemu-devel] KVM call for agenda for 2016-08-27

2016-09-27 Thread Juan Quintela
Juan Quintela wrote: > Juan Quintela wrote: >> Hi >> > > Kindly reminder that call is Tomorrow an there aren't yet any topics. As there were no topics, call get cancelled. Later, Juan. > > Thanks, Juan. > > >> Please, send any topic that you are interested in covering. >> >> At the end of Mon

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-27 Thread Igor Mammedov
On Thu, 22 Sep 2016 23:04:32 +0200 Radim Krčmář wrote: > Cluster x2APIC cannot work without KVM's x2apic API when the maximal > APIC ID is > 8. Make the code simpler by completely forbidding EIM > without KVM's x2apic API. > > Signed-off-by: Radim Krčmář > --- > I think it the dependency wou

[Qemu-devel] [PATCH v14 03/19] option: allow qemu_opts_to_qdict to merge repeated options

2016-09-27 Thread Daniel P. Berrange
If given an option string such as size=1024,nodes=10,nodes=4-5,nodes=1-2,policy=bind the qemu_opts_to_qdict() method will currently overwrite the values for repeated option keys, so only the last value is in the returned dict: size=1024 nodes=1-2 policy=bind This adds the ability

[Qemu-devel] [PATCH v14 04/19] qapi: add trace events for visitor

2016-09-27 Thread Daniel P. Berrange
Allow tracing of the operation of visitors Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + qapi/qapi-visit-core.c | 27 +++ qapi/trace-events | 33 + 3 files changed, 61 insertions(+) create mode 100644 qapi/trace

[Qemu-devel] [PATCH v14 02/19] option: make parse_option_bool/number non-static

2016-09-27 Thread Daniel P. Berrange
The opts-visitor.c opts_type_bool() method has code for parsing a string to set a bool value, as does the qemu-option.c parse_option_bool() method, except it handles fewer cases. To enable consistency across the codebase, extend parse_option_bool() to handle "yes", "no", "y" and "n", and make it n

[Qemu-devel] [PATCH v14 05/19] qapi: rename QmpInputVisitor to QObjectInputVisitor

2016-09-27 Thread Daniel P. Berrange
The QmpInputVisitor has no direct dependency on QMP. It is valid to use it anywhere that one has a QObject. Rename it to better reflect its functionality as a generic QObject to QAPI converter. Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- docs/qapi-code

[Qemu-devel] [PATCH v14 07/19] qapi: don't pass two copies of TestInputVisitorData to tests

2016-09-27 Thread Daniel P. Berrange
The input_visitor_test_add() method was accepting an instance of 'TestInputVisitorData' and passing it as the 'user_data' parameter to test functions. The main 'TestInputVisitorData' instance that was actually used, was meanwhile being allocated automatically by the test framework fixture setup. S

[Qemu-devel] [PATCH v14 01/19] qdict: implement a qdict_crumple method for un-flattening a dict

2016-09-27 Thread Daniel P. Berrange
The qdict_flatten() method will take a dict whose elements are further nested dicts/lists and flatten them by concatenating keys. The qdict_crumple() method aims to do the reverse, taking a flat qdict, and turning it into a set of nested dicts/lists. It will apply nesting based on the key name, wi

[Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-09-27 Thread Daniel P. Berrange
An update of a series previously posted v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html v3: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02498.html v4: https://lists.gnu.org/archive/html

[Qemu-devel] [PATCH v14 06/19] qapi: rename QmpOutputVisitor to QObjectOutputVisitor

2016-09-27 Thread Daniel P. Berrange
The QmpOutputVisitor has no direct dependency on QMP. It is valid to use it anywhere that one wants a QObject. Rename it to better reflect its functionality as a generic QAPI to QObject converter. Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- block/qapi.

[Qemu-devel] [PATCH v14 11/19] qapi: add integer range support for QObjectInputVisitor

2016-09-27 Thread Daniel P. Berrange
The traditional CLI arg syntax allows two ways to specify integer lists, either one value per key, or a range of values per key. eg the following are identical: -arg foo=5,foo=6,foo=7 -arg foo=5-7 This extends the QObjectInputVisitor so that it is able to parse ranges and turn them into disti

[Qemu-devel] [PATCH v14 12/19] qapi: allow QObjectInputVisitor to be created with QemuOpts

2016-09-27 Thread Daniel P. Berrange
Instead of requiring all callers to go through the mutli-step process of turning QemuOpts into a suitable QObject for visiting, add a new constructor that encapsulates this logic. This will allow QObjectInputVisitor to be a drop-in replacement for the existing OptsVisitor with minimal code changes

[Qemu-devel] [PATCH v14 08/19] qapi: permit scalar type conversions in QObjectInputVisitor

2016-09-27 Thread Daniel P. Berrange
Currently the QObjectInputVisitor assumes that all scalar values are directly represented as the final types declared by the thing being visited. ie it assumes an 'int' is using QInt, and a 'bool' is using QBool, etc. This is good when QObjectInputVisitor is fed a QObject that came from a JSON doc

[Qemu-devel] [PATCH v14 14/19] hmp: support non-scalar properties with object_add

2016-09-27 Thread Daniel P. Berrange
The current object_add HMP syntax only allows for creation of objects with scalar properties, or a list with a fixed scalar element type. Objects which have properties that are represented as structs in the QAPI schema cannot be created using -object. This is a design limitation of the way the Opt

[Qemu-devel] [PATCH v14 10/19] qapi: permit auto-creating nested structs

2016-09-27 Thread Daniel P. Berrange
Some of the historical command line opts that had their keys in in a completely flat namespace are now represented by QAPI schemas that use a nested structs. When converting the QemuOpts to QObject, there is no information about compound types available, so the QObject will be completely flat, even

[Qemu-devel] [PATCH v14 15/19] numa: convert to use QObjectInputVisitor for -numa

2016-09-27 Thread Daniel P. Berrange
Switch away from using OptsVisitor to parse the -numa argument processing. This enables use of the modern list syntax for specifying CPUs. e.g. the old syntax -numa node,nodeid=0,cpus=0-3,cpus=8-11,mem=107 is equivalent to -numa node,nodeid=0,cpus.0=0,cpus.1=1,cpus.2=2,cpus.3=3,\ cpu

[Qemu-devel] [PATCH v14 09/19] qapi: permit auto-creating single element lists

2016-09-27 Thread Daniel P. Berrange
When converting QemuOpts to a QObject, there is no information about compound types available, so when visiting a list, the corresponding QObject is not guaranteed to be a QList. We therefore need to be able to auto-create a single element QList from whatever type we find. This mode should only be

[Qemu-devel] [PATCH v14 13/19] qom: support non-scalar properties with -object

2016-09-27 Thread Daniel P. Berrange
The current -object command line syntax only allows for creation of objects with scalar properties, or a list with a fixed scalar element type. Objects which have properties that are represented as structs in the QAPI schema cannot be created using -object. This is a design limitation of the way t

[Qemu-devel] [PATCH v14 18/19] net: convert to QObjectInputVisitor for -net/-netdev parsing

2016-09-27 Thread Daniel P. Berrange
The -net/-netdev command line parsing code uses OptsVisitor for parsing options to populate NetLegacy or NetDev struct respectively. Although those structs have nesting, the OptsVisitor flattens them, so we must enable compatibility options to auto-create structs. This allows the legacy syntax -

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Greg Ungerer
Hi Laurent, On 27/09/16 18:11, Laurent Vivier wrote: Le 27/09/2016 à 09:33, Thomas Huth a écrit : On 27.09.2016 03:29, Greg Ungerer wrote: The shipping default setting for the Freescale M5208EVB board is to run the CPU at 166MHz. The current qemu emulation code for this board is defaulting to

Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Eric Blake
On 09/27/2016 06:14 AM, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use

[Qemu-devel] [PATCH v14 16/19] block: convert crypto driver to use QObjectInputVisitor

2016-09-27 Thread Daniel P. Berrange
The crypto block driver currently uses OptsVisitor to convert from the block driver open/create options into QCryptoBlockOpenOptions/QCryptoBlockCreateOptions. This is easily replaced by use of QObjectInputVisitor with no need to enable any compatibility options, since the structs dealt with contai

Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Eric Blake
On 09/27/2016 06:14 AM, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Greg Ungerer
Hi Thomas, On 27/09/16 17:33, Thomas Huth wrote: On 27.09.2016 03:29, Greg Ungerer wrote: The shipping default setting for the Freescale M5208EVB board is to run the CPU at 166MHz. The current qemu emulation code for this board is defaulting to 66MHz. This results in time appearing to run way t

[Qemu-devel] [PATCH v14 17/19] acpi: convert to QObjectInputVisitor for -acpi parsing

2016-09-27 Thread Daniel P. Berrange
The -acpi command line option parsing uses the OptsVisitor currently. This is easily replaced by the QObjectInputVisitor instead. There is no need to enable any of the compatibility options, since the AcpiTableOptions QAPI struct only contains scalar properties. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/09/2016 10:10, Markus Armbruster wrote: >> For me, the similarity (at the conceptual level) to the persistent >> memory case is striking: in both cases, we need a backend to manage >> memory contents. The difference is that for persistent memory, changes >> persist,

[Qemu-devel] [PATCH v14 19/19] qapi: delete unused OptsVisitor code

2016-09-27 Thread Daniel P. Berrange
Now that all code has been converted to QObjectInputVisitor's QemuOpts compatibility mode, there is no longer any reason to keep OptsVisitor alive. Signed-off-by: Daniel P. Berrange --- include/qapi/opts-visitor.h | 40 qapi/Makefile.objs | 2 +- qapi/opts-visitor.c | 54

Re: [Qemu-devel] [PATCH 1/5] apic: add global apic_get_class()

2016-09-27 Thread Radim Krčmář
2016-09-23 17:17+0800, Peter Xu: > On Thu, Sep 22, 2016 at 11:04:28PM +0200, Radim Krčmář wrote: >> Every configuration has only up to one APIC class and we'll be extending >> the class with a function that can be called without an instanced >> object, so a direct access to the class is convenient.

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Laurent Vivier
Le 27/09/2016 à 15:22, Greg Ungerer a écrit : > Hi Laurent, > > On 27/09/16 18:11, Laurent Vivier wrote: >> Le 27/09/2016 à 09:33, Thomas Huth a écrit : >>> On 27.09.2016 03:29, Greg Ungerer wrote: The shipping default setting for the Freescale M5208EVB board is to run the CPU at 166MH

[Qemu-devel] [PATCH v2 1/2] virtio-serial: add plumbing for virtio console emergency write support

2016-09-27 Thread Sascha Silbe
Add the infrastructure required for the virtio 1.0 "emergency write" (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. Because we don't touch the size of the configuration area, guests will not be able to actually make use of this without further patches. Reviewed-by: Cornelia Huck Signed-off-by: Sascha Si

[Qemu-devel] [PATCH v2 2/2] virtio-serial: enable virtio console emergency write feature

2016-09-27 Thread Sascha Silbe
Add support for enabling the virtio 1.0 "emergency write" (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. The previous patch introduced the plumbing required for this; now we expose the virtio feature to the guest. The feature is disabled for compatibility machines to avoid exposing a new feature to existi

[Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common()

2016-09-27 Thread Kevin Wolf
This enables its use for nested child nodes. The compatibility between the 'discard' and 'detect-zeroes' setting is checked in bdrv_open_common() now as the former setting isn't available before calling bdrv_open() any more. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reit

[Qemu-devel] [PULL 02/18] qemu: use bdrv_flush_all for vm_stop et al

2016-09-27 Thread Kevin Wolf
From: John Snow Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all, bdrv_flush_all does not have device model restrictions. This allows us to flush and halt unconditionally without error. This allows us to do things like migrate when we have a device with an open tray, but has

[Qemu-devel] [PULL 01/18] block: reintroduce bdrv_flush_all

2016-09-27 Thread Kevin Wolf
From: John Snow Commit fe1a9cbc moved the flush_all routine from the bdrv layer to the block-backend layer. In doing so, however, the semantics of the routine changed slightly such that flush_all now used blk_flush instead of bdrv_flush. blk_flush can fail if the attached device model reports th

[Qemu-devel] [PULL 07/18] block/qapi: Move 'aio' option to file driver

2016-09-27 Thread Kevin Wolf
The option whether or not to use a native AIO interface really isn't a generic option for all drivers, but only applies to the native file protocols. This patch moves the option in blockdev-add to the appropriate places (raw-posix and raw-win32). We still have to keep the flag BDRV_O_NATIVE_AIO fo

[Qemu-devel] [PULL 03/18] block-backend: remove blk_flush_all

2016-09-27 Thread Kevin Wolf
From: John Snow We can teach Xen to drain and flush each device as it needs to, instead of trying to flush ALL devices. This removes the last user of blk_flush_all. The function is therefore removed under the premise that any new uses of blk_flush_all would be the wrong paradigm: either flush th

[Qemu-devel] [PULL 00/18] Block layer patches

2016-09-27 Thread Kevin Wolf
The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-26 19:47:00 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch cha

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-27 Thread Riku Voipio
On 27 September 2016 at 14:58, Paolo Bonzini wrote: > > > On 26/09/2016 21:58, riku.voi...@linaro.org wrote: >> From: Riku Voipio >> >> Linux-user and bsd-user code needs lots of arch-specific ifdefs, >> so disable the warning. >> >> Signed-off-by: Riku Voipio >> --- >> scripts/checkpatch.pl |

<    1   2   3   4   5   >