From: John Arbuckle
The NO_KEY value should not be sent to the guest. This patch drops that value.
Signed-off-by: John Arbuckle
Signed-off-by: David Gibson
---
hw/input/adb.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/hw/input/adb.c b/hw/input
From: Laurent Vivier
Signed-off-by: Laurent Vivier
Reviewed-by: Eric Blake
Signed-off-by: David Gibson
---
hw/ppc/spapr_drc.c | 54 -
hw/ppc/trace-events | 21 +
2 files changed, 41 insertions(+), 34 deletions(-)
diff -
From: Nikunj A Dadhania
lxsibzx - Load VSX Scalar as Integer Byte & Zero Indexed
lxsihzx - Load VSX Scalar as Integer Halfword & Zero Indexed
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 2 ++
target-ppc/translate/vsx-impl.inc.c | 2 ++
From: John Arbuckle
The old pc scancode translation is replaced with QEMU's QKeyCode. This is just
a mechanical substitution, which a number of broken mappings left in.
Signed-off-by: John Arbuckle
Signed-off-by: David Gibson
---
hw/input/adb.c | 234 ++
From: Laurent Vivier
Signed-off-by: Laurent Vivier
Reviewed-by: Eric Blake
Signed-off-by: David Gibson
---
hw/ppc/spapr_rtas.c | 30 --
hw/ppc/trace-events | 8
2 files changed, 16 insertions(+), 22 deletions(-)
diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/
From: Nikunj A Dadhania
xxspltib: VSX Vector Splat Immediate Byte
Copy the immediate byte in each byte of target VSR
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 2 ++
target-ppc/translate/vsx-impl.inc.c | 20
ta
From: Nikunj A Dadhania
Implement macro to consolidate store operations using newer
tcg_gen_qemu_st function.
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
di
From: Nikunj A Dadhania
Make byte-swap routines use the common GEN_QEMU_LOAD macro
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/target-ppc/translate.c b
From: Nikunj A Dadhania
Use macro for st64 as well, this changes the function signature from
gen_qemu_st64 => gen_qemu_st64_i64. Replace this at all the call sites.
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 37 ++
From: Nikunj A Dadhania
Being a 16byte operation, qemu_ld/st still does not support this. Move
this out so other store operation can use qemu_ld/st in the following
patch. Also, convert it to two MO_Q operations for stqcx.
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
targe
Now that we allow CPU hot unplug on a few platforms, we can end up in a
situation where we don't have a CPU with index 0. Or at least we could,
if we didn't have code to explicitly prohibit unplug of CPU 0.
Longer term we want to allow CPU 0 unplug, this patch is an early step in
allowing this, b
From: Thomas Huth
QEMU currently refuses to start with KVM-PR and only prints out
qemu: fatal: Unknown MMU model 851972
when being started there. This is because commit 4322e8ced5aaac719
("ppc: Fix 64K pages support in full emulation") introduced a new
POWERPC_MMU_64K bit to indicate su
From: Michael Walle
Only the POWER[789] CPUs should have the ARCH_206 bit set. This is what the
linux kernel does. I guess this was also the intention of commit 0e019746.
We have to make sure all *206 bits are set.
Before this patch, the flags check in the GET_FEATURES2 macro returned true
if _a
From: Nikunj A Dadhania
Use tcg_gen_qemu_st store conditional instructions.
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 58 +-
1 file changed, 24 insertions(+), 34 deletions(-)
diff --git a/target-p
From: Nathan Whitehorn
These are mandatory per PAPR and available on Linux 4.3 and newer kernels. The
calls in question are required to run FreeBSD guests with reasonable
performance, so enable them if possible.
Signed-off-by: Nathan Whitehorn
[dwg: Added a stub to fix compile without KVM (e.
From: Laurent Vivier
Signed-off-by: Laurent Vivier
Reviewed-by: Eric Blake
Signed-off-by: David Gibson
---
hw/scsi/spapr_vscsi.c | 88 +--
hw/scsi/trace-events | 27
2 files changed, 63 insertions(+), 52 deletions(-)
diff --gi
From: Nikunj A Dadhania
tlbie (BookS) and tlbivax (BookE) plus the H_CALLs(pseries) should have
a global effect.
Introduces TLB_NEED_GLOBAL_FLUSH flag. During lazy tlb flush, after
taking care of pending local flushes, check broadcast flush(at context
synchronizing event ptesync/tlbsync, etc) is
From: Ravi Bangoria
darn: Deliver A Random Number
Currently return invalid random number for all the case. This needs
proper algorithm to provide cryptographically suitable random data.
Reading from /dev/random can block and that is not an expected behaviour
while the cpu instruction is getting
From: Bharata B Rao
Each spapr cpu core type defines an instance_init routine which just
populates the CPU class name. This can be done in the class_init
commonly for all core types which simplifies the registration.
This is inspired by how PowerNV core types are registered.
Certain types of spa
From: Rajalakshmi Srinivasaraghavan
The following vector insert instructions are added from ISA 3.0.
vinsertb - Vector Insert Byte
vinserth - Vector Insert Halfword
vinsertw - Vector Insert Word
vinsertd - Vector Insert Doubleword
Signed-off-by: Rajalakshmi Srinivasaraghavan
Signed-off-by: Dav
From: Nikunj A Dadhania
Use macro for ld64 as well, this changes the function signature from
gen_qemu_ld64 => gen_qemu_ld64_i64. Replace this at all the call sites.
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 39 +++---
From: Benjamin Herrenschmidt
This will make life easier for dealing with dynamically configured
ICSes such as PHB3
Signed-off-by: Benjamin Herrenschmidt
Reviewed-by: David Gibson
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
include/hw/ppc/xics.h | 2 +-
1 file changed, 1
From: Nikunj A Dadhania
Introduces bit-flag in CPUPPCState::tlb_need_flush:
TLB_NEED_LOCAL_FLUSH (0x1) - Flush local tlb
This would indicate a pending local tlb flush (isync instructions,
interrupts, ...)
Signed-off-by: Nikunj A Dadhania
Reviewed-by: David Gibson
Signed-off-by: David Gibso
From: Nikunj A Dadhania
stxsibx - Store VSX Scalar as Integer Byte Indexed
stxsihx - Store VSX Scalar as Integer Halfword Indexed
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 2 ++
target-ppc/translate/vsx-impl.inc.c | 3 +++
target-pp
From: Nikunj A Dadhania
We flush the qemu TLB lazily. check_tlb_flush is called whenever we hit
a context synchronizing event or instruction that requires a pending
flush to be performed.
However, we fail to handle broadcast TLB flush operations. In order to
fix that efficiently, we want to diff
From: Nikunj A Dadhania
Fix inconsistent irq status, because of this in the trace logs, for e.g.
LSI status was 0x7, i.e. XICS_STATUS_ASSERTED, XICS_STATUS_SENT and
XICS_STATUS_REJECTED all set, which did not make sense. So the REJECTED
would have been set in earlier interrupt cycle, and then ass
From: Rajalakshmi Srinivasaraghavan
The following vector count trailing zeros instructions are
added from ISA 3.0.
vctzb - Vector Count Trailing Zeros Byte
vctzh - Vector Count Trailing Zeros Halfword
vctzw - Vector Count Trailing Zeros Word
vctzd - Vector Count Trailing Zeros Doubleword
Signed
From: Nikunj A Dadhania
Use tcg_gen_qemu_ld in the load with reservation instructions.
Signed-off-by: Nikunj A Dadhania
Signed-off-by: David Gibson
---
target-ppc/translate.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/target-ppc/translate.c b/
On Tue, 20 Sep 2016 12:54:31 -0700
Richard Henderson wrote:
> Let us merge patch set v18.
>
>
> r~
>
>
>
> The following changes since commit ebc231d7daf1f41b23d8b6a6d1234800b86e5fe2:
>
> Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20160915.0'
> into staging (2016-09-1
From: Rajalakshmi Srinivasaraghavan
Add vpermr instruction from ISA 3.0.
Signed-off-by: Rajalakshmi Srinivasaraghavan
Signed-off-by: David Gibson
---
target-ppc/helper.h | 1 +
target-ppc/int_helper.c | 23 +++
target-ppc/translate/vmx-impl.inc
Already fixed by a Ben's non applied patch:
http://patchwork.ozlabs.org/patch/655238/
Laurent
On 21/09/2016 19:06, Laurent Vivier wrote:
> When used in linux-user mode, tlb_vaddr_to_host(..., addr, ...))
> should return "g2h(addr)", but instead it returns "g2h(vaddr)".
> As "vaddr" is "typedef
On 2016年09月15日 14:14, Dmitry Fleytman wrote:
This patch fixes incorrect check for
interrypt type being used.
PBSCLR register is valid for MSI-X only.
See spec. 10.2.3.13 MSI—X PBA Clear
Signed-off-by: Dmitry Fleytman
---
hw/net/e1000e_core.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
From: Laurent Vivier
Add a first test to validate the protocol:
- rtas/get-time-of-day compares the time
from the guest with the time from the host.
Signed-off-by: Laurent Vivier
Reviewed-by: Greg Kurz
Signed-off-by: David Gibson
---
hw/ppc/spapr_rtas.c | 19
include/
> -Original Message-
> From: Greg Kurz [mailto:gr...@kaod.org]
> Sent: Thursday, September 22, 2016 2:43 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Kevin Wolf; Michael S. Tsirkin; Jason Wang; Max
> Reitz; Aneesh Kumar K.V; Stefan Hajnoczi; Cornelia Huck; Paolo Bonzini
> Subject:
On 2016年09月14日 23:12, Eric Blake wrote:
On 09/14/2016 09:17 AM, Greg Kurz wrote:
On Tue, 13 Sep 2016 17:11:54 +1000
Alexey Kardashevskiy wrote:
The tap backend is already using qemu-bridge-helper to attach tap
interface to a bridge but (unlike the bridge backend) it always uses
the default
On Thu, 22 Sep 2016 09:19:49 +0800
Gonglei wrote:
> On 2016/9/21 21:13, Greg Kurz wrote:
> > This series is a follow up to Stefan's work to eradicate most calls to
> > exit() we currently have in the virtio code.
> >
> > It addresses all exit() call sites in the blk, net and scsi device code,
>
On Wed, 21 Sep 2016 15:00:21 -0500
Eric Blake wrote:
> On 09/21/2016 02:42 PM, Thomas Huth wrote:
> > Basic idea of this script is to check the git log for URLs
> > to the QEMU bugtracker at launchpad.net and to figure out
> > whether the related bug has been marked there as "Fix released"
> > (i
On Wed, 21 Sep 2016 22:08:10 +0200
Paolo Bonzini wrote:
> On 21/09/2016 21:42, Thomas Huth wrote:
> > Basic idea of this script is to check the git log for URLs
> > to the QEMU bugtracker at launchpad.net and to figure out
> > whether the related bug has been marked there as "Fix released"
> > (i
Hi, Paolo
Thanks for your suggestions, although I don't comply with the idea of rtc_delta
yet.
But beyond this, I understand your position, and I think the principle you
insist on,
I mean being simpler, is necessary for the health and sustainability of the
project.
I'll submit a simpler patch fo
On Thu, Sep 22, 2016 at 03:20:48PM +1000, David Gibson wrote:
> On Wed, Sep 21, 2016 at 12:58:54PM +0800, Peter Xu wrote:
> > IOMMU Notifier list is used for notifying IO address mapping changes.
> > Currently VFIO is the only user.
> >
> > However it is possible that future consumer like vhost wo
On 2016年09月19日 19:59, Paolo Bonzini wrote:
On 19/09/2016 02:33, Alexey Kardashevskiy wrote:
On 15/09/16 07:04, Paolo Bonzini wrote:
On 13/09/2016 09:11, Alexey Kardashevskiy wrote:
The tap backend is already using qemu-bridge-helper to attach tap
interface to a bridge but (unlike the bridg
Hi, Riku,
Thanks a lots for your review.
I have no problem deleting "#ifdef TARGET_NR_adjtimex" in strace.c.
However, I want to bring to your attention the case of future target Linux
platforms seizing supporting adjtimex(). Let's say this reflects in such a way
that TARGET_NR_adjtimex is not
On 2016年09月16日 21:27, Peter Lieven wrote:
Am 30.06.2016 um 15:39 schrieb Stefan Hajnoczi:
On Thu, Jun 30, 2016 at 11:49:40AM +0200, Peter Lieven wrote:
we only need to allocate enough memory to hold the packet. This
might be
less than NET_BUFSIZE. Additionally fail early if the packet is lar
On Thu, 22 Sep 2016 07:30:52 +0200
Thomas Huth wrote:
> On Thu, 22 Sep 2016 11:57:15 +1000
> David Gibson wrote:
>
> > On Wed, Sep 21, 2016 at 10:22:11AM +0200, Thomas Huth wrote:
> > > On 20.09.2016 16:39, Cédric Le Goater wrote:
> > > > On 09/20/2016 04:24 PM, Thomas Huth wrote:
> > > >> On 2
Paolo Bonzini writes:
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index dde3f5f..3afa19a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2407,7 +2407,7 @@ sub proce
On Thu, 22 Sep 2016 06:55:43 +
"Gonglei (Arei)" wrote:
> > -Original Message-
> > From: Greg Kurz [mailto:gr...@kaod.org]
> > Sent: Thursday, September 22, 2016 2:43 PM
> > To: Gonglei (Arei)
> > Cc: qemu-devel@nongnu.org; Kevin Wolf; Michael S. Tsirkin; Jason Wang; Max
> > Reitz; Ane
Hi Greg,
> -Original Message-
> From: Greg Kurz [mailto:gr...@kaod.org]
> Sent: Thursday, September 22, 2016 3:22 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Kevin Wolf; Michael S. Tsirkin; Jason Wang; Max
> Reitz; Aneesh Kumar K.V; Stefan Hajnoczi; Cornelia Huck; Paolo Bonzini
> -Original Message-
> From: Greg Kurz [mailto:gr...@kaod.org]
> Sent: Thursday, September 22, 2016 3:22 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Kevin Wolf; Michael S. Tsirkin; Jason Wang; Max
> Reitz; Aneesh Kumar K.V; Stefan Hajnoczi; Cornelia Huck; Paolo Bonzini
> Subject:
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1474525997-318296-1-git-send-email-arei.gong...@huawei.com
Subject: [Qemu-devel] [PATCH] crypto: add
On 21/09/2016 23:21, Benjamin Herrenschmidt wrote:
> We use the wrong argument name for the g2h() macro !
>
> The result ends up being something like (target_ulong)(uint64) + guest_base
> which is obviously wrong.
>
> Signed-off-by: Benjamin Herrenschmidt
Reviewed-by: Laurent Vivier
Tested-b
On Wed, Sep 21, 2016 at 11:41:26PM +0400, Marc-André Lureau wrote:
> Since commit ad739706bbadee49, user_creatable_add_type() expects to be
> given a qdict. However, if object-add is called without props, you reach
> the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type:
> Assertio
After making memory consistent between source and destination
(https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03069.html), there can
still reproduce instruction emulation failure in destination side if migration
when VM’s in grub stage:
[2016-09-15 06:29:24] monitor_qapi_event_emit:47
On 2016-09-21 19:06, Laurent Vivier wrote:
> When used in linux-user mode, tlb_vaddr_to_host(..., addr, ...))
> should return "g2h(addr)", but instead it returns "g2h(vaddr)".
> As "vaddr" is "typedef uint64_t", the result of "g2h(vaddr)" is
> "((void *)((unsigned long)(target_ulong)(uint64_t) + gu
On Wed, 21 Sep 2016 12:44:59 +0100
Leon Alrae wrote:
> Hi,
>
> What's the procedure to update / who can update QEMU's dtc mirror
> git://git.qemu.org/dtc.git which is used as submodule?
>
> There's a patch series relying on the dtc v1.4.2 tag:
> https://lists.nongnu.org/archive/html/qemu-devel/
On 22/09/2016 07:55, Peter Xu wrote:
> I posted patch 3 just to make sure everything is coherent, and let
> Paolo decide which way to choose (since I still think it's okay
> actually... but again both are ok to me). Also it'll be easier for
> Jason to track this down as well (so when Jason sees t
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1474526262-27011-1-git-send-email-da...@gibson.dropbear.id.au
Subject: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
On Thu, Sep 22, 2016 at 02:35:49PM +0800, Gonglei wrote:
> CCtests/test-crypto-tlscredsx509.o
> CCtests/crypto-tls-x509-helpers.o
> CCtests/pkix_asn1_tab.o
> tests/pkix_asn1_tab.c:7:22: warning: libtasn1.h: No such file or directory
> tests/pkix_asn1_tab.c:9: error: expected ‘=’,
Fix events.flags (KVM_VCPUEVENT_VALID_SMM) overwritten by 0.
Signed-off-by: He Rongguang
---
Note without patch 2, this would result in kvm-kmod crash, as described in
patch 2
---
target-i386/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/kvm.c b/target-i
On Thu, 22 Sep 2016 07:38:29 +
"Gonglei (Arei)" wrote:
> Hi Greg,
>
>
>
> > -Original Message-
> > From: Greg Kurz [mailto:gr...@kaod.org]
> > Sent: Thursday, September 22, 2016 3:22 PM
> > To: Gonglei (Arei)
> > Cc: qemu-devel@nongnu.org; Kevin Wolf; Michael S. Tsirkin; Jason Wang
This fixes a Qemu crash that introduced by commit ad73970
("qom: Wrap prop visit in visit_start_struct").
Not all of the callers of user_creatable_add_type always pass qdict,
so we should check qdict against NULL, but not raise an assertion.
The problem can be easily triggered by adding an iothre
On Thu, Sep 22, 2016 at 07:05:11AM +, Aleksandar Markovic wrote:
> Hi, Riku,
>
> Thanks a lots for your review.
>
> I have no problem deleting "#ifdef TARGET_NR_adjtimex" in strace.c.
>
> However, I want to bring to your attention the case of future target Linux
> platforms seizing supporti
On Wed, Sep 21, 2016 at 01:18:58PM -0500, Eric Blake wrote:
> On 09/21/2016 10:28 AM, Markus Armbruster wrote:
>
> >> The compiler.h file has no license header, just a comment
> >> saying "public domain", which is obviously not the case
> >> if you add this macro.
> >>
> >> Given that you'll need
On Thu, Sep 22, 2016 at 12:10:17AM +0400, Marc-André Lureau wrote:
> The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
> parameters, but the qapi qmp_dispatch() code uses
> QERR_INVALID_PARAMETER_TYPE.
>
> Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where
> appropri
On Thu, Sep 22, 2016 at 12:17:43AM -0700,
no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Hi,
>
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce
> it
> locally.
> GTESTER tes
>> @@ -493,6 +525,8 @@ static void pnv_chip_power9_class_init(ObjectClass
>> *klass, void *data)
>> k->chip_cfam_id = 0x100d10498000ull; /* P9 Nimbus DD1.0 */
>> k->cores_mask = POWER9_CORE_MASK;
>> k->core_pir = pnv_chip_core_pir_p9;
>> +k->xscom_addr = pnv_chip_xscom_addr_
On Thu, 14 Jul 2016 13:56:09 +0800
Peter Xu wrote:
> This is v12 for Intel IR. Rebased to lastest master, with some tiny
> tweaks from v11. Please check changelog below.
Hi Peter,
While testing current master 9b8595bc with merged IR remapping
and default IDE disk as following:
qemu-system-x86_
On Thu, 22 Sep 2016 10:14:56 +0200
Greg Kurz wrote:
> On Thu, 22 Sep 2016 07:38:29 +
> "Gonglei (Arei)" wrote:
> > I saw virtio_error() only handle the virtio 1.0 device, the legacy virtio
> > device may
> > still stuck, am I right?
> >
>
> The DEVICE_NEEDS_RESET bit was introduced by th
On 09/21/2016 08:12 AM, David Gibson wrote:
> On Thu, Sep 15, 2016 at 02:45:58PM +0200, Cédric Le Goater wrote:
>> Now that we are using real HW ids for the cores in PowerNV chips, we
>> can route the XSCOM accesses to them. We just need to attach a
>> specific XSCOM memory region to each core in t
Hi Alex,
At 09/01/2016 03:56 AM, Alex Williamson wrote:
On Tue, 19 Jul 2016 15:38:23 +0800
Zhou Jie wrote:
From: Chen Fan
When assigning a vfio device with AER enabled, we must check whether
the device supports a host bus reset (ie. hot reset) as this may be
used by the guest OS in order to
It's 2.8 now, and maybe it's time to switch IOAPIC default version to
0x20.
Signed-off-by: Peter Xu
---
hw/intc/ioapic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index 31791b0..fd9208f 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioap
"Lin Ma" writes:
Markus Armbruster 2016/9/20 星期二 上午 1:13 >>>
>>Andreas Färber writes:
>>
>>> Hi Lin and Markus,
>>>
>>> Am 19.09.2016 um 13:58 schrieb Markus Armbruster:
>>[...]
You're messing with struct EnumProperty because you want more help than
what ObjectPropertyInfo can pr
Marc-André Lureau writes:
> Hi
>
> - Original Message -
>> On 09/13/2016 08:01 AM, Marc-André Lureau wrote:
>> > Signed-off-by: Marc-André Lureau
>> > ---
>> > docs/qmp-commands.txt | 29 -
>> > qapi-schema.json | 13 +
>> > 2 files changed,
The format/h.py file adds an include for control.h to
generated-tracers.h. ftrace, log and syslog, then
add more duplicate includes for control.h.
Reviewed-by: Lluís Vilanova
Signed-off-by: Daniel P. Berrange
---
scripts/tracetool/backend/ftrace.py | 1 -
scripts/tracetool/backend/log.py| 3
Currently methods which want to iterate over trace events,
do so using the trace_event_count() and trace_event_id()
methods. This leaks the concept of a single ID enum to
the callers. There is an alternative trace_event_pattern()
method which can be used in an iteration context, but its
design is s
Instead of having a global dstate array, declare a single
'uint16 TRACE_${EVENT_NAME}_DSTATE' variable for each
trace event. Record a pointer to this variable in the
TraceEvent struct too.
By turning trace_event_get_state_dynamic_by_id into a
macro, this still hits the fast path, and cache affinit
These patches were previously posted as part of my giant
trace events modular build series
v1: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg01714.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03335.html
This series does all the refactoring required to support a
This converts the HMP/QMP monitor API implementations
and some internal trace control methods to use the new
trace event iterator APIs.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Daniel P. Berrange
---
monitor.c | 26 ++
trace/control.c | 85 ++
Currently simpletrace assumes that events are given IDs
starting from 0, based on the order in which they appear
in the trace-events file, with no gaps. When the
trace-events file is split up, this assumption becomes
problematic.
To deal with this, extend the simpletrace format so that
it outputs
The TraceEventID and TraceEventVCPUID enums constants are
no longer actually used for anything critical.
The TRACE_EVENT_COUNT limit is used to determine the size
of the TraceEvents array, and can be removed if we just
NULL terminate the array instead.
The TRACE_VCPU_EVENT_COUNT limit is used as
Currently we only expose a TraceEvent array, which must
be indexed via the TraceEventID enum constants. This
changes the generator to expose a named TraceEvent
instance for each event, with an _EV suffix.
Signed-off-by: Daniel P. Berrange
---
scripts/tracetool/__init__.py| 1 +
scripts/
The trace_event_count, trace_event_id and
trace_event_pattern methods are no longer required
now that everything is using the iterator APIs
The trace_event_set_state and trace_event_set_vcpu_state
macros were also unused.
Reviewed-by: Lluís Vilanova
Signed-off-by: Daniel P. Berrange
---
trace/
Instead of having the code generator assign event IDs and
event VCPU IDs, assign them when the events are registered
at runtime. This will allow us allow code to be generated
from individual trace-events without having to figure out
globally unique numbering at build time.
Signed-off-by: Daniel P.
> -Original Message-
> From: Daniel P. Berrange [mailto:berra...@redhat.com]
> Sent: Thursday, September 22, 2016 4:17 PM
> To: qemu-devel@nongnu.org
> Cc: Gonglei (Arei); f...@redhat.com; Wubin (H)
> Subject: Re: [Qemu-devel] [PATCH] crypto: add CTR mode support
>
> On Thu, Sep 22, 2016
Currently event-internal.h includes generated-events.h,
while generated-events.h includes event-internal.h
causing a circular dependency.
event-internal.h requires that the content of
generated-events.h comes first, so that it can see
the typedefs for TraceEventID and TraceEventVCPUID.
Switching
On 09/22/2016 10:11 AM, Thomas Huth wrote:
On Wed, 21 Sep 2016 12:44:59 +0100
Leon Alrae wrote:
Hi,
What's the procedure to update / who can update QEMU's dtc mirror
git://git.qemu.org/dtc.git which is used as submodule?
There's a patch series relying on the dtc v1.4.2 tag:
https://lists.non
Currently the generated-events.[ch] files contain the
event dstates, constants and TraceEvent structs, while the
generated-tracers.[ch] files contain the actual trace
probe logic. With the removal of usage of the event enums
from the API there is no longer any compelling reason for
the separation b
The _read_events method is used by callers outside of
its module, so should be a public method, not private.
Reviewed-by: Lluís Vilanova
Signed-off-by: Daniel P. Berrange
---
scripts/simpletrace.py| 6 +++---
scripts/tracetool/__init__.py | 14 --
2 files changed, 15 insert
Move the reading of events out of the 'tracetool.generate'
method and into tracetool.main, so that the latter is not
tied to generating from a single source of events.
Reviewed-by: Lluís Vilanova
Signed-off-by: Daniel P. Berrange
---
scripts/tracetool.py | 4 +++-
scripts/tracetool/__i
If the ftrace backend is compiled into QEMU, any attempt
to start QEMU while non-root will fail due to the
inability to open /sys/kernel/debug/tracing/trace_on.
Add a fallback into the code so that it connects up the
trace_marker_fd variable to /dev/null when setting
EACCESS on the 'trace_on' file
Instead of reading the contents of 'trace-events' from stdin,
accept the filename as a positional parameter. This also
allows for reading from multiple files, though this facility
is not used at this time.
Signed-off-by: Daniel P. Berrange
---
Makefile.target | 6 +++---
scripts/tracetool.
>> +static ISABus *pnv_isa_create(PnvChip *chip)
>> +{
>> +PnvLpcController *lpc = &chip->lpc;
>> +ISABus *isa_bus;
>> +qemu_irq *irqs;
>> +PnvChipClass *pcc = PNV_CHIP_GET_CLASS(chip);
>> +
>> +/* Instanciate ISA bus. let isa_bus_new() create its own bridge on
>
> Instantiate
Hi
- Original Message -
> Marc-André Lureau writes:
>
> > Hi
> >
> > - Original Message -
> >> On 09/13/2016 08:01 AM, Marc-André Lureau wrote:
> >> > Signed-off-by: Marc-André Lureau
> >> > ---
> >> > docs/qmp-commands.txt | 29 -
> >> > qapi-schema
Remove the notion of there being a single global array
of trace events, by introducing a method for registering
groups of events.
Signed-off-by: Daniel P. Berrange
---
include/qemu/module.h| 2 ++
qemu-img.c | 1 +
qemu-io.c
> -Original Message-
> From: Daniel P. Berrange [mailto:berra...@redhat.com]
> Sent: Thursday, September 22, 2016 4:12 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Wubin (H)
> Subject: Re: [PATCH] qtest: fix make check complaint in crypto module
>
> On Thu, Sep 22, 2016 at 02:35:
On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote:
> Don't make up a description in user_creatable_help_func(), improve the
> description infrastructure and its use so you get more useful ones
> there.
>
> The existing description infrastructure is just Property member
> descriptio
On Thu, Sep 22, 2016 at 10:29:39AM +0200, Igor Mammedov wrote:
> On Thu, 14 Jul 2016 13:56:09 +0800
> Peter Xu wrote:
>
> > This is v12 for Intel IR. Rebased to lastest master, with some tiny
> > tweaks from v11. Please check changelog below.
>
> Hi Peter,
>
> While testing current master 9b859
The CPUState struct has a bitmap tracking which VCPU
events are currently active. This is indexed based on
the event ID values, and sized according the maximum
TraceEventVCPUID enum value.
When we start dynamically assigning IDs at runtime,
we can't statically declare a bitmap without making
an as
> On 22 Sep 2016, at 09:40 AM, Jason Wang wrote:
>
>
>
> On 2016年09月15日 14:14, Dmitry Fleytman wrote:
>> This patch fixes incorrect check for
>> interrypt type being used.
>>
>> PBSCLR register is valid for MSI-X only.
>>
>> See spec. 10.2.3.13 MSI—X PBA Clear
>>
>> Signed-off-by: Dmitry Fl
On 22/09/2016 07:37, Pavel Dovgalyuk wrote:
>> > I mean that (if I understand correctly) raw images are corrupted if you
>> > don't use -snapshot (the record overwrites them, and the replay reads
>> > overwritten data).
> I tried running record/replay with raw image. Record finished without an
>
On 22/09/2016 00:27, Emilio G. Cota wrote:
> Another suggestion is to consistently access pending_cpus atomically,
> since now we're accessing it with and without the CPU list mutex held.
Yeah, that's a bit of a pain in the ass, but it's a good idea.
Paolo
1 - 100 of 659 matches
Mail list logo
