Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906

2016-09-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906 Type: series Message-id: 1473133396-18940-1-git-send-email-da...@gibson.dropbear.id.au === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-06 Thread Ashijeet Acharya
On Mon, Sep 5, 2016 at 11:37 PM, Ashijeet Acharya wrote: > On Mon, Sep 5, 2016 at 11:26 PM, Daniel P. Berrange > wrote: >> On Mon, Sep 05, 2016 at 11:20:11PM +0530, Ashijeet Acharya wrote: >>> Mark old-commands for speed and downtime as deprecated. >>> Move max-bandwidth and downtime-limit into

Re: [Qemu-devel] [PATCH] crypto: report enum strings instead of values in errors

2016-09-06 Thread Markus Armbruster
"Daniel P. Berrange" writes: > Several error messages print out the raw enum value, which > is less than helpful to users, as these values are not > documented, nor stable across QEMU releases. Switch to use > the enum string instead. > > The nettle impl also had two typos where it said "algorith

Re: [Qemu-devel] [PATCH RFC 4/4] target-ppc: flush tlb from all the cpu

2016-09-06 Thread Nikunj A Dadhania
Benjamin Herrenschmidt writes: > On Tue, 2016-09-06 at 10:23 +0530, Nikunj A Dadhania wrote: >> > >> > No there isn't. You can start qemu with --smp 4 and have 4 CPUs. >> >> That case was prevented to even start in case of TCG. That is why I had >> to add "target-ppc: with MTTCG report more thre

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-06 Thread Roman Kagan
On Tue, Sep 06, 2016 at 04:45:13AM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 05, 2016 at 11:02:36AM +0300, Roman Kagan wrote: > > On Sat, Sep 03, 2016 at 01:53:53AM +0300, Michael S. Tsirkin wrote: > > > On Fri, Sep 02, 2016 at 10:21:58AM +0300, Roman Kagan wrote: > > > > On Thu, Sep 01, 2016

Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

2016-09-06 Thread Mark Cave-Ayland
On 06/09/16 01:16, David Gibson wrote: > On Mon, Sep 05, 2016 at 09:51:09PM +0100, Mark Cave-Ayland wrote: >> On 05/09/16 21:30, Cédric Le Goater wrote: >> Shall we disable rfi now for QEMU 2.8 ? Cédric, could you maybe send a patch with that hunk again? >>> >>> Sure. I have kept it in a

[Qemu-devel] [PATCH 2/3] vfio/pci: pass an error object to vfio_populate_device

2016-09-06 Thread Eric Auger
Let's expand the usage of QEMU Error objects to vfio_populate_device. Signed-off-by: Eric Auger --- hw/vfio/pci.c | 45 - 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index ae1967c..f7768e9 100644 --- a/

[Qemu-devel] [PATCH 0/3] Convert VFIO-PCI to realize

2016-09-06 Thread Eric Auger
This series converts VFIO-PCI to realize. It also aims at improving the error reporting in case of QMP hot-plug. Before the series, a device_add failure would have reported: {"error": {"class": "GenericError", "desc": "Device initialization failed"}}. Now the actual error cause is reported. Eric

[Qemu-devel] [PATCH 1/3] vfio/pci: conversion to realize

2016-09-06 Thread Eric Auger
This patch converts VFIO PCI to realize function. Also original initfn errors now are propagated using QEMU error objects. All errors are formatted with the same pattern: "vfio: %s: the error description" Subsequent patches will pass the error objects to - vfio_populate_device, - vfio_msix_early_

[Qemu-devel] [PATCH 3/3] vfio/pci: pass an error object to vfio_msix_early_setup

2016-09-06 Thread Eric Auger
Let's expand the usage of QEMU Error objects to vfio_msix_early_setup. Signed-off-by: Eric Auger --- hw/vfio/pci.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index f7768e9..b132bf1 100644 --- a/hw/vfio/pci.c ++

Re: [Qemu-devel] [PATCH 0/2] qom-get [for 2.8]

2016-09-06 Thread Paolo Bonzini
On 05/09/2016 20:50, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 25/08/2016 11:37, Dr. David Alan Gilbert (git) wrote: >>> >>> (qemu) qom-get /backend/console[0]/device/vga.rom[0] size >>> 65536 (0x1) >>> >>> (qemu) qom-get /machine smm >>> "auto"

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix wildcard for scsi headers

2016-09-06 Thread Paolo Bonzini
On 05/09/2016 22:11, Thomas Huth wrote: > get_maintainer.pl currently thinks that the scsi headers are > currrently unmaintained. So let's fix the corresponding wildcard > expression. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Qemu-devel] [PATCH v2] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-06 Thread Ashijeet Acharya
Mark old-commands for speed and downtime as deprecated. Move max-bandwidth and downtime-limit into migrate-set-parameters for setting maximum migration speed and expected downtime limit parameters respectively. Change downtime units to milliseconds (only for new-command) and update the query part i

Re: [Qemu-devel] [PATCH v2 0/2] Delay initialization of memory backends

2016-09-06 Thread Maxime Coquelin
On 09/06/2016 04:24 AM, Michael S. Tsirkin wrote: On Mon, Sep 05, 2016 at 04:01:30PM -0300, Eduardo Habkost wrote: On Mon, Sep 05, 2016 at 02:26:30PM +0200, Paolo Bonzini wrote: On 02/09/2016 20:59, Eduardo Habkost wrote: While trying to fix the original bug in v1, another bug was fixed by a

Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object

2016-09-06 Thread Cédric Le Goater
On 09/05/2016 03:45 AM, David Gibson wrote: > On Tue, Aug 30, 2016 at 09:23:40AM +0200, Cédric Le Goater wrote: >> On 08/30/2016 08:15 AM, Benjamin Herrenschmidt wrote: >>> On Mon, 2016-08-29 at 10:30 -0400, David Gibson wrote: Possibly. In fact, I'm planning to eliminate cpu->cpu_dt_id

Re: [Qemu-devel] [PATCH 0/3] Remove some unused CONFIG_* variables

2016-09-06 Thread Paolo Bonzini
On 05/09/2016 19:25, Daniel P. Berrange wrote: > There are a few CONFIG_* variables defined in default-configs/ > that are never referenced. These were found using: > > $ for i in `grep -h -E '^CONFIG' default-configs/* | sed -e 's/=.*//' | > sort | uniq` > do > echo -n "$i: " > gi

[Qemu-devel] [PULL 18/38] s390x/cpumodel: store the CPU model in the CPU instance

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand A CPU model consists of a CPU definition, to which delta changes are applied - features added or removed (e.g. z13-base,vx=on). In addition, certain properties (e.g. cpu id) can later on change during migration but belong into the CPU model. This data will later be filled

[Qemu-devel] [PULL 00/38] First set of s390x patches for 2.8

2016-09-06 Thread Cornelia Huck
The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: Open 2.8 development tree (2016-09-05 11:38:54 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20160906 for you to fetch changes up to

[Qemu-devel] [PULL 06/38] s390x/ioinst: advertise fcs facility

2016-09-06 Thread Cornelia Huck
As we provide format 1 chsc scpd data (and don't support any ficon channels), we de facto already have the ficon-cascaded-switch facility. Reviewed-by: Pierre Morel Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- target-s390x/ioinst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[Qemu-devel] [PULL 02/38] s390x/pci: return directly if create zpci failed

2016-09-06 Thread Cornelia Huck
From: Yi Min Zhao In the case that zpci is automatically created, we did not return immediately on failure, which would lead to NULL pointer dereferencing. Let's fix it. Signed-off-by: Yi Min Zhao Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 03/38] s390x/pci: assert zpci always existing

2016-09-06 Thread Cornelia Huck
From: Yi Min Zhao If one pci device is plugged successfully, there must be a zpci device existing. This means that during hot-unplugging a pci device, its corresponding zpci device must be found. Therefore we use an assert to replace current code. Signed-off-by: Yi Min Zhao Signed-off-by: Corne

[Qemu-devel] [PULL 08/38] linux-headers: update

2016-09-06 Thread Cornelia Huck
Update headers against 4.8-rc2. Signed-off-by: Cornelia Huck --- include/standard-headers/linux/input-event-codes.h | 32 include/standard-headers/linux/input.h | 1 + include/standard-headers/linux/virtio_config.h | 10 ++- include/standard-headers/linux/virtio_ids.h

[Qemu-devel] [PULL 20/38] s390x/cpumodel: let the CPU model handle feature checks

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand If we have certain features enabled, we have to migrate additional state (e.g. vector registers or runtime-instrumentation registers). Let the CPU model control that unless we have no "host" CPU model in the KVM case. This will later on be the case for compatibility machin

[Qemu-devel] [PULL 01/38] s390x: add compat machine for 2.8

2016-09-06 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 18 +- include/hw/compat.h| 3 +++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 91d9cef..3bfd6cc 100644 --- a/hw/s390x/s390-virtio

[Qemu-devel] [PULL 12/38] s390x/cpumodel: expose CPU class properties

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's expose the description and migration safety and whether a definition is static, as class properties, this can be helpful in the future. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-4-d...@linux.vnet.ibm.com> Signed-off

[Qemu-devel] [PULL 15/38] s390x/cpumodel: generate CPU feature group lists

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Feature groups will be very helpful to reduce the amount of features typically available in sane configurations. E.g. the MSA facilities introduced loads of subfunctions, which could - in theory - go away in the future, but we want to avoid reporting hundrets of features t

[Qemu-devel] [PULL 19/38] s390x/cpumodel: expose features and feature groups as properties

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's add all features and feature groups as properties to all CPU models. If the "host" CPU model is unknown, we can neither query nor change features. KVM will just continue to work like it did until now. We will not allow to enable features that were not part of the or

[Qemu-devel] [PULL 04/38] s390/sclp: cache the sclp device

2016-09-06 Thread Cornelia Huck
From: Christian Borntraeger With the current code a simple sclp command takes about 13000 ns The biggest part seems to be the resolver of the object model. By caching the sclp device the time for an sclp command goes down to 2500ns. Talking about real life scenarios, this change doubles the speed

[Qemu-devel] [PULL 34/38] qmp: add QMP interface "query-cpu-model-comparison"

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's provide a standardized interface to compare two CPU models. "query-cpu-model-compare" takes two models and returns how they compare in a specific configuration. The result will give guarantees about runnability. E.g. if a CPU model A is a subset of CPU model B, mod

[Qemu-devel] [PULL 25/38] s390x/sclp: propagate the ibc val (lowest and unblocked ibc)

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand If we have a lowest ibc, we can indicate the ibc to the guest. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-17-d...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 2 ++ include/hw/s390x/s

[Qemu-devel] [PULL 05/38] s390x: wrap flic savevm calls into vmstate

2016-09-06 Thread Cornelia Huck
Just a simple conversion to get rid of register_savevm. Signed-off-by: Cornelia Huck --- hw/intc/s390_flic_kvm.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c index fef8080..21ac2

[Qemu-devel] [PULL 14/38] s390x/cpumodel: generate CPU feature lists for CPU models

2016-09-06 Thread Cornelia Huck
From: Michael Mueller This patch introduces the helper "gen-features" which allows to generate feature list definitions at compile time. Its flexibility is better and the error-proneness is lower when compared to static programming time added statements. The helper includes "target-s390x/cpu_fea

[Qemu-devel] [PULL 30/38] s390x/kvm: disable host model for problematic compat machines

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Compatibility machines that touch runtime-instrumentation should not be used with the CPU model. Otherwise the host model will look different, depending on the QEMU machine QEMU has been started with. So let's simply disable the host model for existing compatibility machi

[Qemu-devel] [PULL 29/38] s390x/kvm: implement CPU model support

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's implement our two hooks so we can support CPU models. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-22-d...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck --- target-s390x/cpu_models.c | 75 +++- target-s39

[Qemu-devel] [PULL 11/38] s390x/cpumodel: "host" and "qemu" as CPU subclasses

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand This patch introduces two CPU models, "host" and "qemu". "qemu" is used as default when running under TCG. "host" is used as default when running under KVM. "host" cannot be used without KVM. "host" is not migration-safe. They both inherit from the base s390x CPU, which is

[Qemu-devel] [PULL 10/38] qmp: details about CPU definitions in query-cpu-definitions

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand It might be of interest for tooling whether a CPU definition can be safely used when migrating, or if e.g. CPU features might get lost during migration when migrationg from/to a different QEMU version or host, even if the same compatibility machine is used. Also, we want

[Qemu-devel] [PULL 31/38] s390x/kvm: let the CPU model control CMM(A)

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Starting with recent kernels, if the cmma attributes are available, we actually have hardware support. Enabling CMMA then means providing the guest VCPU with CMM, therefore enabling its CMM facility. Let's not blindly enable CMM anymore but let's control it using CPU mode

[Qemu-devel] [PULL 26/38] s390x/sclp: propagate the mha via sclp

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand The mha is provided in the CPU model, so get any CPU and extract the value. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-18-d...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 1 + includ

[Qemu-devel] [PULL 09/38] s390x/kvm: 2 byte software breakpoint support

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Diag 501 (4 bytes) was used until now for software breakpoints on s390. As instructions on s390 might be 2 bytes long, temporarily overwriting them with 4 bytes is evil and can result in very strange guest behaviour. We make use of invalid instruction 0x as new sw bre

[Qemu-devel] [PULL 07/38] s390x/css: handle cssid 255 correctly

2016-09-06 Thread Cornelia Huck
The cssid 255 is reserved but still valid from an architectural point of view. However, feeding a bogus schid of 0x into the virtio hypercall will lead to a crash: Stack trace of thread 138363: #0 0x100d168c css_find_subch (qemu-system-s390x) #1 0x100d3290

[Qemu-devel] [PULL 35/38] qmp: add QMP interface "query-cpu-model-baseline"

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's provide a standardized interface to baseline two CPU models, to create a third, compatible one. This is especially helpful when two CPU models are not identical, but a CPU model is required that is guaranteed to run under both configurations, where the original model

Re: [Qemu-devel] [PATCH V13 06/12] colo-compare: track connection and enqueue packet

2016-09-06 Thread Zhang Chen
On 09/06/2016 03:51 PM, Jason Wang wrote: On 2016年09月05日 17:37, Zhang Chen wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn lis

[Qemu-devel] [PULL 21/38] s390x/cpumodel: check and apply the CPU model

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand We have to test if a configured CPU model is runnable in the current configuration, and if not report why that is the case. This is done by comparing it to the maximum supported model (host for KVM or z900 for TCG). Also, we want to do some base sanity checking for a confi

[Qemu-devel] [PULL 13/38] s390x/cpumodel: introduce CPU features

2016-09-06 Thread Cornelia Huck
From: Michael Mueller The patch introduces s390x CPU features (most of them refered to as facilities) along with their discription and some functions that will be helpful when working with the features later on. Please note that we don't introduce all known CPU features, only the ones currently

[Qemu-devel] [PULL 22/38] s390x/sclp: factor out preparation of cpu entries

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's factor out the common code of "read cpu info" and "read scp info". This will make the introduction of new cpu entry fields easier. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-14-d...@linux.vnet.ibm.com> Signed-off-by:

[Qemu-devel] [PULL 28/38] s390x/kvm: allow runtime-instrumentation for "none" machine

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand To be able to query the correct host model for the "none" machine, let's allow runtime-instrumentation for that machine. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-21-d...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL 23/38] s390x/sclp: introduce sclp feature blocks

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand The sclp "read cpu info" and "read scp info" commands can include features for the cpu info and configuration characteristics (extended), decribing some advanced features available in the configuration. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id

[Qemu-devel] [PATCH v2 2/2] tests: add RTAS command in the protocol

2016-09-06 Thread Laurent Vivier
Add a first test to validate the protocol: - rtas/get-time-of-day compares the time from the guest with the time from the host. Signed-off-by: Laurent Vivier --- v2: - add a missing space in qrtas_call() prototype hw/ppc/spapr_rtas.c | 19 include/hw/ppc/spapr_rtas.h | 1

[Qemu-devel] [PULL 17/38] s390x/cpumodel: register defined CPU models as subclasses

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand This patch adds the CPU model definitions that are known on s390x - like z900, zBC12 or z13. For each definition, introduce two CPU models: 1. Base model (e.g. z13-base): Minimum feature set we expect to be around on all z13 systems. These models are migration-safe and

[Qemu-devel] [PULL 24/38] s390x/sclp: indicate sclp features

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand We have three different blocks in the SCLP read-SCP information response that indicate sclp features. Let's prepare propagation. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-16-d...@linux.vnet.ibm.com> Signed-off-by: Corneli

[Qemu-devel] [PULL 27/38] s390x/sclp: propagate hmfai

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand hmfai is provided on CPU models >= z196. Let's propagate it properly. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Message-Id: <20160905085244.99980-19-d...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/sclp.c | 1 + include/hw/s

[Qemu-devel] [Bug 1618431] Re: windows hangs after live migration with virtio

2016-09-06 Thread Wry
As the virtio related parts aren't the ones hanging (network and disks still work...) it's unlikely, but it makes a night and day difference. Removing -no-hpet as suggested does seem to make a difference, too. (Changing the tick policy doesn't, for me.) However, I've found that there are various o

[Qemu-devel] [PULL 36/38] s390x/cpumodel: implement QMP interface "query-cpu-model-expansion"

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand In order to expand CPU models, we create temporary cpus that handle the feature/group parsing. Only CPU feature properties are expanded. When converting the data structure back, we always fall back to the static base CPU model, which is by definition migration-safe. Acke

[Qemu-devel] [PULL 16/38] s390x/cpumodel: introduce CPU feature group definitions

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's use the generated groups to create feature group representations for the user. These groups can later be used to enable/disable multiple features in one shot and will be used to reduce the amount of reported features to the user if all subfeatures are in place. We w

Re: [Qemu-devel] [PATCH V13 06/12] colo-compare: track connection and enqueue packet

2016-09-06 Thread Jason Wang
On 2016年09月05日 17:37, Zhang Chen wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn

[Qemu-devel] [PULL 33/38] qmp: add QMP interface "query-cpu-model-expansion"

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's provide a standardized interface to expand CPU models. This interface can be used by tooling to get details about a specific CPU model in a certain configuration, e.g. about the "host" model. To take care of all architectures, two detail levels for an expansion are

[Qemu-devel] [PULL 32/38] s390x/kvm: don't enable key wrapping if msa3 is disabled

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand As the CPU model now controls msa3, trying to set wrapping keys without msa3 being around/enable in the kernel will produce misleading errors. So let's simply not configure key wrapping if msa3 is not enabled and make compat machines with disabled CPU model work correctly

[Qemu-devel] [PATCH v2] block: m25p80c Fix vmstate structure name

2016-09-06 Thread marcin.krzeminski
From: Marcin Krzeminski Correct bad name of the vmstate structure. Since this breaks compatibility also update vmstate version back to 0 and make all fields independent of the VMState version. Signed-off-by: Marcin Krzeminski Acked-by: Alistair Francis --- V2: rewrite commit message hw/block

[Qemu-devel] [PULL 38/38] s390x/cpumodel: implement QMP interface "query-cpu-model-baseline"

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's implement that interface by reusing our conversion code and lookup code for CPU definitions. In order to find a compatible CPU model, we first detect the maximum possible CPU generation and then try to find a maximum model, satisfying all base features (not exceedin

[Qemu-devel] [PULL 37/38] s390x/cpumodel: implement QMP interface "query-cpu-model-comparison"

2016-09-06 Thread Cornelia Huck
From: David Hildenbrand Let's implement that interface by reusing our convertion code implemented for expansion. We use CPU generations and CPU features to calculate the result. This means, that a zEC12 cannot simply be converted into a z13 by stripping of features. This is required, as other ma

Re: [Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy

2016-09-06 Thread Jason Wang
On 2016年09月05日 17:37, Zhang Chen wrote: COLO-proxy is a part of COLO project. COLO project is composed of COLO-frame, COLO-proxy and block-replication. It is used to compare the network package to help COLO decide whether to do checkpoint. With COLO-proxy's help, COLO greatly improves the perfo

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-06 Thread Paolo Bonzini
On 06/09/2016 07:27, Peter Xu wrote: > Maybe I haven't explained the idea very clearly, but device-IOTLB is > not a "flush" of whole device cache. It still needs a IOMMUTLBEntry, > and works just like how general IOMMU invalidations. E.g., we can do > device-IOTLB invalidation for a single 4K pag

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-06 Thread Paolo Bonzini
On 06/09/2016 04:43, Michael S. Tsirkin wrote: > > Based also on the discussion at QEMU summit, where there was consensus > > that three weeks between softfreeze and rc0 was too much, IMO we can > > shorten the period to just two weeks > > Do we intend to strengthen the soft freeze definition th

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-09-06 Thread Lluís Vilanova
Daniel P Berrange writes: > On Mon, Sep 05, 2016 at 08:29:54PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > On Mon, Aug 29, 2016 at 08:46:02PM +0200, Lluís Vilanova wrote: >> >> Stefan Hajnoczi writes: >> >> >> >> > When SystemTap is used the QEMU monitor interface does noth

[Qemu-devel] [PATCH v2 1/2] tests: make pc_alloc_init/init_flags/uninit generic

2016-09-06 Thread Laurent Vivier
And add support for ppc64. Signed-off-by: Laurent Vivier --- v2: - remove useless parenthesis, inline tests/Makefile.include | 3 ++- tests/libqos/libqos.h | 2 +- tests/libqos/malloc-ppc64.c | 38 ++ tests/libqos/malloc-ppc64.h | 17

[Qemu-devel] [PATCH v2 0/2] tests: add RTAS protocol

2016-09-06 Thread Laurent Vivier
This series allows to call RTAS commands from the qtest framework, and defines a first test to call RTAS command "get-time-of-day" to validate the protocol and test RTAS. RTAS command parameters are passed to the guest via the guest memory, so we also need to implement the guest memory management

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-06 Thread Peter Xu
On Tue, Sep 06, 2016 at 09:51:28AM +0200, Paolo Bonzini wrote: > > > On 06/09/2016 07:27, Peter Xu wrote: > > Maybe I haven't explained the idea very clearly, but device-IOTLB is > > not a "flush" of whole device cache. It still needs a IOMMUTLBEntry, > > and works just like how general IOMMU inv

[Qemu-devel] virtio ssd caching

2016-09-06 Thread Aarian P. Aleahmad
Hi there I am looking for a solution to cache a VM on a SSD without the guest knowing about it. We can do it by caching the disk on which the VM's disk is lcoated with a SSD or we can do it through the hypervisor (i.e. Qemu, KVM, etc.). I was thinking about passing an ssd device to the hypervisor

Re: [Qemu-devel] [PATCH v2] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter

2016-09-06 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Mon, Sep 05, 2016 at 03:16:04PM +0200, Paolo Bonzini wrote: >> >> >> On 05/09/2016 15:09, Ashijeet Acharya wrote: >> >>> >> + >> >>> >> "compress-level:i?,compress-threads:i?,decompress-threads:i?,cpu-throttle-initial:i?,cpu-throttle-increment:i?,mi

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-06 Thread Paolo Bonzini
On 06/09/2016 10:17, Peter Xu wrote: > After knowing the possibility that the two consumers might be > mixturely used in the future (as David has mentioned), I'd vote for a > bitmask for notification type: > > IOMMU_NOTIFIER_NONE = 0, > IOMMU_NOTIFIER_INVALIDATION = 1, > IOMMU_NOTIFI

[Qemu-devel] [PATCH] smbios: Add 1 terminator if there is any string field defined in given table.

2016-09-06 Thread Lin Ma
If user specifies binary file on command line to load smbios entries, then will get error messages while decoding them in guest. Reproducer: 1. dump a smbios table to a binary file from host or guest.(says table 1) 2. load the binary file through command line: 'qemu -smbios file=...'. 3. perform '

Re: [Qemu-devel] [PATCH] trace: Allow events without arguments

2016-09-06 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Aug 26, 2016 at 11:12:47AM +0200, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> scripts/tracetool/__init__.py |5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py >> i

Re: [Qemu-devel] [PULL 00/38] First set of s390x patches for 2.8

2016-09-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/38] First set of s390x patches for 2.8 Type: series Message-id: 20160906074710.13495-1-cornelia.h...@de.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tot

Re: [Qemu-devel] [PATCH v2 0/2] tests: add RTAS protocol

2016-09-06 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 0/2] tests: add RTAS protocol Type: series Message-id: 1473150183-16407-1-git-send-email-lviv...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=

[Qemu-devel] Checkpatch false positives (Was: Re: [PATCH v2 0/6] hypertrace: Lightweight guest-to-QEMU trace channel)

2016-09-06 Thread Lluís Vilanova
no-reply writes: > Checking PATCH 1/6: hypertrace: Add documentation... > ERROR: trailing whitespace > #109: FILE: docs/hypertrace.txt:92: > +$ > ERROR: trailing whitespace > #110: FILE: docs/hypertrace.txt:93: > +$ > ERROR: trailing whitespace > #117: FILE: docs/hypertrace.txt:100: > +

Re: [Qemu-devel] Checkpatch false positives (Was: Re: [PATCH v2 0/6] hypertrace: Lightweight guest-to-QEMU trace channel)

2016-09-06 Thread Paolo Bonzini
On 06/09/2016 11:11, Lluís Vilanova wrote: > no-reply writes: >> Checking PATCH 1/6: hypertrace: Add documentation... >> ERROR: trailing whitespace >> #109: FILE: docs/hypertrace.txt:92: >> +$ > >> ERROR: trailing whitespace >> #110: FILE: docs/hypertrace.txt:93: >> +$ > >> ERROR: trai

Re: [Qemu-devel] [PATCH v5 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-06 Thread Anthony PERARD
On Tue, Aug 16, 2016 at 08:55:56AM +0200, Paulina Szubarczyk wrote: > diff --git a/configure b/configure > index 8d84919..68b3374 100755 > --- a/configure > +++ b/configure > @@ -1956,6 +1956,43 @@ EOF > /* > * If we have stable libs the we don't want the libxc compat > * layers, regardless of

Re: [Qemu-devel] [RFC v4 00/28] Base enabling patches for MTTCG

2016-09-06 Thread Alex Bennée
Alex Bennée writes: > This is the fourth iteration of the RFC patch set which aims to > provide the basic framework for MTTCG. I hope this will provide a good > base for discussion at KVM Forum later this month. Review ping? It would be nice to get some review feedback before I re-spin against

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] tests: add RTAS command in the protocol

2016-09-06 Thread Greg Kurz
On Tue, 6 Sep 2016 10:23:03 +0200 Laurent Vivier wrote: > Add a first test to validate the protocol: > > - rtas/get-time-of-day compares the time > from the guest with the time from the host. > > Signed-off-by: Laurent Vivier > --- > v2: > - add a missing space in qrtas_call() prototype >

Re: [Qemu-devel] [PATCH v3 1/4] error-report: provide error_report_fatal()

2016-09-06 Thread Fam Zheng
On Thu, 08/18 13:28, Peter Xu wrote: > There are many places in current QEMU codes that needs to print some > error and then quit QEMU. Provide a new function for it. > > Signed-off-by: Peter Xu > --- > include/qemu/error-report.h | 1 + > util/qemu-error.c | 12 > 2 file

Re: [Qemu-devel] [PATCH v3 2/4] error-report: provide error_report_abort()

2016-09-06 Thread Fam Zheng
On Thu, 08/18 13:28, Peter Xu wrote: > A twin for error_report_fatal(), for programming errors. > > Signed-off-by: Peter Xu > --- > include/qemu/error-report.h | 1 + > util/qemu-error.c | 12 > 2 files changed, 13 insertions(+) > > diff --git a/include/qemu/error-report

Re: [Qemu-devel] virtio-net & dhcp & udp checksum

2016-09-06 Thread Michael S. Tsirkin
On Tue, Sep 06, 2016 at 02:32:27PM +1000, Alexey Kardashevskiy wrote: > Hi! > > I am trying DHCP between 2 guests. So I am running first guest with: > > -netdev tap,id=TAP0,helper=/home/aik/qemu-bridge-helper \ > -device "virtio-net-pci,id=vnet0,mac=C0:41:49:4b:ee:ee,netdev=TAP0" > > and second

Re: [Qemu-devel] [PATCH 0/2] qom-get [for 2.8]

2016-09-06 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 05/09/2016 20:50, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > >> > >> > >> On 25/08/2016 11:37, Dr. David Alan Gilbert (git) wrote: > >>> > >>> (qemu) qom-get /backend/console[0]/device/vga.rom[0] size > >>

Re: [Qemu-devel] [PULL 00/42] Block layer patches

2016-09-06 Thread Peter Maydell
On 5 September 2016 at 19:13, Kevin Wolf wrote: > The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: > > Open 2.8 development tree (2016-09-05 11:38:54 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-06 Thread Michael S. Tsirkin
On Tue, Sep 06, 2016 at 09:50:00AM +0300, Roman Kagan wrote: > On Tue, Sep 06, 2016 at 04:45:13AM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 05, 2016 at 11:02:36AM +0300, Roman Kagan wrote: > > > On Sat, Sep 03, 2016 at 01:53:53AM +0300, Michael S. Tsirkin wrote: > > > > On Fri, Sep 02, 2016

Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2016-09-06 Thread Fam Zheng
On Mon, 08/22 23:56, Ashish Mittal wrote: > block/Makefile.objs |2 + > block/trace-events | 41 ++ > block/vxhs.c| 1304 > +++ > block/vxhs.h| 237 ++ > configure | 50 ++ If vxhs code is contained in one

[Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command

2016-09-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This started off as Andreas Färber's implementation from March 2015, but after feedback from Paolo morphed into using the json output which handles structs reasonably. Use with qom-list to find the members of an object. (qemu) qom-get /backend/console[0]/device/vg

Re: [Qemu-devel] Checkpatch false positives

2016-09-06 Thread Lluís Vilanova
Paolo Bonzini writes: > On 06/09/2016 11:11, Lluís Vilanova wrote: >> no-reply writes: >>> Checking PATCH 1/6: hypertrace: Add documentation... >>> ERROR: trailing whitespace >>> #109: FILE: docs/hypertrace.txt:92: >>> +$ >> >>> ERROR: trailing whitespace >>> #110: FILE: docs/hypertrace.txt:

Re: [Qemu-devel] [PATCH v3 2/4] error-report: provide error_report_abort()

2016-09-06 Thread Peter Xu
On Tue, Sep 06, 2016 at 05:53:26PM +0800, Fam Zheng wrote: > On Thu, 08/18 13:28, Peter Xu wrote: > > A twin for error_report_fatal(), for programming errors. > > > > Signed-off-by: Peter Xu > > --- > > include/qemu/error-report.h | 1 + > > util/qemu-error.c | 12 > > 2

[Qemu-devel] [PATCH] checkpatch: Fix whitespace checks for documentation code blocks

2016-09-06 Thread Lluís Vilanova
Prevent blank lines in documentation code blocks to be signalled as incorrect trailing whitespace. Code blocks in documentation are 4-column aligned, and blank lines in them should have exactly 4 columns of trailing whitespace to prevent QEMU's wiki to render them as separate code blocks. Signed-

Re: [Qemu-devel] [PATCH v15 00/15] PTimer fixes/features and ARM MPTimer conversion

2016-09-06 Thread Dmitry Osipenko
On 06.09.2016 01:12, Peter Maydell wrote: > On 5 September 2016 at 22:52, Dmitry Osipenko wrote: >> On 05.09.2016 21:14, Peter Maydell wrote: >>> I tried "check this compiles and passes the tests for each commit", >>> and what I found was that you get a lot of new warnings running >>> 'make check'

Re: [Qemu-devel] [PATCH 2/3] memory: add iommu_notify_flag

2016-09-06 Thread Peter Xu
On Tue, Sep 06, 2016 at 10:19:14AM +0200, Paolo Bonzini wrote: > > > On 06/09/2016 10:17, Peter Xu wrote: > > After knowing the possibility that the two consumers might be > > mixturely used in the future (as David has mentioned), I'd vote for a > > bitmask for notification type: > > > > IOM

Re: [Qemu-devel] proposed release timetable for 2.8

2016-09-06 Thread Kevin Wolf
Am 05.09.2016 um 13:10 hat Peter Maydell geschrieben: > On 1 September 2016 at 12:18, Peter Maydell wrote: > > I know 2.7 isn't quite out the door yet, but I figured we should > > kick off the discussion of 2.8's schedule. At the QEMU Summit there > > was some discussion on how we're doing with re

Re: [Qemu-devel] [PULL 00/42] Block layer patches

2016-09-06 Thread Peter Maydell
On 5 September 2016 at 19:13, Kevin Wolf wrote: > The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: > > Open 2.8 development tree (2016-09-05 11:38:54 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you

[Qemu-devel] [PATCH] virtio-pci: use size from correct structure

2016-09-06 Thread Michael S. Tsirkin
PIO MR registration should use size from the correct notify struct. Doesn't affect any visible behaviour because the field values are the same (both are 4). Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/

[Qemu-devel] [PATCH qemu] tap: Allow specifying a bridge

2016-09-06 Thread Alexey Kardashevskiy
The tap backend is already using qemu-bridge-helper to attach tap interface to a bridge but (unlike the bridge backend) it always uses the default bridge name - br0. This adds a "br" property support to the tap backend. Signed-off-by: Alexey Kardashevskiy --- My reason for the patch is I want t

Re: [Qemu-devel] [RFC PATCH v2 00/12] Guest startup time optimization

2016-09-06 Thread Chao Peng
> Patches 1-4 are okay, though I think it would be easier to add a -M > q35-lite too that just removes the legacy devices.  The -M q35-lite > machine doesn't have to support versioning for now. Okay, this is also good to have in my mind. > > As you might expect, I don't agree with removing the

Re: [Qemu-devel] [PULL 00/42] Block layer patches

2016-09-06 Thread Peter Maydell
On 5 September 2016 at 19:13, Kevin Wolf wrote: > The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: > > Open 2.8 development tree (2016-09-05 11:38:54 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you

Re: [Qemu-devel] [PULL 00/42] Block layer patches

2016-09-06 Thread Kevin Wolf
Am 06.09.2016 um 12:12 hat Peter Maydell geschrieben: > On 5 September 2016 at 19:13, Kevin Wolf wrote: > > The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: > > > > Open 2.8 development tree (2016-09-05 11:38:54 +0100) > > > > are available in the git repository at: >

Re: [Qemu-devel] virtio-net & dhcp & udp checksum

2016-09-06 Thread Alexey Kardashevskiy
On 06/09/16 20:03, Michael S. Tsirkin wrote: > On Tue, Sep 06, 2016 at 02:32:27PM +1000, Alexey Kardashevskiy wrote: >> Hi! >> >> I am trying DHCP between 2 guests. So I am running first guest with: >> >> -netdev tap,id=TAP0,helper=/home/aik/qemu-bridge-helper \ >> -device "virtio-net-pci,id=vnet0,

  1   2   3   4   5   >