On 06/09/2016 10:17, Peter Xu wrote: > After knowing the possibility that the two consumers might be > mixturely used in the future (as David has mentioned), I'd vote for a > bitmask for notification type: > > IOMMU_NOTIFIER_NONE = 0, > IOMMU_NOTIFIER_INVALIDATION = 1, > IOMMU_NOTIFIER_ADDITION = 2,
ADDITION really should be "CHANGE" I think, so what about IOMMU_NOTIFIER_INVALIDATE and IOMMU_NOTIFIER_CHANGE? For VFIO, would the "invalidate" and "add" callbacks use the same code or different? Thanks, Paolo
