Re: [Qemu-devel] [RFC/PATCHSET 0/3] virtio: Implement virtio pstore device (v3)

2016-08-24 Thread Joel
Hi Namhyung, > On Aug 23, 2016, at 8:20 AM, Namhyung Kim wrote: > > Hi Joel, > > On Tue, Aug 23, 2016 at 7:25 PM, Joel Fernandes wrote: >> From: Namhyung Kim > >> >> Any thoughts on what you think about it? In your approach though, you >> wouldn't need a backing mem-path file which is the s

[Qemu-devel] Patch to add support for building in MSYS2 on Windows

2016-08-24 Thread Evan Hunter
Hi, I noticed that QEMU would not compile on Windows in the MSYS2 environment. Here is a patch that adds a check for it to the configure script and amended some ifdefs so it now builds. At the bottom of this email is a build script I made for building under MSYS2, however I am not sure if i

[Qemu-devel] [RFC PATCH 0/3] target-arm: Add cortex-a72 support

2016-08-24 Thread Shannon Zhao
From: Shannon Zhao This series add cortex-a72 cpu support for target-arm. Shannon Zhao (3): target-arm: cpu64: Add support for Cortex-A72 target-arm/kvm64: Add cortex-a72 cpu support hw/arm/virt: Add cortex-a72 cpu support in machine virt hw/arm/virt.c | 5 linux-he

[Qemu-devel] [RFC PATCH 3/3] hw/arm/virt: Add cortex-a72 cpu support in machine virt

2016-08-24 Thread Shannon Zhao
From: Shannon Zhao Add cortex-a72 cpu support in machine virt, so it can be used for TCG and KVM. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index a193b5a..adffe03 100644 --- a/hw/arm/virt.c +++ b/hw/arm/

[Qemu-devel] [RFC PATCH 1/3] target-arm: cpu64: Add support for Cortex-A72

2016-08-24 Thread Shannon Zhao
From: Shannon Zhao Add the ARM Cortex-A72 processor definition. It's similar to A57. Signed-off-by: Shannon Zhao --- target-arm/cpu64.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 1635

[Qemu-devel] [RFC PATCH 2/3] target-arm/kvm64: Add cortex-a72 cpu support

2016-08-24 Thread Shannon Zhao
From: Shannon Zhao Enable cortex-a72 cpu support for KVM. Signed-off-by: Shannon Zhao --- linux-headers/asm-arm64/kvm.h | 3 ++- target-arm/cpu64.c| 1 + target-arm/kvm-consts.h | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-headers/asm-arm64/kvm.

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Dr. David Alan Gilbert
cc'ing in Liang Li who did the original avx2 code. Dave * Richard Henderson (r...@twiddle.net) wrote: > Patches 1-3 remove the use of ifunc from the implementation. > > Patch 5 adjusts the x86 implementation a bit more to take > advantage of ptest (in sse4.1) and unaligned accesses (in avx1).

Re: [Qemu-devel] [PATCH 2/7] cutils: Export only buffer_is_zero

2016-08-24 Thread Dr. David Alan Gilbert
* Richard Henderson (r...@twiddle.net) wrote: > Since the two users don't make use of the returned offset, > beyond ensuring that the entire buffer is zero, consider the > can_use_buffer_find_nonzero_offset and buffer_find_nonzero_offset > functions internal. > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-24 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Sun, Aug 21, 2016 at 02:32:34PM +0200, Lluís Vilanova wrote: >> Unfortuntely, I've been unable to to make dtrace recognise QEMU's events (I'm >> only able to see the host kernel events). If someone with more experience on >> it >> can help me use dtrace with QEMU's ev

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Adam Richter
> * Richard Henderson (r...@twiddle.net) wrote: >> Patches 1-3 remove the use of ifunc from the implementation. [...] I am not a qemu developer, but I wanted to write in support of removing the use of ifunc. I filed a glibc bug at https://sourceware.org/bugzilla/show_bug.cgi?id=20480 that I actua

[Qemu-devel] [PATCH v2 2/5] vmstateify rc4030

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" rc4030 seems to be part of a MIPS chipset; this converts it to VMState. Note: a) It builds but I've not found a way to boot a MIPS Jazz image to test it. b) It was saving 0..<15 on the 16 entry rem_speed array; I've not got a clue what that array is but I

[Qemu-devel] [PATCH v2 3/5] vmstateify ssi-sd

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Changed a few types to fixed sized types in the ssi_sd_state Now saving/loading a byte for the cmdarg/response bytes that were previously saved as uint32 Bumped version number to deal with those changes. Signed-off-by: Dr. David Alan Gilbert --- hw/sd/ssi-sd.c

[Qemu-devel] [PATCH v2 1/5] vmstateify ssd0323 display

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Bumps version number because we now use the VMSTATE_SSI_SLAVE that only uses a byte rather than a 32bit (for saving a bool 'cs'). Signed-off-by: Dr. David Alan Gilbert --- hw/display/ssd0323.c | 102 --- 1 file c

[Qemu-devel] [PATCH v2 0/5] vmstateify a bunch of rare devices [for 2.8]

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In an effort to nibble away at register_savevm users, this set removes 5 more and converts them to vmstate. The ssd0323 seems to test OK with Peter's Stellaris test. The rc4030 has a tested-by from Hervé. The other 3 I'm less sure of; the ssi-sd is similar to the s

[Qemu-devel] [PATCH v2 4/5] vmstateify tsc2005

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I've converted the fields in it's main data structure to fixed size types in ways that look sane, but I don't actually know the details of this hardware. Signed-off-by: Dr. David Alan Gilbert --- hw/input/tsc2005.c | 154 --

[Qemu-devel] [PATCH v2 5/5] vmstateify tsc210x

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Note: I know nothing about this hardware. I'm now saving all 3 of the pll entries; only 2 were saved before. There are a couple of times that were previously stored as offsets from 'now' calculated before saving; with vmstate it's easier to store the 'n

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Peter Maydell
On 24 August 2016 at 11:26, Adam Richter wrote: > I hope that that consideration, combined with the micro-costs to > readability and portability of using and ELF specific and perhaps > currently GCC specific feature might tip the balance against the > savings of a level of function call indirectio

[Qemu-devel] [RFC PATCH v3 0/2] GICv3 live migration support

2016-08-24 Thread vijay . kilari
From: Vijaya Kumar K This series introduces support for GICv3 live migration with new VGIC implementation in 4.7-rc3 kernel. In this series, patch 1 of the previous implementation are ported. https://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg05284.html Patch 2, is based on below implem

[Qemu-devel] [RFC PATCH v3 1/2] kernel: Add definitions for GICv3 attributes

2016-08-24 Thread vijay . kilari
From: Vijaya Kumar K This temporary patch adds kernel API definitions. Use proper header update procedure after these features are released. Signed-off-by: Pavel Fedin --- linux-headers/asm-arm64/kvm.h | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [RFC PATCH v3 2/2] hw/intc/arm_gicv3_kvm: Implement get/put functions

2016-08-24 Thread vijay . kilari
From: Vijaya Kumar K This actually implements pre_save and post_load methods for in-kernel vGICv3. Signed-off-by: Pavel Fedin Signed-off-by: Peter Maydell [PMM: * use decimal, not 0bnnn * fixed typo in names of ICC_APR0R_EL1 and ICC_AP1R_EL1 * completely rearranged the get and put functions

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-24 Thread Paolo Bonzini
- Original Message - > From: "ronnie sahlberg" > To: "Paolo Bonzini" > Cc: "Roy Shterman" , "qemu-devel" > , "Peter Lieven" > Sent: Monday, August 22, 2016 10:35:03 PM > Subject: Re: [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU > > It is never too late. > > I can start

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Paolo Bonzini
> On 24 August 2016 at 11:26, Adam Richter wrote: > > I hope that that consideration, combined with the micro-costs to > > readability and portability of using and ELF specific and perhaps > > currently GCC specific feature might tip the balance against the > > savings of a level of function call

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Peter Maydell
On 24 August 2016 at 12:45, Paolo Bonzini wrote: > It does save a level of indirection after the first call AFAIK, but > it shouldn't be measurable. It's worse on first call, but I don't think the subsequent calls are better than straight pointer-indirection. It's been a while since I looked thou

Re: [Qemu-devel] [RFC for 2.8 0/3] Drop support for 64 bit guests on 32 bit hosts

2016-08-24 Thread Alex Bennée
Alex Bennée writes: > Hi, > > I'm proposing for the 2.8 cycle we officially drop supporting 64 bit > guests on 32 bit hosts. For most of the KVM targets it doesn't make > any sense anyway and for TCG it makes things harder (e.g. supporting > 64 bit atomics on a 32 bit platform). I'm not actually

[Qemu-devel] [PATCH v4 0/5] POWER9 TCG enablement - part3

2016-08-24 Thread Rajalakshmi Srinivasaraghavan
This series contains 14 new instructions for POWER9 described in ISA3.0. Patches: 01: Adds vector insert instructions. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doub

[Qemu-devel] [PATCH v4 1/5] target-ppc: add vector insert instructions

2016-08-24 Thread Rajalakshmi Srinivasaraghavan
The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |4 ta

[Qemu-devel] [PATCH v4 2/5] target-ppc: add vector extract instructions

2016-08-24 Thread Rajalakshmi Srinivasaraghavan
The following vector extract instructions are added from ISA 3.0. vextractub - Vector Extract Unsigned Byte vextractuh - Vector Extract Unsigned Halfword vextractuw - Vector Extract Unsigned Word vextractd - Vector Extract Unsigned Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- tar

[Qemu-devel] [PATCH v4 4/5] target-ppc: add vector bit permute doubleword instruction

2016-08-24 Thread Rajalakshmi Srinivasaraghavan
Add vbpermd instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 20 target-ppc/translate/vmx-impl.inc.c |1 + target-ppc/translate/vmx-ops.inc.c |1 + 4 file

[Qemu-devel] [PATCH v4 5/5] target-ppc: add vector permute right indexed instruction

2016-08-24 Thread Rajalakshmi Srinivasaraghavan
Add vpermr instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 23 +++ target-ppc/translate/vmx-impl.inc.c | 18 ++ target-ppc/translate/vmx-ops.inc.

[Qemu-devel] [PATCH v4 3/5] target-ppc: add vector count trailing zeros instructions

2016-08-24 Thread Rajalakshmi Srinivasaraghavan
The following vector count trailing zeros instructions are added from ISA 3.0. vctzb - Vector Count Trailing Zeros Byte vctzh - Vector Count Trailing Zeros Halfword vctzw - Vector Count Trailing Zeros Word vctzd - Vector Count Trailing Zeros Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan

[Qemu-devel] Adding new source files

2016-08-24 Thread Pradeep Kiruvale
Hi All, I have added two new files (.h/.c) file in 9pfs for some new feature. When I compile there is a lot of compilation time errors and also I do not see a dependency file getting created for this source file. Please let me know how can I fix this, is there a place where I need to mention the

[Qemu-devel] [RFC 2/6] migration: Report values for comparisons

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Report the values when a comparison fails; together with the previous patch that prints the device and field names this should give a good idea of why loading the migration failed. Signed-off-by: Dr. David Alan Gilbert --- migration/vmstate.c | 8 1 file

[Qemu-devel] [RFC 3/6] migration: Add VMSTATE_UNUSED_VARRAY_UINT32

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" VMSTATE_UNUSED_VARRAY_UINT32 is used to skip a chunk of the stream that's an n-element array; note the array size and the dynamic value read never get multiplied so there's no overflow risk. Signed-off-by: Dr. David Alan Gilbert --- include/migration/vmstate.h |

[Qemu-devel] [RFC 0/6] converting some of virtio to VMState

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This series converts two parts of virtio to VMState - the device load/save for virtio-balloon and virtio-net. It's only been smoke tested (which it passes); but if anyone has a good suggestion for testing virtio-net migration I'd be greatful. The first coupl

[Qemu-devel] [RFC 6/6] virtio/migration: Migrate virtio-net to VMState

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Only lightly smoke-tested so far Signed-off-by: Dr. David Alan Gilbert --- hw/net/virtio-net.c| 256 - include/hw/virtio/virtio-net.h | 10 +- 2 files changed, 157 insertions(+), 109 deletions(-) diff --git a/

[Qemu-devel] [RFC 4/6] virtio/migration: Add VMStateDescription to VirtioDeviceClass

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Provide a vmsd pointer for VirtIO devices to use instead of the load/save methods. We'll eventually kill off the load/save methods. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/virtio.c | 11 +++ include/hw/virtio/virtio.h | 2 ++ 2 files

[Qemu-devel] [RFC 5/6] virtio/migration: Migrate balloon to VMState

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Replace the load/save with a vmsd. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/virtio-balloon.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c i

[Qemu-devel] [RFC 1/6] migration: report an error giving the failed field

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When a field fails to load (typically due to a limit check, or a call to a get/put) report the device and field to give an indication of the cause. Signed-off-by: Dr. David Alan Gilbert --- migration/vmstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[Qemu-devel] [PATCH] 9pfs: disallow / in path components

2016-08-24 Thread Greg Kurz
At various places in 9pfs, full paths are created by concatenating a guest originated string to the export path. A malicious guest could forge a relative path and access files outside the export path. A tentative fix was sent recently by Prasad J Pandit, but it was only focused on the local backen

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-08-24 Thread luigiburdo
Hi T, im checking and testing the lastest qemu and i understand the issue is present only with all softmmu system . if i open eg qemu-system-ppc64 i have the issue if i open qemu-system-ppc64 with kvm enabled the issue isnt present and all run like have to be. It means all the emulated machine

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Richard Henderson
On 08/23/2016 09:38 PM, Paolo Bonzini wrote: On 24/08/2016 06:30, no-re...@patchew.org wrote: ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #44: FILE: util/cutils.c:289: +__asm volatile("vmovdqu -0x80(%1),%0\n\t" Other errors can be ignor

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Paolo Bonzini
- Original Message - > From: "Richard Henderson" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: "peter maydell" , qemu-...@nongnu.org, > f...@redhat.com, "vijay kilari" > > Sent: Wednesday, August 24, 2016 4:53:37 PM > Subject: Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero >

Re: [Qemu-devel] [PATCH] 9pfs: disallow / in path components

2016-08-24 Thread Peter Maydell
On 24 August 2016 at 15:29, Greg Kurz wrote: > At various places in 9pfs, full paths are created by concatenating a guest > originated string to the export path. A malicious guest could forge a > relative path and access files outside the export path. > > A tentative fix was sent recently by Prasa

Re: [Qemu-devel] [RFC 0/6] converting some of virtio to VMState

2016-08-24 Thread Cornelia Huck
On Wed, 24 Aug 2016 14:42:27 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This series converts two parts of virtio to VMState - the > device load/save for virtio-balloon and virtio-net. > > It's only been smoke tested (which it passes); but if anyone

Re: [Qemu-devel] [RFC 4/6] virtio/migration: Add VMStateDescription to VirtioDeviceClass

2016-08-24 Thread Cornelia Huck
On Wed, 24 Aug 2016 14:42:31 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Provide a vmsd pointer for VirtIO devices to use instead of the > load/save methods. > > We'll eventually kill off the load/save methods. > > Signed-off-by: Dr. David Alan Gilbert >

Re: [Qemu-devel] [RFC 4/6] virtio/migration: Add VMStateDescription to VirtioDeviceClass

2016-08-24 Thread Dr. David Alan Gilbert
* Cornelia Huck (cornelia.h...@de.ibm.com) wrote: > On Wed, 24 Aug 2016 14:42:31 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Provide a vmsd pointer for VirtIO devices to use instead of the > > load/save methods. > > > > We'll eventually kill off t

Re: [Qemu-devel] [PATCH] 9pfs: disallow / in path components

2016-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2016 at 04:00:24PM +0100, Peter Maydell wrote: > On 24 August 2016 at 15:29, Greg Kurz wrote: > > At various places in 9pfs, full paths are created by concatenating a guest > > originated string to the export path. A malicious guest could forge a > > relative path and access files

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 for 2.7] ui: fix refresh of VNC server surface

2016-08-24 Thread Peter Maydell
On 23 August 2016 at 07:50, Peter Lieven wrote: > Am 16.08.2016 um 18:30 schrieb Daniel P. Berrange: >> >> In previous commit >> >>commit c7628bff4138ce906a3620d12e0820c1cf6c140d >>Author: Gerd Hoffmann >>Date: Fri Oct 30 12:10:09 2015 +0100 >> >> vnc: only alloc server surface

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 for 2.7] ui: fix refresh of VNC server surface

2016-08-24 Thread Daniel P. Berrange
On Wed, Aug 24, 2016 at 04:46:31PM +0100, Peter Maydell wrote: > On 23 August 2016 at 07:50, Peter Lieven wrote: > > Am 16.08.2016 um 18:30 schrieb Daniel P. Berrange: > >> > >> In previous commit > >> > >>commit c7628bff4138ce906a3620d12e0820c1cf6c140d > >>Author: Gerd Hoffmann > >>D

Re: [Qemu-devel] [RFC 4/6] virtio/migration: Add VMStateDescription to VirtioDeviceClass

2016-08-24 Thread Cornelia Huck
On Wed, 24 Aug 2016 16:42:05 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (cornelia.h...@de.ibm.com) wrote: > > On Wed, 24 Aug 2016 14:42:31 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > > > index d2490c1.

Re: [Qemu-devel] [PATCH for-2.8 2/2] vhost-vsock: add virtio sockets device

2016-08-24 Thread Claudio Imbrenda
Hi Stefan! I tried it on s390x and... it doesn't compile :( Something has been changed somewhere behind our backs, and you need to change this line to get it to compile again: --- virtio-ccw.c~ 2016-08-23 16:37:14.0 +0200 +++ virtio-ccw.c2016-08-23 16:41:10.587853314 +020

[Qemu-devel] how to understand proccessor codes in Qemu

2016-08-24 Thread Mahmoud Abd el-hameed
Hi all, I am a new developer at Qemu and i want to understand how the processors code works. I am get lost through google and didn't know where i can begin to understand the code. my aim is to understand how can we model the proccessors using qemu? Thanks, Mahmoud

[Qemu-devel] [PATCH] eepro100: Frame Reception

2016-08-24 Thread Mateus Krepsky Ludwich
Changed E100 device so it updates EOF, F, and Actual Count fields of Receive Frame Descriptor (RFD). Assuming RFD.actual_count equals to size. Signed-off-by: Mateus Krepsky Ludwich --- hw/net/eepro100.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c

Re: [Qemu-devel] [PATCH for-2.8 2/2] vhost-vsock: add virtio sockets device

2016-08-24 Thread Cornelia Huck
On Tue, 23 Aug 2016 19:45:15 +0200 Claudio Imbrenda wrote: > Hi Stefan! > > I tried it on s390x and... it doesn't compile :( > Something has been changed somewhere behind our backs, and you need to > change this line to get it to compile again: > > --- virtio-ccw.c~ 2016-08-23 16:37:14.0

Re: [Qemu-devel] [RFC 0/6] converting some of virtio to VMState

2016-08-24 Thread Dr. David Alan Gilbert
* Cornelia Huck (cornelia.h...@de.ibm.com) wrote: > On Wed, 24 Aug 2016 14:42:27 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This series converts two parts of virtio to VMState - the > > device load/save for virtio-balloon and virtio-net.

Re: [Qemu-devel] [PATCH] Fix bsd-user build after d915b7bb

2016-08-24 Thread Peter Maydell
On 22 August 2016 at 21:15, Ed Maste wrote: > On 22 August 2016 at 12:20, Peter Maydell wrote: >> >> Awkward that this missed rc4 by an hour or two :-( > > Indeed, and I'm sorry that's the case. It wasn't even in the context > of the upcoming release that I tried building and stumbled across this

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Fam and Jsnow for Bitmap support

2016-08-24 Thread Max Reitz
On 2016-08-04 at 14:18, John Snow wrote: These files are currently unmaintained. I'm proposing that Fam and I co-maintain them; under the model that whomever between us isn't authoring a given series will be responsible for reviewing it. Signed-off-by: John Snow --- MAINTAINERS | 14 +

Re: [Qemu-devel] [PATCH] commit: get the overlay node before manipulating the backing chain

2016-08-24 Thread Max Reitz
On 2016-08-21 at 23:36, Alberto Garcia wrote: The 'block-commit' command has a 'top' parameter to specify the topmost node from which the data is going to be copied. [E] <- [D] <- [C] <- [B] <- [A] In this case if [C] is the top node then this is the result: [E] <- [B] <- [A] [B] must b

Re: [Qemu-devel] [PATCH] 9pfs: disallow / in path components

2016-08-24 Thread Greg Kurz
On Wed, 24 Aug 2016 16:00:24 +0100 Peter Maydell wrote: > On 24 August 2016 at 15:29, Greg Kurz wrote: > > At various places in 9pfs, full paths are created by concatenating a guest > > originated string to the export path. A malicious guest could forge a > > relative path and access files outsi

Re: [Qemu-devel] [PATCH] 9pfs: disallow / in path components

2016-08-24 Thread Greg Kurz
On Wed, 24 Aug 2016 18:46:10 +0300 "Michael S. Tsirkin" wrote: > On Wed, Aug 24, 2016 at 04:00:24PM +0100, Peter Maydell wrote: > > On 24 August 2016 at 15:29, Greg Kurz wrote: > > > At various places in 9pfs, full paths are created by concatenating a guest > > > originated string to the expor

[Qemu-devel] [PATCH] Postcopy vs xbzrle: Don't send xbzrle pages once in postcopy [for 2.8]

2016-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" xbzrle relies on reading pages that have already been sent to the destination and then applying the modifications; we can't do that in postcopy because the destination may well have modified the page already or the page has been discarded. I already didn't allow re

[Qemu-devel] [PATCH v2 3/8] cutils: Export only buffer_is_zero

2016-08-24 Thread Richard Henderson
Since the two users don't make use of the returned offset, beyond ensuring that the entire buffer is zero, consider the can_use_buffer_find_nonzero_offset and buffer_find_nonzero_offset functions internal. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Richard Henderson --- include/qemu/cut

[Qemu-devel] [PATCH v2 0/8] Improve buffer_is_zero

2016-08-24 Thread Richard Henderson
Patches 1-4 remove the use of ifunc from the implementation. Patch 6 adjusts the x86 implementation a bit more to take advantage of ptest (in sse4.1) and unaligned accesses (in avx1). Patches 3 and 7 are the result of my conversation with Vijaya Kumar with respect to ThunderX. Patch 8 is the res

[Qemu-devel] [PATCH v2 7/8] cutils: Rewrite aarch64 buffer zero checking

2016-08-24 Thread Richard Henderson
Provide 64-byte and 128-byte versions. Use dczid_el0 as a proxy for the cacheline size. Cc: qemu-...@nongnu.org Cc: vijay.kil...@gmail.com Signed-off-by: Richard Henderson --- util/bufferiszero.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/ut

[Qemu-devel] [PATCH v2 4/8] cutils: Rearrange buffer_is_zero acceleration

2016-08-24 Thread Richard Henderson
Allow selection of several acceleration functions based on the size and alignment of the buffer. Do not require ifunc support for AVX2 acceleration. Signed-off-by: Richard Henderson --- configure | 21 +--- util/bufferiszero.c | 352 +---

[Qemu-devel] [PATCH v2 5/8] cutils: Add generic prefetch

2016-08-24 Thread Richard Henderson
There's no real knowledge of the cacheline size, just prefetching one loop ahead. Signed-off-by: Richard Henderson --- util/bufferiszero.c | 5 + 1 file changed, 5 insertions(+) diff --git a/util/bufferiszero.c b/util/bufferiszero.c index 5246c5b..264598b 100644 --- a/util/bufferiszero.c ++

[Qemu-devel] [PATCH v2 1/8] cutils: Move buffer_is_zero and subroutines to a new file

2016-08-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- util/Makefile.objs | 1 + util/bufferiszero.c | 272 util/cutils.c | 244 -- 3 files changed, 273 insertions(+), 244 deletions(-) create mode 100644 util

[Qemu-devel] [PATCH v2 8/8] cutils: Rewrite ppc buffer zero checking

2016-08-24 Thread Richard Henderson
GCC versions through 6 do a poor job with the indexed addressing, and (for ppc64le) issues unnecessary xxswapd insns. Cc: qemu-...@nongnu.org Cc: David Gibson Signed-off-by: Richard Henderson --- util/bufferiszero.c | 40 ++-- 1 file changed, 38 insertions(+)

[Qemu-devel] [PATCH v2 6/8] cutils: Rewrite x86 buffer zero checking

2016-08-24 Thread Richard Henderson
Use unaligned load operations. Add versions for avx1 and sse4.1. Cc: liang.z...@intel.com Signed-off-by: Richard Henderson --- util/bufferiszero.c | 169 1 file changed, 145 insertions(+), 24 deletions(-) diff --git a/util/bufferiszero.c b/ut

[Qemu-devel] [Patch v3 22/30] s390x/kvm: disable host model for problematic compat machines

2016-08-24 Thread David Hildenbrand
Compatibility machines that touch runtime-instrumentation should not be used with the CPU model. Otherwise the host model will look different, depending on the QEMU machine QEMU has been started with. So let's simply disable the host model for existing compatibility machines that all disable ri. T

[Qemu-devel] [Patch v3 20/30] s390x/kvm: allow runtime-instrumentation for "none" machine

2016-08-24 Thread David Hildenbrand
To be able to query the correct host model for the "none" machine, let's allow runtime-instrumentation for that machine. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/

[Qemu-devel] [Patch v3 06/30] s390x/cpumodel: generate CPU feature group lists

2016-08-24 Thread David Hildenbrand
Feature groups will be very helpful to reduce the amount of features typically available in sane configurations. E.g. the MSA facilities introduced loads of subfunctions, which could - in theory - go away in the future, but we want to avoid reporting hundrets of features to the user if usually all

[Qemu-devel] [Patch v3 15/30] s390x/sclp: indicate sclp features

2016-08-24 Thread David Hildenbrand
We have three different blocks in the SCLP read-SCP information response that indicate sclp features. Let's prepare propagation. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 9 + target-s390x/cpu_models.c | 14 ++ target-s390x/cpu

[Qemu-devel] [Patch v3 23/30] s390x/kvm: let the CPU model control CMM(A)

2016-08-24 Thread David Hildenbrand
Starting with recent kernels, if the cmma attributes are available, we actually have hardware support. Enabling CMMA then means providing the guest VCPU with CMM, therefore enabling its CMM facility. Let's not blindly enable CMM anymore but let's control it using CPU models. For disabled CPU model

[Qemu-devel] [Patch v3 01/30] qmp: details about CPU definitions in query-cpu-definitions

2016-08-24 Thread David Hildenbrand
It might be of interest for tooling whether a CPU definition can be safely used when migrating, or if e.g. CPU features might get lost during migration when migrationg from/to a different QEMU version or host, even if the same compatibility machine is used. Also, we want to know if a CPU definitio

[Qemu-devel] [Patch v3 05/30] s390x/cpumodel: generate CPU feature lists for CPU models

2016-08-24 Thread David Hildenbrand
From: Michael Mueller This patch introduces the helper "gen-features" which allows to generate feature list definitions at compile time. Its flexibility is better and the error-proneness is lower when compared to static programming time added statements. The helper includes "target-s390x/cpu_fea

[Qemu-devel] [Patch v3 04/30] s390x/cpumodel: introduce CPU features

2016-08-24 Thread David Hildenbrand
From: Michael Mueller The patch introduces s390x CPU features (most of them refered to as facilities) along with their discription and some functions that will be helpful when working with the features later on. Please note that we don't introduce all known CPU features, only the ones currently

[Qemu-devel] [Patch v3 14/30] s390x/sclp: introduce sclp feature blocks

2016-08-24 Thread David Hildenbrand
The sclp "read cpu info" and "read scp info" commands can include features for the cpu info and configuration characteristics (extended), decribing some advanced features available in the configuration. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- include/hw/s390x/sclp.h | 12 ++

[Qemu-devel] [Patch v3 02/30] s390x/cpumodel: "host" and "qemu" as CPU subclasses

2016-08-24 Thread David Hildenbrand
This patch introduces two CPU models, "host" and "qemu". "qemu" is used as default when running under TCG. "host" is used as default when running under KVM. "host" cannot be used without KVM. "host" is not migration-safe. They both inherit from the base s390x CPU, which is turned into an abstract c

[Qemu-devel] [Patch v3 24/30] s390x/kvm: don't enable key wrapping if msa3 is disabled

2016-08-24 Thread David Hildenbrand
As the CPU model now controls msa3, trying to set wrapping keys without msa3 being around/enable in the kernel will produce misleading errors. So let's simply not configure key wrapping if msa3 is not enabled and make compat machines with disabled CPU model work correctly. Signed-off-by: David Hi

[Qemu-devel] [Patch v3 00/30] s390x CPU models: exposing features

2016-08-24 Thread David Hildenbrand
Only minor changes this version. I think this is ready to go. If we find model inconsitencies or bad feature names, we can still fix them until the next release. Latest version can be found on branch: github.com/cohuck/qemu cpumodel-s390x-v3 Concept---

[Qemu-devel] [Patch v3 07/30] s390x/cpumodel: introduce CPU feature group definitions

2016-08-24 Thread David Hildenbrand
Let's use the generated groups to create feature group representations for the user. These groups can later be used to enable/disable multiple features in one shot and will be used to reduce the amount of reported features to the user if all subfeatures are in place. Acked-by: Cornelia Huck Signe

[Qemu-devel] [Patch v3 29/30] s390x/cpumodel: implement QMP interface "query-cpu-model-comparison"

2016-08-24 Thread David Hildenbrand
Let's implement that interface by reusing our convertion code implemented for expansion. We use CPU generations and CPU features to calculate the result. This means, that a zEC12 cannot simply be converted into a z13 by stripping of features. This is required, as other magic values (e.g. maximum a

[Qemu-devel] [Patch v3 30/30] s390x/cpumodel: implement QMP interface "query-cpu-model-baseline"

2016-08-24 Thread David Hildenbrand
Let's implement that interface by reusing our conversion code and lookup code for CPU definitions. In order to find a compatible CPU model, we first detect the maximum possible CPU generation and then try to find a maximum model, satisfying all base features (not exceeding the maximum generation).

[Qemu-devel] [Patch v3 21/30] s390x/kvm: implement CPU model support

2016-08-24 Thread David Hildenbrand
Let's implement our two hooks so we can support CPU models. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target-s390x/cpu_models.c | 75 +++- target-s390x/cpu_models.h | 50 target-s390x/kvm.c| 295 ++ 3 file

[Qemu-devel] [Patch v3 12/30] s390x/cpumodel: check and apply the CPU model

2016-08-24 Thread David Hildenbrand
We have to test if a configured CPU model is runnable in the current configuration, and if not report why that is the case. This is done by comparing it to the maximum supported model (host for KVM or z900 for TCG). Also, we want to do some base sanity checking for a configured CPU model. We'll ca

[Qemu-devel] [Patch v3 28/30] s390x/cpumodel: implement QMP interface "query-cpu-model-expansion"

2016-08-24 Thread David Hildenbrand
In order to expand CPU models, we create temporary cpus that handle the feature/group parsing. Only CPU feature properties are expanded. When converting the data structure back, we always fall back to the static base CPU model, which is by definition migration-safe. Acked-by: Cornelia Huck Signe

[Qemu-devel] [Patch v3 26/30] qmp: add QMP interface "query-cpu-model-comparison"

2016-08-24 Thread David Hildenbrand
Let's provide a standardized interface to compare two CPU models. "query-cpu-model-compare" takes two models and returns how they compare in a specific configuration. The result will give guarantees about runnability. E.g. if a CPU model A is a subset of CPU model B, model A is guaranteed to run

[Qemu-devel] [Patch v3 11/30] s390x/cpumodel: let the CPU model handle feature checks

2016-08-24 Thread David Hildenbrand
If we have certain features enabled, we have to migrate additional state (e.g. vector registers or runtime-instrumentation registers). Let the CPU model control that unless we have no "host" CPU model in the KVM case. This will later on be the case for compatibility machines, so migration from QEMU

[Qemu-devel] [Patch v3 13/30] s390x/sclp: factor out preparation of cpu entries

2016-08-24 Thread David Hildenbrand
Let's factor out the common code of "read cpu info" and "read scp info". This will make the introduction of new cpu entry fields easier. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) d

[Qemu-devel] [Patch v3 18/30] s390x/sclp: propagate hmfai

2016-08-24 Thread David Hildenbrand
hmfai is provided on CPU models >= z196. Let's propagate it properly. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 1 + include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 14 ++ target-s390x/cpu_models.h | 1 + 4 files chang

Re: [Qemu-devel] [PATCH] 9pfs: disallow / in path components

2016-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2016 at 06:41:45PM +0200, Greg Kurz wrote: > On Wed, 24 Aug 2016 18:46:10 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Aug 24, 2016 at 04:00:24PM +0100, Peter Maydell wrote: > > > On 24 August 2016 at 15:29, Greg Kurz wrote: > > > > At various places in 9pfs, full paths ar

[Qemu-devel] [Patch v3 16/30] s390x/sclp: propagate the ibc val(lowest and unblocked ibc)

2016-08-24 Thread David Hildenbrand
If we have a lowest ibc, we can indicate the ibc to the guest. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c | 2 ++ include/hw/s390x/sclp.h | 3 ++- target-s390x/cpu_models.c | 21 + target-s390x/cpu_models.h | 12 4

[Qemu-devel] [Patch v3 19/30] linux-headers: update against kvm/next

2016-08-24 Thread David Hildenbrand
Update against 29b4817d4018 ("Linux 4.8-rc1") Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- include/standard-headers/linux/input-event-codes.h | 32 + include/standard-headers/linux/input.h | 1 + include/standard-headers/linux/virtio_config.h | 1

[Qemu-devel] [Patch v3 25/30] qmp: add QMP interface "query-cpu-model-expansion"

2016-08-24 Thread David Hildenbrand
Let's provide a standardized interface to expand CPU models. This interface can be used by tooling to get details about a specific CPU model in a certain configuration, e.g. about the "host" model. To take care of all architectures, two detail levels for an expansion are introduced. Certain archit

[Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset

2016-08-24 Thread Sascha Silbe
The debian-bootstrap image doesn't choose a default architecture and distribution version, instead the user has to set both DEB_ARCH and DEB_TYPE in the environment. Print a reasonably helpful message if either of them isn't set instead of complaining about "qemu-" being missing or erroring out bec

[Qemu-devel] [Patch v3 03/30] s390x/cpumodel: expose CPU class properties

2016-08-24 Thread David Hildenbrand
Let's expose the description and migration safety and whether a definition is static, as class properties, this can be helpful in the future. Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand --- target-s390x/cpu.c| 1 + target-s390x/cpu.h| 1 + target-s390x/cpu_models.

[Qemu-devel] [Patch v3 10/30] s390x/cpumodel: expose features and feature groups as properties

2016-08-24 Thread David Hildenbrand
Let's add all features and feature groups as properties to all CPU models. If the "host" CPU model is unknown, we can neither query nor change features. KVM will just continue to work like it did until now. We will not allow to enable features that were not part of the original CPU model, because

[Qemu-devel] [PATCH v2 0/7] docker tests fixes

2016-08-24 Thread Sascha Silbe
A couple of fixes for issues encountered while trying out the new docker test support. As of v2 building the debian-debootstrap image now works on my laptop, too. Thanks for the docker test support, BTW. The centos6 test came in rather handy today for testing the glib < 2.30 compatibility code. v

[Qemu-devel] [Patch v3 08/30] s390x/cpumodel: register defined CPU models as subclasses

2016-08-24 Thread David Hildenbrand
This patch adds the CPU model definitions that are known on s390x - like z900, zBC12 or z13. For each definition, introduce two CPU models: 1. Base model (e.g. z13-base): Minimum feature set we expect to be around on all z13 systems. These models are migration-safe and will never change. 2.

  1   2   >