Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-14 Thread Prerna Saxena
On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: >On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: >> >> On 12/08/16 12:08 pm, "Fam Zheng" wrote: >> >> >> >> >> >> >On Wed, 08/10 18:30, Michael S. Tsirkin wrote: >> >> From: Prerna Saxena >> >> >> >> The set_mem_table comma

Re: [Qemu-devel] [PATCH for-2.7 1/4] virtio: recalculate vq->inuse after migration

2016-08-14 Thread Fam Zheng
On Fri, 08/12 16:32, Stefan Hajnoczi wrote: > The vq->inuse field is not migrated. Many devices don't hold > VirtQueueElements across migration so it doesn't matter that vq->inuse > starts at 0 on the destination QEMU. > > At least virtio-serial, virtio-blk, and virtio-balloon migrate while > hol

[Qemu-devel] [PATCH v2] hw/vfio/platform: Add Qualcomm Technologies, Inc HIDMA device support

2016-08-14 Thread Shanker Donthineni
This patch introduces the Qualcomm Technologies, Inc HIDMA device and allows passthrough the host HIDMA device to a guest machine using the vfio-platform framework. A platform device tree node is created for the guest machine which contains the compat string 'qcom,hidma-1.0', mmio regions, active

Re: [Qemu-devel] [PATCH] monitor: Add an "xlate" command for translating a virtual address

2016-08-14 Thread Peter Maydell
On 13 August 2016 at 12:52, Benjamin Herrenschmidt wrote: > This is very handy when debugging a guest, especially when it's > stuck on accessing some HW and the only way to figure out what > specific piece of HW is to translate the virtual address to > a hardware address that can then be matched w

Re: [Qemu-devel] Fix for CVE-2016-5403 causes crash on migration if memory stats are enabled

2016-08-14 Thread Gaudenz Steinlin
Hi Stefan Hajnoczi writes: > [ Unknown signature status ] > On Thu, Aug 11, 2016 at 09:18:12AM +0200, Gaudenz Steinlin wrote: >> >> [ Please CC me on replies as I'm not subscribed to this list. ] >> >> Hi >> >> The Fix for CVE-2016-5403 (virtio: error out if guest exceeds virtqueue >> size)

Re: [Qemu-devel] Fix for CVE-2016-5403 causes crash on migration if memory stats are enabled

2016-08-14 Thread Gaudenz Steinlin
Gaudenz Steinlin writes: > Hi > > Stefan Hajnoczi writes: > >> [ Unknown signature status ] >> On Thu, Aug 11, 2016 at 09:18:12AM +0200, Gaudenz Steinlin wrote: >>> >>> [ Please CC me on replies as I'm not subscribed to this list. ] >>> >>> Hi >>> >>> The Fix for CVE-2016-5403 (virtio: error

Re: [Qemu-devel] [PATCH] monitor: Add an "xlate" command for translating a virtual address

2016-08-14 Thread Benjamin Herrenschmidt
On Sun, 2016-08-14 at 19:55 +0100, Peter Maydell wrote: > On 13 August 2016 at 12:52, Benjamin Herrenschmidt > wrote: > > > > This is very handy when debugging a guest, especially when it's > > stuck on accessing some HW and the only way to figure out what > > specific piece of HW is to translate

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-14 Thread Michael S. Tsirkin
On Sun, Aug 14, 2016 at 09:42:11AM +, Prerna Saxena wrote: > On 14/08/16 8:21 am, "Michael S. Tsirkin" wrote: > > > >On Fri, Aug 12, 2016 at 07:16:34AM +, Prerna Saxena wrote: > >> > >> On 12/08/16 12:08 pm, "Fam Zheng" wrote: > >> > >> > >> > >> > >> > >> >On Wed, 08/10 18:30, Mi

[Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread Benjamin Herrenschmidt
This adds a simplistic emulation of the Sun GEM ethernet controller found in Apple ASICs. Currently we only support the Apple UniNorth 1.x variant, but the other Apple or Sun variants should mostly be a matter of adding PCI IDs options. It doesn't (yet) support state saving, but neither does the

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1471214931.12231.71.ca...@kernel.crashing.org Subject: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH] monitor: Add an "xlate" command for translating a virtual address

2016-08-14 Thread Benjamin Herrenschmidt
On Sun, 2016-08-14 at 19:55 +0100, Peter Maydell wrote: > On 13 August 2016 at 12:52, Benjamin Herrenschmidt > wrote: > > > > This is very handy when debugging a guest, especially when it's > > stuck on accessing some HW and the only way to figure out what > > specific piece of HW is to translate

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread Benjamin Herrenschmidt
On Sun, 2016-08-14 at 15:54 -0700, no-reply@ec2-52-6-146-230.compute- 1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output > below for more information: Bla bla bla bla ... Seriously, we have nazi stylebot on the list now ? I made conscious decisions

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread Benjamin Herrenschmidt
On Mon, 2016-08-15 at 09:59 +1000, Benjamin Herrenschmidt wrote: > Bla bla bla bla ... > > Seriously, we have nazi stylebot on the list now ? > > I made conscious decisions to style it this way and as far as the tabs > in the .h are concerned, that's because the file is lifted from Linux > and I'

[Qemu-devel] [Bug 1613133] [NEW] SLIRP code regression fails to build on OpenBSD

2016-08-14 Thread Brad Smith
Public bug reported: The SLIRP code has regressed between 2.6 and 2.7 and now fails to build on OpenBSD. cc -I/home/ports/pobj/qemu-2.7.0-rc2/qemu-2.7.0-rc2/tcg -I/home/ports/pobj/qemu-2.7.0-rc2/qemu-2.7.0-rc2/tcg/i386 -I. -I/home/ports/pobj/qemu-2.7.0-rc2/qemu-2.7.0-rc2 -I/home/ports/pobj/ qem

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-14 Thread Zheng, Lv
Hi, > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > revision changes > > On Fri, Aug 12, 2016 at 12:47:04AM +, Zheng, Lv wrote: > > Hi, Igor > > > > Thanks for the review. > > > > > From: Igor Mammedov [mailto:imamm.

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-14 Thread Zheng, Lv
Hi, Paolo > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > revision changes > > > > On 11/08/2016 11:36, Lv Zheng wrote: > > > > -error_setg(errp, "'-acpitable' requires one of 'data' or 'file'"); > > +val = qemu

Re: [Qemu-devel] [PATCH v24 11/12] support replication driver in blockdev-add

2016-08-14 Thread Changlong Xie
On 08/09/2016 05:08 PM, Kevin Wolf wrote: Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake @@ -2078,6

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-14 Thread Michael S. Tsirkin
On Mon, Aug 15, 2016 at 01:33:41AM +, Zheng, Lv wrote: > Hi, > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > > revision changes > > > > On Fri, Aug 12, 2016 at 12:47:04AM +, Zheng, Lv wrote: > > > Hi, Igor

Re: [Qemu-devel] [PATCH V4] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-08-14 Thread Zhang Chen
On 08/10/2016 10:57 PM, Paolo Bonzini wrote: On 10/08/2016 10:16, Zhang Chen wrote: Hi~ paolo~~ Just a ping... Have any comments for this patch? Same as before: the patch is pointless alone, it makes sense to include it as part of CoLo, if CoLo needs it. OK, I will move this patch to col

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-14 Thread Zheng, Lv
Hi, > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > revision changes > > On Mon, Aug 15, 2016 at 01:33:41AM +, Zheng, Lv wrote: > > Hi, > > > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Subject: Re:

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-14 Thread Michael S. Tsirkin
On Mon, Aug 15, 2016 at 02:18:55AM +, Zheng, Lv wrote: > Hi, > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > > revision changes > > > > On Mon, Aug 15, 2016 at 01:33:41AM +, Zheng, Lv wrote: > > > Hi, > >

Re: [Qemu-devel] [PATCH v3] vfio : add aer process

2016-08-14 Thread Zhou Jie
ping On 2016/8/2 11:57, Zhou Jie wrote: During aer err occurs and resume do following to protect device from being accessed. 1. Make config space read only. 2. Disable INTx/MSI Interrupt. 3. Do nothing for bar regions. Signed-off-by: Zhou Jie --- v2-v3: 1. Call init_completion() in vfio_pci

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-14 Thread Zheng, Lv
Hi, Michael > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > revision changes > > On Mon, Aug 15, 2016 at 02:18:55AM +, Zheng, Lv wrote: > > Hi, > > > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Subjec

Re: [Qemu-devel] [PATCH v2] docs: add cpu-hotplug.txt

2016-08-14 Thread Dou Liyang
Hi drew, 在 2016年08月12日 23:44, Andrew Jones 写道: Hi Dou, I'm catching up on mail after vacation so I reviewed the wrong version of this patch first... Darn. I'll try again with this version. Please still check my comments in that old version though, as I'm going faster through this one and may m

Re: [Qemu-devel] [PATCH RFC] msix_init: input params *_offset isn't the real one

2016-08-14 Thread Cao jin
Sorry for the noise. On 08/10/2016 11:18 AM, Cao jin wrote: The parameter table_offset & pba_offset is kind of confusing, they shouldn't include bir field. Signed-off-by: Cao jin --- According to the passed arguments, I guess all the callers of msix_init() has the same feeling with me, but I

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-14 Thread Zheng, Lv
Hi, Igor > From: Igor Mammedov [mailto:imamm...@redhat.com] > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > revision changes > > On Fri, 12 Aug 2016 00:47:04 + > "Zheng, Lv" wrote: > > > Hi, Igor > > > > Thanks for the review. > > > > > From: Igor Mammedov [mailto:i

[Qemu-devel] ARM MCU Target Structure Question

2016-08-14 Thread Carl Allendorph
Hello All, I'm working on a new microcontroller target (Atmel ATSAM4E) for the qemu-system-arm executable. I've successfully setup a machine and created some peripherals. I have some questions about how to structure the files for contributing this target to the qemu project. ​In the current "hw"

Re: [Qemu-devel] [PATCH v5 1/2] ACPI: Cleanup -acpitable option code

2016-08-14 Thread Zheng, Lv
Hi, Igor > From: Igor Mammedov [mailto:imamm...@redhat.com] > Subject: Re: [PATCH v5 1/2] ACPI: Cleanup -acpitable option code > > On Thu, 11 Aug 2016 17:36:38 +0800 > Lv Zheng wrote: > > > In -acpitable options, at least/most one data/file sub-option is mandatory, > > this patch cleans up the

Re: [Qemu-devel] [PATCH v3] qemu-img: add conv=notrunc option to dd

2016-08-14 Thread Fam Zheng
On Thu, 08/11 11:31, Reda Sallahi wrote: > This adds the conv=notrunc option to dd which tells dd to not truncate the > output. > > Signed-off-by: Reda Sallahi > --- > Depends on: > [PATCH v5] qemu-img: add skip option to dd > > Changes from v2: > * Delete the mandatory conv=notrunc > Changes fr

[Qemu-devel] [PATCH v3] docs: add cpu-hotplug.txt

2016-08-14 Thread Dou Liyang
This document describes how to use cpu hotplug in QEMU. Signed-off-by: Dou Liyang --- Change log v2 -> v3: From drew's advice: 1. modify the examples. 2. Fix some syntax. Change log v1 -> v2: From Fam's advice: 1. Fix some comment. Change log v1: From Igor's advice: 1. Rem

Re: [Qemu-devel] [PATCH v2] qemu-img: change opening method for the output in dd

2016-08-14 Thread Fam Zheng
On Thu, 08/11 15:04, Reda Sallahi wrote: > dd was creating an output image regardless of whether there was one already > created. With this patch we try to open first the output image and resize it > if necessary. > > We also make it mandatory to specify conv=notrunc when the file already > exists

[Qemu-devel] [PULL 0/1] ppc-for-2.7 queue 20160815

2016-08-14 Thread David Gibson
The following changes since commit 60ac136102098a70b97ab0c07bc7bf53131c: target-arm: Fix warn about implicit conversion (2016-08-12 11:12:24 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160815 for you to fetch changes up to e703d2f7

[Qemu-devel] [PULL 1/1] ppc: parse cpu features once

2016-08-14 Thread David Gibson
From: Greg Kurz Considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation lo

Re: [Qemu-devel] [PATCH v2] docs: add cpu-hotplug.txt

2016-08-14 Thread Andrew Jones
On Mon, Aug 15, 2016 at 11:48:59AM +0800, Dou Liyang wrote: > Hi drew, > > 在 2016年08月12日 23:44, Andrew Jones 写道: > > > > Hi Dou, > > > > I'm catching up on mail after vacation so I reviewed the wrong > > version of this patch first... Darn. I'll try again with this > > version. Please still chec

Re: [Qemu-devel] [Bug 1613133] [NEW] SLIRP code regression fails to build on OpenBSD

2016-08-14 Thread Thomas Huth
On 15.08.2016 02:46, Brad Smith wrote: > Public bug reported: > > The SLIRP code has regressed between 2.6 and 2.7 and now fails to build > on OpenBSD. [...] > In file included from /usr/include/net/if.h:454:0, > from slirp/slirp.c:34: > /usr/include/net/if_arp.h:47:8: error: rede