On Sun, 2016-08-14 at 19:55 +0100, Peter Maydell wrote: > On 13 August 2016 at 12:52, Benjamin Herrenschmidt > <b...@kernel.crashing.org> wrote: > > > > This is very handy when debugging a guest, especially when it's > > stuck on accessing some HW and the only way to figure out what > > specific piece of HW is to translate the virtual address to > > a hardware address that can then be matched with the mtree > > > > Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> > > Should this wrap cpu_get_phys_page_attrs_debug() instead > (and report the attributes to the user)?
Looking at this... the attributes are a bit of a mess aren't they ? The requester_id is pretty much PCI specific and only useful for load/stores coming from a device (for IOMMUs), the "secure" bit seems to be an ARM thing and is an output from translation, what about "user" ? IE, it's a blend of things that are input to an access and things that are output from translate as far as I can tell ... For the monitor, I'm thinking of just printing "secure", what do you think ? Cheers, Ben.
