Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Nikunj A Dadhania
Thomas Huth writes: >>> You can not rely on /dev/random for this job, since it might block. So >>> your guest would stop executing when there is not enough random data >>> available in the host, and I think that's quite a bad behavior... >> >> Hmm.. rng-random does use this, but it might have way

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Thomas Huth
On 12.08.2016 10:41, Nikunj A Dadhania wrote: > Thomas Huth writes: You can not rely on /dev/random for this job, since it might block. So your guest would stop executing when there is not enough random data available in the host, and I think that's quite a bad behavior... >>> >>> H

Re: [Qemu-devel] [PATCH] intel_iommu: add "eim" property

2016-08-12 Thread Peter Xu
On Thu, Aug 11, 2016 at 05:44:16PM +0200, Radim Krčmář wrote: > 2016-08-11 21:29+0800, Peter Xu: > > Adding one extra property for intel-iommu device to decide whether we > > should support EIM bit for IR. > > > > Now we are throwing high 24 bits of dest_id away directly. This will > > cause inter

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Nikunj A Dadhania
Thomas Huth writes: > On 12.08.2016 10:41, Nikunj A Dadhania wrote: >> Thomas Huth writes: > You can not rely on /dev/random for this job, since it might block. So > your guest would stop executing when there is not enough random data > available in the host, and I think that's quite

Re: [Qemu-devel] [RFC PATCH v1 2/2] utils: Add prefetch for Thunderx platform

2016-08-12 Thread Richard Henderson
On 08/12/2016 12:32 PM, Vijay Kilari wrote: On Sat, Aug 6, 2016 at 3:47 PM, Richard Henderson wrote: On 08/02/2016 03:50 PM, vijay.kil...@gmail.com wrote: +#define VEC_PREFETCH(base, index) \ +asm volatile ("prfm pldl1strm, [%x[a]]\n" : : [a]"r"(&base[(index)])) Is this not __built

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Fri, Aug 12, 2016 at 12:13:49PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > [ Unknown signature status ] >> > On Tue, Aug 09, 2016 at 02:47:46PM +0530, Nikunj A Dadhania wrote: >> >> Nikunj A Dadhania writes: >> >> >

Re: [Qemu-devel] [RFC v5 4/7] target-arm/kvm: Pass requester ID to MSI routing functions

2016-08-12 Thread Peter Maydell
On 2 August 2016 at 19:07, Eric Auger wrote: > From: Pavel Fedin > > Introduce global kvm_arm_msi_use_devid flag and pass device IDs in > kvm_arch_fixup_msi_route(). Device IDs are required by the ITS. > > Signed-off-by: Pavel Fedin > Signed-off-by: Eric Auger > > --- > > v3 -> v4: > - OR route

Re: [Qemu-devel] [PATCH v1 02/10] target-ppc: consolidate load operations

2016-08-12 Thread Richard Henderson
On 08/12/2016 05:52 AM, Nikunj A Dadhania wrote: Richard Henderson writes: On 08/10/2016 08:00 PM, Nikunj A Dadhania wrote: +#define GEN_QEMU_LOAD_64(ldop, op) \ +static void glue(gen_qemu_, glue(ldop, _i64))(DisasContext *ctx,\ +

[Qemu-devel] [PATCH v2 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method

2016-08-12 Thread Xiao Guangrong
Currently, 'RLEN' is the totally buffer size written by QEMU and it is ACPI internally used only. The buffer size returned to guest should not include 'RLEN' itself Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi

[Qemu-devel] [PATCH v8 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-12 Thread Colin Lord
From: Marc Mari Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. In addition, only the protocol dr

Re: [Qemu-devel] [RFC v5 1/7] hw/intc/arm_gicv3_its: Implement ITS base class

2016-08-12 Thread Peter Maydell
On 2 August 2016 at 19:07, Eric Auger wrote: > From: Pavel Fedin > > This is the basic skeleton for both KVM and software-emulated ITS. > Since we already prepare status structure, we also introduce complete > VMState description. But, because we currently have no migratable > implementations, we

[Qemu-devel] [PATCH v2 2/8] nvdimm acpi: prebuild nvdimm devices for available slots

2016-08-12 Thread Xiao Guangrong
For each NVDIMM present or intended to be supported by platform, platform firmware also exposes an ACPI Namespace Device under the root device So it builds nvdimm devices for all slots to support vNVDIMM hotplug Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c| 41

[Qemu-devel] [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback

2016-08-12 Thread Xiao Guangrong
We should let nvdimm acpi know which nvdimm device is being unplugged before QEMU interrupts the guest so that nvdimm acpi can update its FIT properly prepare_unplug() callback is introduced exactly for this purpose then the being removed device is skipped when guest reads FIT Signed-off-by: Xiao

[Qemu-devel] [PATCH v2 6/8] pc: memhp: do not export nvdimm's memory via _CRS

2016-08-12 Thread Xiao Guangrong
nvdimm's memory info can not exported via _CRS, instead, it is reported by NFIT/FIT This patch let _CRS return zero for both memory address and memory size if it is a nvdimm device inserted to the slot Signed-off-by: Xiao Guangrong --- hw/acpi/memory_hotplug.c | 16 inc

[Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-12 Thread Xiao Guangrong
This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing rx queue siz) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 Changelog in v2: Fixed signed integer overflow pointed out by Stefan Hajnoczi This patch

[Qemu-devel] [PATCH v2 3/8] nvdimm acpi: introduce _FIT

2016-08-12 Thread Xiao Guangrong
_FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received As FIT buffer is not completely mapped into guest address space, so a new function, Read FIT whose function index is 0x, is reserved by QEMU to read the piece of FIT buff

Re: [Qemu-devel] [PATCH v8 0/4] Dynamic module loading for block drivers

2016-08-12 Thread Max Reitz
On 12.08.2016 15:27, Colin Lord wrote: > v8: > - Add note to commit message about dmg not being modularized > > v7: > - Add ifdef around qemu_iscsi_opts in vl.c (first patch) > > v6: > - Fix bug so that users can specify a modularized driver on the cli > without qemu exiting > - Remove extra li

[Qemu-devel] [PATCH v2 4/8] nvdimm acpi: implement Read FIT function

2016-08-12 Thread Xiao Guangrong
Read FIT whose function index is 0x is reserved by QEMU to read the piece of FIT buffer. Please refer to docs/specs/acpi_nvdimm.txt for detailed info Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 61 1 file changed, 61 inser

[Qemu-devel] [PATCH v2 7/8] pc: acpi: memhp: nvdimm hotplug support

2016-08-12 Thread Xiao Guangrong
It notifies the nvdimm root device if there is a nvdimm device plugged/unplugged A new bit is used to indicates it is a nvdimm device Signed-off-by: Xiao Guangrong --- docs/specs/acpi_mem_hotplug.txt | 4 +++- hw/acpi/memory_hotplug.c| 5 - hw/i386/acpi-build.c| 26 +++

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Richard Henderson
On 08/12/2016 10:51 AM, Nikunj A Dadhania wrote: I can drop this from my patch series, until we have clarity here. Why don't you just drop the internals from helper_darn*, leaving both to always return -1. That way we can keep the translation work that you did. r~

Re: [Qemu-devel] [RFC v5 2/7] target-arm: move gicv3_class_name from machine to kvm_arm.h

2016-08-12 Thread Peter Maydell
On 2 August 2016 at 19:07, Eric Auger wrote: > Machine.c contains code related to migration. Let's move > gicv3_class_name to kvm_arm.h instead. > > Signed-off-by: Eric Auger > Suggested-by: Peter Maydell > > --- Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH v2 8/8] nvdimm docs: add nvdimm Read FIT function

2016-08-12 Thread Xiao Guangrong
Add the specification of Read FIT function Signed-off-by: Xiao Guangrong --- docs/specs/acpi_nvdimm.txt | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/docs/specs/acpi_nvdimm.txt b/docs/specs/acpi_nvdimm.txt index 0fdd251..1a31b19 10064

[Qemu-devel] [PATCH v8 2/4] blockdev: Add dynamic generation of module_block.h

2016-08-12 Thread Colin Lord
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: Stefan Hajn

Re: [Qemu-devel] [PATCH v3 06/10] palmetto-bmc: add board specific configuration

2016-08-12 Thread Cédric Le Goater
On 08/11/2016 12:27 PM, Peter Maydell wrote: > On 2 August 2016 at 18:15, Cédric Le Goater wrote: >> aspeed_board_init() now uses a board identifier to customize some values >> specific to the board. >> >> Signed-off-by: Cédric Le Goater >> --- >> >> Changes since v2: >> >> - removed silicon-re

Re: [Qemu-devel] [PATCH] xen: handle inbound migration of VMs without ioreq server pages

2016-08-12 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 11 August 2016 21:07 > To: Paul Durrant > Cc: Anthony Perard; xen-de...@lists.xenproject.org; qemu- > de...@nongnu.org; Stefano Stabellini > Subject: RE: [PATCH] xen: handle inbound migration of VMs with

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-12 Thread Colin Lord
On 08/11/2016 09:29 PM, Fam Zheng wrote: > On Thu, 08/11 12:03, Colin Lord wrote: >> On 08/10/2016 11:23 PM, Fam Zheng wrote: >>> On Wed, 08/10 21:06, Max Reitz wrote: On 10.08.2016 21:04, Colin Lord wrote: > On 08/10/2016 02:37 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord w

[Qemu-devel] 答复: [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-12 Thread 李强
Hello Dmitry, I don't see the assert for 'max_frags' in vmxnet device emulation. Could you please point it out? In my PoC, I set it to '0x2000', and in vmxnet_tx_pkt_init() the 'p->raw' will be NULL because of an integer overflow(in x86). And this will bypass all the assert, and in vmxne

Re: [Qemu-devel] [RFC v4 00/28] Base enabling patches for MTTCG

2016-08-12 Thread Alex Bennée
On 11 August 2016 at 17:43, G 3 wrote: > > On Aug 11, 2016, at 11:24 AM, qemu-devel-requ...@nongnu.org wrote: > > > Performance > > === > > > You can't do full work-load testing on this tree due to the lack of > > atomic support (but I will run some numbers on > > mttcg/base-patches-v4-wit

Re: [Qemu-devel] [RFC v5 5/7] hw/intc/arm_gicv3_its: Implement support for in-kernel ITS emulation

2016-08-12 Thread Peter Maydell
On 2 August 2016 at 19:07, Eric Auger wrote: > From: Pavel Fedin > > The ITS control frame is in-kernel emulated while accesses to the > GITS_TRANSLATER are mediated through the KVM_SIGNAL_MSI ioctl (MSI > direct MSI injection advertised by the CAP_SIGNAL_MSI capability) > > the kvm_gsi_direct_ma

Re: [Qemu-devel] [PATCH v3 00/10] arm: add ast2500 support

2016-08-12 Thread Peter Maydell
On 12 August 2016 at 09:38, Cédric Le Goater wrote: > On 08/11/2016 12:47 PM, Peter Maydell wrote: >> On 2 August 2016 at 18:15, Cédric Le Goater wrote: >>> On the AST2500, I am still having a little issue under uboot which >>> sets the vbar doing : >>> >>> mcr p15, 0, r0, c12

[Qemu-devel] 答复: [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-12 Thread 李强
Hi Dmitry > > > On 12 Aug 2016, at 04:21 AM, 李强 wrote: > > > > Hello Dmitry, > > > > I don't see the assert for 'max_frags' in vmxnet device emulation. Could you > please point it out? > > > Hi, > > I mean that max_frags for vmxnet3 device is a size of TX ring so assert > introduced by this

Re: [Qemu-devel] [PATCH v3 03/10] aspeed-soc: provide a framework to add new SoCs

2016-08-12 Thread Cédric Le Goater
On 08/11/2016 12:14 PM, Peter Maydell wrote: > On 2 August 2016 at 18:15, Cédric Le Goater wrote: >> Let's define an object class for each Aspeed SoC we support. A >> AspeedSoCInfo struct gathers the SoC specifications which can later be >> used by an instance of the class or by a board using the

[Qemu-devel] [PULL for-2.7 0/1] Tracing patches

2016-08-12 Thread Stefan Hajnoczi
The following changes since commit 28b874429ba16e71e0caa46453f3a3e31efb3c51: Merge remote-tracking branch 'remotes/amit-migration/tags/migration-for-2.7-7' into staging (2016-08-11 17:53:35 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-

Re: [Qemu-devel] [PATCH v2] help: Update help to reflect that GTK is the default

2016-08-12 Thread Paolo Bonzini
On 08/08/2016 08:56, Markus Armbruster wrote: > Aside: -nographic is hard to understand because it does too many things. -nographic is "just" -serial mon:stdio -machine graphics=false -display none. :) Paolo

Re: [Qemu-devel] [RFC v4 00/28] Base enabling patches for MTTCG

2016-08-12 Thread G 3
On Aug 12, 2016, at 9:19 AM, Alex Bennée wrote: On 11 August 2016 at 17:43, G 3 wrote: On Aug 11, 2016, at 11:24 AM, qemu-devel-requ...@nongnu.org wrote: Performance === You can't do full work-load testing on this tree due to the lack of atomic support (but I will run some numb

Re: [Qemu-devel] [PATCH] linux-aio: Handle io_submit() failure gracefully

2016-08-12 Thread Christian Borntraeger
On 08/09/2016 01:20 PM, Kevin Wolf wrote: > It is generally not expected that io_submit() fails other than with > -EAGAIN, but corner cases like SELinux refusing I/O when permissions are > revoked are still possible. In this case, we shouldn't abort, but just > return an I/O error for the request.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Nikunj A Dadhania
Richard Henderson writes: > On 08/12/2016 10:51 AM, Nikunj A Dadhania wrote: >> I can drop this from my patch series, until we have clarity here. > > Why don't you just drop the internals from helper_darn*, leaving both to > always > return -1. That way we can keep the translation work that yo

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Nikunj A Dadhania
Thomas Huth writes: > On 12.08.2016 08:43, Nikunj A Dadhania wrote: >> David Gibson writes: >> >>> [ Unknown signature status ] >>> On Tue, Aug 09, 2016 at 02:47:46PM +0530, Nikunj A Dadhania wrote: Nikunj A Dadhania writes: > David Gibson writes: > >> [ Unknown signatur

[Qemu-devel] [PATCH v8 1/4] blockdev: prepare iSCSI block driver for dynamic loading

2016-08-12 Thread Colin Lord
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- block/iscsi.c | 36 ---

[Qemu-devel] [PATCH v2] intel_iommu: add "eim" property

2016-08-12 Thread Peter Xu
Adding one extra property for intel-iommu device to decide whether we should support EIM bit for IR. Now we are throwing high 24 bits of dest_id away directly. This will cause interrupt issues with guests that: - enabled x2apic with cluster mode - have more than 8 vcpus (so dest_id[31:8] might be

[Qemu-devel] [PATCH v8 4/4] blockdev: Modularize nfs block driver

2016-08-12 Thread Colin Lord
Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/Makefile.objs b/block/Makefile.objs index

Re: [Qemu-devel] [RFC PATCH v1 2/2] utils: Add prefetch for Thunderx platform

2016-08-12 Thread Vijay Kilari
On Sat, Aug 6, 2016 at 3:47 PM, Richard Henderson wrote: > On 08/02/2016 03:50 PM, vijay.kil...@gmail.com wrote: >> >> +#define VEC_PREFETCH(base, index) \ >> +asm volatile ("prfm pldl1strm, [%x[a]]\n" : : >> [a]"r"(&base[(index)])) > > > Is this not __builtin_prefetch(base + index) ? > >

Re: [Qemu-devel] [PATCH v3 03/10] aspeed-soc: provide a framework to add new SoCs

2016-08-12 Thread Peter Maydell
On 12 August 2016 at 09:33, Cédric Le Goater wrote: > On 08/11/2016 12:14 PM, Peter Maydell wrote: >> board_id 0 means "I am an EBSA110", which this isn't, >> and your silicon rev values are completely out of range. > > OK. I was not aware of this. I will request new board ids for > the ast2400 an

Re: [Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver

2016-08-12 Thread Max Reitz
On 10.08.2016 21:22, Colin Lord wrote: > On 08/10/2016 03:04 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord wrote: >>> Modularizes the nfs block driver so that it gets dynamically loaded. >>> >>> Signed-off-by: Colin Lord >>> Reviewed-by: Stefan Hajnoczi >>> --- >>> block/Makefile.objs

Re: [Qemu-devel] [PATCH] intel_iommu: add "eim" property

2016-08-12 Thread Paolo Bonzini
On 11/08/2016 15:29, Peter Xu wrote: > + > +static void vtd_eim_prop_set(Object *o, bool value, Error **errp) > +{ > +IntelIOMMUState *s = INTEL_IOMMU_DEVICE(o); > +s->eim_supported = value; > +} > + > +static void vtd_instance_init(Object *o) > +{ > +IntelIOMMUState *s = INTEL_IOMMU_

Re: [Qemu-devel] Fix for CVE-2016-5403 causes crash on migration if memory stats are enabled

2016-08-12 Thread Stefan Hajnoczi
On Thu, Aug 11, 2016 at 09:18:12AM +0200, Gaudenz Steinlin wrote: > > [ Please CC me on replies as I'm not subscribed to this list. ] > > Hi > > The Fix for CVE-2016-5403 (virtio: error out if guest exceeds virtqueue > size)[1] causes qemu to exit(1) after migration or restart from a saved > st

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-12 Thread Stefan Hajnoczi
On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote: > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > rx queue siz) on pci branch of Michael's git tree and can be found at: > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v2 > > Changelog in v2: >

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-12 Thread Dmitry Fleytman
> On 12 Aug 2016, at 04:21 AM, 李强 wrote: > > Hello Dmitry, > > I don't see the assert for 'max_frags' in vmxnet device emulation. Could you > please point it out? Hi, I mean that max_frags for vmxnet3 device is a size of TX ring so assert introduced by this patch will fire all the time.

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Thomas Huth
On 12.08.2016 08:43, Nikunj A Dadhania wrote: > David Gibson writes: > >> [ Unknown signature status ] >> On Tue, Aug 09, 2016 at 02:47:46PM +0530, Nikunj A Dadhania wrote: >>> Nikunj A Dadhania writes: >>> David Gibson writes: > [ Unknown signature status ] > On Mon, Aug 08,

Re: [Qemu-devel] something broken in "v2.7.0-rc1" or just a behavior change?

2016-08-12 Thread Stefan Hajnoczi
On Fri, Aug 05, 2016 at 07:15:06AM +0200, Dennis Luehring wrote: > my scenario works with before "v2.7.0-rc1" > git "v2.5.0" OK > git "v2.6.0" OK > git "v2.7.0-rc0" OK > git "v2.7.0-rc1" FAILS I suggest using git-bisect(1) to find which commit between v2.7.0-rc0 and -rc1 introduced this. Then you

Re: [Qemu-devel] [RFC v4 00/28] Base enabling patches for MTTCG

2016-08-12 Thread Alex Bennée
Alex Bennée writes: > Alex Bennée writes: > >> This is the fourth iteration of the RFC patch set which aims to >> provide the basic framework for MTTCG. I hope this will provide a good >> base for discussion at KVM Forum later this month. >> > >> >> In practice the memory barrier problems don'

Re: [Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

2016-08-12 Thread Gerd Hoffmann
On Do, 2016-08-11 at 09:21 +0200, Thomas Huth wrote: > +[Q_KEY_CODE_BACKSPACE] = QEMU_KEY_BACKSPACE, Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v5 1/2] ACPI: Cleanup -acpitable option code

2016-08-12 Thread Igor Mammedov
On Thu, 11 Aug 2016 17:36:38 +0800 Lv Zheng wrote: > In -acpitable options, at least/most one data/file sub-option is mandatory, > this patch cleans up the code to reflect this in a managed manner so that > the follow-up mandatory sub-options can be added to -acpitable. > > Signed-off-by: Lv Zhe

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Peter Maydell
On 12 August 2016 at 08:20, Marc-André Lureau wrote: > Hi > > - Original Message - >> sent a follow-up response to GET_FEATURES), I am now wondering if this patch >> may break existing vhost applications too ? If so, reverting it possibly >> better. >> What confuses me is why it doesn’t fa

[Qemu-devel] [PATCH v8 0/4] Dynamic module loading for block drivers

2016-08-12 Thread Colin Lord
v8: - Add note to commit message about dmg not being modularized v7: - Add ifdef around qemu_iscsi_opts in vl.c (first patch) v6: - Fix bug so that users can specify a modularized driver on the cli without qemu exiting - Remove extra lines from Makefile - Add patch to modularize NFS v5: - No f

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread David Gibson
On Fri, Aug 12, 2016 at 12:13:49PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > [ Unknown signature status ] > > On Tue, Aug 09, 2016 at 02:47:46PM +0530, Nikunj A Dadhania wrote: > >> Nikunj A Dadhania writes: > >> > >> > David Gibson writes: > >> > > >> >> [ Unknown signature

Re: [Qemu-devel] [PATCH 5/5] target-arm: Fix warn about implicit conversion

2016-08-12 Thread Peter Maydell
On 11 August 2016 at 11:50, Peter Maydell wrote: > On 9 August 2016 at 20:02, Pranith Kumar wrote: >> Clang warns about an implicit conversion as follows: >> >> /mnt/devops/code/qemu/target-arm/neon_helper.c:1075:1: warning: implicit >> conversion from 'int' to 'int8_t' (aka 'signed char') chang

Re: [Qemu-devel] [PATCH] test-coroutine: Fix coroutine pool corruption

2016-08-12 Thread Kevin Wolf
Am 10.08.2016 um 13:17 hat Kevin Wolf geschrieben: > The test case overwrites the Coroutine object with 0xff as a way to > assert that the coroutine isn't used any more. However, this means that > the coroutine pool now contains a corrupted object and later test cases > may get this corrupted objec

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

2016-08-12 Thread Paolo Bonzini
On 11/08/2016 20:45, Ashijeet Acharya wrote: > Introduce VMChangeStateEntry parameter in ide_register_restart_cb() to handle > possible memory leak from qemu_add_vm_change_state_handler(). > > Signed-off-by: Ashijeet Acharya > --- > hw/ide/ahci.c | 2 +- > hw/ide/cmd646.c

Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-08-12 Thread Marek Vasut
On 08/10/2016 02:45 PM, Dmitry Osipenko wrote: > On 10.08.2016 13:30, Dmitry Osipenko wrote: > > [snip] > >> I suggest to provide "reset" function, otherwise it's likely that you would >> get >> unexpected result or crash on QEMU reset. This also applies to the "interrupt >> controller" patch. >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

2016-08-12 Thread Thomas Huth
On 12.08.2016 09:39, Nikunj A Dadhania wrote: > Thomas Huth writes: > >> On 12.08.2016 08:43, Nikunj A Dadhania wrote: >>> David Gibson writes: >>> [ Unknown signature status ] On Tue, Aug 09, 2016 at 02:47:46PM +0530, Nikunj A Dadhania wrote: > Nikunj A Dadhania writes: > >>>

[Qemu-devel] [PATCH for-2.7 0/4] virtio-balloon: fix stats vq migration

2016-08-12 Thread Stefan Hajnoczi
Gaudenz Steinlin reported that virtqueue_pop() terminates QEMU because the virtqueue size is exceeded following the CVE-2016-5403 fix. I have been unable to reproduce this or understand the root cause by code inspection. Along the way I did discover a few bugs in virtio-balloon and virtio code.

Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-08-12 Thread Marek Vasut
On 08/10/2016 12:30 PM, Dmitry Osipenko wrote: > On 07.08.2016 23:27, Marek Vasut wrote: >> On 07/30/2016 11:42 PM, Dmitry Osipenko wrote: >>> Hello Marek, >> >> Hi! >> >> Sorry for the late reply, I got back from vacation only recently. >> >> I noticed that a lot of files in this patchset are unde

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-12 Thread Igor Mammedov
On Fri, 12 Aug 2016 00:47:04 + "Zheng, Lv" wrote: > Hi, Igor > > Thanks for the review. > > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > > revision changes > > > > On Thu, 11 Aug 2016 17:36:45 +0800 > > Lv Zhe

Re: [Qemu-devel] [RFC v4 00/28] Base enabling patches for MTTCG

2016-08-12 Thread Alex Bennée
G 3 writes: > On Aug 12, 2016, at 9:19 AM, Alex Bennée wrote: > >> On 11 August 2016 at 17:43, G 3 wrote: >>> >>> On Aug 11, 2016, at 11:24 AM, qemu-devel-requ...@nongnu.org wrote: >>> >>> >>> Performance >>> >>> === >>> >>> >>> You can't do full work-load testing on this tree due to th

[Qemu-devel] [PATCH for-2.7 1/4] virtio: recalculate vq->inuse after migration

2016-08-12 Thread Stefan Hajnoczi
The vq->inuse field is not migrated. Many devices don't hold VirtQueueElements across migration so it doesn't matter that vq->inuse starts at 0 on the destination QEMU. At least virtio-serial, virtio-blk, and virtio-balloon migrate while holding VirtQueueElements. For these devices we need to re

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-12 Thread Paolo Bonzini
On 11/08/2016 11:36, Lv Zheng wrote: > > -error_setg(errp, "'-acpitable' requires one of 'data' or 'file'"); > +val = qemu_opt_get((QemuOpts *)opts, "fadt"); > +if (val) { > +unsigned long rev; Don't use qemu_opt_get. Add the field to AcpiTableOptions in qapi-schema.json,

[Qemu-devel] [PULL for-2.7 1/1] trace-events: fix first line comment in trace-events

2016-08-12 Thread Stefan Hajnoczi
From: Laurent Vivier Documentation is docs/tracing.txt instead of docs/trace-events.txt. find . -name trace-events -exec \ sed -i "s?See docs/trace-events.txt for syntax documentation.?See docs/tracing.txt for syntax documentation.?" \ {} \; Signed-off-by: Laurent Vivier Message-id:

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > sent a follow-up response to GET_FEATURES), I am now wondering if this patch > may break existing vhost applications too ? If so, reverting it possibly > better. > What confuses me is why it doesn’t fail all the time, but only about 20% to > 30% time as Fam report

[Qemu-devel] [PATCH for-2.7 3/4] virtio: add virtqueue_rewind()

2016-08-12 Thread Stefan Hajnoczi
virtqueue_discard() requires a VirtQueueElement but virtio-balloon does not migrate its in-use element. Introduce a new function that is similar to virtqueue_discard() but doesn't require a VirtQueueElement. This will allow virtio-balloon to access element again after migration with the usual pro

Re: [Qemu-devel] [PATCH v7 0/4] Dynamic module loading for block drivers

2016-08-12 Thread Max Reitz
On 08.08.2016 20:07, Colin Lord wrote: > One more minor revision from v6, no big changes. > > v7: > - Add ifdef around qemu_iscsi_opts in vl.c (first patch) > > v6: > - Fix bug so that users can specify a modularized driver on the cli > without qemu exiting > - Remove extra lines from Makefile

[Qemu-devel] [PATCH v4 0/2] trace: Simplify late initialization

2016-08-12 Thread Lluís Vilanova
Removes the need for 'trace_events_dstate_init' and does a little cleanup in how state values are modified (to avoid implicit conversions from bool). Changes in v2 = * Fix late-init state value [Daniel P. Berrange]. Changes in v3 = * Avoid implicit conversions from bool

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-12 Thread Igor Mammedov
On Fri, 12 Aug 2016 09:35:12 +0100 Stefan Hajnoczi wrote: > On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's git tree and can be found at: > > https://

[Qemu-devel] [Bug 891625] Re: [qemu-kvm] add vhost-net to kvm group udev rules 65-kvm.rules

2016-08-12 Thread T. Huth
Since there is no udev file in upstream QEMU, I guess this bug was meant for the qemu Ubuntu package instead? ** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/8

[Qemu-devel] [PATCH v4 1/2] trace: Remove 'trace_events_dstate_init'

2016-08-12 Thread Lluís Vilanova
Removes the event state array used for early initialization. Since only events with the "vcpu" property need a late initialization fixup, threats their initialization specially. Assumes that the user won't touch the state of "vcpu" events between early and late initialization (e.g., through QMP).

Re: [Qemu-devel] [PATCH] docs: add cpu-hotplug.txt

2016-08-12 Thread Andrew Jones
On Mon, Aug 08, 2016 at 10:28:02AM +0800, Dou Liyang wrote: > This document describes how to use cpu hotplug in QEMU. > > Signed-off-by: Dou Liyang > --- > docs/cpu-hotplug.txt | 110 > +++ > 1 file changed, 110 insertions(+) > create mode 100644

Re: [Qemu-devel] [PATCH v3 00/10] arm: add ast2500 support

2016-08-12 Thread Cédric Le Goater
On 08/11/2016 12:47 PM, Peter Maydell wrote: > On 2 August 2016 at 18:15, Cédric Le Goater wrote: >> On the AST2500, I am still having a little issue under uboot which >> sets the vbar doing : >> >> mcr p15, 0, r0, c12, c0, 0 /* Set VBAR */ >> >> and this is trapped as an

[Qemu-devel] [Bug 1603734] Re: Hang in fsqrt

2016-08-12 Thread Peter Maydell
Thanks for this bug report. The problem here is that QEMU is not correctly handling the obsolete "unnormal" 80-bit floating point format. The Intel architecture reference says that this should be handled by raising the invalid-input exception and returning the default NaN. See also the discussion

[Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

2016-08-12 Thread Fam Zheng
Previously all test cases in a category, such as check-qtest-y, are executed in a single long gtester command. This patch separates each test into its own make target to allow better parallism. Signed-off-by: Fam Zheng --- This saves 50% of the time "make check takes" compared to on master (I us

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > sent a follow-up response to GET_FEATURES), I am now wondering if this > > > patch > > > may break existing vhost applications too ? If so, revert

Re: [Qemu-devel] Hang bug in 80-bit float square root implementation

2016-08-12 Thread Peter Maydell
On 10 August 2016 at 04:35, Andrew Dutcher wrote: > Hello! > > I ran into an issue where qemu (specifically, the unicorn engine) > would hang forever in the middle of the emulated square root > instruction under certain circumstances. I eventually tracked the > issue down to the square root of an

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2016-08-12 Thread T. Huth
According to Stefan, this problem has been fixed by this commit: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=cc4662f9642995c78 ... so let's close this bug ticket now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH] intel_iommu: add "eim" property

2016-08-12 Thread Peter Xu
On Fri, Aug 12, 2016 at 10:34:44AM +0200, Paolo Bonzini wrote: > > > On 11/08/2016 15:29, Peter Xu wrote: > > + > > +static void vtd_eim_prop_set(Object *o, bool value, Error **errp) > > +{ > > +IntelIOMMUState *s = INTEL_IOMMU_DEVICE(o); > > +s->eim_supported = value; > > +} > > + > > +s

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2016-08-12 Thread T. Huth
As far as I can see, this should have been fixed in upstream QEMU by this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8cb6bfb54e91b1a31a ... so closing this issue now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a

[Qemu-devel] [PATCH for-2.7 2/4] virtio: decrement vq->inuse in virtqueue_discard()

2016-08-12 Thread Stefan Hajnoczi
virtqueue_descard() moves vq->last_avail_idx back so the element can be popped again. It's necessary to decrement vq->inuse to avoid "leaking" the element count. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio.c b/hw/vir

[Qemu-devel] [PATCH v4 2/2] trace: Avoid implicit bool->integer conversions

2016-08-12 Thread Lluís Vilanova
An explicit if/else is clearer than arithmetic assuming #true is 1, while the compiler should be able to generate just as optimal code. Signed-off-by: Lluís Vilanova --- stubs/trace-control.c | 17 +++-- trace/control-target.c | 31 ++- 2 files change

Re: [Qemu-devel] [Qemu-block] [PATCH v7 1/4] blockdev: prepare iSCSI block driver for dynamic loading

2016-08-12 Thread Stefan Hajnoczi
On Mon, Aug 08, 2016 at 02:07:17PM -0400, Colin Lord wrote: > This commit moves the initialization of the QemuOptsList qemu_iscsi_opts > struct out of block/iscsi.c in order to allow the iscsi module to be > dynamically loaded. > > Signed-off-by: Colin Lord > Reviewed-by: Fam Zheng > --- > bloc

[Qemu-devel] [PATCH for-2.7 4/4] virtio-balloon: fix stats vq migration

2016-08-12 Thread Stefan Hajnoczi
The statistics virtqueue is not migrated properly because virtio-balloon does not include s->stats_vq_elem in the migration stream. After migration the statistics virtqueue hangs because the host never completes the last element (s->stats_vq_elem is NULL on the destination QEMU). Therefore the gu

Re: [Qemu-devel] [PATCH v2] docs: add cpu-hotplug.txt

2016-08-12 Thread Andrew Jones
Hi Dou, I'm catching up on mail after vacation so I reviewed the wrong version of this patch first... Darn. I'll try again with this version. Please still check my comments in that old version though, as I'm going faster through this one and may miss things that are here too (although not all com

[Qemu-devel] [Bug 939995] Re: v1.0-1172-g235fe3b crashes (opts=0x0)

2016-08-12 Thread T. Huth
Peter's fix had been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=967c0da73a7b0da186baba6 ... so I think we can close this bug ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, whi

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2016-08-12 Thread T. Huth
Looks like Serge's fix has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=efc8243d00ab4cf4fa05a9b ... so let's close this bug now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > sent a follow-up response to GET_FEATURES), I am now wondering if this patch > > may break existing vhost applications too ? If so, reverting it possibly > > better. > > What confuses me is

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 01:01:16PM +0100, Peter Maydell wrote: > On 12 August 2016 at 08:20, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > >> sent a follow-up response to GET_FEATURES), I am now wondering if this > >> patch > >> may break existing vhost applications too ?

Re: [Qemu-devel] [PATCH v1 02/10] target-ppc: consolidate load operations

2016-08-12 Thread Nikunj A Dadhania
Richard Henderson writes: > On 08/12/2016 05:52 AM, Nikunj A Dadhania wrote: >> Richard Henderson writes: >> >>> On 08/10/2016 08:00 PM, Nikunj A Dadhania wrote: +#define GEN_QEMU_LOAD_64(ldop, op) \ +static void glue(gen_qemu_, glue(ldop, _i64))(DisasC

[Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

2016-08-12 Thread Marc-André Lureau
Add some missing flags description. Signed-off-by: Marc-André Lureau --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 8d84919..352cbdd 100755 --- a/configure +++ b/configure @@ -1324,9 +1324,11 @@ disabled with --disable-FEATURE, default is enab

Re: [Qemu-devel] [PATCH] trace-events: fix first line comment in trace-events

2016-08-12 Thread Stefan Hajnoczi
On Mon, Aug 08, 2016 at 05:11:21PM +0200, Laurent Vivier wrote: > Documentation is docs/tracing.txt instead of docs/trace-events.txt. > > find . -name trace-events -exec \ > sed -i "s?See docs/trace-events.txt for syntax documentation.?See > docs/tracing.txt for syntax documentation.?" \ >

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] coroutine: Assertions and debugging aids

2016-08-12 Thread Stefan Hajnoczi
On Thu, Aug 11, 2016 at 06:22:20PM +0200, Kevin Wolf wrote: > A while ago we were debugging a hang where coroutines were waiting for a mutex > to be unlocked, but we couldn't find out who held the lock. This series adds > some information to Coroutine and CoMutex that both allows to add a few > ass

Re: [Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > On 12 August 2016 at 16:52, Marc-André Lureau > wrote: > > Add some missing flags description. > > > > Signed-off-by: Marc-André Lureau > > --- > > configure | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/configure b/configure > > index 8d

Re: [Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-12 Thread Lai Jiangshan
On Fri, Aug 12, 2016 at 2:48 PM, Li, Liang Z wrote: >> >> > BTW. Is it possible to bypass the shared block in the >> >> 'ram_find_and_save_block'? >> >> > I mean no to check if a page is dirty for a shared block, it may >> >> > make things >> >> faster. >> >> >> >> Nice spotted. That would make t

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Prerna Saxena
On 12/08/16 12:08 pm, "Fam Zheng" wrote: >On Wed, 08/10 18:30, Michael S. Tsirkin wrote: >> From: Prerna Saxena >> >> The set_mem_table command currently does not seek a reply. Hence, there is >> no easy way for a remote application to notify to QEMU when it finished >> setting up memory,

  1   2   >