[Qemu-devel] [PATCH v3 7/9] configure: Remove detection code for UUID

All code now uses built-in UUID implementation. Remove the code of libuuid and make --enable-uuid and --disable-uuid only print a message. Signed-off-by: Fam Zheng --- configure | 43 --- 1 file changed, 4 insertions(+), 39 deletions(-) diff --git a/confi

[Qemu-devel] [PATCH v3 2/9] vhdx: Use QEMU UUID API

This removes our dependency to libuuid, so that the driver can always be built. Similar to how we handled data plane configure options, --enable-vhdx and --disable-vhdx are also changed to a nop with a message saying it's obsolete. Signed-off-by: Fam Zheng --- block/Makefile.objs | 2 +- block

Re: [Qemu-devel] [RFC PATCH v2 2/2] hw/intc/arm_gicv3_kvm: Implement get/put functions

On Mon, Aug 8, 2016 at 10:27 PM, Peter Maydell wrote: > On 8 August 2016 at 17:51, wrote: >> From: Vijaya Kumar K >> >> This actually implements pre_save and post_load methods for in-kernel >> vGICv3. >> >> Signed-off-by: Pavel Fedin >> Signed-off-by: Peter Maydell >> [PMM: >> * use decimal,

[Qemu-devel] [PATCH v3 4/9] vpc: Use QEMU UUID API

Previously we conditionally generated footer->uuid, when libuuid was available. Now that we have a built-in implementation, we can switch to it. Signed-off-by: Fam Zheng --- block/vpc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index

[Qemu-devel] [PATCH v3 9/9] tests: Add uuid tests

Signed-off-by: Fam Zheng --- tests/Makefile.include | 2 + tests/test-uuid.c | 173 + 2 files changed, 175 insertions(+) create mode 100644 tests/test-uuid.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 14be491..aa4f83

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

On Tue, Aug 09, 2016 at 08:33:13AM +0200, Jan Kiszka wrote: > On 2016-08-09 08:24, Peter Xu wrote: > > On Tue, Aug 09, 2016 at 02:18:15PM +0800, Peter Xu wrote: > >> On Tue, Aug 09, 2016 at 12:33:17PM +0800, Chao Gao wrote: > >>> On Mon, Aug 08, 2016 at 04:57:14PM +0800, Peter Xu wrote: > On M

Re: [Qemu-devel] [PATCH v1] docs: add cpu-hotplug.txt

Hello Liyang, Thanks for the contribution! On Tue, 08/09 14:48, Dou Liyang wrote: > This document describes how to use cpu hotplug in QEMU. > > Change log v1: > From Igor's advice: > 1. Remove any mentioning of apic-id from the document. > 2. Remove the "device_del qom_path" from the CP

Re: [Qemu-devel] [PATCH] target-mips: Fix warning about shifting negative value

On 08/08/2016 15:56, Pranith Kumar wrote: > Hi Paolo, > > On Mon, Aug 8, 2016 at 5:11 AM, Paolo Bonzini wrote: >> >> >> On 07/08/2016 03:15, Pranith Kumar wrote: >>> With latest clang you get the following warning: >>> >>> warning: shifting a negative signed value is undefined >>> [-Wshift-neg

Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defined'

On 09/08/2016 04:35, Pranith Kumar wrote: > Clang produces the following warning. The warning is detailed here: > https://reviews.llvm.org/D15866. Disable the warning. > > /home/pranith/devops/code/qemu/hw/display/qxl.c:507:5: warning: macro > expansion producing 'defined' has undefined behavio

Re: [Qemu-devel] [PATCH] hw/net: Fix a heap overflow in xlnx.xps-ethernetlite

On 2016年08月09日 11:52, chaojianhu wrote: The .receive callback of xlnx.xps-ethernetlite doesn't check the length of data before calling memcpy. As a result, the NetClientState object in heap will be overflowed. All versions of qemu with xlnx.xps-ethernetlite will be affected. Reported-by: chaoj

Re: [Qemu-devel] [PULL for-2.7 0/4] Error reporting patches for 2016-08-08

On Mon, 08/08 16:58, Markus Armbruster wrote: > Automated trivial patch checking at work, woot! > > I dropped no-re...@ec2-52-6-146-230.compute-1.amazonaws.com manually. > Fam, you might want to add a Reply-to: header. > > no-re...@ec2-52-6-146-230.compute-1.amazonaws.com writes: > > > Hi, > > >

[Qemu-devel] [PULL 2/3] net: vmxnet3: check for device_active before write

From: Li Qiang Vmxnet3 device emulator does not check if the device is active, before using it for write. It leads to a use after free issue, if the vmxnet3_io_bar0_write routine is called after the device is deactivated. Add check to avoid it. Reported-by: Li Qiang Signed-off-by: Prasad J Pand

[Qemu-devel] [PULL 0/3] Net patches

The following changes since commit 53279c76cf071fed07a336948d37c72e3613e0b7: Update version for v2.7.0-rc2 release (2016-08-08 17:26:11 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to a0d1cbdacff5df4ded

[Qemu-devel] [PULL 1/3] net: check fragment length during fragmentation

From: Prasad J Pandit Network transport abstraction layer supports packet fragmentation. While fragmenting a packet, it checks for more fragments from packet length and current fragment length. It is susceptible to an infinite loop, if the current fragment length is zero. Add check to avoid it.

[Qemu-devel] [PULL 3/3] hw/net: Fix a heap overflow in xlnx.xps-ethernetlite

From: chaojianhu The .receive callback of xlnx.xps-ethernetlite doesn't check the length of data before calling memcpy. As a result, the NetClientState object in heap will be overflowed. All versions of qemu with xlnx.xps-ethernetlite will be affected. Reported-by: chaojianhu Signed-off-by: cha

[Qemu-devel] [virtio-dev][RFC v3] virtio-sdm: new device specification

This patch adds the specification of the Signal Dristribution Module virtio device to the current virtio specification document. Signed-off-by: Christian Pinto Signed-off-by: Baptiste Reynal --- v2 -> v3: - Removed master field from configuration and replaced with device_id - Added new RESET si

[Qemu-devel] [PATCH] timer: set vm_clock disabled default

(commit 80dcfb8532ae76343109a48f12ba8ca1c505c179) Upon migration, the code use a timer based on vm_clock for 1ns in the future from post_load to do the event send in case host_connected differs between migration source and target. However, it's not guaranteed that the apic is ready to inject irqs

Re: [Qemu-devel] [PATCH v3 03/15] monitor: register gen:false commands manually

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Since a few commands are using 'gen': false, they are not registered > automatically by the generator. Register manually instead. > > This is in preparation for removal of qapi 'middle' mode generation. > > Note that this function

Re: [Qemu-devel] Abort with qemu-aarch64(latest git master)

On 8 August 2016 at 21:53, Pranith Kumar wrote: > I am seeing an abort when I run qemu-aarch64 on a multi-threaded ARM64 > executable. Is this a valid use case or is multi-threading still not > supported? It's a lot better than it was, but I think we have still got some places where we're missin

Re: [Qemu-devel] [PATCH v3 05/15] qapi: add 'export-marshal' command key

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > When a command sets the 'export-marshal' key to true, the generated > marshaller will be exported, so it can be called from outside. > > Signed-off-by: Marc-André Lureau Sure we need to make linkage configurable in the schema? W

Re: [Qemu-devel] [QUESTION]stuck in SeaBIOS and vm cannot be reset any more

>On Tue, Aug 02, 2016 at 04:18:30AM +, Xulei (Stone) wrote: >> >On Fri, Jul 29, 2016 at 04:04:59AM +, Xulei (Stone) wrote: >> >> After one day, the vm is stuck. Looking from the following seabios >> >> log, it seems seabios stops at "PCI: Using 00:02.0 for primary >> >> VGA", and can not ex

Re: [Qemu-devel] [QUESTION]stuck in SeaBIOS and vm cannot be reset any more

On 09/08/2016 10:04, Xulei (Stone) wrote: > Following your suggestion, i'm now sure it is caused by missing SMI. > I have tried adding dprintf() like this: > > --- a/roms/seabios/src/fw/smm.c > +++ b/roms/seabios/src/fw/smm.c > @@ -65,7 +65,8 @@ handle_smi(u16 cs) > u8 cmd = inb(PORT_SMI_CM

Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defined'

On 9 August 2016 at 03:35, Pranith Kumar wrote: > Clang produces the following warning. The warning is detailed here: > https://reviews.llvm.org/D15866. Disable the warning. > > /home/pranith/devops/code/qemu/hw/display/qxl.c:507:5: warning: macro > expansion producing 'defined' has undefined beh

Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defined'

On Tue, Aug 09, 2016 at 09:09:13AM +0100, Peter Maydell wrote: > On 9 August 2016 at 03:35, Pranith Kumar wrote: > > Clang produces the following warning. The warning is detailed here: > > https://reviews.llvm.org/D15866. Disable the warning. > > > > /home/pranith/devops/code/qemu/hw/display/qxl.c

Re: [Qemu-devel] [PATCH] timer: set vm_clock disabled default

On 09/08/2016 09:49, Gonglei wrote: > (commit 80dcfb8532ae76343109a48f12ba8ca1c505c179) > Upon migration, the code use a timer based on vm_clock for 1ns > in the future from post_load to do the event send in case host_connected > differs between migration source and target. > > However, it's not

Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defined'

On 09/08/2016 10:09, Peter Maydell wrote: > On 9 August 2016 at 03:35, Pranith Kumar wrote: >> Clang produces the following warning. The warning is detailed here: >> https://reviews.llvm.org/D15866. Disable the warning. >> >> /home/pranith/devops/code/qemu/hw/display/qxl.c:507:5: warning: macro

Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defined'

On 9 August 2016 at 09:15, Paolo Bonzini wrote: > > > On 09/08/2016 10:09, Peter Maydell wrote: >> Is this the only thing in our code which provokes the warning? >> If so, why don't we just fix it to not be undefined behaviour? > > Indeed that was my first suggestion yesterday. However, we use -W

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

On Tue, Aug 09, 2016 at 02:18:15PM +0800, Peter Xu wrote: >On Tue, Aug 09, 2016 at 12:33:17PM +0800, Chao Gao wrote: >> On Mon, Aug 08, 2016 at 04:57:14PM +0800, Peter Xu wrote: >> >On Mon, Aug 08, 2016 at 03:41:23PM +0800, Chao Gao wrote: >> >> HI, everyone. >> >> >> >> We have done some tests af

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

On Tue, 9 Aug 2016 11:23:58 +0800 Chao Gao wrote: > On Mon, Aug 08, 2016 at 11:18:20AM +0200, Igor Mammedov wrote: > >On Mon, 8 Aug 2016 15:41:23 +0800 > >Chao Gao wrote: > > > >> HI, everyone. > >> > >> We have done some tests after merging this patch set into the lastest qemu > >> master. I

[Qemu-devel] [PATCH] spar: remove extra type variable

The sPAPR CPU core typename is already available in the upper block. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index fdc6644d61cb..6dc5fe48971e 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1783,7

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

On Mon, 8 Aug 2016 16:57:14 +0800 Peter Xu wrote: > On Mon, Aug 08, 2016 at 03:41:23PM +0800, Chao Gao wrote: > > HI, everyone. > > > > We have done some tests after merging this patch set into the lastest qemu > > master. In kvm aspect, we use the lastest kvm linux-next branch. Here are > > som

Re: [Qemu-devel] [PATCH v3 04/15] monitor: remove usage of generated marshal functions

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Once the middle mode is removed, the generated marshal functions will no > longer be exported. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake > --- > monitor.c | 10 +- > 1 file changed, 5 insertions(+),

Re: [Qemu-devel] [PATCH v3 05/15] qapi: add 'export-marshal' command key

Hi On Tue, Aug 9, 2016 at 12:07 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > When a command sets the 'export-marshal' key to true, the generated > > marshaller will be exported, so it can be called from outside. > > > > Signed-off-by: M

Re: [Qemu-devel] [PATCH v3 04/15] monitor: remove usage of generated marshal functions

Hi On Tue, Aug 9, 2016 at 12:38 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Once the middle mode is removed, the generated marshal functions will no > > longer be exported. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Eri

Re: [Qemu-devel] [PATCH v1] docs: add cpu-hotplug.txt

Hi Fam, 在 2016年08月09日 15:14, Fam Zheng 写道: Hello Liyang, Thanks for the contribution! On Tue, 08/09 14:48, Dou Liyang wrote: This document describes how to use cpu hotplug in QEMU. Change log v1: From Igor's advice: 1. Remove any mentioning of apic-id from the document. 2. Remove th

[Qemu-devel] [PATCH v2 1/1] block/gluster: improve defense over string to int conversion

using atoi() for converting string to int may be error prone in case if string supplied in the argument is not a fold of numerical number, This is not a bug because in the existing code, static QemuOptsList runtime_tcp_opts = { .name = "gluster_tcp", .head = QTAILQ_HEAD_INITIALIZER(runtim

Re: [Qemu-devel] [PATCH] iotest 055: refactor and speed up

Am 06.08.2016 um 20:09 hat Vladimir Sementsov-Ogievskiy geschrieben: > Source disk is created and filled with test data before each test case. > Instead initialize it once for the whole unit. > > performance: > qcow2: 25s -> 15s > raw: 16s -> 11s > > Actually, changed only TestSetSpeed: before

Re: [Qemu-devel] [PATCH v24 11/12] support replication driver in blockdev-add

Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Reviewed-by: Eric Blake > @@ -2078,6 +2079,23 @@ > { 'enum' : 'R

Re: [Qemu-devel] [PATCH v1] docs: add cpu-hotplug.txt

On Tue, 08/09 16:47, Dou Liyang wrote: > >>+ > >>+ (qemu) device_del cpu1 > >>+ > > > >Can you also document what should be done in guest to make this operation > >successful? > > > > I am not sure about these words "what should be done in guest". > > Do you mean that setting the CPUx's online t

Re: [Qemu-devel] [PATCH v6] qemu-img: add the 'dd' subcommand

Am 25.07.2016 um 07:58 hat Reda Sallahi geschrieben: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. > > For the start, this implements the bs, if, of and count options and requires > both if and of to be specified (no stdin/stdout if not specified) and doesn't > support tt

[Qemu-devel] [PATCH 3/5] hw/ppc/spapr: Do not leak the memory of the type string

The type string is allocated in spapr_get_cpu_core_type() with g_strdup_printf(), so we should free this memory when we're done with it. Signed-off-by: Thomas Huth --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index ec65b07..424b506 100644

[Qemu-devel] [PATCH for-2.7 0/5] spapr: Fix regression in CPU alias handling

There is a regression with the "-cpu" parameter which has been introduced by the spapr CPU hotplug code: We used to allow to specify a "CPU family" name with the "-cpu" parameter when running on KVM so that the user does not need to know the gory details of the exact CPU version of the host CPU. Fo

[Qemu-devel] [PATCH 5/5] ppc/kvm: Register also a generic spapr CPU core family type

There is a regression with the "-cpu" parameter introduced by the spapr CPU hotplug code: We used to allow to specify a "CPU family" name with the "-cpu" parameter when running on KVM so that the user does not need to know the gory details of the exact CPU version of the host CPU. For example, it w

[Qemu-devel] [PATCH 1/5] ppc: Introduce a function to look up CPU alias strings

We will need this function to look up the aliases in the spapr-cpu-core code, too. Signed-off-by: Thomas Huth --- target-ppc/cpu.h| 1 + target-ppc/translate_init.c | 13 + 2 files changed, 14 insertions(+) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 5fce1ff.

Re: [Qemu-devel] [PATCH COLO-Frame v18 17/34] COLO failover: Introduce state to record failover process

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > +error_report("Unkown error for failover, old_state=%d", old_state); Tiny typo; 'Unknown'. Don't bother reposting just for that, we can fix it later; or fix it if you have to repost anyway. Dave > +return; > +} >

[Qemu-devel] [PATCH 4/5] ppc/kvm: Do not mess up the generic CPU family registration

The code for registering the sPAPR CPU host core type has been added inbetween the generic CPU host core type and the generic CPU family type. That way the instance_init and the class_init information got lost when registering the generic CPU family type. Fix it by moving the generic family registr

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/6] target-ppc: Implement darn instruction

Nikunj A Dadhania writes: > David Gibson writes: > >> [ Unknown signature status ] >> On Mon, Aug 08, 2016 at 07:33:37AM +1000, Benjamin Herrenschmidt wrote: >>> On Sun, 2016-08-07 at 23:06 +0530, Nikunj A Dadhania wrote: >>> > +target_ulong helper_darn(uint32_t l) >>> > +{ >>> > +    target_ulo

[Qemu-devel] [PATCH 2/5] hw/ppc/spapr: Look up CPU alias names instead of hard-coding the aliases

Hard-coding the CPU alias names in the spapr_cores[] array has two big disadvantages: 1) We register a real type with the CPU alias name in spapr_cpu_core_register_types() - this prevents us from registering a CPU family name in kvm_ppc_register_host_cpu_type() with the same name (as we d

Re: [Qemu-devel] [PATCH] clang: Disable warning about expansion to 'defined'

On 09/08/2016 10:17, Peter Maydell wrote: > On 9 August 2016 at 09:15, Paolo Bonzini wrote: >> >> >> On 09/08/2016 10:09, Peter Maydell wrote: >>> Is this the only thing in our code which provokes the warning? >>> If so, why don't we just fix it to not be undefined behaviour? >> >> Indeed that w

Re: [Qemu-devel] [PATCH v1] docs: add cpu-hotplug.txt

Hi Fam 在 2016年08月09日 17:07, Fam Zheng 写道: On Tue, 08/09 16:47, Dou Liyang wrote: + + (qemu) device_del cpu1 + Can you also document what should be done in guest to make this operation successful? I am not sure about these words "what should be done in guest". Do you mean that setting the

[Qemu-devel] [PATCH v1 1/1] block/gluster: fix port type in the QAPI options list

After introduction of qapi schema in gluster block driver code, the port type is now string as per InetSocketAddress { 'struct': 'InetSocketAddress', 'data': { 'host': 'str', 'port': 'str', '*to': 'uint16', '*ipv4': 'bool', '*ipv6': 'bool' } } but the current code still trea

Re: [Qemu-devel] [PATCH] iotest 055: refactor and speed up

On 09.08.2016 11:50, Kevin Wolf wrote: Am 06.08.2016 um 20:09 hat Vladimir Sementsov-Ogievskiy geschrieben: Source disk is created and filled with test data before each test case. Instead initialize it once for the whole unit. performance: qcow2: 25s -> 15s raw: 16s -> 11s Actually, changed

[Qemu-devel] [PATCH 0/5] POWER9 TCG enablement - part3

This series contains 14 new instructions for POWER9 described in ISA3.0. Patches: 01: Adds vector insert instructions. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doub

[Qemu-devel] [PATCH v2 2/5] target-ppc: add vector extract instructions

The following vector extract instructions are added from ISA 3.0. vextractub - Vector Extract Unsigned Byte vextractuh - Vector Extract Unsigned Halfword vextractuw - Vector Extract Unsigned Word vextractd - Vector Extract Unsigned Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- tar

[Qemu-devel] [PATCH v2 1/5] target-ppc: add vector insert instructions

The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd - Vector Insert Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |4 +++ target-

Re: [Qemu-devel] [PULL 0/3] Net patches

On 9 August 2016 at 08:34, Jason Wang wrote: > The following changes since commit 53279c76cf071fed07a336948d37c72e3613e0b7: > > Update version for v2.7.0-rc2 release (2016-08-08 17:26:11 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-r

[Qemu-devel] [PATCH v2 3/5] target-ppc: add vector count trailing zeros instructions

The following vector count trailing zeros instructions are added from ISA 3.0. vctzb - Vector Count Trailing Zeros Byte vctzh - Vector Count Trailing Zeros Halfword vctzw - Vector Count Trailing Zeros Word vctzd - Vector Count Trailing Zeros Doubleword Signed-off-by: Rajalakshmi Srinivasaraghavan

[Qemu-devel] [PATCH v2 4/5] target-ppc: add vector bit permute doubleword instruction

Add vbpermd instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 20 target-ppc/translate/vmx-impl.c |1 + target-ppc/translate/vmx-ops.c |1 + 4 files changed, 23 in

[Qemu-devel] [PATCH v2 5/5] target-ppc: add vector permute right indexed instruction

Add vpermr instruction from ISA 3.0. Signed-off-by: Rajalakshmi Srinivasaraghavan --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 23 +++ target-ppc/translate/vmx-impl.c | 18 ++ target-ppc/translate/vmx-ops.c |1 + 4 f

[Qemu-devel] [PATCH v2] docs: add cpu-hotplug.txt

This document describes how to use cpu hotplug in QEMU. Signed-off-by: Dou Liyang --- Change log v1 -> v2: From Fam's advice: 1. Fix some comment. Change log v1: From Igor's advice: 1. Remove any mentioning of apic-id from the document. 2. Remove the "device_del qom_path" from t

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

On Tue, 9 Aug 2016, Howard Spoelstra wrote: Openbios has problems with the USB keyboard when one specifically defines e.g., -device ich9-usb-uhci1,id=newusb -device usb-mouse,bus=newusb.0 (which is needed to get mouse/keyboard going in OSX 10.5) I think it does not have a UHCI driver, only mini

Re: [Qemu-devel] [PATCH] vhost: check for vhost_ops before using.

Hi On Wed, Aug 3, 2016 at 12:37 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Wed, Aug 3, 2016 at 9:25 AM Ilya Maximets > wrote: > >> 'vhost_set_vring_enable()' tries to call function using pointer to >> 'vhost_ops' which can be already zeroized in 'vhost_dev_cleanup()' >

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

On Mon, 8 Aug 2016 06:27:15 + "Zeng, Xin" wrote: > On Thu, Friday, August 05, 2016 3:56 AM, Michael S. Tsirkin wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, August 05, 2016 3:56 AM > > To: Gonglei (Arei) > > Cc: Zeng, Xin; qemu-d

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

On Mon, Aug 08, 2016 at 06:27:15AM +, Zeng, Xin wrote: > On Thu, Friday, August 05, 2016 3:56 AM, Michael S. Tsirkin wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, August 05, 2016 3:56 AM > > To: Gonglei (Arei) > > Cc: Zeng, Xin; qe

Re: [Qemu-devel] [PATCH] spar: remove extra type variable

On 09.08.2016 10:25, Cédric Le Goater wrote: > The sPAPR CPU core typename is already available in the upper > block. > > Signed-off-by: Cédric Le Goater > --- > hw/ppc/spapr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index fdc6644d61cb..6dc5fe48

Re: [Qemu-devel] [PATCH] spar: remove extra type variable

On 08/09/2016 01:05 PM, Thomas Huth wrote: > On 09.08.2016 10:25, Cédric Le Goater wrote: >> The sPAPR CPU core typename is already available in the upper >> block. >> >> Signed-off-by: Cédric Le Goater >> --- >> hw/ppc/spapr.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/hw/ppc/spa

[Qemu-devel] [PATCH v2] spar: remove extra type variable

The sPAPR CPU core typename is already available in the upper block. Let's use it and move the check upward also. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) Index: qemu-dgibson-for-2.8.git/hw/ppc/spapr.c ===

[Qemu-devel] [PATCH] linux-aio: Handle io_submit() failure gracefully

It is generally not expected that io_submit() fails other than with -EAGAIN, but corner cases like SELinux refusing I/O when permissions are revoked are still possible. In this case, we shouldn't abort, but just return an I/O error for the request. Signed-off-by: Kevin Wolf --- block/linux-aio.c

Re: [Qemu-devel] [PATCH v3 01/15] qapi-schema: use generated marshaller for 'qmp_capabilities'

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > qapi'fy the 'qmp_capabilities' command. Perhaps add: Makes the command visible in query-qmp-schema. Can do on commit. > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH for-2.7 0/5] spapr: Fix regression in CPU alias handling

On Tue, 2016-08-09 at 11:17 +0200, Thomas Huth wrote: > There is a regression with the "-cpu" parameter which has been > introduced by the spapr CPU hotplug code: We used to allow to specify > a "CPU family" name with the "-cpu" parameter when running on KVM so > that the user does not need to know

Re: [Qemu-devel] [PATCH v2] spar: remove extra type variable

On 09.08.2016 13:15, Cédric Le Goater wrote: > The sPAPR CPU core typename is already available in the upper > block. Let's use it and move the check upward also. > > Signed-off-by: Cédric Le Goater > --- > hw/ppc/spapr.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-)

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

On Tue, 2016-08-09 at 12:26 +0200, BALATON Zoltan wrote: > On Tue, 9 Aug 2016, Howard Spoelstra wrote: > > > > Openbios has problems with the USB keyboard when one specifically defines > > e.g., -device ich9-usb-uhci1,id=newusb -device usb-mouse,bus=newusb.0 > > (which is needed to get mouse/keybo

Re: [Qemu-devel] QEMU-guestOS latencies.

Hi stephan, Thanks for getting back to me, as for the mlock, we have tried it here and apparently mlock cause our system to freeze for some reason, using linux tools and ram allocation we have verified no swaps are occurring. still we have delays that cause our system to lose track. my goal as I

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu wrote: > On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote: > > [...] > > Hi Peter. Most of your comments are valid thought some are subjective :-). I'm covering most if not all of them on next version (should coming shortly). > +/* invalidate

Re: [Qemu-devel] [PATCH v3 10/15] qapi: check invalid arguments on no-args commands

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The generated marshal functions do not visit arguments from commands > that take no arguments. Thus they fail to catch invalid > members. Visit the arguments, if provided, to throw an error in case of > invalid members. Begs the q

Re: [Qemu-devel] [PATCH v3 10/15] qapi: check invalid arguments on no-args commands

Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > The generated marshal functions do not visit arguments from commands > > that take no arguments. Thus they fail to catch invalid > > members. Visit the arguments, if provided, to throw an

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

On Tue, Aug 09, 2016 at 03:07:43PM +0300, David Kiarie wrote: > On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu wrote: > > > On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote: > > > > [...] > > > > > Hi Peter. > > Most of your comments are valid thought some are subjective :-). I'm > coverin

Re: [Qemu-devel] [PATCH v3 11/15] qmp: update qmp_query_spice fallback

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The following "use qmp_dispatch()" commit will use the generated > dispatch command table that is unaware of compile time conditionals. > > There are a few commands that are under #ifdef conditions in > qmp-commands.hx. Move the qm

[Qemu-devel] [Bug 1062220] Re: qemu-system-arm crashed with SIGABRT in cpu_abort()

In the upcoming QEMU 2.7 we've removed the abort() call in this code path, and instead will print an error message which hopefully is clearer at suggesting to users where they've gone wrong rather than implying that this is a QEMU bug: == qemu-system-arm: Trying to execute code outside RAM or

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

2016-08-09 15:09+0800, Peter Xu: > On Tue, Aug 09, 2016 at 08:33:13AM +0200, Jan Kiszka wrote: >> On 2016-08-09 08:24, Peter Xu wrote: >> > On Tue, Aug 09, 2016 at 02:18:15PM +0800, Peter Xu wrote: >> >> On Tue, Aug 09, 2016 at 12:33:17PM +0800, Chao Gao wrote: >> >>> On Mon, Aug 08, 2016 at 04:57:

Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Replace the old manual dispatch and validation code by the generic one > provided by qapi common code. > > Note that it is now possible to call the following commands that used to > be disabled by compile-time conditionals: > - dum

Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()

On Tue, Aug 09, 2016 at 02:43:41PM +0200, Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Replace the old manual dispatch and validation code by the generic one > > provided by qapi common code. > > > > Note that it is now possible to call the

Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()

Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Replace the old manual dispatch and validation code by the generic one > > provided by qapi common code. > > > > Note that it is now possible to call the following commands that used to >

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

2016-08-09 16:19+0800, Chao Gao: > On Tue, Aug 09, 2016 at 02:18:15PM +0800, Peter Xu wrote: >>On Tue, Aug 09, 2016 at 12:33:17PM +0800, Chao Gao wrote: >>> On Mon, Aug 08, 2016 at 04:57:14PM +0800, Peter Xu wrote: >>> >On Mon, Aug 08, 2016 at 03:41:23PM +0800, Chao Gao wrote: >>> >> HI, everyone.

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu wrote: > On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote: > > [...] > > > +/* invalidate internal caches for devid */ > > +typedef struct QEMU_PACKED { > > +#ifdef HOST_WORDS_BIGENDIAN > > +uint64_t devid;/* device to inval

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

Hi all, On 09.08.2016 17:52, David Kiarie wrote: On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu mailto:pet...@redhat.com>> wrote: On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote: [...] > +/* invalidate internal caches for devid */ > +typedef struct QEMU_PACKED { >

Re: [Qemu-devel] [PATCH v2 12/12] Drop qmp-commands.hx

Marc-André Lureau writes: > Hi > > On Fri, Aug 5, 2016 at 6:58 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> [...] >> > diff --git a/qmp-commands.hx b/qmp-commands.txt >> > similarity index 87% >> > rename from qmp-commands.hx >> > rename to qmp-commands.txt >> >> Shoul

Re: [Qemu-devel] [PATCH v3 14/15] Drop qmp-commands.hx

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The only remaining function of qmp-commands.hx is to let us generate > qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt. > > (a later update will move the documentation in the respective json files > and again

Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation

On 08/08/2016 19:12, Peter Maydell wrote: > PS: if you would like your BSD flavour promoted to "we don't > merge changes that break the build on it" I would need to > have ssh access to a machine I can run builds and tests on. > (Unfortunately the only BSD in the gcc compile farm is an > ancient

[Qemu-devel] [PATCH v2] iotest 055: refactor and speed up

Source disk is created and filled with test data before each test case. Instead initialize it once for the whole unit. Test disk filling patterns are merged into one pattern. Also TestSetSpeed used different image_len for source and target (by mistake) - this is automatically fixed here. Signed-

Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation

On 9 August 2016 at 14:12, Paolo Bonzini wrote: > On 08/08/2016 19:12, Peter Maydell wrote: >> PS: if you would like your BSD flavour promoted to "we don't >> merge changes that break the build on it" I would need to >> have ssh access to a machine I can run builds and tests on. >> (Unfortunately

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

On Tue, Aug 9, 2016 at 4:01 PM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > Hi all, > > On 09.08.2016 17:52, David Kiarie wrote: > >> >> >> On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu > > wrote: >> >> On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

On Tue, Aug 09, 2016 at 10:28:41AM +0200, Igor Mammedov wrote: > On Mon, 8 Aug 2016 16:57:14 +0800 > Peter Xu wrote: > > > On Mon, Aug 08, 2016 at 03:41:23PM +0800, Chao Gao wrote: > > > HI, everyone. > > > > > > We have done some tests after merging this patch set into the lastest qemu > > > ma

Re: [Qemu-devel] [Xen-devel] [PATCH 15/19] Qemu-Xen-vTPM: Xen frontend driver infrastructure

On August 07, 2016 7:39 PM, Emil Condrea wrote: On Mon, Jul 25, 2016 at 7:01 PM, Anthony PERARD wrote: > > > > > +{ > > > +xs_transaction_t xbt = XBT_NULL; > > > + > > > +if (xendev->fe_state == xbus) { > > > +return 0; > > > +} > > > + > > > +xendev->fe_state = xbus; > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] adb: change handler only when recognized

On Tue, Aug 9, 2016 at 6:06 AM, Benjamin Herrenschmidt < b...@kernel.crashing.org> wrote: > On Tue, 2016-08-09 at 03:31 +0200, BALATON Zoltan wrote: > > > > > Because PowerBooks do (or rather a PMU-simulation of ADB) and MacOS > > > doesn't care. If ADB is in the device-tree, it will use it. It ma

[Qemu-devel] [PATCH] add migration capability to bypass the shared memory

When the migration capability 'bypass-shared-memory' is set, the shared memory will be bypassed when migration. It is the key feature to enable several excellent features for the qemu, such as qemu-local-migration, qemu-live-update, extremely-fast-save-restore, vm-template, vm-fast-live-clone, yet

Re: [Qemu-devel] [PATCH v3 14/15] Drop qmp-commands.hx

Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > The only remaining function of qmp-commands.hx is to let us generate > > qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt. > > > > (a later update will move the docum

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

On Tuesday, August 9, 2016 6:44 PM Cornelia Huck wrote: > -Original Message- > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Tuesday, August 9, 2016 6:44 PM > To: Zeng, Xin > Cc: Michael S. Tsirkin ; Gonglei (Arei) > ; qemu-devel@nongnu.org; virtio- > d...@lists.oasis-ope

Re: [Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

On Tue, 9 Aug 2016 21:35:04 +0800 Peter Xu wrote: > On Tue, Aug 09, 2016 at 10:28:41AM +0200, Igor Mammedov wrote: > > On Mon, 8 Aug 2016 16:57:14 +0800 > > Peter Xu wrote: > > > > > On Mon, Aug 08, 2016 at 03:41:23PM +0800, Chao Gao wrote: > > > > HI, everyone. > > > > > > > > We have don

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

On Tuesday, August 9, 2016 6:58 PM Michael S. Tsirkin Wrote: > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, August 9, 2016 6:58 PM > To: Zeng, Xin > Cc: Gonglei (Arei) ; qemu-devel@nongnu.org; > virtio-...@lists.oasis-open.org; Huangpeng (Peter) >

  1   2   3   4   >