On Tue, Aug 09, 2016 at 03:07:43PM +0300, David Kiarie wrote: > On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu <pet...@redhat.com> wrote: > > > On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote: > > > > [...] > > > > > Hi Peter. > > Most of your comments are valid thought some are subjective :-). I'm > covering most if not all of them on next version (should coming shortly).
Hi, David, I think for most subjective comments, I was using "Nit:" as prefix. Most of the other comments should not? ;) For endian issue, I am not sure whether that's important, since I don't know whether there will be anyone run x86_64 on e.g. big endian machines with a AMD IOMMU... For the other comments besides "nit" and "endianess" issues, I would like to hear your opinion if you disagree on any of them (so I can learn as well if I made any mistake). :) Thanks, -- peterx
