Re: [Qemu-devel] [PATCH 4/4] error: Fix error_printf() calls lacking newlines

Eric Blake writes: > On 08/03/2016 05:37 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> hw/i386/pc.c | 2 +- >> kvm-all.c| 2 +- >> ui/vnc.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> > > I'm guessing these were found with a slight tweak

Re: [Qemu-devel] [PATCH for-2.7 v3 03/36] qga: free the whole blacklist

Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> >> Copying the QGA maintainer. >> >> >> >> marcandre.lur...@redhat.com writes: >> >> >> >> > From: Marc-André Lureau >> >> > >> >> > Free the list

Re: [Qemu-devel] [PATCH for-2.7 v3 32/36] tests: add qtest_add_data_func_full

Marc-André Lureau writes: > Hi > > - Original Message - >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Allows one to specify a destroy function for the test data. >> > >> > Signed-off-by: Marc-André Lureau >> > --- >> > tests/libqtest.c | 15 +

[Qemu-devel] [PATCH] macio: set res_count value to 0 after non-block ATAPI DMA transfers

res_count should be set to the number of outstanding bytes after a DBDMA request. Unfortunately this wasn't being set to zero by the non-block transfer codepath meaning drivers that checked the descriptor result for such requests (e.g reading the CDROM TOC) would assume from a non-zero result that

Re: [Qemu-devel] [PATCH v6 4/4] docs: Add Documentation for Mediated devices

On 8/4/2016 1:01 PM, Tian, Kevin wrote: >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] >> Sent: Thursday, August 04, 2016 3:04 AM >> >> + >> +* mdev_supported_types: (read only) >> +List the current supported mediated device types and its details. >> + >> +* mdev_create: (write only) >

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote: 1;4402;0c> > > On 04/08/2016 04:38, David Gibson wrote: > > On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: > >> If we don't provide the page size in target-ppc:cpu_get_dump_info(), > >> the default one (TARGET_PAGE_S

Re: [Qemu-devel] [RFC PATCH V10 6/7] colo-compare: introduce packet comparison thread

On 08/02/2016 03:52 PM, Jason Wang wrote: On 2016年07月26日 09:49, Zhang Chen wrote: If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes and secondary packet not, s/and/bu

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

On 05/08/2016 09:49, David Gibson wrote: > On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote: > 1;4402;0c> >> >> On 04/08/2016 04:38, David Gibson wrote: >>> On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: If we don't provide the page size in target-ppc:cpu_get_

Re: [Qemu-devel] [Help]: Does qemu-system-aarch64 support virtio-9p? I got a problem when remap host file to guest in AArch64.

On 5 August 2016 at 03:23, Kevin Zhao wrote: > Hi All, > I have a problem may about Qemu and kindly need your help. Does > qemu-system-aarch64 support virtio-9p ? virtio-9p isn't guest architecture specific so in theory it should. However I've never tried it. > The Qemu version is QEMU

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

On 05.08.2016 09:49, David Gibson wrote: > On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote: > 1;4402;0c> >> >> On 04/08/2016 04:38, David Gibson wrote: >>> On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: If we don't provide the page size in target-ppc:cpu_get_du

[Qemu-devel] [PATCH for-2.7 v4 01/36] build-sys: fix building with make CFLAGS=.. argument

From: Marc-André Lureau When calling make with a CFLAGS=.. argument, the -g/-O filter is not applied, which may result with build failure with ASAN for example. It could be solved with an 'override' directive on CFLAGS, but that would actually prevent setting different CFLAGS manually. Instead,

[Qemu-devel] [PATCH for-2.7 v4 03/36] glib-compat: add g_(s)list_free_full()

From: Marc-André Lureau Those functions are only available since glib 2.28. Signed-off-by: Marc-André Lureau --- include/glib-compat.h | 24 1 file changed, 24 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index 01aa7b3..ff7eae5 100644 --- a

[Qemu-devel] [PATCH for-2.7 v4 00/36] Various memory leak fixes

From: Marc-André Lureau Hi, Thanks to AddressSanitizer (ASAN), I found a number of direct leaks worth fixing. Note that there are probably many indirect leaks left (I am adding some here), I haven't investigated much yet. There are still a number of direct leaks remaining, in particular in the

[Qemu-devel] [PATCH for-2.7 v4 02/36] tests: fix test-qga leaks

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-qga.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-qga.c b/tests/test-qga.c index dac8fb8..21f44f8 100644 --- a/tests/test-qga.c +++ b/tests/test-qga.c @@ -398,6 +398,7 @@ sta

[Qemu-devel] [PATCH for-2.7 v4 04/36] qga: free the whole blacklist

From: Marc-André Lureau Free the config blacklist list, not just the elements. Do it so in the more appropriate function config_free(). Signed-off-by: Marc-André Lureau --- qga/main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/qga/main.c b/qga/main.c index 4c3b2c

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

Sascha Silbe writes: > Dear Eric, > > Eric Blake writes: > >>> +++ b/include/qapi/error.h >>> @@ -170,6 +170,9 @@ void error_setg_internal(Error **errp, >>> * Just like error_setg(), with @os_error info added to the message. >>> * If @os_error is non-zero, ": " + strerror(os_error) is append

[Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qga/guest-agent-command-state.c | 6 ++ qga/guest-agent-core.h | 1 + qga/main.c | 6 ++ 3 files changed, 13 insertions(+) diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-s

[Qemu-devel] [PATCH for-2.7 v4 06/36] tests: fix test-cutils leaks

From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-cutils.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/tests/test-cutils.c b/tests/test-cutils.c index 64e3e95..20b0f59 10064

[Qemu-devel] [PATCH for-2.7 v4 07/36] tests: fix test-vmstate leaks

From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-vmstate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 41fd841..d8da26f 100644 --- a/tests/t

[Qemu-devel] [PATCH for-2.7 v4 11/36] tests: fix small leak in test-io-channel-command

From: Marc-André Lureau srcfifo && dstfifo must be freed in error case, however unlink() may delete a file from a different context. Instead, use mkdtemp()/rmdir() for the temporary files. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-io-channel-command.c | 20 ++

[Qemu-devel] [PATCH for-2.7 v4 08/36] tests: fix test-iov leaks

From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-iov.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/test-iov.c b/tests/test-iov.c index 46ae25e..a22d71f 100644 --- a/tests/test-iov.c +++ b/tests/test-io

[Qemu-devel] [PATCH for-2.7 v4 18/36] acpi-build: fix array leak

From: Marc-André Lureau The free_ranges array is used as a temporary pointer array, the segment should still be freed, however, it shouldn't free the elements themself. Signed-off-by: Marc-André Lureau Tested-by: Marcel Apfelbaum Reviewed-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 4 ++-

[Qemu-devel] [PATCH for-2.7 v4 09/36] tests: fix check-qom-interface leaks

From: Marc-André Lureau Found thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/check-qom-interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/check-qom-interface.c b/tests/check-qom-interface.c index 719ddcf..f87c9aa 100644 --- a/tests/check-

[Qemu-devel] [PATCH for-2.7 v4 14/36] numa: do not leak NumaOptions

From: Marc-André Lureau In all cases, call qapi_free_NumaOptions(), by using a common ending block. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- numa.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/numa.c b/numa.c index 7286171..6289f46 10

[Qemu-devel] [PATCH for-2.7 v4 19/36] char: free the tcp connection data when closing

From: Marc-André Lureau Make sure the connection data got freed when closing the chardev, to avoid leaks. Introduce tcp_chr_free_connection() to clean all connection related data, and move some tcp_chr_close() clean-ups there. (while at it, set write_msgfds_num to 0 when clearing array in tcp_se

[Qemu-devel] [PATCH for-2.7 v4 10/36] tests: fix check-qom-proplist leaks

From: Marc-André Lureau Found thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/check-qom-proplist.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c index 42defe7..a16cefc 100644 ---

[Qemu-devel] [PATCH for-2.7 v4 13/36] portio: keep references on portio

From: Marc-André Lureau The isa_register_portio_list() function allocates ioports data/state. Let's keep the reference to this data on some owner. This isn't enough to fix leaks, but at least, ASAN stops complaining of direct leaks. Further cleanup would require calling portio_list_del/destroy()

[Qemu-devel] [PATCH for-2.7 v4 20/36] char: free MuxDriver when closing

From: Marc-André Lureau Similarly to other chr_close callbacks, free char type specific data. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- qemu-char.c | 8 1 file changed, 8 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index f20d385..539dd70 100644 --- a/qemu

[Qemu-devel] [PATCH for-2.7 v4 16/36] pc: don't leak a20_line

From: Marc-André Lureau The irqs array is no longer being used Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- hw/i386/pc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 6b138d6..fd4a050 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1608

[Qemu-devel] [PATCH for-2.7 v4 12/36] tests: fix leak in test-string-input-visitor

From: Marc-André Lureau Free the list returned by visit_type_intList(). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-string-input-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-visitor.c ind

[Qemu-devel] [PATCH for-2.7 v4 23/36] pc: keep gsi reference

From: Marc-André Lureau Further cleanup would need to call qemu_free_irq() at the appropriate time, but for now this silences ASAN about direct leaks. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- hw/i386/pc_piix.c| 17 - hw/i386/pc_q35.c | 13 +++

[Qemu-devel] [PATCH for-2.7 v4 21/36] tests: fix qom-test leaks

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/qom-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qom-test.c b/tests/qom-test.c index 23493a2..d48f890 100644 --- a/tests/qom-test.c +++ b/tests/qom-test.c @@ -115

[Qemu-devel] [PATCH for-2.7 v4 31/36] bus: simplify name handling

From: Marc-André Lureau Simplify a bit the code by using g_strdup_printf() and store it in a non-const value so casting is no longer needed, and ownership is clearer. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- hw/core/bus.c | 21 ++--- include/hw/qde

[Qemu-devel] [PATCH for-2.7 v4 15/36] pc: simplify passing qemu_irq

From: Marc-André Lureau qemu_irq is already a pointer, no need to have an extra pointer level. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- hw/i386/pc.c | 8 hw/input/pckbd.c | 4 ++-- include/hw/i386/pc.h | 2 +- 3 files changed, 7 insertions(+), 7 deleti

[Qemu-devel] [PATCH for-2.7 v4 27/36] virtio-input: free config list

From: Marc-André Lureau Clear the list when finalizing. The list is created during realize with virtio_input_idstr_config() and later by further calls to virtio_input_init_config() and virtio_input_add_config(). This leak can be reproduced with device-introspect-test -p /x86_64/device/introspect

[Qemu-devel] [PATCH for-2.7 v4 22/36] pc: free i8259

From: Marc-André Lureau Simiarly to 2ba154cf4eb8636cdd3aa90f392ca9e77206ca39 Signed-off-by: Marc-André Lureau Reviewed-by: Marcel Apfelbaum --- hw/i386/pc_q35.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index c0b9961..c5e8367 100644 --- a/hw/i38

[Qemu-devel] [PATCH for-2.7 v4 17/36] machine: use class base init generated name

From: Marc-André Lureau machine_class_base_init() member name is allocated by machine_class_base_init(), but not freed by machine_class_finalize(). Simply freeing there doesn't work, because DEFINE_PC_MACHINE() overwrites it with a literal string. Fix DEFINE_PC_MACHINE() not to overwrite it, an

[Qemu-devel] [PATCH for-2.7 v4 32/36] tests: add qtest_add_data_func_full

From: Marc-André Lureau Allows one to specify a destroy function for the test data. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 15 +++ tests/libqtest.h | 17 + 2 files changed, 32 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index eb0

[Qemu-devel] [PATCH for-2.7 v4 24/36] ahci: free irqs array

From: Marc-André Lureau Each irq is referenced by the IDEBus in ide_init2(), thus we can free the no longer used array. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow Acked-by: John Snow --- hw/ide/ahci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahc

[Qemu-devel] [PATCH for-2.7 v4 26/36] qjson: free str

From: Marc-André Lureau Release the qstring allocated in qjson_new(). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- migration/qjson.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/qjson.c b/migration/qjson.c index 5cae55a..f345904 100644 --- a/migration/qjson.c

[Qemu-devel] [PATCH for-2.7 v4 34/36] tests: fix rsp leak in postcopy-test

From: Marc-André Lureau In all cases, even when the dict doesn't contain 'ram', the qmp response must be unref. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/postcopy-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/postcopy-test.c b/tests/

[Qemu-devel] [PATCH for-2.7 v4 33/36] tests: pc-cpu-test leaks fixes

From: Marc-André Lureau The path is allocated and should be freed. The qmp response should be unref, but then 'machine' must be duplicated. Use a destroy function for the PCTestData. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/pc-cpu-test.c | 24 +++---

[Qemu-devel] [PATCH for-2.7 v4 25/36] sd: free timer

From: Marc-André Lureau Free the timer allocated in instance_init. Signed-off-by: Marc-André Lureau Reviewed-by: Andrew Baumann --- hw/sd/sd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 87c6dc1..8e88e83 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @

[Qemu-devel] [PATCH for-2.7 v4 35/36] ahci: fix sglist leak on retry

From: Marc-André Lureau ahci-test /x86_64/ahci/io/dma/lba28/retry triggers the following leak: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7fc4b2a25e20 in malloc (/lib64/libasan.so.3+0xc6e20) #1 0x7fc4993bce58 in g_malloc (/lib64/libglib-2.0.so.0+0x4ee58) #2 0x556a1

[Qemu-devel] [PATCH for-2.7 v4 28/36] ipmi: free extern timer

From: Marc-André Lureau Free the timer allocated during instance init. Signed-off-by: Marc-André Lureau Reviewed-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 157879e..5b

Re: [Qemu-devel] [PATCH for-2.7 v4 00/36] Various memory leak fixes

On Fri, Aug 05, 2016 at 12:23:45PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > Thanks to AddressSanitizer (ASAN), I found a number of direct leaks > worth fixing. Note that there are probably many indirect leaks left (I > am adding some here), I haven't invest

[Qemu-devel] [PATCH for-2.7 v4 29/36] usb: free USBDevice.strings

From: Marc-André Lureau The list is created during instance init and further populated with usb_desc_set_string(). Clear it when unrealizing the device. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- hw/usb/bus.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/u

Re: [Qemu-devel] [Help]: Does qemu-system-aarch64 support virtio-9p? I got a problem when remap host file to guest in AArch64.

On Fri, Aug 05, 2016 at 10:23:58AM +0800, Kevin Zhao wrote: > Hi All, > I have a problem may about Qemu and kindly need your help. Does > qemu-system-aarch64 support virtio-9p ? > Recently I have tried to use qemu remapped the file from host to > guest. As I know, Qemu has supported this

Re: [Qemu-devel] [PATCH v2] net: check fragment length during fragmentation

On 2016年08月04日 18:57, Dmitry Fleytman wrote: Reviewed-by: Dmitry Fleytman > On Thu, Aug 4, 2016 at 12:30 AM, P J P > wrote: From: Prasad J Pandit mailto:p...@fedoraproject.org>> Network transport abstraction layer supports packet

[Qemu-devel] [PATCH for-2.7 v4 30/36] usb: free leaking path

From: Marc-André Lureau qdev_get_dev_path() returns an allocated string, free it when no longer needed. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- hw/usb/desc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/desc.c b/hw/usb/desc.c index adb026e..5e0e1d1 100644

Re: [Qemu-devel] [PATCH] virtio-net: allow increasing rx queue size

On Thu, 4 Aug 2016 22:52:29 +0300 "Michael S. Tsirkin" wrote: > On Thu, Aug 04, 2016 at 09:35:15AM +0200, Cornelia Huck wrote: > > On Thu, 4 Aug 2016 02:16:14 +0300 > > "Michael S. Tsirkin" wrote: > > > > > This allows increasing the rx queue size up to 1024: unlike with tx, > > > guests don't

[Qemu-devel] [Bug 1586756] Re: "-serial unix:" option of qemu-system-arm is broken in qemu 2.6.0

Fix posted https://lists.gnu.org/archive/html/qemu- devel/2016-08/msg00684.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1586756 Title: "-serial unix:" option of qemu-system-arm is broken in q

[Qemu-devel] [PATCH for-2.7 v4 36/36] tests: fix postcopy-test leaks

From: Marc-André Lureau A few strings are allocated and never freed. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/postcopy-test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c index bf4e579..41ed1a9

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

On Thu, 08/04 16:48, Daniel P. Berrange wrote: > On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > > A number of different places across the code base use CONFIG_UUID. Some > > of them are soft dependency, some are not built if libuuid is not > > available, some come with dummy fallback,

[Qemu-devel] [PULL 0/2] Docker patches

The following changes since commit 42e0d60f1615ef63d16e41bb1668805560c37870: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160804' into staging (2016-08-04 18:36:05 +0100) are available in the git repository at: g...@github.com:famz/qemu tags/docker-pull-request for you

Re: [Qemu-devel] [PATCH 3/7] vdi: Use QEMU UUID API

On Fri, 08/05 08:31, Markus Armbruster wrote: > Eric Blake writes: > > > On 08/04/2016 12:58 PM, Stefan Weil wrote: > >> Hi, > >> > >> On 08/02/16 11:18, Fam Zheng wrote: > >>> The QEMU UUID api, including the data structure (qemu_uuid_t), is fully > >>> compatible with libuuid. Use it, and rem

Re: [Qemu-devel] [RFC PATCH V10 7/7] colo-compare: add TCP, UDP, ICMP packet comparison

On 08/02/2016 04:04 PM, Jason Wang wrote: On 2016年07月26日 09:49, Zhang Chen wrote: We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. less checkpoint more efficiency. s/less/Less/ OK. Signed-off-by: Zhang C

[Qemu-devel] [PULL 1/2] docker: Be compatible with older docker

By not using "--format" with docker images command. The option is not available on RHEL 7 docker command. Use an awk matching command instead. Reported-by: Paolo Bonzini Signed-off-by: Fam Zheng Message-Id: <1470202928-3392-1-git-send-email-f...@redhat.com> --- tests/docker/Makefile.include |

Re: [Qemu-devel] fix incorrect identify implementation in nvme

Am 05.08.2016 um 08:48 hat Markus Armbruster geschrieben: > Keith Busch writes: > > > On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote: > >> Third resent of this series after this didn't get picked up the > >> previous times. The Qemu NVMe implementation mistakes the cns > >> fi

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

Uploaded. ** Changed in: qemu (Ubuntu Xenial) Status: Triaged => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds

[Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform

From: Benjamin Herrenschmidt The goal is to emulate a PowerNV system at the level of the skiboot firmware, which loads the OS and provides some runtime services. Power Systems have a lower firmware (HostBoot) that does low level system initialization, like DRAM training. This is beyond the scope

[Qemu-devel] [PULL for-2.7 1/5] block/parallels: check new image size

From: Klim Kireev Before this patch incorrect image could be created via qemu-img (Example: qemu-img create -f parallels -o size=4096T hack.img), incorrect images cannot be used due to overflow in main image structure. This patch add check of size in image creation. After reading size it compar

[Qemu-devel] [PULL 2/2] docker: Add "--enable-werror" to configure command line

We don't have .git in the docker checkout, add this to enable -Werror explicitly. Signed-off-by: Fam Zheng Message-id: 1469453510-658-1-git-send-email-f...@redhat.com --- tests/docker/common.rc | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/common.rc b/tests/docker/common.rc in

[Qemu-devel] [PATCH 0/3] ppc/pnc: add a minimal platform

In this version, the initial patch sent by Ben was trimmed down to its minimal : a platform with some RAM to load initial ROMs and a device tree built from the machine reset op. A PnvChip object comes next to act as a container for all the 'chiplets' required to run a system. First of these are th

[Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object

This is is an abstraction of a P8 chip which is a set of cores plus other 'units', like the pervasive unit, the interrupt controller, the memory controller, the on-chip microcontroller, etc. The whole can be seen as a socket. We start with an empty PnvChip which we will grow in the subsequent patc

Re: [Qemu-devel] [PULL 0/5] linux-user fixes for 2.7

On 4 August 2016 at 15:15, wrote: > From: Riku Voipio > > The following changes since commit 09704e6ded83fa0bec14baf32f800f6512156ca0: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-08-04 10:24:27 +0100) > > are available in the git repository at: >

[Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object

This is largy inspired by sPAPRCPUCore with some simplification, no hotplug for instance. But the differences are small and the objects could possibly be merged. A set of PowerNVCPUCore objects is added to the PnvChip and the device tree is populated looping on these cores. Core ids in the device

[Qemu-devel] [Question] virtio-serial misses irq delivery on migration?

Hi Paolo , Jan, Amit Recently we encountered a problem that the virtio-serial can't work after Migration in RH5.5 VM. The bigger problem is, I can't reproduce it. :( It's phenomenon was much like BZ 867366, the usb-table mouse didn't work because the uhci and virtio-serial shard the irq line (usi

[Qemu-devel] [PULL 0/3] Block layer patches for 2.7.0-rc2

The following changes since commit 42e0d60f1615ef63d16e41bb1668805560c37870: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160804' into staging (2016-08-04 18:36:05 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[Qemu-devel] [PULL for-2.7 0/5] Block patches

The following changes since commit 42e0d60f1615ef63d16e41bb1668805560c37870: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160804' into staging (2016-08-04 18:36:05 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request

[Qemu-devel] [PULL 3/3] nvme: bump PCI revision

From: Christoph Hellwig The broken Identify implementation in earlier Qemu versions means we need to blacklist it from issueing the NVMe 1.1 Identify Namespace List command. As we want to be able to use it in newer Qemu versions we need a way to identify those. Bump the PCI revision as a guest

[Qemu-devel] [PULL for-2.7 2/5] throttle: Don't allow burst limits to be lower than the normal limits

From: Alberto Garcia Setting FOO_max to a value that is lower than FOO does not make sense, and it produces odd results depending on the value of FOO_max_length. Although the user should not set that configuration in the first place it's better to reject it explicitly. https://bugzilla.redhat.co

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote: > > > On 04/08/2016 04:38, David Gibson wrote: > > On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: > >> If we don't provide the page size in target-ppc:cpu_get_dump_info(), > >> the default one (TARGET_PAGE_SIZE, 4KB)

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: > If we don't provide the page size in target-ppc:cpu_get_dump_info(), > the default one (TARGET_PAGE_SIZE, 4KB) is used to create > the compressed dump. It works fine with Macintosh, but not with > pseries as the kernel default page s

[Qemu-devel] [PULL for-2.7 3/5] throttle: Test burst limits lower than the normal limits

From: Alberto Garcia This checks that making FOO_max lower than FOO is not allowed. We could also forbid having FOO_max == FOO, but that doesn't have any odd side effects and it would require us to update several other tests, so let's keep it simple. Signed-off-by: Alberto Garcia Reviewed-by:

[Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

GCC compiles linuxboot_dma.c to 921 bytes, while clang needs 1527. This causes the API to break between a GCC-compiled ROM and one that was obtained with clang. First, this patch fixes this by preventing clang's happy inlining (which -Os cannot prevent). This only requires adding a noinline attri

[Qemu-devel] [PULL for-2.7 5/5] virtio-blk: Remove stale comment about draining

From: Fam Zheng This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to drain IO requests), remove it. Suggested-by: Laszlo Ersek Signed-off-by: Fam Zheng Reviewed-by: Laszlo Ersek Message-id: 1470278654-13525-3-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi --- h

[Qemu-devel] [PATCH for-2.8 02/18] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled

Workaround for long standing issue where Linux kernel assigns hotplugged CPU to 1st numa node as it discards proximity for possible CPUs from SRAT after it's parsed. _PXM method allows linux query proximity directly from hotplugged CPU object, which allows Linux to assing CPU to the correct numa n

[Qemu-devel] [PULL 1/3] block: Accept any target node for transactional blockdev-backup

Commit 0d978913 changed blockdev-backup to accept arbitrary node names instead of device names (i.e. root nodes) for the backup target. However, it forgot to make the same change in transactions and to update the documentation. This patch fixes these omissions. Signed-off-by: Kevin Wolf Reviewed-

[Qemu-devel] [PATCH for-2.8 01/18] numa: reduce code duplication by adding helper numa_get_node_for_cpu()

Replace repeated pattern for (i = 0; i < nb_numa_nodes; i++) { if (test_bit(idx, numa_info[i].node_cpu)) { ... break; with a helper function to lookup numa node index for cpu. Suggested-by: Michael S. Tsirkin Signed-off-by: Igor Mammedov Reviewed-by: David Gib

[Qemu-devel] [PULL for-2.7 4/5] virtio-blk: Release s->rq queue at system_reset

From: Fam Zheng At system_reset, there is no point in retrying the queued request, because the driver that issued the request won't be around any more. Analyzed-by: Laszlo Ersek Reported-by: Laszlo Ersek Signed-off-by: Fam Zheng Reviewed-by: Laszlo Ersek Message-id: 1470278654-13525-2-git-se

[Qemu-devel] [PATCH for-2.8 04/18] linux-headers: update to v4.8-rc1

From: root Signed-off-by: Radim Krčmář --- linux-headers/linux/kvm.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index e60e21b..aa7f587 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kv

[Qemu-devel] [PULL 2/3] nvme: fix identify to be NVMe 1.1 compliant

From: Christoph Hellwig NVMe 1.1 requires devices to implement a Namespace List subcommand of the identify command. Qemu not only not implements this features, but also misinterprets it as an Identify Controller request. Due to this any OS trying to use the Namespace List will fail the probe.

[Qemu-devel] [PATCH for-2.8 03/18] tests: acpi: extend cphp testcase with numa check

so it would be possible to verify _PXM generation in DSDT and SRAT tables. Signed-off-by: Igor Mammedov Reviewed-by: Marcel Apfelbaum --- NOTE to maintainer: SRAT table is included in patch as it doesn't have any chance for conflicts compared to often changing DSDT following table blobs should

[Qemu-devel] [PATCH for-2.8 00/18] pc: q35: x2APIC support in kvm_apic mode

Changes since RFC: - use new KVM_CAP_X2APIC_API to detect x2APIC IDs support - rebase on top of 2.7-rc1, since many deps were merged - fix etc/boot-cpus to account for -device provided cpus - include not yet merged _PXM fix as prereq - add 2.8 machine type and bump up maxcpus count since

[Qemu-devel] [PATCH for-2.8 07/18] acpi: cphp: support x2APIC entry in cpu._MAT

Signed-off-by: Igor Mammedov --- hw/acpi/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c index 902f5c9..5ac89fe 100644 --- a/hw/acpi/cpu.c +++ b/hw/acpi/cpu.c @@ -531,6 +531,11 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatur

[Qemu-devel] [PATCH for-2.8 09/18] pc: leave max apic_id_limit only in legacy cpu hotplug code

that's enough to make old code that depends on it to prevent QEMU starting with more than 255 CPUs. Signed-off-by: Igor Mammedov --- hw/acpi/cpu_hotplug.c | 7 ++- hw/i386/pc.c | 7 --- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/acpi/cpu_hotplug.c b/hw/acp

Re: [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object

On Fri, 2016-08-05 at 11:15 +0200, Cédric Le Goater wrote: > This is is an abstraction of a P8 chip which is a set of cores plus > other 'units', like the pervasive unit, the interrupt controller, the > memory controller, the on-chip microcontroller, etc. The whole can be > seen as a socket. > > W

[Qemu-devel] [PATCH for-2.8 05/18] pc: acpi: x2APIC support for MADT table

Signed-off-by: Igor Mammedov --- include/hw/acpi/acpi-defs.h | 18 +++ hw/i386/acpi-build.c| 78 +++-- 2 files changed, 72 insertions(+), 24 deletions(-) diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h index 41c1d95..

[Qemu-devel] [PATCH for-2.8 08/18] acpi: cphp: force switch to modern cpu hotplug if APIC ID > 254

Switch to modern cpu hotplug at machine startup time if a cpu present at boot has apic-id in range unsupported by legacy cpu hotplug interface (i.e. > 254), to avoid killing QEMU from legacy cpu hotplug code with error: "acpi: invalid cpu id: #apic-id#" Signed-off-by: Igor Mammedov --- hw/acp

[Qemu-devel] [PATCH for-2.8 11/18] pc: apic_common: restore APIC ID to initial ID on reset

APIC ID should be restored to initial APIC ID state after Reset and Power-On. Signed-off-by: Igor Mammedov --- hw/intc/apic_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 125af9d..e246cf3 100644 --- a/hw/intc/apic_common.c +++ b/h

[Qemu-devel] hw/ppc/spapr_iommu.c: spapr_tce_reset() calls memset on NULL pointer

If you build with clang-3.8's undefined behaviour sanitizer it reveals that hw/ppc/spapr_iommu.c is calling memset() with a NULL pointer: $ (cd build/clang; UBSAN_OPTIONS=print_stacktrace=1 QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 QTEST_QEMU_IMG=qemu-img MALLOC_PERTURB_=${MALLOC_PERTURB_:

[Qemu-devel] [PATCH for-2.8 10/18] pc: apic_common: extend APIC ID property to 32bit

ACPI ID is 32 bit wide on CPUs with x2APIC support. Extend 'id' property to support it. Signed-off-by: Igor Mammedov --- include/hw/i386/apic_internal.h | 3 ++- target-i386/cpu.h | 1 + hw/intc/apic_common.c | 40 +++- target-i386/cp

Re: [Qemu-devel] [PATCH] ppc64: fix compressed dump with pseries kernel

On 05/08/2016 11:26, Andrew Jones wrote: > On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote: >> >> >> On 04/08/2016 04:38, David Gibson wrote: >>> On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote: If we don't provide the page size in target-ppc:cpu_get_dump_info()

[Qemu-devel] [PATCH for-2.8 06/18] pc: acpi: x2APIC support for SRAT table

Signed-off-by: Igor Mammedov --- rebase on top in 2.7 + updated cpu PXM patches --- include/hw/acpi/acpi-defs.h | 11 +++ hw/i386/acpi-build.c| 34 -- 2 files changed, 35 insertions(+), 10 deletions(-) diff --git a/include/hw/acpi/acpi-defs.h b/inc

[Qemu-devel] [PATCH for-2.8 15/18] increase MAX_CPUMASK_BITS from 255 to 288

so that it would be possible to increase maxcpus limit for x86 target. Keep spapr/virt_arm at limit they used to have 255. Signed-off-by: Igor Mammedov --- include/sysemu/sysemu.h | 2 +- hw/arm/virt.c | 2 +- hw/ppc/spapr.c | 2 +- 3 files changed, 3 insertions(+), 3 deletion

[Qemu-devel] [PATCH for-2.8 13/18] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode

Signed-off-by: Igor Mammedov --- target-i386/kvm_i386.h | 1 + hw/i386/kvm/apic.c | 13 +++-- target-i386/kvm.c | 14 ++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm_i386.h b/target-i386/kvm_i386.h index 42b00af..dad0dcf 100644 ---

[Qemu-devel] [PATCH for-2.8 16/18] pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs

Currently firmware uses 1 byte at 0x5F offset in RTC CMOS to get number of CPUs present at boot. However 1 byte is not enough to handle more than 255 CPUs. So add a new fw_cfg file that would allow QEMU to tell it. For compat reasons add file only for machine types that support more than 255 CPUs.

[Qemu-devel] [PATCH for-2.8 12/18] pc: apic_common: reset APIC ID to initial ID when switching into x2APIC mode

SDM: x2APIC State Transitions: State Changes From xAPIC Mode to x2APIC Mode " Any APIC ID value written to the memory-mapped local APIC ID register is not preserved " Signed-off-by: Igor Mammedov --- hw/intc/apic_common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/intc/

Re: [Qemu-devel] [PATCH for 2.7] linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation

On Fri, Aug 05, 2016 at 11:34:57AM +0200, Paolo Bonzini wrote: > GCC compiles linuxboot_dma.c to 921 bytes, while clang needs 1527. > This causes the API to break between a GCC-compiled ROM and > one that was obtained with clang. I don't understand this justification. Which API? Between which bi

  1   2   3   >