[Qemu-devel] [PATCH v2 6/9] hw/misc: use macros to define hw-strap1 register on Aspeed SOC

2016-07-28 Thread Cédric Le Goater
This gives some explanation behind the magic number 0x120CE416. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 2 +- include/hw/misc/aspeed_scu.h | 109 +++ 2 files changed, 110 insertions(+), 1 deletion(-) diff --git a/hw/arm/aspeed

[Qemu-devel] [PATCH v2 05/37] tests: fix test-cutils leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-cutils.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/tests/test-cutils.c b/tests/test-cutils.c index 64e3e95..20b0f59 10064

[Qemu-devel] [PATCH v2 00/37] Various memory leak fixes

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Hi, Thanks to AddressSanitizer (ASAN), I found a number of direct leaks worth fixing. Note that there are probably many indirect leaks left (I am adding some here), I haven't investigated much yet. There are still a number of direct leaks remaining, in particular in the

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-28 Thread Steven Rostedt
On Thu, 28 Jul 2016 14:39:53 +0900 Namhyung Kim wrote: > Well, I dont' know. As you know, the kernel oops dump is already sent > to serial device but it's rather slow. As I wrote in the cover > letter, enabling ftrace_dump_on_oops makes it even worse.. Also > pstore saves the (compressed) bina

[Qemu-devel] [PATCH v2 9/9] palmetto-bmc: remove extra no_sdcard assignement

2016-07-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c8812cc358bb..e658611df37a 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -123,7 +123,6 @@ static void palmetto_bmc_class_init(ObjectClass *oc, voi

[Qemu-devel] [PATCH v2 07/37] tests: fix test-iov leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-iov.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/test-iov.c b/tests/test-iov.c index 46ae25e..a22d71f 100644 --- a/tests/test-iov.c +++ b/tests/test-io

[Qemu-devel] [PATCH v2 06/37] tests: fix test-vmstate leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-vmstate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 41fd841..d8da26f 100644 --- a/tests/t

[Qemu-devel] [PATCH v2 04/37] qga: free remaining leaking state

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qga/guest-agent-command-state.c | 7 +++ qga/guest-agent-core.h | 1 + qga/main.c | 6 ++ 3 files changed, 14 insertions(+) diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-

[Qemu-devel] [PATCH v2 09/37] tests: fix check-qom-interface leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Found thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/check-qom-interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/check-qom-interface.c b/tests/check-qom-interface.c index 719ddcf..f87c9aa 100644 --- a/tests/check-

[Qemu-devel] [PATCH v2 13/37] portio: keep references on portio

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau The isa_register_portio_list() function allocates ioports data/state. Let's keep the reference to this data on some owner. This isn't enough to fix leaks, but at least, ASAN stops complaining of direct leaks. Further cleanup would require calling portio_list_del/destroy()

[Qemu-devel] [PATCH v2 08/37] qdist: fix entries memory leak

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau qdist_init() allocates entries, make sure we don't leak it. Spotted thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- util/qdist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/qdist.c b/util/qdist.c index 56f573

[Qemu-devel] [PATCH v2 10/37] tests: fix check-qom-proplist leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Found thanks to ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/check-qom-proplist.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c index 42defe7..a16cefc 100644 ---

[Qemu-devel] [PATCH v2 02/37] tests: fix test-qga leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-qga.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-qga.c b/tests/test-qga.c index dac8fb8..21f44f8 100644 --- a/tests/test-qga.c +++ b/tests/test-qga.c @@ -398,6 +398,7 @@ sta

[Qemu-devel] [PATCH v2 11/37] tests: fix small leak in test-io-channel-command

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau srcfifo && dstfifo must be freed in error case, however unlink() may delete a file from a different context. Instead, use mkdtemp()/rmdir() for the temporary files. Signed-off-by: Marc-André Lureau --- tests/test-io-channel-command.c | 20 +--- 1 file ch

[Qemu-devel] [PATCH v2 15/37] pc: simplify passing qemu_irq

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau qemu_irq is already a pointer, no need to have an extra pointer level. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- hw/i386/pc.c | 8 hw/input/pckbd.c | 4 ++-- include/hw/i386/pc.h | 2 +- 3 files changed, 7 insertions(+), 7 deleti

[Qemu-devel] [PATCH v2 25/37] sd: free timer

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Free the timer allocated in instance_init. Signed-off-by: Marc-André Lureau Reviewed-by: Andrew Baumann --- hw/sd/sd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 87c6dc1..8e88e83 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @

[Qemu-devel] [PATCH v2 12/37] tests: fix leak in test-string-input-visitor

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Free the list returned by visit_type_intList(). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-string-input-visitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-visitor.c ind

[Qemu-devel] [PATCH v2 14/37] numa: do not leak NumaOptions

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau In all cases, call qapi_free_NumaOptions(), by using a common ending block. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- numa.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/numa.c b/numa.c index cbae430..3be3b26 10

[Qemu-devel] [PATCH v2 16/37] pc: don't leak a20_line

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau The irqs array is no longer being used Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- hw/i386/pc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 6b138d6..fd4a050 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1608

[Qemu-devel] [PATCH v2 27/37] virtio-input: free config list

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Clear the list when finalizing. The list is created during realize with virtio_input_idstr_config() and later by further calls to virtio_input_init_config() and virtio_input_add_config(). This leak can be reproduced with device-introspect-test -p /x86_64/device/introspect

[Qemu-devel] [PATCH v2 20/37] char: free MuxDriver when closing

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Similarly to other chr_close callbacks, free char type specific data. Signed-off-by: Marc-André Lureau --- qemu-char.c | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index 6ed6dd6..e276485 100644 --- a/qemu-char.c +++ b/qemu-char.

[Qemu-devel] [PATCH v2 34/37] tests: pc-cpu-test leaks fixes

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau The path is allocated and should be freed. The qmp response should be unref, but then 'machine' must be duplicated. Use a destroy function for the PCTestData. Signed-off-by: Marc-André Lureau --- tests/pc-cpu-test.c | 24 +++- 1 file changed, 19 in

[Qemu-devel] [PATCH v2 18/37] acpi-build: fix array leak

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau The free_ranges array is used as a temporary pointer array, the segment should still be freed, however, it shouldn't free the elements themself. Signed-off-by: Marc-André Lureau Tested-by: Marcel Apfelbaum Reviewed-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 4 ++-

[Qemu-devel] [PATCH v2 17/37] machine: use class base init generated name

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Remove machine class name initialization from DEFINE_PC_MACHINE, rely on class base init name generation instead. Get rid of some leaks that way. Signed-off-by: Marc-André Lureau --- hw/core/machine.c| 1 + include/hw/boards.h | 2 +- include/hw/i386/pc.h | 1 - 3

[Qemu-devel] [PATCH v2 33/37] tests: add qtest_add_data_func_full

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Allows to specify a destroy function for the test data. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 15 ++- tests/libqtest.h | 7 ++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index e

[Qemu-devel] [PATCH v2 37/37] tests: fix postcopy-test leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau A few strings are allocated and never freed. Signed-off-by: Marc-André Lureau --- tests/postcopy-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c index f6f6598..9b32c5e 100644 --- a/tests/postcop

[Qemu-devel] [PATCH v2 22/37] pc: free i8259

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Simiarly to 2ba154cf4eb8636cdd3aa90f392ca9e77206ca39 Signed-off-by: Marc-André Lureau Reviewed-by: Marcel Apfelbaum --- hw/i386/pc_q35.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index c0b9961..c5e8367 100644 --- a/hw/i38

[Qemu-devel] [PATCH v2 23/37] pc: keep gsi reference

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Further cleanup would need to call qemu_free_irq() at the appropriate time, but for now this silences ASAN about direct leaks. Signed-off-by: Marc-André Lureau --- hw/i386/pc_piix.c| 17 - hw/i386/pc_q35.c | 13 ++--- include/hw/i386/pc.h

[Qemu-devel] [PATCH v2 26/37] qjson: free str

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Release the qstring allocated in qjson_new(). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- migration/qjson.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/qjson.c b/migration/qjson.c index 5cae55a..f345904 100644 --- a/migration/qjson.c

[Qemu-devel] [PATCH v2 19/37] char: disconnect peer when qemu_chr_free()

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau chr_disconnect callback is used to cleanup server socket peer. This removes some leaks when the chardev is freed. Signed-off-by: Marc-André Lureau --- qemu-char.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-char.c b/qemu-char.c index e4b8448..6ed6dd6 100644

[Qemu-devel] [PATCH v2 24/37] ahci: free irqs array

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Each irq is referenced by the IDEBus in ide_init2(), thus we can free the no longer used array. Signed-off-by: Marc-André Lureau Reviewed-by: John Snow Acked-by: John Snow --- hw/ide/ahci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahc

[Qemu-devel] [PATCH v2 21/37] tests: fix qom-test leaks

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/qom-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qom-test.c b/tests/qom-test.c index 23493a2..d48f890 100644 --- a/tests/qom-test.c +++ b/tests/qom-test.c @@ -115

[Qemu-devel] [PATCH v2 30/37] tests: free a bunch of qmp responses

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/libqos/usb.c | 1 + tests/postcopy-test.c | 3 ++- tests/pvpanic-test.c | 1 + tests/test-filter-mirror.c | 4 +++- tests/test-filter-redirector.c | 8 ++-- te

[Qemu-devel] [PATCH v2 36/37] ahci: fix sglist leak on retry

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau ahci-test /x86_64/ahci/io/dma/lba28/retry triggers the following leak: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7fc4b2a25e20 in malloc (/lib64/libasan.so.3+0xc6e20) #1 0x7fc4993bce58 in g_malloc (/lib64/libglib-2.0.so.0+0x4ee58) #2 0x556a1

Re: [Qemu-devel] ui/cocoa.m: Make a better about dialog

2016-07-28 Thread Peter Maydell
On 28 July 2016 at 15:42, Programmingkid wrote: > From 0c803fd07ddf05904d283628f8277b14fb8cbf35 Mon Sep 17 00:00:00 2001 > From: John Arbuckle > Date: Thu, 28 Jul 2016 10:34:33 -0400 > Subject: [PATCH] Make a better about dialog > > The about dialog in QEMU on Mac OS X is very plain and unhelpful

[Qemu-devel] [PATCH v2 29/37] usb: free USBDevice.strings

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau The list is created during instance init and further populated with usb_desc_set_string(). Clear it when unrealizing the device. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- hw/usb/bus.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/u

[Qemu-devel] [Bug 1470720] Re: high IRQ-TLB generates network interruptions

2016-07-28 Thread Robert van Leeuwen
Seeing the same here, also happens on overbooked hypervisors. Just one or two hosts have this behaviour. We are using: qemu-kvm 2.0.0+dfsg-2ubuntu1.25 libvirt-bin 1.2.9 kernel 3.13.0-92-generic We are using contrail as a SDN. It looks like i

[Qemu-devel] ui/cocoa.m: Make a better about dialog

2016-07-28 Thread Programmingkid
From 0c803fd07ddf05904d283628f8277b14fb8cbf35 Mon Sep 17 00:00:00 2001 From: John Arbuckle Date: Thu, 28 Jul 2016 10:34:33 -0400 Subject: [PATCH] Make a better about dialog The about dialog in QEMU on Mac OS X is very plain and unhelpful. This patch makes the about dialog look a lot better and ha

Re: [Qemu-devel] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits

2016-07-28 Thread Eric Blake
On 07/28/2016 02:08 AM, Alberto Garcia wrote: > Hello, > > Gu Nini found this problem and reported it in > > https://bugzilla.redhat.com/show_bug.cgi?id=1355665 > > When setting the throttling configuration, the burst limits can be > lower than the normal limits. This does not making any sense a

[Qemu-devel] [PATCH v2 28/37] ipmi: free extern timer

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Free the timer allocated during instance init. Signed-off-by: Marc-André Lureau Reviewed-by: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 157879e..5b

[Qemu-devel] [PATCH v2 31/37] usb: free leaking path

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau qdev_get_dev_path() returns an allocated string, free it when no longer needed. Signed-off-by: Marc-André Lureau Reviewed-by: Gerd Hoffmann --- hw/usb/desc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/desc.c b/hw/usb/desc.c index adb026e..5e0e1d1 100644

[Qemu-devel] [PATCH v2 32/37] bus: simplify name handling

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Simplify a bit the code by using g_strdup_printf() and store it in a non-const value so casting is no longer needed, and ownership is clearer. Signed-off-by: Marc-André Lureau --- hw/core/bus.c | 21 ++--- include/hw/qdev-core.h | 2 +- 2 files

Re: [Qemu-devel] [Qemu-trivial] [PATCH] timer/cpus: fix some typos and update some comments

2016-07-28 Thread Michael Tokarev
Applied to -trivial, with the following change: > /* enable cpu_get_ticks() > - * Caller must hold BQL which server as mutex for vm_clock_seqlock. > + * Caller must hold BQL which serve as mutex for vm_clock_seqlock. ..which serveS as a mutex... here and in one more place. /mjt

[Qemu-devel] QEMU-guestOS latencies.

2016-07-28 Thread Nir Levy
Hi all, First, thanks for your time and attention for reading this. I wish to share with you some of my goals. My main goal is to trace latencies qemu-kvm interface (in order to see if they secondary goal is to figure out the way qemu thread are spawned. in addition I wish to understand ram alloc

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

2016-07-28 Thread Eric Blake
On 07/28/2016 04:46 AM, Halil Pasic wrote: > The implementation of preserve errno seems inconsistent to me. The > function error_setv is static, and I guess it is supposed to provide > this indirect errno preservation and is used for both error_setg und > error_setg_errno, yet error_setg_ errno_i

[Qemu-devel] [PATCH v2 35/37] tests: fix rsp leak in postcopy-test

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau In all cases, even when the dict doesn't contain 'ram', the qmp response must be unref. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/postcopy-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/postcopy-test.c b/tests/

Re: [Qemu-devel] [PATCH] target-m68k: fix get_mac_extf helper

2016-07-28 Thread Michael Tokarev
15.07.2016 18:29, Paolo Bonzini wrote: > val is assigned twice; the second one should be combined with "|". > Reported by Coverity. Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH v2] ui/cocoa.m: Make a better about dialog

2016-07-28 Thread Programmingkid
The about dialog in QEMU on Mac OS X is very plain and unhelpful. This patch makes the about dialog look a lot better and have some descriptive information on what version of QEMU the user is running. Signed-off-by: John Arbuckle --- version 2 changes: Added QEMU version to the version label ui

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: Make a better about dialog

2016-07-28 Thread Peter Maydell
On 28 July 2016 at 16:01, Programmingkid wrote: > The about dialog in QEMU on Mac OS X is very plain and unhelpful. This patch > makes the about dialog look a lot better and have some descriptive information > on what version of QEMU the user is running. > > Signed-off-by: John Arbuckle > --- > v

[Qemu-devel] [PATCH] tests: add drive_del-test to ppc/ppc64

2016-07-28 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- tests/Makefile.include | 2 ++ tests/drive_del-test.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 4b5123b..ebecfa4 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@

Re: [Qemu-devel] [PATCH] timer.h: fix typo

2016-07-28 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH 6/6] linux-user: Implement force_sigsegv() via force_sig()

2016-07-28 Thread Peter Maydell
Now that we have a force_sig() with the semantics we need, we can implement force_sigsegv() to call it rather than open-coding the call to queue_signal(). Signed-off-by: Peter Maydell --- linux-user/signal.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/l

Re: [Qemu-devel] [PATCH] maint: Ignore generated version file

2016-07-28 Thread Michael Tokarev
08.06.2016 23:26, Eric Blake wrote: > Commit 67a1de0d created a generated version file, and, in some > circumstances, also a temporary file. Make sure 'git add .' > won't check them into the repository. Applied to -trivial, thanks! /mjt

[Qemu-devel] [Bug 1392468] Re: qemu uses a bitmap icon

2016-07-28 Thread Francesco Turco
I also see an ugly icon when running QEMU as a user in GNOME. I tried running QEMU as root to see if there is any difference, but it doesn't work at all. I think QEMU should use pc-bios/qemu_logo_no_text.svg instead of pc-bios/qemu-icon.bmp. -- You received this bug notification because you are a

[Qemu-devel] [PATCH] Update ancient copyright string in QEMU -version output

2016-07-28 Thread Peter Maydell
Currently the -version command line argument prints a string ending with "Copyright (c) 2003-2008 Fabrice Bellard". This is now some eight years out of date; abstract it out of the several places that print the string and update it to: Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

2016-07-28 Thread Halil Pasic
On 07/28/2016 04:56 PM, Eric Blake wrote: > On 07/28/2016 04:46 AM, Halil Pasic wrote: > >> The implementation of preserve errno seems inconsistent to me. The >> function error_setv is static, and I guess it is supposed to provide >> this indirect errno preservation and is used for both error_s

[Qemu-devel] [PATCH 2/6] linux-user: Pass si_type information to queue_signal() explicitly

2016-07-28 Thread Peter Maydell
Instead of assuming in queue_signal() that all callers are passing a siginfo structure which uses the _sifields._sigfault part of the union (and thus a si_type of QEMU_SI_FAULT), make callers pass the si_type they require in as an argument. Signed-off-by: Peter Maydell --- linux-user/main.c|

Re: [Qemu-devel] [PATCH] timer.h: fix inconsistency between comment and function prototype

2016-07-28 Thread Michael Tokarev
Applied to -trivial, with a fix type: the clock TYPE to use... /mjt

Re: [Qemu-devel] [PATCH] util/qemu-sockets: revert Yoda Conditions to normal

2016-07-28 Thread Eric Blake
On 07/28/2016 04:50 AM, Cao jin wrote: > Follow CODING_STYLE > > Cc: Daniel P. Berrange > Cc: Gerd Hoffmann > Cc: Paolo Bonzini > > Signed-off-by: Cao jin > --- > util/qemu-sockets.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > Daniel P. Berrange make me realized t

[Qemu-devel] e1000 not fully implemented

2016-07-28 Thread Gadre Nayan
Hi everyone, I am trying to get my Host Ubuntu Machines kernel and initrd to run in QEMU as well. Basically I have Host Ubuntu 16.04, with Linux kernel 4.4.13. I compiled the kernel (make, make modules modules_install, install etc.). So I have the following files: Initrd:/boot/initrd.img-4.4

[Qemu-devel] [PATCH 4/6] linux-user: ARM: Give SIGSEGV if signal frame setup fails

2016-07-28 Thread Peter Maydell
The 32-bit ARM signal frame setup code was just bailing out on error returns from lock_user_struct calls, without generating the SIGSEGV that should happen here. Wire up error return codes to call force_sigsegv(). Signed-off-by: Peter Maydell --- linux-user/signal.c | 23 +--

Re: [Qemu-devel] VFIO mdev with vIOMMU

2016-07-28 Thread Alex Williamson
On Thu, 28 Jul 2016 10:15:24 + "Tian, Kevin" wrote: > Hi, Alex, > > Along with recent enhancement on virtual IOMMU (vIOMMU) in Qemu, I'm > thinking whether there is any issue for mdev to cope with vIOMMU. I > know today VFIO device only works with PowerPC IOMMU (note someone > is enabling V

[Qemu-devel] [PATCH 3/6] linux-user: SIGSEGV on signal entry need not be fatal

2016-07-28 Thread Peter Maydell
A failed write to memory trying to set up the signal frame should trigger a SIGSEGV, but this need not be fatal: the guest has a chance to catch it. Implement this via a force_sigsegv() function with the same behaviour as the kernel function of that name: make sure that we don't try to re-take a fa

[Qemu-devel] [PATCH 0/6] linux-user: Handle SEGV on signal entry/exit correctly

2016-07-28 Thread Peter Maydell
This patchset fixes bugs in our handling of failure to read or write guest memory on entry and exit from a signal handler. This is supposed to cause a SIGSEGV, but the guest is permitted a chance to handle the SIGSEGV (assuming it wasn't generated in the course of trying to enter a SIGSEGV handler

Re: [Qemu-devel] [PATCH 03/32] ppc: Move classic fp ops out of translate.c

2016-07-28 Thread Richard Henderson
On 07/27/2016 03:50 AM, Benjamin Herrenschmidt wrote: Makes things a bit more manageable Signed-off-by: Benjamin Herrenschmidt --- target-ppc/translate.c | 1205 +--- target-ppc/translate/fp-impl.c | 1098 target-

[Qemu-devel] [PATCH 1/6] linux-user: Recheck for pending synchronous signals too

2016-07-28 Thread Peter Maydell
In process_pending_signals() we restart the scan of possible pending signals after calling handle_pending_signal() in case some other signal has been generated. This rescan should also include a check for a new synchronous signal since those are in fact the only kind of new signal that the signal f

[Qemu-devel] [PATCH 5/6] linux-user: SIGSEGV from sigreturn need not be fatal

2016-07-28 Thread Peter Maydell
If the sigreturn syscall fails to read memory then this causes a SIGSEGV, but this is not necessarily a fatal signal -- the guest process can catch it. We don't implement this correctly because the behaviour of QEMU's force_sig() function has drifted away from the kernel function of the same name

Re: [Qemu-devel] [PATCH 09/32] ppc: Make float_invalid_op_excp() pass the return address

2016-07-28 Thread Richard Henderson
On 07/27/2016 03:51 AM, Benjamin Herrenschmidt wrote: +/* GETPC() works here because this is inline */ +raise_exception_err_ra(env, POWERPC_EXCP_PROGRAM, + POWERPC_EXCP_FP | op, GETPC()); It doesn't, with --enable-debug, aka -O0. r~

Re: [Qemu-devel] [PATCH] hw/net/e1000: Fix compiler warning

2016-07-28 Thread Michael Tokarev
Applied to -trivial, with commit message fixed. /mjt

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: Make a better about dialog

2016-07-28 Thread Programmingkid
On Jul 28, 2016, at 11:12 AM, Peter Maydell wrote: > On 28 July 2016 at 16:01, Programmingkid wrote: >> The about dialog in QEMU on Mac OS X is very plain and unhelpful. This patch >> makes the about dialog look a lot better and have some descriptive >> information >> on what version of QEMU th

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

2016-07-28 Thread Reda Sallahi
On 7/28/16, Stefan Hajnoczi wrote: > On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi wrote: >> -qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, &error_abort); >> +if (dd.flags & C_SKIP && size < in.bsz * in.offset) { >> +error_report("%s: cannot skip to specified offset", >> in.file

Re: [Qemu-devel] [PATCH v3 4/6] cadence_gem: Add queue support

2016-07-28 Thread Alistair Francis
On Thu, Jul 28, 2016 at 2:39 AM, Peter Maydell wrote: > On 26 July 2016 at 19:25, Alistair Francis > wrote: >> Signed-off-by: Alistair Francis >> --- >> >> There is a indentation error in this patch in the gem_transmit function. >> I have written it like that to make it easier to see the change

Re: [Qemu-devel] [PATCH v3 4/6] cadence_gem: Add queue support

2016-07-28 Thread Peter Maydell
On 28 July 2016 at 17:33, Alistair Francis wrote: > On Thu, Jul 28, 2016 at 2:39 AM, Peter Maydell > wrote: >> On 26 July 2016 at 19:25, Alistair Francis >> wrote: >>> Signed-off-by: Alistair Francis >>> --- >>> >>> There is a indentation error in this patch in the gem_transmit function. >>>

[Qemu-devel] [PATCH RFC 1/1] arm64: add an option to turn on/off vpmu support

2016-07-28 Thread Wei Huang
This patch adds a pmu=[on/off] option to enable/disable vpmu support in guest vm. There are several reasons to justify this option. First vpmu can be problematic for cross-migration between different SoC as perf counters is architecture-dependent. It is more flexible to have an option to turn it on

Re: [Qemu-devel] [PATCH v3 4/6] cadence_gem: Add queue support

2016-07-28 Thread Alistair Francis
On Thu, Jul 28, 2016 at 9:36 AM, Peter Maydell wrote: > On 28 July 2016 at 17:33, Alistair Francis > wrote: >> On Thu, Jul 28, 2016 at 2:39 AM, Peter Maydell >> wrote: >>> On 26 July 2016 at 19:25, Alistair Francis >>> wrote: Signed-off-by: Alistair Francis --- There is

Re: [Qemu-devel] [PATCH v3 4/6] cadence_gem: Add queue support

2016-07-28 Thread Peter Maydell
On 28 July 2016 at 17:41, Alistair Francis wrote: > Also, I have a MAINTAINERS patch on the list, that should be fine for 2.7. Could you give me a URL for that, please? thanks -- PMM

Re: [Qemu-devel] [PATCH v3 4/6] cadence_gem: Add queue support

2016-07-28 Thread Alistair Francis
On Thu, Jul 28, 2016 at 9:43 AM, Peter Maydell wrote: > On 28 July 2016 at 17:41, Alistair Francis > wrote: >> Also, I have a MAINTAINERS patch on the list, that should be fine for 2.7. > > Could you give me a URL for that, please? I can't find it... I'll send it again. Thanks, Alistair > >

Re: [Qemu-devel] [PATCH v1 1/1] MAINTAINERS: Update the Xilinx maintainers

2016-07-28 Thread Alistair Francis
On Mon, Jul 11, 2016 at 4:22 PM, Alistair Francis wrote: > Update the Xilinx maintainers documentation to simplify what we maintain > and cover all of our upstream code. This is the patch I was talking about. I can't find it in the web archive. Thanks, Alistair > > Signed-off-by: Alistair Fran

Re: [Qemu-devel] QEMU-guestOS latencies.

2016-07-28 Thread Nir Levy
After changing the inside function qemuMonitorOpenUnix int timeout to MAX_INT; in file: ./src/qemu/qemu_monitor.c (libvirt) I am now able to debug kvm and malloc I would love hearing some tips regarding tracing for latencies. regards, Nir. From: Nir Levy Sent: Thursday, July 28, 2016 12:25 PM To

[Qemu-devel] [PATCH v1 1/1] MAINTAINERS: Update the Xilinx maintainers

2016-07-28 Thread Alistair Francis
Update the Xilinx maintainers documentation to simplify what we maintain and cover all of our upstream code. Signed-off-by: Alistair Francis --- MAINTAINERS | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1d0e2

Re: [Qemu-devel] [PATCH v1 4/8] target-ppc: add vabsdu[b, h, w] instructions

2016-07-28 Thread Nikunj A Dadhania
Richard Henderson writes: > On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: >> +r->element[i] = abs(a->element[i] - b->element[i]); \ >> +} \ >> +} >> + >> +/* VABSDU - Vector absolute difference unsigned >

Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: Add skeletton PowerNV platform

2016-07-28 Thread Cédric Le Goater
Hello, On 07/26/2016 08:23 AM, David Gibson wrote: > On Mon, Jul 25, 2016 at 04:24:43PM +0200, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> No devices yet, not even an interrupt controller, just to get >> started. >> >> (Folded in Stewart Smith patch to add command lien support)

Re: [Qemu-devel] [PATCH v1 5/8] target-ppc: add vcmpnez[b, h, w][.] instructions

2016-07-28 Thread Nikunj A Dadhania
Richard Henderson writes: > On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: >> +#define VCMPNEZ_DO(suffix, element, record) \ >> +void helper_vcmpnez##suffix(CPUPPCState *env, ppc_avr_t *r, \ >> +ppc_avr_t *a, ppc_avr_t *b)

Re: [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction

2016-07-28 Thread Nikunj A Dadhania
Richard Henderson writes: > On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: >> +tcg_gen_ext32s_tl(dst, src); >> +if (sh != 0) { >> +tcg_gen_shli_tl(dst, dst, sh); >> +} > > You need not test for sh != 0, since that will be done in > tcg_gen_shli_tl. Sure, will updated. > Ot

[Qemu-devel] [PATCH v2 1/8] target-ppc: implement branch-less divw[o][.]

2016-07-28 Thread Nikunj A Dadhania
While implementing modulo instructions figured out that the implementation uses many branches. Change the logic to achieve the branch-less code. Undefined value is set to dividend in case of invalid input. Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target-ppc/translate.

[Qemu-devel] [PATCH v2 0/8] POWER9 TCG enablements - part2

2016-07-28 Thread Nikunj A Dadhania
This series contains 11 new instructions for POWER9 described in ISA3.0. Patches: 01-02: Changes following instructions: divd[u][o][.]: Divide Doubleword Signed/Unsigned divw[u][o][.]: Divide Word Signed/Unsigned 03: dtstsfi[q]: DFP Test Significance Immediate [Quad] 04: vabs

[Qemu-devel] [PATCH v2 4/8] target-ppc: add vabsdu[b, h, w] instructions

2016-07-28 Thread Nikunj A Dadhania
From: Sandipan Das Adds following instructions: vabsdub: Vector Absolute Difference Unsigned Byte vabsduh: Vector Absolute Difference Unsigned Halfword vabsduw: Vector Absolute Difference Unsigned Word Signed-off-by: Sandipan Das [ use ISA300 define. Drop etype ] Signed-off-by: Nikunj A Dadhan

[Qemu-devel] [PATCH v2 5/8] target-ppc: add vcmpnez[b, h, w][.] instructions

2016-07-28 Thread Nikunj A Dadhania
From: Swapnil Bokade Adds following instructions: vcmpnezb[.]: Vector Compare Not Equal or Zero Byte vcmpnezh[.]: Vector Compare Not Equal or Zero Halfword vcmpnezw[.]: Vector Compare Not Equal or Zero Word Signed-off-by: Swapnil Bokade [ collapse switch case ] Signed-off-by: Nikunj A Dadhania

[Qemu-devel] [PATCH v2 2/8] target-ppc: implement branch-less divd[o][.]

2016-07-28 Thread Nikunj A Dadhania
Similar to divw, implement branch-less divd. Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target-ppc/translate.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/tran

[Qemu-devel] [PATCH v2 8/8] target-ppc: add extswsli[.] instruction

2016-07-28 Thread Nikunj A Dadhania
extswsli : Extend Sign Word & Shift Left Immediate Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson Reviewed-by: Richard Henderson --- target-ppc/translate.c | 28 1 file changed, 28 insertions(+) diff --git a/target-ppc/translate.c b/target-ppc/translat

[Qemu-devel] [PATCH v2 6/8] target-ppc: add vslv instruction

2016-07-28 Thread Nikunj A Dadhania
From: Vivek Andrew Sha vslv: Vector Shift Left Variable Signed-off-by: Vivek Andrew Sha Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson Reviewed-by: Richard Henderson --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 14 ++ target-ppc/trans

[Qemu-devel] [PATCH v2 3/8] target-ppc: add dtstsfi[q] instructions

2016-07-28 Thread Nikunj A Dadhania
From: Sandipan Das DFP Test Significance Immediate [Quad] Signed-off-by: Sandipan Das Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson --- target-ppc/dfp_helper.c | 35 +++ target-ppc/helper.h | 2 ++ target-ppc/translate/dfp-imp

[Qemu-devel] [PATCH v2 7/8] target-ppc: add vsrv instruction

2016-07-28 Thread Nikunj A Dadhania
From: Vivek Andrew Sha Adds Vector Shift Right Variable instruction. Signed-off-by: Vivek Andrew Sha [ reverse the order of computation to avoid temporary array ] Signed-off-by: Nikunj A Dadhania Reviewed-by: Richard Henderson --- target-ppc/helper.h | 1 + target-ppc/int_helper

[Qemu-devel] [PATCH for-2.8 v4 3/6] cadence_gem: Add support for screening

2016-07-28 Thread Alistair Francis
The Cadence GEM hardware allows incoming data to be 'screened' based on some register values. Add support for these screens. We also need to increase the max regs to avoid compilation failures. These new registers are implemented in the next patch. Signed-off-by: Alistair Francis Reviewed-by: Pe

[Qemu-devel] [PATCH for-2.8 v4 0/6] Add support for Cadence GEM priority queues

2016-07-28 Thread Alistair Francis
This patch series adds initial priority queue support to the Cadence GEM device. This is based on original work by Peter C, that has been ported to the latest version of QEMU. There is more GEM work that I'd like to upstream after this, but I figured this a good place to start. I have done limite

[Qemu-devel] [PATCH for-2.8 v4 1/6] cadence_gem: QOMify Cadence GEM

2016-07-28 Thread Alistair Francis
The sysbus_init_irq() call will eventually depend on a property so it needs to be in the realize function. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V2: - Update commit message hw/net/cadence_gem.c | 28 +--- 1 file changed, 17 insertions(+), 11 de

Re: [Qemu-devel] [PATCH COLO-Frame v17 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-07-28 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > This is the 17th version of COLO FT feature. > > Here is only COLO frame part, you can get the whole codes from github: > https://github.com/coloft/qemu/commits/colo-v3.0-periodic-mode > > Migration now switches to use the new QIOChannel A

[Qemu-devel] [PATCH for-2.8 v4 4/6] cadence_gem: Add queue support

2016-07-28 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- There is a indentation error in this patch in the gem_transmit function. I have written it like that to make it easier to see the changes. It is fixed in the next patch. V3: -Fix up number of queues logic - Fixup vmstate version V

[Qemu-devel] [PATCH for-2.8 v4 5/6] cadence_gem: Correct indentation

2016-07-28 Thread Alistair Francis
Fix up the indentation inside the for loop that was introduced in the previous patch. This commit is almost empty if viewed using 'git show -w', except for a few changes that were required to avoid the 80 charecter line limit. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V2: -

[Qemu-devel] [PATCH for-2.8 v4 2/6] cadence_gem: Add the num-priority-queues property

2016-07-28 Thread Alistair Francis
The Cadence GEM hardware supports N number priority queues, this patch is a step towards that by adding the property to set the queues. At the moment behaviour doesn't change as we only use queue 0. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V3: - Add error checking V2: - F

<    1   2   3   4   >