Re: [Qemu-devel] [PATCH 3/6] ast2400: use machine cpu_model to initialize the soc cpu

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 04:37 AM, Andrew Jeffery wrote: > I did a similar thing in the series introducing the AST2400 SoC, and > Peter had a comment on the approach[1]: > > What we do now is not let the user override the cpu model at all; > presumably this SoC only ever has an ARM926 and it doesn't

[Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction

2016-07-28 Thread Nikunj A Dadhania
extswsli : Extend Sign Word & Shift Left Immediate Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson --- target-ppc/translate.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 82349ed..8d25121 100

[Qemu-devel] [PATCH v1 1/8] target-ppc: implement branch-less divw[o][.]

2016-07-28 Thread Nikunj A Dadhania
While implementing modulo instructions figured out that the implementation uses many branches. Change the logic to achieve the branch-less code. Undefined value is set to dividend in case of invalid input. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 48 +++--

Re: [Qemu-devel] [PATCH 4/6] palmetto-bmc: add board specific configuration

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 04:45 AM, Andrew Jeffery wrote: > On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: >> aspeed_init() now uses a board identifier to customize some values >> specific to the board, ram base, board revision number, etc. >> >> Signed-off-by: Cédric Le Goater > > Looks okay to

Re: [Qemu-devel] [PATCH] ppc: Add MacOS VGA driver ROM

2016-07-28 Thread Alexander Graf
On 07/28/2016 07:51 AM, David Gibson wrote: On Wed, Jul 27, 2016 at 06:27:33PM +1000, Benjamin Herrenschmidt wrote: The project is at https://github.com/ozbenh/QemuMacDrivers This adds a native MacOS driver in ROM (which can be picked up by MacOS once OpenBIOS has been updated if Mark accepts t

Re: [Qemu-devel] [PATCH 2/6] palmetto-bmc: replace palmetto_bmc with aspeed

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 06:48 AM, Andrew Jeffery wrote: > On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: >> This is mostly a name replacement to prepare ground for other socs >> specificities. It also adds a specific TypeInfo struct for the >> palmetto_bmc board with a custom initialization for t

[Qemu-devel] [PATCH for-2.7 v5.1 1/2] vhost-user: Introduce a new protocol feature REPLY_ACK.

2016-07-28 Thread Prerna Saxena
From: Prerna Saxena This introduces the VHOST_USER_PROTOCOL_F_REPLY_ACK. If negotiated, client applications should send a u64 payload in response to any message that contains the "need_reply" bit set on the message flags. Setting the payload to "zero" indicates the command finished successfully.

[Qemu-devel] [PATCH for-2.7 v5.1 0/2] vhost-user: Extend protocol to receive replies on any command.

2016-07-28 Thread Prerna Saxena
From: Prerna Saxena vhost-user: Extend protocol to receive replies on any command. The current vhost-user protocol requires the client to send reply to only a few commands. For the remaining commands, it is impossible for QEMU to know the status of the requested operation -- ie, did it succeed?

[Qemu-devel] [PATCH for-2.7 v5.1 2/2] vhost-user: Attempt to fix a race with set_mem_table.

2016-07-28 Thread Prerna Saxena
From: Prerna Saxena The set_mem_table command currently does not seek a reply. Hence, there is no easy way for a remote application to notify to QEMU when it finished setting up memory, or if there were errors doing so. As an example: (1) Qemu sends a SET_MEM_TABLE to the backend (eg, a vhost-us

Re: [Qemu-devel] [PATCH v4 2/2] vhost-user: Attempt to fix a race with set_mem_table.

2016-07-28 Thread Prerna Saxena
On 27/07/16 7:00 pm, "Michael S. Tsirkin" wrote: >On Wed, Jul 27, 2016 at 02:52:37AM -0700, Prerna Saxena wrote: >> From: Prerna Saxena >> >> The set_mem_table command currently does not seek a reply. Hence, there is >> no easy way for a remote application to notify to QEMU when it finished >

Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 07:11 AM, Andrew Jeffery wrote: > On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >> hw/arm/palmetto-bmc.c| 32 +++- >> include/hw/arm/ast2400.h | 5 + >> 2 files changed, 36 insertions(+), 1 d

[Qemu-devel] [PATCH 0/3] Remove obsolete non-blocking connect

2016-07-28 Thread Cao jin
Remove it as Daniel suggest, the other two are trivial. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Cao jin (3): util: remove the obsolete non-blocking connect util: fix some coding style issue migration/socket: fix typo in file header include/qemu/sockets.h | 7 +- io

[Qemu-devel] [PATCH 2/3] util: fix some coding style issue

2016-07-28 Thread Cao jin
Fix some coding style issues found in removing NonBlockingConnectHandler. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Cao jin --- util/qemu-sockets.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/util/qemu-sockets.c b/util/

[Qemu-devel] [PATCH 1/3] util: remove the obsolete non-blocking connect

2016-07-28 Thread Cao jin
The non-blocking connect mechanism is obsolete, and it doesn't work well in inet connection, because it will call getaddrinfo first and getaddrinfo will blocks on DNS lookups. Since commit e65c67e4 & d984464e, the non-blocking connect of migration goes through QIOChannel in a different manner(using

[Qemu-devel] [PATCH 3/3] migration/socket: fix typo in file header

2016-07-28 Thread Cao jin
Code of inet socket & unix socket is merged together. Also add some newlines, make code block well separated. Cc: Daniel P. Berrange Cc: Juan Quintela (maintainer:Migration) Cc: Amit Shah (maintainer:Migration) Signed-off-by: Cao jin --- migration/socket.c | 4 +++- 1 file changed, 3 insertio

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

2016-07-28 Thread Fam Zheng
On Thu, 07/28 13:17, Fam Zheng wrote: > > Maybe I'm doing something wrong, but when I apply this third patch > > (along with the first two) to master it doesn't seem to build when > > modules are enabled in the configuration: > > > > LINK x86_64-softmmu/qemu-system-x86_64 > > ../backends/baum.o

Re: [Qemu-devel] [PATCH v2 repost 7/7] virtio-balloon: tell host vm's free page info

2016-07-28 Thread Li, Liang Z
> > } > > > > +static void update_free_pages_stats(struct virtio_balloon *vb, > > why _stats? Will change. > > + max_pfn = get_max_pfn(); > > + mutex_lock(&vb->balloon_lock); > > + while (pfn < max_pfn) { > > + memset(vb->page_bitmap, 0, vb->bmap_len); > > + ret = get_

Re: [Qemu-devel] [PATCH 1/6] palmetto-bmc: add a "silicon-rev" property at the soc level

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 04:14 AM, Andrew Jeffery wrote: > On Wed, 2016-07-27 at 18:46 +0200, Cédric Le Goater wrote: >> The SCU controler holds the board revision number in its 0x7C >> register. Let's use an alias to link a "silicon-rev" property of the >> soc to the "silicon-rev" property of the SCU control

Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board

2016-07-28 Thread Andrew Jeffery
On Thu, 2016-07-28 at 09:15 +0200, Cédric Le Goater wrote: > >  > > Also, the meaning of the bits have changed from the AST2400 - they > > probably should be documented somewhere? > > So you want me send to an updated version of : > > http://lists.nongnu.org/archive/html/qemu-arm/2016-06/

Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 09:58 AM, Andrew Jeffery wrote: > On Thu, 2016-07-28 at 09:15 +0200, Cédric Le Goater wrote: >>> >>> Also, the meaning of the bits have changed from the AST2400 - they >>> probably should be documented somewhere? >> >> So you want me send to an updated version of : >> >> htt

Re: [Qemu-devel] [PATCH 1/3] util: remove the obsolete non-blocking connect

2016-07-28 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 03:39:29PM +0800, Cao jin wrote: > The non-blocking connect mechanism is obsolete, and it doesn't work well > in inet connection, because it will call getaddrinfo first and getaddrinfo > will blocks on DNS lookups. Since commit e65c67e4 & d984464e, the non-blocking > connect

Re: [Qemu-devel] [PATCH 2/3] util: fix some coding style issue

2016-07-28 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 03:39:30PM +0800, Cao jin wrote: > Fix some coding style issues found in removing NonBlockingConnectHandler. > > Cc: Daniel P. Berrange > Cc: Gerd Hoffmann > Cc: Paolo Bonzini > Signed-off-by: Cao jin > --- > util/qemu-sockets.c | 16 +++- > 1 file changed,

Re: [Qemu-devel] [PATCH 3/3] migration/socket: fix typo in file header

2016-07-28 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 03:39:31PM +0800, Cao jin wrote: > Code of inet socket & unix socket is merged together. > Also add some newlines, make code block well separated. > > Cc: Daniel P. Berrange > Cc: Juan Quintela (maintainer:Migration) > Cc: Amit Shah (maintainer:Migration) > Signed-off-by

[Qemu-devel] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits

2016-07-28 Thread Alberto Garcia
Hello, Gu Nini found this problem and reported it in https://bugzilla.redhat.com/show_bug.cgi?id=1355665 When setting the throttling configuration, the burst limits can be lower than the normal limits. This does not making any sense and behaves oddly, so let's forbid it. Berto v2: - Simplify e

[Qemu-devel] [PATCH for-2.7 v2 1/2] throttle: Don't allow burst limits to be lower than the normal limits

2016-07-28 Thread Alberto Garcia
Setting FOO_max to a value that is lower than FOO does not make sense, and it produces odd results depending on the value of FOO_max_length. Although the user should not set that configuration in the first place it's better to reject it explicitly. https://bugzilla.redhat.com/show_bug.cgi?id=13556

[Qemu-devel] [PATCH for-2.7 v2 2/2] throttle: Test burst limits lower than the normal limits

2016-07-28 Thread Alberto Garcia
This checks that making FOO_max lower than FOO is not allowed. We could also forbid having FOO_max == FOO, but that doesn't have any odd side effects and it would require us to update several other tests, so let's keep it simple. Signed-off-by: Alberto Garcia --- tests/test-throttle.c | 8 +

Re: [Qemu-devel] [PATCH] ppc: Add MacOS VGA driver ROM

2016-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2016 at 09:04:25AM +0200, Alexander Graf wrote: > On 07/28/2016 07:51 AM, David Gibson wrote: > > On Wed, Jul 27, 2016 at 06:27:33PM +1000, Benjamin Herrenschmidt wrote: > > > The project is at https://github.com/ozbenh/QemuMacDrivers > > > > > > This adds a native MacOS driver in

Re: [Qemu-devel] [PATCH] virtio: check vring descriptor buffer length

2016-07-28 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 09:07:56PM +0530, P J P wrote: > From: Prasad J Pandit > > virtio back end uses set of buffers to facilitate I/O operations. > An infinite loop unfolds in virtqueue_pop() if a buffer was > of zero size. Add check to avoid it. > > Reported-by: Li Qiang > Signed-off-by: Pr

Re: [Qemu-devel] [PATCH 2/3] util: fix some coding style issue

2016-07-28 Thread Cao jin
On 07/28/2016 04:08 PM, Daniel P. Berrange wrote: On Thu, Jul 28, 2016 at 03:39:30PM +0800, Cao jin wrote: Fix some coding style issues found in removing NonBlockingConnectHandler. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Cao jin --- util/qemu-sockets.c

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-07-28 Thread Peter Lieven
Am 27.07.2016 um 12:02 schrieb Roy Shterman: iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API is introduced in abstracion of the Libiscsi transport layer. In order to use the new iSER transport, one need t

[Qemu-devel] [PATCH v2 3/3] migration/socket: fix typo in file header

2016-07-28 Thread Cao jin
Code of inet socket & unix socket is merged together. Also add some newlines, make code block well separated. Cc: Daniel P. Berrange Cc: Juan Quintela Cc: Amit Shah Reviewed-by: Daniel P. Berrange Signed-off-by: Cao jin --- migration/socket.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

[Qemu-devel] [PATCH v2 2/3] util: fix some coding style issue

2016-07-28 Thread Cao jin
Fix some coding style issues found in removing NonBlockingConnectHandler. Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Reviwed-by: Daniel P. Berrange Signed-off-by: Cao jin --- util/qemu-sockets.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [PATCH v2 0/3] Remove the obsolete non-blocking connect

2016-07-28 Thread Cao jin
v2 changelog: 1. revert the yoda-condition in patch 2 (Daniel) Cao jin (3): util: remove the obsolete non-blocking connect util: fix some coding style issue migration/socket: fix typo in file header include/qemu/sockets.h | 7 +- io/channel-socket.c| 2 +- migration/socket.c |

[Qemu-devel] [PATCH v2 1/3] util: remove the obsolete non-blocking connect

2016-07-28 Thread Cao jin
The non-blocking connect mechanism is obsolete, and it doesn't work well in inet connection, because it will call getaddrinfo first and getaddrinfo will blocks on DNS lookups. Since commit e65c67e4 & d984464e, the non-blocking connect of migration goes through QIOChannel in a different manner(using

Re: [Qemu-devel] [PATCH v2 0/3] Remove the obsolete non-blocking connect

2016-07-28 Thread Cao jin
forget to cc maintainers in cover-letter.. On 07/28/2016 04:54 PM, Cao jin wrote: v2 changelog: 1. revert the yoda-condition in patch 2 (Daniel) Cao jin (3): util: remove the obsolete non-blocking connect util: fix some coding style issue migration/socket: fix typo in file header in

[Qemu-devel] [Bug 1606899] Re: virtio-vga does not let guest poweroff properly

2016-07-28 Thread Frediano Ziglio
Removed the parameters, now the command line is /usr/bin/qemu-system-x86_64 -machine accel=kvm -name rawhide -machine pc-i440fx-2.3,accel=kvm,usb=off -cpu Haswell-noTSX -m 2048 -realtime mlock=off -smp 2,sockets=2,cores=1,threads=1 -uuid 64216421-aec4-4ce4-aa52-aed9e4e31a1c -no-user-config -nodefa

[Qemu-devel] [PATCH] target-mips: fix EntryHi.EHINV being cleared on TLB exception

2016-07-28 Thread Leon Alrae
While implementing TLB invalidation feature we forgot to modify part of code responsible for updating EntryHi during TLB exception. Consequently EntryHi.EHINV is unexpectedly cleared on the exception. Signed-off-by: Leon Alrae --- target-mips/helper.c |1 + 1 files changed, 1 insertions(+),

Re: [Qemu-devel] [PATCH v3] qemu-img: add skip option to dd

2016-07-28 Thread Fam Zheng
On Wed, 07/27 16:51, Reda Sallahi wrote: > +for skip in $TEST_SKIP_BLOCKS; do > +echo > +echo "== Creating image ==" > + > +size=1M > +_make_test_img $size > +_check_test_img > +$QEMU_IO -c "write -P 0xa 0 $size" "$TEST_IMG" | _filter_qemu_io I think the data pattern could

Re: [Qemu-devel] [PULL 0/9] x86 and machine queue, 2016-07-27

2016-07-28 Thread Peter Maydell
On 27 July 2016 at 15:29, Eduardo Habkost wrote: > The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' > into staging (2016-07-26 11:53:47 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

2016-07-28 Thread Stefan Hajnoczi
On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi wrote: > -qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, &error_abort); > +if (dd.flags & C_SKIP && size < in.bsz * in.offset) { > +error_report("%s: cannot skip to specified offset", in.filename); > +qemu_opt_set_number(opts,

[Qemu-devel] [PATCH V3] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-07-28 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/sysemu/char.h | 11 -

Re: [Qemu-devel] [Qemu-block] [PATCH v6] qemu-img: add the 'dd' subcommand

2016-07-28 Thread Stefan Hajnoczi
On Mon, Jul 25, 2016 at 6:58 AM, Reda Sallahi wrote: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. > > For the start, this implements the bs, if, of and count options and requires > both if and of to be specified (no stdin/stdout if not specified) and doesn't > support tt

Re: [Qemu-devel] [PATCH v3 3/6] cadence_gem: Add support for screening

2016-07-28 Thread Peter Maydell
On 26 July 2016 at 19:25, Alistair Francis wrote: > The Cadence GEM hardware allows incoming data to be 'screened' based on some > register values. Add support for these screens. > > We also need to increase the max regs to avoid compilation failures. These new > registers are implemented in the n

Re: [Qemu-devel] [PATCH v3 4/6] cadence_gem: Add queue support

2016-07-28 Thread Peter Maydell
On 26 July 2016 at 19:25, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > There is a indentation error in this patch in the gem_transmit function. > I have written it like that to make it easier to see the changes. It is > fixed in the next patch. > @@ -1417,8 +1500,8 @@ stat

[Qemu-devel] [PATCH V11 7/9] filter-rewriter: introduce filter-rewriter initialization

2016-07-28 Thread Zhang Chen
Filter-rewriter is a part of COLO project. It will rewrite some of secondary packet to make secondary guest's tcp connection established successfully. In this module we will rewrite tcp packet's ack to the secondary from primary,and rewrite tcp packet's seq to the primary from secondary. usage: c

[Qemu-devel] [PATCH V11 0/9] Introduce COLO-compare and filter-rewriter

2016-07-28 Thread Zhang Chen
COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. Filter-rewriter is a part of COLO project too. It will rewrite some of secondary packet to make secondary guest's connection established successfully. In this module we w

[Qemu-devel] [PATCH V11 8/9] filter-rewriter: track connection and parse packet

2016-07-28 Thread Zhang Chen
We use colo-base.h to track connection and parse packet Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-base.c | 14 ++ net/colo-base.h | 1 + net/filter-rewriter.c | 50 ++ 3

[Qemu-devel] VFIO mdev with vIOMMU

2016-07-28 Thread Tian, Kevin
Hi, Alex, Along with recent enhancement on virtual IOMMU (vIOMMU) in Qemu, I'm thinking whether there is any issue for mdev to cope with vIOMMU. I know today VFIO device only works with PowerPC IOMMU (note someone is enabling VFIO device with virtual VT-d but looks not complete yet), but it's alw

[Qemu-devel] [PATCH V11 1/9] colo-compare: introduce colo compare initialization

2016-07-28 Thread Zhang Chen
This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ | +--

[Qemu-devel] [PATCH V11 2/9] colo-base: add colo-base to define and handle packet

2016-07-28 Thread Zhang Chen
COLO-base used by colo-compare and filter-rewriter. this can share common data structure like:net packet, and share other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-base.c| 74

[Qemu-devel] [PATCH V11 4/9] colo-compare: track connection and enqueue packet

2016-07-28 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

[Qemu-devel] [PATCH V11 3/9] Jhash: add linux kernel jhashtable in qemu

2016-07-28 Thread Zhang Chen
Jhash used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 61 1 file changed, 61 insertions(+) create mod

[Qemu-devel] [PATCH V11 5/9] colo-compare: introduce packet comparison thread

2016-07-28 Thread Zhang Chen
If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes and secondary packet not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a checkp

Re: [Qemu-devel] invalid runstate transition: 'prelaunch' -> 'prelaunch'

2016-07-28 Thread Markus Armbruster
Liviu Ionescu writes: > Hi, > > I just upgraded GNU ARM Eclipse QEMU to 2.6.0 and ran into a problem. > > The console reads: > > ``` > GNU ARM Eclipse 64-bits QEMU v2.6.0 (qemu-system-gnuarmeclipse). > Board: 'STM32F4-Discovery' (ST Discovery kit for STM32F407/417 lines). > Device: 'STM32F407VG'

[Qemu-devel] [PATCH V11 6/9] colo-compare: add TCP, UDP, ICMP packet comparison

2016-07-28 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 174 +++

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/2] convert device initialization functions

2016-07-28 Thread Marcel Apfelbaum
On 07/13/2016 10:14 AM, Wei, Jiangang wrote: cc qemu-trivial The following patches had been reviewed one month ago, But so far, It haven't been merged. May I trouble any maintainer give me some feedback? hw/pci-bridge: Convert pxb initialization functions to Error apb: convert init to realize

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

2016-07-28 Thread Markus Armbruster
Eric Blake writes: > On 07/27/2016 03:24 AM, Sascha Silbe wrote: >> C11 allows errno to be clobbered by pretty much any library function >> call, so in general callers need to take care to save errno before >> calling other functions. >> >> However, for error reporting functions this is rather a

[Qemu-devel] [PATCH V11 9/9] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-07-28 Thread Zhang Chen
We will rewrite tcp packet secondary received and sent. When colo guest is a tcp server. Firstly, client start a tcp handshake. the packet's seq=client_seq, ack=0,flag=SYN. COLO primary guest get this pkt and mirror(filter-mirror) to secondary guest, secondary get it use filter-redirector. Then,pr

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

2016-07-28 Thread Sascha Silbe
Dear Eric, Eric Blake writes: >> +++ b/include/qapi/error.h >> @@ -170,6 +170,9 @@ void error_setg_internal(Error **errp, >> * Just like error_setg(), with @os_error info added to the message. >> * If @os_error is non-zero, ": " + strerror(os_error) is appended to >> * the human-readable e

[Qemu-devel] [PATCH] util/qemu-sockets: revert Yoda Conditions to normal

2016-07-28 Thread Cao jin
Follow CODING_STYLE Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Cao jin --- util/qemu-sockets.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Daniel P. Berrange make me realized there is Yoda Conditions in this file, this file is mixed with b

Re: [Qemu-devel] [PATCH] error: error_setg_errno(): errno gets preserved

2016-07-28 Thread Halil Pasic
On 07/28/2016 12:19 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 07/27/2016 03:24 AM, Sascha Silbe wrote: >>> C11 allows errno to be clobbered by pretty much any library function >>> call, so in general callers need to take care to save errno before >>> calling other functions. >>>

Re: [Qemu-devel] invalid runstate transition: 'prelaunch' -> 'prelaunch'

2016-07-28 Thread Liviu Ionescu
Peter, Can you confirm that adding a new transition definition is ok for the context I'm using it? I had no problems so far, just wanted to be sure. Thank you, Liviu > On 27 Jul 2016, at 22:40, Liviu Ionescu wrote: > > Hi, > > I just upgraded GNU ARM Eclipse QEMU to 2.6.0 and ran into a

[Qemu-devel] [PATCH] RFC: pci-bus: add property ownership on bsel

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau The property should own the allocated and unreferenced pointer. In case of error, it should also be freed. RFC, because this patch triggers: /x86_64/qom/pc-i440fx-1.7: qemu-system-x86_64: attempt to add duplicate property 'acpi-pcihp-bsel' to object (type 'PCI') Signed-

Re: [Qemu-devel] [PATCH] RFC: pci-bus: add property ownership on bsel

2016-07-28 Thread Igor Mammedov
On Thu, 28 Jul 2016 15:13:57 +0400 marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The property should own the allocated and unreferenced pointer. In case > of error, it should also be freed. I wonder, what use case triggers above error > > RFC, because this patch triggers: >

Re: [Qemu-devel] [PATCH 22/37] pc: free i8259

2016-07-28 Thread Marcel Apfelbaum
On 07/19/2016 11:54 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Simiarly to 2ba154cf4eb8636cdd3aa90f392ca9e77206ca39 Signed-off-by: Marc-André Lureau --- hw/i386/pc_q35.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index c0b996

[Qemu-devel] [PATCH] linux-user: Use correct alignment for long long on i386 guests

2016-07-28 Thread Peter Maydell
For i386, the ABI specifies that 'long long' (8 byte values) need only be 4 aligned, but we were requiring them to be 8-aligned. This meant we were laying out the target_epoll_event structure wrongly. Add a suitable ifdef to abitypes.h to specify the i386-specific alignment requirement. Reported-b

[Qemu-devel] [PATCH 4/7] nios2: Add IIC interrupt controller emulation

2016-07-28 Thread Marek Vasut
From: Chris Wulff Add the Altera Nios2 internal interrupt controller model. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- hw/intc/Makefile.objs | 1 + hw/intc/nios2_iic.c | 103 +

[Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-07-28 Thread Marek Vasut
From: Chris Wulff Add the Altera timer model. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- hw/timer/Makefile.objs | 1 + hw/timer/altera_timer.c | 225 2 fil

[Qemu-devel] [PATCH 3/7] nios2: Add usermode binaries emulation

2016-07-28 Thread Marek Vasut
Add missing bits for qemu-user required for emulating Altera Nios2 userspace binaries. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves Vandervennet --- include/elf.h | 2 + linux-user/elfload.c |

[Qemu-devel] [PATCH V2 1/7] nios2: Add disas entries

2016-07-28 Thread Marek Vasut
Add nios2 disassembler support. This patch is composed from binutils files from commit "Opcodes and assembler support for Nios II R2". The files from binutils used in this patch are: include/opcode/nios2.h include/opcode/nios2r1.h include/opcode/nios2r2.h opcodes/nios2-opc.c op

[Qemu-devel] [PATCH 2/7] nios2: Add architecture emulation support

2016-07-28 Thread Marek Vasut
From: Chris Wulff Add support for emulating Altera NiosII R1 architecture into qemu. This patch is based on previous work by Chris Wulff from 2012 and updated to latest mainline QEMU. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva Cc: Ley Foon Tan Cc: Sandra Loosemore Cc: Yves

[Qemu-devel] [PATCH 7/7] nios2: Add support for Nios-II R1

2016-07-28 Thread Marek Vasut
Add remaining bits of the Altera NiosII R1 support into qemu, which is documentation, MAINTAINERS file entry, configure bits, arch_init and configuration files for both linux-user (userland binaries) and softmmu (hardware emulation). Signed-off-by: Marek Vasut Cc: Chris Wulff Cc: Jeff Da Silva

[Qemu-devel] [PATCH 6/7] nios2: Add Altera 10M50 GHRD emulation

2016-07-28 Thread Marek Vasut
Add the Altera 10M50 Nios2 GHRD model. This allows emulating the 10M50 development kit with the Nios2 GHRD loaded in the FPGA. It is possible to boot Linux kernel and run userspace, thus far only from initrd as storage support is not yet implemented. Signed-off-by: Marek Vasut Cc: Chris Wulff Cc

Re: [Qemu-devel] [PATCH] ppc: Add MacOS VGA driver ROM

2016-07-28 Thread Benjamin Herrenschmidt
On Thu, 2016-07-28 at 15:51 +1000, David Gibson wrote: > So, I believe qemu convention is to include the ROM source via a > submodule - even though it won't typically be built from there and the > prebuilt blob will be used instead. > > Not sure who the right person to talk to about that would be.

Re: [Qemu-devel] [PATCH v1 1/8] target-ppc: implement branch-less divw[o][.]

2016-07-28 Thread Richard Henderson
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: While implementing modulo instructions figured out that the implementation uses many branches. Change the logic to achieve the branch-less code. Undefined value is set to dividend in case of invalid input. Signed-off-by: Nikunj A Dadhania --- ta

Re: [Qemu-devel] [PATCH] ppc: Add MacOS VGA driver ROM

2016-07-28 Thread Benjamin Herrenschmidt
On Thu, 2016-07-28 at 09:28 +0100, Stefan Hajnoczi wrote: > > Jeff, please create a mirror git repo for > https://github.com/ozbenh/QemuMacDrivers at > git://git.qemu-project.org/QemuMacDrivers.git with nightly mirroring. > > Once Jeff has set up the mirror repo, please send a new revision of > t

Re: [Qemu-devel] [PATCH v1 2/8] target-ppc: implement branch-less divd[o][.]

2016-07-28 Thread Richard Henderson
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: Similar to divw, implement branch-less divd. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) Reviewed-by: Richard Henderson

[Qemu-devel] [Bug 1591724] Re: Windows 7 installation DVD can't boot in qemu 2.6.0/OVMF

2016-07-28 Thread tkr
*** This bug is a duplicate of bug 1581936 *** https://bugs.launchpad.net/bugs/1581936 ** This bug has been marked a duplicate of bug 1581936 Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1) -- You received this bug notification because you are a member of qemu- devel-m

[Qemu-devel] [Bug 1585008] Re: Windows 7 guests hang on bootup when qxl video is used

2016-07-28 Thread tkr
*** This bug is a duplicate of bug 1581936 *** https://bugs.launchpad.net/bugs/1581936 ** This bug is no longer a duplicate of bug 1591724 Windows 7 installation DVD can't boot in qemu 2.6.0/OVMF ** This bug has been marked a duplicate of bug 1581936 Frozen Windows 7 VMs with VGA CVE-201

Re: [Qemu-devel] [PATCH v1 4/8] target-ppc: add vabsdu[b, h, w] instructions

2016-07-28 Thread Richard Henderson
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: +r->element[i] = abs(a->element[i] - b->element[i]); \ +} \ +} + +/* VABSDU - Vector absolute difference unsigned + * name- instruction mnemonic suffix

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-28 Thread Stefan Hajnoczi
On Thu, Jul 28, 2016 at 02:39:53PM +0900, Namhyung Kim wrote: > On Thu, Jul 28, 2016 at 03:02:54AM +0300, Michael S. Tsirkin wrote: > > On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > > > +static ssize_t virtio_pstore_do_write(VirtIOPstore *s, struct iovec > > > *out_sg, > > > +

Re: [Qemu-devel] [PATCH v1 5/8] target-ppc: add vcmpnez[b, h, w][.] instructions

2016-07-28 Thread Richard Henderson
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: +#define VCMPNEZ_DO(suffix, element, record) \ +void helper_vcmpnez##suffix(CPUPPCState *env, ppc_avr_t *r, \ +ppc_avr_t *a, ppc_avr_t *b) \ +{

[Qemu-devel] [Bug 1589153] Re: qemu-system-x86_64 version 2.5.0 freezes during windows 7 installation in lubuntu 16.04

2016-07-28 Thread tkr
*** This bug is a duplicate of bug 1581936 *** https://bugs.launchpad.net/bugs/1581936 ** This bug has been marked a duplicate of bug 1581936 Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1) -- You received this bug notification because you are a member of qemu- devel-m

Re: [Qemu-devel] [PATCH v1 6/8] target-ppc: add vslv instruction

2016-07-28 Thread Richard Henderson
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: From: Vivek Andrew Sha vslv: Vector Shift Left Variable Signed-off-by: Vivek Andrew Sha Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 14 +

Re: [Qemu-devel] [PATCH v1 7/8] target-ppc: add vsrv instruction

2016-07-28 Thread Richard Henderson
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: From: Vivek Andrew Sha Adds Vector Shift Right Variable instruction. Signed-off-by: Vivek Andrew Sha [ reverse the order of computation to avoid temporary array ] Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + ta

Re: [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction

2016-07-28 Thread Richard Henderson
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote: +tcg_gen_ext32s_tl(dst, src); +if (sh != 0) { +tcg_gen_shli_tl(dst, dst, sh); +} You need not test for sh != 0, since that will be done in tcg_gen_shli_tl. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-28 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 01:56:07PM +0100, Stefan Hajnoczi wrote: > On Thu, Jul 28, 2016 at 02:39:53PM +0900, Namhyung Kim wrote: > > On Thu, Jul 28, 2016 at 03:02:54AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > > > > +static ssize_t virtio

Re: [Qemu-devel] [PATCH 6/7] qemu: Implement virtio-pstore device

2016-07-28 Thread Daniel P. Berrange
On Thu, Jul 28, 2016 at 12:08:30AM +0900, Namhyung Kim wrote: > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... > > (guest)

Re: [Qemu-devel] [PATCH] RFC: pci-bus: add property ownership on bsel

2016-07-28 Thread Marc-André Lureau
Hi On Thu, Jul 28, 2016 at 3:29 PM, Igor Mammedov wrote: > On Thu, 28 Jul 2016 15:13:57 +0400 > marcandre.lur...@redhat.com wrote: > >> From: Marc-André Lureau >> >> The property should own the allocated and unreferenced pointer. In case >> of error, it should also be freed. > I wonder, what use

Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board

2016-07-28 Thread Cédric Le Goater
On 07/28/2016 10:03 AM, Cédric Le Goater wrote: > On 07/28/2016 09:58 AM, Andrew Jeffery wrote: >> On Thu, 2016-07-28 at 09:15 +0200, Cédric Le Goater wrote: Also, the meaning of the bits have changed from the AST2400 - they probably should be documented somewhere? >>> >>> So you w

[Qemu-devel] [PATCH v2 0/9] arm: add ast2500 support

2016-07-28 Thread Cédric Le Goater
The ast2500 soc being very close to the ast2400 soc, the goal of the changes below is to modify the existing platform 'palmetto-bmc' and existing soc 'ast2400' to take into account the small differences and avoid code duplication. This is mostly inspired by the realview platform. First patches rew

[Qemu-devel] [PATCH v2 1/9] palmetto-bmc: rename file to aspeed.c

2016-07-28 Thread Cédric Le Goater
We plan to add more Aspeed platform to this file. Let's rename it to a more generic name. There are no changes in the code. Signed-off-by: Cédric Le Goater --- hw/arm/Makefile.objs | 2 +- hw/arm/aspeed.c | 102 ++ hw/arm/palmetto-bmc.c |

[Qemu-devel] [PATCH v2 5/9] palmetto-bmc: add board specific configuration

2016-07-28 Thread Cédric Le Goater
aspeed_init() now uses a board identifier to customize some values specific to the board, ram base, board revision number, etc. Signed-off-by: Cédric Le Goater --- Changes since v1: - changed aspeed_init() prototype to use a 'const AspeedBoardConfig *' - fixed white space issues hw/arm/as

[Qemu-devel] [PATCH v2 4/9] ast2400: use machine cpu_model to initialize the soc cpu

2016-07-28 Thread Cédric Le Goater
It will be easier to specify a different cpu for other soc derived from the ast2400 soc. Signed-off-by: Cédric Le Goater --- Change since v1: - remove check on cpu_model. hw/arm/aspeed.c | 1 + hw/arm/ast2400.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/arm/

[Qemu-devel] [PATCH v2 2/9] palmetto-bmc: add a "silicon-rev" property at the soc level

2016-07-28 Thread Cédric Le Goater
The SCU controler holds the board revision number in its 0x7C register. Let's use an alias to link a "silicon-rev" property of the soc to the "silicon-rev" property of the SCU controler. The SDMC controler "silicon-rev" property is derived from the SCU one at realize time. I did not find a better

[Qemu-devel] [PATCH v2 7/9] aspeed: add ast2500 support to scu and sdmc controllers

2016-07-28 Thread Cédric Le Goater
Based on previous work done by Andrew Jeffery . The ast2500 eval board has a hardware strapping register value of 0xF100C2E6 which we use for a definition of AST2500_HW_STRAP1 below. Signed-off-by: Cédric Le Goater --- Andrew, I did not add your 'Reviewed-by' because of the changes below.

[Qemu-devel] [PATCH v2 03/37] qga: free the whole blacklist

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Free the list, not just the elements. Signed-off-by: Marc-André Lureau --- qga/main.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/qga/main.c b/qga/main.c index 4c3b2c7..67be90b 100644 --- a/qga/main.c +++ b/qga/main.c @@ -1175,6 +1175,8 @

[Qemu-devel] [PATCH v2 01/37] build-sys: use an override for CFLAGS filter

2016-07-28 Thread marcandre . lureau
From: Marc-André Lureau Even if the user gave CFLAGS=... argument on make command line to override the configure value, make sure the filter is applied. Signed-off-by: Marc-André Lureau --- pc-bios/optionrom/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pc-bi

[Qemu-devel] [PATCH v2 8/9] arm: add support for an ast2500 evaluation board

2016-07-28 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- Changes since v1: - changed AST2500_EDK to AST2500_EVB - fixed white space issues - added AST2500_HW_STRAP1 hw/arm/aspeed.c | 31 ++- include/hw/arm/ast2400.h | 5 + 2 files changed, 35 insertions(+), 1 deletion

[Qemu-devel] [PATCH v2 3/9] palmetto-bmc: replace palmetto_bmc with aspeed

2016-07-28 Thread Cédric Le Goater
This is mostly a name replacement to prepare ground for other socs specificities. It also adds a specific TypeInfo struct for the palmetto_bmc board with a custom initialization for the same reason. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 54

  1   2   3   4   >