On 07/28/2016 09:58 AM, Andrew Jeffery wrote: > On Thu, 2016-07-28 at 09:15 +0200, Cédric Le Goater wrote: >>> >>> Also, the meaning of the bits have changed from the AST2400 - they >>> probably should be documented somewhere? >> >> So you want me send to an updated version of : >> >> http://lists.nongnu.org/archive/html/qemu-arm/2016-06/msg00698.html >> >> as a prereq ? > > I mentioned this in passing due to the discussion on my original patch. > I think we discussed this separately and concluded the macros were > pretty verbose given they are sort-of single-use given the value > doesn't change. Maybe just comments as Peter was requesting? You have > the patch below but some of the macros will be different for the > AST2500.
yes. > I'm probably leaning towards comments over macros, but don't feel > strongly either way. ok. having a correct value is a minimum and this is not the case in this patch. I think I will go for the comments for now as We have not merged anything in mainline uboot yet. Thanks, C.
