If correctly configured allow the STM32F2xx timer to print
out the PWM duty cycle information.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Crosthwaite
---
V3:
- Use OR instead of + for masking
- Improve clarity of print statement
V2:
- Fix up if statement braces
- Remove stm32f2xx_tim
Add the STM32F2xx SPI device.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
V4:
- Add VMState
- Small fixes
V2:
- Address Peter C's comments
default-configs/arm-softmmu.mak | 1 +
hw/ssi/Makefile.objs| 1 +
hw/ssi/stm32f2xx_spi.c | 225 +
Signed-off-by: Alistair Francis
---
hw/core/irq.c| 44
include/hw/irq.h | 13 +
2 files changed, 57 insertions(+)
diff --git a/hw/core/irq.c b/hw/core/irq.c
index 49ff2e6..73b18b4 100644
--- a/hw/core/irq.c
+++ b/hw/core/irq.c
@@ -27,
On 26 July 2016 at 15:37, Alistair Francis wrote:
> Signed-off-by: Alistair Francis
> ---
>
> hw/core/irq.c| 44
> include/hw/irq.h | 13 +
> 2 files changed, 57 insertions(+)
>
> diff --git a/hw/core/irq.c b/hw/core/irq.c
> index 49ff
On Mon, Jul 25, 2016 at 11:59:18AM +0200, Igor Mammedov wrote:
> Changes from v1:
> - be conservative, drop QTAIL_*() macros hunks and do list element
> check/cleanup localy in cpu_exec_exit()
> - fix conflict caused by above
> - update Reviewed-bys fom v1
> - drop spapr patches as they
On Tue, Jul 26, 2016 at 01:16:59PM +1000, David Gibson wrote:
> On Mon, Jul 25, 2016 at 11:59:18AM +0200, Igor Mammedov wrote:
> > Changes from v1:
> > - be conservative, drop QTAIL_*() macros hunks and do list element
> > check/cleanup localy in cpu_exec_exit()
> > - fix conflict caused by
On 26.07.2016 15:13, Daniel P. Berrange wrote:
> The previous commit refactoring iotests.py:
>
> commit 66613974468fb6e1609fb3eabf55981b1ee436cf
> Author: Daniel P. Berrange
> Date: Wed Jul 20 14:23:10 2016 +0100
>
> scripts: refactor the VM class in iotests for reuse
>
> was not pr
On 26.07.2016 14:52, Alberto Garcia wrote:
> On Fri, Jul 08, 2016 at 05:05:12PM +0300, Alberto Garcia wrote:
>> Hi,
>>
>> Stefan reported this, this is a regression caused by commit
>> efaa7c4eeb7490c6f37f3.
>>
>> I sent a separate series for the git master, this is the backport
>> for QEMU v2.6.0.
Sergey Fedorov writes:
> From: Sergey Fedorov
>
> This patch is based on the ideas found in work of KONRAD Frederic [1],
> Alex Bennée [2], and Alvise Rigo [3].
>
> This mechanism allows to perform an operation safely in a quiescent
> state. Quiescent state means: (1) no vCPU is running and (2)
- Igor Mammedov ha scritto:
> QEMU fails migration with following error:
>
> qemu-system-x86_64: Missing section footer for i2c_bus
> qemu-system-x86_64: load of migration failed: Invalid argument
>
> when migrating from:
> qemu-system-x86_64-v2.6.0 -m 256M rhel72.img -M pc-i440fx-2.6
> t
On 26.07.2016 13:34, Halil Pasic wrote:
> Make raw_open for POSIX more consistent in handling errors by setting
> the error object also when qemu_open fails. The error object was set
> generally set in case of errors, but I guess this case was overlooked.
> Do the same for win32.
>
> Signed-off-by
I'm unable to reproduce the problem mentioned myself, and code
inspection shows no problem for x86_64 at least.
Specifically hw/char/serial.c has a serial_xmit() method which calls
qemu_chr_fe_write(), and if it sees EAGAIN, it sets up a event
notification to re-try the write later.
Can you pro
On Tue, Jul 26, 2016 at 4:47 AM, Peter Maydell wrote:
> On 26 July 2016 at 01:12, Alistair Francis
> wrote:
>> The Cadence GEM hardware supports N number priority queues, this patch is a
>> step towards that by adding the property to set the queues. At the moment
>> behaviour doesn't change as w
Looking at the code in 2.5.0, the qemu_chr_fe_write method would see
EAGAIN too, because the tcp_chr_accept() method would always set the
newly connected client to non-blocking mode. So thre's no obvious change
in behaviour between 2.5 and 2.6 wrt to blocking sockets.
--
You received this bug not
On 26/07/2016 12:02, Thomas Huth wrote:
> On 26.07.2016 11:53, Laurent Vivier wrote:
>>
>>
>> On 26/07/2016 11:39, Laurent Vivier wrote:
>>>
>>>
>>> On 26/07/2016 11:28, Thomas Huth wrote:
On 26.07.2016 11:23, Laurent Vivier wrote:
>
>
> On 23/07/2016 08:30, David Gibson wrote:
>
On 26.07.2016 10:15, Changlong Xie wrote:
> From: Wen Congyang
>
> Signed-off-by: Wen Congyang
> Signed-off-by: Changlong Xie
> Signed-off-by: Wang WeiWei
> Signed-off-by: zhanghailiang
> Signed-off-by: Gonglei
> ---
> block/Makefile.objs | 1 +
> block/replication.c | 658
>
The previous commit refactoring iotests.py:
commit 66613974468fb6e1609fb3eabf55981b1ee436cf
Author: Daniel P. Berrange
Date: Wed Jul 20 14:23:10 2016 +0100
scripts: refactor the VM class in iotests for reuse
was not properly tested and included a number of broken
bits.
- The 'even
Can you provide the full QEMU command line arguments you're using to
reproduce this problem. I tested a guest with the following console
config:
and confirmed that the log file gets written, even when no client is
connected to the UNIX domain socket.
** Chan
On 26.07.2016 10:15, Changlong Xie wrote:
> From: Wen Congyang
>
> Signed-off-by: Wen Congyang
> Signed-off-by: Changlong Xie
> Signed-off-by: Wang WeiWei
> Signed-off-by: zhanghailiang
> Signed-off-by: Gonglei
> Reviewed-by: Eric Blake
> ---
> qapi/block-core.json | 22 +++
On Tue, Jul 26, 2016 at 5:06 AM, Peter Maydell wrote:
> On 26 July 2016 at 01:12, Alistair Francis
> wrote:
>> Signed-off-by: Alistair Francis
>> ---
>>
>> There is a indentation error in this patch in the gem_transmit function.
>> I have written it like that to make it easier to see the change
On 26.07.2016 10:15, Changlong Xie wrote:
> As per Stefan's suggestion, add Wen and I as co-maintainers
> of replication.
>
> Cc: Stefan Hajnoczi
> Signed-off-by: Wen Congyang
> Signed-off-by: Changlong Xie
> ---
> MAINTAINERS | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/M
On 26.07.2016 18:16, Daniel P. Berrange wrote:
> The previous commit refactoring iotests.py:
>
> commit 66613974468fb6e1609fb3eabf55981b1ee436cf
> Author: Daniel P. Berrange
> Date: Wed Jul 20 14:23:10 2016 +0100
>
> scripts: refactor the VM class in iotests for reuse
>
> was not pr
On 26/07/2016 12:02, Thomas Huth wrote:
> On 26.07.2016 11:53, Laurent Vivier wrote:
>>
>>
>> On 26/07/2016 11:39, Laurent Vivier wrote:
>>>
>>>
>>> On 26/07/2016 11:28, Thomas Huth wrote:
On 26.07.2016 11:23, Laurent Vivier wrote:
>
>
> On 23/07/2016 08:30, David Gibson wrote:
>
Hi t,
this is what you need?
70f87e0f0aa04f764dabaeb3ed71ff195748076a is the first bad commit
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1603636
Title:
Guest has not initialized the display yet
On Tue, Jul 26, 2016 at 5:01 AM, Peter Maydell wrote:
> On 26 July 2016 at 01:12, Alistair Francis
> wrote:
>> The Cadence GEM hardware allows incoming data to be 'screened' based on some
>> register values. Add support for these screens.
>>
>> Signed-off-by: Alistair Francis
>> ---
>> V2:
>>
On 26 July 2016 at 17:42, Alistair Francis wrote:
> On Tue, Jul 26, 2016 at 5:01 AM, Peter Maydell
> wrote:
>> On 26 July 2016 at 01:12, Alistair Francis
>> wrote:
>>> The Cadence GEM hardware allows incoming data to be 'screened' based on some
>>> register values. Add support for these screen
Hi t,
just to notice the 2.7 is effected too :-(
./qemu-system-i386
qemu-system-i386: Trying to execute code outside RAM or ROM at 0x000a
This usually means one of the following happened:
(1) You told QEMU to execute a kernel for the wrong machine type, and it
crashed on startup (eg trying
On Windows, such files were not truncated like on all other hosts.
Now we also test whether truncation is needed when running on Windows.
Reported-by: Benjamin David Lunt
Signed-off-by: Stefan Weil
---
qemu-char.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/q
The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' into
staging (2016-07-26 11:53:47 +0100)
are available in the git repository at:
git://github.com/XanClic/qemu.git tags/pull-blo
From: Vladimir Sementsov-Ogievskiy
There are no needs to allocate more than one cluster, as we set
avail_out for deflate to one cluster.
Zlib docs (http://www.zlib.net/manual.html) says:
"deflate compresses as much data as possible, and stops when the input
buffer becomes empty or the output buf
On 07/26/2016 05:42 PM, Max Reitz wrote:
>> +++ b/block/raw-posix.c
>> > @@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict
>> > *options,
>> > s->fd = -1;
>> > fd = qemu_open(filename, s->open_flags, 0644);
>> > if (fd < 0) {
>> > +error_setg_errno
From: "Daniel P. Berrange"
The qemu-img info command has the ability to expose format
specific metadata about volumes. Wire up this facility for
the LUKS driver to report on cipher configuration and key
slot usage.
$ qemu-img info ~/VirtualMachines/demo.luks
image: /home/berrange/Virtual
From: "Daniel P. Berrange"
When creating new block encryption volumes, we accept a list of
parameters to control the formatting process. It is useful to
be able to query what those parameters were for existing block
devices. Add a qcrypto_block_get_info() method which returns a
QCryptoBlockInfo i
From: Cao jin
Correct comments of field notify_me
Cc: Kevin Wolf
Cc: Max Reitz
Signed-off-by: Cao jin
Message-id: 1468575858-22975-1-git-send-email-caoj.f...@cn.fujitsu.com
Signed-off-by: Max Reitz
---
include/block/aio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/i
From: "Daniel P. Berrange"
The previous commit refactoring iotests.py:
commit 66613974468fb6e1609fb3eabf55981b1ee436cf
Author: Daniel P. Berrange
Date: Wed Jul 20 14:23:10 2016 +0100
scripts: refactor the VM class in iotests for reuse
was not properly tested and included a number
On Tue, Jul 26, 2016 at 9:55 AM, Peter Maydell wrote:
> On 26 July 2016 at 17:42, Alistair Francis
> wrote:
>> On Tue, Jul 26, 2016 at 5:01 AM, Peter Maydell
>> wrote:
>>> On 26 July 2016 at 01:12, Alistair Francis
>>> wrote:
The Cadence GEM hardware allows incoming data to be 'screened
On 26.07.2016 19:18, Halil Pasic wrote:
>
>
> On 07/26/2016 05:42 PM, Max Reitz wrote:
>>> +++ b/block/raw-posix.c
@@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict
*options,
s->fd = -1;
fd = qemu_open(filename, s->open_flags, 0644);
On 26.07.2016 19:18, Halil Pasic wrote:
>
>
> On 07/26/2016 05:42 PM, Max Reitz wrote:
>>> +++ b/block/raw-posix.c
@@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict
*options,
s->fd = -1;
fd = qemu_open(filename, s->open_flags, 0644);
Dear Max,
Max Reitz writes:
> We don't guarantee that error_setg_errno() does not modify errno. (In
> practice it should not, but we don't guarantee that.)
I agree it's a good general policy to _not_ rely on the callee
explicitly saving and restoring errno. Especially since C11 pretty much
allo
On 26.07.2016 20:03, Sascha Silbe wrote:
> Dear Max,
>
> Max Reitz writes:
>
>> We don't guarantee that error_setg_errno() does not modify errno. (In
>> practice it should not, but we don't guarantee that.)
>
> I agree it's a good general policy to _not_ rely on the callee
> explicitly saving a
On 07/26/2016 07:34 AM, Halil Pasic wrote:
> Make raw_open for POSIX more consistent in handling errors by setting
> the error object also when qemu_open fails. The error object was set
> generally set in case of errors, but I guess this case was overlooked.
> Do the same for win32.
>
> Signed-o
On 07/26/2016 11:34 AM, Max Reitz wrote:
> On 26.07.2016 14:52, Alberto Garcia wrote:
>> On Fri, Jul 08, 2016 at 05:05:12PM +0300, Alberto Garcia wrote:
>>> Hi,
>>>
>>> Stefan reported this, this is a regression caused by commit
>>> efaa7c4eeb7490c6f37f3.
>>>
>>> I sent a separate series for the
The sysbus_init_irq() call will eventually depend on a property so it needs to
be in the realize function.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
V2:
- Update commit message
hw/net/cadence_gem.c | 28 +---
1 file changed, 17 insertions(+), 11 de
This patch series adds initial priority queue support to the Cadence GEM
device. This is based on original work by Peter C, that has been ported
to the latest version of QEMU.
There is more GEM work that I'd like to upstream after this, but I
figured this a good place to start. I have done limite
Signed-off-by: Alistair Francis
---
There is a indentation error in this patch in the gem_transmit function.
I have written it like that to make it easier to see the changes. It is
fixed in the next patch.
V3:
-Fix up number of queues logic
- Fixup vmstate version
V2:
- Use the new screening
Set the ZynqMP number of priority queues to 2.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
hw/arm/xlnx-zynqmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index 23c7199..0d86ba3 100644
--- a/hw/arm/xlnx-zynqmp.c
+++ b/hw
The Cadence GEM hardware supports N number priority queues, this patch is a
step towards that by adding the property to set the queues. At the moment
behaviour doesn't change as we only use queue 0.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
V3:
- Add error checking
V2:
- F
On Mon, Jul 25, 2016 at 11:59:21AM +0200, Igor Mammedov wrote:
> it keeps the legacy behavior for all users that doesn't care
> about stable cpu_index value, but would allow boards that
> would support device_add/device_del to set stable cpu_index
> that won't depend on order in which cpus are crea
Fix up the indentation inside the for loop that was introduced in the previous
patch. This commit is almost empty if viewed using 'git show -w', except for a
few changes that were required to avoid the 80 charecter line limit.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
---
V2:
-
On Mon, Jul 25, 2016 at 11:59:18AM +0200, Igor Mammedov wrote:
[...]
> Igor Mammedov (6):
> exec: reduce CONFIG_USER_ONLY ifdeffenery
> exec: don't use cpu_index to detect if cpu_exec_init()'s been called
> for cpu
> exec: set cpu_index only if it's not been explictly set
> qdev: fix ob
The Cadence GEM hardware allows incoming data to be 'screened' based on some
register values. Add support for these screens.
We also need to increase the max regs to avoid compilation failures. These new
registers are implemented in the next patch.
Signed-off-by: Alistair Francis
---
V3:
- Add
On Sun, Jul 17, 2016 at 07:53:07PM +0300, Marcel Apfelbaum wrote:
>
> v4 -> v5:
> Addressed the pull request issues: (Peter Maydell)
> See: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00882.html
> - cland warning -> "hw/pci/pci.c:196:23: runtime error: shift exponent -1
> is ne
As a general policy, we want callers to save errno
themselves. error_setg_internal() currently goes out of its way to
preserve errno, so with the API documentation not mentioning it either
way, callers might come to rely on the current behaviour of the
implementation. Spell out that we don't want t
Dear Max,
Max Reitz writes:
>> So how about:
>>
>> /*
>> * Just like error_setg(), with @os_error info added to the message.
>> * If @os_error is non-zero, ": " + strerror(os_error) is appended to
>> * the human-readable error message.
>> + *
>> + * Reminder: errno may get clobbered by a
On 07/26/2016 12:44 PM, Sascha Silbe wrote:
> As a general policy, we want callers to save errno
> themselves. error_setg_internal() currently goes out of its way to
> preserve errno, so with the API documentation not mentioning it either
> way, callers might come to rely on the current behaviour o
On Wed, Jun 29, 2016 at 06:32:13PM +0800, Liang Li wrote:
> This patch set contains two parts of changes to the virtio-balloon.
>
> One is the change for speeding up the inflating & deflating process,
> the main idea of this optimization is to use bitmap to send the page
> information to host ins
On Tue, Jul 26, 2016 at 04:16:04PM +0200, Igor Mammedov wrote:
> On Tue, 26 Jul 2016 18:41:22 +0530
> Amit Shah wrote:
>
> > On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote:
> > > > This was flagged by a nightly run of the static checker when this
> > > > series was pulled. On a 'before' tr
From: Swapnil Bokade
Adds following instructions:
vcmpnezb[.]: Vector Compare Not Equal or Zero Byte
vcmpnezh[.]: Vector Compare Not Equal or Zero Halfword
vcmpnezw[.]: Vector Compare Not Equal or Zero Word
Signed-off-by: Swapnil Bokade
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.
From: Vivek Andrew Sha
vslv: Vector Shift Left Variable
Signed-off-by: Vivek Andrew Sha
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 1 +
target-ppc/int_helper.c | 14 ++
target-ppc/translate.c | 2 ++
3 files changed, 17 insertions(+)
diff --git a/target-ppc
From: Sandipan Das
DFP Test Significance Immediate [Quad]
Signed-off-by: Sandipan Das
Signed-off-by: Nikunj A Dadhania
---
target-ppc/dfp_helper.c | 35 +++
target-ppc/helper.h | 2 ++
target-ppc/translate.c | 22 ++
3 files changed, 5
This series contains 11 new instructions for POWER9 described in ISA3.0.
Patches:
01: dtstsfi[q]: DFP Test Significance Immediate [Quad]
02: vabsdub : Vector Absolute Difference Unsigned Byte
vabsduh : Vector Absolute Difference Unsigned Halfword
vabsduw : Vec
From: Vivek Andrew Sha
Adds Vector Shift Right Variable instruction.
Signed-off-by: Vivek Andrew Sha
Signed-off-by: Nikunj A Dadhania
---
target-ppc/helper.h | 1 +
target-ppc/int_helper.c | 17 +
target-ppc/translate.c | 2 ++
3 files changed, 20 insertions(+)
diff --
From: Sandipan Das
Adds following instructions:
vabsdub: Vector Absolute Difference Unsigned Byte
vabsduh: Vector Absolute Difference Unsigned Halfword
vabsduw: Vector Absolute Difference Unsigned Word
Signed-off-by: Sandipan Das
[ use ISA300 define and abs() ]
Signed-off-by: Nikunj A Dadhania
extswsli : Extend Sign Word & Shift Left Immediate
Signed-off-by: Nikunj A Dadhania
---
target-ppc/translate.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 3382cd0..0a1b750 100644
--- a/target-ppc/transl
On Fri, Jul 22, 2016 at 01:01:10AM +0200, Greg Kurz wrote:
> As suggested by Eduardo, this series split the error handling of global
> properties in two separate patches.
Reviewed-by: Eduardo Habkost
Applied to machine-next, thanks.
--
Eduardo
QEMU emulator version 2.6.0 (Debian 1:2.6+dfsg-3), Copyright (c)
2003-2008 Fabrice Bellard
qemu-system-ppc64 --enable-kvm -M pseries -cpu host -m 3G -cdrom Fedora-
Server-dvd-ppc64-24-1.2.iso
Fedora 24 Server
--
You received this bug notification because you are a member of qemu-
devel-ml, whic
** Attachment added: "Screenshot showing problem is also present in kernel
framebuffer mode"
https://bugs.launchpad.net/qemu/+bug/1546680/+attachment/4707706/+files/centos-big-endian-display-color-problem-kernel-framebuffer-fedora-24.png
--
You received this bug notification because you are
From: Prasanna Kumar Kalever
1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/
2. rearrange the versioning
3. s/server description/servers description/
Signed-off-by: Prasanna Kumar Kalever
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
Message-Id: <1469198048-8535
The following changes since commit f49ee630d73729ecaeecf4b38a8df11bc613914d:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160726' into
staging (2016-07-26 11:53:47 +0100)
are available in the git repository at:
g...@github.com:codyprime/qemu-kvm-jtc.git tags/
From: Vladimir Sementsov-Ogievskiy
Mirror can do up to 16 in-flight requests, but actually on full copy
(the whole source disk is non-zero) in-flight is always 1. This happens
as the request is not limited in size: the data occupies maximum available
capacity of s->buf.
The patch limits the size
Update the build flags appropriately for FreeBSD and add the
correct LD_EMULATION type for the FreeBSD build case.
Fixes FreeBSD build error:
ld: unrecognised emulation mode: elf_i386
Supported emulations: elf_x86_64_fbsd elf_i386_fbsd
gmake[1]: *** [Makefile:51: linuxboot_
On 07/26/16 03:32, Paolo Bonzini wrote:
>
>> Update the build flags appropriately for FreeBSD and add the correct
>> LD_EMULATION type for the FreeBSD build case.
>>
>> Signed-off-by: Sean Bruno
>
> I posted the right fix a couple days ago, but didn't manage to send a pull
> request before le
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
hw/net/vhost_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index f92d3f8..3677a82 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -313,7 +313,7 @@ int vho
From: Marc-André Lureau
In some cases, qemu_chr_fe_read_all() on HUP event doesn't raise
CHR_EVENT_CLOSED because the read/recv function returns -1 on
disconnected peers (for example with tch_chr_recv, an ECONNRESET errno
overwritten as EIO).
It is simpler to explicitely disconnect on HUP, risin
From: Marc-André Lureau
Although not strictly required, it is nice to have vhost_log_put()
safely callable multiple times.
Clear dev->log* when calling vhost_log_put() to make the function
idempotent. This also simplifies a bit the caller work.
Signed-off-by: Marc-André Lureau
---
hw/virtio/v
From: Marc-André Lureau
If vhost_dev_init() failed, caller may still call vhost_dev_cleanup()
later. However, vhost_dev_cleanup() tries to remove the device from the
list even if it wasn't yet added, which may lead to crashes. Similarly
for the memory listener.
Signed-off-by: Marc-André Lureau
From: Marc-André Lureau
Make sure the log was released on cleanup, or it will leak (the
alternative is to call vhost_log_put() unconditionally, but it may hide
some dev state issues).
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/
From: Marc-André Lureau
Hi,
Since 'vhost-user: simple reconnection support' has been merged, it is
possible to disconnect and reconnect a vhost-user backend. However,
many code paths in qemu may trigger assert() when the backend is
disconnected.
There are also code paths that are wrong, see "do
From: Marc-André Lureau
vhost_net_init() calls vhost_dev_init() and in case of failure, calls
vhost_dev_cleanup() directly. However, the structure is already
partially cleaned on error. Calling vhost_dev_cleanup() again will call
vhost_virtqueue_cleanup() on already clean queues, and causing pote
From: Marc-André Lureau
vhost-dev opaque isn't necessarily an fd, it can be a chardev when using
vhost-user. Goto fail, so vhost_backend_cleanup() is called to handle
backend cleanup appropriately.
vhost_set_backend_type() should never fail, use an assert().
Signed-off-by: Marc-André Lureau
--
From: Marc-André Lureau
Shorten the code and make it more clear by using the specialized
function g_str_has_prefix().
Signed-off-by: Marc-André Lureau
---
net/vhost-user.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index c4d63e0..2
From: Marc-André Lureau
Add missing VHOST_OPS_DEBUG() logs, for completeness.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 1ece1ef..5a29eb3 100644
--- a/
From: Marc-André Lureau
It is fine to call set_msgfds() with 0 fd, and ensures any previous fd
array is cleared.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-user.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
in
From: Marc-André Lureau
It is called on multiple code path, so make it safe to call several
times (note: I don't remember a reproducer here, but a function called
'cleanup' should probably be idempotent in my book)
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost.c | 7 ++-
1 file chan
From: Marc-André Lureau
Calling a vhost operation may fail, for example with disconnected
vhost-user backend, but qemu shouldn't abort in this case.
Log an error instead, except on error and cleanup code paths where it
can be mostly ignored.
Let's use a VHOST_OPS_DEBUG macro to easily disable t
From: Marc-André Lureau
Calling qemu_chr_fe_set_msgfds() on unconnected socket leads to crash
since s->ioc is NULL in this case. Return an error earlier instead.
Signed-off-by: Marc-André Lureau
---
qemu-char.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/qemu
From: Marc-André Lureau
vhost_dev_init(), calling vhost backend initialization, should be
cleaned up after failure too. Call vhost_dev_cleanup() in all failure
cases. First, it needs to zero-alloc the struct to avoid the initial
garbage.
Signed-off-by: Marc-André Lureau
---
hw/net/vhost_net.c
From: Marc-André Lureau
All these functions must be called only after the backend is connected.
They are called from virtio-net.c, after either virtio or link status
change.
The check for nc->peer->link_down should ensure vhost_net_{start,stop}()
are always called between vhost_user_{start,stop}
From: Marc-André Lureau
The vhost-user code is quite inconsistent with error handling. Instead
of ignoring some return values of read/write and silently going on with
invalid state (invalid read for example), break the code flow when the
error happened.
Signed-off-by: Marc-André Lureau
---
hw/
From: Marc-André Lureau
Let's use qemu proper error reporting API, this ensures the error is
reported at the right place (stderr or monitor), with a conventional
format.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost.c | 19 +--
1 file changed, 9 insertions(+), 10 deletio
From: Marc-André Lureau
The chardev waits for an initial connection before starting qemu, and
vhost-user should wait for the backend negotiation to be completed
before starting qemu too.
vhost-user is started in the net_vhost_user_event callback, which is
synchronously called after the socket is
From: Marc-André Lureau
Check qemu_chr_fe_set_msgfds() for errors, to make sure the message to
be sent is correct.
Signed-off-by: Marc-André Lureau
---
hw/virtio/vhost-user.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
From: Marc-André Lureau
Either the callback is mandatory to implement, in which case an assert()
is more appropriate, or it's not and we can't tell much whether the
function should fail or not (given it's name, I guess it should silently
success by default). Instead, make the implementation manda
From: Marc-André Lureau
Many code paths assume get_vhost_net() returns non-null.
Keep VhostUserState.vhost_net after a successful vhost_net_init(),
instead of freeing it in vhost_net_cleanup().
VhostUserState.vhost_net is thus freed before after being recreated or
on final vhost_user_cleanup()
From: Marc-André Lureau
Add a few assertions to be more explicit about the runtime behaviour
after the previous patch: get_vhost_net() is non-null after
net_vhost_user_init().
Signed-off-by: Marc-André Lureau
---
hw/net/vhost_net.c | 1 +
net/vhost-user.c | 2 ++
2 files changed, 3 insertion
From: Marc-André Lureau
Now that get_vhost_net() returns non-null after a successful
vhost_net_init(), we no longer need to check this case.
This reverts commit ecd34898596c60f79886061618dd7e01001113ad.
Signed-off-by: Marc-André Lureau
---
hw/net/vhost_net.c | 7 +--
1 file changed, 1 ins
From: Marc-André Lureau
A function to wait on the backend to be connected, to be used in the
following patches.
Signed-off-by: Marc-André Lureau
---
include/sysemu/char.h | 8
qemu-char.c | 9 +
2 files changed, 17 insertions(+)
diff --git a/include/sysemu/char.h b/
From: Marc-André Lureau
This test just checks that 2 virtio-net queues can be setup over
vhost-user and waits for them to be started.
Signed-off-by: Marc-André Lureau
---
tests/Makefile.include | 2 +-
tests/vhost-user-test.c | 108 +++-
2 files c
From: Marc-André Lureau
Spotted by valgrind.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 46d0588..27b10c1 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-tes
From: Marc-André Lureau
Add a chr_wait_connected for the tcp backend, and use it in the
open_socket() function.
Signed-off-by: Marc-André Lureau
---
qemu-char.c | 63 ++---
1 file changed, 44 insertions(+), 19 deletions(-)
diff --git a/q
101 - 200 of 317 matches
Mail list logo
