Re: [Qemu-devel] [PATCH v5 04/10] block: Support meta dirty bitmap

2016-07-18 Thread Fam Zheng
On Fri, 07/15 14:10, Max Reitz wrote: > > I just remembered that it's very much justified now, as you have only > recently adopted this series. > > It's just always funny to get a “What are you talking about?” reply to > some nagging I sent out long enough in the past that I can't even > remember

Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes()

2016-07-18 Thread Peter Lieven
Am 15.07.2016 um 17:40 schrieb Eric Blake: On 07/15/2016 04:09 AM, Peter Lieven wrote: Am 05.07.2016 um 17:09 schrieb Paolo Bonzini: On 05/07/2016 16:59, Eric Blake wrote: And yes, we could probably switch to (potentially slower) / % * instead of bit operations in block/io.c to accommodate a n

Re: [Qemu-devel] [Qemu-block] [PATCH] AioContext: correct comments

2016-07-18 Thread Fam Zheng
On Fri, 07/15 14:57, Max Reitz wrote: > On 15.07.2016 11:44, Cao jin wrote: > > Correct comments of field notify_me > > > > Cc: Kevin Wolf > > Cc: Max Reitz > > Signed-off-by: Cao jin > > --- > > include/block/aio.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

[Qemu-devel] [PATCH] MAINTAINERS: Add include/block/aio.h to block I/O path section

2016-07-18 Thread Fam Zheng
This file is actually the header for async.c and aio-*.c., so add it to the same section. Suggested-by: Max Reitz Signed-off-by: Fam Zheng --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d0e2c3..83e0f13 100644 --- a/MAINTAINERS +++ b/MAINTAIN

Re: [Qemu-devel] QOM: best way for parents to pass information to children? (was Re: [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties)

2016-07-18 Thread Igor Mammedov
On Fri, 15 Jul 2016 18:33:53 -0300 Eduardo Habkost wrote: > On Fri, Jul 15, 2016 at 08:38:35PM +0200, Igor Mammedov wrote: > > On Fri, 15 Jul 2016 14:43:53 -0300 > > Eduardo Habkost wrote: > > > On Fri, Jul 15, 2016 at 06:30:41PM +0200, Andreas Färber wrote: > > > > Am 15.07.2016 um 18:10 sc

Re: [Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

2016-07-18 Thread Igor Mammedov
On Mon, 18 Jul 2016 11:17:25 +1000 David Gibson wrote: > On Sat, Jul 16, 2016 at 12:11:56AM +0200, Greg Kurz wrote: > > On Thu, 14 Jul 2016 21:59:45 +1000 > > David Gibson wrote: > > > > > On Thu, Jul 14, 2016 at 03:50:56PM +0530, Bharata B Rao wrote: > > > > On Thu, Jul 14, 2016 at 3:24 PM

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

2016-07-18 Thread Christian Borntraeger
On 07/18/2016 06:37 AM, Namhyung Kim wrote: Can you do the virtio-mmio and virtio-ccw plumbing as well, or do you need help with that? [...] > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 2b34b43..8281b80 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c

[Qemu-devel] [RFC PATCH V7 0/7] Introduce COLO-compare

2016-07-18 Thread Zhang Chen
COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. The full version in this github: https://github.com/zhangckid/qemu/tree/colo-v2.7-proxy-mode-compare-with-colo-base-jul18 v7: p5: - add [PATCH]qemu-char: Fix contex

[Qemu-devel] [RFC PATCH V7 6/7] colo-compare: introduce packet comparison thread

2016-07-18 Thread Zhang Chen
If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes and secondary packet not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a checkp

[Qemu-devel] [RFC PATCH V7 2/7] colo-base: add colo-base to define and handle packet

2016-07-18 Thread Zhang Chen
COLO-base used by colo-compare and filter-rewriter. this can share common data structure like:net packet, and share other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-base.c| 74

[Qemu-devel] [RFC PATCH V7 5/7] qemu-char: Fix context for g_source_attach()

2016-07-18 Thread Zhang Chen
We want to poll and handle chardev in another thread other than main loop. But qemu_chr_add_handlers() can only work for global default context other than thread default context. So we use g_source_attach(xx, g_main_context_get_thread_default()) replace g_source_attach(xx, NULL) to attach g_source.

[Qemu-devel] [RFC PATCH V7 3/7] Jhash: add linux kernel jhashtable in qemu

2016-07-18 Thread Zhang Chen
Jhash used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 61 1 file changed, 61 insertions(+) create mod

[Qemu-devel] [RFC PATCH V7 1/7] colo-compare: introduce colo compare initialization

2016-07-18 Thread Zhang Chen
This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ | +--

[Qemu-devel] [RFC PATCH V7 4/7] colo-compare: track connection and enqueue packet

2016-07-18 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

[Qemu-devel] [RFC PATCH V7 7/7] colo-compare: add TCP, UDP, ICMP packet comparison

2016-07-18 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 174 +++

Re: [Qemu-devel] [PATCH v4 0/5] fix numa node mapping for hotplugged CPUs

2016-07-18 Thread Igor Mammedov
On Mon, 4 Jul 2016 17:51:14 +0200 Igor Mammedov wrote: Ping, Michael, it seems that series fell through cracks, could you pick it up please? > Changelog: > v3->v4: > - return -1 on failure from numa_get_node_for_cpu() > - replace SRAT table blob in 5/5 with note to maintainer to add it man

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-18 Thread Cornelia Huck
On Mon, 18 Jul 2016 13:37:39 +0900 Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next boot us

Re: [Qemu-devel] [PATCH V4] block/iscsi: allow caching of the allocation map

2016-07-18 Thread Peter Lieven
Am 16.07.2016 um 15:38 schrieb Paolo Bonzini: On 30/06/2016 13:07, Peter Lieven wrote: +static void +iscsi_allocmap_update(IscsiLun *iscsilun, int64_t sector_num, + int nb_sectors, bool allocated, bool valid) { int64_t cluster_num, nb_clusters; -if (iscsilun->al

Re: [Qemu-devel] [PATCH] util: Fix MIN_NON_ZERO

2016-07-18 Thread Peter Lieven
Am 12.07.2016 um 18:24 schrieb Paolo Bonzini: On 12/07/2016 17:54, Eric Blake wrote: On 07/12/2016 12:48 AM, Fam Zheng wrote: MIN_NON_ZERO(0, 1) is evaluated to 0. Rewrite the macro to fix it. Huh? Old expansion, in various stages: (((0) != 0 && (0) < (1)) ? (0) : (1)) ((0 && 1) ? 0 : 1) (0

Re: [Qemu-devel] [PATCH v3 6/6] iscsi: Rely on block layer to break up large requests

2016-07-18 Thread Paolo Bonzini
On 15/07/2016 20:32, Eric Blake wrote: > Now that the block layer honors max_request, we don't need to > bother with an EINVAL on overlarge requests, but can instead > assert that requests are well-behaved. > > Signed-off-by: Eric Blake > Reviewed-by: Fam Zheng > Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v3 5/6] nbd: Drop unused offset parameter

2016-07-18 Thread Paolo Bonzini
On 15/07/2016 20:32, Eric Blake wrote: > Now that NBD relies on the block layer to fragment things, we no > longer need to track an offset argument for which fragment of > a request we are actually servicing. > > While at it, use true and false instead of 0 and 1 for a bool > parameter. > > Sig

Re: [Qemu-devel] [PATCH v3 4/6] nbd: Rely on block layer to break up large requests

2016-07-18 Thread Paolo Bonzini
On 15/07/2016 20:32, Eric Blake wrote: > Now that the block layer will honor max_transfer, we can simplify > our code to rely on that guarantee. > > The readv code can call directly into nbd-client, just as the > writev code has done since commit 52a4650. > > Interestingly enough, while qemu-io

Re: [Qemu-devel] [PATCH V4] block/iscsi: allow caching of the allocation map

2016-07-18 Thread Paolo Bonzini
On 18/07/2016 09:55, Peter Lieven wrote: > Am 16.07.2016 um 15:38 schrieb Paolo Bonzini: >> >> On 30/06/2016 13:07, Peter Lieven wrote: >>> +static void >>> +iscsi_allocmap_update(IscsiLun *iscsilun, int64_t sector_num, >>> + int nb_sectors, bool allocated, bool valid) >>>

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-18 Thread Namhyung Kim
Hello, On Mon, Jul 18, 2016 at 09:54:39AM +0200, Cornelia Huck wrote: > On Mon, 18 Jul 2016 13:37:39 +0900 > Namhyung Kim wrote: > > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > > machine. Users

[Qemu-devel] [PATCH v5 04/16] pc: forbid BSP removal

2016-07-18 Thread Igor Mammedov
Boot CPU is assumed to always present in QEMU code, so untile that assumptions are gone, deny removal request, In another words QEMU won't support BSP hot-unplug. Signed-off-by: Igor Mammedov --- v5: - s/1st CPU (BSP)/Boot CPU/ Eduardo Habkost - intialize idx to -1 and assert on it,

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

2016-07-18 Thread Namhyung Kim
Hello, On Mon, Jul 18, 2016 at 09:28:42AM +0200, Christian Borntraeger wrote: > On 07/18/2016 06:37 AM, Namhyung Kim wrote: > > Can you do the virtio-mmio and virtio-ccw plumbing as well, or > do you need help with that? Any help would be greatly appreciated! Thanks, Namhyung > > [...] > > d

[Qemu-devel] [PATCH v5 05/16] pc: enforce adding CPUs contiguously and removing them in opposit order

2016-07-18 Thread Igor Mammedov
it will still allow us to use cpu_index as migration instance_id since when CPUs are added contiguously (from the first to the last) and removed in opposite order, cpu_index stays stable and it's reproducable on destination side. While there is work in progress to support migration when there are

Re: [Qemu-devel] [RFC PATCH V7 6/7] colo-compare: introduce packet comparison thread

2016-07-18 Thread Daniel P. Berrange
On Mon, Jul 18, 2016 at 03:40:49PM +0800, Zhang Chen wrote: > If primary packet is same with secondary packet, > we will send primary packet and drop secondary > packet, otherwise notify COLO frame to do checkpoint. > If primary packet comes and secondary packet not, > after REGULAR_PACKET_CHECK_MS

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-18 Thread T. Huth
In the title, you talk about PPC, but in the bug description, you talk about i386 ... quite confusing, please try to be consistent. But since you say that you run into this problem with all machine types, this sounds like a configuration problem to me. Can you please specify how you run the conf

Re: [Qemu-devel] [RFC PATCH V7 5/7] qemu-char: Fix context for g_source_attach()

2016-07-18 Thread Daniel P. Berrange
On Mon, Jul 18, 2016 at 03:40:48PM +0800, Zhang Chen wrote: > We want to poll and handle chardev in another thread > other than main loop. But qemu_chr_add_handlers() can only > work for global default context other than thread default context. > So we use g_source_attach(xx, g_main_context_get_thr

[Qemu-devel] A question about 9894dc0cdcc397ee5b26370bc53da6d360a363c2

2016-07-18 Thread Gonglei (Arei)
Hi Daniel & Paolo, Commit 9894dc0c "char: convert from GIOChannel to QIOChannel", about the below code segment: static bool qemu_chr_open_socket_fd(CharDriverState *chr, Error **errp) { TCPCharDriver *s = chr->opaque; -int fd; +QIOChannelSocket *sioc = qio_channel_socket_new();

[Qemu-devel] [Bug 1581796] Re: console-gl.c:96:surface_gl_create_texture:code should not be reached

2016-07-18 Thread T. Huth
Sorry, I didn't quite get your question ... do you want to see the patch included in the 2.5 stable branch (i.e. included in version 2.5.2)? Or do you have a problem applying the patch on top of 2.5.1 on your own? -- You received this bug notification because you are a member of qemu- devel-ml, w

[Qemu-devel] [PATCH V5 1/2] block/iscsi: fix rounding in iscsi_allocationmap_set

2016-07-18 Thread Peter Lieven
when setting clusters as alloacted the boundaries have to be expanded. As Paolo pointed out the calculation of the number of clusters is wrong: Suppose cluster_sectors is 2, sector_num = 1, nb_sectors = 6: In the "mark allocated" case, you want to set 0..8, i.e. cluster_num=0, nb_clusters=4.

[Qemu-devel] [PATCH V5 2/2] block/iscsi: allow caching of the allocation map

2016-07-18 Thread Peter Lieven
until now the allocation map was used only as a hint if a cluster is allocated or not. If a block was not allocated (or Qemu had no info about the allocation status) a get_block_status call was issued to check the allocation status and possibly avoid a subsequent read of unallocated sectors. If a b

[Qemu-devel] [PATCH V5 0/2] block/iscsi: allow caching of the allocation map

2016-07-18 Thread Peter Lieven
until now the allocation map was used only as a hint if a cluster is allocated or not. If a block was not allocated (or Qemu had no info about the allocation status) a get_block_status call was issued to check the allocation status and possibly avoid a subsequent read of unallocated sectors. If a b

Re: [Qemu-devel] [PATCH v19 3/5] block/gluster: remove rdma transport

2016-07-18 Thread Markus Armbruster
Prasanna Kumar Kalever writes: > gluster volfile server fetch happens through unix and/or tcp, it doesn't > support volfile fetch over rdma, hence removing the dead code > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 35 +-- > 1 file changed,

Re: [Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

2016-07-18 Thread Greg Kurz
On Mon, 18 Jul 2016 11:17:25 +1000 David Gibson wrote: > On Sat, Jul 16, 2016 at 12:11:56AM +0200, Greg Kurz wrote: > > On Thu, 14 Jul 2016 21:59:45 +1000 > > David Gibson wrote: > > > > > On Thu, Jul 14, 2016 at 03:50:56PM +0530, Bharata B Rao wrote: > > > > On Thu, Jul 14, 2016 at 3:24 PM

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Greg Kurz
On Mon, 18 Jul 2016 10:52:36 +1000 David Gibson wrote: > On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: > > Commit 86b50f2e1bef ("Disable huge page support if it is not available > > for main RAM") already made sure that huge page support is not announced > > to the guest if the nor

Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-18 Thread Cornelia Huck
On Mon, 18 Jul 2016 17:29:55 +0900 Namhyung Kim wrote: > On Mon, Jul 18, 2016 at 09:54:39AM +0200, Cornelia Huck wrote: > > On Mon, 18 Jul 2016 13:37:39 +0900 > > Namhyung Kim wrote: > > > +#define VIRT_PSTORE_ORDER2 > > > +#define VIRT_PSTORE_BUFSIZE (4096 << VIRT_PSTORE_ORDER) > > > > I

Re: [Qemu-devel] [PULL 1/1] Add optionrom compatible with fw_cfg DMA version

2016-07-18 Thread Paolo Bonzini
On 15/07/2016 15:26, Stefan Hajnoczi wrote: >> pc-bios/linuxboot_dma.bin | Bin 0 -> 1024 bytes >> pc-bios/optionrom/Makefile| 42 -- >> pc-bios/optionrom/code16gcc.h | 3 + >> pc-bios/optionrom/linuxboot_dma.c | 294 >> ++ >> 10 fi

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Thomas Huth
On 18.07.2016 10:59, Greg Kurz wrote: > On Mon, 18 Jul 2016 10:52:36 +1000 > David Gibson wrote: > >> On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: >>> Commit 86b50f2e1bef ("Disable huge page support if it is not available >>> for main RAM") already made sure that huge page support

Re: [Qemu-devel] A question about 9894dc0cdcc397ee5b26370bc53da6d360a363c2

2016-07-18 Thread Daniel P. Berrange
On Mon, Jul 18, 2016 at 08:41:32AM +, Gonglei (Arei) wrote: > Hi Daniel & Paolo, > > Commit 9894dc0c "char: convert from GIOChannel to QIOChannel", > about the below code segment: > > static bool qemu_chr_open_socket_fd(CharDriverState *chr, Error **errp) > { > TCPCharDriver *s = chr->

Re: [Qemu-devel] [PATCH V5 2/2] block/iscsi: allow caching of the allocation map

2016-07-18 Thread Paolo Bonzini
On 18/07/2016 10:52, Peter Lieven wrote: > +/* shrink to touch only completely contained clusters */ > +cl_num_shrinked = DIV_ROUND_UP(sector_num, iscsilun->cluster_sectors); > +nb_cls_shrinked = (sector_num + nb_sectors) / iscsilun->cluster_sectors > + - cl_num_s

[Qemu-devel] [RFC 2/2] qmp: Implement cpu-add in terms of query-hotpluggable-cpus when available

2016-07-18 Thread David Gibson
We've recently added a new device_add based cpu hotplug implementation, with the spapr machine type being the first user. In order to overcome the limitations of the old cpu_add interface, it works very differently. That's going to require a new interface in libvirt to properly use the new interf

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-18 Thread luigiburdo
Hi T, yes it is the emulated i386 machine qemu-system-i386 and it was working since something change in 2.6. but issue is present in ppc machine too. dint try the kvm because on ppcemb there is not vga output. I had try the 2.5.1 and build and work and confirmed the issue is present only in 2.6

[Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list

2016-07-18 Thread David Gibson
The spapr implementation of query-hotpluggable-cpus builds the list of hotpluggable cores from the end (most removed from the list head) because that's the easiest way with a singly linked list. Because it also traverses the possible CPU cores starting from low indexes the resulting list has the c

Re: [Qemu-devel] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Thomas Huth
On 15.07.2016 11:28, Greg Kurz wrote: > On Fri, 15 Jul 2016 10:10:25 +0200 > Thomas Huth wrote: > >> Commit 86b50f2e1bef ("Disable huge page support if it is not available >> for main RAM") already made sure that huge page support is not announced >> to the guest if the normal RAM of non-NUMA con

[Qemu-devel] [RFC 0/2] cpu-add compatibility for query-hotpluggable-cpus implementations

2016-07-18 Thread David Gibson
I'm not entirely sure if this is a good idea, and if it is whether this is a good approach to it. But I'd like to discuss it and see if anyone has better ideas. As you may know we've hit a bunch of complications with cpu_index which will impose some limitations with what we can do with the new qu

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Greg Kurz
On Mon, 18 Jul 2016 11:04:39 +0200 Thomas Huth wrote: > On 18.07.2016 10:59, Greg Kurz wrote: > > On Mon, 18 Jul 2016 10:52:36 +1000 > > David Gibson wrote: > > > >> On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: > >>> Commit 86b50f2e1bef ("Disable huge page support if it is n

[Qemu-devel] [PULL 01/23] use g_path_get_dirname instead of dirname

2016-07-18 Thread Paolo Bonzini
From: Wei Jiangang Use g_path_get_basename to get the directory components of a file name, and free its return when no longer needed. Signed-off-by: Wei Jiangang Message-Id: <1459997185-15669-3-git-send-email-weijg.f...@cn.fujitsu.com> Signed-off-by: Paolo Bonzini --- os-posix.c | 3 +

[Qemu-devel] [PULL 08/23] cpu-exec: Move down some declarations in cpu_exec()

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov This will fix a compiler warning with -Wclobbered: http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg03347.html Reported-by: Stefan Weil Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Message-Id: <20160715193123.28113-1-sergey.fedo...@linaro.org> Si

[Qemu-devel] [Bug 1581796] Re: console-gl.c:96:surface_gl_create_texture:code should not be reached

2016-07-18 Thread luigiburdo
i think the best will be it included in the stable branch for have a full working qemu options -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581796 Title: console-gl.c:96:surface_gl_create_texture

[Qemu-devel] [PULL 00/23] TCG and misc patches for 2.7 hard freeze from 2016-07-18

2016-07-18 Thread Paolo Bonzini
The following changes since commit 6b92bbfe812746fe7841a24c24e6460f5359ce72: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' into staging (2016-07-15 16:56:08 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for yo

[Qemu-devel] [PULL 03/23] hw/i386: add device tree support

2016-07-18 Thread Paolo Bonzini
From: Antonio Borneo With "-dtb" on command-line: - append the device tree blob to the kernel image; - pass the blob's pointer to the kernel through setup_data, as requested by upstream kernel commit da6b737b9ab7 ("x86: Add device tree support"). The device tree blob is passed as-is to the g

[Qemu-devel] [PULL 14/23] tcg: Introduce tb_mark_invalid() and tb_is_invalid()

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov These functions will be used to make translation block invalidation safe with concurrent lockless lookup in the global hash table. Most targets don't use 'cs_base'; so marking TB as invalid is as simple as assigning -1 to 'cs_base'. SPARC target stores the next program count

[Qemu-devel] [PULL 04/23] compiler: never omit assertions if using a static analysis tool

2016-07-18 Thread Paolo Bonzini
Assertions help both Coverity and the clang static analyzer avoid false positives, but on the other hand both are confused when the condition is compiled as (void)(x != FOO). Always expand assertion macros when using Coverity or clang, through a new QEMU_STATIC_ANALYSIS preprocessor symbol. This

[Qemu-devel] [PULL 12/23] tcg: Prepare safe access to tb_flushed out of tb_lock

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov Ensure atomicity and ordering of CPU's 'tb_flushed' access for future translation block lookup out of 'tb_lock'. This field can only be touched from another thread by tb_flush() in user mode emulation. So the only access to be sequential atomic is: * a single write in tb_fl

[Qemu-devel] [PULL 07/23] exec: avoid realloc in phys_map_node_reserve

2016-07-18 Thread Paolo Bonzini
From: Peter Lieven this is the first step in reducing the brk heap fragmentation created by the map->nodes memory allocation. Since the introduction of RCU the freeing of the PhysPageMaps is delayed so that sometimes several hundred are allocated at the same time. Even worse the memory for map->

[Qemu-devel] [PULL 21/23] Move README to markdown

2016-07-18 Thread Paolo Bonzini
From: Pranith Kumar Move the README file to markdown so that it makes the github page look prettier. I know that github repo is a mirror and not the official repo, but I think it doesn't hurt to have it in markdown format. Signed-off-by: Pranith Kumar Message-Id: <20160715043111.29007-1-bobby.p

[Qemu-devel] [PULL 05/23] megasas: remove useless check for cmd->frame

2016-07-18 Thread Paolo Bonzini
megasas_enqueue_frame always returns with non-NULL cmd->frame. Remove the "else" part as it is dead code. Signed-off-by: Paolo Bonzini --- hw/scsi/megasas.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 52a4123..e968302 10064

[Qemu-devel] [PULL 11/23] tcg: Prepare safe tb_jmp_cache lookup out of tb_lock

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov Ensure atomicity of CPU's 'tb_jmp_cache' access for future translation block lookup out of 'tb_lock'. Note that this patch does *not* make CPU's TLB invalidation safe if it is done from some other thread while the CPU is in its execution loop. Signed-off-by: Alex Bennée Si

[Qemu-devel] [PULL 13/23] target-i386: Remove redundant HF_SOFTMMU_MASK

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov 'HF_SOFTMMU_MASK' is only set when 'CONFIG_SOFTMMU' is defined. So there's no need in this flag: test 'CONFIG_SOFTMMU' instead. Suggested-by: Paolo Bonzini Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Message-Id: <20160715175852.30

[Qemu-devel] [PULL 06/23] checkpatch: consider git extended headers valid patches

2016-07-18 Thread Paolo Bonzini
From: Stefan Hajnoczi Renames look like this with git-diff(1) when diff.renames = true is set: diff --git a/a b/b similarity index 100% rename from a rename to b This raises the "Does not appear to be a unified-diff format patch" error because checkpatch.pl only considers a diff valid i

[Qemu-devel] [PULL 17/23] tcg: cpu-exec: remove tb_lock from the hot-path

2016-07-18 Thread Paolo Bonzini
From: Alex Bennée Lock contention in the hot path of moving between existing patched TranslationBlocks is the main drag in multithreaded performance. This patch pushes the tb_lock() usage down to the two places that really need it: - code generation (tb_gen_code) - jump patching (tb_add_jump

[Qemu-devel] [PULL 16/23] tcg: set up tb->page_addr before insertion

2016-07-18 Thread Paolo Bonzini
From: Alex Bennée This ensures that if we find the TB on the slow path that tb->page_addr is correctly set before being tested. Signed-off-by: Alex Bennée Reviewed-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Message-Id: <20160715175852.30749-9-sergey.fedo...@linaro.org> Signed-off-by: Pa

[Qemu-devel] [PULL 02/23] Changed malloc to g_malloc, free to g_free in bsd-user/qemu.h

2016-07-18 Thread Paolo Bonzini
From: Md Haris Iqbal Signed-off-by: Md Haris Iqbal Message-Id: <1459861743-4514-1-git-send-email-haris.p...@gmail.com> Reviewed-by: Sean Bruno Signed-off-by: Paolo Bonzini --- bsd-user/qemu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qe

[Qemu-devel] [PULL 19/23] tcg: Merge tb_find_slow() and tb_find_fast()

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov These functions are not too big and can be merged together. This makes locking scheme more clear and easier to follow. Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Message-Id: <20160715175852.30749-12-sergey.fedo...@linaro.org> Sign

[Qemu-devel] [PULL 18/23] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump()

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Sergey Fedorov Reviewed-by: Alex Bennée Message-Id: <20160715175852.30749-11-sergey.fedo...@linaro.org> Signed-off-by: Paolo Bonzini --- cpu-exec.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PULL 09/23] util/qht: Document memory ordering assumptions

2016-07-18 Thread Paolo Bonzini
It is naturally expected that some memory ordering should be provided around qht_insert() and qht_lookup(). Document these assumptions in the header file and put some comments in the source to denote how that memory ordering requirements are fulfilled. Signed-off-by: Paolo Bonzini [Sergey Fedorov

[Qemu-devel] [PULL 23/23] block/iscsi: allow caching of the allocation map

2016-07-18 Thread Paolo Bonzini
From: Peter Lieven until now the allocation map was used only as a hint if a cluster is allocated or not. If a block was not allocated (or Qemu had no info about the allocation status) a get_block_status call was issued to check the allocation status and possibly avoid a subsequent read of unallo

[Qemu-devel] [PULL 20/23] tcg: rename tb_find_physical()

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov In fact, this function does not exactly perform a lookup by physical address as it is descibed for comment on get_page_addr_code(). Thus it may be a bit confusing to have "physical" in it's name. So rename it to tb_htable_lookup() to better reflect its actual functionality.

[Qemu-devel] [PULL 10/23] tcg: Pass last_tb by value to tb_find_fast()

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov This is a small clean up. tb_find_fast() is a final consumer of this variable so no need to pass it by reference. 'last_tb' is always updated by subsequent cpu_loop_exec_tb() in cpu_exec(). This change also simplifies calling cpu_exec_nocache() in cpu_handle_exception(). Si

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Thomas Huth
On 18.07.2016 11:26, Greg Kurz wrote: > On Mon, 18 Jul 2016 11:04:39 +0200 > Thomas Huth wrote: > >> On 18.07.2016 10:59, Greg Kurz wrote: >>> On Mon, 18 Jul 2016 10:52:36 +1000 >>> David Gibson wrote: >>> On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: > Commit 86b50f

[Qemu-devel] [PULL 22/23] block/iscsi: fix rounding in iscsi_allocationmap_set

2016-07-18 Thread Paolo Bonzini
From: Peter Lieven when setting clusters as alloacted the boundaries have to be expanded. As Paolo pointed out the calculation of the number of clusters is wrong: Suppose cluster_sectors is 2, sector_num = 1, nb_sectors = 6: In the "mark allocated" case, you want to set 0..8, i.e. cluster_num=0

[Qemu-devel] [PULL 15/23] tcg: Prepare TB invalidation for lockless TB lookup

2016-07-18 Thread Paolo Bonzini
From: Sergey Fedorov When invalidating a translation block, set an invalid CPU state into the TranslationBlock structure first. As soon as the TB is marked with an invalid CPU state, there is no need to remove it from CPU's 'tb_jmp_cache'. However it will be necessary to recheck whether the targ

Re: [Qemu-devel] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Greg Kurz
On Mon, 18 Jul 2016 11:21:41 +0200 Thomas Huth wrote: > On 15.07.2016 11:28, Greg Kurz wrote: > > On Fri, 15 Jul 2016 10:10:25 +0200 > > Thomas Huth wrote: > > > >> Commit 86b50f2e1bef ("Disable huge page support if it is not available > >> for main RAM") already made sure that huge page supp

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread David Gibson
On Mon, Jul 18, 2016 at 10:59:44AM +0200, Greg Kurz wrote: > On Mon, 18 Jul 2016 10:52:36 +1000 > David Gibson wrote: > > > On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: > > > Commit 86b50f2e1bef ("Disable huge page support if it is not available > > > for main RAM") already made s

Re: [Qemu-devel] [PATCH v19 4/5] block/gluster: using new qapi schema

2016-07-18 Thread Markus Armbruster
Prasanna Kumar Kalever writes: > this patch adds 'GlusterServer' related schema in qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 111 > +-- > qapi/block-core.json | 94 +

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2016-07-18 Thread Peter Maydell
On 15 July 2016 at 16:10, Mark Cave-Ayland wrote: > Hi Peter, > > Now the repository switch has been completed, here are the OpenBIOS image > updates for 2.7. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 14c7d99333e4a474c65bdae6f99aa8837e8078e6: > > Merge remote-tra

Re: [Qemu-devel] [PATCH 2/3] qemu: Implement virtio-pstore device

2016-07-18 Thread Stefan Hajnoczi
On Mon, Jul 18, 2016 at 01:37:40PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > Add virtio pstore device to allow kernel log files saved on the host. > It will save the log files on the directory given by pstore device > option. > > $ qemu-system-x86_64 -device virtio-pstore,directory=d

Re: [Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

2016-07-18 Thread David Gibson
On Mon, Jul 18, 2016 at 10:52:39AM +0200, Greg Kurz wrote: > On Mon, 18 Jul 2016 11:17:25 +1000 > David Gibson wrote: > > > On Sat, Jul 16, 2016 at 12:11:56AM +0200, Greg Kurz wrote: > > > On Thu, 14 Jul 2016 21:59:45 +1000 > > > David Gibson wrote: > > > > > > > On Thu, Jul 14, 2016 at 03:50

Re: [Qemu-devel] [RFC 2/2] linux-user: Fix cpu_index generation

2016-07-18 Thread David Gibson
On Mon, Jul 18, 2016 at 09:25:58AM +0200, Igor Mammedov wrote: > On Mon, 18 Jul 2016 11:17:25 +1000 > David Gibson wrote: > > > On Sat, Jul 16, 2016 at 12:11:56AM +0200, Greg Kurz wrote: > > > On Thu, 14 Jul 2016 21:59:45 +1000 > > > David Gibson wrote: > > > > > > > On Thu, Jul 14, 2016 at 0

[Qemu-devel] [PATCH v2] qemu-img: add the 'dd' subcommand

2016-07-18 Thread Reda Sallahi
This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The image format must be specified with -O for

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Greg Kurz
On Mon, 18 Jul 2016 19:21:08 +1000 David Gibson wrote: > On Mon, Jul 18, 2016 at 10:59:44AM +0200, Greg Kurz wrote: > > On Mon, 18 Jul 2016 10:52:36 +1000 > > David Gibson wrote: > > > > > On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: > > > > Commit 86b50f2e1bef ("Disable hug

Re: [Qemu-devel] [PATCH v2 0/2] Add a test for serial output (and sort tests by architecture in the Makefile)

2016-07-18 Thread David Gibson
On Fri, Jul 15, 2016 at 05:39:37PM +0200, Thomas Huth wrote: > Since some of the machines that we support in QEMU sometimes get > broken by other changes, and it then takes a while 'till somebody > notices the breakage, it would be nice to get some more automatic > test coverage for various machine

Re: [Qemu-devel] [PATCH v19 5/5] block/gluster: add support for multiple gluster servers

2016-07-18 Thread Markus Armbruster
Prasanna Kumar Kalever writes: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currently VM Image on gluster volume is specified like this: > > file=gluster[+tcp]://host[:port

Re: [Qemu-devel] [PULL 0/4] Block patches

2016-07-18 Thread Peter Maydell
On 15 July 2016 at 18:59, Stefan Hajnoczi wrote: > The following changes since commit 14c7d99333e4a474c65bdae6f99aa8837e8078e6: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160714' into staging (2016-07-14 > 17:32:53 +0100) > > are available in the git repository

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

2016-07-18 Thread Greg Kurz
On Mon, 18 Jul 2016 11:33:16 +0200 Thomas Huth wrote: > On 18.07.2016 11:26, Greg Kurz wrote: > > On Mon, 18 Jul 2016 11:04:39 +0200 > > Thomas Huth wrote: > > > >> On 18.07.2016 10:59, Greg Kurz wrote: > >>> On Mon, 18 Jul 2016 10:52:36 +1000 > >>> David Gibson wrote: > >>> > On

Re: [Qemu-devel] [PATCH v2] qemu-img: add the 'dd' subcommand

2016-07-18 Thread Fam Zheng
On Mon, 07/18 12:00, Reda Sallahi wrote: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. Please submit subsequent revisions as top level email. I.e. no In-Reply-To to previous version. > > For the start, this implements the bs, if, of and count options and requires > both

[Qemu-devel] [PATCH] linux-user: Use direct syscall for utimensat

2016-07-18 Thread Peter Maydell
The linux utimensat syscall differs in semantics from the libc function because the syscall combines the features of utimensat() and futimens(). Rather than trying to split these apart in order to call the two libc functions which then call the same underlying syscall, just always directly make the

Re: [Qemu-devel] [PATCH] migration: set state to post-migrate on failure

2016-07-18 Thread Amit Shah
On (Fri) 15 Jul 2016 [17:44:46], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If a migration fails/is cancelled during the postcopy stage we currently > end up with the runstate as finish-migrate, where it should be post-migrate. > There's a small window in precopy whe

[Qemu-devel] [PATCH 1/1] vmstateify ssd0323 display

2016-07-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" barely tested. Note: a) Bumps version number because we now use the VMSTATE_SSI_SLAVE that only uses a byte rather than a 32bit (for saving a bool 'cs'). b) Some of the int's in it's struct should probably become int32_t. Signed-off-by: Dr. David Alan Gilber

[Qemu-devel] [PATCH 0/1] vmstatification of 0323 [for 2.8?]

2016-07-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, Chipping away at register_vmstate's I thought I'd tackle one of the small devices; does anyone care about the migration state of this? Note I've bumped the version number on it and haven't got anything to test with; Peter does the bump matter to you, and

Re: [Qemu-devel] [PATCH v19 3/5] block/gluster: remove rdma transport

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 2:23 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> gluster volfile server fetch happens through unix and/or tcp, it doesn't >> support volfile fetch over rdma, hence removing the dead code >> >> Signed-off-by: Prasanna Kumar Kalever >> --- >> block/g

Re: [Qemu-devel] [PULL 00/14] ppc-for-2.7 queue 20160718

2016-07-18 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160718 > > for you to fetch changes up to 159d2e39a8602c369542a92573a52acb5f5f58f2: > > ppc: Yet another fix for the huge page support det

Re: [Qemu-devel] [PATCH v19 4/5] block/gluster: using new qapi schema

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 2:59 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> this patch adds 'GlusterServer' related schema in qapi/block-core.json >> >> Signed-off-by: Prasanna Kumar Kalever >> --- >> block/gluster.c | 111 >> +--

[Qemu-devel] [Bug 1581796] Re: console-gl.c:96:surface_gl_create_texture:code should not be reached

2016-07-18 Thread T. Huth
Well, QEMU 2.7 is likely to be released next months, so I'm not sure whether there will be another 2.5.x stable release ... but if you like, you can try to send the patch to the qemu-stable mailing list (that's the official way to get a patch included into the stable tree) and ask to include it in

[Qemu-devel] [Bug 1603636] Re: Guest has not initialized the display yet on ubuntu 16.10 PPC

2016-07-18 Thread T. Huth
Ah, you mean your *host* is running Ubuntu 16.10 PPC (i.e. not your guest)? Only looking at the title of this bug, I was assuming you were talking about the guest running Ubuntu 16.10 PPC (i.e. the host could also be a x86 machine)... So yes, please provide also the output of "./configure ..." a

Re: [Qemu-devel] [PATCH v19 5/5] block/gluster: add support for multiple gluster servers

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 3:47 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> This patch adds a way to specify multiple volfile servers to the gluster >> block backend of QEMU with tcp|rdma transport types and their port numbers. >> >> Problem: >> >> Currently VM Image on gluste

Re: [Qemu-devel] [PULL 00/23] TCG and misc patches for 2.7 hard freeze from 2016-07-18

2016-07-18 Thread Peter Maydell
On 18 July 2016 at 10:27, Paolo Bonzini wrote: > The following changes since commit 6b92bbfe812746fe7841a24c24e6460f5359ce72: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' > into staging (2016-07-15 16:56:08 +0100) > > are available in the git repository at: > >

  1   2   3   4   >