Re: [Qemu-devel] [PATCH] virtio: revert host notifiers to old semantics

2016-07-04 Thread Jason Wang
On 2016年06月30日 23:31, Cornelia Huck wrote: The host notifier rework tried both to unify host notifiers across transports and plug a possible hole during host notifier re-assignment. Unfortunately, this meant a change in semantics that breaks vhost and iSCSI+dataplane. As the minimal fix, keep

Re: [Qemu-devel] [PATCH v5 6/9] ast2400: add SMC controllers (FMC and SPI)

2016-07-04 Thread Cédric Le Goater
Hello Marcin, On 07/02/2016 07:00 PM, mar.krzeminski wrote: >> >> + >> +/* CE Control Register */ >> +#define R_CE_CTRL(0x04 / 4) >> +#define CTRL_EXTENDED4 4 /* 32 bit addressing for SPI */ >> +#define CTRL_EXTENDED3 3 /* 32 bit addressing for SPI */ >> +#define CT

Re: [Qemu-devel] [PATCH v3 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu()

2016-07-04 Thread Igor Mammedov
On Fri, 1 Jul 2016 14:30:12 +0200 Andrew Jones wrote: > On Fri, Jul 01, 2016 at 01:50:24PM +0200, Igor Mammedov wrote: > > Replace repeated pattern > > > > for (i = 0; i < nb_numa_nodes; i++) { > > if (test_bit(idx, numa_info[i].node_cpu)) { > >... > >break; >

Re: [Qemu-devel] [PATCH v5 6/9] ast2400: add SMC controllers (FMC and SPI)

2016-07-04 Thread Marcin Krzemiński
2016-07-04 8:58 GMT+02:00 Cédric Le Goater : > Hello Marcin, > > On 07/02/2016 07:00 PM, mar.krzeminski wrote: > >> > >> + > >> +/* CE Control Register */ > >> +#define R_CE_CTRL(0x04 / 4) > >> +#define CTRL_EXTENDED4 4 /* 32 bit addressing for SPI */ > >> +#define CTRL_EXTE

Re: [Qemu-devel] [PATCH v2 3/7] ppc: different creation paths for cpus in system and user mode

2016-07-04 Thread Igor Mammedov
On Sat, 02 Jul 2016 00:41:40 +0200 Greg Kurz wrote: > The machine code currently uses the same cpu_ppc_init() function to > create cpus as the user mode. This function also triggers the cpu > realization. > > It is okay for user mode but with system mode we may want to do other > things between

Re: [Qemu-devel] [PATCH 09/15] loader: use mmap for ROMs

2016-07-04 Thread Peter Lieven
Am 28.06.2016 um 12:41 schrieb Paolo Bonzini: On 28/06/2016 11:01, Peter Lieven wrote: a classic use for mmap here. Signed-off-by: Peter Lieven They are never freed, why does mmap help? checked again. qemu_system_reset (which calls rom_reset) is invoked after pc_macine_init. So the memory

Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-07-04 Thread Changlong Xie
On 05/19/2016 05:46 AM, Eric Blake wrote: Valgrind complained about a number of leaks in tests/check-qobject-json: ==12657==definitely lost: 17,247 bytes in 1,234 blocks All of which had the same root cause: on an incomplete parse, we were abandoning the token queue without cleaning up the

Re: [Qemu-devel] [PATCH 1/3] Mediated device Core driver

2016-07-04 Thread Xiao Guangrong
On 07/01/2016 02:51 AM, Kirti Wankhede wrote: On 6/29/2016 7:21 PM, Xiao Guangrong wrote: On 06/21/2016 12:31 AM, Kirti Wankhede wrote: Design for Mediated Device Driver: ... +static int mdev_add_attribute_group(struct device *dev, +const struct attribute_group **gro

Re: [Qemu-devel] [PATCH v2 4/7] ppc: open code cpu creation for machine types

2016-07-04 Thread Igor Mammedov
On Mon, 4 Jul 2016 13:54:55 +1000 David Gibson wrote: > On Sat, Jul 02, 2016 at 10:33:33AM +0200, Greg Kurz wrote: > > On Sat, 2 Jul 2016 13:36:22 +0530 > > Bharata B Rao wrote: > > > > > On Sat, Jul 02, 2016 at 12:41:48AM +0200, Greg Kurz wrote: > > > > If we want to generate cpu_dt_id in the

Re: [Qemu-devel] [PATCH v2 3/7] ppc: different creation paths for cpus in system and user mode

2016-07-04 Thread Greg Kurz
On Mon, 4 Jul 2016 09:14:43 +0200 Igor Mammedov wrote: > On Sat, 02 Jul 2016 00:41:40 +0200 > Greg Kurz wrote: > > > The machine code currently uses the same cpu_ppc_init() function to > > create cpus as the user mode. This function also triggers the cpu > > realization. > > > > It is okay for

Re: [Qemu-devel] [RFC PATCH V2 1/3] filter-rewriter: introduce filter-rewriter initialization

2016-07-04 Thread Zhang Chen
On 07/04/2016 10:49 AM, Jason Wang wrote: On 2016年07月02日 14:22, Zhang Chen wrote: Filter-rewriter is a part of COLO project. It will rewrite some of secondary packet to make secondary guest's connection established successfully. Probably need to be more verbose here. E.g we only care about

Re: [Qemu-devel] [RFC PATCH V2 2/3] filter-rewriter: track connection and parse packet

2016-07-04 Thread Zhang Chen
On 07/04/2016 11:04 AM, Jason Wang wrote: On 2016年07月02日 14:22, Zhang Chen wrote: We use colo-base.h to track connection and parse packet Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/filter-rewriter.c | 52

Re: [Qemu-devel] [PATCH v2 0/6] cpus: make "-cpu cpux, features" global properties

2016-07-04 Thread Igor Mammedov
On Thu, 9 Jun 2016 19:10:57 +0200 Igor Mammedov wrote: Eduardo, is anything more left to review/fix so remaining patches of this series could be merged? There is PPC series[1] that would introduce a conflict (using old style feature parsing code), it would be better if this series are merged a

Re: [Qemu-devel] [PATCH v2 4/7] ppc: open code cpu creation for machine types

2016-07-04 Thread David Gibson
On Mon, Jul 04, 2016 at 09:37:47AM +0200, Igor Mammedov wrote: > On Mon, 4 Jul 2016 13:54:55 +1000 > David Gibson wrote: > > > On Sat, Jul 02, 2016 at 10:33:33AM +0200, Greg Kurz wrote: > > > On Sat, 2 Jul 2016 13:36:22 +0530 > > > Bharata B Rao wrote: > > > > > > > On Sat, Jul 02, 2016 at 12:4

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 4/7] ppc: open code cpu creation for machine types

2016-07-04 Thread Greg Kurz
On Mon, 4 Jul 2016 08:32:04 +0200 Greg Kurz wrote: > On Mon, 4 Jul 2016 13:54:55 +1000 > David Gibson wrote: > > > On Sat, Jul 02, 2016 at 10:33:33AM +0200, Greg Kurz wrote: > > > On Sat, 2 Jul 2016 13:36:22 +0530 > > > Bharata B Rao wrote: > > > > > > > On Sat, Jul 02, 2016 at 12:41:48

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH 1/2] serial console, output

2016-07-04 Thread Gerd Hoffmann
Hi, > > @@ -57,6 +58,7 @@ handle_10(struct bregs *regs) > > { > > debug_enter(regs, DEBUG_HDL_10); > > // don't do anything, since the VGA BIOS handles int10h requests > > +sercon_10(regs); > > } > > Might as well remove handle_10 and call sercon_10 directly from > romlayout.S.

Re: [Qemu-devel] [RFC PATCH V2 1/3] filter-rewriter: introduce filter-rewriter initialization

2016-07-04 Thread Jason Wang
On 2016年07月04日 15:42, Zhang Chen wrote: @item -object filter-dump,id=@var{id},netdev=@var{dev},file=@var{filename}][,maxlen=@var{len}] Dump the network traffic on netdev @var{dev} to the file specified by diff --git a/vl.c b/vl.c index c6b9a6f..b47be6a 100644 --- a/vl.c +++ b/vl.c @@

Re: [Qemu-devel] [RFC PATCH V2 2/3] filter-rewriter: track connection and parse packet

2016-07-04 Thread Jason Wang
On 2016年07月04日 15:47, Zhang Chen wrote: +if (is_tcp_packet(pkt)) { +if (sender == nf->netdev) { +fill_connection_key(pkt, &key, SECONDARY); +} else { +fill_connection_key(pkt, &key, PRIMARY); +} + +conn = connection_get(s->connection_t

Re: [Qemu-devel] [RFC PATCH V2 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-07-04 Thread Zhang Chen
On 07/04/2016 11:16 AM, Jason Wang wrote: On 2016年07月02日 14:22, Zhang Chen wrote: We will rewrite tcp packet secondary received and sent. When colo guest is a tcp server. Firstly, client start a tcp handshake. the packet's seq=client_seq, ack=0,flag=SYN. COLO primary guest get this pkt and

Re: [Qemu-devel] [PULL 0/2] 9p patches for 2.7

2016-07-04 Thread Peter Maydell
On 1 July 2016 at 17:56, Greg Kurz wrote: > The following changes since commit 94e31093ff34ead50dc3970699a4e36582fb3f17: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20160630.0' > into staging (2016-07-01 11:52:14 +0100) > > are available in the git repository at: > > h

Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor

2016-07-04 Thread Paolo Bonzini
On 30/06/2016 16:12, Markus Armbruster wrote: > Implementing a stack as "big enough" array can be wasteful. > Implementing it as dynamically allocated list is differently wasteful. > Saving several mallocs and frees can be worth "wasting" a few pages of > memory for a short time. Most usage of Q

Re: [Qemu-devel] [RFC PATCH 1/2] serial console, output

2016-07-04 Thread Paolo Bonzini
On 04/07/2016 10:16, Gerd Hoffmann wrote: > > +sercon_putchar('\x1b'); > +sercon_putchar('c'); > +/* clear screen */ > +sercon_putchar('\x1b'); > +sercon_putchar('['); > +sercon_putchar('2'); > +sercon_putchar('J'); > +} > + > +static void sercon_set_color(u8 fg, u8 b

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
On 07/02/2016 08:05 PM, mar.krzeminski wrote: > > > W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze: >> This test uses the palmetto platform and the AST2400 SPI controller to >> test the m25p80 flash module device model. The flash model is defined >> by the platform (n25q256a) and it would be n

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH 2/2] serial console, input

2016-07-04 Thread Gerd Hoffmann
Hi, > > +#define FLAG_CTRL (1<<0) > > +#define FLAG_SHIFT (1<<1) > > + > > +VARLOW struct { > > +u8 flags; > > +u8 scancode; > > +} termchr[256] = { > > +[ '1'] = { .scancode = 0x02, }, > > I think this table should be generated at runtime from > kbd.c:

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2016-07-04 Thread Kai Storbeck
We have four identical Ubuntu servers running libvirt/kvm/qemu, with access to CEPH rbd filesystems. Guests can be live migrated between them. However, live migration leads in ~30% of the cases to guests being stuck at 100%. Only a few times we had the patience to wait, and upon logging in our pass

[Qemu-devel] [PATCH 0/2 V4] Show all of snapshot info on every block dev

2016-07-04 Thread Lin Ma
V4: Use QTAILQ_FOREACH_SAFE instead of QTAILQ_FOREACH while freeing snapshot lists. V3: Fix leaking the entries in image_list and the entries in their ImageEntry.snapshots lists V2: Split it to 2 patches. Lin Ma (2): hmp: use snapshot name to determine whether a snapshot is 'fully ava

[Qemu-devel] [PATCH 1/2 V4] hmp: use snapshot name to determine whether a snapshot is 'fully available'

2016-07-04 Thread Lin Ma
Currently qemu uses snapshot id to determine whether a snapshot is fully available, It causes incorrect output in some scenario. For instance: (qemu) info block drive_image1 (#block113): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk0.qcow2 (qcow2) Cache mode: writeback drive_image2 (#block349

[Qemu-devel] [PATCH 2/2 V4] hmp: show all of snapshot info on every block dev in output of 'info snapshots'

2016-07-04 Thread Lin Ma
Currently, the output of 'info snapshots' shows fully available snapshots. It's opaque, hides some snapshot information to users. It's not convenient if users want to know more about all of snapshot information on every block device via monitor. Follow Kevin's and Max's proposals, The patch makes

[Qemu-devel] [PULL 2/4] bios: Add fast variant of SeaBIOS for use with -kernel on x86.

2016-07-04 Thread Gerd Hoffmann
From: "Richard W.M. Jones" This commit adds a fast variant of SeaBIOS called 'bios-fast.bin'. It's designed to be the fastest (also the smallest, but that's not the main aim) SeaBIOS that is just enough to boot a Linux kernel using the -kernel option on i686 and x86_64. This commit does not mod

[Qemu-devel] [PULL 1/4] seabios: update submodule from 1.9.1 to 1.9.3

2016-07-04 Thread Gerd Hoffmann
git shortlog Alex Williamson (1): fw/pci: Add support for mapping Intel IGD via QEMU Haozhong Zhang (1): fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL Kevin O'Connor (1): build: fix .text section address alignment Marcel Apfelbaum (1):

[Qemu-devel] [PULL 4/4] seabios: update binaries from 1.9.1 to 1.9.3

2016-07-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- pc-bios/bios-256k.bin | Bin 262144 -> 262144 bytes pc-bios/bios-fast.bin | Bin 0 -> 65536 bytes pc-bios/bios.bin | Bin 131072 -> 131072 bytes 3 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 pc-bios/bios-fast.bin diff --git a/pc-bios/b

[Qemu-devel] [PULL 3/4] seabios: update 128k config

2016-07-04 Thread Gerd Hoffmann
Turn off mpt-scsi and bootsplash to keep size below 128k. Signed-off-by: Gerd Hoffmann --- roms/config.seabios-128k | 2 ++ 1 file changed, 2 insertions(+) diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k index 0a9da77..93203af 100644 --- a/roms/config.seabios-128k +++ b/roms/co

[Qemu-devel] [PULL 0/4] seabios: update from 1.9.1 to 1.9.3

2016-07-04 Thread Gerd Hoffmann
. please pull, Gerd The following changes since commit 96b39d8327883094f52b0a3d3f25dba83d6d1d63: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2016-07-01 19:29:27 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-seabio

[Qemu-devel] [PATCH v8 0/7] trace: Per-vCPU tracing states

2016-07-04 Thread Lluís Vilanova
NOTE: This series applies on top of "trace: [*-user] Add commandline arguments to control tracing". Provides per-vCPU dynamic controls of the tracing state of events with the "vcpu" property. A later series proposes an optimization where tracing code can be elided for dynamically disabled e

[Qemu-devel] [PATCH 3/4] msmouse: switch to new input interface

2016-07-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- backends/msmouse.c | 68 -- 1 file changed, 56 insertions(+), 12 deletions(-) diff --git a/backends/msmouse.c b/backends/msmouse.c index 9ade31b..b1e1bea 100644 --- a/backends/msmouse.c +++ b/backends/msmouse.c

[Qemu-devel] [PATCH v8 1/7] trace: Identify events with the 'vcpu' property

2016-07-04 Thread Lluís Vilanova
A new event attribute 'cpu_id' is added to have a separate ID space ('TRACE_VCPU_*') for all events with the 'vcpu' property. These are later used to identify which events are enabled on each vCPU. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- scripts/tracetool/format/events_c

[Qemu-devel] [PATCH v8 6/7] trace: Allow event name pattern in "info trace-events"

2016-07-04 Thread Lluís Vilanova
Homogenizes the command capabilities with QMP. Signed-off-by: Lluís Vilanova Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- hmp-commands-info.hx |8 +--- hmp.h|1 + monitor.c| 31 ++- 3 files changed, 36 insertio

[Qemu-devel] [PATCH v8 5/7] trace: Conditionally trace events based on their per-vCPU state

2016-07-04 Thread Lluís Vilanova
Events with the 'vcpu' property are conditionally emitted according to their per-vCPU state. Other events are emitted normally based on their global tracing state. Note that the per-vCPU condition check applies to all tracing backends. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 4/4] msmouse: send short messages if possible.

2016-07-04 Thread Gerd Hoffmann
Keep track of button changes. Send the extended 4-byte messages for three button mice only in case we have something to report for the middle button. Use the short 3-byte messages (original protocol for two-button microsoft mouse) otherwise. Signed-off-by: Gerd Hoffmann --- backends/msmouse.c

[Qemu-devel] [PATCH v8 3/7] [trivial] trace: Cosmetic changes on fast-path tracing

2016-07-04 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- trace/control-internal.h |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/trace/control-internal.h b/trace/control-internal.h index 5e0a5ab..c5f5f3d 100644 --- a/trace/control-internal.h +++ b/trace/contr

[Qemu-devel] [PATCH 2/4] msmouse: fix buffer handling

2016-07-04 Thread Gerd Hoffmann
The msmouse chardev backend writes data without checking whenever there is enough space. That happens to work with linux guests, probably by pure luck because the linux driver enables the fifo and the serial port emulation accepts more data than announced via qemu_chr_be_can_write() in that case.

[Qemu-devel] [PATCH v8 4/7] trace: Add per-vCPU tracing states for events with the 'vcpu' property

2016-07-04 Thread Lluís Vilanova
Each vCPU gets a 'trace_dstate' bitmap to control the per-vCPU dynamic tracing state of events with the 'vcpu' property. Signed-off-by: Lluís Vilanova --- bsd-user/main.c |1 + include/qom/cpu.h|6 + linux-user/main.c|1 + qom/cpu.c|1

[Qemu-devel] [PATCH v8 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-07-04 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- hmp-commands-info.hx |6 +- hmp-commands.hx |7 +- monitor.c| 17 +- qapi/trace.json | 32 +-- qmp-commands.hx | 35 +++- trace/qmp.c | 148 ++

Re: [Qemu-devel] [PULL 0/4] tcg (-ish) updates

2016-07-04 Thread Peter Maydell
On 1 July 2016 at 18:19, Richard Henderson wrote: > Three tcg patches, and a build change so that we can still > use --cpu=i686 on a x86_64 host, now that linux-user has > the syscall assembly thunks. > > > r~ > > > The following changes since commit 9a48e3670030148a8d00c8d4d4cd7f051c0d9f39: > >

[Qemu-devel] [PATCH v8 2/7] disas: Remove unused macro '_'

2016-07-04 Thread Lluís Vilanova
Eliminates a future compilation error when UI code includes the tracing headers (indirectly pulling "disas/bfd.h" through "qom/cpu.h") and GLib's i18n '_' macro. Signed-off-by: Lluís Vilanova Reviewed-by: Stefan Hajnoczi --- disas/alpha.c |6 +++--- disas/arm.c |2 +- disa

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-07-04 Thread Peter Maydell
On 1 July 2016 at 18:49, Dmitry Osipenko wrote: > On 01.07.2016 19:36, Peter Maydell wrote: >> On 30 June 2016 at 20:01, Dmitry Osipenko wrote: >>> On 30.06.2016 18:02, Peter Maydell wrote: What I meant was: ptimer_get_count() is typically called to generate a value to return from a reg

[Qemu-devel] [PATCH v2 0/4] msmouse: misc fixes.

2016-07-04 Thread Gerd Hoffmann
Hi, A small collection of msmouse fixes. Not many changes in v2, only dropped a comment on patch 4 (peters comment) and added paolo's acks for patches 1+2. cheers, Gerd Gerd Hoffmann (4): msmouse: add MouseState, unregister handler on close msmouse: fix buffer handling msmouse: switch

[Qemu-devel] [PATCH 1/4] msmouse: add MouseState, unregister handler on close

2016-07-04 Thread Gerd Hoffmann
Add struct to track serial mouse state. Store mouse event handler there. Unregister properly on chardev close. Signed-off-by: Gerd Hoffmann Acked-by: Paolo Bonzini --- backends/msmouse.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/backends/msmou

[Qemu-devel] Any topics for today's MTTCG sync-up call?

2016-07-04 Thread Alex Bennée
Hi, It's been a while since we've actually held the call. Here are some things that might be worth discussing: Soft Freeze === This cycles soft-freeze is upon us. QHT has already been merged this cycle which is a win. I've taken some of the lock contention patches from my base enabling

Re: [Qemu-devel] [PULL 2/4] bios: Add fast variant of SeaBIOS for use with -kernel on x86.

2016-07-04 Thread Richard W.M. Jones
On Mon, Jul 04, 2016 at 11:33:40AM +0200, Gerd Hoffmann wrote: > From: "Richard W.M. Jones" > > This commit adds a fast variant of SeaBIOS called 'bios-fast.bin'. > > It's designed to be the fastest (also the smallest, but that's not the > main aim) SeaBIOS that is just enough to boot a Linux ke

Re: [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG

2016-07-04 Thread Paolo Bonzini
On 02/07/2016 09:38, Sergey Fedorov wrote: >>> +bool qemu_tcg_mttcg_enabled(void) >>> +{ >>> +return mttcg_enabled; >>> +} >>> >> Is there a good reason to expose this via function call, rather than >>> >> just test >>> >> the variable? >> > It was in Fred's original patc

Re: [Qemu-devel] [PATCH 6/6] coroutine: reduce stack size to 64kB

2016-07-04 Thread Paolo Bonzini
On 04/07/2016 08:22, Peter Lieven wrote: >>> >> >> Ought we check that this is not smaller than >> >> sysconf(_SC_THREAD_STACK_MIN) >> >> which (for glibc at least), is 192k for ia64, 128k for aarch64, mips >> and tile (though why it is quite so high in those later cases I don't >> know). >

Re: [Qemu-devel] [PATCH 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-04 Thread Paolo Bonzini
On 04/07/2016 08:18, Peter Lieven wrote: > Am 01.07.2016 um 22:49 schrieb Richard Henderson: >> On 07/01/2016 01:12 PM, Richard Henderson wrote: >>> On 06/30/2016 12:37 AM, Peter Lieven wrote: +void *qemu_alloc_stack(size_t sz) +{ +/* allocate sz bytes plus one extra page for a

Re: [Qemu-devel] [PATCH 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-04 Thread Peter Lieven
Am 04.07.2016 um 12:19 schrieb Paolo Bonzini: On 04/07/2016 08:18, Peter Lieven wrote: Am 01.07.2016 um 22:49 schrieb Richard Henderson: On 07/01/2016 01:12 PM, Richard Henderson wrote: On 06/30/2016 12:37 AM, Peter Lieven wrote: +void *qemu_alloc_stack(size_t sz) +{ +/* allocate sz byte

[Qemu-devel] KVM call for agenda for 2016-07-05

2016-07-04 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-04 Thread Paolo Bonzini
On 04/07/2016 12:25, Peter Lieven wrote: >>> >> No, you just pass the stack and the runtime takes care of initializing >> the two stack pointers: >> >> uc.uc_link = &old_uc; >> uc.uc_stack.ss_sp = co->stack; >> uc.uc_stack.ss_size = stack_size; >> uc.uc_stack.ss_flags = 0; >

Re: [Qemu-devel] [PATCH 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-04 Thread Peter Lieven
Am 04.07.2016 um 12:34 schrieb Paolo Bonzini: On 04/07/2016 12:25, Peter Lieven wrote: No, you just pass the stack and the runtime takes care of initializing the two stack pointers: uc.uc_link = &old_uc; uc.uc_stack.ss_sp = co->stack; uc.uc_stack.ss_size = stack_size; u

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
>>> +static void test_erase_sector(void) >>> +{ >>> +uint32_t some_page_addr = 0x600 * PAGE_SIZE; >>> +uint32_t page[PAGE_SIZE / 4]; >>> +int i; >>> + >>> +spi_conf(CONF_ENABLE_W0); >>> + >>> +spi_ctrl_start_user(); >>> +writeb(AST2400_FLASH_BASE, WREN); >>> +writeb(AST2

Re: [Qemu-devel] [PATCH v2 1/6] block/qdev: Allow node name for drive properties

2016-07-04 Thread Kevin Wolf
Am 02.07.2016 um 17:33 hat Max Reitz geschrieben: > On 30.06.2016 16:13, Kevin Wolf wrote: > > If a node name instead of a BlockBackend name is specified as the driver > > for a guest device, an anonymous BlockBackend is created now. > > > > Signed-off-by: Kevin Wolf > > --- > > hw/core/qdev-pro

Re: [Qemu-devel] [PATCH] ppc: Fix xsrdpi, xvrdpi and xvrspi rounding

2016-07-04 Thread Anton Blanchard
Hi David, > I take it float_round_ties_away is the same thing the architecture > refers to as "round to Nearest Away"? Yeah. I noticed it when 0.5 got rounded to 0 on QEMU and 1.0 on real hardware. Anton

Re: [Qemu-devel] [PATCH 1/6] oslib-posix: add helpers for stack alloc and free

2016-07-04 Thread Paolo Bonzini
On 04/07/2016 12:35, Peter Lieven wrote: > Am 04.07.2016 um 12:34 schrieb Paolo Bonzini: >> >> On 04/07/2016 12:25, Peter Lieven wrote: No, you just pass the stack and the runtime takes care of initializing the two stack pointers: uc.uc_link = &old_uc; uc.uc_s

Re: [Qemu-devel] [PATCH v2 5/6] qemu-iotests: Test setting WCE with qdev

2016-07-04 Thread Kevin Wolf
Am 02.07.2016 um 18:15 hat Max Reitz geschrieben: > On 30.06.2016 16:13, Kevin Wolf wrote: > > +echo "info block" \ > > +| run_qemu -drive "$drive,cache=$cache" \ > > + -device "ide-hd,drive=none0$wce" \ > > +| grep -e "Testing" -e "Cache mode"

Re: [Qemu-devel] [PATCH v2 6/6] block: Remove BB options from blockdev-add

2016-07-04 Thread Kevin Wolf
Am 02.07.2016 um 18:28 hat Max Reitz geschrieben: > On 30.06.2016 16:13, Kevin Wolf wrote: > > werror/rerror are now available as qdev options. The stats-* options are > > removed without an existing replacement; they should probably be > > configurable with a separate QMP command like I/O throttli

Re: [Qemu-devel] [PATCH v8 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state

2016-07-04 Thread Markus Armbruster
Lluís Vilanova writes: > Signed-off-by: Lluís Vilanova > Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Peter Maydell
On 4 July 2016 at 10:15, Cédric Le Goater wrote: > On 07/02/2016 08:05 PM, mar.krzeminski wrote: >> >> >> W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze: >>> +static void test_erase_sector(void) >>> +{ >>> +uint32_t some_page_addr = 0x600 * PAGE_SIZE; >>> +uint32_t page[PAGE_SIZE / 4];

Re: [Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source

2016-07-04 Thread Sascha Silbe
Dear Markus, Markus Armbruster writes: > Markus Armbruster writes: > >> Hmm, this demonstrates some of our headers may only be included when >> certain CONFIG_* are defined. [...] >> Regardless, we need to find the problemtatic headers. Perhaps you can >> find a few more with "make -k check-so

Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor

2016-07-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 30/06/2016 16:12, Markus Armbruster wrote: >> Implementing a stack as "big enough" array can be wasteful. >> Implementing it as dynamically allocated list is differently wasteful. >> Saving several mallocs and frees can be worth "wasting" a few pages of >> memory for a

Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor

2016-07-04 Thread Peter Lieven
Am 04.07.2016 um 13:18 schrieb Markus Armbruster: Paolo Bonzini writes: On 30/06/2016 16:12, Markus Armbruster wrote: Implementing a stack as "big enough" array can be wasteful. Implementing it as dynamically allocated list is differently wasteful. Saving several mallocs and frees can be wort

Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor

2016-07-04 Thread Paolo Bonzini
On 04/07/2016 13:18, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 30/06/2016 16:12, Markus Armbruster wrote: >>> Implementing a stack as "big enough" array can be wasteful. >>> Implementing it as dynamically allocated list is differently wasteful. >>> Saving several mallocs and free

[Qemu-devel] [PULL v2 0/3] seabios: update from 1.9.1 to 1.9.3

2016-07-04 Thread Gerd Hoffmann
pull, Gerd The following changes since commit 96b39d8327883094f52b0a3d3f25dba83d6d1d63: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2016-07-01 19:29:27 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-seabios-20160

Re: [Qemu-devel] [PATCH] quorum: Only compile when supported

2016-07-04 Thread Alberto Garcia
On Sat 02 Jul 2016 02:36:38 PM CEST, Max Reitz wrote: >> This was the only exceptional module init function that does >> something else than a simple list of bdrv_register() calls, in all >> the block drivers. > > This sounds like this patch specifically wants to drop the check from > bdrv_quorum_

[Qemu-devel] [PULL v2 2/3] seabios: update 128k config

2016-07-04 Thread Gerd Hoffmann
Turn off mpt-scsi and bootsplash to keep size below 128k. Signed-off-by: Gerd Hoffmann --- roms/config.seabios-128k | 2 ++ 1 file changed, 2 insertions(+) diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k index 0a9da77..93203af 100644 --- a/roms/config.seabios-128k +++ b/roms/co

[Qemu-devel] [PULL v2 1/3] seabios: update submodule from 1.9.1 to 1.9.3

2016-07-04 Thread Gerd Hoffmann
git shortlog Alex Williamson (1): fw/pci: Add support for mapping Intel IGD via QEMU Haozhong Zhang (1): fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL Kevin O'Connor (1): build: fix .text section address alignment Marcel Apfelbaum (1):

Re: [Qemu-devel] [PATCH 2/2] cpu-exec: remove tb_lock from the hot-path

2016-07-04 Thread Alex Bennée
Emilio G. Cota writes: > On Fri, Jul 01, 2016 at 17:16:10 +0100, Alex Bennée wrote: >> Lock contention in the hot path of moving between existing patched >> TranslationBlocks is the main drag in multithreaded performance. This >> patch pushes the tb_lock() usage down to the two places that reall

[Qemu-devel] [PULL v2 3/3] seabios: update binaries from 1.9.1 to 1.9.3

2016-07-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- pc-bios/bios-256k.bin | Bin 262144 -> 262144 bytes pc-bios/bios.bin | Bin 131072 -> 131072 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/bios-256k.bin b/pc-bios/bios-256k.bin index e7a7e72..57fb4d8 100644 Binary files a/pc-bio

Re: [Qemu-devel] [PULL 0/6] slirp: ipv6 dns & dhcp support

2016-07-04 Thread Peter Maydell
On 3 July 2016 at 23:04, Samuel Thibault wrote: > The following changes since commit 9a48e3670030148a8d00c8d4d4cd7f051c0d9f39: > > Added Bulgarian translation (2016-07-01 16:06:57 +0100) > > are available in the git repository at: > > http://people.debian.org/~sthibault/qemu.git tags/samuel-th

Re: [Qemu-devel] [PULL 2/4] bios: Add fast variant of SeaBIOS for use with -kernel on x86.

2016-07-04 Thread Gerd Hoffmann
On Mo, 2016-07-04 at 11:08 +0100, Richard W.M. Jones wrote: > Hi Gerd, I'd like to "self-" NACK this patch - ie. I withdraw it. Ok. Dropped patch, dropped binary, PULL v2 sent. cheers, Gerd

Re: [Qemu-devel] [PATCH v2 06/27] int128: Use complex numbers if advisable

2016-07-04 Thread Paolo Bonzini
On 01/07/2016 19:04, Richard Henderson wrote: > If __int128 is not supported, prefer a base type that is > returned in registers rather than memory. > > Signed-off-by: Richard Henderson > --- > include/qemu/int128.h | 110 > +++--- > 1 file changed,

Re: [Qemu-devel] [PATCH v2 0/2]vhost-user: Extend protocol to seek response for any command.

2016-07-04 Thread Michael S. Tsirkin
On Fri, Jul 01, 2016 at 02:46:20AM -0700, Prerna Saxena wrote: > From: Prerna Saxena > > The current vhost-user protocol requires the client to send responses to only > a > few commands. For the remaining commands, it is impossible for QEMU to know > the > status of the requested operation -- i

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
On 07/04/2016 01:14 PM, Peter Maydell wrote: > On 4 July 2016 at 10:15, Cédric Le Goater wrote: >> On 07/02/2016 08:05 PM, mar.krzeminski wrote: >>> >>> >>> W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze: > +static void test_erase_sector(void) +{ +uint32_t some_page_addr = 0

Re: [Qemu-devel] [PATCH v2 06/27] int128: Use complex numbers if advisable

2016-07-04 Thread Peter Maydell
On 1 July 2016 at 18:04, Richard Henderson wrote: > If __int128 is not supported, prefer a base type that is > returned in registers rather than memory. So which host architectures does this improve? 128 bit integers are nothing to do with complex numbers, so we ought to have a strong justificati

Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test

2016-07-04 Thread Peter Maydell
On 4 July 2016 at 13:01, Cédric Le Goater wrote: > On 07/04/2016 01:14 PM, Peter Maydell wrote: >> What is the test actually supposed to be doing? >> writel() says "write this 32 bit value as if the (guest) CPU >> wrote it to memory with a 32-bit write instruction". > > The test (and the guest) is

Re: [Qemu-devel] [PATCH v3 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu()

2016-07-04 Thread Michael S. Tsirkin
On Fri, Jul 01, 2016 at 01:50:24PM +0200, Igor Mammedov wrote: > Replace repeated pattern > > for (i = 0; i < nb_numa_nodes; i++) { > if (test_bit(idx, numa_info[i].node_cpu)) { >... >break; > > with a helper function to lookup numa node index for cpu. > > Sug

Re: [Qemu-devel] [PATCH v3 5/5] tests: acpi: extend cphp testcase with numa check

2016-07-04 Thread Michael S. Tsirkin
On Fri, Jul 01, 2016 at 01:50:26PM +0200, Igor Mammedov wrote: > so it would be possible to verify _PXM generation in > DSDT and SRAT tables. > > Signed-off-by: Igor Mammedov > Reviewed-by: Marcel Apfelbaum It's still a pain to backport, pls make it a separate patch if you repost. > --- > NOTE

[Qemu-devel] [PATCH 0/7] ast2400: U-boot support

2016-07-04 Thread Cédric Le Goater
Hello, Here is a serie adding the changes requires to boot a ast2400 guest directly from a flash image. These images generally start with the U-boot bootloader. U-boot on the Aspeed SOCs makes use of the SPI controller in the Command mode. In this mode, the flash content is mapped to a memory reg

[Qemu-devel] [PATCH 2/7] m25p80: add mx25l25635f chip

2016-07-04 Thread Cédric Le Goater
The Macronix chip mx25l25635f used on some OpenPower boxes is very similar to the mx25l25635e. They share the same JEDEC identifier but the WRSR instruction requires 2 bytes in the mx25l25635f case. To prevent some warnings on guests, let's introduce a new chip identifying JEDEC 0xc22019 as a MX25

[Qemu-devel] [PATCH 1/7] tests: add a m25p80 test

2016-07-04 Thread Cédric Le Goater
This test uses the palmetto platform and the AST2400 SPI controller to test the m25p80 flash module device model. The flash model is defined by the platform (n25q256a) and it would be nice to find way to control it, using a property probably. Signed-off-by: Cédric Le Goater Reviewed-by: Peter May

Re: [Qemu-devel] [PATCH v8 0/5] Add a generic loader

2016-07-04 Thread Peter Maydell
On 2 July 2016 at 02:07, Alistair Francis wrote: > This work is based on the original work by Li Guang with extra > features added by Peter C and myself. > > The idea of this loader is to allow the user to load multiple images > or values into QEMU at startup. > > Memory values can be loaded like

[Qemu-devel] [PATCH 6/7] ast2400: use contents of first SPI flash as a rom

2016-07-04 Thread Cédric Le Goater
This provides support for U-Boot images which are loaded at 0x0. A Palmetto BMC guest can now be simply booted with : $ qemu-system-arm -m 256 -M palmetto-bmc -nographic -nodefaults \ -mtdblock ./flash-palmetto-20160512040959 \ -mtdblock ./palmetto.pnor The first block device

[Qemu-devel] [PATCH 3/7] ast2400: use a mx25l25635f chip

2016-07-04 Thread Cédric Le Goater
The pflash command on OpenBmc is used to update the flash and it expects a mx25l25635f and not a mx25l25635e. Signed-off-by: Cédric Le Goater --- hw/arm/palmetto-bmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/palmetto-bmc.c b/hw/arm/palmetto-bmc.c index 54e29a86

[Qemu-devel] [PATCH 5/7] ast2400: handle SPI flash Command mode (read only)

2016-07-04 Thread Cédric Le Goater
To handle memory accesses when the SPI flash slave is configured in Command mode, let's change the memory region of the SPI flash object to a ROM memory region (like the pflash_cfi* object). The m25p80 flash object creation is changed accordingly to use the new memory region as a storage. Only rea

[Qemu-devel] [PULL 08/23] bitops: Add MAKE_64BIT_MASK macro

2016-07-04 Thread Peter Maydell
From: Alistair Francis Add a macro that creates a 64bit value which has length number of ones shifted across by the value of shift. Signed-off-by: Alistair Francis Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Message-id: 9773244aa1c8c26b8b82cb261d8f5dd4b7b9fcf9.1467053537.git.alistair

[Qemu-devel] [PULL 00/23] target-arm queue

2016-07-04 Thread Peter Maydell
: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2016-07-04 10:49:17 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20160704 for you to fetch cha

[Qemu-devel] [PATCH 4/7] m25p80: add a m25p80_set_rom_storage() routine

2016-07-04 Thread Cédric Le Goater
Some SPI controllers, such as the Aspeed AST2400, have a mode in which accesses to the flash content are no different than doing MMIOs. The controller generates all the necessary commands to load (or store) data in memory. To emulate such a behavior, we need to have access to the underlying storag

[Qemu-devel] [PATCH 7/7] ast2400: add a memory controller device model

2016-07-04 Thread Cédric Le Goater
The uboot in the previous release of the SDK was using a hardcoded value for memory size. This is not true anymore, the value is now retrieved from the memory controller. Below is a model for this device, only supporting unlock and configuration. Without it, we endup running a guest with 64MB, whi

[Qemu-devel] [PULL 12/23] register: QOMify

2016-07-04 Thread Peter Maydell
From: Peter Crosthwaite QOMify registers as a child of TYPE_DEVICE. This allows registers to define GPIOs. Define an init helper that will do QOM initialisation. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Peter Maydell Message-

[Qemu-devel] [PULL 15/23] xilinx_zynq: Connect devcfg to the Zynq machine model

2016-07-04 Thread Peter Maydell
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Message-id: 85f39c9a13569b1113dacac3b952b0af54fc1260.1467053537.git.alistair.fran...@xilinx.com Signed-off-by: Peter Maydell --- hw/arm/xilinx_zynq.c | 6 ++ 1 file change

Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-07-04 Thread Markus Armbruster
Changlong Xie writes: > On 05/19/2016 05:46 AM, Eric Blake wrote: >> Valgrind complained about a number of leaks in >> tests/check-qobject-json: >> >> ==12657==definitely lost: 17,247 bytes in 1,234 blocks >> >> All of which had the same root cause: on an incomplete parse, >> we were abandoni

[Qemu-devel] [PULL 19/23] m25p80: change cur_addr to 32 bit integer

2016-07-04 Thread Peter Maydell
From: Paolo Bonzini The maximum amount of storage that can be addressed by the m25p80 command set is 4 GiB. However, cur_addr is currently a 64-bit integer. To avoid further problems related to sign extension of signed 32-bit integer expressions, change cur_addr to a 32 bit integer. Preserve m

[Qemu-devel] [PULL 10/23] register: Add Memory API glue

2016-07-04 Thread Peter Maydell
From: Alistair Francis Add memory io handlers that glue the register API to the memory API. Just translation functions at this stage. Although it does allow for devices to be created without all-in-one mmio r/w handlers. This patch also adds the RegisterInfoArray struct, which allows all of the

  1   2   3   4   5   >