Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] ppc: Improve PCR bit selection in ppc_set_compat()

2016-06-08 Thread Thomas Huth
On 08.06.2016 07:44, David Gibson wrote: > On Tue, Jun 07, 2016 at 05:39:39PM +0200, Thomas Huth wrote: >> When using an olderr PowerISA level, all the upper compatibility >> bits have to be enabled, too. For example when we want to run >> something in PowerISA 2.05 compatibility mode on POWER8, th

Re: [Qemu-devel] [PATCH v2 17/19] linux-user: Use both si_code and si_signo when converting siginfo_t

2016-06-08 Thread Riku Voipio
On Wed, Jun 08, 2016 at 09:30:35AM +0300, Riku Voipio wrote: > On Fri, May 27, 2016 at 03:51:59PM +0100, Peter Maydell wrote: > > The siginfo_t struct includes a union. The correct way to identify > > which fields of the union are relevant is complicated, because we > > have to use a combination of

Re: [Qemu-devel] [Qemu-stable] [PATCH V2] net: fix qemu_announce_self not emitting packets

2016-06-08 Thread Peter Lieven
Am 08.06.2016 um 08:39 schrieb Jason Wang: > > > On 2016年06月07日 21:00, Peter Lieven wrote: >> commit fefe2a78 accidently dropped the code path for injecting >> raw packets. This feature is needed for sending gratuitous ARPs >> after an incoming migration has completed. The result is increased >> ne

[Qemu-devel] [PULL 0/6] docker queue

2016-06-08 Thread Fam Zheng
ull-docker-20160608 for you to fetch changes up to d3a49cbed5c18dcdce35f8e39712545ab1fd7cd0: tests/docker: build all targets in test-clang (2016-06-08 15:19:30 +0800) Docker testing fixe

[Qemu-devel] [PULL 1/6] tests/docker: fix make-archive-maybe

2016-06-08 Thread Fam Zheng
From: Paolo Bonzini make-archive-maybe expects an archive path relative to $1, but receives a path relative to the current directory. Redirect the output outside the subshell to bypass the "cd $1". Signed-off-by: Paolo Bonzini Message-id: 1465224417-141321-2-git-send-email-pbonz...@redhat.com

[Qemu-devel] [PULL 3/6] tests/docker: fix test-mingw

2016-06-08 Thread Fam Zheng
From: Paolo Bonzini Add flex and bison for use in test-mingw, because test-mingw uses the in-tree libdtc. Signed-off-by: Paolo Bonzini Message-id: 1465224417-141321-4-git-send-email-pbonz...@redhat.com Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 2 +- tests/docker/do

[Qemu-devel] [PULL 5/6] tests/docker: support travis test with fedora image

2016-06-08 Thread Fam Zheng
From: Paolo Bonzini Install sparse and PyYAML. Signed-off-by: Paolo Bonzini Message-id: 1465224417-141321-6-git-send-email-pbonz...@redhat.com Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/dock

Re: [Qemu-devel] [PATCH v3 10/10] ipmi: provide support for FRUs

2016-06-08 Thread Cédric Le Goater
On 03/15/2016 03:30 PM, Michael S. Tsirkin wrote: > On Thu, Mar 10, 2016 at 03:04:03PM +0100, Cédric Le Goater wrote: >> This patch provides a simple FRU support for the BMC simulator. FRUs >> are loaded from a file which name is specified in the object >> properties, each entry having a fixed size

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] ppc: Improve PCR bit selection in ppc_set_compat()

2016-06-08 Thread David Gibson
On Wed, Jun 08, 2016 at 08:59:30AM +0200, Thomas Huth wrote: > On 08.06.2016 07:44, David Gibson wrote: > > On Tue, Jun 07, 2016 at 05:39:39PM +0200, Thomas Huth wrote: > >> When using an olderr PowerISA level, all the upper compatibility > >> bits have to be enabled, too. For example when we want

[Qemu-devel] [PULL 4/6] tests/docker: remove unused feature "ccache"

2016-06-08 Thread Fam Zheng
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Message-id: 1465224417-141321-5-git-send-email-pbonz...@redhat.com Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/ubuntu.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/ubuntu.docker b/

[Qemu-devel] [PULL 6/6] tests/docker: build all targets in test-clang

2016-06-08 Thread Fam Zheng
From: Paolo Bonzini Warnings specific to clang may affect devices that are not build by x86_64-softmmu and aarch64-softmmu. Build all targets since that is also what Peter does. Signed-off-by: Paolo Bonzini Message-id: 1465224417-141321-7-git-send-email-pbonz...@redhat.com Signed-off-by: Fam Z

[Qemu-devel] [PULL 2/6] tests/docker: make test-full build all targets, not none

2016-06-08 Thread Fam Zheng
From: Paolo Bonzini Fix common.rc to avoid passing an empty --target-list= option to configure. Signed-off-by: Paolo Bonzini Message-id: 1465224417-141321-3-git-send-email-pbonz...@redhat.com Signed-off-by: Fam Zheng --- tests/docker/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] ppc: Improve PCR bit selection in ppc_set_compat()

2016-06-08 Thread Thomas Huth
On 08.06.2016 09:24, David Gibson wrote: > On Wed, Jun 08, 2016 at 08:59:30AM +0200, Thomas Huth wrote: >> On 08.06.2016 07:44, David Gibson wrote: >>> On Tue, Jun 07, 2016 at 05:39:39PM +0200, Thomas Huth wrote: When using an olderr PowerISA level, all the upper compatibility bits have t

Re: [Qemu-devel] [PATCH] net: mipsnet: check transmit buffer size before sending

2016-06-08 Thread P J P
Hello Jason, +-- On Wed, 8 Jun 2016, Jason Wang wrote --+ | We need to fix this issue, but instead of changing the behavior, is it | better the add a check in MIPSNET_TX_DATA_BUFFER? Yes, the patch has that too. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54

Re: [Qemu-devel] [Qemu-stable] [PATCH V2] net: fix qemu_announce_self not emitting packets

2016-06-08 Thread Jason Wang
On 2016年06月08日 15:13, Peter Lieven wrote: Am 08.06.2016 um 08:39 schrieb Jason Wang: On 2016年06月07日 21:00, Peter Lieven wrote: commit fefe2a78 accidently dropped the code path for injecting raw packets. This feature is needed for sending gratuitous ARPs after an incoming migration has comple

[Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too

2016-06-08 Thread Thomas Huth
MinGW seems to compile currently without warnings, so it should be safe to enable -Werror now for this environment, too. Signed-off-by: Thomas Huth --- ... at least it compiles without errors for me here. I hope that's also true for different versions of MinGW ... would be great if everybody w

Re: [Qemu-devel] [Qemu-block] [PATCH] Report error when opening device with locked tray

2016-06-08 Thread Kevin Wolf
Am 07.06.2016 um 22:00 hat John Snow geschrieben: > > > On 06/07/2016 06:28 AM, Kevin Wolf wrote: > > Am 06.06.2016 um 21:40 hat Colin Lord geschrieben: > >> This commit causes qmp_blockdev_change_medium to report an error if an > >> attempt is made to open a device with a locked tray. > > > > T

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Artyom Tarasenko as SPARC maintainer

2016-06-08 Thread Artyom Tarasenko
Thank you, Mark. Acked-by: Artyom Tarasenko On Wed, Jun 8, 2016 at 12:09 AM, Mark Cave-Ayland wrote: > On 07/06/16 23:04, Mark Cave-Ayland wrote: > >> Artyom has been working on QEMU's SPARC emulation for several years, >> providing >> initial support for Solaris under qemu-system-sparc and mo

Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too

2016-06-08 Thread Daniel P. Berrange
On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote: > MinGW seems to compile currently without warnings, so it should > be safe to enable -Werror now for this environment, too. > > Signed-off-by: Thomas Huth > --- > ... at least it compiles without errors for me here. I hope that's > a

Re: [Qemu-devel] [PATCH v2 1/3] block: Allow replacement of a BDS by its overlay

2016-06-08 Thread Kevin Wolf
Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: > change_parent_backing_link() asserts that the BDS to be replaced is not > used as a backing file. However, we may want to replace a BDS by its > overlay in which case that very link should not be redirected. > > Signed-off-by: Max Reitz So the

Re: [Qemu-devel] [PULL 24/52] docs: Fix a couple of typos in throttle.txt

2016-06-08 Thread Alberto Garcia
On Sun 05 Jun 2016 09:43:01 AM CEST, Michael Tokarev wrote: >- Water leaks from the bucket at a rate of 100 IOPS. >- Water can be added to the bucket at a rate of 2000 IOPS. >- The size of the bucket is 2000 x 60 = 12 > - - If 'iops-total-max-length' is unset then the bucket size

[Qemu-devel] [PULL 06/31] iscsi: Use block size as minimum zero/discard alignment

2016-06-08 Thread Kevin Wolf
From: Eric Blake If hardware does not advertise a minimum zero/discard alignment, we still want to guarantee that the block layer will align requests to our blocks, rather than the arbitrary 512-byte BDRV sector size. Signed-off-by: Eric Blake Signed-off-by: Kevin Wolf --- block/iscsi.c | 5 +

[Qemu-devel] [PULL 00/31] Block layer patches

2016-06-08 Thread Kevin Wolf
The following changes since commit 6ed5546fa7bf12c5b87ef76bafb86e1d77ed6e85: Merge remote-tracking branch 'remotes/mjt/tags/pull-trivial-patches-2016-06-07' into staging (2016-06-07 16:34:45 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[Qemu-devel] [PULL 04/31] qemu-iotests: Test one more spot for optimizing write_zeroes

2016-06-08 Thread Kevin Wolf
From: Eric Blake Add another test to 154, showing that we currently allocate a data cluster in the top layer if any sector of the backing file was allocated. The next patch will optimize this case. Signed-off-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/154 | 40 ++

[Qemu-devel] [PULL 08/31] block: Add .bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Update bdrv_co_do_write_zeroes() to be byte-based, and select between the new byte-based bdrv_co_pwrite_zeroes() or the old bdrv_co_write_zeroes(). The next patches will convert drivers, then remove the old interface. Signed-off-by: Eric Blake Signed-off-by: Kevin Wolf --- b

[Qemu-devel] [PULL 02/31] qcow2: simplify logic in qcow2_co_write_zeroes

2016-06-08 Thread Kevin Wolf
From: "Denis V. Lunev" Unaligned requests will occupy only one cluster. This is true since the previous commit. Simplify the code taking this consideration into account. In other words, the caller is now buggy if it ever passes us an unaligned request that crosses cluster boundaries (the only re

[Qemu-devel] [PULL 07/31] block: Track write zero limits in bytes

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step towards removing sector-based interfaces: convert the maximum write and minimum alignment values from sectors to bytes. Rename the variables to let the compiler check that all users are converted to the new semantics. The maximum remains an int as long as BDRV_REQU

[Qemu-devel] [PULL 01/31] block: split write_zeroes always

2016-06-08 Thread Kevin Wolf
From: "Denis V. Lunev" We should split requests even if they are less than write_zeroes_alignment. For example we can have the following request: offset 62k size 4k write_zeroes_alignment 64k The original code sent 1 request covering 2 qcow2 clusters, and resulted in both clusters being a

[Qemu-devel] [PULL 19/31] migration/block: Convert load to BlockBackend

2016-06-08 Thread Kevin Wolf
This converts the loading part of block migration to use BlockBackend interfaces rather than accessing the BlockDriverState directly. Note that this takes a lazy shortcut. We should really use a separate BlockBackend that is configured for the migration rather than for the guest (e.g. writethrough

[Qemu-devel] [PULL 10/31] iscsi: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. As this is the first byte-based iscsi interface, convert is_request_lun_aligned() into two versions, one for sectors and one for bytes. Also, change from outright -EINVAL failure on an unaligned request, t

[Qemu-devel] [PULL 05/31] qcow2: Catch more unaligned write_zero into zero cluster

2016-06-08 Thread Kevin Wolf
From: Eric Blake is_zero_cluster() and is_zero_cluster_top_locked() are used only by qcow2_co_write_zeroes(). The former is too broad (we don't care if the sectors we are about to overwrite are non-zero, only that all other sectors in the cluster are zero), so it needs to be called up to twice b

[Qemu-devel] [PULL 03/31] qcow2: add tracepoints for qcow2_co_write_zeroes

2016-06-08 Thread Kevin Wolf
From: "Denis V. Lunev" This patch follows guidelines of all other tracepoints in qcow2, like ones in qcow2_co_writev. I think that they should dump values in the same quantities or be changed all together. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Kevin Wolf Message-Id: <1463476543-308

[Qemu-devel] [PULL 21/31] block: assert that bs->request_alignment is a power of 2

2016-06-08 Thread Kevin Wolf
From: Peter Lieven at least bdrv_co_preadv/pwritev expect this. Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 736432f..f54bc25 100644 --- a/block.c +++ b/bl

[Qemu-devel] [PULL 15/31] raw-posix: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. Signed-off-by: Eric Blake [ kwolf: Fixed up trace_paio_submit_co() call for qiov == NULL ] Signed-off-by: Kevin Wolf --- block/raw-posix.c | 34 +- trace-events | 2

[Qemu-devel] [PULL 11/31] qcow2: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. Signed-off-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow2.c | 37 +++-- trace-events | 4 ++-- 2 files changed, 21 insertions(+), 20 deletions(-) diff --git a

[Qemu-devel] [PULL 24/31] block: Fix bdrv_all_delete_snapshot() error handling

2016-06-08 Thread Kevin Wolf
The code to exit the loop after bdrv_snapshot_delete_by_id_or_name() returned failure was duplicated. The first copy of it was too early so that the AioContext lock would not be freed. This patch removes it so that only the second, correct copy remains. Signed-off-by: Kevin Wolf Reviewed-by: Max

[Qemu-devel] [PULL 09/31] block: Switch bdrv_write_zeroes() to byte interface

2016-06-08 Thread Kevin Wolf
From: Eric Blake Rename to bdrv_pwrite_zeroes() to let the compiler ensure we cater to the updated semantics. Do the same for bdrv_co_write_zeroes(). Signed-off-by: Eric Blake Signed-off-by: Kevin Wolf --- block/blkreplay.c | 4 +++- block/io.c | 34 +---

[Qemu-devel] [PULL 18/31] block: Kill bdrv_co_write_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Now that all drivers have been converted to a byte interface, we no longer need a sector interface. Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/io.c| 15 ++- include/block/block_int.h | 2 -- 2 files chan

[Qemu-devel] [PULL 16/31] raw_bsd: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/raw_bsd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/raw_bsd.c b/block/ra

[Qemu-devel] [PULL 25/31] blockdev: clean up error handling in do_open_tray

2016-06-08 Thread Kevin Wolf
From: Colin Lord Returns negative error codes and accompanying error messages in cases where the device has no tray or the tray is locked and isn't forced open. This extra information should result in better flexibility in functions that call do_open_tray. Suggested by: Markus Armbruster Signed

[Qemu-devel] [PULL 29/31] qemu-img bench: Make start offset configurable

2016-06-08 Thread Kevin Wolf
This patch adds an option the specify the offset of the first request made by qemu-img bench. This allows to benchmark misaligned requests. Signed-off-by: Kevin Wolf Reviewed-by: Denis V. Lunev Reviewed-by: Stefan Hajnoczi --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 23 +

[Qemu-devel] [PULL 13/31] gluster: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/gluster.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/block/gluster.c b/block

[Qemu-devel] [PULL 20/31] migration/block: Convert saving to BlockBackend

2016-06-08 Thread Kevin Wolf
This creates a new BlockBackend for copying data from an images to the migration stream on the source host. All I/O for block migration goes through BlockBackend now. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- migration/block.c | 124 ++---

[Qemu-devel] [PULL 31/31] qemu-img bench: Add --flush-interval

2016-06-08 Thread Kevin Wolf
This options allows to flush the image periodically during write tests. Signed-off-by: Kevin Wolf Reviewed-by: Denis V. Lunev Reviewed-by: Stefan Hajnoczi --- qemu-img-cmds.hx | 4 +-- qemu-img.c | 95 ++-- qemu-img.texi| 8 -

[Qemu-devel] [PATCH v3 0/7] virtio-blk: multiqueue support

2016-06-08 Thread Stefan Hajnoczi
v3: * Drop Patch 1 to batch guest notify for non-dataplane The Linux AIO completion BH and the virtio-blk batch notify BH changed order in the AioContext->first_bh list as a side-effect of moving the BH from hw/block/dataplane/virtio-blk.c to hw/block/virtio-blk.c. This caused a seri

[Qemu-devel] [PULL 14/31] qed: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. Kill an abuse of the comma operator while at it (fortunately, the semantics were still right). Also, the test for requests not aligned to clusters should be applied always, not just when a backing file is

[Qemu-devel] [PULL 22/31] raw-posix: Fetch max sectors for host block device

2016-06-08 Thread Kevin Wolf
From: Fam Zheng This is sometimes a useful value we should count in. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/raw-posix.c | 24 1 file changed, 24 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index ce1c

[Qemu-devel] [PATCH v3 4/7] virtio-blk: associate request with a virtqueue

2016-06-08 Thread Stefan Hajnoczi
Multiqueue requires that each request knows to which virtqueue it belongs. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 20 +++- include/hw/virtio/virtio-blk.h | 4 +++- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/block/virtio-blk.c

[Qemu-devel] [PATCH v3 2/7] virtio-blk: multiqueue batch notify

2016-06-08 Thread Stefan Hajnoczi
The batch notification BH needs to know which virtqueues to notify when multiqueue is enabled. Use a bitmap to track the virtqueues with pending notifications. At this point there is only one virtqueue so hard-code virtqueue index 0. A later patch will switch to real virtqueue indices. Signed-o

[Qemu-devel] [PULL 17/31] vmdk: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/vmdk.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c

[Qemu-devel] [PULL 30/31] qemu-img bench: Implement -S (step size)

2016-06-08 Thread Kevin Wolf
With this new option, qemu-img bench can be told to advance the current offset after each request by a different value than the buffer size. This is useful for controlling the conditions for cluster allocation in image formats (e.g. qcow2 cluster allocation with COW in front of the request, or COW

Re: [Qemu-devel] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Kevin Wolf
Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: > Currently, we are trying to move the backing BDS from the source to the > target in bdrv_replace_in_backing_chain() which is called from > mirror_exit(). However, mirror_complete() already tries to open the > target's backing chain with a call to

[Qemu-devel] [PATCH v3 6/7] virtio-blk: dataplane multiqueue support

2016-06-08 Thread Stefan Hajnoczi
Monitor ioeventfds for all virtqueues in the device's AioContext. This is not true multiqueue because requests from all virtqueues are processed in a single IOThread. In the future it will be possible to use multiple IOThreads when the QEMU block layer supports multiqueue. Signed-off-by: Stefan

[Qemu-devel] [PULL 12/31] blkreplay: Convert to bdrv_co_pwrite_zeroes()

2016-06-08 Thread Kevin Wolf
From: Eric Blake Another step on our continuing quest to switch to byte-based interfaces. Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/blkreplay.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block/blkreplay.c b/block

Re: [Qemu-devel] [PATCH 14/18] linux-user: Use __get_user() and __put_user() to handle structs in do_fcntl()

2016-06-08 Thread Laurent Vivier
Le 07/06/2016 à 23:20, Peter Maydell a écrit : > On 7 June 2016 at 21:41, Laurent Vivier wrote: >>> -fl64.l_type = >>> - target_to_host_bitmask(tswap16(target_fl64->l_type), flock_tbl) >>> >> 1; >> >> The ">> 1" disappears... > > ...and it's correct that it disappears, right?

[Qemu-devel] [Bug 1590336] [NEW] qemu-arm does not reject vrintz on non-v8 cpu

2016-06-08 Thread Christophe Lyon
Public bug reported: Hello, It seems that qemu-arm does not reject some v8-only instructions as it should, but executes them "correctly". For instance, while compiling/running some of the GCC ARM instrinsics tests, we noticed that vrintz should be rejected on cortex-a9 for instance, while it is

[Qemu-devel] [PULL 23/31] qcow2: avoid extra flushes in qcow2

2016-06-08 Thread Kevin Wolf
From: "Denis V. Lunev" The problem with excessive flushing was found by a couple of performance tests: - parallel directory tree creation (from 2 processes) - 32 cached writes + fsync at the end in a loop For the first one results improved from 2.6 loops/sec to 3.5 loops/sec. Each loop creat

[Qemu-devel] [PATCH v3 3/7] virtio-blk: tell dataplane which vq to notify

2016-06-08 Thread Stefan Hajnoczi
Let the virtio_blk_data_plane_notify() caller decide which virtqueue to notify. This will allow the function to be used with multiqueue. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 4 ++-- hw/block/dataplane/virtio-blk.h | 2 +- hw/block/virtio-blk.c | 2 +- 3

[Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

2016-06-08 Thread Denis V. Lunev
From: Vladimir Sementsov-Ogievskiy Acquire aio context before run command, this is mandatory for unit tests. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Paolo Bonzini --- hmp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hmp.c b/

[Qemu-devel] [PULL 27/31] qemu-img bench

2016-06-08 Thread Kevin Wolf
This adds a qemu-img command that allows doing some simple benchmarks for the block layer without involving guest devices and a real VM. For the start, this implements only a test of sequential reads. Signed-off-by: Kevin Wolf Reviewed-by: Denis V. Lunev Reviewed-by: Stefan Hajnoczi --- qemu-

[Qemu-devel] [RFC] hw/i386: Composite Bus and PCI device

2016-06-08 Thread David Kiarie
Sample composite SysBus and PCI device similar to AMD IOMMU setup Signed-off-by: David Kiarie --- hw/i386/compositedevice.c | 113 ++ 1 file changed, 113 insertions(+) create mode 100644 hw/i386/compositedevice.c diff --git a/hw/i386/compositedevice.

[Qemu-devel] [PATCH v3 5/7] virtio-blk: live migrate s->rq with multiqueue

2016-06-08 Thread Stefan Hajnoczi
Add a field for the virtqueue index when migrating the s->rq request list. The new field is only needed when num_queues > 1. Existing QEMUs are unaffected by this change and therefore virtio-blk migration stays compatible. Suggested-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/bloc

[Qemu-devel] [PULL 00/50] Trivial patches for 2016-06-08

2016-06-08 Thread Michael Tokarev
Here's yet another attempt to process -trivial queue. 3rd is the best, it looks like :) I dropped one more patch from the series, per request from author, "docs: Fix a couple of typos in throttle.txt". Not resending anything this time, as the queue is just one patch shorter now. Thanks, and sorr

[Qemu-devel] [PULL 28/31] qemu-img bench: Sequential writes

2016-06-08 Thread Kevin Wolf
This extends qemu-img bench with an option that makes it use sequential writes instead of reads for the test run. Signed-off-by: Kevin Wolf Reviewed-by: Denis V. Lunev Reviewed-by: Stefan Hajnoczi --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 38 +- qem

Re: [Qemu-devel] [RFC 01/10] exec: Introduce tcg_exclusive_{lock, unlock}()

2016-06-08 Thread alvise rigo
As far as I understand, linux-user uses a mutex to make the atomic accesses exclusive with respect to other CPU's atomic accesses. So basically in the LDREX case it implements: lock() -> access() -> unlock() This patch series makes the atomic accesses exclusive with respect to every memory access,

[Qemu-devel] [PULL 26/31] block: Don't emulate natively supported pwritev flags

2016-06-08 Thread Kevin Wolf
Drivers that implement .bdrv_co_pwritev() get the flags passed as an argument to said function, but we also unconditionally emulate the flags anyway. We shouldn't do that. Fix this by clearing all flags that the driver supports natively after it returns from .bdrv_co_pwritev(). Fixes: 4df863f3 ('

Re: [Qemu-devel] [PULL 24/52] docs: Fix a couple of typos in throttle.txt

2016-06-08 Thread Michael Tokarev
08.06.2016 12:00, Alberto Garcia wrote: > On Sun 05 Jun 2016 09:43:01 AM CEST, Michael Tokarev wrote: > >>- Water leaks from the bucket at a rate of 100 IOPS. >>- Water can be added to the bucket at a rate of 2000 IOPS. >>- The size of the bucket is 2000 x 60 = 12 >> - - If 'iops-

Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init()

2016-06-08 Thread Cao jin
ping~ On 06/06/2016 04:00 PM, Cao jin wrote: v7 changelog: 1. 4 new patches, patch 11, 13, 14, 15. previous patch 11 numbered 12 now. 2. patch 2: remove comment of "errp", add it in patch 12 3. patch 4: fix commit message as sugguestion 4. replace all "msi == ON_OFF_AUTO_ON || msi == ON_OFF_AUTO

Re: [Qemu-devel] [PATCH 00/18] linux-user: Extend safe_syscall wrapper use

2016-06-08 Thread Riku Voipio
On Mon, Jun 06, 2016 at 07:58:01PM +0100, Peter Maydell wrote: > This set of pretty dull patches extends the use of the safe_syscall > wrapper to every syscall listed in the signal(7) manpage as being > interruptible. > > Most of the patches are just straightforward "use the wrapper" changes. > For

Re: [Qemu-devel] [RFC 01/10] exec: Introduce tcg_exclusive_{lock, unlock}()

2016-06-08 Thread Alex Bennée
Alvise Rigo writes: > Add tcg_exclusive_{lock,unlock}() functions that will be used for making > the emulation of LL and SC instructions thread safe. I wonder how much similarity there is to the mechanism linus-user ends up using for it's exclusive-start/end? > > Signed-off-by: Alvise Rigo >

[Qemu-devel] [PATCH v3 1/7] virtio-blk: add VirtIOBlockConf->num_queues

2016-06-08 Thread Stefan Hajnoczi
The num_queues field is always 1 for the time being. A later patch will make it a configurable device property so that multiqueue can be enabled. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 1 + include/hw/virtio/virtio-blk.h | 1 + 2 files changed, 2 insertions(+) diff

[Qemu-devel] [PATCH v3 7/7] virtio-blk: add num-queues device property

2016-06-08 Thread Stefan Hajnoczi
Multiqueue virtio-blk can be enabled as follows: qemu -device virtio-blk-pci,num-queues=8 Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 15 +-- include/hw/virtio/virtio-blk.h | 1 - 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/block/vir

Re: [Qemu-devel] [PATCH v2 18/19] linux-user: Avoid possible misalignment in host_to_target_siginfo()

2016-06-08 Thread Laurent Vivier
Le 07/06/2016 à 23:08, Peter Maydell a écrit : > On 7 June 2016 at 20:36, Laurent Vivier wrote: >> >> >> Le 27/05/2016 à 16:52, Peter Maydell a écrit : >>> host_to_target_siginfo() is implemented by a combination of >>> host_to_target_siginfo_noswap() followed by tswap_siginfo(). >>> The first o

Re: [Qemu-devel] [Qemu-stable] [PATCH V2] net: fix qemu_announce_self not emitting packets

2016-06-08 Thread Paolo Bonzini
- Original Message - > From: "Jason Wang" > To: "Peter Lieven" , qemu-devel@nongnu.org > Cc: pbonz...@redhat.com, qemu-sta...@nongnu.org, "hongyang yang" > > Sent: Wednesday, June 8, 2016 9:54:53 AM > Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH V2] net: fix > qemu_announce_self not

Re: [Qemu-devel] [for-2.7 PATCH v3 07/15] spapr: Abstract CPU core device and type specific core devices

2016-06-08 Thread Bharata B Rao
On Fri, Jun 03, 2016 at 03:25:08PM +1000, David Gibson wrote: > On Thu, May 12, 2016 at 09:18:17AM +0530, Bharata B Rao wrote: > > Add sPAPR specific abastract CPU core device that is based on generic > > CPU core device. Use this as base type to create sPAPR CPU specific core > > devices. > > > >

Re: [Qemu-devel] [kvm-unit-tests PATCH v2 00/10] arm/arm64: add gic framework

2016-06-08 Thread Andrew Jones
On Tue, Jun 07, 2016 at 06:13:53PM +0100, Alex Bennée wrote: > > Alex Bennée writes: > > > Andrew Jones writes: > > > >> v2: > >> Rebased on on latest master + my "populate argv[0]" series (will > >> send a REPOST for that shortly. Additionally a few patches got > >> fixes/features; > >> 07

[Qemu-devel] [RFC] AMD IOMMU: emulate multiple devices

2016-06-08 Thread David Kiarie
Hello all, This patch tries to solve a problem whereby real AMD IOMMUs exhibit both PCI and Platform device properties. AMD IOMMU properties that conflict with conventional PCI devices' features include the fact that its not a BusMaster device and reserves MMIO region without a BAR register amo

Re: [Qemu-devel] [PATCH 2/3] replay: allow replay stopping and restarting

2016-06-08 Thread Paolo Bonzini
- Original Message - > From: "Pavel Dovgalyuk" > To: qemu-devel@nongnu.org > Cc: pbonz...@redhat.com, jasow...@redhat.com, ag...@suse.de, > da...@gibson.dropbear.id.au > Sent: Wednesday, June 8, 2016 7:14:04 AM > Subject: [PATCH 2/3] replay: allow replay stopping and restarting > > Thi

Re: [Qemu-devel] [PULL 24/52] docs: Fix a couple of typos in throttle.txt

2016-06-08 Thread Alberto Garcia
On Wed 08 Jun 2016 11:44:35 AM CEST, Michael Tokarev wrote: > 08.06.2016 12:00, Alberto Garcia wrote: >> On Sun 05 Jun 2016 09:43:01 AM CEST, Michael Tokarev wrote: >> >>>- Water leaks from the bucket at a rate of 100 IOPS. >>>- Water can be added to the bucket at a rate of 2000 IOPS. >>>

[Qemu-devel] [PATCH v2] net: mipsnet: check transmit buffer size before sending

2016-06-08 Thread P J P
From: Prasad J Pandit When processing MIPSnet I/O port write operation, it uses a transmit buffer tx_buffer[MAX_ETH_FRAME_SIZE=1514]. Two indices 's->tx_written' and 's->tx_count' are used to control data written to this buffer. If the two were to be equal before writing, it'd lead to an OOB writ

Re: [Qemu-devel] [RFC 00/14] vhost-user backends for gpu & input virtio devices

2016-06-08 Thread Gerd Hoffmann
On Di, 2016-06-07 at 11:01 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Mo, 2016-06-06 at 15:54 +0200, Marc-André Lureau wrote: > > > Hi Gerd > > > > > > Thanks for your feedback on the series. Your remarks are all valid, > > > but before doing more work I would li

[Qemu-devel] [PATCH] ui: fix regression in printing VNC host/port on startup

2016-06-08 Thread Daniel P. Berrange
If VNC is chosen as the compile time default display backend, QEMU will print the host/port it listens on at startup. Previously this would look like VNC server running on '::1:5900' but in 04d2529da27db512dcbd5e99d0e26d333f16efcc the ':' was accidentally replaced with a ';'. This the ':' back.

[Qemu-devel] [PATCH] docs: Fix description of the leaky bucket algorithm in throttle.txt

2016-06-08 Thread Alberto Garcia
Commit 0bab0ebb17759c926bd48fd396bd8cbb2c8e4a3e was supposed to fix a mistake in the description of the leaky bucket algorithm, but the version that finally landed after the review process was incorrect. This patch solves that problem and hopefully clarifies the description a bit better. Signed-o

Re: [Qemu-devel] [PATCH] docs: Fix description of the leaky bucket algorithm in throttle.txt

2016-06-08 Thread Michael Tokarev
08.06.2016 13:54, Alberto Garcia wrote: > Commit 0bab0ebb17759c926bd48fd396bd8cbb2c8e4a3e was supposed to fix > a mistake in the description of the leaky bucket algorithm, but the > version that finally landed after the review process was incorrect. > > This patch solves that problem and hopefully

[Qemu-devel] [PATCH 1/7] linux-headers: update

2016-06-08 Thread Cornelia Huck
Update to 4.7-rc2. Signed-off-by: Cornelia Huck --- include/standard-headers/linux/pci_regs.h | 20 +++- include/standard-headers/linux/virtio_config.h | 2 ++ linux-headers/asm-arm/unistd.h | 2 ++ linux-headers/asm-arm64/unistd.h | 3 +++ l

[Qemu-devel] [PATCH 2/7] s390x/kvm: add interface for clearing IO irqs

2016-06-08 Thread Cornelia Huck
From: Halil Pasic According to the platform specification, under certain conditions, pending IO interruptions have to be cleared. Let's add an interface for that. Signed-off-by: Halil Pasic Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- hw/intc/s390_flic.c | 8

[Qemu-devel] [PATCH 0/7] s390x: next batch of patches

2016-06-08 Thread Cornelia Huck
More s390x patches, this time mostly dealing with channel I/O: Bugfixes and cleanups, and dequeue pending interrupts after machine checks. Christian Borntraeger (3): virtio-ccw: Provide traces for indicator changes s390x: Limit s390-ccw machines to 248 CPUs s390x/kvm: Fixup interrupt type fo

[Qemu-devel] [PATCH 4/7] s390x/css: introduce property type for device ids

2016-06-08 Thread Cornelia Huck
Let's introduce a CssDevId to handle device ids of the xx.x. type used for channel devices. This has some benefits: - We can use them in virtio-ccw and split the validity checks for a channel device id in general from the constraint checking within the virtio-ccw scope. - We can reuse the

[Qemu-devel] [PATCH 3/7] s390x/css: clear IO irqs when generating IPI CRW

2016-06-08 Thread Cornelia Huck
From: Halil Pasic According to the Principles of Operation (more precisely the subsection 'Channel-Report Word'), a subchannel put into the installed parameters initialized state is in the same state as after an I/O system reset (just parameters possibly changed). This implies that any I/O interr

[Qemu-devel] [PATCH 6/7] s390x: Limit s390-ccw machines to 248 CPUs

2016-06-08 Thread Cornelia Huck
From: Christian Borntraeger The sclp scp read info call fills in a buffer with information about the system. With more than 248 CPUs we overflow the 4k buffer of the SCCB, leading to random data corruption. Basically ALL guest operating systems call scp read info, so let's limit the machines to 2

[Qemu-devel] [PATCH 5/7] virtio-ccw: Provide traces for indicator changes

2016-06-08 Thread Cornelia Huck
From: Christian Borntraeger This allows to trace changes in the summary and queue indicators for the non-irqfd case. For irqfd, kernel traces are needed instead. Signed-off-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 1 + trace-events | 1 + 2 f

[Qemu-devel] [PATCH 7/7] s390x/kvm: Fixup interrupt type for non-adapter I/O interrupts

2016-06-08 Thread Cornelia Huck
From: Christian Borntraeger The current algorithm for I/O interrupts would result in a wrong interrupt type for subchannel numbers fffe and . In addition a non adapter interrupt might look like an adapter interrupt for any subchannel number that has the 0x0400 bit set. No kernel has ever use

Re: [Qemu-devel] [PATCH v2 1/3] hw/pci: delay bus_master_enable_region initialization

2016-06-08 Thread Paolo Bonzini
- Original Message - > From: "Marcel Apfelbaum" > To: qemu-devel@nongnu.org > Cc: mar...@redhat.com, m...@redhat.com, pbonz...@redhat.com, > ehabk...@redhat.com, pet...@redhat.com, > davidkiar...@gmail.com, "jan kiszka" , "bd aviv" > , "alex williamson" > > Sent: Thursday, June 2, 201

Re: [Qemu-devel] [PATCH v2 3/3] q35: allow dynamic sysbus

2016-06-08 Thread Marcel Apfelbaum
On 06/08/2016 05:56 AM, Peter Xu wrote: On Thu, Jun 02, 2016 at 11:15:55PM +0300, Marcel Apfelbaum wrote: Allow adding sysbus devices with -device on Q35. At first Q35 will support only intel-iommu to be added this way, however the command line will support all sysbus devices. Mark with 'canno

Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

2016-06-08 Thread Kevin Wolf
Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben: > From: Vladimir Sementsov-Ogievskiy > > Acquire aio context before run command, this is mandatory for unit tests. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Paolo Bonzini Look

Re: [Qemu-devel] [PATCH] vl: Eliminate usb_enabled()

2016-06-08 Thread Marcel Apfelbaum
On 06/07/2016 07:56 PM, Eduardo Habkost wrote: This wrapper for machine_usb(current_machine) is not necessary, replace all usages of usb_enabled() with machine_usb(). Signed-off-by: Eduardo Habkost --- hw/arm/nseries.c| 2 +- hw/arm/pxa2xx.c | 7 +-- hw/arm/realview.c

Re: [Qemu-devel] [PATCH 00/18] linux-user: Extend safe_syscall wrapper use

2016-06-08 Thread Peter Maydell
On 8 June 2016 at 10:20, Riku Voipio wrote: > I've merged most of this now to to: > > https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/linux-user-for-upstream > > With the changes of Adding Laurent's reviewed by's where given and > And adjusted changed to "abi_llong" in "Corr

Re: [Qemu-devel] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Paolo Bonzini
- Original Message - > From: "Kevin Wolf" > To: "Max Reitz" > Cc: qemu-bl...@nongnu.org, qemu-devel@nongnu.org, "Fam Zheng" > , nsof...@redhat.com, > ebl...@redhat.com, pbonz...@redhat.com > Sent: Wednesday, June 8, 2016 11:32:29 AM > Subject: Re: [PATCH v2 2/3] block/mirror: Fix targe

Re: [Qemu-devel] [PATCH v2 18/19] linux-user: Avoid possible misalignment in host_to_target_siginfo()

2016-06-08 Thread Peter Maydell
On 8 June 2016 at 10:29, Laurent Vivier wrote: > > > Le 07/06/2016 à 23:08, Peter Maydell a écrit : >> On 7 June 2016 at 20:36, Laurent Vivier wrote: >>> >>> >>> Le 27/05/2016 à 16:52, Peter Maydell a écrit : host_to_target_siginfo() is implemented by a combination of host_to_target_sig

Re: [Qemu-devel] [PATCH 1/1] hmp: acquire aio_context in hmp_qemu_io

2016-06-08 Thread Denis V. Lunev
On 06/08/2016 02:23 PM, Kevin Wolf wrote: Am 08.06.2016 um 11:39 hat Denis V. Lunev geschrieben: From: Vladimir Sementsov-Ogievskiy Acquire aio context before run command, this is mandatory for unit tests. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Kevin W

  1   2   3   4   >