On Wed, Jun 08, 2016 at 08:59:30AM +0200, Thomas Huth wrote: > On 08.06.2016 07:44, David Gibson wrote: > > On Tue, Jun 07, 2016 at 05:39:39PM +0200, Thomas Huth wrote: > >> When using an olderr PowerISA level, all the upper compatibility > >> bits have to be enabled, too. For example when we want to run > >> something in PowerISA 2.05 compatibility mode on POWER8, the bit > >> for 2.06 has to be set beside the bit for 2.05. > >> Additionally, to make sure that we do not set bits that are not > >> supported by the host, we apply a mask with the known-to-be-good > >> bits here, too. > >> > >> Signed-off-by: Thomas Huth <th...@redhat.com> > > > > So, this breaks compile on 32-bit targets, because the spr values are > > only 32-bit there, and the PCR constants exceed that. But > > ppc_set_compat() is only actually used on 64-bit machines, so I've > > added a change to #if it out for 64-bit targets. > > D'oh, I explicitly compiled everything with a mingw32 cross-compiler to > catch such issues ... but apparently it compiled without -Werror here, > so I did not notice the warning :-(
No, not 32-bit *host*, 32-bit *target*, so mingw32 wouldn't help.
Configuring in ppc-softmmu and ppcemb-softmmu would.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
