[Qemu-devel] [PULL V4 07/31] pci: Introduce define for PM capability version 1.1

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- include/hw/pci/pci_regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/pci/pci_regs.h b/include/hw/pci/pci_regs.h index ba8cbe9..

[Qemu-devel] [PULL V4 13/31] vmxnet3: Use common MAC address tracing macros

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/net/vmxnet3.c | 8 hw/net/vmxnet_debug.h | 3 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/net/vmxnet3.c b/

[Qemu-devel] [PULL V4 05/31] pci: fix unaligned access in pci_xxx_quad()

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Replace legacy cpu_to_le64w()/le64_to_cpup() calls with stq_le_p()/ldq_le_p(). Motivation for this modification is that follow up patches add utility function pcie_dev_ser_num_init() for PCIe DSN capability creation which uses pci_set_quad() with a misaligned offset. Signe

[Qemu-devel] [PULL V4 08/31] pcie: Add support for PCIe CAP v1

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Added support for PCIe CAP v1, while reusing some of the existing v2 infrastructure. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/pci/pcie.c | 84 +++

[Qemu-devel] [PULL V4 15/31] rtl8139: Move more TCP definitions to common header

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/net/rtl8139.c | 5 - include/net/eth.h | 8 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net

[Qemu-devel] [PULL V4 19/31] e1000: Move out code that will be reused in e1000e

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Code that will be shared moved to a separate files. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- MAINTAINERS| 5 + hw/net/Makefile.objs | 2 +- hw/net/e1000.c | 411 ++

[Qemu-devel] [PULL V4 04/31] net/net: Add SocketReadState for reuse codes

2016-06-02 Thread Jason Wang
From: Zhang Chen This function is from net/socket.c, move it to net.c and net.h. Add SocketReadState to make others reuse net_fill_rstate(). suggestion from jason. v4: - move 'rs->finalize = finalize' to rs_init() v3: - remove SocketReadState init callback - put finalize callback to net_fill

[Qemu-devel] [PULL V4 09/31] pcie: Introduce function for DSN capability creation

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/pci/pcie.c | 10 ++ include/hw/pci/pcie.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c in

[Qemu-devel] [PULL V4 11/31] net: Introduce Toeplitz hash calculator

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- include/net/checksum.h | 45 + 1 file changed, 45 insertions(+) diff --git a/include/net/checksum.h b/in

[Qemu-devel] [PULL V4 25/31] i.MX: Fix FEC code for MDIO address selection

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois According to the FEC chapter of i.MX25 reference manual When writing to MMFR register, the MDIO device and adress are selected by bit 27 to 23 and bit 22 to 18 respectively. This is a total of 10 bits that need to be used by the Phy chip/address decoding function. T

[Qemu-devel] [PULL V4 14/31] net_pkt: Name vmxnet3 packet abstractions more generic

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman This patch drops "vmx" prefix from packet abstractions names to emphasize the fact they are generic and not tied to any specific network device. These abstractions will be reused by e1000e emulation implementation introduced by following patches so their names need generali

[Qemu-devel] [PULL V4 28/31] i.MX: Rename i.MX FEC defines to ENET_XXX

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois Signed-off-by: Jean-Christophe Dubois Signed-off-by: Jason Wang --- hw/net/imx_fec.c | 54 include/hw/net/imx_fec.h | 64 2 files changed, 59 insertions(+), 59 deletio

[Qemu-devel] [PULL V4 17/31] vmxnet3: Use pci_dma_* API instead of cpu_physical_memory_*

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman To make this device and network packets abstractions ready for IOMMU. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/net/net_tx_pkt.c | 16 +++- hw/net/net_tx_pkt.h | 5 +++-- hw/

[Qemu-devel] [PULL V4 16/31] net_pkt: Extend packet abstraction as required by e1000e functionality

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman This patch extends the TX/RX packet abstractions with features that will be used by the e1000e device implementation. Changes are: 1. Support iovec lists for RX buffers 2. Deeper RX packets parsing 3. Loopback option for TX packets 4. Extended VLAN headers handling

Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fetch max sectors for host block device from sysfs

2016-06-02 Thread Fam Zheng
On Thu, 05/26 14:15, Fam Zheng wrote: > This is sometimes a useful value we should count in. Kevin, Max, could you review this please? Fam > > Signed-off-by: Fam Zheng > --- > block/raw-posix.c | 47 +++ > 1 file changed, 47 insertions(+) > > diff

[Qemu-devel] [PULL V4 29/31] i.MX: move FEC device to a register array structure.

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois This is to prepare for the ENET Gb device of the i.MX6. Signed-off-by: Jean-Christophe Dubois Signed-off-by: Jason Wang --- hw/net/imx_fec.c | 398 ++- include/hw/net/imx_fec.h | 51 -- 2 files changed, 256

[Qemu-devel] [PULL V4 21/31] e1000e: Introduce qtest for e1000e device

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- tests/Makefile | 3 + tests/e1000e-test.c | 479 2 files changed, 482 insertions(+) crea

[Qemu-devel] [PATCH] 9p: drop useless inclusion of hw/i386/pc.h

2016-06-02 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |1 - hw/9pfs/virtio-9p-device.c |1 - 2 files changed, 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index aab1da116894..587e901f81cc 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -13,7 +13,6 @@ #include "qemu/osdep.

[Qemu-devel] [PULL V4 18/31] e1000_regs: Add definitions for Intel 82574-specific bits

2016-06-02 Thread Jason Wang
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch Reviewed-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/net/e1000_regs.h | 345 +++- 1 file changed, 342 insertions(+), 3 deletions(-) diff --git a/hw/ne

[Qemu-devel] [PULL V4 31/31] Add ENET device to i.MX6 SOC.

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois This adds the ENET device to the i.MX6 SOC. This was tested by booting Linux on an Qemu i.MX6 instance and accessing the internet from the linux guest. Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois Signed-off-by: Jason Wang --- hw/arm/fsl-imx6

[Qemu-devel] [PULL V4 22/31] net: improve UDP/TCP checksum computation.

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois * based on Eth, UDP, TCP struct present in eth.h instead of hardcoded indexes and sizes. * based on various macros present in eth.h. Signed-off-by: Jean-Christophe Dubois Signed-off-by: Jason Wang --- net/checksum.c | 94 ++

[Qemu-devel] [PULL V4 24/31] i.MX: Fix FEC code for MDIO operation selection

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois According to the FEC chapter of i.MX25 reference manual When writing the MMFR register, bit 29 and 28 select the requested operation. * 10 means read operation with valid MII mgmt frame * 11 means read operation with non compliant MII mgmt frame * 01 means write o

[Qemu-devel] [PULL V4 23/31] net: handle optional VLAN header in checksum computation.

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois Signed-off-by: Jean-Christophe Dubois Signed-off-by: Jason Wang --- net/checksum.c | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/net/checksum.c b/net/checksum.c index 39ad73f..23323b0 100644 --- a/net/check

[Qemu-devel] [PULL V4 26/31] i.MX: Fix FEC code for ECR register reset value.

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois According to the FEC chapter of i.MX25 reference manual ECR register is initialized at 0xf000 at reset time. We fix the value. Signed-off-by: Jean-Christophe Dubois Signed-off-by: Jason Wang --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Qemu-devel] [PULL V4 27/31] i.MX: reset TX/RX descriptors when FEC is disabled.

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois According to the FEC chapter of i.MX25 reference manual RX adn TX descriptors are reseted when the FEC device is disabled through ECR. Signed-off-by: Jean-Christophe Dubois Signed-off-by: Jason Wang --- hw/net/imx_fec.c | 2 ++ 1 file changed, 2 insertions(+) di

[Qemu-devel] [PULL V4 30/31] Add ENET/Gbps Ethernet support to FEC device

2016-06-02 Thread Jason Wang
From: Jean-Christophe Dubois The ENET device (present in i.MX6) is "derived" from FEC and backward compatible with it. This patch adds the necessary support of the added feature in the ENET device to allow Linux to use it (on supported processors). Signed-off-by: Jean-Christophe Dubois Signed-

Re: [Qemu-devel] [RFC PATCH v0 0/2] Increase max memslots to 512 for PowerPC

2016-06-02 Thread Thomas Huth
On 02.06.2016 06:39, Bharata B Rao wrote: ... > Agreed. Here is the updated patch: > > spapr: Increase hotpluggable memory slots to 256 > > From: Bharata B Rao > > KVM now supports 512 memslots on PowerPC (earlier it was 32). Allow half > of it (256) to be used as hotpluggable memory slots. >

Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-06-02 Thread Cédric Le Goater
On 06/02/2016 05:17 AM, David Gibson wrote: > On Wed, Jun 01, 2016 at 08:03:08AM +0100, Mark Cave-Ayland wrote: >> On 01/06/16 03:15, David Gibson wrote: >> >>> On Tue, May 31, 2016 at 11:28:49PM +0100, Mark Cave-Ayland wrote: On 31/05/16 01:41, David Gibson wrote: > From: Benjamin He

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

2016-06-02 Thread Michal Privoznik
On 01.06.2016 18:16, Wei Xu wrote: > On 2016年06月01日 00:44, Daniel P. Berrange wrote: >> On Wed, Jun 01, 2016 at 12:30:44AM +0800, w...@redhat.com wrote: >>> From: Wei Xu >>> >>> Recently I'm working on a fd passing issue, selinux forbids qemu to >>> create a unix socket for a chardev when managing

Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-06-02 Thread Mark Cave-Ayland
On 02/06/16 08:37, Cédric Le Goater wrote: > On 06/02/2016 05:17 AM, David Gibson wrote: >> On Wed, Jun 01, 2016 at 08:03:08AM +0100, Mark Cave-Ayland wrote: >>> On 01/06/16 03:15, David Gibson wrote: >>> On Tue, May 31, 2016 at 11:28:49PM +0100, Mark Cave-Ayland wrote: > On 31/05/16 01:41

Re: [Qemu-devel] [RFC PATCH v4 3/3] VFIO Type1 IOMMU: Add support for mediated devices

2016-06-02 Thread Neo Jia
On Wed, Jun 01, 2016 at 04:40:19PM +0800, Dong Jia wrote: > On Wed, 25 May 2016 01:28:17 +0530 > Kirti Wankhede wrote: > > > + > > +/* > > + * Pin a set of guest PFNs and return their associated host PFNs for API > > + * supported domain only. > > + * @vaddr [in]: array of guest PFNs > > + * @npa

Re: [Qemu-devel] [PATCH] block/raw-posix: Fix error_report of mounting message

2016-06-02 Thread Markus Armbruster
Wei Jiangang writes: > Use a single error_printf to replace triple error_report. > > Signed-off-by: Wei Jiangang > --- > block/raw-posix.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index a4f5a1b..141b01a 100644 >

Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-06-02 Thread Cédric Le Goater
On 06/02/2016 09:45 AM, Mark Cave-Ayland wrote: > On 02/06/16 08:37, Cédric Le Goater wrote: >> On 06/02/2016 05:17 AM, David Gibson wrote: >>> On Wed, Jun 01, 2016 at 08:03:08AM +0100, Mark Cave-Ayland wrote: On 01/06/16 03:15, David Gibson wrote: > On Tue, May 31, 2016 at 11:28:49PM

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

2016-06-02 Thread Daniel P. Berrange
On Thu, Jun 02, 2016 at 09:41:56AM +0200, Michal Privoznik wrote: > On 01.06.2016 18:16, Wei Xu wrote: > > On 2016年06月01日 00:44, Daniel P. Berrange wrote: > >> On Wed, Jun 01, 2016 at 12:30:44AM +0800, w...@redhat.com wrote: > >>> From: Wei Xu > >>> > >>> Recently I'm working on a fd passing issue

Re: [Qemu-devel] [PATCH] ps2: take exact use of ps2 buffer

2016-06-02 Thread Gerd Hoffmann
On Do, 2016-06-02 at 14:05 +0800, Yang Hongyang wrote: > According to PS/2 Mouse/Keyboard Protocol, the keyboard output buffer > size is 16 bytes, but we only use 15 bytes actually, this causes some > problem, for example, if I submit "123456789" in a bunch through VNC, > the actual result will be

Re: [Qemu-devel] [PATCH v6 07/11] intel-hda: change msi property type

2016-06-02 Thread Cao jin
On 06/01/2016 04:39 PM, Markus Armbruster wrote: Cao jin writes: Not covered: static void intel_hda_update_irq(IntelHDAState *d) { -->int msi = d->msi && msi_enabled(&d->pci); int level; intel_hda_update_int_sts(d); if (d->int_sts & (1U << 31) && d->int_

Re: [Qemu-devel] [PATCH 4/6 Resend] Vhost-pci RFC: Detailed Description in the Virtio Specification Format

2016-06-02 Thread Wang, Wei W
On Thu 6/2/2016 11:52 AM, Xiao Guangrong wrote: > On 06/02/2016 11:15 AM, Wang, Wei W wrote: > > On Wed 6/1/2016 4:15 PM, Xiao Guangrong wrote: > >> On 05/29/2016 04:11 PM, Wei Wang wrote: > >>> Signed-off-by: Wei Wang > >>> --- > >>>Details | 324 > >> > ++

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-02 Thread Peter Xu
On Sat, May 21, 2016 at 06:42:03PM +0200, Jan Kiszka wrote: > On 2016-05-21 18:19, Aviv B.D wrote: > > From: "Aviv Ben-David" > > > > This flag tells the guest to invalidate tlb cache also after unmap > > operations. > > > > Signed-off-by: Aviv Ben-David > > --- > > hw/i386/intel_iommu.c

Re: [Qemu-devel] [PATCH] throttle: refuse iops-size without iops-total/read/write

2016-06-02 Thread Alberto Garcia
On Thu 02 Jun 2016 02:40:31 AM CEST, Stefan Hajnoczi wrote: > In a similar vein to commit ee2bdc33c913b7d765baa5aa338c29fb30a05c9a > ("throttle: refuse bps_max/iops_max without bps/iops") it is likely that > the user made a configuration error if iops-size has been set but no > iops limit has bee

Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-06-02 Thread Mark Cave-Ayland
On 02/06/16 09:23, Cédric Le Goater wrote: > On 06/02/2016 09:45 AM, Mark Cave-Ayland wrote: >> On 02/06/16 08:37, Cédric Le Goater wrote: >>> On 06/02/2016 05:17 AM, David Gibson wrote: On Wed, Jun 01, 2016 at 08:03:08AM +0100, Mark Cave-Ayland wrote: > On 01/06/16 03:15, David Gibson wr

[Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

2016-06-02 Thread Gerd Hoffmann
This patch extends the functionality of the max-ram-below-4g option to also allow increasing lowmem. Use case: Give as much memory as possible to legacy non-PAE guests. While being at it also rework the lowmem calculation logic and add a longish comment describing how it works and what the compat

[Qemu-devel] [PATCH 0/4] 9p: get rid of readdir_r()

2016-06-02 Thread Greg Kurz
The readdir_r() function has a broken design and should not be used anymore. It is expected to be obsoleted in a future version of POSIX.1: http://austingroupbugs.net/view.php?id=696#c2857 Glibc has already announced that 2.24 (scheduled for August 2016) will deprecates readdir_r() and encourages

[Qemu-devel] [PATCH 2/4] 9p: introduce the V9fsDir type

2016-06-02 Thread Greg Kurz
If we are to switch back to readdir(), we need a more complex type than DIR * to be able to serialize concurrent accesses to the directory stream. This patch introduces a placeholder type and fixes all users. Signed-off-by: Greg Kurz --- hw/9pfs/9p-handle.c | 18 +- hw/9pfs/9p

[Qemu-devel] [PATCH 1/4] 9p: drop useless out: label

2016-06-02 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 587e901f81cc..12bd688f37d3 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -1646,15 +1646,15 @@ static int v9fs_do_readdir_with_stat(V9fsPDU *

[Qemu-devel] [PATCH 3/4] 9p: add locking to V9fsDir

2016-06-02 Thread Greg Kurz
If several threads call concurrently readdir() with the same directory stream pointer, it is possible that they all get a pointer to the same dirent structure, whose content is overwritten each time readdir() is called. We must thus serialize accesses to the dirent structure. This may be achieved

Re: [Qemu-devel] [Qemu-devel [RFC] [WIP] v1] Keeping the Source side alive incase of network failure (Migration recover from network failure)

2016-06-02 Thread haris iqbal
On Wed, Jun 1, 2016 at 9:45 PM, Dr. David Alan Gilbert wrote: > * Md Haris Iqbal (haris.p...@gmail.com) wrote: > > Remember to add a more detailed comment about what the patch is doing. Sure. I will do that in for the upcoming patches. > (And possibly split it up a bit more) Done, I will split

[Qemu-devel] [PATCH 4/4] 9p: switch back to readdir()

2016-06-02 Thread Greg Kurz
This patch changes the 9p code to use readdir() again instead of readdir_r(), which is deprecated in glibc 2.24. All the locking was put in place by a previous patch. Signed-off-by: Greg Kurz --- fsdev/file-op-9p.h |3 +-- hw/9pfs/9p-handle.c |8 +++- hw/9pfs/9p-local.c | 20 +++

Re: [Qemu-devel] [PATCH v6 9/9] target-mips: Implement FCR31's R/W bitmask and related functionalities

2016-06-02 Thread Leon Alrae
> - Add preprocessor constants for all bits of FCR31 and related masks > for its subfields. Introducing all these constants for fcr31_rw_bitmask doesn't seem necessary or useful > > - Modify handling of CFC1 and CTC1 instructions (cases 25, 26, 28) > so that they utilize newly-defind constan

Re: [Qemu-devel] [PATCH v6 6/9] target-mips: Activate IEEE 754-2008 signaling NaN bit meaning

2016-06-02 Thread Leon Alrae
> diff --git a/target-mips/translate.c b/target-mips/translate.c > index e934884..2cdd2bd 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translate.c > @@ -20129,7 +20129,11 @@ void cpu_state_reset(CPUMIPSState *env) > env->CP0_PageGrain = env->cpu_model->CP0_PageGrain; > env->

Re: [Qemu-devel] [RFC] A clock framework in QEMU.

2016-06-02 Thread KONRAD Frederic
Hi Peter, Do you agree with this? I think you are the hw/*/omap* maintainer? Thanks, Fred Le 31/05/2016 à 21:08, KONRAD Frederic a écrit : Hi, We would like to have a way to have a clock tree inside QEMU: * models can have clock outputs and/or clock inputs. * changing the clock rate of pr

Re: [Qemu-devel] [PATCH] ps2: take exact use of ps2 buffer

2016-06-02 Thread Yang Hongyang
Hi Gerd, Thanks for reply! On Thu, Jun 2, 2016 at 4:37 PM, Gerd Hoffmann wrote: > On Do, 2016-06-02 at 14:05 +0800, Yang Hongyang wrote: > > According to PS/2 Mouse/Keyboard Protocol, the keyboard output buffer > > size is 16 bytes, but we only use 15 bytes actually, this causes some > > probl

Re: [Qemu-devel] [PATCH v8 16/25] q35: add "intremap" parameter to enable IR

2016-06-02 Thread Marcel Apfelbaum
On 05/30/2016 04:33 PM, Peter Xu wrote: On Mon, May 30, 2016 at 02:43:22PM +0200, Jan Kiszka wrote: On 2016-05-30 12:31, Peter Xu wrote: One flag is added to specify whether to enable IR for emulated IOMMU. By default, interrupt remapping is not supportted. To enable it, we should specify somet

Re: [Qemu-devel] [virtio-comment] [PATCH 5/6 Resend] Vhost-pci RFC: Future Security Enhancement

2016-06-02 Thread Jan Kiszka
On 2016-05-31 10:00, Wang, Wei W wrote: > On Mon 5/30/2016 2:24 PM, Jan Kiszka Wrote: >> On 2016-05-29 10:11, Wei Wang wrote: >>> Signed-off-by: Wei Wang >>> --- >>> FutureWorks | 21 + >>> 1 file changed, 21 insertions(+) >>> create mode 100644 FutureWorks >>> >>> diff --git

Re: [Qemu-devel] [PATCH] net: mipsnet: check transmit buffer size before sending

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 07:44, P J P wrote: > From: Prasad J Pandit > > When processing MIPSnet I/O port write operation, it uses a > transmit buffer tx_buffer[MAX_ETH_FRAME_SIZE=1514]. Two indices > 's->tx_written' and 's->tx_count' are used to control data written > to this buffer. If the two were to

Re: [Qemu-devel] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback

2016-06-02 Thread Igor Mammedov
On Thu, 2 Jun 2016 11:15:44 +1000 David Gibson wrote: > On Thu, May 12, 2016 at 09:18:15AM +0530, Bharata B Rao wrote: > > From: Igor Mammedov > > > > pre_plug callback is to be called before device.realize() is > > executed. This would allow to check/set device's properties from > > HotplugHan

Re: [Qemu-devel] [PATCH 0/4] 9p: get rid of readdir_r()

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 09:51, Greg Kurz wrote: > The readdir_r() function has a broken design and should not be used anymore. > It is expected to be obsoleted in a future version of POSIX.1: > > http://austingroupbugs.net/view.php?id=696#c2857 > > Glibc has already announced that 2.24 (scheduled for Au

Re: [Qemu-devel] [for-2.7 PATCH v3 06/15] cpu: Abstract CPU core type

2016-06-02 Thread Igor Mammedov
On Thu, 2 Jun 2016 13:38:58 +1000 David Gibson wrote: > On Thu, May 12, 2016 at 09:18:16AM +0530, Bharata B Rao wrote: > > Add an abstract CPU core type that could be used by machines that > > want to define and hotplug CPUs in core granularity. > > > > Signed-off-by: Bharata B Rao > > Signed-o

Re: [Qemu-devel] [RFC] A clock framework in QEMU.

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 10:18, KONRAD Frederic wrote: > Hi Peter, > > Do you agree with this? I think you are the hw/*/omap* maintainer? The in-master OMAP stuff is pretty ancient and not a good pattern for anything. You could have a look at the omap3 clocktree stuff that's in the qemu-linaro tree; tha

Re: [Qemu-devel] [PATCH 0/4] 9p: get rid of readdir_r()

2016-06-02 Thread Greg Kurz
On Thu, 2 Jun 2016 10:33:06 +0100 Peter Maydell wrote: > On 2 June 2016 at 09:51, Greg Kurz wrote: > > The readdir_r() function has a broken design and should not be used anymore. > > It is expected to be obsoleted in a future version of POSIX.1: > > > > http://austingroupbugs.net/view.php?id=69

Re: [Qemu-devel] [PATCH RFC 1/8] target-i386: cpu: move features logic that requires CPUState to realize time

2016-06-02 Thread Igor Mammedov
On Wed, 1 Jun 2016 14:43:09 -0300 Eduardo Habkost wrote: [...] > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 3fbc6f3..6159a7f 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -1932,6 +1932,11 @@ static inline void feat2prop(char *s) > > } > > } > >

Re: [Qemu-devel] [RFC] A clock framework in QEMU.

2016-06-02 Thread Edgar E. Iglesias
On Tue, May 31, 2016 at 09:08:14PM +0200, KONRAD Frederic wrote: > Hi, Hi Fred, > We would like to have a way to have a clock tree inside QEMU: > * models can have clock outputs and/or clock inputs. > * changing the clock rate of propagates in the clock tree through > callbacks which wil

Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Stefano Stabellini
On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > Dave, can you take a look? > > Yes, I think I'm happy with it; > > Reviewed-by: Dr. David Alan Gilbert > > I think people might try interesting non-Xen things with it; for > example I think if you

Re: [Qemu-devel] [PATCH RFC 2/8] target-i386: cpu: move xcc->kvm_required check to reaize time

2016-06-02 Thread Igor Mammedov
On Wed, 1 Jun 2016 14:46:51 -0300 Eduardo Habkost wrote: > On Wed, Jun 01, 2016 at 06:37:24PM +0200, Igor Mammedov wrote: > > it will allow to drop custom cpu_x86_init() and use > > cpu_generic_init() instead reducing cpu_x86_create() > > to a simple 3-liner. > > > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH] ps2: take exact use of ps2 buffer

2016-06-02 Thread Gerd Hoffmann
On Do, 2016-06-02 at 17:19 +0800, Yang Hongyang wrote: > Hi Gerd, > Thanks for reply! > > > On Thu, Jun 2, 2016 at 4:37 PM, Gerd Hoffmann > wrote: > On Do, 2016-06-02 at 14:05 +0800, Yang Hongyang wrote: > > According to PS/2 Mouse/Keyboard Protocol, the keyboard > outp

Re: [Qemu-devel] [PATCH RFC 6/8] cpu: use CPUClass->parse_features() as convertor to global properties

2016-06-02 Thread Igor Mammedov
On Wed, 1 Jun 2016 15:54:50 -0300 Eduardo Habkost wrote: > On Wed, Jun 01, 2016 at 06:37:28PM +0200, Igor Mammedov wrote: > > Currently CPUClass->parse_features() is used to parse > > -cpu features string and set properties on created CPU > > instances. > > > > But considering that features spec

Re: [Qemu-devel] [PATCH v6 09/11] megasas: change msi/msix property type

2016-06-02 Thread Cao jin
On 06/01/2016 05:14 PM, Markus Armbruster wrote: static bool megasas_use_msix(MegasasState *s) { -return s->flags & MEGASAS_MASK_USE_MSIX; +return s->msix == ON_OFF_AUTO_AUTO || s->msix == ON_OFF_AUTO_ON; s->msi != ON_OFF_AUTO_OFF, please. } Same correctness argument as fo

Re: [Qemu-devel] [PATCH 0/9] QOM'ify hw/intc files

2016-06-02 Thread 赵小强
At 2016-05-09 17:24:04, mich...@walle.cc wrote: >Hi Peter, > >Am 2016-05-04 16:56, schrieb Peter Maydell: > >> SPARC, lm32, CRIS maintainers: do you want to take your patches >> or shall I just take 1-8 through the target-arm.next tree? > >There are other ones (milkymist-ac97, lm32_uart, lm32_jua

Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Stefano Stabellini
On Thu, 2 Jun 2016, Stefano Stabellini wrote: > On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote: > > * Amit Shah (amit.s...@redhat.com) wrote: > > > Dave, can you take a look? > > > > Yes, I think I'm happy with it; > > > > Reviewed-by: Dr. David Alan Gilbert > > > > I think people might try i

Re: [Qemu-devel] [PATCH v3 5/5] qcow2: Catch more unaligned write_zero into zero cluster

2016-06-02 Thread Kevin Wolf
Am 26.05.2016 um 16:35 hat Eric Blake geschrieben: > On 05/26/2016 07:41 AM, Denis V. Lunev wrote: > > On 05/26/2016 06:48 AM, Eric Blake wrote: > >> is_zero_cluster() and is_zero_cluster_top_locked() are used only > >> by qcow2_co_write_zeroes(). The former is too broad (we don't > >> care if the

Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Dr. David Alan Gilbert
* Stefano Stabellini (sstabell...@kernel.org) wrote: > On Thu, 2 Jun 2016, Stefano Stabellini wrote: > > On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote: > > > * Amit Shah (amit.s...@redhat.com) wrote: > > > > Dave, can you take a look? > > > > > > Yes, I think I'm happy with it; > > > > > > Rev

Re: [Qemu-devel] [PATCH v3 0/5] qcow2_co_write_zeroes and related improvements

2016-06-02 Thread Kevin Wolf
Am 26.05.2016 um 05:48 hat Eric Blake geschrieben: > This series improves write_zeroes for qcow2 > > Since the work conflicts with my proposed patches to switch > write_zeroes to a byte-base interface, I figured I'd fix the > bugs and get this part nailed first, then rebase my other > work on top,

[Qemu-devel] [PATCH v5 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Changlong Xie
From: Wen Congyang Introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices, but not the RAM or the block devices of the VM. We only have hmp commands savevm/loadvm, and qmp commands xen-save-devices-state. We use this new command for COLO: 1. suspend

[Qemu-devel] [PATCH v5 0/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Changlong Xie
Changelog v5: 1. Introduce qio channel since 8925839f v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets, fix a bug v2: 1. Rebased to the lastest code 2. Addressed on Eric's comments, fixed coding style Wen Congyang (1): Introduce "xen-load-devices-state" migration/savevm.

Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-06-02 Thread Changlong Xie
On 06/02/2016 06:16 PM, Dr. David Alan Gilbert wrote: * Stefano Stabellini (sstabell...@kernel.org) wrote: On Thu, 2 Jun 2016, Stefano Stabellini wrote: On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote: * Amit Shah (amit.s...@redhat.com) wrote: Dave, can you take a look? Yes, I think I'm ha

Re: [Qemu-devel] [PATCH] ps2: take exact use of ps2 buffer

2016-06-02 Thread Yang Hongyang
On Thu, Jun 2, 2016 at 6:05 PM, Gerd Hoffmann wrote: > On Do, 2016-06-02 at 17:19 +0800, Yang Hongyang wrote: > > Hi Gerd, > > Thanks for reply! > > > > > > On Thu, Jun 2, 2016 at 4:37 PM, Gerd Hoffmann > > wrote: > > On Do, 2016-06-02 at 14:05 +0800, Yang Hongyang wrote: > > >

Re: [Qemu-devel] [PATCH v3] vnc: add configurable keyboard delay

2016-06-02 Thread Yang Hongyang
On Wed, Jun 1, 2016 at 2:22 PM, Gerd Hoffmann wrote: > Limits the rate kbd events from the vnc server are forwarded to the > guest, so input devices which are typically low-bandwidth can keep > up even on bulky input. > > v2: update documentation too. > v3: spell fixes. > > Signed-off-by: Gerd Ho

Re: [Qemu-devel] [PATCH] block/raw-posix: Fix error_report of mounting message

2016-06-02 Thread Wei, Jiangang
On Thu, 2016-06-02 at 09:57 +0200, Markus Armbruster wrote: > Wei Jiangang writes: > > > Use a single error_printf to replace triple error_report. > > > > Signed-off-by: Wei Jiangang > > --- > > block/raw-posix.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff

Re: [Qemu-devel] [PATCH v2 04/13] block: Switch bdrv_write_zeroes() to byte interface

2016-06-02 Thread Kevin Wolf
Am 01.06.2016 um 23:10 hat Eric Blake geschrieben: > Rename to bdrv_pwrite_zeroes() to let the compiler ensure we > cater to the updated semantics. Do the same for > bdrv_aio_write_zeroes() and bdrv_co_write_zeroes(). Two of the > three places map to the byte-based counterparts; but for now, > si

Re: [Qemu-devel] [PATCH 0/9] QOM'ify hw/intc files

2016-06-02 Thread Michael Walle
hi, im planning to, please bear with me, as i'm on vacation. -michael Am 2. Juni 2016 16:10:40 GMT+06:00, schrieb "赵小强" : > > >At 2016-05-09 17:24:04, mich...@walle.cc wrote: >>Hi Peter, >> >>Am 2016-05-04 16:56, schrieb Peter Maydell: >> >>> SPARC, lm32, CRIS maintainers: do you want to take

Re: [Qemu-devel] [PATCH v2 1/33] tests: acpi: report names of expected files in verbose mode

2016-06-02 Thread Marcel Apfelbaum
On 05/26/2016 12:46 PM, Igor Mammedov wrote: print expected file name if it doesn't exists if verbose mode is enabled*. It helps to avoid running bios-tables-test under debugger to figure out missing file name. *) verbose mode is enabled if "V" env. variable is set Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v2 13/33] acpi: extend ACPI interface to provide send_event hook

2016-06-02 Thread Marcel Apfelbaum
On 05/31/2016 12:57 PM, Igor Mammedov wrote: send_event() hook will allow to send ACPI event in a target specific way (GPE or GPIO based impl.) it will also simplify proxy wrappers in piix4pm/ich9 that access ACPI regs and SCI which are part of piix4pm/lcp_ich9 devices and call acpi_foo() API dir

Re: [Qemu-devel] [PATCH v2 14/33] pc: use AcpiDeviceIfClass.send_event to issue GPE events

2016-06-02 Thread Marcel Apfelbaum
On 05/31/2016 01:01 PM, Igor Mammedov wrote: it reduces number of args passed in handlers by 1 and a number of used proxy wrappers saving ~20LOC. Also it allows to make cpu/mem hotplug code more universal as it would allow ARM to reuse it without rewrite by providing its own send_event callback t

Re: [Qemu-devel] [PATCH 4/6 Resend] Vhost-pci RFC: Detailed Description in the Virtio Specification Format

2016-06-02 Thread Xiao Guangrong
On 06/02/2016 04:43 PM, Wang, Wei W wrote: On Thu 6/2/2016 11:52 AM, Xiao Guangrong wrote: On 06/02/2016 11:15 AM, Wang, Wei W wrote: On Wed 6/1/2016 4:15 PM, Xiao Guangrong wrote: On 05/29/2016 04:11 PM, Wei Wang wrote: Signed-off-by: Wei Wang --- Details | 324 +++

Re: [Qemu-devel] [PATCH v2 09/13] qed: Convert to bdrv_co_pwrite_zeroes()

2016-06-02 Thread Kevin Wolf
Am 01.06.2016 um 23:10 hat Eric Blake geschrieben: > Another step on our continuing quest to switch to byte-based > interfaces. > > Kill an abuse of the comma operator while at it (fortunately, > the semantics were still right). Also, the test for requests > not aligned to clusters should be appl

Re: [Qemu-devel] [PATCH v2 13/33] acpi: extend ACPI interface to provide send_event hook

2016-06-02 Thread Igor Mammedov
On Thu, 2 Jun 2016 14:09:12 +0300 Marcel Apfelbaum wrote: > On 05/31/2016 12:57 PM, Igor Mammedov wrote: > > send_event() hook will allow to send ACPI event in > > a target specific way (GPE or GPIO based impl.) > > it will also simplify proxy wrappers in piix4pm/ich9 > > that access ACPI regs an

Re: [Qemu-devel] [PATCH v2 13/33] acpi: extend ACPI interface to provide send_event hook

2016-06-02 Thread Marcel Apfelbaum
On 06/02/2016 02:19 PM, Igor Mammedov wrote: On Thu, 2 Jun 2016 14:09:12 +0300 Marcel Apfelbaum wrote: On 05/31/2016 12:57 PM, Igor Mammedov wrote: send_event() hook will allow to send ACPI event in a target specific way (GPE or GPIO based impl.) it will also simplify proxy wrappers in piix4p

Re: [Qemu-devel] [PATCH v2 00/13] Kill sector-based write_zeroes

2016-06-02 Thread Kevin Wolf
Am 01.06.2016 um 23:10 hat Eric Blake geschrieben: > Kevin pointed out that my recent change to byte-based instead > of sector-based blk_write_zeroes() (commit 983a1600) makes life > harder as long as bdrv_write_zeroes is still sector-based, and > where the compiler doesn't flag any change in param

Re: [Qemu-devel] [PATCH v2 14/33] pc: use AcpiDeviceIfClass.send_event to issue GPE events

2016-06-02 Thread Igor Mammedov
On Thu, 2 Jun 2016 14:13:23 +0300 Marcel Apfelbaum wrote: > On 05/31/2016 01:01 PM, Igor Mammedov wrote: > > it reduces number of args passed in handlers by 1 and > > a number of used proxy wrappers saving ~20LOC. > > Also it allows to make cpu/mem hotplug code more > > universal as it would allo

Re: [Qemu-devel] [PATCH v5 14/27] qemu-img: Add "-L" option to sub commands

2016-06-02 Thread Max Reitz
On 01.06.2016 07:34, Fam Zheng wrote: > On Tue, 05/24 20:06, Max Reitz wrote: [...] >> Also: Should we have distinct flags for source and target for convert? >> For instance, I can imagine someone wanting not to lock the source but >> leave the target in default exclusive mode. > > "-L" is a sho

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

2016-06-02 Thread Michal Privoznik
On 02.06.2016 10:29, Daniel P. Berrange wrote: > On Thu, Jun 02, 2016 at 09:41:56AM +0200, Michal Privoznik wrote: >> On 01.06.2016 18:16, Wei Xu wrote: >>> On 2016年06月01日 00:44, Daniel P. Berrange wrote: On Wed, Jun 01, 2016 at 12:30:44AM +0800, w...@redhat.com wrote: > From: Wei Xu

Re: [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work

2016-06-02 Thread Vladimir Sementsov-Ogievskiy
Hi, what are the plans? On 26.05.2016 03:47, Fam Zheng wrote: On Wed, 05/25 17:45, Vladimir Sementsov-Ogievskiy wrote: Hi! Are you going to update the series in the near future? Yes, probably in a couple days. Fam On 08.03.2016 07:44, Fam Zheng wrote: v4: Rebase. Add rev-by from Joh

Re: [Qemu-devel] [PATCH 0/9] QOM'ify hw/intc files

2016-06-02 Thread xiaoqiang zhao
> 在 2016年6月2日,19:01,Michael Walle 写道: > > hi, > > im planning to, please bear with me, as i'm on vacation. > > -michael Oh,have a good time ;-)

[Qemu-devel] [Bug 1588328] [NEW] Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-02 Thread Zhen Ning Lim
Public bug reported: Hi, I tried the following command to boot Solaris 9 sparc: qemu-system-sparc -nographic -boot d -hda ./Spark9.disk -m 256 -cdrom sol-9-905hw-ga-sparc-dvd.iso -serial telnet:0.0.0.0:3000,server It seems there are a few Segmentation Faults, one from the starting of the boot.

Re: [Qemu-devel] [PATCH 0/4] 9p: get rid of readdir_r()

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 10:42, Greg Kurz wrote: > On Thu, 2 Jun 2016 10:33:06 +0100 > Peter Maydell wrote: >> AIUI the argument is that all sensible implementations of readdir() >> already provide the thread-safety guarantees POSIX is going to >> specify, but have you tested this on one of the BSDs or

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-06-02 Thread Greg Kurz
Latest work on the subject seems to be: https://github.com/ericvh/linux/commit/eaf70223eac094291169f5a6de580351890162a2 I could verify that this patch still applies to the upstream kernel tree and fixes the issue. The fix was verified with upstream QEMU + the following patch: http://patchwork.o

Re: [Qemu-devel] [PATCH v3 00/24] target-sparc improvements

2016-06-02 Thread Artyom Tarasenko
On Thu, Jun 2, 2016 at 7:56 AM, Richard Henderson wrote: > The primary focus of this patch set is to reduce the number of > helpers that modify TCG globals, and thus increase the lifetime > of those globals within each TB, and thus decrease the number > of times that tcg must spill and fill them f

Re: [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-02 Thread Igor Mammedov
On Wed, 1 Jun 2016 15:46:20 -0300 Eduardo Habkost wrote: > On Wed, Jun 01, 2016 at 06:37:26PM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > target-i386/cpu.c | 32 +--- > > 1 file changed, 17 insertions(+), 15 deletions(-) > > > > diff --g

Re: [Qemu-devel] [PATCH 1/2] raw-posix: Fetch max sectors for host block device from sysfs

2016-06-02 Thread Max Reitz
On 26.05.2016 08:15, Fam Zheng wrote: > This is sometimes a useful value we should count in. > > Signed-off-by: Fam Zheng > --- > block/raw-posix.c | 47 +++ > 1 file changed, 47 insertions(+) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > i

Re: [Qemu-devel] [PATCH 2/2] arm/virt: Mark pcie controller node as dma-coherent

2016-06-02 Thread Peter Maydell
On 2 June 2016 at 13:26, Bogdan Purcareata wrote: > A PCI device is marked either as coherent or non-coherent based on the pcie > controller "dma-coherent" property. This is further used when configuring the > IOMMU ops for the device DMA resources (e.g. descriptor rings, for e1000e). > > This dma

Re: [Qemu-devel] [PATCH v3 5/5] qcow2: Catch more unaligned write_zero into zero cluster

2016-06-02 Thread Eric Blake
On 06/02/2016 04:14 AM, Kevin Wolf wrote: >> If you prefer, I could have written '-tail % s->cluster_sectors', but as >> % on a negative signed integer gives different results than what you get >> for an unsigned number, I felt that & was nicer than % for making it >> more obvious that I'm grabbin

  1   2   3   4   >