Re: [Qemu-devel] [PATCH 0/2] macio: switch over to new byte-aligned DMA helpers

2016-05-31 Thread Mark Cave-Ayland
On 30/05/16 22:19, Aurelien Jarno wrote: > On 2016-05-27 09:48, Mark Cave-Ayland wrote: >> Here is a tidied up version of my patch to convert the macio controller over >> to >> using the new byte-aligned DMA helpers. >> >> The first patch is just a hack and temporarily disables unaligned iovec >>

[Qemu-devel] [PATCH 0/2] Reveal 'to' parameter of 'vnc' option to user

2016-05-31 Thread Robert Ho
(If you received this patch set several times, I appologize, I met some problem in the smtp setting.) I find that '-vnc' option actually has a parameter 'to', implicitly; while actually is there and can be used but not be public. Don't know why but this may probably confuse user, especially when us

[Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in use

2016-05-31 Thread Robert Ho
If no display option defined in QEMU command line, and SDL is not available, then it by default uses '-vnc localhost:0,to=99,id=default'. This patch simply print out the default option parameters out, so that user is aware of that. Signed-off-by: Robert Ho --- vl.c | 5 - 1 file changed, 4 i

[Qemu-devel] [PATCH 1/2] Reveal 'to' param of '-vnc' option in qemu man page

2016-05-31 Thread Robert Ho
Add the descrption of the 'to' param of 'vnc' option in QEMU man page. Signed-off-by: Robert Ho --- qemu-options.hx | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 6106520..68b4cf2 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1241,6 +1

Re: [Qemu-devel] How to enable limited set of cpu features when using KVM

2016-05-31 Thread Fam Zheng
On Mon, 05/30 15:48, Gaurav Sharma wrote: > I am trying to boot a 64 bit image using KVM. By default I understand > 'qemu64' is the guest processor. > What I am trying is to not to expose certain features like sse, sse2 etc. > Even though the change the same in 'builtin_x86_defs' for qemu64, i stil

Re: [Qemu-devel] [PATCH v6 16/17] net: Introduce e1000e device emulation

2016-05-31 Thread Dmitry Fleytman
> On 31 May 2016, at 09:08 AM, Dmitry Fleytman wrote: > > >> On 30 May 2016, at 18:10 PM, Michael S. Tsirkin wrote: >> >> On Mon, May 30, 2016 at 12:14:41PM +0300, Leonid Bloch wrote: >>> diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c >>> new file mode 100644 >>> index 000..4da6bb1 >>> --

[Qemu-devel] [PATCH v7 02/17] msix: make msix_clr_pending() visible for clients

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman This function will be used by e1000e device code. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/msix.c | 2 +- include/hw/pci/msix.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index b

[Qemu-devel] [PATCH v7 04/17] pcie: Add support for PCIe CAP v1

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Added support for PCIe CAP v1, while reusing some of the existing v2 infrastructure. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c | 84 -- include/hw/pci/pcie.h | 4 +++ includ

[Qemu-devel] [PATCH v7 03/17] pci: Introduce define for PM capability version 1.1

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/hw/pci/pci_regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/pci/pci_regs.h b/include/hw/pci/pci_regs.h index ba8cbe9..7a83142 100644 --- a/include/hw/pci/pci_regs.h +++ b/include

[Qemu-devel] [PATCH v7 00/17] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-05-31 Thread Dmitry Fleytman
Hello All, This is v7 of e1000e series. For convenience, the same patches are available at: https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-v7 Best regards, Dmitry. Changes since v6: 1. Comments added and commit message extended for pci_[set|get]_quad() patch 2. Fixes for a few stylin

[Qemu-devel] [PATCH v7 01/17] pci: fix unaligned access in pci_xxx_quad()

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Replace legacy cpu_to_le64w()/le64_to_cpup() calls with stq_le_p()/ldq_le_p(). Motivation for this modification is that follow up patches add utility function pcie_dev_ser_num_init() for PCIe DSN capability creation which uses pci_set_quad() with a misaligned offset. Signe

[Qemu-devel] [PATCH v7 07/17] net: Introduce Toeplitz hash calculator

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/net/checksum.h | 45 + 1 file changed, 45 insertions(+) diff --git a/include/net/checksum.h b/include/net/checksum.h index 7de1acb..dd8b4f6 100644 --- a/inc

[Qemu-devel] [PATCH v7 05/17] pcie: Introduce function for DSN capability creation

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/pci/pcie.c | 10 ++ include/hw/pci/pcie.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 24cfc3b..9599fde 100644 --- a/hw/pci/pcie.c +++ b/hw/pci

[Qemu-devel] [PATCH v7 13/17] vmxnet3: Use pci_dma_* API instead of cpu_physical_memory_*

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman To make this device and network packets abstractions ready for IOMMU. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/net_tx_pkt.c | 16 +++- hw/net/net_tx_pkt.h | 5 +++-- hw/net/vmxnet3.c| 51 ++

[Qemu-devel] [PATCH v7 15/17] e1000: Move out code that will be reused in e1000e

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Code that will be shared moved to a separate files. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- MAINTAINERS| 5 + hw/net/Makefile.objs | 2 +- hw/net/e1000.c | 411 +++-- hw/net/e100

[Qemu-devel] [PATCH v7 06/17] vmxnet3: Use generic function for DSN capability definition

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/vmxnet3.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 20f26b7..586e915 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c

[Qemu-devel] [PATCH v7 09/17] vmxnet3: Use common MAC address tracing macros

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/vmxnet3.c | 8 hw/net/vmxnet_debug.h | 3 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 586e915..200d2ea 100644 --- a/hw/net/

[Qemu-devel] [PATCH v7 14/17] e1000_regs: Add definitions for Intel 82574-specific bits

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/e1000_regs.h | 345 +++- 1 file changed, 342 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000_regs.h b/hw/net/e1000_regs.h index 1c40244..d62b3fa

Re: [Qemu-devel] How to enable limited set of cpu features when using KVM

2016-05-31 Thread Gaurav Sharma
In the command line, "-cpu $model,-$flag"? For example, -cpu qemu64,-sse2 >> I have tried the same already. But my VM hangs if remove sse or sse2. I am using qemu 2.2.0 On Tue, May 31, 2016 at 12:38 PM, Fam Zheng wrote: > On Mon, 05/30 15:48, Gaurav Sharma wrote: > > I am trying to boot a 6

[Qemu-devel] [PATCH v7 08/17] net: Add macros for MAC address tracing

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman These macros will be used by future commits introducing e1000e device emulation and by vmxnet3 tracing code. Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- include/net/net.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/net.h b/incl

Re: [Qemu-devel] [PATCH 01/19] block: Use children list in bdrv_refresh_filename

2016-05-31 Thread Alberto Garcia
On Tue 26 Apr 2016 11:32:00 PM CEST, Max Reitz wrote: > bdrv_refresh_filename() should invoke itself recursively on all > children, not just on file. > > With that change, we can remove the manual invocations in blkverify and > quorum. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Be

[Qemu-devel] [PATCH v7 11/17] rtl8139: Move more TCP definitions to common header

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- hw/net/rtl8139.c | 5 - include/net/eth.h | 8 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 1e5ec14..562c1fd 100644 --- a/hw/net/rtl813

[Qemu-devel] [PATCH v7 10/17] net_pkt: Name vmxnet3 packet abstractions more generic

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman This patch drops "vmx" prefix from packet abstractions names to emphasize the fact they are generic and not tied to any specific network device. These abstractions will be reused by e1000e emulation implementation introduced by following patches so their names need generali

[Qemu-devel] [PATCH v7 12/17] net_pkt: Extend packet abstraction as required by e1000e functionality

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman This patch extends the TX/RX packet abstractions with features that will be used by the e1000e device implementation. Changes are: 1. Support iovec lists for RX buffers 2. Deeper RX packets parsing 3. Loopback option for TX packets 4. Extended VLAN headers handling

[Qemu-devel] [PATCH v7 17/17] e1000e: Introduce qtest for e1000e device

2016-05-31 Thread Dmitry Fleytman
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Signed-off-by: Leonid Bloch --- tests/Makefile | 3 + tests/e1000e-test.c | 479 2 files changed, 482 insertions(+) create mode 100644 tests/e1000e-test.c diff --git a/tests/Makef

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-05-31 Thread Jimi
Well, that's a bunch more stuff ruled out. My host is a BIOS with MBR partitioning, using ext4, and the images are all raw. For each guest, there's an image of the OS (so the C: drive on Windows and the / partition on Linux) on my SSD, and Windows also has a bigger image on my HDD (drive D:). I don

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: avoid potential overflow of acb->task->cdb

2016-05-31 Thread Kevin Wolf
Am 31.05.2016 um 08:44 hat Fam Zheng geschrieben: > On Tue, 05/24 10:59, Peter Lieven wrote: > > at least in the path via virtio-blk the maximum size is not > > restricted. > > > > Cc: qemu-sta...@nongnu.org > > Signed-off-by: Peter Lieven > > --- > > block/iscsi.c | 7 +++ > > 1 file change

Re: [Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in use

2016-05-31 Thread Markus Armbruster
Robert Ho writes: > If no display option defined in QEMU command line, and SDL is not > available, then it by default uses '-vnc localhost:0,to=99,id=default'. > This patch simply print out the default option parameters out, so that > user is aware of that. > > Signed-off-by: Robert Ho > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: avoid potential overflow of acb->task->cdb

2016-05-31 Thread Kevin Wolf
Am 31.05.2016 um 08:44 hat Fam Zheng geschrieben: > On Tue, 05/24 10:59, Peter Lieven wrote: > > at least in the path via virtio-blk the maximum size is not > > restricted. > > > > Cc: qemu-sta...@nongnu.org > > Signed-off-by: Peter Lieven > > --- > > block/iscsi.c | 7 +++ > > 1 file change

Re: [Qemu-devel] [PATCH v6 10/15] qht: QEMU's fast, resizable and scalable Hash Table

2016-05-31 Thread Alex Bennée
Sergey Fedorov writes: > On 25/05/16 04:13, Emilio G. Cota wrote: >> diff --git a/include/qemu/qht.h b/include/qemu/qht.h >> new file mode 100644 >> index 000..aec60aa >> --- /dev/null >> +++ b/include/qemu/qht.h >> @@ -0,0 +1,183 @@ > (snip) >> +/** >> + * qht_init - Initialize a QHT >> + *

Re: [Qemu-devel] [PATCH] scsi: esp: check TI buffer index before read/write

2016-05-31 Thread Peter Maydell
On 31 May 2016 at 06:20, P J P wrote: > Hello Peter, > > +-- On Mon, 30 May 2016, Peter Maydell wrote --+ > | > +} else if (s->ti_rptr < TI_BUFSZ) { > | > s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++]; > | > +} else { > | > +trace_esp_error

Re: [Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-31 Thread Igor Mammedov
On Mon, 30 May 2016 21:18:59 +0300 Marcel Apfelbaum wrote: > On 05/17/2016 05:42 PM, Igor Mammedov wrote: > > move the former SSDT part of CPU hoplug close to DSDT part. > > AML is only moved but there isn't any functional change. > > > > The patch looks good to me, > but why did you decide to

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: avoid potential overflow of acb->task->cdb

2016-05-31 Thread Fam Zheng
On Tue, 05/31 09:35, Kevin Wolf wrote: > Am 31.05.2016 um 08:44 hat Fam Zheng geschrieben: > > On Tue, 05/24 10:59, Peter Lieven wrote: > > > at least in the path via virtio-blk the maximum size is not > > > restricted. > > > > > > Cc: qemu-sta...@nongnu.org > > > Signed-off-by: Peter Lieven > >

Re: [Qemu-devel] [virtio-comment] [PATCH 5/6 Resend] Vhost-pci RFC: Future Security Enhancement

2016-05-31 Thread Wang, Wei W
On Mon 5/30/2016 2:24 PM, Jan Kiszka Wrote: > On 2016-05-29 10:11, Wei Wang wrote: > > Signed-off-by: Wei Wang > > --- > > FutureWorks | 21 + > > 1 file changed, 21 insertions(+) > > create mode 100644 FutureWorks > > > > diff --git a/FutureWorks b/FutureWorks new file mode

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: avoid potential overflow of acb->task->cdb

2016-05-31 Thread Fam Zheng
On Tue, 05/31 09:39, Kevin Wolf wrote: > Am 31.05.2016 um 08:44 hat Fam Zheng geschrieben: > > On Tue, 05/24 10:59, Peter Lieven wrote: > > > at least in the path via virtio-blk the maximum size is not > > > restricted. > > > > > > Cc: qemu-sta...@nongnu.org > > > Signed-off-by: Peter Lieven > >

[Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-05-31 Thread Greg Kurz
Paolo's recent cpu.h cleanups broke legacy virtio for ppc64 LE guests (and arm BE guests as well, even if I have not verified that). Especially, commit "33c11879fd42 qemu-common: push cpu.h inclusion out of qemu-common.h" has the side-effect of silently hiding the TARGET_IS_BIENDIAN macro from the

[Qemu-devel] [PATCH 1/1] virtio-balloon: export all balloon statistics

2016-05-31 Thread Denis V. Lunev
From: Igor Redko We are making experiments with different autoballooning strategies based on the guest behavior. Thus we need to experiment with different guest statistics. For now every counter change requires QEMU recompilation and dances with Libvirt. This patch introduces transport for unrec

Re: [Qemu-devel] [PATCH 1/1] vnc: Add support for color map

2016-05-31 Thread Denis V. Lunev
On 05/24/2016 05:19 PM, Denis V. Lunev wrote: From: Alexander Graf Our current VNC code does not handle color maps (aka non-true-color) at all and aborts if a client requests them. There are 2 major issues with this: 1) A VNC viewer on an 8-bit X11 system may request color maps 2) RealVNC

Re: [Qemu-devel] [PATCH qemu v16 10/19] spapr_iommu: Migrate full state

2016-05-31 Thread Alexey Kardashevskiy
On 26/05/16 14:01, David Gibson wrote: > On Wed, May 04, 2016 at 04:52:22PM +1000, Alexey Kardashevskiy wrote: >> The source guest could have reallocated the default TCE table and >> migrate bigger/smaller table. This adds reallocation in post_load() >> if the default table size is different on sou

Re: [Qemu-devel] [RFC PATCH V4 0/4] Introduce COLO-compare

2016-05-31 Thread Zhang Chen
On 05/31/2016 02:16 PM, Jason Wang wrote: On 2016年05月31日 11:54, Zhang Chen wrote: On 05/30/2016 11:19 AM, Jason Wang wrote: On 2016年05月25日 20:50, Zhang Chen wrote: COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkp

Re: [Qemu-devel] [PULL v3 00/31] Misc changes for 2016-05-27

2016-05-31 Thread Peter Maydell
On 28 May 2016 at 17:49, Paolo Bonzini wrote: > > > - Original Message - >> From: "Peter Maydell" >> To: "Paolo Bonzini" >> Cc: "QEMU Developers" >> Sent: Friday, May 27, 2016 6:38:10 PM >> Subject: Re: [Qemu-devel] [PULL v3 00/31] Misc changes for 2016-05-27 >> >> On 27 May 2016 at 17:

[Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some

2016-05-31 Thread Markus Armbruster
We print a few fatal error messages to stdout instead of stderr. Reproducer: $ qemu-system-x86_64 -g 1024x768 Option g not supported for this target $ qemu-system-x86_64 -g 1024x768 >/dev/null Fix by printing them with error_report(). This also improves the messages. The above one be

[Qemu-devel] [PATCH] block: Fix leak of BdrvIoctlCompletionData when driver returns NULL

2016-05-31 Thread Fam Zheng
"data" allocated in bdrv_co_do_ioctl is not freed. Free it before returning. Cc: qemu-sta...@nongnu.org Reported-by: Kevin Wolf Signed-off-by: Fam Zheng --- block/io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/io.c b/block/io.c index 2d832aa..aa5a5d7 100644 --- a/block/io.c +++

Re: [Qemu-devel] [PATCH v6 14/15] tb hash: track translated blocks with qht

2016-05-31 Thread Alex Bennée
Emilio G. Cota writes: > Having a fixed-size hash table for keeping track of all translation blocks > is suboptimal: some workloads are just too big or too small to get maximum > Reviewed-by: Alex Bennée > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > --- > cpu-exec.c

Re: [Qemu-devel] [PATCH v2 4/4] target-tricore: Added new JNE instruction variant

2016-05-31 Thread Bastian Koppelmann
On 05/31/2016 07:49 AM, peer.ad...@c-lab.de wrote: > From: Peer Adelt > > If D[15] is != sign_ext(const4) then PC will be set to (PC + > zero_ext(disp4 + 16)). > > Signed-off-by: Peer Adelt > --- > target-tricore/translate.c | 11 +++ > target-tricore/tricore-opcodes.h | 1 + >

Re: [Qemu-devel] [PATCH 24/33] acpi: add CPU hotplug methods to DSDT

2016-05-31 Thread Igor Mammedov
On Tue, 31 May 2016 07:38:08 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 17, 2016 at 04:43:16PM +0200, Igor Mammedov wrote: > > Add necessary CPU hotplug methods to handle hotplug > > events. > > > > Signed-off-by: Igor Mammedov > > --- > > v1: > > - make replace _MAT method with named bu

Re: [Qemu-devel] [PATCH v2 3/4] target-tricore: Added new MOV instruction variant

2016-05-31 Thread Bastian Koppelmann
On 05/31/2016 07:48 AM, peer.ad...@c-lab.de wrote: > From: Peer Adelt > > Puts the content of data register D[a] into E[c][63:32] and the > content of data register D[b] into E[c][31:0]. > > Signed-off-by: Peer Adelt > --- > target-tricore/translate.c | 8 > target-tricore/trico

Re: [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd

2016-05-31 Thread Denis V. Lunev
On 05/20/2016 02:26 AM, Eric Blake wrote: On 05/17/2016 02:20 AM, Denis V. Lunev wrote: Pls note, trace_init_backends() must be called in the final process, i.e. s/Pls/Please/ after daemonization. This is necessary to keep tracing thread in the proper process. Signed-off-by: Denis V. Lunev

Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some

2016-05-31 Thread Marcel Apfelbaum
On 05/31/2016 11:31 AM, Markus Armbruster wrote: We print a few fatal error messages to stdout instead of stderr. Reproducer: $ qemu-system-x86_64 -g 1024x768 Option g not supported for this target $ qemu-system-x86_64 -g 1024x768 >/dev/null Fix by printing them with error_report

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Paolo Bonzini
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > new file mode 100644 > index 000..372733d > --- /dev/null > +++ b/tests/docker/Makefile.include > @@ -0,0 +1,121 @@ > +# Makefile for Docker tests > + > +include $(SRC_PATH)/rules.mak Why include this _and_ include

[Qemu-devel] [PATCH v2 0/3] trace: enable tracing in qemu-io/qemu-nbd

2016-05-31 Thread Denis V. Lunev
Actually this is a rework of the original patch, set as a part of write-zeroes patchset. Moving it out to process via trace tree. Changes from v1: - fixed nits found by Eric Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf Denis V. Lunev (3):

[Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io

2016-05-31 Thread Denis V. Lunev
Moving trace_init_backends() into trace_opt_parse() is not possible. This should be called after daemonize() in vl.c. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- qemu-io.c | 17 + 1 file changed, 13 insertions(+), 4 de

[Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd

2016-05-31 Thread Denis V. Lunev
Please note, trace_init_backends() must be called in the final process, i.e. after daemonization. This is necessary to keep tracing thread in the proper process. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- qemu-nbd.c | 17

[Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/control.c

2016-05-31 Thread Denis V. Lunev
The patch also creates trace_opt_parse() helper in trace/control.c to reuse this code in next patches for qemu-nbd and qemu-io. The patch also makes trace_init_events() static, as this call is not used outside the module anymore. Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake CC: Paolo B

Re: [Qemu-devel] [RFC PATCH v1 1/2] target-arm: Update page size for aarch64

2016-05-31 Thread Vijay Kilari
Hi Peter On Wed, Apr 6, 2016 at 8:31 PM, Vijay Kilari wrote: > On Mon, Apr 4, 2016 at 10:14 PM, Peter Maydell > wrote: >> On 4 April 2016 at 17:40, Vijay Kilari wrote: >>> On Mon, Apr 4, 2016 at 7:14 PM, Peter Maydell >>> wrote: I agree that this would definitely improve performance (bo

Re: [Qemu-devel] [PATCH] block: Fix leak of BdrvIoctlCompletionData when driver returns NULL

2016-05-31 Thread Paolo Bonzini
On 31/05/2016 10:34, Fam Zheng wrote: > "data" allocated in bdrv_co_do_ioctl is not freed. Free it before > returning. > > Cc: qemu-sta...@nongnu.org > Reported-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- > block/io.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/io.c b/

[Qemu-devel] [PATCH 01/11] block: switch blk_write_compressed() to byte-based interface

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin This is a preparatory patch, which continues the general trend of the transition to the byte-based interfaces. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan Hajnoczi CC: Kevin Wo

[Qemu-devel] [PATCH v4 00/11] backup compression

2016-05-31 Thread Denis V. Lunev
The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. These patches add the ability to compress data during backup. This functionality is implemented by means of adding options to the qmp/hmp

[Qemu-devel] [PATCH 02/11] block/io: add bdrv_co_write_compressed

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin This patch just adds the interface to the bdrv_co_pwritev_compressed, which is currently not used but will be useful for safe implementation of the bdrv_co_write_compressed callback in format drivers. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cod

[Qemu-devel] [PATCH 03/11] qcow2: add qcow2_co_write_compressed

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin Added implementation of the qcow2_co_write_compressed function that will allow us to safely use compressed writes for the qcow2 from running VMs. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow

Re: [Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-05-31 Thread Cédric Le Goater
On 05/31/2016 10:09 AM, Greg Kurz wrote: > Paolo's recent cpu.h cleanups broke legacy virtio for ppc64 LE guests (and > arm BE guests as well, even if I have not verified that). Especially, commit > "33c11879fd42 qemu-common: push cpu.h inclusion out of qemu-common.h" has > the side-effect of silen

[Qemu-devel] [PATCH 04/11] vmdk: add vmdk_co_write_compressed

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin Added implementation of the vmdk_co_write_compressed function that will allow us to safely use compressed writes for the vmdk from running VMs. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow

[Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin For bdrv_pwrite_compressed() it looks like most of the code creating coroutine is duplicated in blk_prw(). So we can just add a flag(BDRV_REQ_WRITE_COMPRESSED) and use the blk_prw() as a generic one. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody

Re: [Qemu-devel] [PATCH v6 for-2.7 00/28] Convert migration to QIOChannel & support

2016-05-31 Thread Daniel P. Berrange
On Thu, May 26, 2016 at 11:47:42AM +0530, Amit Shah wrote: > On (Wed) 27 Apr 2016 [11:04:50], Daniel P. Berrange wrote: > > This is an update of patches that were previously posted > > > > FYI: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html > >v1: https://lists.gnu.org/a

[Qemu-devel] [PATCH 09/11] blockdev-backup: added support for data compression

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake

Re: [Qemu-devel] [PATCH v2 0/3] trace: enable tracing in qemu-io/qemu-nbd

2016-05-31 Thread Daniel P. Berrange
On Tue, May 31, 2016 at 11:58:14AM +0300, Denis V. Lunev wrote: > Actually this is a rework of the original patch, set as a part of write-zeroes > patchset. Moving it out to process via trace tree. > > Changes from v1: > - fixed nits found by Eric > > Signed-off-by: Denis V. Lunev > CC: Eric Bla

[Qemu-devel] [PATCH 05/11] qcow: add qcow_co_write_compressed

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin Added implementation of the qcow_co_write_compressed function that will allow us to safely use compressed writes for the qcow from running VMs. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow

[Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. The patch adds a flag to the qmp/hmp drive-backup command which enables block compression. Compression should be i

Re: [Qemu-devel] [PATCH v2 0/3] trace: enable tracing in qemu-io/qemu-nbd

2016-05-31 Thread Denis V. Lunev
On 05/31/2016 12:25 PM, Daniel P. Berrange wrote: On Tue, May 31, 2016 at 11:58:14AM +0300, Denis V. Lunev wrote: Actually this is a rework of the original patch, set as a part of write-zeroes patchset. Moving it out to process via trace tree. Changes from v1: - fixed nits found by Eric Signed

Re: [Qemu-devel] [PULL 25/28] migration: define 'tls-creds' and 'tls-hostname' migration parameters

2016-05-31 Thread Daniel P. Berrange
On Fri, May 27, 2016 at 03:32:14PM +0530, Amit Shah wrote: > On (Thu) 26 May 2016 [09:05:37], Eric Blake wrote: > > > > @@ -667,6 +702,21 @@ > > > # auto-converge detects that migration is not > > > making > > > # progress. The default value is

Re: [Qemu-devel] [PATCH] Fix configure test for PBKDF2 in nettle

2016-05-31 Thread Daniel P. Berrange
On Thu, May 26, 2016 at 09:53:13PM -0700, Steven Luo wrote: > From: Steven Luo > > On my Debian jessie system, including nettle/pbkdf2.h does not cause > NULL to be defined, which causes the test to fail to compile. Include > stddef.h to bring in a definition of NULL. > > Cc: qemu-triv...@nongn

[Qemu-devel] [PATCH 06/11] block: remove BlockDriver.bdrv_write_compressed

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin There are no block drivers left that implement the old .bdrv_write_compressed interface, so it can be removed now. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan Hajnoczi CC: Kevi

Re: [Qemu-devel] [RFC PATCH v1 1/2] target-arm: Update page size for aarch64

2016-05-31 Thread Peter Maydell
On 31 May 2016 at 10:04, Vijay Kilari wrote: > On Wed, Apr 6, 2016 at 8:31 PM, Vijay Kilari wrote: >> On Mon, Apr 4, 2016 at 10:14 PM, Peter Maydell >> wrote: >>> If you want to avoid defining TARGET_PAGE_SIZE to the >>> lowest-common-denominator 1K, then yes, you'd need to >>> choose it at run

[Qemu-devel] [PATCH 10/11] qemu-iotests: test backup compression in 055

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin Added cases to check the backup compression out of qcow2, raw in qcow2 on drive-backup and blockdev-backup. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan Hajnoczi CC: Kevin Wolf

[Qemu-devel] [PATCH 11/11] qemu-iotests: add vmdk for test backup compression in 055

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin The vmdk format has support for compression, it would be fine to add it for the test backup compression Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow CC: Stefan Hajnoczi CC: Kevin Wolf ---

Re: [Qemu-devel] undefined symbol _nettle_cast5_set_key

2016-05-31 Thread Daniel P. Berrange
On Sat, May 21, 2016 at 02:14:07PM +0100, Peter Maydell wrote: > On 20 May 2016 at 23:43, Eric Blake wrote: > > What version of nettle are you compiling against? Obviously it's an > > older version, but is it one that we need to work around at configure > > time, or one that you should just update

[Qemu-devel] [PATCH] Modify net/socket.c to use socket_* functions from include/qemu/sockets.h

2016-05-31 Thread Ashijeet Acharya
Changed the listen(),connect(),parse_host_port() in net/socket.c with the socket_*()functions in include/qemu/sockets.h. Signed-off-by: Ashijeet Acharya --- net/socket.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/net/socket.c b/n

Re: [Qemu-devel] RFC: do we need ordered dict?

2016-05-31 Thread Daniel P. Berrange
On Mon, May 23, 2016 at 09:29:23AM -0600, Eric Blake wrote: > On 05/23/2016 04:14 AM, Wei, Jiangang wrote: > > Hi all, > > > > I found a problem about the output of 'query-version' > > > > > Actually, It's as following, > > -> { "execute": "query-version" } > > <- { > > "return":{ > >

Re: [Qemu-devel] [PULL 00/30] Misc changes for 2016-05-27

2016-05-31 Thread Peter Maydell
On 30 May 2016 at 16:12, Paolo Bonzini wrote: > The following changes since commit d6550e9ed2e1a60d889dfb721de00d9a4e3bafbe: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160527' > into staging (2016-05-27 14:05:48 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] Modify net/socket.c to use socket_* functions from include/qemu/sockets.h

2016-05-31 Thread Ashi
On Monday 16 May 2016 10:11 PM, Stefan Hajnoczi wrote: On Thu, May 12, 2016 at 10:33:05PM +0530, Ashijeet Acharya wrote: Changed the listen(),connect(),parse_host_port() in net/socket.c with the socket_*()functions in include/qemu/sockets.h. What is the rationale for this change? Please ex

[Qemu-devel] [PATCH v2 13/33] acpi: extend ACPI interface to provide send_event hook

2016-05-31 Thread Igor Mammedov
send_event() hook will allow to send ACPI event in a target specific way (GPE or GPIO based impl.) it will also simplify proxy wrappers in piix4pm/ich9 that access ACPI regs and SCI which are part of piix4pm/lcp_ich9 devices and call acpi_foo() API directly. Signed-off-by: Igor Mammedov --- Follo

[Qemu-devel] [PATCH v2 14/33] pc: use AcpiDeviceIfClass.send_event to issue GPE events

2016-05-31 Thread Igor Mammedov
it reduces number of args passed in handlers by 1 and a number of used proxy wrappers saving ~20LOC. Also it allows to make cpu/mem hotplug code more universal as it would allow ARM to reuse it without rewrite by providing its own send_event callback to trigger events usiong GPIO instead of GPE as

Re: [Qemu-devel] [PATCH 04/33] pc: acpi: remove AML for empty/not used GPE handlers

2016-05-31 Thread Marcel Apfelbaum
On 05/25/2016 04:19 PM, Igor Mammedov wrote: On Wed, 25 May 2016 12:11:33 +0300 Marcel Apfelbaum wrote: On 05/17/2016 05:42 PM, Igor Mammedov wrote: ACPI spec requires GPE handlers only for GPE events that hardware implements. So remove AML for not supported by QEMU device model events. Sign

[Qemu-devel] [PATCH 4/4] trace: enable trace events in qemu-img

2016-05-31 Thread Denis V. Lunev
The command will work this way: qemu-img create --trace qcow2* -f qcow2 1.img 64G Signed-off-by: Denis V. Lunev Suggested by: Daniel P. Berrange CC: Eric Blake CC: Paolo Bonzini CC: Stefan Hajnoczi CC: Kevin Wolf --- qemu-img.c | 97 ++

Re: [Qemu-devel] [PATCH 20/33] pc: q35: initialize new CPU hotplug hw

2016-05-31 Thread Igor Mammedov
On Mon, 30 May 2016 22:02:31 +0300 Marcel Apfelbaum wrote: > On 05/17/2016 05:43 PM, Igor Mammedov wrote: > > add necessary wiring to init new CPU hotplug hardware > > if ICH9-LPC.cpu-hotplug-legacy is "off". > > Set ICH9-LPC.cpu-hotplug-legacy to "off" by default and > > switch legacy hotplug to

Re: [Qemu-devel] [Qemu-block] [PATCH v19 09/10] tests: add unit test case for replication

2016-05-31 Thread Changlong Xie
On 05/31/2016 01:34 AM, Stefan Hajnoczi wrote: On Fri, May 20, 2016 at 03:36:19PM +0800, Changlong Xie wrote: +/* primary */ +#define P_LOCAL_DISK "/tmp/p_local_disk.XX" +#define P_COMMAND "driver=replication,mode=primary,node-name=xxx,"\ + "file.driver=qcow2,file.file.filen

Re: [Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in use

2016-05-31 Thread Robert Hu
On Tue, 2016-05-31 at 09:51 +0200, Markus Armbruster wrote: > Robert Ho writes: > > > If no display option defined in QEMU command line, and SDL is not > > available, then it by default uses '-vnc localhost:0,to=99,id=default'. > > This patch simply print out the default option parameters out, so

Re: [Qemu-devel] [PATCH 20/33] pc: q35: initialize new CPU hotplug hw

2016-05-31 Thread Marcel Apfelbaum
On 05/31/2016 01:06 PM, Igor Mammedov wrote: On Mon, 30 May 2016 22:02:31 +0300 Marcel Apfelbaum wrote: On 05/17/2016 05:43 PM, Igor Mammedov wrote: add necessary wiring to init new CPU hotplug hardware if ICH9-LPC.cpu-hotplug-legacy is "off". Set ICH9-LPC.cpu-hotplug-legacy to "off" by defau

Re: [Qemu-devel] [Qemu-block] [PATCH v19 00/10] Block replication for continuous checkpoints

2016-05-31 Thread Changlong Xie
On 05/31/2016 02:20 AM, Stefan Hajnoczi wrote: On Fri, May 20, 2016 at 03:36:10PM +0800, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http:/

Re: [Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-31 Thread Marcel Apfelbaum
On 05/31/2016 10:50 AM, Igor Mammedov wrote: On Mon, 30 May 2016 21:18:59 +0300 Marcel Apfelbaum wrote: On 05/17/2016 05:42 PM, Igor Mammedov wrote: move the former SSDT part of CPU hoplug close to DSDT part. AML is only moved but there isn't any functional change. The patch looks good to

Re: [Qemu-devel] [PATCH v7 00/17] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-05-31 Thread Michael S. Tsirkin
On Tue, May 31, 2016 at 10:20:42AM +0300, Dmitry Fleytman wrote: > Hello All, > > This is v7 of e1000e series. > > For convenience, the same patches are available at: > https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-v7 > > Best regards, > Dmitry. series: Acked-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] block: Fix leak of BdrvIoctlCompletionData when driver returns NULL

2016-05-31 Thread Fam Zheng
On Tue, 05/31 11:14, Paolo Bonzini wrote: > > > On 31/05/2016 10:34, Fam Zheng wrote: > > "data" allocated in bdrv_co_do_ioctl is not freed. Free it before > > returning. > > > > Cc: qemu-sta...@nongnu.org > > Reported-by: Kevin Wolf > > Signed-off-by: Fam Zheng > > --- > > block/io.c | 1 + >

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Fam Zheng
On Tue, 05/31 10:51, Paolo Bonzini wrote: > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > > new file mode 100644 > > index 000..372733d > > --- /dev/null > > +++ b/tests/docker/Makefile.include > > @@ -0,0 +1,121 @@ > > +# Makefile for Docker tests > > + > > +in

Re: [Qemu-devel] [RFC PATCH V4 0/4] Introduce COLO-compare

2016-05-31 Thread Jason Wang
On 2016年05月31日 16:28, Zhang Chen wrote: On 05/31/2016 02:16 PM, Jason Wang wrote: On 2016年05月31日 11:54, Zhang Chen wrote: On 05/30/2016 11:19 AM, Jason Wang wrote: On 2016年05月25日 20:50, Zhang Chen wrote: COLO-compare is a part of COLO project. It is used to compare the network packa

Re: [Qemu-devel] [PATCH 2/4] target-tricore: Added MADD.F and MSUB.F instructions

2016-05-31 Thread Bastian Koppelmann
On 05/30/2016 12:59 AM, peer.ad...@c-lab.de wrote: > +uint32_t helper_fmadd(CPUTriCoreState *env, uint32_t r1, > + uint32_t r2, uint32_t r3) > +{ > +uint32_t flags; > +float32 arg1 = make_float32(r1); > +float32 arg2 = make_float32(r2); > +float32 arg3 = make_fl

[Qemu-devel] including the "git describe" output in the QEMU binaries?

2016-05-31 Thread Laszlo Ersek
Hi, has this been raised / considered before? To me at least it would be extremely useful if QEMU binaries built from a git working directory returned the output of "git describe" (+ possibly a hint about an unclean working directory), when invoked with "-version". Not volunteering for the implem

Re: [Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in use

2016-05-31 Thread Markus Armbruster
Robert Hu writes: > On Tue, 2016-05-31 at 09:51 +0200, Markus Armbruster wrote: >> Robert Ho writes: >> >> > If no display option defined in QEMU command line, and SDL is not >> > available, then it by default uses '-vnc localhost:0,to=99,id=default'. >> > This patch simply print out the defaul

Re: [Qemu-devel] including the "git describe" output in the QEMU binaries?

2016-05-31 Thread Daniel P. Berrange
On Tue, May 31, 2016 at 01:16:14PM +0200, Laszlo Ersek wrote: > Hi, > > has this been raised / considered before? To me at least it would be > extremely useful if QEMU binaries built from a git working directory > returned the output of "git describe" (+ possibly a hint about an > unclean working

[Qemu-devel] [PATCH v2] scsi: esp: check TI buffer index before read/write

2016-05-31 Thread P J P
From: Prasad J Pandit The 53C9X Fast SCSI Controller(FSC) comes with internal 16-byte FIFO buffers. One is used to handle commands and other is for information transfer. While reading/writing to these buffers an index into 's->ti_buf[TI_BUFSZ=16]' could exceed its size. Add check to avoid OOB r/w

[Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value

2016-05-31 Thread Cédric Le Goater
commit 243e6f69c129 ("m25p80: Switch to byte-based block access") replaced blk_read() calls with blk_pread() but return values are different. Signed-off-by: Cédric Le Goater --- hw/block/m25p80.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu-ast2400-mainline.git/hw/block/

  1   2   3   4   >