On 05/20/2016 02:26 AM, Eric Blake wrote:
On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
Pls note, trace_init_backends() must be called in the final process, i.e.
s/Pls/Please/
after daemonization. This is necessary to keep tracing thread in the
proper process.
Signed-off-by: Denis V. Lunev <d...@openvz.org>
CC: Paolo Bonzini <pbonz...@redhat.com>
CC: Stefan Hajnoczi <stefa...@redhat.com>
CC: Kevin Wolf <kw...@redhat.com>
---
qemu-nbd.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
Same comments as on 2/3 - missing documentation - this time, it is the
man page that is incomplete.
@@ -87,6 +89,7 @@ static void usage(const char *name)
"General purpose options:\n"
" --object type,id=ID,... define an object such as 'secret' for
providing\n"
" passwords and/or encryption keys\n"
+" -T, --trace FILE enable trace events listed in the given file\n"
Insufficient, compared to how qemu's help text reads.
But overall a cool concept. Are there any plans to convert some of the
TRACE() debugging printfs in nbd/* into actual trace points?
hmm, interesting. Will think on this.
