[Qemu-devel] [PATCH 0/4] slirp: Spring-cleaning

2016-05-13 Thread Thomas Huth
QEMU 2.6.0 has been released ... time for some spring-cleaning in the slirp code: These patches remove some old and unused code, and clean up osdep.h related header inclusions. Thomas Huth (4): slirp: Clean up slirp_config.h slirp: Remove obsolete backward-compatibility cruft slirp: Remove s

[Qemu-devel] [PATCH 2/4] slirp: Remove obsolete backward-compatibility cruft

2016-05-13 Thread Thomas Huth
The slirp code does not use index() and gethostid() anymore, so these parts can be removed without problems. memmove() and strerror() should be available on each of the supported platforms nowadays, too, so these wrappers are also not needed anymore. And we certainly also do not support Ultrix anym

[Qemu-devel] [PATCH 3/4] slirp: Remove some unused code from slirp.h

2016-05-13 Thread Thomas Huth
These hunks are apparently not used anymore, so let's delete them. Signed-off-by: Thomas Huth --- slirp/slirp.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 5b5df59..e373876 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -58,10

[Qemu-devel] [PATCH 4/4] slirp: Clean up osdep.h related header inclusions

2016-05-13 Thread Thomas Huth
qemu/osdep.h is included in some headers twice - one time should be sufficient. Also remove the inclusion of time.h since that is already done by osdep.h, too (this makes scripts/clean-includes happy again). Signed-off-by: Thomas Huth --- slirp/ip6_icmp.c | 1 - slirp/ip_input.c | 1 - slirp/udp

[Qemu-devel] [PATCH 1/4] slirp: Clean up slirp_config.h

2016-05-13 Thread Thomas Huth
There are a lot of unused #defines / #undefs in slirp_config.h, which are apparently left-overs from the very early slirp code. Since there is no more code that uses them, let's simply remove them from our version of slirp. Signed-off-by: Thomas Huth --- slirp/slirp_config.h | 87 ---

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Dong Jia
On Thu, 12 May 2016 13:05:52 -0600 Alex Williamson wrote: > On Thu, 12 May 2016 08:00:36 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Thursday, May 12, 2016 6:06 AM > > > > > > On Wed, 11 May 2016 17:15:15 +0800 > > > Jike Song wro

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Tian, Kevin
> From: Neo Jia [mailto:c...@nvidia.com] > Sent: Friday, May 13, 2016 2:42 PM > > > > > > We possibly have the same requirement from the mediate driver backend: > > > > a) get a GFN, when guest try to tell hardware; > > b) consult the vfio iommu with that GFN[1]: will you find me a proper

Re: [Qemu-devel] [PATCH qemu v16 01/19] vfio: Delay DMA address space listener release

2016-05-13 Thread Alexey Kardashevskiy
On 05/06/2016 08:39 AM, Alex Williamson wrote: On Wed, 4 May 2016 16:52:13 +1000 Alexey Kardashevskiy wrote: This postpones VFIO container deinitialization to let region_del() callbacks (called via vfio_listener_release) do proper clean up while the group is still attached to the container.

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 03:10:22PM +0800, Dong Jia wrote: > On Thu, 12 May 2016 13:05:52 -0600 > Alex Williamson wrote: > > > On Thu, 12 May 2016 08:00:36 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > > Sent: Thursday, May 12, 2016 6:

Re: [Qemu-devel] [PATCH v5 0/3] usb, xen: add pvUSB backend

2016-05-13 Thread Gerd Hoffmann
On Do, 2016-05-12 at 16:13 +0200, Juergen Gross wrote: > This series adds a Xen pvUSB backend driver to qemu. USB devices > connected to the host can be passed through to a Xen guest. The > devices are specified via Xenstore. Access to the devices is done > via host-libusb.c > > I've tested the ba

[Qemu-devel] [PATCH 1/1] migration: fix ram decompression race deadlock

2016-05-13 Thread Denis V. Lunev
From: Maxim Nestratov There is a race in between do_data_decompress and start_decompression. do_data_decompress() while (!quit_decomp_thread) { qemu_mutex_lock(¶m->mutex); while (!param->start && !quit_decomp_thread) { qemu_cond_wait(¶m->cond, ¶m->mutex);

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Jike Song
On 05/13/2016 02:43 PM, Neo Jia wrote: > On Fri, May 13, 2016 at 02:22:37PM +0800, Jike Song wrote: >> On 05/13/2016 10:41 AM, Tian, Kevin wrote: From: Neo Jia [mailto:c...@nvidia.com] Sent: Friday, May 13, 2016 3:49 AM > >> Perhaps one possibility would be to allow the vgp

Re: [Qemu-devel] [PATCH v3 0/4] QOM'ify hw/audio files

2016-05-13 Thread Gerd Hoffmann
On Fr, 2016-05-13 at 11:46 +0800, xiaoqiang zhao wrote: > This patch set QOM'ify some files under hw/audio directory. > See each patch's commit message for details. > > Changes in v3: > * fix code style errors > * refine error_setg message format Added to audio patch queue. thanks, Gerd

Re: [Qemu-devel] ipxe and arm

2016-05-13 Thread Thomas Huth
On 12.05.2016 16:03, Gerd Hoffmann wrote: > Hi, > >>> I don't understand the question, sorry. How can ipxe fail if ipxe is not >>> made available to the guest, in any NIC's PCI option ROM BAR? >> What I meat to say is that on x86 user can use rtl8139 or e1000 to use >> ipxe. If uefi doesn't supp

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 07:13:44AM +, Tian, Kevin wrote: > > From: Neo Jia [mailto:c...@nvidia.com] > > Sent: Friday, May 13, 2016 2:42 PM > > > > > > > > > > We possibly have the same requirement from the mediate driver backend: > > > > > > a) get a GFN, when guest try to tell hardware; >

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 03:30:27PM +0800, Jike Song wrote: > On 05/13/2016 02:43 PM, Neo Jia wrote: > > On Fri, May 13, 2016 at 02:22:37PM +0800, Jike Song wrote: > >> On 05/13/2016 10:41 AM, Tian, Kevin wrote: > From: Neo Jia [mailto:c...@nvidia.com] Sent: Friday, May 13, > 2016 3:49 AM

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Tian, Kevin
> From: Neo Jia [mailto:c...@nvidia.com] > Sent: Friday, May 13, 2016 3:42 PM > > On Fri, May 13, 2016 at 03:30:27PM +0800, Jike Song wrote: > > On 05/13/2016 02:43 PM, Neo Jia wrote: > > > On Fri, May 13, 2016 at 02:22:37PM +0800, Jike Song wrote: > > >> On 05/13/2016 10:41 AM, Tian, Kevin wrote:

Re: [Qemu-devel] [PULL 00/12] ui patch queue

2016-05-13 Thread Gerd Hoffmann
Hi, > > This was on ppc64be Linux, though I'm guessing that's just because > > it's the only system that happens not to define CONFIG_VTE. > > mingw builds don't have vte too, so I'm wondering now how that one > managed to escape my attention ... Ah, because only linux builds default to -Werro

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Tian, Kevin
> From: Neo Jia [mailto:c...@nvidia.com] > Sent: Friday, May 13, 2016 3:38 PM > > On Fri, May 13, 2016 at 07:13:44AM +, Tian, Kevin wrote: > > > From: Neo Jia [mailto:c...@nvidia.com] > > > Sent: Friday, May 13, 2016 2:42 PM > > > > > > > > > > > > > > We possibly have the same requirement fro

Re: [Qemu-devel] [PATCH V2] net/net: Add SocketReadState for reuse codes

2016-05-13 Thread Zhang Chen
On 05/13/2016 12:02 PM, Jason Wang wrote: On 2016年05月12日 17:19, Zhang Chen wrote: This function is from net/socket.c, move it to net.c and net.h. Add SocketReadState to make others reuse net_fill_rstate(). suggestion from jason. v2: - rename ReadState to SocketReadState - add SocketRead

Re: [Qemu-devel] RFC: Proposed vfio IGD assignment fw_cfg ABI

2016-05-13 Thread Gerd Hoffmann
> #1: "etc/igd-opregion" > > the IGD OpRegion is an area of memory which contains among other > things, the Video BIOS Table which is integral in allowing an assigned > IGD to configure and make use of the physical display outputs of the > system. "etc/igd-opregion" is an opaque fw_cfg file which

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 07:45:14AM +, Tian, Kevin wrote: > > From: Neo Jia [mailto:c...@nvidia.com] > > Sent: Friday, May 13, 2016 3:42 PM > > > > On Fri, May 13, 2016 at 03:30:27PM +0800, Jike Song wrote: > > > On 05/13/2016 02:43 PM, Neo Jia wrote: > > > > On Fri, May 13, 2016 at 02:22:37PM

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Dong Jia
On Fri, 13 May 2016 00:24:34 -0700 Neo Jia wrote: > On Fri, May 13, 2016 at 03:10:22PM +0800, Dong Jia wrote: > > On Thu, 12 May 2016 13:05:52 -0600 > > Alex Williamson wrote: > > > > > On Thu, 12 May 2016 08:00:36 + > > > "Tian, Kevin" wrote: > > > > > > > > From: Alex Williamson [mailto

Re: [Qemu-devel] [PATCH qemu v16 19/19] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2016-05-13 Thread Bharata B Rao
On Wed, May 4, 2016 at 12:22 PM, Alexey Kardashevskiy wrote: > This adds support for Dynamic DMA Windows (DDW) option defined by > the SPAPR specification which allows to have additional DMA window(s) > > The "ddw" property is enabled by default on a PHB but for compatibility > the pseries-2.5 mac

Re: [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub

2016-05-13 Thread Kevin Wolf
Am 13.05.2016 um 10:29 hat Sebastian Färber geschrieben: > Add support for reopen() by adding the .bdrv_reopen_prepare() stub > > Signed-off-by: Sebastian Färber > Tested-by: Sebastian Färber > --- > block/rbd.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/block/rbd.c b/bl

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 08:02:41AM +, Tian, Kevin wrote: > > From: Neo Jia [mailto:c...@nvidia.com] > > Sent: Friday, May 13, 2016 3:38 PM > > > > On Fri, May 13, 2016 at 07:13:44AM +, Tian, Kevin wrote: > > > > From: Neo Jia [mailto:c...@nvidia.com] > > > > Sent: Friday, May 13, 2016 2:42

Re: [Qemu-devel] [Qemu-arm] [PATCH RESEND 2/5] hw/display: QOM'ify jazz_led.c

2016-05-13 Thread Leon Alrae
On Thu, May 05, 2016 at 01:46:13PM +0100, Peter Maydell wrote: > On 5 May 2016 at 04:04, xiaoqiang zhao wrote: > > * Drop the old SysBus init function and use instance_init > > * Move graphic_console_init into realize stage > > > > Signed-off-by: xiaoqiang zhao > > --- > > hw/display/jazz_led.c

Re: [Qemu-devel] [PATCH qemu v16 19/19] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2016-05-13 Thread Bharata B Rao
On Fri, May 13, 2016 at 2:11 PM, Bharata B Rao wrote: > On Wed, May 4, 2016 at 12:22 PM, Alexey Kardashevskiy wrote: >> +static void rtas_ibm_create_pe_dma_window(PowerPCCPU *cpu, >> + sPAPRMachineState *spapr, >> +

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Neo Jia
On Fri, May 13, 2016 at 04:39:37PM +0800, Dong Jia wrote: > On Fri, 13 May 2016 00:24:34 -0700 > Neo Jia wrote: > > > On Fri, May 13, 2016 at 03:10:22PM +0800, Dong Jia wrote: > > > On Thu, 12 May 2016 13:05:52 -0600 > > > Alex Williamson wrote: > > > > > > > On Thu, 12 May 2016 08:00:36 +

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Jike Song
On 05/13/2016 04:31 PM, Neo Jia wrote: > On Fri, May 13, 2016 at 07:45:14AM +, Tian, Kevin wrote: >> >> We use page tracking framework, which is newly added to KVM recently, >> to mark RAM pages as read-only so write accesses are intercepted to >> device model. > > Yes, I am aware of that pat

Re: [Qemu-devel] [RFC v2 04/11] tcg: comment on which functions have to be called with tb_lock held

2016-05-13 Thread Paolo Bonzini
On 12/05/2016 21:32, Sergey Fedorov wrote: >> > >> > As mentioned above, user-mode emulation uses l1_map in linux-user/mmap.c >> > via page_{get,set}_flags, which I guess is why the lock is separate. >> > None of us was involved in the original multi-threaded linux-user work, >> > we're reverse e

Re: [Qemu-devel] [PATCH v3] target-i386: implement CPUID[0xB] (Extended Topology Enumeration)

2016-05-13 Thread Igor Mammedov
On Thu, 12 May 2016 19:24:26 +0200 Radim Krčmář wrote: > I looked at a dozen Intel CPU that have this CPUID and all of them > always had Core offset as 1 (a wasted bit when hyperthreading is > disabled) and Package offset at least 4 (wasted bits at <= 4 cores). > > QEMU uses more compact IDs and

Re: [Qemu-devel] [PATCH 0/4] slirp: Spring-cleaning

2016-05-13 Thread Peter Maydell
On 13 May 2016 at 08:04, Thomas Huth wrote: > QEMU 2.6.0 has been released ... time for some spring-cleaning > in the slirp code: These patches remove some old and unused > code, and clean up osdep.h related header inclusions. > > Thomas Huth (4): > slirp: Clean up slirp_config.h > slirp: Remo

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-05-13 Thread Jike Song
On 05/13/2016 04:12 AM, Neo Jia wrote: > On Thu, May 12, 2016 at 01:05:52PM -0600, Alex Williamson wrote: >> >> If you're trying to equate the scale of what we need to track vs what >> type1 currently tracks, they're significantly different. Possible >> things we need to track include the pfn, the

Re: [Qemu-devel] [PULL 00/12] ui patch queue

2016-05-13 Thread Peter Maydell
On 13 May 2016 at 08:56, Gerd Hoffmann wrote: >> > This was on ppc64be Linux, though I'm guessing that's just because >> > it's the only system that happens not to define CONFIG_VTE. >> >> mingw builds don't have vte too, so I'm wondering now how that one >> managed to escape my attention ... > >

[Qemu-devel] tsc=reliable in Linux guests

2016-05-13 Thread Richard W.M. Jones
I was wondering why the Linux kernel was spending 21ms starting up each secondary CPU when we boot it virtualized with qemu -smp >= 2. It turns out the time was lost in check_tsc_sync_target(). This is easily avoided by using `tsc=reliable' on the command line, saving 63ms when starting a guest w

Re: [Qemu-devel] [PULL 00/39] tcg-next patch queue

2016-05-13 Thread Peter Maydell
On 13 May 2016 at 01:13, Richard Henderson wrote: > Wow, this has gotten a bit longer than I remembered. > > > r~ > > > The following changes since commit f68419eee9a966f5a915314c43cda6778f976a77: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-05-12 16:3

[Qemu-devel] [PULL 0/2] target-mips queue

2016-05-13 Thread Leon Alrae
at: git://github.com/lalrae/qemu.git tags/mips-20160513 for you to fetch changes up to 7fe91a5b33fe100bbc68ee434f947752c69b3f68: hw/display: QOM'ify jazz_led.c (2016-05-13 09:33:38 +0100) MIPS patches 2016-05-13 Changes:

[Qemu-devel] [PULL 1/2] target-mips: fix call to memset in soft reset code

2016-05-13 Thread Leon Alrae
From: Aurelien Jarno Recent versions of GCC report the following error when compiling target-mips/helper.c: qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size] This is indeed correct and

[Qemu-devel] [PULL 2/2] hw/display: QOM'ify jazz_led.c

2016-05-13 Thread Leon Alrae
From: "xiaoqiang.zhao" * Drop the old SysBus init function and use instance_init * Move graphic_console_init into realize stage Signed-off-by: xiaoqiang zhao Reviewed-by: Peter Maydell Signed-off-by: Leon Alrae --- hw/display/jazz_led.c | 18 +++--- 1 file changed, 11 insertions(

Re: [Qemu-devel] [PATCH 1/3] qemu-io: Fix missing getopt() updates

2016-05-13 Thread Max Reitz
On 12.05.2016 23:39, Eric Blake wrote: > Commit 770e0e0e [*] forgot to implement 'writev -f'. Likewise, > commit c3e001c forgot to implement 'aio_write -u -z'. *c2e001c I can fix that while applying, though. Max > > [*] does it sound "ech0e" in here? :) > > Signed-off-by: Eric Blake > --- >

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Fix regression in 136 on aio_read invalid

2016-05-13 Thread Max Reitz
On 12.05.2016 23:39, Eric Blake wrote: > Commit 093ea232 removed the ability for aio_read and aio_write > to artificially inflate the invalid statistics counters for > block devices, since it no longer flags unaligned offset or > length. Add 'aio_read -i' and 'aio_write -i' to restore > the abilit

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Simplify 109 with unaligned qemu-img compare

2016-05-13 Thread Max Reitz
On 12.05.2016 23:39, Eric Blake wrote: > For some time now, qemu-img compare has been able to compare > unaligned images. So we no longer need test 109's hack of > resizing to sector boundaries before invoking compare. > > Signed-off-by: Eric Blake Reviewed-by: Max Reitz signature.asc Descr

Re: [Qemu-devel] [PATCH 1/3] qemu-io: Fix missing getopt() updates

2016-05-13 Thread Max Reitz
On 13.05.2016 13:55, Max Reitz wrote: > On 12.05.2016 23:39, Eric Blake wrote: >> Commit 770e0e0e [*] forgot to implement 'writev -f'. Likewise, >> commit c3e001c forgot to implement 'aio_write -u -z'. > > *c2e001c > > I can fix that while applying, though. (With that fixed: Reviewed-by: Max R

Re: [Qemu-devel] [PULL 0/2] target-mips queue

2016-05-13 Thread Peter Maydell
gt; Update version for v2.6.0 release (2016-05-11 16:44:26 +0100) > > are available in the git repository at: > > git://github.com/lalrae/qemu.git tags/mips-20160513 > > for you to fetch changes up to 7fe91a5b33fe100bbc68ee434f947752c69b3f68: > &

Re: [Qemu-devel] [PATCH 0/3] Fix recent qemu-iotests issues

2016-05-13 Thread Max Reitz
On 12.05.2016 23:39, Eric Blake wrote: > I introduced a couple of bugs in my recent qemu-io enhancements; > time to fix them back up now that the broken patches are already > part of mainline. > > Eric Blake (3): > qemu-io: Fix missing getopt() updates > qemu-iotests: Simplify 109 with unalign

Re: [Qemu-devel] [PATCH] gtk: don't leak the GtkBorder with VTE 0.36

2016-05-13 Thread Gerd Hoffmann
On Fr, 2016-05-13 at 11:20 +0300, Alberto Garcia wrote: > When gtk_widget_style_get() is used to get the "inner-border" style > property, it returns a copy of the GtkBorder which must be freed by > the caller. > > This patch also fixes a warning about the unused 'padding' structure > with VTE 0.36

[Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20

2016-05-13 Thread Gerd Hoffmann
Fixes the remaining gtk 3.20 warnings. Signed-off-by: Gerd Hoffmann Reviewed-by: Cole Robinson Tested-by: Cole Robinson Message-id: 1463038146-13939-1-git-send-email-kra...@redhat.com --- ui/gtk.c | 49 +++-- 1 file changed, 43 insertions(+), 6 delet

[Qemu-devel] [PULL v2 11/17] ui/gtk: copy to clipboard support

2016-05-13 Thread Gerd Hoffmann
From: "Michael S. Tsirkin" This adds a menu item to copy current selection to clipboard. Seems handy for copying out guest error messages. Signed-off-by: Michael S. Tsirkin Message-id: 1460924740-24513-1-git-send-email-...@redhat.com [ kraxel: fix build with CONFIG_VTE=n ] [ kraxel: fix build

[Qemu-devel] [PULL v2 04/17] configure: error on unknown --with-sdlabi value

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson I accidentally tried --with-sdlabi="1.0", and it failed much later in a weird way. Instead, throw an error if the value isn't in our whitelist. Signed-off-by: Cole Robinson Message-id: 60e4822e17697d257a914df03bdb9fff4b4c0490.1462557436.git.crobi...@redhat.com Signed-off-by

[Qemu-devel] [PULL v2 13/17] Changed malloc to g_malloc, free to g_free in ui/shader.c

2016-05-13 Thread Gerd Hoffmann
From: Md Haris Iqbal Signed-off-by: Md Haris Iqbal Message-id: 1459862499-4768-1-git-send-email-haris.p...@gmail.com Signed-off-by: Gerd Hoffmann --- ui/shader.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/shader.c b/ui/shader.c index 9264009..1ffddbe 100644

[Qemu-devel] [PULL v2 17/17] gtk: don't leak the GtkBorder with VTE 0.36

2016-05-13 Thread Gerd Hoffmann
From: Alberto Garcia When gtk_widget_style_get() is used to get the "inner-border" style property, it returns a copy of the GtkBorder which must be freed by the caller. This patch also fixes a warning about the unused 'padding' structure with VTE 0.36. Signed-off-by: Alberto Garcia Message-id:

[Qemu-devel] [PULL v2 02/17] ui: sdl2: Release grab before opening console window

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson sdl 2.0.4 currently has a bug which causes our UI shortcuts to fire rapidly in succession: https://bugzilla.libsdl.org/show_bug.cgi?id=3287 It's a toss up whether ctrl+alt+f or ctrl+alt+2 will fire an odd or even number of times, thus determining whether the action succeed

[Qemu-devel] [PULL v2 14/17] egl-helpers: fix possible resource leak

2016-05-13 Thread Gerd Hoffmann
From: Gonglei CID 1352419, using g_strdup_printf instead of asprintf. Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Message-id: 1463047028-123868-2-git-send-email-arei.gong...@huawei.com Signed-off-by: Gerd Hoffmann --- ui/egl-helpers.c | 9 +++-- 1 file changed, 3 insertions(+), 6 d

[Qemu-devel] [PULL v2 08/17] configure: support vte-2.91

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson vte >= 0.37 expores API version 2.91, which is where all the active development is. qemu builds and runs fine with that version, so use it if it's available. Signed-off-by: Cole Robinson Message-id: b4f0375647f7b368d3dbd3834aee58cb0253566a.1462557436.git.crobi...@redhat.com

[Qemu-devel] [PULL v2 00/17] ui patch queue

2016-05-13 Thread Gerd Hoffmann
:12 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20160513-1 for you to fetch changes up to 6978dc4adcdf27722aa6f9e13f88a903b30a3f8d: gtk: don't leak the GtkBorder with VTE 0.36 (2016-05-13 12:40:12

[Qemu-devel] [PULL v2 06/17] configure: report GTK version

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Signed-off-by: Cole Robinson Message-id: 4c464e20d69fdcf21927ceed31a8d749b4af0c49.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 76600f4..55bd35

[Qemu-devel] [PULL v2 03/17] configure: build SDL if only SDL2 available

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Right now if SDL2 is installed but not SDL1, default configure will entirely disable SDL. Check upfront for SDL2 using pkg-config, but still prefer SDL1 if both versions are installed. Signed-off-by: Cole Robinson Message-id: c9e570b5964d128a3595efe3170129a3da459776.1462557

[Qemu-devel] [PULL v2 10/17] ui: gtk: Fix some deprecation warnings

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson All device manager APIs are deprecated now. Much of our usage is just to get the current pointer, so centralize that logic and use the new seat APIs Signed-off-by: Cole Robinson Message-id: d6dec24220a4e1449a0172119c10c48e145c0f6f.1462557436.git.crobi...@redhat.com Signed-o

[Qemu-devel] [PULL v2 15/17] spice: fix coverity complains

2016-05-13 Thread Gerd Hoffmann
From: Gonglei Remove the unnecessary NULL check. Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Message-id: 1463047028-123868-3-git-send-email-arei.gong...@huawei.com Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a

[Qemu-devel] [PULL v2 01/17] ui: gtk: fix crash when terminal inner-border is NULL

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson VTE terminal inner-border can be NULL. The vte-0.36 (API 2.90) code checks for the condition too so I assume it's not just a bug Fixes a crash on Fedora 24 with gtk 3.20 Signed-off-by: Cole Robinson Message-id: 2b2e85d403e8760ea53afd735a170500d5c17716.1462557436.git.crobi.

[Qemu-devel] [PULL v2 09/17] ui: gtk: Fix a runtime warning on vte >= 0.37

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson inner-border was dropped in vte API 2.91, in favor of the standard padding style Signed-off-by: Cole Robinson Message-id: 60a6cdc337d611d902f53907e66a8f37ea374d65.1462557436.git.crobi...@redhat.com [ kraxel: Fix warning with old vte version. ] Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL v2 12/17] spice/gl: add & use qemu_spice_gl_monitor_config

2016-05-13 Thread Gerd Hoffmann
Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/ui/spice-display.h | 1 + ui/spice-display.c | 30 ++ 2 files changed, 31 insertions(+) diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h in

[Qemu-devel] [PULL v2 05/17] configure: add echo_version helper

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Simplifies printing library versions, dependent on if the library was even found Signed-off-by: Cole Robinson Message-id: 3c9ab16123e06bb4109771ef6ee8acd82d449ba0.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 18 -- 1 file

[Qemu-devel] [PULL v2 07/17] configure: report SDL version

2016-05-13 Thread Gerd Hoffmann
From: Cole Robinson Signed-off-by: Cole Robinson Message-id: 98e4a3b98dc824bfaff96db43b172272c780c15f.1462557436.git.crobi...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 55bd354..

[Qemu-devel] [PATCH v3 2/6] pc: Postpone SMBIOS table installation to post machine init

2016-05-13 Thread minyard
From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c inde

[Qemu-devel] [PATCH v3 1/6] ipmi fwinfo: Remove ACPI parent, add the device

2016-05-13 Thread minyard
From: Corey Minyard Instead of storing the ACPI parent, store the device in the fwinfo structure for IPMI. This way a future change that scans the IPMI devices for firmware can select the devices on a particular bus. This will let the ACPI scope be defined by the calling code so the IPMI code d

[Qemu-devel] [PATCH v3 4/6] ipmi: Add SMBIOS table entry

2016-05-13 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- hw/smbios/Makefile.objs | 2 ++ hw/smbios/ipmi.c | 76 hw/smbios/noipmi.c | 14 + hw/smbios/smbios.

[Qemu-devel] [PATCH v3 5/6] acpi: Add IPMI table entries

2016-05-13 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_dsdt to add an DSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not compiled in. This conforms

[Qemu-devel] [PATCH v3 0/6] Add ACPI and SMBIOS tables for IPMI

2016-05-13 Thread minyard
This rework is based on Michael's comments on the SMBus series. This patch series modifies the way the tables are added so that they are scanned from the ACPI code handling that particular bus instead of all being added at the end. This way the IPMI ACPI code doesn't have to know the ACPI scope o

[Qemu-devel] [PATCH v3 3/6] smbios: Move table build tools into an include file.

2016-05-13 Thread minyard
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77 2 files changed,

Re: [Qemu-devel] [PATCH 01/14] block: keep a list of block jobs

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > From: Alberto Garcia > > The current way to obtain the list of existing block jobs is to > iterate over all root nodes and check which ones own a job. > > Since we want to be able to support block jobs in other nodes as well, > this patch keeps a list of

Re: [Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the right CRS

2016-05-13 Thread Corey Minyard
On 05/12/2016 08:39 AM, Michael S. Tsirkin wrote: On Thu, May 12, 2016 at 08:29:53AM -0500, Corey Minyard wrote: On 05/12/2016 02:33 AM, Michael S. Tsirkin wrote: On Wed, May 11, 2016 at 02:46:05PM -0500, miny...@acm.org wrote: From: Corey Minyard Signed-off-by: Corey Minyard --- hw/acpi/

Re: [Qemu-devel] [PATCH 02/14] block: Cancel jobs first in bdrv_close_all()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > So far, bdrv_close_all() first removed all root BlockDriverStates of > BlockBackends and monitor owned BDSes, and then assumed that the > remaining BDSes must be related to jobs and cancelled these jobs. > > This order doesn't work that well any more when b

Re: [Qemu-devel] [PATCH 03/14] block: Default to enabled write cache in blk_new()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > The existing users of the function are: > > 1. blk_new_open(), which already enabled the write cache > 2. Some test cases that don't care about the setting > 3. blockdev_init() for empty drives, where the cache mode is overridden >with the value from th

Re: [Qemu-devel] [PATCH 0/3] Fix recent qemu-iotests issues

2016-05-13 Thread Eric Blake
On 05/13/2016 06:06 AM, Max Reitz wrote: > On 12.05.2016 23:39, Eric Blake wrote: >> I introduced a couple of bugs in my recent qemu-io enhancements; >> time to fix them back up now that the broken patches are already >> part of mainline. >> >> Eric Blake (3): >> qemu-io: Fix missing getopt() upd

Re: [Qemu-devel] [PATCH 04/14] block: Convert block job core to BlockBackend

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This adds a new BlockBackend field to the BlockJob struct, which > coexists with the BlockDriverState while converting the individual jobs. > > When creating a block job, a new BlockBackend is created on top of the > given BlockDriverState, and it is destro

Re: [Qemu-devel] [PATCH 05/14] stream: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the streaming block job to use the job's BlockBackend for > performing the COR reads. job->bs isn't used by the streaming code any > more afterwards. > > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 15 +++ >

Re: [Qemu-devel] [PATCH 06/14] mirror: Allow target that already has a BlockBackend

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > We had to forbid mirroring to a target BDS that already had a BB > attached because the node swapping at job completion would add a second > BB and we didn't support multiple BBs on a single BDS at the time. Now > we do, so we can lift the restriction. > As

Re: [Qemu-devel] [PATCH 00/23] GICv3 emulation

2016-05-13 Thread Shannon Zhao
On 2016年05月12日 23:22, Peter Maydell wrote: > On 12 May 2016 at 16:01, Shannon Zhao wrote: >> On 2016年05月12日 22:35, Peter Maydell wrote: >>> Can you put the Image file somewhere I can download it, please? >> I just upload it to >> http://people.linaro.org/~shannon.zhao/ACPI_ARM/Image > > OK, I can

Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the mirror block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the mirroring code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 75 > +++-

Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the mirror block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the mirroring code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 75 > +++-

Re: [Qemu-devel] [PULL v2 00/17] ui patch queue

2016-05-13 Thread Peter Maydell
lowing changes since commit 860a3b34854d8abe9af9f1eb584691de926ce897: > > Update version for v2.6.0-rc5 release (2016-05-09 14:08:12 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-ui-20160513-1 > > for you to fetch changes up to 6978dc4adcdf27722aa6f9e13f88a903b30

[Qemu-devel] [PATCH] migration: fix ram decompression race deadlock

2016-05-13 Thread Maxim Nestratov
The way how decompress_data_with_multi_threads communicates with do_data_decompress is incorrect. Imagine the following scenario. The function do_data_decompress just finished decompression and released param->mutex and got preempted. In parallel, the function decompress_data_with_multi_threads cal

[Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub

2016-05-13 Thread Sebastian Färber
Add support for reopen() by adding the .bdrv_reopen_prepare() stub Signed-off-by: Sebastian Färber Tested-by: Sebastian Färber --- block/rbd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index 5bc5b32..5f121b5 100644 --- a/block/rbd.c +++ b/block/rbd.c

Re: [Qemu-devel] Make virtio-net.c ring size configurable?

2016-05-13 Thread xchenum
Luke, I might have a similar problem... I am wondering if you end up increasing the ring buffer size yourself. My problem is on the tx side. When sending many small udp packets, I am seeing "outgoing packets dropped" in "netstat -s" increase quickly. Increasing txqueue of the interface and wmem

Re: [Qemu-devel] [PATCH 08/14] backup: Don't leak BackupBlockJob in error path

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/backup.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

[Qemu-devel] [Bug 1581334] [NEW] qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread chenwqin
Public bug reported: I got an IO problem. When running Qemu + ceph(use librbd), and do a random IO benchmark or some high load random IO test, it will exhaust all my host cpu on %sy cpu. It doesn’t happen all the time, but when it appear it will reproduce every time I start a random IO benchmar

Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O

2016-05-13 Thread Eric Blake
On 05/13/2016 08:38 AM, Max Reitz wrote: > On 04.05.2016 11:39, Kevin Wolf wrote: >> This changes the mirror block job to use the job's BlockBackend for >> performing its I/O. job->bs isn't used by the mirroring code any more >> afterwards. >> >> Signed-off-by: Kevin Wolf >> --- >> @@ -156,8 +156

Re: [Qemu-devel] [PATCH 09/14] backup: Pack Notifier within BackupBlockJob

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > From: John Snow > > Instead of relying on peeking at bs->job, we want to explicitly get > a reference to the job that was involved in this notifier callback. > > Pack the Notifier inside of the BackupBlockJob so we can use > container_of to get a referenc

[Qemu-devel] [Bug 1581308] [NEW] ohci doesn't check the 'num-ports' property

2016-05-13 Thread Li Qiang
Public bug reported: command: qemu-system-x86_64 -m 1024 -enable-kvm /root/centos6.img -enable-kvm -device pci-ohci,num-ports=100,masterbus=1 The ohci doesn't check the 'num-ports' property and would case an out- of-bands write,crash the qemu process. ohci->num_ports = num_ports; if (ma

Re: [Qemu-devel] [PATCH 11/23] hw/intc/arm_gicv3: Implement GICv3 distributor registers

2016-05-13 Thread Shannon Zhao
On 2016年05月10日 01:29, Peter Maydell wrote: > +static MemTxResult gicd_writeb(GICv3State *s, hwaddr offset, > + uint64_t value, MemTxAttrs attrs) > +{ > +/* Most GICv3 distributor registers do not support byte accesses. */ > +switch (offset) { > +case GICD_C

Re: [Qemu-devel] [PATCH 10/14] backup: Remove bs parameter from backup_do_cow()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > Now that we pass the job to the function, bs is implied by that. > > Signed-off-by: Kevin Wolf > --- > block/backup.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digi

Re: [Qemu-devel] [Bug 1581334] [NEW] qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Serge Hallyn
affects linux ** Also affects: linux Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581334 Title: qemu + librbd takes high %sy cpu under high random io

Re: [Qemu-devel] [PATCH 11/14] block: Add blk_co_readv/writev()

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 26 ++ > include/sysemu/block-backend.h | 4 > trace-events | 2 ++ > 3 files changed, 32 insertions(+) Reasonable in principle, but not su

[Qemu-devel] [Bug 1581334] Re: qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Josh Durgin
Since this works fine with krbd, it sounds like the bug may be in librbd. Could you install debug symbols (the librbd1-dbg package) and when this occurs, attach to the qemu process with gdb and get a backtrace of all threads (there will be a lot of them) via 'gdb -p $pid' and in gdb 'thread apply a

Re: [Qemu-devel] [Bug 1581334] [NEW] qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Serge Hallyn
affects ceph ** Also affects: ceph Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581334 Title: qemu + librbd takes high %sy cpu under high random io w

Re: [Qemu-devel] [PATCH 12/14] backup: Use BlockBackend for I/O

2016-05-13 Thread Max Reitz
On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the backup block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the backup code any more > afterwards. > > Signed-off-by: Kevin Wolf > --- > block/backup.c | 42 > ++-

Re: [Qemu-devel] [PATCH 11/23] hw/intc/arm_gicv3: Implement GICv3 distributor registers

2016-05-13 Thread Peter Maydell
On 13 May 2016 at 16:05, Shannon Zhao wrote: > On 2016年05月10日 01:29, Peter Maydell wrote: >> +static MemTxResult gicd_writeb(GICv3State *s, hwaddr offset, >> + uint64_t value, MemTxAttrs attrs) >> +{ >> +/* Most GICv3 distributor registers do not support byte acce

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-05-13 Thread Peter Maydell
On 12 May 2016 at 02:46, 赵小强 wrote: > > 在 2016-03-31 16:15:17,"xiaoqiang zhao" 写道: >> >> >>> 在 2016年3月31日,16:05,Peter Maydell 写道: >>> On 31 March 2016 at 02:48, xiaoqiang zhao wrote: > 在 2016年03月16日 20:00, Peter Maydell 写道: > >> On 16 March 2016 at 11:31, Peter Maydell >

  1   2   >