On 04.05.2016 11:39, Kevin Wolf wrote: > So far, bdrv_close_all() first removed all root BlockDriverStates of > BlockBackends and monitor owned BDSes, and then assumed that the > remaining BDSes must be related to jobs and cancelled these jobs. > > This order doesn't work that well any more when block jobs use > BlockBackends internally because then they will lose their BDS before > being cancelled. > > This patch changes bdrv_close_all() to first cancel all jobs and then > remove all root BDSes from the remaining BBs. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 23 +---------------------- > blockjob.c | 13 +++++++++++++ > include/block/blockjob.h | 7 +++++++ > 3 files changed, 21 insertions(+), 22 deletions(-)
I agree with Berto about the assertion because it was me who suggested it. :-) And because I didn't give Berto an R-b because of that I'm afraid I can't give you one either. O:-) Max
signature.asc
Description: OpenPGP digital signature
