Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-18 Thread Markus Armbruster
Sascha Silbe writes: > Running an iotests-based Python test directly might appear to work, > but may fail in subtle ways and is insecure: > > - It creates files with predictable file names in a world-writable > location (/var/tmp). > > - Tests expect the environment to be set up by check. E.g.

[Qemu-devel] [PATCH] ICH9: fix typo

2016-04-18 Thread Cao jin
Signed-off-by: Cao jin --- include/hw/i386/ich9.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index d04dcdc..abf84ed 100644 --- a/include/hw/i386/ich9.h +++ b/include/hw/i386/ich9.h @@ -35,7 +35,7 @@ typedef struct ICH9LPCSta

Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-18 Thread Alexander Graf
On 18.04.16 08:53, Gerd Hoffmann wrote: > Hi, > >> Vnc already uses qemu_input_event_send_key_delay today, so I'm not sure >> where things fall apart. > > Well, not everywhere. Try the attached patch. > > Also worth trying: > * use xhci instead of ohci (current slof should handle >kbd

Re: [Qemu-devel] [PATCH] ICH9: fix typo

2016-04-18 Thread Cao jin
hi mst, please ingore this one, I find more small fix like this, I will pack all these into one On 04/18/2016 03:24 PM, Cao jin wrote: Signed-off-by: Cao jin --- include/hw/i386/ich9.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/ich9.h b/include/

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

2016-04-18 Thread Richard W.M. Jones
On Mon, Apr 18, 2016 at 09:10:36AM +0800, Fam Zheng wrote: > On Sun, 04/17 20:27, Richard W.M. Jones wrote: > > On Fri, Apr 15, 2016 at 11:27:55AM +0800, Fam Zheng wrote: > > > virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > > > the intervene. > > > +static int raw_lockf(BlockD

Re: [Qemu-devel] [PATCH] ICH9: fix typo

2016-04-18 Thread Michael S. Tsirkin
Pls repost all this after 2.6 is out. Thanks! On Mon, Apr 18, 2016 at 03:57:42PM +0800, Cao jin wrote: > hi mst, > please ingore this one, I find more small fix like this, I will pack all > these into one > > On 04/18/2016 03:24 PM, Cao jin wrote: > >Signed-off-by: Cao jin > >--- > > includ

[Qemu-devel] [PATCH] cuda: fix off-by-one error in SET_TIME command

2016-04-18 Thread Aurelien Jarno
With the new framework the cuda_cmd_set_time command directly receive the data, without the command byte. Therefore the time is stored at in_data[0], not at in_data[1]. This fixes the "hwclock --systohc" command in a guest. Cc: Hervé Poussineau Cc: David Gibson Signed-off-by: Aurelien Jarno --

Re: [Qemu-devel] [PATCH for-2.7 00/49] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-04-18 Thread Markus Armbruster
Needs a rebase, but better delay rebasing until later, because this stuff goes stale quickly. What's your base commit? Got a branch I can pull?

Re: [Qemu-devel] [PULL 00/19] Block layer patches for 2.6.0-rc3

2016-04-18 Thread Peter Maydell
On 15 April 2016 at 18:02, Kevin Wolf wrote: > The following changes since commit 538a467329818ea831f602491ac62d7d7999102a: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into > staging (2016-04-15 10:49:04 +0100) > > are available in the git repository at: > > > g

Re: [Qemu-devel] [PATCH v3 12/13] q35: ioapic: add support for split irqchip and irqfd

2016-04-18 Thread Peter Xu
On Sun, Apr 17, 2016 at 12:45:03PM +0300, Michael S. Tsirkin wrote: > On Sat, Apr 16, 2016 at 07:44:12PM -0700, Jan Kiszka wrote: > > On 2016-04-14 20:31, Peter Xu wrote: [...] > > > diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c > > > index 84e8948..b993bd0 100644 > > > --- a/hw/intc/ioapic.c >

[Qemu-devel] [PULL] Update OpenBIOS images

2016-04-18 Thread Mark Cave-Ayland
Hi Peter, This update is primarily to fix a regression booting early versions of MacOS X under qemu-system-ppc. Please pull. ATB, Mark. The following changes since commit c7b45f12828c1ba7105dbc029c63d7de68eaa91c: Merge remote-tracking branch 'remotes/armbru/tags/pull-backends-2016-04-15'

Re: [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks

2016-04-18 Thread Alex Bennée
Peter Maydell writes: > On 15 April 2016 at 16:56, Alex Bennée wrote: >> A number of configure options only really affect the core code and any >> arch specific stuff should be flushed out by other builds: >> >> - trace-backends, log build is all targets, others can be less >> - --disable-b

Re: [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 10:15, Alex Bennée wrote: > Peter Maydell writes: >> The wildcarding gives you a configure command that will >> potentially change behaviour as we introduce new targets, >> too; that makes me a bit nervous. > > Well it doesn't stop you using the full names but I take your poin

Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-18 Thread Gerd Hoffmann
On Mo, 2016-04-18 at 09:26 +0200, Alexander Graf wrote: > > On 18.04.16 08:53, Gerd Hoffmann wrote: > > Hi, > > > >> Vnc already uses qemu_input_event_send_key_delay today, so I'm not sure > >> where things fall apart. > > > > Well, not everywhere. Try the attached patch. > > > > Also worth

Re: [Qemu-devel] [PULL 0/1] Wxx patch for 2.6

2016-04-18 Thread Peter Maydell
On 15 April 2016 at 18:45, Stefan Weil wrote: > The following changes since commit c7b45f12828c1ba7105dbc029c63d7de68eaa91c: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-backends-2016-04-15' > into staging (2016-04-15 17:43:34 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH 1/2] ehci: apply limit to itd/sidt descriptors

2016-04-18 Thread Gerd Hoffmann
Commit "156a2e4 ehci: make idt processing more robust" tries to avoid a DoS by the guest (create a circular itd queue and let qemu ehci emulation run in circles forever). Unfortunaly this has two problems: First it misses the case of sitds, and second it reportly breaks freebsd. So lets go for a

[Qemu-devel] [PATCH 2/2] Revert "ehci: make idt processing more robust"

2016-04-18 Thread Gerd Hoffmann
This reverts commit 156a2e4dbffa85997636a7a39ef12da6f1b40254. Breaks freebsd. --- hw/usb/hcd-ehci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 923f110..7add81c 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1397

Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-18 Thread Alexander Graf
On 18.04.16 11:21, Gerd Hoffmann wrote: > On Mo, 2016-04-18 at 09:26 +0200, Alexander Graf wrote: >> >> On 18.04.16 08:53, Gerd Hoffmann wrote: >>> Hi, >>> Vnc already uses qemu_input_event_send_key_delay today, so I'm not sure where things fall apart. >>> >>> Well, not everywhere.

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Daniel P. Berrange
On Fri, Apr 15, 2016 at 08:56:59AM -0700, H. Peter Anvin wrote: > On April 15, 2016 3:41:34 AM PDT, Cole Robinson wrote: > >Libvirt currently rejects using host /dev/urandom as an input source > >for a > >virtio-rng device. The only accepted sources are /dev/random and > >/dev/hwrng. > >This is th

[Qemu-devel] [PATCH] migration: remove useless code

2016-04-18 Thread Liang Li
page_buffer is set twice repeatedly, remove the previous set. Signed-off-by: Liang Li --- migration/ram.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 3f05738..31d40f4 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2322,7 +2322,6 @@ static in

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

2016-04-18 Thread Daniel P. Berrange
On Mon, Apr 18, 2016 at 09:12:44AM +0800, Fam Zheng wrote: > On Sat, 04/16 16:29, Denis V. Lunev wrote: > > On 04/15/2016 06:27 AM, Fam Zheng wrote: > > >virtlockd in libvirt locks the first byte, we lock byte 1 to avoid > > >the intervene. > > > > > >Suggested-by: "Daniel P. Berrange" > > >Signed

Re: [Qemu-devel] [PATCH for-2.7 v2 05/17] raw-posix: Implement .bdrv_lockf

2016-04-18 Thread Denis V. Lunev
On 04/18/2016 12:34 PM, Daniel P. Berrange wrote: On Mon, Apr 18, 2016 at 09:12:44AM +0800, Fam Zheng wrote: On Sat, 04/16 16:29, Denis V. Lunev wrote: On 04/15/2016 06:27 AM, Fam Zheng wrote: virtlockd in libvirt locks the first byte, we lock byte 1 to avoid the intervene. Suggested-by: "Dan

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Andrea Arcangeli (aarca...@redhat.com) wrote: > On Fri, Apr 15, 2016 at 06:23:30PM +0300, Kirill A. Shutemov wrote: > > The same here. Freshly booted machine with 64GiB ram. I've checked > > /proc/vmstat: huge pages were allocated > > I tried the test in a loop and I can't reproduce it here. >

Re: [Qemu-devel] [PATCH] migration: remove useless code

2016-04-18 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > page_buffer is set twice repeatedly, remove the previous set. > > Signed-off-by: Liang Li > --- > migration/ram.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 3f05738..31d40f4 100644 > --- a/migratio

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread H. Peter Anvin
On April 18, 2016 2:28:42 AM PDT, "Daniel P. Berrange" wrote: >On Fri, Apr 15, 2016 at 08:56:59AM -0700, H. Peter Anvin wrote: >> On April 15, 2016 3:41:34 AM PDT, Cole Robinson >wrote: >> >Libvirt currently rejects using host /dev/urandom as an input source >> >for a >> >virtio-rng device. The

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Li, Liang Z
> > > > I've run it directly, setting relevant QTEST_QEMU_BINARY. > > > > > > Interesting; it's failing reliably for me - but only with a > > > reasonably freshly booted machine (so that the pages get THPd). > > > > The same here. Freshly booted machine with 64GiB ram. I've checked > > /proc/vmstat

Re: [Qemu-devel] [PATCH 2/4] .travis.yml: reduce target list on core configure tweaks

2016-04-18 Thread Alex Bennée
Peter Maydell writes: > On 18 April 2016 at 10:15, Alex Bennée wrote: >> Peter Maydell writes: >>> The wildcarding gives you a configure command that will >>> potentially change behaviour as we introduce new targets, >>> too; that makes me a bit nervous. >> >> Well it doesn't stop you using th

Re: [Qemu-devel] [PATCH for-2.7 v2 00/17] block: Lock images when opening

2016-04-18 Thread Daniel P. Berrange
On Fri, Apr 15, 2016 at 11:27:50AM +0800, Fam Zheng wrote: > v2: Lock byte 1 in the image itself, no lock file. [Daniel] > Fix migration (image are not locked in bdrv_open_common if > BDRV_O_INACTIVE). [Denis] > Simplify test case fixes because of the above. > Add lock for RBD. >

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > > > > I've run it directly, setting relevant QTEST_QEMU_BINARY. > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > reasonably freshly booted machine (so that the pages get THPd). > > > > > > The same here. Freshly boot

[Qemu-devel] [PATCH RFC 1/3] virtio: add features for IOMMU control

2016-04-18 Thread Michael S. Tsirkin
The interaction between virtio and DMA API is messy. On most systems with virtio, physical addresses match bus addresses, and it doesn't particularly matter whether we use the DMA API. On some systems, including Xen and any system with a physical device that speaks virtio behind a physical IOMMU,

[Qemu-devel] [PATCH RFC 0/3] virtio-pci: iommu support

2016-04-18 Thread Michael S. Tsirkin
This is an attempt to allow enabling IOMMU for DMA. Design: - new feature bit IOMMU_PLATFORM which means host won't bypass IOMMU - virtio core uses DMA API if it sees IOMMU_PLATFORM - add quirk for vfio to disable device unless IOMMU_PLATFORM is set or th

[Qemu-devel] [PATCH RFC 2/3] vfio: report group noiommu status

2016-04-18 Thread Michael S. Tsirkin
When using vfio, callers might want to know whether device is added to a regular group or an non-iommu group. Report this status from vfio_add_group_dev. Signed-off-by: Michael S. Tsirkin --- drivers/vfio/pci/vfio_pci.c | 2 +- drivers/vfio/platform/vfio_platform_common.c | 2 +

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Li, Liang Z
> * Andrea Arcangeli (aarca...@redhat.com) wrote: > > On Fri, Apr 15, 2016 at 06:23:30PM +0300, Kirill A. Shutemov wrote: > > > The same here. Freshly booted machine with 64GiB ram. I've checked > > > /proc/vmstat: huge pages were allocated > > > > I tried the test in a loop and I can't reproduce i

[Qemu-devel] [PATCH RFC 3/3] vfio: add virtio pci quirk

2016-04-18 Thread Michael S. Tsirkin
Modern virtio pci devices can set VIRTIO_F_IOMMU_PLATFORM to signal they are safe to use with an IOMMU. Without this bit, exposing the device to userspace is unsafe, so probe and fail VFIO initialization unless noiommu is enabled. Signed-off-by: Michael S. Tsirkin --- drivers/vfio/pci/vfio_pci_

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Li, Liang Z
> * Li, Liang Z (liang.z...@intel.com) wrote: > > > > > > I've run it directly, setting relevant QTEST_QEMU_BINARY. > > > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > reasonably freshly booted machine (so that the pages get THPd). > > > > > > > > The same here

[Qemu-devel] [PATCH] cadence_uart: bounds check write offset

2016-04-18 Thread Michael S. Tsirkin
cadence_uart_init() initializes an I/O memory region of size 0x1000 bytes. However in uart_write(), the 'offset' parameter (offset within region) is divided by 4 and then used to index the array 'r' of size CADENCE_UART_R_MAX which is much smaller: (0x48/4). If 'offset>>=2' exceeds CADENCE_UART_R

Re: [Qemu-devel] [PATCH] cadence_uart: bounds check write offset

2016-04-18 Thread Peter Maydell
CCing the maintainers for this device... On 18 April 2016 at 11:07, Michael S. Tsirkin wrote: > cadence_uart_init() initializes an I/O memory region of size 0x1000 > bytes. However in uart_write(), the 'offset' parameter (offset within > region) is divided by 4 and then used to index the array '

Re: [Qemu-devel] [PULL 00/03] seccomp branch queue

2016-04-18 Thread Peter Maydell
On 16 April 2016 at 20:04, Eduardo Otubo wrote: > The following changes since commit c7b45f12828c1ba7105dbc029c63d7de68eaa91c: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-backends-2016-04-15' > into staging (2016-04-15 17:43:34 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > * Li, Liang Z (liang.z...@intel.com) wrote: > > > > > > > I've run it directly, setting relevant QTEST_QEMU_BINARY. > > > > > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > > reasonably freshly booted machine (so t

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Li, Liang Z
> > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > > > reasonably freshly booted machine (so that the pages get THPd). > > > > > > > > > > > > The same here. Freshly booted machine with 64GiB ram. I've > > > > > > checked > > > > > > /proc/vmstat: huge pages were al

[Qemu-devel] [PATCH v2 1/3] powerpc: scan_features() updates incorrect bits for REAL_LE

2016-04-18 Thread Michael Ellerman
From: Anton Blanchard The REAL_LE feature entry in the ibm_pa_feature struct is missing an MMU feature value, meaning all the remaining elements initialise the wrong values. This means instead of checking for byte 5, bit 0, we check for byte 0, bit 0, and then we incorrectly set the CPU feature

Re: [Qemu-devel] [PULL 0/3] ppc-for-2.6 queue 20160418

2016-04-18 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160418 > > for you to fetch changes up to aa378598fea819b15c00d48048bedfa0dc631132: > > ppc: Fix migration of the XER register (2016-04-18 15:14:38 +1000) > >

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Hubert Kario
On Friday 15 April 2016 17:51:36 H. Peter Anvin wrote: > On April 15, 2016 9:10:44 AM PDT, Hubert Kario wrote: > >On Friday 15 April 2016 09:47:51 Eric Blake wrote: > >> On 04/15/2016 04:41 AM, Cole Robinson wrote: > >> > Libvirt currently rejects using host /dev/urandom as an input > > > >source

Re: [Qemu-devel] [PATCH] cuda: fix off-by-one error in SET_TIME command

2016-04-18 Thread Hervé Poussineau
Le 18/04/2016 10:07, Aurelien Jarno a écrit : This fixes the "hwclock --systohc" command in a guest. Cc: Hervé Poussineau Cc: David Gibson Signed-off-by: Aurelien Jarno Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Hubert Kario
On Monday 18 April 2016 02:46:19 H. Peter Anvin wrote: > Another thing that really needs to be addressed, but is a separate > issue: invalidating and reseeding the entropy pool after a snapshot > event. definitely agreed though just reseeding would be sufficient - the goal is to make the output

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-18 Thread Li, Liang Z
Hi Dave, I am now working on how to benefit post-copy by skipping the free pages, and I remember you have said we should let the destination know the info of free pages so as to avoid request the free pages from the source. We have two solutions: a. send the migration dirty page bitmap to dest

[Qemu-devel] [Bug 1571084] Re: Qemu 2.x dont build on last Gtk dev 3.0+

2016-04-18 Thread Peter Maydell
Thanks for the bug report. You can avoid this being a compilation failure by passing configure the option "--disable-werror". (This is the default for releases, so you only need it for building QEMU from git (a build from a release tarball or a release candidate tarball should be fine). -- You re

[Qemu-devel] [RFC PATCH V3 0/4] Introduce COLO-compare

2016-04-18 Thread Zhang Chen
COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. We rebase colo-compare to colo-frame v2.7 you can get the codes from github: https://github.com/zhangckid/qemu/tree/colo-v2.7-proxy-mode-apr18 v3: - rebase colo-comp

[Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-04-18 Thread Zhang Chen
packet come from primary char indev will be send to outdev - packet come from secondary char dev will be drop usage: primary: -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66 -chardev socket,id=mirror0,host=3.3.3.3

[Qemu-devel] [RFC PATCH V3 3/4] colo-compare: introduce packet comparison thread

2016-04-18 Thread Zhang Chen
if packets are same, we send primary packet and drop secondary packet, otherwise notify COLO do checkpoint. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 126 + trace-events |

[Qemu-devel] [RFC PATCH V3 4/4] colo-compare: add TCP, UDP, ICMP packet comparison

2016-04-18 Thread Zhang Chen
Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 158 +++-- 1 file changed, 154 insertions(+), 4 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 4b5a2d4..3dad461 1006

[Qemu-devel] [RFC PATCH V3 2/4] colo-compare: track connection and enqueue packet

2016-04-18 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 10:04, Mark Cave-Ayland wrote: > Hi Peter, > > This update is primarily to fix a regression booting early versions of MacOS > X under qemu-system-ppc. Please pull. > > > ATB, > > Mark. > > > The following changes since commit c7b45f12828c1ba7105dbc029c63d7de68eaa91c: > > Mer

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Hubert Kario
On Sunday 17 April 2016 17:27:05 H. Peter Anvin wrote: > On 04/16/16 01:31, Paolo Bonzini wrote: > > Right, but there's always the point about people that use > > heterogeneous hosts and cannot pass rdrand/rdseed to the guest. > > For these, we should add a QEMU driver that uses rdrand/rdseed, and

[Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Peter Maydell
Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and the mailing list we seem to be in reasonable shape for the 2.6 release. I would ideally like the 2.6rc3 tarball which we will make later this week to be the final one before full release. This is therefore the last call for any bugs

Re: [Qemu-devel] RFC: virtio-rng and /dev/urandom

2016-04-18 Thread Daniel P. Berrange
On Mon, Apr 18, 2016 at 01:07:40PM +0200, Hubert Kario wrote: > On Monday 18 April 2016 02:46:19 H. Peter Anvin wrote: > > Another thing that really needs to be addressed, but is a separate > > issue: invalidating and reseeding the entropy pool after a snapshot > > event. > > definitely agreed >

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 11:08:31AM +, Li, Liang Z wrote: > Hi Dave, > > I am now working on how to benefit post-copy by skipping the free pages, > and I remember you have said we should let the destination know the info > of free pages so as to avoid request the free pages from the source. >

[Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
This adds a flag to enable/disable bypassing the IOMMU by virtio devices. This is on top of patch http://article.gmane.org/gmane.comp.emulators.qemu/403467 virtio: convert to use DMA api Tested with patchset http://article.gmane.org/gmane.linux.kernel.virtualization/27545 virtio-pci: iommu suppor

Re: [Qemu-devel] [PATCH 1/2] ehci: apply limit to itd/sidt descriptors

2016-04-18 Thread P J P
+-- On Mon, 18 Apr 2016, Gerd Hoffmann wrote --+ | Commit "156a2e4 ehci: make idt processing more robust" tries to avoid a | DoS by the guest (create a circular itd queue and let qemu ehci | emulation run in circles forever). Unfortunaly this has two problems: | First it misses the case of sitds,

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread David Woodhouse
On Mon, 2016-04-18 at 14:47 +0300, Michael S. Tsirkin wrote: > This adds a flag to enable/disable bypassing the IOMMU by > virtio devices. I'm still deeply unhappy with having this kind of hack in the virtio code at all, as you know. Drivers should just use the DMA API and if the *platform* wants

[Qemu-devel] [PATCH v8 2/3] block: add support for encryption secrets in block I/O tests

2016-04-18 Thread Daniel P. Berrange
The LUKS block driver tests will require the ability to specify encryption secrets with block devices. This requires using the --object argument to qemu-img/qemu-io to create a 'secret' object. When the IMGKEYSECRET env variable is set, it provides the password to be associated with a secret calle

[Qemu-devel] [PATCH v8 0/3] Tests for LUKS driver

2016-04-18 Thread Daniel P. Berrange
This series contains the 3 test suite patches that had to be dropped from the v6 series during merge with the block tree: v6: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04935.html v7: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg06687.html Changed in v8: - Add conver

[Qemu-devel] [PATCH v8 3/3] block: enable testing of LUKS driver with block I/O tests

2016-04-18 Thread Daniel P. Berrange
This adds support for testing the LUKS driver with the block I/O test framework. cd tests/qemu-io-tests ./check -luks A handful of test cases are modified to work with luks - 004 - whitelist luks format - 012 - use TEST_IMG_FILE instead of TEST_IMG for file ops - 048 - use TEST_IMG_FILE

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Mark Cave-Ayland
On 18/04/16 12:22, Peter Maydell wrote: > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > the mailing list we seem to be in reasonable shape for the 2.6 release. > I would ideally like the 2.6rc3 tarball which we will make later this > week to be the final one before full relea

[Qemu-devel] [PATCH v8 1/3] block: add support for --image-opts in block I/O tests

2016-04-18 Thread Daniel P. Berrange
Currently all block tests use the traditional syntax for images just specifying a filename. To support the LUKS driver without resorting to JSON, the tests need to be able to use the new --image-opts argument to qemu-img and qemu-io. This introduces a new env variable IMGOPTSSYNTAX. If this is set

[Qemu-devel] [PATCH] xenfb: Fix overzealous ring test

2016-04-18 Thread Samuel Thibault
From: Wei Liu pv-grub booting got broken with recent qemu-xen, due to ac0487e1d2ae811cd4d035741a109a4ecfb013f1 ('xenfb.c: avoid expensive loops when prod <= out_cons') prod - out_cons can actually be XENFB_OUT_RING_LEN when the ring is exactly full, this is a normal condition and should not be e

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Samuel Thibault
Hello, Peter wrote: > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > the mailing list we seem to be in reasonable shape for the 2.6 release. > I would ideally like the 2.6rc3 tarball which we will make later this > week to be the final one before full release. > > This is the

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 12:22, Peter Maydell wrote: > This is therefore the last call for any bugs that need to be fixed > for 2.6 or patches that must go in. If you have anything you think > should go into 2.6 please either add it to the "still unfixed in > master" part of the planning wiki page or f

Re: [Qemu-devel] [PATCH 01/50] scripts: add script to build QEMU and analyze inclusions

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > scripts/analyze-inclusions | 89 > ++ > 1 file changed, 89 insertions(+) > create mode 100644 scripts/analyze-inclusions > > diff --git a/scripts/analyze-inclusions b/scripts/analyze-inclu

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 07:58:37AM -0400, David Woodhouse wrote: > On Mon, 2016-04-18 at 14:47 +0300, Michael S. Tsirkin wrote: > > This adds a flag to enable/disable bypassing the IOMMU by > > virtio devices. > > I'm still deeply unhappy with having this kind of hack in the virtio > code at all,

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-18 Thread Sergey Fedorov
On 07/04/16 19:18, Cornelia Huck wrote: > On Thu, 7 Apr 2016 18:53:44 +0300 > Sergey Fedorov wrote: (snip) >> --- >> pc-bios/s390-ccw/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile >> index 4208cb429593..

Re: [Qemu-devel] post-copy is broken?

2016-04-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > > > > > > > Interesting; it's failing reliably for me - but only with a > > > > > > > > reasonably freshly booted machine (so that the pages get THPd). > > > > > > > > > > > > > > The same here. Freshly booted machine with 64GiB ram. I've > > > > > >

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Stefan Weil
Am 18.04.2016 um 15:02 schrieb Peter Maydell: > On 18 April 2016 at 12:22, Peter Maydell wrote: >> This is therefore the last call for any bugs that need to be fixed >> for 2.6 or patches that must go in. If you have anything you think >> should go into 2.6 please either add it to the "still unfix

Re: [Qemu-devel] [PATCH 13/50] target-ppc: do not use target_ulong in cpu-qom.h

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > Bring the PowerPCCPUClass handle_mmu_fault method type into line with > the one in CPUState. You mean CPUClass, don't you? > Using vaddr also makes the cpu-qom.h file target independent. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 14:44, Stefan Weil wrote: > Am 18.04.2016 um 15:02 schrieb Peter Maydell: >> Hi Stefan -- I see you added "update the translation po/ files" >> to the list. Can you remind me how to do this? I think it's >> just "make -C po update", which seems to update the creation >> date ti

Re: [Qemu-devel] [PATCH 39/50] gdbstub: remove includes from gdbstub-xml.c

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > gdbstub-xml.c defines a bunch of arrays of strings; there is no > need to include anything. > > Signed-off-by: Paolo Bonzini > --- > scripts/feature_to_c.sh | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/scripts/feature_to_c.sh b/scripts/feature_to_c.sh > ind

Re: [Qemu-devel] [PATCH 49/50] hw: remove pio_addr_t

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > pio_addr_t is almost unused, because these days I/O ports are simply > accessed through the address space. cpu_{in,out}[bwl] themselves are > almost unused; monitor.c and xen-hvm.c could use address_space_read/write > directly, since they have an integer size at hand. Th

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread David Woodhouse
On Mon, 2016-04-18 at 16:12 +0300, Michael S. Tsirkin wrote: > I'm not sure I understand the issue.  The public API is not about how > the driver works.  It doesn't say "don't use DMA API" anywhere, does it? > It's about telling device whether to obey the IOMMU and > about discovering whether a dev

Re: [Qemu-devel] [PATCH for-2.7 00/49] NEED_CPU_H / cpu.h / hw/hw.h cleanups

2016-04-18 Thread Markus Armbruster
Paolo Bonzini writes: > (CCs only on cover letter due to huge series). > > I am sending this now because of vacation coming soon (yay!). > This series removes usage of NEED_CPU_H from several central > include files in QEMU, most notably hw/hw.h and qemu-common.h. > Definitions conditional on NEE

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > 'tb_invalidated_flag' was meant to catch two events: > * some TB has been invalidated by tb_phys_invalidate(); > * the whole translation buffer has been flushed by tb_flush(). > > Then it was checked: > * in cpu_exec() to ensure that the last

Re: [Qemu-devel] [PATCH 39/50] gdbstub: remove includes from gdbstub-xml.c

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 14:54, Markus Armbruster wrote: > Paolo Bonzini writes: > >> gdbstub-xml.c defines a bunch of arrays of strings; there is no >> need to include anything. > We might want to include osdep.h anyway, just to avoid adding an > exception to the rule "any C file must include qemu/o

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

2016-04-18 Thread David Gibson
On Mon, Apr 18, 2016 at 01:23:06PM +0100, Mark Cave-Ayland wrote: > On 18/04/16 12:22, Peter Maydell wrote: > > > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > > the mailing list we seem to be in reasonable shape for the 2.6 release. > > I would ideally like the 2.6rc3 tarbal

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 10:03:52AM -0400, David Woodhouse wrote: > On Mon, 2016-04-18 at 16:12 +0300, Michael S. Tsirkin wrote: > > I'm not sure I understand the issue.  The public API is not about how > > the driver works.  It doesn't say "don't use DMA API" anywhere, does it? > > It's about telli

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-18 Thread Li, Liang Z
> On Mon, Apr 18, 2016 at 11:08:31AM +, Li, Liang Z wrote: > > Hi Dave, > > > > I am now working on how to benefit post-copy by skipping the free > > pages, and I remember you have said we should let the destination know > > the info of free pages so as to avoid request the free pages from the

Re: [Qemu-devel] [PATCH] xenfb: Fix overzealous ring test

2016-04-18 Thread Wei Liu
On Mon, Apr 18, 2016 at 02:41:48PM +0200, Samuel Thibault wrote: > From: Wei Liu > > pv-grub booting got broken with recent qemu-xen, due to > ac0487e1d2ae811cd4d035741a109a4ecfb013f1 ('xenfb.c: avoid expensive loops > when prod <= out_cons') > > prod - out_cons can actually be XENFB_OUT_RING_LE

Re: [Qemu-devel] [PATCH] xenfb: Fix overzealous ring test

2016-04-18 Thread Samuel Thibault
Wei Liu, on Mon 18 Apr 2016 15:40:15 +0100, wrote: > This patch is already queued by Stefano. Ah, sorry, I missed it. Samuel

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-18 Thread Cornelia Huck
On Thu, 7 Apr 2016 18:53:44 +0300 Sergey Fedorov wrote: > From: Sergey Fedorov > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov > --- > pc-bios/s390-ccw/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s3

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Sergey Fedorov
On 18/04/16 17:09, Alex Bennée wrote: > Sergey Fedorov writes: >> From: Sergey Fedorov >> >> 'tb_invalidated_flag' was meant to catch two events: >> * some TB has been invalidated by tb_phys_invalidate(); >> * the whole translation buffer has been flushed by tb_flush(). >> >> Then it was checke

[Qemu-devel] Persistent Main Memory in QEmu

2016-04-18 Thread Li, Tianyou
Hi, Currently we are trying to implement below functionalities in QEmu: main memory in guest can be logically viewed as persistent and its content can be survived through reboot or shutdown/powerup. I have looked into the QEmu memory management code include memory.c, exec.c and other related s

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread David Woodhouse
On Mon, 2016-04-18 at 17:23 +0300, Michael S. Tsirkin wrote: > > This patch doesn't change DMAR tables, it creates a way for virtio > device to tell guest "I obey what DMAR tables tell you, you can stop > doing hacks". > > And as PPC guys seem adamant that platform tools there are no good for > t

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 11:22:03AM -0400, David Woodhouse wrote: > On Mon, 2016-04-18 at 17:23 +0300, Michael S. Tsirkin wrote: > > > > This patch doesn't change DMAR tables, it creates a way for virtio > > device to tell guest "I obey what DMAR tables tell you, you can stop > > doing hacks". > >

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-18 Thread Cornelia Huck
On Mon, 18 Apr 2016 16:51:16 +0200 Cornelia Huck wrote: > On Thu, 7 Apr 2016 18:53:44 +0300 > Sergey Fedorov wrote: > > > From: Sergey Fedorov > > > > Signed-off-by: Sergey Fedorov > > Signed-off-by: Sergey Fedorov > > --- > > pc-bios/s390-ccw/Makefile | 2 +- > > 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH v3 4/4] tcg: rework tb_invalidated_flag

2016-04-18 Thread Peter Maydell
On 18 April 2016 at 16:05, Sergey Fedorov wrote: > @@ -507,14 +510,12 @@ int cpu_exec(CPUState *cpu) > } > tb_lock(); > tb = tb_find_fast(cpu); > -/* Note: we do it here to avoid a gcc bug on Mac OS X when > - doi

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-04-18 Thread Michael S. Tsirkin
On Mon, Apr 18, 2016 at 02:36:31PM +, Li, Liang Z wrote: > > On Mon, Apr 18, 2016 at 11:08:31AM +, Li, Liang Z wrote: > > > Hi Dave, > > > > > > I am now working on how to benefit post-copy by skipping the free > > > pages, and I remember you have said we should let the destination know > >

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-18 Thread Sergey Fedorov
On 18/04/16 18:34, Cornelia Huck wrote: > On Mon, 18 Apr 2016 16:51:16 +0200 > Cornelia Huck wrote: > >> On Thu, 7 Apr 2016 18:53:44 +0300 >> Sergey Fedorov wrote: >> >>> From: Sergey Fedorov >>> >>> Signed-off-by: Sergey Fedorov >>> Signed-off-by: Sergey Fedorov >>> --- >>> pc-bios/s390-ccw

Re: [Qemu-devel] [PATCH RFC] fixup! virtio: convert to use DMA api

2016-04-18 Thread David Woodhouse
On Mon, 2016-04-18 at 18:30 +0300, Michael S. Tsirkin wrote: > > > Setting (only) VIRTIO_F_IOMMU_PASSTHROUGH indicates to the guest that > > its own operating system's IOMMU code is expected to be broken, and > > that the virtio driver should eschew the DMA API? > > No - it tells guest that e.g.

[Qemu-devel] [PATCH v5 5/9] target-mips: Activate IEEE 274-2008 signaling NaN bit meaning

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Functions mips_cpu_reset() and msa_reset() are updated so that flag snan_bit_is_one is properly set for any Mips FPU/MSA configuration. For main FPUs, CPUs with FCR31's FCR31_NAN2008 bit set will invoke set_snan_bit_is_one(0). For MSA, as it is IEEE 274-2008 compliant fr

[Qemu-devel] [PATCH v5 4/9] target-mips: Amend processor definitions in relation to FCR31

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Amend definitions of some Mips processors related to FCR31 (float status control register). Most significantly, FCR31 of processors mips32r6-generic, mips64r6-generic, and P5600 will be set so that its FCR31_ABS2008 and FCR31_NAN2008 bits are set to 1. Signed-off-by: Al

[Qemu-devel] [PATCH v5 2/9] softfloat: For Mips only, correct default NaN values

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic Only for Mips platform, and only for cases when snan_bit_is_one is 0, correct default NaN values (in their 16-, 32-, and 64-bit flavors). For more info, see [1], page 84, Table 6.3 "Value Supplied When a New Quiet NaN Is Created", and [2], page 52, Table 3.7 "Default Na

[Qemu-devel] [PATCH v5 7/9] target-mips: Add nan2008 flavor of ..

2016-04-18 Thread Aleksandar Markovic
From: Aleksandar Markovic New set of helpers for handling nan2008-syle versions of instructions .., for Mips R6. All involved instructions have float operand and integer result. Their core functionality is implemented via invocations of appropriate SoftFloat functions. The problematic cases are

  1   2   >