On 18/04/16 18:34, Cornelia Huck wrote: > On Mon, 18 Apr 2016 16:51:16 +0200 > Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > >> On Thu, 7 Apr 2016 18:53:44 +0300 >> Sergey Fedorov <sergey.fedo...@linaro.org> wrote: >> >>> From: Sergey Fedorov <serge.f...@gmail.com> >>> >>> Signed-off-by: Sergey Fedorov <serge.f...@gmail.com> >>> Signed-off-by: Sergey Fedorov <sergey.fedo...@linaro.org> >>> --- >>> pc-bios/s390-ccw/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile >>> index 4208cb429593..5ce6d4ccbaf5 100644 >>> --- a/pc-bios/s390-ccw/Makefile >>> +++ b/pc-bios/s390-ccw/Makefile >>> @@ -20,7 +20,7 @@ s390-ccw.elf: $(OBJECTS) >>> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS)," Building >>> $(TARGET_DIR)$@") >>> >>> s390-ccw.img: s390-ccw.elf >>> - $(call quiet-command,strip --strip-unneeded $< -o $@," Stripping >>> $(TARGET_DIR)$@") >>> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@," Stripping >>> $(TARGET_DIR)$@") >>> >>> $(OBJECTS): Makefile >>> >> Thanks, applied to s390-next. > Uhm, scratch that. > > This fails to build with --disable-strip, as $STRIP is unset in that > case: > > Building s390-ccw/s390-ccw.elf > Stripping s390-ccw/s390-ccw.img > /bin/sh: --strip-unneeded: command not found > make[1]: *** [s390-ccw.img] Error 127 > > > The catch is that we always want to strip that binary. Care to send a > patch that deals with that? >
I see the problem. I don't promise to fix it soon, but I could try dealing with this as I have time. I don't mind if someone else can just fix it with their own patch :) Kind regards, Sergey
