Re: [Qemu-devel] [PATCH for-2.7 07/15] qemu-io: Add "-L" option for BDRV_O_NO_LOCK

2016-04-14 Thread Denis V. Lunev
On 04/13/2016 12:09 PM, Fam Zheng wrote: Signed-off-by: Fam Zheng --- qemu-io.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 288bba8..6bb6232 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -107,6 +107,7 @@ static void open_

Re: [Qemu-devel] [PATCH for-2.7 v2 1/3] vl: Use exit(1) when requested VGA interface is unavailable

2016-04-14 Thread Marcel Apfelbaum
On 04/14/2016 03:51 AM, Eduardo Habkost wrote: Instead of using exit(0), use exit(1) when an unavailable VGA interface is used in the command-line to indicate it's an error. Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost --- vl.c | 14 +++--- 1 file changed, 7 insertions(+),

Re: [Qemu-devel] [PATCH for-2.7 v2 2/3] vl: Table-based select_vgahw()

2016-04-14 Thread Marcel Apfelbaum
On 04/14/2016 03:51 AM, Eduardo Habkost wrote: Instead of implementing separate check functions for each vga interface type, add a table enumerating the possible VGA interfaces. Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Keep assert(vga_interface_type == VGA

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Apr 13, 2016 at 06:17:29PM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote: >> >> I have a hard time coming up with realistic unclean breakage. >> > >> > The issue is

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Apr 13, 2016 at 06:19:55PM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote: >> >> If we can protect them without >> >> complicating or breaking stuff, sure, why not.

Re: [Qemu-devel] [PATCH for-2.7 v2 3/3] vl: Replace *_vga_available() functions with class_names field

2016-04-14 Thread Marcel Apfelbaum
On 04/14/2016 03:51 AM, Eduardo Habkost wrote: Instead of requiring a separate function for each VGA interface, just enumerate the corresponding class names on struct VGAInterfaceInfo. Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost --- vl.c | 70 +++---

Re: [Qemu-devel] [PULL v2 8/9] input-linux: refine mouse detection

2016-04-14 Thread Ladi Prosek
On Wed, Apr 13, 2016 at 5:45 PM, Gerd Hoffmann wrote: > Read absolute and relative axis information, only classify > devices as mouse/tablet in case the x axis is present. I, too, had to come up with a heuristic to classify input devices in my guest driver and what I ended up with is different.

[Qemu-devel] [Bug 1569988] Re: [2.6] user network broken reaching foreign servers on Win64

2016-04-14 Thread Michael
Another thing: if I disable ipv6, ipv4 runs still in sort of a timeout before writing Network is unreachable (ENETUNREACH), while ipv6 says this without delay (which is ok/good) ** Description changed: Both on master and, starting with 2016-03-22 builds from http://qemu.weilnetz.de/w64/, us

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Cornelia Huck
On Thu, 14 Apr 2016 03:33:15 + "Gonglei (Arei)" wrote: > Hi, > > > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > > Sent: Thursday, April 14, 2016 12:30 AM > > To: Gonglei (Arei) > > Subject: Re: [RFC v2] virtio-crypto specification > > > > On Tue, 12 Apr 2016 09:03:33 + > > "G

Re: [Qemu-devel] [PULL v2 8/9] input-linux: refine mouse detection

2016-04-14 Thread Gerd Hoffmann
On Do, 2016-04-14 at 09:42 +0200, Ladi Prosek wrote: > On Wed, Apr 13, 2016 at 5:45 PM, Gerd Hoffmann wrote: > > Read absolute and relative axis information, only classify > > devices as mouse/tablet in case the x axis is present. > > I, too, had to come up with a heuristic to classify input devi

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-14 Thread Michael S. Tsirkin
On Thu, Apr 14, 2016 at 09:36:28AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Apr 13, 2016 at 06:17:29PM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote: > >> >> I h

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-14 Thread Michael S. Tsirkin
On Thu, Apr 14, 2016 at 09:39:07AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Apr 13, 2016 at 06:19:55PM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote: > >> >> If

Re: [Qemu-devel] [PATCH for-2.7 07/15] qemu-io: Add "-L" option for BDRV_O_NO_LOCK

2016-04-14 Thread Fam Zheng
On Thu, 04/14 10:06, Denis V. Lunev wrote: > On 04/13/2016 12:09 PM, Fam Zheng wrote: > >Signed-off-by: Fam Zheng > >--- > > qemu-io.c | 22 -- > > 1 file changed, 20 insertions(+), 2 deletions(-) > > > >diff --git a/qemu-io.c b/qemu-io.c > >index 288bba8..6bb6232 100644 > >--

Re: [Qemu-devel] [PATCH v2 for-2.6] block: convert iscsi target to a valid ID for -iscsi arg lookup

2016-04-14 Thread Daniel P. Berrange
On Wed, Apr 13, 2016 at 09:41:54PM -0400, John Ferlan wrote: > > > On 04/13/2016 12:17 PM, Daniel P. Berrange wrote: > > The iSCSI block driver has a very strange approach whereby it > > does not accept options directly as part of the -drive arg, > > but instead takes them indirectly from a -iscs

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-14 Thread Peter Xu
On Wed, Apr 13, 2016 at 10:42:26PM -0700, Jan Kiszka wrote: > On 2016-04-13 19:46, Peter Xu wrote: > > On Wed, Apr 13, 2016 at 07:44:54AM -0700, Jan Kiszka wrote: > > [...] > >>> One thing I am curious about: I see that in vtd spec 5.1.5.1: > >>> > >>> "RTE bits 10:8 is programmed to 000b (Fixed) t

[Qemu-devel] [PATCH] hw/virtio/balloon: Replace TARGET_PAGE_SIZE with BALLOON_PAGE_SIZE

2016-04-14 Thread Thomas Huth
The balloon code currently calls madvise() with TARGET_PAGE_SIZE as length parameter. Since the virtio-balloon protocol is always based on 4k pages, no matter what the host and guest are using as page size, this could cause problems: If TARGET_PAGE_SIZE is bigger than 4k, the madvise call also dest

Re: [Qemu-devel] [PULL v2 0/9] virtio-input; live migration support, various bugfixes

2016-04-14 Thread Peter Maydell
On 13 April 2016 at 16:44, Gerd Hoffmann wrote: > Hi, > > Here comes a virtio-input update, with a bugfix collection from Ladi > Prosek and live migration support. > > Changes in v2: > - add one mor fix from Ladi. > - add patch to fix the bigendian build failure. > - add patch to move const_l

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Gonglei (Arei)
Hi, > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > 1 Crypto Device > > > > > > The virtio crypto device is a virtual crypto device (ie. hardware > > > > > > crypto > > > > > accelerator card). The encryption and decryption requests of are > > > > > pla

[Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers

2016-04-14 Thread Artyom Tarasenko
Fix register offset calculation when regwptr is used. Signed-off-by: Artyom Tarasenko --- target-sparc/ldst_helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c index 2b0221c..a383074 100644 --- a/target

[Qemu-devel] [PATCH 2/2 for-2.6] target-sparc: fix Trap Based Address Register behavior for sparc64

2016-04-14 Thread Artyom Tarasenko
Accoding the chapter 7.6 Trap Processing of the SPARC Architecture Manual v9, the Trap Based Address Register is not modified as a trap is taken. This fix allows booting FreeBSD-10.3-RELEASE-sparc64. Signed-off-by: Artyom Tarasenko --- target-sparc/int64_helper.c | 5 ++--- 1 file changed, 2 in

[Qemu-devel] [patch] firmware: qemu_fw_cfg.c: potential unintialized variable

2016-04-14 Thread Dan Carpenter
It acpi_acquire_global_lock() return AE_NOT_CONFIGURED then "glk" isn't initialized, which, if you got very unlucky, could cause a bug. Signed-off-by: Dan Carpenter diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index d999fe3..0e20116 100644 --- a/drivers/firmware/q

[Qemu-devel] [Bug 1569988] Re: [2.6] user network broken reaching foreign servers on Win64

2016-04-14 Thread Stefan Weil
It looks like this commit caused the regression: $ git bisect bad c619644067f98098dcdbc951e2dda79e97560afa is the first bad commit commit c619644067f98098dcdbc951e2dda79e97560afa Author: Daniel P. Berrange Date: Mon Mar 7 11:19:18 2016 + osdep: fix socket_error() to work with Mingw64

Re: [Qemu-devel] post-copy is broken?

2016-04-14 Thread Dr. David Alan Gilbert
* Andrea Arcangeli (aarca...@redhat.com) wrote: > On Wed, Apr 13, 2016 at 01:50:53PM +0100, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > > > +if ( ((b + 1) % 255) == last_byte && !hit_edge) { > > > > Ahem, that should be 256. > > > > I

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Cornelia Huck
On Thu, 14 Apr 2016 09:26:36 + "Gonglei (Arei)" wrote: > > > Sorry, I don't find the git repository of virtio spec, except a svn > > > repository > > which > > > seems that it's not the latest version. :( > > > > > > https://tools.oasis-open.org/version-control/browse/wsvn/virtio/ > > > > >

[Qemu-devel] [PATCH for 2.6 1/1] nbd: fix assert() on qemu-nbd stop

2016-04-14 Thread Denis V. Lunev
From: Pavel Butsykin >From time to time qemu-nbd is crashing on the following assert: assert(state == TERMINATING); nbd_export_closed nbd_export_put main and the state at the moment of the crash is evaluated to TERMINATE. During shutdown process of the client the nbd_client_threa

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Michael S. Tsirkin
On Thu, Apr 14, 2016 at 09:26:36AM +, Gonglei (Arei) wrote: > Hi, > > > > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > > > 1 Crypto Device > > > > > > > The virtio crypto device is a virtual crypto device (ie. hardware > > > > > > > crypto > > > > > >

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Stefan Hajnoczi
On Thu, Apr 14, 2016 at 09:26:36AM +, Gonglei (Arei) wrote: > Hi, > > > > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > > > 1 Crypto Device > > > > > > > The virtio crypto device is a virtual crypto device (ie. hardware > > > > > > > crypto > > > > > >

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Gonglei (Arei)
> > > Hi, > > > > > > > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > > > > > 1 Crypto Device > > > > > > > > The virtio crypto device is a virtual crypto device (ie. > > > > > > > > hardware > crypto > > > > > > > accelerator card). The encryption an

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Gonglei (Arei)
> > > Hi, > > > > > > > > > > > > > > > > > Virtio-crypto device Spec > > > > > > > > > > > > > > > > 1 Crypto Device > > > > > > > > The virtio crypto device is a virtual crypto device (ie. > > > > > > > > hardware > crypto > > > > > > > accelerator card). The encryption an

Re: [Qemu-devel] [RFC v2] virtio-crypto specification

2016-04-14 Thread Cornelia Huck
On Thu, 14 Apr 2016 10:36:14 + "Gonglei (Arei)" wrote: > > The main spec text is in trunk/content.tex. You also need to modify > > trunk/conformance.tex to include all the "Driver Requirements" and > > "Device Requirements" sections for your device. > > > > Thank you for your reminder, Ste

Re: [Qemu-devel] [PATCH v4 7/9] target-mips: Add abs2008 flavor of .

2016-04-14 Thread Leon Alrae
On 12/04/16 13:58, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Updated handling of instuctions .. Note that legacy > (pre-abs2008) ABS and NEG instructions are arithmetic (any NaN operand > signals invalid operation), while abs2008 ones are non-arithmetic, always > changing the sig

[Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum speed for block jobs

2016-04-14 Thread Sascha Silbe
Dear developers, Sascha Silbe writes: > The current rate limit implementation for block jobs is ineffective > below a certain minimum rate. It will permit writes at least once per > time slice. The resulting minimum write speed (assuming source and > sink are fast enough in the first place) is h

Re: [Qemu-devel] [PATCH v2 for-2.6] block: convert iscsi target to a valid ID for -iscsi arg lookup

2016-04-14 Thread John Ferlan
[...] >> >> Figured I'd chime in since I tripped across this today... >> >> I think the one thing that concerns me about this '_' approach is we'd >> be "stuck" with it. Eventually if 'initiator-name' is added to the >> -drive command (as well as being able to parse the 'user=' and >> 'password-sec

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Apr 14, 2016 at 09:36:28AM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Wed, Apr 13, 2016 at 06:17:29PM +0200, Markus Armbruster wrote: >> >> "Michael S. Tsirkin" writes: >> >> >> >> > On Wed, Apr 13, 2016 at 10:59:35AM +020

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Apr 14, 2016 at 09:39:07AM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Wed, Apr 13, 2016 at 06:19:55PM +0200, Markus Armbruster wrote: >> >> "Michael S. Tsirkin" writes: >> >> >> >> > On Wed, Apr 13, 2016 at 10:59:35AM +020

[Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"

2016-04-14 Thread Sascha Silbe
Running an iotests-based Python test directly might appear to work, but may fail in subtle ways and is insecure: - It creates files with predictable file names in a world-writable location (/var/tmp). - Tests expect the environment to be set up by check. E.g. 041 and 055 may take the wrong co

Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak

2016-04-14 Thread Igor Mammedov
On Wed, 13 Apr 2016 18:57:40 +0200 marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov > --- > backends/hostmem-file.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/backends/hostmem-file.c b/backends

Re: [Qemu-devel] [PATCH for-2.6 0/4] qemu-iotests: don't use /tmp

2016-04-14 Thread Sascha Silbe
Dear Max, Max Reitz writes: [...] > Thanks Sascha, I applied the series to my block tree: Thanks! I've just sent out the last patch from my local queue (fixing =/var/tmp= usage). Barring further discoveries during testing, I'm done for 2.6 now. Sascha -- Softwareentwicklung Sascha Silbe, Nied

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-14 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > That would mean a regression compared to what we have today. Currently, > the ballooning is working OK for 64k guests on a 64k ppc host - rather > by chance than on purpose, but it's working. The guest is always sending > all the 4k fragments of a 64k page

[Qemu-devel] [Bug 1569988] Re: [2.6] user network broken reaching foreign servers on Win64

2016-04-14 Thread Stefan Weil
Here is a patch which fixes the problem. diff --git a/slirp/tcp_input.c b/slirp/tcp_input.c index 2027a75..696867f 100644 --- a/slirp/tcp_input.c +++ b/slirp/tcp_input.c @@ -587,7 +587,7 @@ findso: if ((tcp_fconnect(so, so->so_ffamily) == -1) && #if defined(_WIN32) - sock

[Qemu-devel] [Bug 1569988] Re: [2.6] user network broken reaching foreign servers on Win64

2016-04-14 Thread Stefan Weil
** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1569988 Title:

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-14 Thread Michael S. Tsirkin
On Thu, Apr 14, 2016 at 01:29:20PM +0200, Markus Armbruster wrote: > What good is that going to do? Enforce a sane policy. It's too easy to misconfigure qemu as it is. We don't need more knobs that can break guests. -- MST

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-14 Thread Thomas Huth
On 14.04.2016 13:47, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: > >> That would mean a regression compared to what we have today. Currently, >> the ballooning is working OK for 64k guests on a 64k ppc host - rather >> by chance than on purpose, but it's working. The gu

Re: [Qemu-devel] [PING][PATCH] Added the -m flag feature to stellaris boards

2016-04-14 Thread Peter Maydell
On 14 April 2016 at 13:21, Aurelio Remonda wrote: > Hello Peter, have you had a chance to look at this? I made review comments in my previous mail on this patch, which means it's now back to you to update the patch and resend. thanks -- PMM

Re: [Qemu-devel] post-copy is broken?

2016-04-14 Thread Dr. David Alan Gilbert
* Andrea Arcangeli (aarca...@redhat.com) wrote: > The next suspect is the massive THP refcounting change that went > upstream recently: > As further debug hint, can you try to disable THP and see if that > makes the problem go away? Yep, this seems to be the problem (cc'ing in Kirill). 122afea9

[Qemu-devel] IRQ number used by virtio-net-device in vexpress-a15

2016-04-14 Thread Inti Gonzalez-Herrera
Hello, I am writing a simple OS that must access the network. The platform I'm using can be seen below: qemu-system-arm -redir tcp:::80 -m 256M -smp 1 -M vexpress-a15 -cpu cortex-a15 -netdev user,id=net0 -device virtio-net-device,netdev=net0 -kernel ~/work/src/simple-arm-os/bin/kernel.b

Re: [Qemu-devel] IRQ number used by virtio-net-device in vexpress-a15

2016-04-14 Thread Peter Maydell
On 14 April 2016 at 13:58, Inti Gonzalez-Herrera wrote: > I have some problems using virtio-net-device. In particular, th system is > not receiving an interrupt when it transmits a package. However, I can see > how the buffer descriptors are moved to the used ring. I was thinking that > maybe the

Re: [Qemu-devel] [PATCH for 2.6 1/1] nbd: fix assert() on qemu-nbd stop

2016-04-14 Thread Paolo Bonzini
On 14/04/2016 12:20, Denis V. Lunev wrote: > From: Pavel Butsykin > > From time to time qemu-nbd is crashing on the following assert: > assert(state == TERMINATING); > nbd_export_closed > nbd_export_put > main > and the state at the moment of the crash is evaluated to TERMINATE.

Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak

2016-04-14 Thread Paolo Bonzini
On 14/04/2016 13:34, Igor Mammedov wrote: > On Wed, 13 Apr 2016 18:57:40 +0200 > marcandre.lur...@redhat.com wrote: > >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau > Reviewed-by: Igor Mammedov Igor, feel free to send a pull request or even to add yourself as hostmem maint

Re: [Qemu-devel] [PING][PATCH] Added the -m flag feature to stellaris boards

2016-04-14 Thread Aurelio Remonda
Ok, but I explained my decisions on a the mail dated 03/28, responding on your mail dated 03/23 maybe you missed that mail. Thanks!

Re: [Qemu-devel] IRQ number used by virtio-net-device in vexpress-a15

2016-04-14 Thread Inti Gonzalez-Herrera
On 14/04/16 15:19, Peter Maydell wrote: On 14 April 2016 at 13:58, Inti Gonzalez-Herrera wrote: I have some problems using virtio-net-device. In particular, th system is not receiving an interrupt when it transmits a package. However, I can see how the buffer descriptors are moved to the used

Re: [Qemu-devel] [PING][PATCH] Added the -m flag feature to stellaris boards

2016-04-14 Thread Peter Maydell
On 28 March 2016 at 19:15, Aurelio Remonda wrote: >>> #define NUM_IRQ_LINES 64 >>> +#define LM3S811EVB_DEFAULT_DC0 0x1f00 /* Default value for dc0 >>> sram_size half */ >>> +#define LM3S6965EVB_DEFAULT_DC0 0xff00 /* Default value for dc0 >>> sram_size half */ >> >> These don't seem to b

Re: [Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers

2016-04-14 Thread Mark Cave-Ayland
On 14/04/16 10:29, Artyom Tarasenko wrote: > Fix register offset calculation when regwptr is used. > > Signed-off-by: Artyom Tarasenko > --- > target-sparc/ldst_helper.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/target-sparc/ldst_helper.c b/target-sp

Re: [Qemu-devel] [PATCH 2/2 for-2.6] target-sparc: fix Trap Based Address Register behavior for sparc64

2016-04-14 Thread Mark Cave-Ayland
On 14/04/16 10:29, Artyom Tarasenko wrote: > Accoding the chapter 7.6 Trap Processing of the SPARC Architecture Manual v9, > the Trap Based Address Register is not modified as a trap is taken. > > This fix allows booting FreeBSD-10.3-RELEASE-sparc64. > > Signed-off-by: Artyom Tarasenko > --- >

[Qemu-devel] [PULL 6/6] hw/virtio/balloon: Replace TARGET_PAGE_SIZE with BALLOON_PAGE_SIZE

2016-04-14 Thread Michael S. Tsirkin
From: Thomas Huth The balloon code currently calls madvise() with TARGET_PAGE_SIZE as length parameter. Since the virtio-balloon protocol is always based on 4k pages, no matter what the host and guest are using as page size, this could cause problems: If TARGET_PAGE_SIZE is bigger than 4k, the ma

Re: [Qemu-devel] [PATCH for 2.6 1/1] nbd: fix assert() on qemu-nbd stop

2016-04-14 Thread Denis V. Lunev
On 04/14/2016 04:23 PM, Paolo Bonzini wrote: On 14/04/2016 12:20, Denis V. Lunev wrote: From: Pavel Butsykin From time to time qemu-nbd is crashing on the following assert: assert(state == TERMINATING); nbd_export_closed nbd_export_put main and the state at the moment of

Re: [Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers

2016-04-14 Thread Artyom Tarasenko
On Thu, Apr 14, 2016 at 3:42 PM, Mark Cave-Ayland wrote: > On 14/04/16 10:29, Artyom Tarasenko wrote: > >> Fix register offset calculation when regwptr is used. >> >> Signed-off-by: Artyom Tarasenko >> --- >> target-sparc/ldst_helper.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 del

[Qemu-devel] [PULL 1/6] specs/vhost-user: improve VHOST_SET_VRING_NUM documentation

2016-04-14 Thread Michael S. Tsirkin
From: Marc-André Lureau "number of vrings" doesn't help me understand the purpose of this message. My understanding is that it is rather the size of the queue (in modern terms). Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/specs/

[Qemu-devel] [PULL 4/6] tpm: acpi: remove IRQ from TPM's CRS to make Windows not see conflict

2016-04-14 Thread Michael S. Tsirkin
From: Igor Mammedov IRQ 5 used by TPM conflicts with PNP0C0F IRQs, as result Windows fails driver initialization with reason 'device cannot find enough free resources' But if TPM._CRS.IRQ entry is commented out, Windows seems to initialize driver without errors as it doesn't notice possible con

[Qemu-devel] [PULL 2/6] specs/vhost-user: spelling fix

2016-04-14 Thread Michael S. Tsirkin
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/specs/vhost-user.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt index 4778241..777

Re: [Qemu-devel] [PATCH for 2.6 1/1] nbd: fix assert() on qemu-nbd stop

2016-04-14 Thread Paolo Bonzini
On 14/04/2016 15:40, Denis V. Lunev wrote: > On 04/14/2016 04:23 PM, Paolo Bonzini wrote: >> >> On 14/04/2016 12:20, Denis V. Lunev wrote: >>> From: Pavel Butsykin >>> >>> From time to time qemu-nbd is crashing on the following assert: >>> assert(state == TERMINATING); >>> nbd_export_

[Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-14 Thread Alexander Graf
We can currently buffer up to 16 events in our event queue for input devices. While it sounds like 16 events backlog for everyone should be enough, our automated testing tools (OpenQA) manage to easily type faster than our guests can handle. So we run into queue overflows and start to drop input c

Re: [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate

2016-04-14 Thread Sergey Fedorov
On 29/03/16 13:37, Paolo Bonzini wrote: Your observation that tb->pc==-1 is not necessarily safe still holds of >> > course. Probably the best thing is an inline that can do one of: >> > >> > 1) set cs_base to an invalid value (anything nonzero is enough except >> > on >>

Re: [Qemu-devel] [PULL 0/6] tpm, vhost, virtio: fixes for 2.6

2016-04-14 Thread Peter Maydell
On 14 April 2016 at 14:47, Michael S. Tsirkin wrote: > The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-04-12 17:47:15 +0100) > > are available in the git repository at: > > git

Re: [Qemu-devel] [PING][PATCH] Added the -m flag feature to stellaris boards

2016-04-14 Thread Aurelio Remonda
Hello Peter, have you had a chance to look at this? On Mon, Mar 28, 2016 at 3:15 PM, Aurelio Remonda wrote: >>> #define NUM_IRQ_LINES 64 >>> +#define LM3S811EVB_DEFAULT_DC0 0x1f00 /* Default value for dc0 >>> sram_size half */ >>> +#define LM3S6965EVB_DEFAULT_DC0 0xff00 /* Default value

[Qemu-devel] [PULL 0/6] tpm, vhost, virtio: fixes for 2.6

2016-04-14 Thread Michael S. Tsirkin
The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-04-12 17:47:15 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

[Qemu-devel] [PULL 3/6] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS

2016-04-14 Thread Michael S. Tsirkin
From: Igor Mammedov Windows will fail initialize TMP driver with the reason: 'device cannot find enough free resources' That happens because parent BUS doesn't describe MMIO resources used by TPM child device. Fix it by describing it in top-most parent bus scope PCI0. It was 'regressed' by com

[Qemu-devel] [PULL 5/6] tpm: Fix write to file descriptor function

2016-04-14 Thread Michael S. Tsirkin
From: Stefan Berger Fix a bug introduced in commit 46f296c while moving send_all to the tpm_passthrough code. Fix the name of the variable used in the loop. Signed-off-by: Stefan Berger Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/tpm/tpm_passthrough.c | 2 +- 1 file

Re: [Qemu-devel] [PATCH 2/2 for-2.6] target-sparc: fix Trap Based Address Register behavior for sparc64

2016-04-14 Thread Artyom Tarasenko
On Thu, Apr 14, 2016 at 3:43 PM, Mark Cave-Ayland wrote: > On 14/04/16 10:29, Artyom Tarasenko wrote: > >> Accoding the chapter 7.6 Trap Processing of the SPARC Architecture Manual v9, >> the Trap Based Address Register is not modified as a trap is taken. >> >> This fix allows booting FreeBSD-10.3

Re: [Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers

2016-04-14 Thread Mark Cave-Ayland
On 14/04/16 15:04, Artyom Tarasenko wrote: > Can you please show the output of your checkpatch.pl report? I get: > > $ scripts/checkpatch.pl > 0001-target-sparc-fix-Nucleus-quad-LDD-128-bit-access-for.patch > total: 0 errors, 0 warnings, 25 lines checked > 0001-target-sparc-fix-Nucleus-quad-LD

Re: [Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers

2016-04-14 Thread Artyom Tarasenko
On Thu, Apr 14, 2016 at 4:20 PM, Mark Cave-Ayland wrote: > On 14/04/16 15:04, Artyom Tarasenko wrote: > >> Can you please show the output of your checkpatch.pl report? I get: >> >> $ scripts/checkpatch.pl >> 0001-target-sparc-fix-Nucleus-quad-LDD-128-bit-access-for.patch >> total: 0 errors, 0 w

Re: [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate

2016-04-14 Thread Paolo Bonzini
On 14/04/2016 16:45, Sergey Fedorov wrote: > So what would you suggest to use for x86? I can't think of something > that looks like a really compelling combination when I look at > cpu_get_tb_cpu_state() in target-i386/cpu.h. On x86 I think we should define HF_INVALID_TB to an invalid flag combi

[Qemu-devel] [PATCH 2/2] ppc: Fix the bad exception NIP value and the range check in LSWX

2016-04-14 Thread Thomas Huth
The range checks in the LSWX instruction are completely insufficient: They do not take the wrap-around case into account, and the check "reg < rx" should be "reg <= rx" instead. Fix it by using the new lsw_reg_in_range() helper function that is already used for LSWI, too. Then there is a second pr

[Qemu-devel] [PATCH 0/2] ppc: Fixes for LSWX and LSWI instructions

2016-04-14 Thread Thomas Huth
These two patches fix the bad range checks in the LSWI and LSWX instructions. To see the change in behavior for the lswx instruction, you can use the "emulator" test from the kvm-unit-tests suite - code can be found here: https://git.kernel.org/cgit/virt/kvm/kvm-unit-tests.git/tree/powerpc/emulat

[Qemu-devel] [PATCH 1/2] ppc: Fix the range check in the LSWI instruction

2016-04-14 Thread Thomas Huth
There are two issues: First, the number of registers that are used has to be calculated with "(nb + 3) / 4" (i.e. round always up, not down). Second, the "start <= ra && (start + nr - 32) > ra" condition for the wrap-around case is wrong: It has to be tested with "||" instead of "&&". Since we can

Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-14 Thread Gerd Hoffmann
On Do, 2016-04-14 at 16:25 +0200, Alexander Graf wrote: > We can currently buffer up to 16 events in our event queue for input > devices. While it sounds like 16 events backlog for everyone should > be enough, our automated testing tools (OpenQA) manage to easily > type faster than our guests can h

Re: [Qemu-devel] [PATCH v14 08/19] qapi: Document visitor interfaces, add assertions

2016-04-14 Thread Markus Armbruster
Eric Blake writes: > The visitor interface for mapping between QObject/QemuOpts/string > and QAPI is scandalously under-documented, making changes to visitor > core, individual visitors, and users of visitors difficult to > coordinate. Among other questions: when is it safe to pass NULL, > vs. w

Re: [Qemu-devel] [PATCH for-2.6] nbd: Don't kill server on client that doesn't request TLS

2016-04-14 Thread Eric Blake
[adding qemu-block in cc, since Paolo can't send pull request] On 04/07/2016 02:29 PM, Eric Blake wrote: > Upstream NBD is documenting that servers MAY choose to operate > in a conditional mode, where it is up to the client whether to > use TLS. For qemu's case, we want to always be in FORCEDTLS

Re: [Qemu-devel] [PATCH for-2.6] nbd: Don't fail handshake on NBD_OPT_LIST descriptions

2016-04-14 Thread Eric Blake
[adding qemu-block in cc, since Paolo can't send pull request] On 04/07/2016 07:09 PM, Eric Blake wrote: > The NBD Protocol states that NBD_REP_SERVER may set > 'length > sizeof(namelen) + namelen'; in which case the rest > of the packet is a UTF-8 description of the export. While we > don't know

Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-14 Thread Alexander Graf
On 04/14/2016 05:17 PM, Gerd Hoffmann wrote: On Do, 2016-04-14 at 16:25 +0200, Alexander Graf wrote: We can currently buffer up to 16 events in our event queue for input devices. While it sounds like 16 events backlog for everyone should be enough, our automated testing tools (OpenQA) manage to

Re: [Qemu-devel] efi var store migration assert (bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed.)

2016-04-14 Thread Peter Maydell
On 4 April 2016 at 11:40, Paolo Bonzini wrote: > > > On 01/04/2016 19:58, Dr. David Alan Gilbert wrote: >> In the continuing journeys of trying to migrate a q35 guest with ovmf, >> I've just hit this assert: >> >> qemu-system-x86_64: /root/git/qemu/block/io.c:1297: bdrv_co_do_pwritev: >> Assertio

Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit

2016-04-14 Thread Leon Alrae
On 12/04/2016 13:58, Aleksandar Markovic wrote: > @@ -3200,11 +3200,17 @@ FLOAT_RINT(rint_d, 64) > #define FLOAT_CLASS_POSITIVE_ZERO 0x200 > > #define FLOAT_CLASS(name, bits) \ > -uint ## bits ## _t helper_float_ ## name (uint ## bits ## _t arg)\ >

Re: [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate

2016-04-14 Thread Sergey Fedorov
On 14/04/16 18:13, Paolo Bonzini wrote: > This is very similar to the current code. From 10,000 feet, because > tb_find_fast calls tb_find_slow, this could indeed work, but I'm a bit > concerned about how to order the removal of the jump lists. The usage > of "tcg_ctx.tb_ctx.tb_invalidated_flag =

Re: [Qemu-devel] [PATCH for-2.6] nbd: Don't kill server on client that doesn't request TLS

2016-04-14 Thread Alex Bligh
On 14 Apr 2016, at 16:25, Eric Blake wrote: > [adding qemu-block in cc, since Paolo can't send pull request] > > On 04/07/2016 02:29 PM, Eric Blake wrote: >> Upstream NBD is documenting that servers MAY choose to operate >> in a conditional mode, where it is up to the client whether to >> use T

Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak

2016-04-14 Thread Igor Mammedov
On Thu, 14 Apr 2016 15:24:10 +0200 Paolo Bonzini wrote: > On 14/04/2016 13:34, Igor Mammedov wrote: > > On Wed, 13 Apr 2016 18:57:40 +0200 > > marcandre.lur...@redhat.com wrote: > > > >> From: Marc-André Lureau > >> > >> Signed-off-by: Marc-André Lureau > > Reviewed-by: Igor Mammedov >

Re: [Qemu-devel] [PATCH for-2.6] nbd: Don't fail handshake on NBD_OPT_LIST descriptions

2016-04-14 Thread Alex Bligh
On 14 Apr 2016, at 16:26, Eric Blake wrote: > [adding qemu-block in cc, since Paolo can't send pull request] > > On 04/07/2016 07:09 PM, Eric Blake wrote: >> The NBD Protocol states that NBD_REP_SERVER may set >> 'length > sizeof(namelen) + namelen'; in which case the rest >> of the packet is a

Re: [Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers

2016-04-14 Thread Mark Cave-Ayland
On 14/04/16 15:49, Artyom Tarasenko wrote: >> Possibly the DOS line endings are being added by a mail program? > > I use git send-email (which uses msmtp). Used to work fine. > > Clicking on "download mbox" on > https://patchwork.ozlabs.org/patch/610402/ and running checkpatch.pl > reveals no er

Re: [Qemu-devel] [PATCH v14 09/19] tests: Add check-qnull

2016-04-14 Thread Markus Armbruster
Eric Blake writes: > Add a new test, for checking reference counting of qnull(). As > part of the new file, move a previous reference counting change > added in commit a861564 into a more logical place. into or to? Those darn prepositions... > Signed-off-by: Eric Blake > > --- > v14: no chang

Re: [Qemu-devel] [PATCH] hid: Extend the event queue size to 1024

2016-04-14 Thread Gerd Hoffmann
On Do, 2016-04-14 at 17:29 +0200, Alexander Graf wrote: > On 04/14/2016 05:17 PM, Gerd Hoffmann wrote: > > On Do, 2016-04-14 at 16:25 +0200, Alexander Graf wrote: > >> We can currently buffer up to 16 events in our event queue for input > >> devices. While it sounds like 16 events backlog for every

Re: [Qemu-devel] post-copy is broken?

2016-04-14 Thread Andrea Arcangeli
Adding linux-mm too, On Thu, Apr 14, 2016 at 01:34:41PM +0100, Dr. David Alan Gilbert wrote: > * Andrea Arcangeli (aarca...@redhat.com) wrote: > > > The next suspect is the massive THP refcounting change that went > > upstream recently: > > > As further debug hint, can you try to disable THP and

[Qemu-devel] [Bug 1570134] Re: While committing snapshot qemu crashes with SIGABRT

2016-04-14 Thread Matthew Schumacher
Sure, I did the same test and still got a SIGABRT, but the debug looks a little different: Backtrace: #0 0x7f8f0d46a3f8 in raise () at /lib64/libc.so.6 #1 0x7f8f0d46bffa in abort () at /lib64/libc.so.6 #2 0x7f8f0d462c17 in __assert_fail_base () at /lib64/libc.so.6 #3 0x7f8f0d4

Re: [Qemu-devel] [PATCH v14 10/19] qapi: Add visit_type_null() visitor

2016-04-14 Thread Markus Armbruster
Eric Blake writes: > Right now, qmp-output-visitor happens to produce a QNull result > if nothing is actually visited between the creation of the visitor > and the request for the resulting QObject. A stronger protocol > would require that a QMP output visit MUST visit something. But > to still

Re: [Qemu-devel] [PATCH] hostmem-file: plug a small leak

2016-04-14 Thread Paolo Bonzini
On 14/04/2016 17:44, Igor Mammedov wrote: > On Thu, 14 Apr 2016 15:24:10 +0200 > Paolo Bonzini wrote: > >> On 14/04/2016 13:34, Igor Mammedov wrote: >>> On Wed, 13 Apr 2016 18:57:40 +0200 >>> marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau Signed-off-by: Marc-A

Re: [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate

2016-04-14 Thread Paolo Bonzini
On 14/04/2016 17:36, Sergey Fedorov wrote: > IIUC we always modify tb_jmp_cache/tb_phys_hash under tb_lock. We're > just gonna do tb_jmp_cache lookup outside of tb_lock. I think write > memory barrier in tb_phys_invalidate() paired with read memory memory > barrier in tb_find_fast()/tb_find_slow(

Re: [Qemu-devel] [PATCH v14 09/19] tests: Add check-qnull

2016-04-14 Thread Markus Armbruster
There's one unusual bit: the other check-q*.c leave the visitor stuff to the test-*-visitor.c, but this one doesn't. Hmm.

[Qemu-devel] [PATCH for 2.6] wxx: Fix broken TCP networking (regression)

2016-04-14 Thread Stefan Weil
It is broken since commit c619644067f98098dcdbc951e2dda79e97560afa. Reported-by: Michael Fritscher Signed-off-by: Stefan Weil --- Networking with QEMU for Windows is currently not usable, see bug report https://bugs.launchpad.net/qemu/+bug/1569988. With this patch, it seems to work again at le

Re: [Qemu-devel] [PATCH for 2.6] wxx: Fix broken TCP networking (regression)

2016-04-14 Thread Michael Fritscher
> It is broken since commit c619644067f98098dcdbc951e2dda79e97560afa. > > Reported-by: Michael Fritscher > Signed-off-by: Stefan Weil > --- > > Networking with QEMU for Windows is currently not usable, > see bug report https://bugs.launchpad.net/qemu/+bug/1569988. > > With this patch, it seems to

Re: [Qemu-devel] [PATCH for 2.6] wxx: Fix broken TCP networking (regression)

2016-04-14 Thread Samuel Thibault
Hello, Stefan Weil, on Thu 14 Apr 2016 19:46:17 +0200, wrote: > Michael Fritscher reported that it is still slow, so > more fixes might be needed. Michael, what do you mean by "slow", the bandwidth, or the time to connect? Does it help if you disable ipv6? Samuel

Re: [Qemu-devel] [PATCH] fix missing event_notifier_init_fd() function on Mac OS X

2016-04-14 Thread Programmingkid
On Apr 8, 2016, at 7:25 AM, Markus Armbruster wrote: > [Wasn't delivered correctly by eggs.gnu.org, resending] > > Paolo Bonzini writes: > >> On 30/03/2016 18:35, Programmingkid wrote: >>> Remove macro that prevents event_notifier_init_fd() function from being >>> compiled on Mac OS X. >>> >

Re: [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate

2016-04-14 Thread Sergey Fedorov
On 14/04/16 18:13, Paolo Bonzini wrote: > This is very similar to the current code. From 10,000 feet, because > tb_find_fast calls tb_find_slow, this could indeed work, but I'm a bit > concerned about how to order the removal of the jump lists. As long as we always link/unlink TBs under tb_lock t

  1   2   >