Re: [Qemu-devel] [PATCH v2] exec.c: Ensure right alignment also for file backed ram

2016-04-13 Thread Dominik Dingel
On Tue, 12 Apr 2016 23:45:18 +0200 Paolo Bonzini wrote: > > > On 07/04/2016 23:31, Dominik Dingel wrote: > > diff --git a/exec.c b/exec.c > > index c4f9036..1ae98e4 100644 > > --- a/exec.c > > +++ b/exec.c > > @@ -1241,6 +1241,7 @@ static void *file_ram_alloc(RAMBlock *block, > > void *are

Re: [Qemu-devel] [PATCH v2 13/13] intel_iommu: Add support for PCI MSI remap

2016-04-13 Thread Peter Xu
Hi, Michael, On Mon, Apr 11, 2016 at 03:41:29PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 11, 2016 at 05:19:23PM +0800, Peter Xu wrote: > > This patch enables interrupt remapping for PCI devices. > > > > To play the trick, one memory region "iommu_ir" is added as child region > > of the orig

Re: [Qemu-devel] about correctness of IDE emulation

2016-04-13 Thread Huaicheng Li (coperd)
> On Mar 14, 2016, at 10:09 PM, Huaicheng Li wrote: > > >> On Mar 13, 2016, at 8:42 PM, Fam Zheng wrote: >> >> On Sun, 03/13 14:37, Huaicheng Li (coperd) wrote: >>> Hi all, >>> >>> What I’m confused about is that: >>> >>> If one I/O is too large and may need several rounds (say 2) of DMA

Re: [Qemu-devel] [PATCH v2 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-13 Thread Peter Xu
On Mon, Apr 11, 2016 at 03:32:18PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 11, 2016 at 05:19:10PM +0800, Peter Xu wrote: > > v2 changes: > > - patch 1 > > - rename "int_remap" to "intr" in several places [Marcel] > > - remove "Intel" specific words in desc or commit message, prepare > >

Re: [Qemu-devel] [PATCH v2 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-13 Thread Peter Xu
On Mon, Apr 11, 2016 at 04:19:01PM -0600, Alex Williamson wrote: > On Mon, 11 Apr 2016 17:19:10 +0800 > Peter Xu wrote: > > > v2 changes: > > - patch 1 > > - rename "int_remap" to "intr" in several places [Marcel] > > - remove "Intel" specific words in desc or commit message, prepare > >

Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void

2016-04-13 Thread Paolo Bonzini
On 13/04/2016 08:33, Markus Armbruster wrote: > * Look for functions that are named *_exit or *_exitfn in hw/ and that > return int. They should all return zero. Make them return void, and > remove the checks for the callers. ... and change the exit method to "void fn(void)" > * Onc

[Qemu-devel] Qemu-kvm live migration modify

2016-04-13 Thread Gilar Dwitresna
hi, I have done make implementation of qemu-kvm instalation for live migration on ubuntu with sharing storage (NFS) configuration. the qemu-kvm has been succeed for live migration with default algorithm (guest without service), but if the guest run the service (streaming server), the dirty pages ra

Re: [Qemu-devel] post-copy is broken?

2016-04-13 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > > > I used the latest qemu code (commit id: 4e71220387e88a22) and kernel > > > (v4.5) to test the post-copy, and find the guest get crashed after > > > live migration, no matter I did a local live migration or live > > > migration between two hosts. I

[Qemu-devel] [PATCH v13 0/3] qapi: child add/delete support

2016-04-13 Thread Changlong Xie
ChangLog: v13: 1. Rebase to the newest codes 2. Address commets from Betro and Max p1. Add R-B, fix incorrect syntax p2. Add missing "qemu/cutils.h" since 2.6, and rewrite quorum_add/del_child p3. Remove unnecessary "id", add "since 2.7" v11~v12: 1. Address comments from Max p1. Add R-B p2. Add R-B

[Qemu-devel] [PATCH v13 1/3] Add new block driver interface to add/delete a BDS's child

2016-04-13 Thread Changlong Xie
From: Wen Congyang In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c

[Qemu-devel] [PATCH v13 3/3] qmp: add monitor command to add/remove a child

2016-04-13 Thread Changlong Xie
From: Wen Congyang The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Sig

[Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-13 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8 +++--- block/quorum.c| 78 +-- include/block/block.h | 4 +++ 3 files chang

Re: [Qemu-devel] work needed on QEMU 2.6 ChangeLog

2016-04-13 Thread Daniel P. Berrange
On Tue, Apr 12, 2016 at 08:46:56PM +0200, Paolo Bonzini wrote: > Hi all, if you are CCed there is a feature you wrote or maintain that > needs further work in the ChangeLog > (http://wiki.qemu.org/ChangeLog/2.6). In particular: > > Andrew/Peter: > * New partial Raspberry Pi 1 and 2 emulation with

Re: [Qemu-devel] work needed on QEMU 2.6 ChangeLog

2016-04-13 Thread Jason Wang
On 04/13/2016 02:46 AM, Paolo Bonzini wrote: > Hi all, if you are CCed there is a feature you wrote or maintain that > needs further work in the ChangeLog > (http://wiki.qemu.org/ChangeLog/2.6). In particular: > > Andrew/Peter: > * New partial Raspberry Pi 1 and 2 emulation with "raspi" and "ras

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-13 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Apr 11, 2016 at 01:04:14PM +0200, Markus Armbruster wrote: >> My best guess >> is you're referring to the part where I challenge mapping >> /unsupported/root/FOO to FOO. I find that baroque. I can accept >> baroque when I see a reason. That's why I asked

[Qemu-devel] [PATCH for-2.7 00/15] block: Lock images when opening

2016-04-13 Thread Fam Zheng
Too many troubles have been caused by two processes writing to the same image unexpectedly. This series introduces automatical image locking into QEMU to avoid such tragedy. With this, the user won't be able to open the image from two processes (e.g. using qemu-img when the image is attached to the

[Qemu-devel] [PATCH for-2.7 01/15] block: Add BDRV_O_NO_LOCK

2016-04-13 Thread Fam Zheng
Later the block layer will automatically lock the images to avoid unexpected concurrent accesses to the same image, which will easily corrupt the metadata or user data, unless in some very special cases, like migration. The exceptional cases like shared storage migration and testing should set BDR

[Qemu-devel] [PATCH for-2.7 07/15] qemu-io: Add "-L" option for BDRV_O_NO_LOCK

2016-04-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-io.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 288bba8..6bb6232 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -107,6 +107,7 @@ static void open_help(void) " -r, -- open file read-only\n"

[Qemu-devel] [PATCH for-2.7 05/15] raw-posix: Implement .bdrv_lockf

2016-04-13 Thread Fam Zheng
Because virtlockd in libvirt already uses the fcntl lock on the image file, we have to workaround this by locking a digest-mapped temporary file. Signed-off-by: Fam Zheng --- block/raw-posix.c | 97 +++ 1 file changed, 97 insertions(+) diff --

[Qemu-devel] [PATCH for-2.7 02/15] qapi: Add lock-image in blockdev-add options

2016-04-13 Thread Fam Zheng
To allow overriding the default locking behavior when opening the image. Signed-off-by: Fam Zheng --- qapi/block-core.json | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1d09079..2913f3e 100644 --- a/qapi/block-core.json

[Qemu-devel] [PATCH for-2.7 06/15] gluster: Implement .bdrv_lockf

2016-04-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/gluster.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/block/gluster.c b/block/gluster.c index 51e154c..e76ec87 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -672,6 +672,36 @@ static void qemu_gluster_close(Bloc

[Qemu-devel] [PATCH for-2.7 10/15] qemu-iotests: Fix lock-image for shared disk in test case 091

2016-04-13 Thread Fam Zheng
Because the source and the destination QEMU instances both open the image, we have to disable the lock. Signed-off-by: Fam Zheng --- tests/qemu-iotests/091 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091 index 32bbd56..2a3c9

[Qemu-devel] [PATCH for-2.7 03/15] blockdev: Add and parse "lock-image" option for block devices

2016-04-13 Thread Fam Zheng
Honor the locking switch specified in CLI or QMP, and set the open flags for the image accordingly. Signed-off-by: Fam Zheng --- blockdev.c | 8 1 file changed, 8 insertions(+) diff --git a/blockdev.c b/blockdev.c index f1f520a..93bd43e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -382,

[Qemu-devel] [PATCH for-2.7 12/15] qemu-iotests: 051: Disable image lock in the command line

2016-04-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/051| 2 +- tests/qemu-iotests/051.out| 10 +- tests/qemu-iotests/051.pc.out | 10 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index 88b3d91..2fee7e8

[Qemu-devel] [PATCH for-2.7 15/15] block: Turn on image locking by default

2016-04-13 Thread Fam Zheng
Now that test cases are covered, we can turn it on. Signed-off-by: Fam Zheng --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 93bd43e..87d22c3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -383,7 +383,7 @@ static void extract_common_b

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 00/10] ppc: preparing pnv landing

2016-04-13 Thread Cédric Le Goater
On 03/22/2016 12:14 AM, David Gibson wrote: > On Mon, Mar 21, 2016 at 01:52:30PM +0100, Cédric Le Goater wrote: >> Hello, >> >> This is a first mini-serie of patches adding support for new ppc SPRs. >> They were taken from Ben's larger patchset adding the ppc powernv >> platform and they should alr

[Qemu-devel] [PATCH for-2.7 04/15] block: Introduce image file locking interface

2016-04-13 Thread Fam Zheng
Block drivers can implement this new operation .bdrv_lockf to actually lock the image in the protocol specific way. Signed-off-by: Fam Zheng --- block.c | 25 + include/block/block.h | 8 include/block/block_int.h | 5 + 3 files change

[Qemu-devel] [PATCH for-2.7 14/15] ide-test: Specify "lock-image=off" in command lines

2016-04-13 Thread Fam Zheng
If a failure in a previous test case doesn't clean up the running qemu process (it happens), the subsequent ones can fail because of a image locking failure. That is not an authentic failure of the test case itself and could be sometimes confusing. Disable image locking to avoid that. Signed-off-

[Qemu-devel] [PATCH for-2.7 08/15] qemu-iotests: 140: Disable image lock for qemu-io access

2016-04-13 Thread Fam Zheng
The VM is still on, the image locking check would complain. Signed-off-by: Fam Zheng --- tests/qemu-iotests/140 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/140 b/tests/qemu-iotests/140 index 05e4506..412b26f 100755 --- a/tests/qemu-iotests/140 +++ b/tes

Re: [Qemu-devel] [PATCH for-2.7 00/15] block: Lock images when opening

2016-04-13 Thread Daniel P. Berrange
On Wed, Apr 13, 2016 at 05:09:49PM +0800, Fam Zheng wrote: > Too many troubles have been caused by two processes writing to the same image > unexpectedly. This series introduces automatical image locking into QEMU to > avoid such tragedy. With this, the user won't be able to open the image from > t

[Qemu-devel] [PATCH for-2.7 09/15] qemu-iotests: 046: Move version detection out from verify_io

2016-04-13 Thread Fam Zheng
So the image lock won't complain. Signed-off-by: Fam Zheng --- tests/qemu-iotests/046 | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046 index e0be46c..40c4bc0 100755 --- a/tests/qemu-iotests/046 +++ b/test

Re: [Qemu-devel] [PATCH for-2.7 05/15] raw-posix: Implement .bdrv_lockf

2016-04-13 Thread Daniel P. Berrange
On Wed, Apr 13, 2016 at 05:09:54PM +0800, Fam Zheng wrote: > Because virtlockd in libvirt already uses the fcntl lock on the image file, we > have to workaround this by locking a digest-mapped temporary file. > > Signed-off-by: Fam Zheng > --- > block/raw-posix.c | 97 >

[Qemu-devel] [PATCH for-2.7 11/15] qemu-iotests: Disable image lock when checking test image

2016-04-13 Thread Fam Zheng
The VM is running, qemu-io would fail the lock acquisition. Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index 3ac2443..fa996ef 100755 --- a/tests/qemu-iotests/030 +++ b/tes

[Qemu-devel] [PATCH for-2.7 13/15] ahci-test: Specify "lock-image=off" in CLI

2016-04-13 Thread Fam Zheng
The case is the temporary image is sometimes used by more than one QEMU processes, just use the nop lock to avoid image locking failures. Signed-off-by: Fam Zheng --- tests/ahci-test.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/ahci-test.c b/tests

[Qemu-devel] [PATCH] vl: chanage runstate only if new state is different from current state

2016-04-13 Thread Li Zhijian
Previously, qemu will abort at following scenario: (qemu) stop (qemu) system_reset (qemu) system_reset (qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate transition: 'prelaunch' -> 'prelaunch' Signed-off-by: Li Zhijian --- vl.c | 4 1 file changed, 4 insertions(+) dif

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-13 Thread Marc-André Lureau
Hi - Original Message - > Hi Marc, > > First of all, sorry again for late response! > > Last time I tried with your first version, I found few issues related > with reconnect, mainly on the acked_feautres lost. While checking your > new code, I found that you've already solved that, whic

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

2016-04-13 Thread Vijay Kilari
On Mon, Apr 11, 2016 at 3:07 PM, Suzuki K Poulose wrote: > On 11/04/16 07:52, Vijay Kilari wrote: >> >> Adding Suzuki Poulose. >> >> Hi Suzuki, >> >> On Fri, Apr 8, 2016 at 3:13 PM, Peter Maydell >> wrote: >>> >>> On 8 April 2016 at 07:21, Vijay Kilari wrote: On Thu, Apr 7, 2016 at 5:1

Re: [Qemu-devel] [RFC PATCH v2 2/3] utils: Add cpuinfo helper to fetch /proc/cpuinfo

2016-04-13 Thread Suzuki K Poulose
On 13/04/16 10:54, Vijay Kilari wrote: On Mon, Apr 11, 2016 at 3:07 PM, Suzuki K Poulose wrote: On 11/04/16 07:52, Vijay Kilari wrote: Hi Suzuki, The last 5 patches are not compiling on v4.4. Looks like your patch series is not merged completely. Can you please rebase your patches and le

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-13 Thread Peter Xu
On Tue, Apr 12, 2016 at 08:39:21PM -0700, Jan Kiszka wrote: > On 2016-04-12 20:33, Peter Xu wrote: > > On Tue, Apr 12, 2016 at 08:39:02AM -0700, Jan Kiszka wrote: > >> On 2016-04-12 02:02, Peter Xu wrote: > > > > [...] > > > >>> Yes, I should consider other x86 platforms like AMD. Thanks to point

[Qemu-devel] [PULL 1/1] ivshmem: fix ivshmem-{plain, doorbell} crash without arg

2016-04-13 Thread marcandre . lureau
From: Marc-André Lureau "qemu -device ivshmem-{plain,doorbell}" will crash, because the device doesn't check that the required argument is provided. (screwed up in commit 5400c02) Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- hw/misc/ivshmem.c | 30 ++

[Qemu-devel] [PULL 0/1] Ivshmem fix

2016-04-13 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-04-12 17:47:15 +0100) are available in the git repository at: g...@github.com:elmarco/qemu.git tags/ivshme

Re: [Qemu-devel] [PATCH for-2.7 00/15] block: Lock images when opening

2016-04-13 Thread Denis V. Lunev
On 04/13/2016 12:09 PM, Fam Zheng wrote: Too many troubles have been caused by two processes writing to the same image unexpectedly. This series introduces automatical image locking into QEMU to avoid such tragedy. With this, the user won't be able to open the image from two processes (e.g. using

Re: [Qemu-devel] [PATCH v2 4/5] Change return type of functions that are named *_exit or *_exitfn in hw/s390x from int to void

2016-04-13 Thread Cornelia Huck
On Tue, 12 Apr 2016 23:57:06 +0530 Nutan Shinde wrote: > This change is required because the return type of exit(error) function is > not used. > This patch only has changes for files in hw/s390x package. Some meta-notes (I saw the related discussion on qemu-devel; the comments there apply to th

Re: [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver.

2016-04-13 Thread Jitendra Kolhe
On 4/10/2016 10:29 PM, Michael S. Tsirkin wrote: > On Fri, Apr 01, 2016 at 04:38:28PM +0530, Jitendra Kolhe wrote: >> On 3/29/2016 5:58 PM, Michael S. Tsirkin wrote: >>> On Mon, Mar 28, 2016 at 09:46:05AM +0530, Jitendra Kolhe wrote: While measuring live migration performance for qemu/kvm gues

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote: > I have a hard time coming up with realistic unclean breakage. The issue is that Linux is now exposing fw cfg to userspace. So it's use is about to expand significantly. This is what I am trying to prevent: - in 2016, users build

[Qemu-devel] [PATCH for-2.6 0/2] block: Fix blk_aio_write_zeroes()

2016-04-13 Thread Kevin Wolf
Kevin Wolf (2): qemu-io: Support 'aio_write -z' block: Fix blk_aio_write_zeroes() block/block-backend.c | 20 +++ qemu-io-cmds.c | 64 +++- tests/qemu-iotests/033 | 8 +++-- tests/qemu-iotests/033.out | 82 +

[Qemu-devel] [PATCH for-2.6 1/2] qemu-io: Support 'aio_write -z'

2016-04-13 Thread Kevin Wolf
This allows testing blk_aio_write_zeroes(). Signed-off-by: Kevin Wolf --- qemu-io-cmds.c | 64 +++--- 1 file changed, 48 insertions(+), 16 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 382faa8..51ae5a5 100644 --- a/qemu-io-cm

[Qemu-devel] [PATCH for-2.6 2/2] block: Fix blk_aio_write_zeroes()

2016-04-13 Thread Kevin Wolf
Commit 57d6a428 broke blk_aio_write_zeroes() because in some write functions in the call path don't have an explicit length argument but reuse qiov->size instead. Which is great, except that write_zeroes doesn't have a qiov, which this commit interprets as 0 bytes. Consequently, blk_aio_write_zeroe

Re: [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver.

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 04:24:55PM +0530, Jitendra Kolhe wrote: > Can we extend support for post-copy in a different patch set? If the optimization does not *help* on some paths, that's fine. The issue is with adding extra code special-casing protocols: +if (migrate_postcopy_ram()) { +

Re: [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver.

2016-04-13 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Wed, Apr 13, 2016 at 04:24:55PM +0530, Jitendra Kolhe wrote: > > Can we extend support for post-copy in a different patch set? > > If the optimization does not *help* on some paths, > that's fine. The issue is with adding extra code > special-casi

[Qemu-devel] Gdk deprecations on fedora24/gdk 3.20

2016-04-13 Thread Dr. David Alan Gilbert
Hi Gerd, I tried building qemu head on f24, there are a bunch of gtk deprecations: (This is from gtk gtk3-3.20.2-1.fc24.x86_64) /home/dgilbert/git/qemu/ui/gtk.c:479:5: error: ‘gdk_display_get_device_manager’ is deprecated: Use 'gdk_display_get_default_seat' instead [-Werror=deprecated-declara

Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void

2016-04-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 13/04/2016 08:33, Markus Armbruster wrote: >> * Look for functions that are named *_exit or *_exitfn in hw/ and that >> return int. They should all return zero. Make them return void, and >> remove the checks for the callers. > > ... and change the exit meth

Re: [Qemu-devel] [PATCH v2] migration: skip sending ram pages released by virtio-balloon driver.

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 12:15:38PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Wed, Apr 13, 2016 at 04:24:55PM +0530, Jitendra Kolhe wrote: > > > Can we extend support for post-copy in a different patch set? > > > > If the optimization does not *help

Re: [Qemu-devel] post-copy is broken?

2016-04-13 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Li, Liang Z (liang.z...@intel.com) wrote: > > > > > I used the latest qemu code (commit id: 4e71220387e88a22) and kernel > > > > (v4.5) to test the post-copy, and find the guest get crashed after > > > > live migration, no matter I did a loc

[Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Thomas Huth
The balloon code currently calls madvise() with TARGET_PAGE_SIZE as length parameter, and an address which is directly based on the page address supplied by the guest. Since the virtio-balloon protocol is always based on 4k based addresses/sizes, no matter what the host and guest are using as page

Re: [Qemu-devel] Gdk deprecations on fedora24/gdk 3.20

2016-04-13 Thread Paolo Bonzini
On 13/04/2016 13:24, Dr. David Alan Gilbert wrote: > Hi Gerd, > I tried building qemu head on f24, there are a bunch of gtk > deprecations: > > (This is from gtk gtk3-3.20.2-1.fc24.x86_64) Can you add it to known issues (though it probably shouldn't block 2.6). Paolo > /home/dgilbert/git/qe

Re: [Qemu-devel] [PATCH] vl: chanage runstate only if new state is different from current state

2016-04-13 Thread Paolo Bonzini
On 13/04/2016 11:27, Li Zhijian wrote: > Previously, qemu will abort at following scenario: > (qemu) stop > (qemu) system_reset > (qemu) system_reset > (qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate > transition: 'prelaunch' -> 'prelaunch' > > Signed-off-by: Li Zhijian

Re: [Qemu-devel] Gdk deprecations on fedora24/gdk 3.20

2016-04-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 13/04/2016 13:24, Dr. David Alan Gilbert wrote: > > Hi Gerd, > > I tried building qemu head on f24, there are a bunch of gtk > > deprecations: > > > > (This is from gtk gtk3-3.20.2-1.fc24.x86_64) > > Can you add it to known issues (though

Re: [Qemu-devel] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit

2016-04-13 Thread Leon Alrae
On 12/04/16 13:58, Aleksandar Markovic wrote: > @@ -322,14 +327,14 @@ int float32_is_quiet_nan( float32 a_ ) > | NaN; otherwise returns 0. > > **/ > > -int float32_is_signaling_nan( float32 a_ ) > +int float32_is_signa

Re: [Qemu-devel] [PATCH v4 2/9] softfloat: For Mips only, correct default NaN values

2016-04-13 Thread Leon Alrae
On 12/04/16 13:58, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Only for Mips platform, and only for cases when snan_bit_is_one is 0, > correct default NaN values (in their 16-, 32-, and 64-bit flavors). > > For more info, see [1], page 84, Table 6.3 "Value Supplied When > a New Qu

Re: [Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

2016-04-13 Thread Greg Kurz
On Tue, 12 Apr 2016 09:52:00 +0200 Michael Fritscher wrote: > It was tested on Windows & Linux hosts, on the later no obvious regressions > could be found. The guest was a Knoppix 7.6.0 live cd. > > This is WIP and a RFC - it isn't meant to be upstreamed yet. The error_printf > are only for de

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Andrew Jones
On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: > The balloon code currently calls madvise() with TARGET_PAGE_SIZE > as length parameter, and an address which is directly based on > the page address supplied by the guest. Since the virtio-balloon > protocol is always based on 4k based

Re: [Qemu-devel] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-04-13 Thread Pavel Borzenkov
Hi Eric, On Thu, Apr 07, 2016 at 10:10:58AM -0600, Eric Blake wrote: > On 04/07/2016 04:38 AM, Vladimir Sementsov-Ogievskiy wrote: > > On 05.04.2016 16:43, Paolo Bonzini wrote: > >> > >> On 05/04/2016 06:05, Kevin Wolf wrote: > >>> The options I can think of is adding a request field "max number o

Re: [Qemu-devel] Gdk deprecations on fedora24/gdk 3.20

2016-04-13 Thread Gerd Hoffmann
On Mi, 2016-04-13 at 12:24 +0100, Dr. David Alan Gilbert wrote: > Hi Gerd, > I tried building qemu head on f24, there are a bunch of gtk > deprecations: > > (This is from gtk gtk3-3.20.2-1.fc24.x86_64) Hmm, time to upgrade my fedora container to f24 I guess. But not urgent for 2.6 (we don't ha

Re: [Qemu-devel] [PATCH v4 3/9] softfloat: For Mips only, correct order in pickNaNMulAdd()

2016-04-13 Thread Leon Alrae
On 12/04/16 13:58, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Only for Mips platform, and only for cases when snan_bit_is_one is 0, > correct the order of argument comparisons in pickNaNMulAdd(). > > For more info, see [2], page 53, section "3.5.3 NaN Propagation". > > [1] "MIPS

Re: [Qemu-devel] [PATCH v17 6/8] Introduce new APIs to do replication operation

2016-04-13 Thread Stefan Hajnoczi
On Mon, Apr 11, 2016 at 04:22:57PM +0800, Changlong Xie wrote: > +/* > + * The caller of the function MUST make sure vm stopped > + */ > +void replication_start_all(ReplicationMode mode, Error **errp) > +{ > +ReplicationState *rs, *next; > + > +QLIST_FOREACH_SAFE(rs, &replication_states, no

Re: [Qemu-devel] [PATCH v14 01/19] qapi: Consolidate object visitors

2016-04-13 Thread Markus Armbruster
Eric Blake writes: > Rather than having two separate visitor callbacks with items > already broken out, pass the actual QAPISchemaObjectType object > to the visitor. This lets the visitor access things like > type.is_implicit() without needing another parameter, resolving > a TODO from previous

Re: [Qemu-devel] post-copy is broken?

2016-04-13 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > +if ( ((b + 1) % 255) == last_byte && !hit_edge) { Ahem, that should be 256. I'm going to bisect the kernel and see where we get to. Andrea's userfaultfd self-test passes on 2.5, so it's something more subtle. Dave -- Dr. David

Re: [Qemu-devel] [PATCH v17 7/8] Implement new driver for block replication

2016-04-13 Thread Stefan Hajnoczi
On Mon, Apr 11, 2016 at 04:22:58PM +0800, Changlong Xie wrote: > +static coroutine_fn int replication_co_writev(BlockDriverState *bs, > + int64_t sector_num, > + int remaining_sectors, > +

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: > The balloon code currently calls madvise() with TARGET_PAGE_SIZE > as length parameter, and an address which is directly based on > the page address supplied by the guest. Since the virtio-balloon > protocol is always based on 4k based

[Qemu-devel] [PATCH for-2.7 0/2] 9p: cleanup in #include directives

2016-04-13 Thread Greg Kurz
The recent RFC patch to bring 9p support to Windows hosts unveiled some nits. These two patches are preliminary cleanup. Michael, I'd like you to carry these patches in your patchset. Please rebase your current work on top of them. Thanks. --- Greg Kurz (2): 9p: don't include 9p:

[Qemu-devel] [PATCH for-2.7 2/2] 9p: some more cleanup in #include directives

2016-04-13 Thread Greg Kurz
The "9p-attr.h" header isn't needed by 9p synth and virtio 9p. While here, also drop last references to virtio from 9p synth since it is now transport agnostic code. Signed-off-by: Greg Kurz --- hw/9pfs/9p-synth.c |4 +--- hw/9pfs/virtio-9p-device.c |1 - 2 files changed, 1 inse

[Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include

2016-04-13 Thread Greg Kurz
The system header doesn't exist on all host platforms. Code should include "qemu/osdep.h" instead to avoid build breaks on plafforms that don't define CONFIG_IOVEC (like win32, if it is to support 9p one day). Signed-off-by: Greg Kurz --- fsdev/9p-iov-marshal.c |1 - fsdev/9p-marshal.c

[Qemu-devel] [PATCH 0/1] qemu-img: check block status of backing file when converting.

2016-04-13 Thread Ren Kimura
When converting images, check the block status of it's backing file chain to avoid needlessly reading zeros.

[Qemu-devel] [PATCH 1/1] qemu-img: check block status of backing file when converting.

2016-04-13 Thread Ren Kimura
Signed-off-by: Ren Kimura --- qemu-img.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 06264d9..53471a1 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1451,6 +1451,21 @@ static void convert_select_part(ImgConvertState

[Qemu-devel] [RFC] libqtest: dump child invocation when QTEST_LOG set

2016-04-13 Thread Alex Bennée
The QTEST_LOG environment is used for debugging qtest interactions with a child process. When it is defined we now also dump the invocation line to stderr to make it easier for people to see how QEMU was invoked. Signed-off-by: Alex Bennée --- tests/libqtest.c | 6 +- 1 file changed, 5 inser

Re: [Qemu-devel] best way to implement emulation of AArch64 tagged addresses

2016-04-13 Thread Tom Hanson
On 04/11/2016 06:58 AM, Thomas Hanson wrote: Ah, true. On 9 April 2016 at 09:57, Richard Henderson mailto:r...@twiddle.net>> wrote: On 04/08/2016 05:29 PM, Thomas Hanson wrote: Looking at tcg_out_tlb_load(): If I'm reading the pseudo-assembler of the function names

Re: [Qemu-devel] [Qemu-block] [PULL 08/12] mirror: Rewrite mirror_iteration

2016-04-13 Thread Kevin Wolf
Am 29.02.2016 um 21:08 hat Jeff Cody geschrieben: > From: Fam Zheng > > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iterati

Re: [Qemu-devel] [PATCH v14 02/19] qapi-visit: Add visitor.type classification

2016-04-13 Thread Markus Armbruster
Eric Blake writes: > We have three classes of QAPI visitors: input, output, and dealloc. > Currently, all implementations of these visitors have one thing in > common based on their visitor type: the implementation used for the > visit_type_enum() callback. But since we plan to add more such > c

Re: [Qemu-devel] Qemu-kvm live migration modify

2016-04-13 Thread Thomas Lamprecht
hi, this message would probably be better suited on the qemu-discuss list not the devel. comments inline. On 13.04.2016 09:43, Gilar Dwitresna wrote: > hi, > I have done make implementation of qemu-kvm instalation for live > migration on ubuntu with sharing storage (NFS) configuration. > the qe

[Qemu-devel] Unable to start the program because it lacks libglib-2.0-0.dll on your computer

2016-04-13 Thread aicha hamza
hey every one im trying to run qemu in windows ,but a window msg display Unable to start the program because it lacks libglib-2.0-0.dll on your computer i installed qemu from source and with migw and msys i was able to configure it ./configure --target-list=aarch64-softmmu --disable-vnc --enable-sd

Re: [Qemu-devel] [PATCH v4 3/9] softfloat: For Mips only, correct order in pickNaNMulAdd()

2016-04-13 Thread Aleksandar Markovic
Thanks, you are right, this area is changed in patch #1 too. However, it was not intended to be that way. Patch #1 should leave this function as-is, and the entire change for this function should be in this patch. I will organize the code as intended in the next version of the series. Yours, Ale

Re: [Qemu-devel] [PATCH v14 03/19] qapi: Guarantee NULL obj on input visitor callback error

2016-04-13 Thread Markus Armbruster
Eric Blake writes: > Our existing input visitors were not very consistent on errors > in a function taking 'TYPE **obj'. While all of them set '*obj' Suggest to list the methods. I guess it's start_struct(), start_alternate(), type_str(), type_any(). > to allocated storage on success, it was n

Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS

2016-04-13 Thread Greg Kurz
Hi Jevon, On Sun, 10 Apr 2016 14:55:55 +0800 Jevon Qiao wrote: > Hi Greg, > > Thank you for spending time reviewing this patch. > On 7/4/16 23:50, Greg Kurz wrote: > > On Tue, 15 Mar 2016 00:02:48 +0800 > > Jevon Qiao wrote: > > > >> Ceph as a promising unified distributed storage system is

Re: [Qemu-devel] [PATCH] iSCSI: start moving options also for -drive

2016-04-13 Thread Daniel P. Berrange
On Tue, Apr 12, 2016 at 04:57:42PM +0200, Pino Toscano wrote: > Hi, > > to overcome the limitations of the options handling [1], I'm planning > to move more options for iSCSI also as block options, so it is possible > to specify them with -drive. > > The only patch in this series is for initiator

[Qemu-devel] [PATCH for 2.6] block: convert iscsi target to a valid ID for -iscsi arg lookup

2016-04-13 Thread Daniel P. Berrange
The iSCSI block driver has a very strange approach whereby it does not accept options directly as part of the -drive arg, but instead takes them indirectly from a -iscsi arg. To make up -driver and -iscsi args, it takes the iSCSI target name and uses that as an ID value for the -iscsi arg lookup.

Re: [Qemu-devel] [PATCH v2 00/13] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-13 Thread Jan Kiszka
On 2016-04-13 00:27, Peter Xu wrote: > On Mon, Apr 11, 2016 at 03:32:18PM +0300, Michael S. Tsirkin wrote: >> On Mon, Apr 11, 2016 at 05:19:10PM +0800, Peter Xu wrote: >>> v2 changes: >>> - patch 1 >>> - rename "int_remap" to "intr" in several places [Marcel] >>> - remove "Intel" specific words

Re: [Qemu-devel] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-04-13 Thread Eric Blake
On 04/13/2016 06:38 AM, Pavel Borzenkov wrote: >> I'm also starting to think that it is worth FIRST documenting an >> extension for advertising block sizes, so that we can then couch >> BLOCK_STATUS in those terms (a server MUST NOT subdivide status into >> finer granularity than the advertised blo

[Qemu-devel] [PATCH] virtio-input: support absolute axis config in pass-through

2016-04-13 Thread Ladi Prosek
VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input devices. This patch follows the existing design and pre-fetches the config for all absolute axes using EVIOCGABS at realize time. Signed-off-by: Ladi Prosek --- hw/input/virtio-input-host.c | 46

Re: [Qemu-devel] [PATCH v3] fw_cfg: RFQDN rules, documentation

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 10:59:35AM +0200, Markus Armbruster wrote: > If we can protect them without > complicating or breaking stuff, sure, why not. But not at all costs. The stuff we break is precisely the stuff our warnings say might break at any time. So since you believe users might be relied

Re: [Qemu-devel] [PATCH v2 12/13] intel_iommu: ioapic: IR support for emulated IOAPIC

2016-04-13 Thread Jan Kiszka
On 2016-04-13 03:06, Peter Xu wrote: > On Tue, Apr 12, 2016 at 08:39:21PM -0700, Jan Kiszka wrote: >> On 2016-04-12 20:33, Peter Xu wrote: >>> On Tue, Apr 12, 2016 at 08:39:02AM -0700, Jan Kiszka wrote: On 2016-04-12 02:02, Peter Xu wrote: >>> >>> [...] >>> > Yes, I should consider other x

Re: [Qemu-devel] [PATCH] hw/virtio/balloon: Fixes for different host page sizes

2016-04-13 Thread Thomas Huth
On 13.04.2016 15:15, Michael S. Tsirkin wrote: > On Wed, Apr 13, 2016 at 01:52:44PM +0200, Thomas Huth wrote: >> The balloon code currently calls madvise() with TARGET_PAGE_SIZE >> as length parameter, and an address which is directly based on >> the page address supplied by the guest. Since the vi

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

2016-04-13 Thread Ryan Harper
I should also mention that the original command used will work if we specify which cpu type to use: qemu-system-ppc64 -m 256 \ -cpu POWER8 \ -display none -nographic \ -net nic -net user,net=10.0.0.0/8,host=10.0.0.1,hostfwd=tcp::-:22 \ -machine pseries \ -drive file=xenial-server-cl

Re: [Qemu-devel] [PULL 00/13] Block patches for 2.6

2016-04-13 Thread Peter Maydell
On 12 April 2016 at 17:18, Kevin Wolf wrote: > The following changes since commit 42bb626f7ebc9197d2943b897a99e127315275ab: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2016-04-12 09:34:52 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-04-13 Thread Jeff Cody
On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote: > Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC > over to using blk_pwrite() instead of bdrv_pwrite_sync(). The > return value of bdrv_pwrite_sync() was always 0 for success, and > create_dynamic_disk() in one instance che

Re: [Qemu-devel] [PATCH for 2.6] block: convert iscsi target to a valid ID for -iscsi arg lookup

2016-04-13 Thread Pino Toscano
On Wednesday 13 April 2016 15:18:20 Daniel P. Berrange wrote: > The iSCSI block driver has a very strange approach whereby it > does not accept options directly as part of the -drive arg, > but instead takes them indirectly from a -iscsi arg. To make > up -driver and -iscsi args, it takes the iSCSI

[Qemu-devel] [PULL v2 3/9] virtio-input: add missing key mappings

2016-04-13 Thread Gerd Hoffmann
From: Ladi Prosek KEY_PAUSE is flat out missing. KEY_SYSRQ already has a keycode assigned but it's not what I'm seeing on my system. The mapping doesn't appear to have to be unique so both keycodes now map to KEY_SYSRQ which is what the "Keyboard PrintScreen", HID usage ID 0x46, translates to. S

[Qemu-devel] [PULL v2 1/9] virtio-input: add parenthesis to const_le{16, 32}

2016-04-13 Thread Gerd Hoffmann
"_x" must be "(_x)" otherwise things fail if you pass in expressions. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake Message-id: 1460440299-26654-1-git-send-email-kra...@redhat.com --- include/hw/virtio/virtio-input.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) dif

[Qemu-devel] [PULL v2 7/9] virtio-input: fix emulated tablet axis ranges

2016-04-13 Thread Gerd Hoffmann
From: Ladi Prosek The reported maximum was wrong. The X and Y coordinates are 0-based so if size is 8000 maximum must be 7FFF. Signed-off-by: Ladi Prosek Message-id: 1460128893-10244-1-git-send-email-lpro...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/input/virtio-input-hid.c | 4 ++-- 1 f

[Qemu-devel] [PULL v2 9/9] virtio-input: support absolute axis config in pass-through

2016-04-13 Thread Gerd Hoffmann
From: Ladi Prosek VIRTIO_INPUT_CFG_ABS_INFO was not implemented for pass-through input devices. This patch follows the existing design and pre-fetches the config for all absolute axes using EVIOCGABS at realize time. Signed-off-by: Ladi Prosek Message-id: 1460558603-18331-1-git-send-email-lpro.

  1   2   >