Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

On Fr, 2016-02-19 at 10:14 +0100, Gerd Hoffmann wrote: > Current spice client expects we create a primary surface, > even if we do display updates using dma-bufs exclusively. > > So just do that to get things going. > > Not fully clear whenever that is intentional or a bug on > the spice side, so

Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC)

Hi On Fri, Mar 18, 2016 at 2:17 PM, Gerd Hoffmann wrote: > Ping Marc? Any comment on this? Could you send a rebased series, for the patches that lead to the issue? I assume "render DisplaySurface via opengl" patch? -- Marc-André Lureau

[Qemu-devel] [PULL 01/40] target-ppc: Document TOCTTOU in hugepage support

The code to find the minimum page size is is vulnerable to TOCTTOU. Added in commit 2d103aa "target-ppc: fix hugepage support when using memory-backend-file" (v2.4.0). Since I can't fix it myself right now, add a FIXME comment. Cc: Paolo Bonzini Cc: Michael Roth Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH for-2.6 13/14] pc-bios/s390-ccw: disambiguation of "No zIPL magic" message

From: "Eugene (jno) Dvurechenski" Don't indicate the same error message for different conditions. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/boo

[Qemu-devel] [PATCH for-2.6 14/14] s390-ccw.img: rebuild image

Contains the following changes: pc-bios/s390-ccw: add more disk layout checks pc-bios/s390-ccw: virtio_panic -> panic pc-bios/s390-ccw: add utility functions and "export" some others pc-bios/s390-ccw: qemuize types pc-bios/s390-ccw: update virtio implementation to allow up to 3 vrings pc-bios/s390

Re: [Qemu-devel] [RFC v1 09/11] tcg: drop global lock during TCG code execution

On 18/03/2016 17:18, Alex Bennée wrote: > From: KONRAD Frederic > > This finally allows TCG to benefit from the iothread introduction: Drop > the global mutex while running pure TCG CPU code. Reacquire the lock > when entering MMIO or PIO emulation, or when leaving the TCG loop. > > We have to

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

** Changed in: qemu (Ubuntu Vivid) Status: In Progress => Invalid ** Changed in: qemu (Ubuntu Vivid) Assignee: Liang Chen (cbjchen) => (unassigned) ** No longer affects: qemu (Ubuntu Vivid) -- You received this bug notification because you are a member of qemu- devel-ml, which is su

[Qemu-devel] [PATCH v1 1/2] crypto: add compat cast5_set_key with nettle < 3.0.0

Prior to the nettle 3.0.0 release, the cast5_set_key function was actually named cast128_set_key, so we must add a compatibility definition. Signed-off-by: Daniel P. Berrange --- crypto/cipher-nettle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/cipher-nettle.c b/crypto/cipher-n

[Qemu-devel] [Patch v2 1/1] blizzard: Remove support for DEPTH != 32

On Friday, March 18, 2016, Gerd Hoffmann wrote: > > On Mo, 2016-03-14 at 15:22 +, Peter Maydell wrote: > > On 14 March 2016 at 15:04, Pooja Dhannawat wrote: > > > Removing support for DEPTH != 32 from blizzard template header > > > and file that includes it, as macro DEPTH == 32 only used. >

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Fri, Mar 18, 2016 at 6:57 PM, Jaya Tiwari wrote: > > > On Fri, Mar 18, 2016 at 5:21 PM, Paolo Bonzini > wrote: > >> >> >> On 18/03/2016 12:24, Pooja Dhannawat wrote: >> > >> > >> > On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini > > > wrote: >> > >> > >> > >> >

[Qemu-devel] [RFC v2 4/6] hw/misc: sdm virtio device

This is the virtio implementation for an SDM device. Parameters are: comm=[sdm_communication_id] specifies the communication channel master=[true/false] - configure the SDM device as master or slave num_slaves=[slave_number] - if master is true, specifies the number of slaves len-signals=[signals_

[Qemu-devel] kvm ept fault BUG_ON()

Hi, apologies if I am not posting to the appropriate list(s). I am using QEMU-KVM and try to implement a simple character device which offers mmap() functionality of host device memory to guest userspace. For this purpose, I have written a dummy guest driver which communicates with a qemu backend

[Qemu-devel] [PATCH v5 28/28] migration: remove qemu_get_fd method from QEMUFile

Now that there is a set_blocking callback in QEMUFileOps, and all users needing non-blocking support have been converted to QIOChannel, there is no longer any codepath requiring the qemu_get_fd() method for QEMUFile. Remove it to avoid further code being introduced with an expectation of direct fil

[Qemu-devel] [PULL 26/40] ivshmem: Propagate errors through ivshmem_recv_setup()

This kills off the funny state described in the previous commit. Simplify ivshmem_io_read() accordingly, and update documentation. Signed-off-by: Markus Armbruster Message-Id: <1458066895-20632-27-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- docs/specs/ivshmem-spec.txt

[Qemu-devel] [PULL 35/40] ivshmem: Replace int role_val by OnOffAuto master

In preparation of making it a qdev property. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-36-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --g

[Qemu-devel] [PULL 11/40] ivshmem: Add missing newlines to debug printfs

Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-12-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 1838bc8..11cbc03 100644 -

[Qemu-devel] [PULL v1 02/13] crypto: add support for PBKDF2 algorithm

The LUKS data format includes use of PBKDF2 (Password-Based Key Derivation Function). The Nettle library can provide an implementation of this, but we don't want code directly depending on a specific crypto library backend. Introduce a new include/crypto/pbkdf.h header which defines a QEMU API for

Re: [Qemu-devel] [PATCH 09/16] block: wait for all pending I/O when doing synchronous requests

On Tue, Feb 16, 2016 at 06:56:21PM +0100, Paolo Bonzini wrote: > Synchronous I/O should in general happen either in the main thread (e.g. > for bdrv_open and bdrv_create) or between bdrv_drained_begin and > bdrv_drained_end. Therefore, the simplest way to wait for it to finish > is to wait for _al

[Qemu-devel] [PATCH] arm: fix machine description

Fix what is clearly a copy-and-paste bug. Fixes: c29196904b ("target-arm: Add virt class and machine types"). Cc: Greg Bellows Signed-off-by: Michael S. Tsirkin --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 8c6c996..9cf

[Qemu-devel] [PULL 12/21] hw/timer: Add ASPEED timer device model

From: Andrew Jeffery Implement basic ASPEED timer functionality for the AST2400 SoC[1]: Up to 8 timers can independently be configured, enabled, reset and disabled. Some hardware features are not implemented, namely clock value matching and pulse generation, but the implementation is enough to bo

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

On 03/16/2016 09:38 PM, Christian Borntraeger wrote: On 03/16/2016 01:55 PM, Paolo Bonzini wrote: On 16/03/2016 12:24, Christian Borntraeger wrote: On 03/16/2016 12:09 PM, Paolo Bonzini wrote: On 16/03/2016 11:49, Christian Borntraeger wrote: #3 0x800b713e in virtio_blk_data_plane

[Qemu-devel] [PATCH] quorum: add child name into filename

The monitor command 'query-block' or 'info block' will output the filename. So we can get each children's child-name after this patch. This useful for dynamic reconfiguration. Signed-off-by: Wen Congyang --- block/quorum.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --

[Qemu-devel] [RFC v2 5/6] hw/arm: boot

From: Christian Pinto This patch modifies the boot process of an ARM machine in otrder to check whether if it is a slave, by checking the slave machine flag. When the slave flag is on, no kernel, dtb or initrd are loaded into memory. The boot address of each core is set to the start address of t

[Qemu-devel] [RESEND PATCH v2 4/4] hw/audio: QOM'ify milkymist-ac97.c

* Drop the old SysBus init function and use instance_init * Move AUD_open_in / AUD_open_out function into realize stage Signed-off-by: xiaoqiang zhao --- hw/audio/milkymist-ac97.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/hw/audio/milkymist-

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/bcm2836: Wire up CPU timer interrupts correctly

On Mar 17, 2016 4:33 AM, "Peter Maydell" wrote: > > Wire up the CPU timer interrupts in the right order, with the > nonsecure physical timer on cntpnsirq, the hyp timer on cnthpirq, > and the secure physical timer on cntpsirq. (We did get the > virt timer right, at least.) > > Reported-by: Antonio

Re: [Qemu-devel] [PATCH v2 08/10] ppc: Add POWER8 IAMR register

On 03/16/2016 06:46 PM, Thomas Huth wrote: > That should be now a "if (has_iamr)" instead of "if (!has_iamr)", > shouldn't it? yes I will send an update for this patch only. Sorry for the noise. C.

Re: [Qemu-devel] Hi good afternoon, some small support

On Fri, Mar 04, 2016 at 08:52:37PM +, Sanchez, Juan Carlos (GE Aviation) wrote: > I am trying to execute an image created by ARM in QEMU using windows > OS, could you give me guide to example the command line? > > The command line in Unix work well, but I don't understood all the opti

[Qemu-devel] [PATCH v5 15/28] migration: convert fd socket protocol to use QIOChannel

Convert the fd socket migration protocol driver to use QIOChannel and QEMUFileChannel, instead of plain sockets APIs. It can be unconditionally built because the QIOChannel APIs it uses will take care to report suitable error messages if needed. Reviewed-by: Dr. David Alan Gilbert Signed-off-by:

Re: [Qemu-devel] [PATCH v3 26/40] ivshmem: Propagate errors through ivshmem_recv_setup()

On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster wrote: > This kills off the funny state described in the previous commit. > > Simplify ivshmem_io_read() accordingly, and update documentation. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > docs/specs/ivshmem-

[Qemu-devel] [PULL 10/21] i.MX: Add i.MX6 CCM and ANALOG device.

From: Jean-Christophe Dubois Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois Message-id: 9fa80b4d8c5d0f50c94e77d74f952a7a665e168f.1456868959.git@tribudubois.net Signed-off-by: Peter Maydell --- hw/misc/Makefile.objs | 1 + hw/misc/imx6_ccm.c | 774

[Qemu-devel] [PATCH v2 05/10] ppc: Add dummy SPR_IC for POWER8

From: Benjamin Herrenschmidt It's supposed to be an instruction counter. For now make us not crash when accessing it. Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Thomas Huth Reviewed-by: David Gibson --- This is required for patch "ppc: A couple more dummy POWER8 Book4 regs" target

Re: [Qemu-devel] [Qemu-block] [PATCH v16 2/8] Backup: clear all bitmap when doing block checkpoint

On 03/17/2016 02:48 AM, Jeff Cody wrote: On Fri, Mar 11, 2016 at 06:34:09PM +0800, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c| 15 +++ inc

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Mar 15, 2016 at 01:56:47PM +, Dr. David Alan Gilbert wrote: > > > This would put trace_foo() in generated-tracers-virtio-blk.h and > > > trace_bar() in generated-tracers-memory.h. Source files using tracing > > > would need to include he

Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode emulation

On 17 March 2016 at 13:46, wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Sergey Fedorov > --- > translate-all.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index e9f409b762ab..f17ace1ae8

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Friday, March 18, 2016, Paolo Bonzini wrote: > > > On 18/03/2016 14:49, Pooja Dhannawat wrote: >> >> >> If it is greater than the accepted level, the on-stack >> buffer is not >> used and you allocate one that has the right size on the heap. >> >> Yes

[Qemu-devel] [PULL 34/40] qdev: New DEFINE_PROP_ON_OFF_AUTO

Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-35-git-send-email-arm...@redhat.com> --- hw/core/qdev-properties.c| 10 ++ include/hw/qdev-properties.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/hw/core/qdev-properties.c b/

[Qemu-devel] [PATCH for-2.6 06/14] pc-bios/s390-ccw: add vdev object to store all device details

From: "Eugene (jno) Dvurechenski" Add VDev "object" as a container for all device-related items. The default object is static. Leverage dependency on many different device-related globals. Make them syntactically visible. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck -

Re: [Qemu-devel] [PATCH 2/3] hw/net/spapr_llan: Fix receive buffer handling for better performance

On 17.03.2016 07:23, David Gibson wrote: > On Wed, Mar 16, 2016 at 01:16:50PM +0100, Thomas Huth wrote: >> >> This patch introduces an alternate way of handling the receive >> buffers of the spapr-vlan device, resulting in much better >> receive performance for the guest. [...] >> Though it seems a

[Qemu-devel] [PATCH v4 03/17] block: Add blk_commit_all()

Later, we will remove bdrv_commit_all() and move its contents here, and in order to replace bdrv_commit_all() calls by calls to blk_commit_all() before doing so, we need to add it as an alias now. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/block-backend.c | 5 + inc

[Qemu-devel] [PULL v1 06/13] crypto: add support for the cast5-128 cipher algorithm

A new cipher algorithm 'cast-5-128' is defined for the Cast-5 algorithm with 128 bit key size. Smaller key sizes are supported by Cast-5, but nothing in QEMU should use them, so only 128 bit keys are permitted. The nettle and gcrypt cipher backends are updated to support the new cipher and a test

Re: [Qemu-devel] [PATCH 1/2] quorum: Emit QUORUM_REPORT_BAD for reads in fifo mode

On 15.03.2016 10:41, Alberto Garcia wrote: > If there's an I/O error in one of Quorum children then QEMU > should emit QUORUM_REPORT_BAD. However this is not working with > read-pattern=fifo. This patch fixes this problem. > > Signed-off-by: Alberto Garcia > --- > block/quorum.c | 17 +--

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/17/2016 05:10 PM, Alberto Garcia wrote: > > On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang > > wrote: > >> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { > >> bool rewrite_corrupted;/* true if the driver must > >> rewri

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

On 16/03/2016 12:56, Cornelia Huck wrote: > On Wed, 16 Mar 2016 12:48:22 +0100 > Paolo Bonzini wrote: > >> >> >> On 16/03/2016 12:32, Cornelia Huck wrote: >>> On Wed, 16 Mar 2016 12:09:02 +0100 >>> Paolo Bonzini wrote: >>> On 16/03/2016 11:49, Christian Borntraeger wrote: >>> > #3 0x

Re: [Qemu-devel] [PATCH v2 03/16] block: introduce bdrv_no_throttling_begin/end

On Wed, 03/16 15:16, Paolo Bonzini wrote: > Extract the handling of throttling from bdrv_flush_io_queue. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH V5 1/2] net/filter-mirror: implement filter-redirector

On 03/17/2016 02:43 PM, Jason Wang wrote: On 03/16/2016 06:38 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter.

[Qemu-devel] [PATCH v4 13/17] block: Add bdrv_next_monitor_owned()

Add a function for iterating over all monitor-owned BlockDriverStates so the generic block layer can do so. Signed-off-by: Max Reitz --- blockdev.c | 7 +++ include/block/block.h | 1 + stubs/Makefile.objs | 1 + stubs/bdrv-next-monitor-owned.c | 8

Re: [Qemu-devel] [PATCH 2/2] iotests: Test QUORUM_REPORT_BAD in fifo mode

On 15.03.2016 10:41, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/148 | 17 +++-- > tests/qemu-iotests/148.out | 4 ++-- > 2 files changed, 17 insertions(+), 4 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital

[Qemu-devel] [RFC v1 09/11] tcg: drop global lock during TCG code execution

From: KONRAD Frederic This finally allows TCG to benefit from the iothread introduction: Drop the global mutex while running pure TCG CPU code. Reacquire the lock when entering MMIO or PIO emulation, or when leaving the TCG loop. We have to revert a few optimization for the current TCG threading

Re: [Qemu-devel] [RFC v1 03/11] tcg: comment on which functions have to be called with tb_lock held

On 18/03/2016 17:18, Alex Bennée wrote: > + > +/* Protected by tb_lock. */ Only writes are protected by tb_lock. Read happen outside the lock. Reads are not quite thread safe yet, because of tb_flush. In order to fix that, there's either the async_safe_run() mechanism from Fred or prefer

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

** No longer affects: cloud-archive ** Also affects: cloud-archive Importance: Undecided Status: New ** Also affects: cloud-archive/kilo Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [PULL 04/40] qemu-doc: Fix ivshmem huge page example

Option parameter "share" is missing. Without it, you get a *private* mmap(), which defeats ivshmem's purpose pretty thoroughly ;) While there, switch to the conventional mountpoint of hugetlbfs /dev/hugepages. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Reviewed-by: Paolo B

[Qemu-devel] [RFC v2 4/6] qemu: slave machine flag

From: Christian Pinto This patch adds a new machine flag, to configure qemu as a slave instance. Usage -machine -slave=[on|off] (default=off) Signed-off-by: Christian Pinto --- hw/core/machine.c | 27 +++ include/hw/boards.h | 2 ++ qemu-options.hx | 5 -

[Qemu-devel] [RFC v2 1/6] hw/misc: sdm interface

This patch forms the common skeleton code for the SDM interface. The SDMDevice represents the interface with the machine, the SDMCommunication the communication channel and the SDMSignal represents an action to perform when a signal is received (for example to boot the machine). Signed-off-by: Ba

[Qemu-devel] [PATCH v5 25/28] migration: define 'tls-creds' and 'tls-hostname' migration parameters

Define two new migration parameters to be used with TLS encryption. The 'tls-creds' parameter provides the ID of an instance of the 'tls-creds' object type, or rather a subclass such as 'tls-creds-x509'. Providing these credentials will enable use of TLS on the migration data stream. If using x509

[Qemu-devel] [PATCH v5 03/28] migration: remove use of qemu_bufopen from vmstate tests

Some of the test-vmstate.c test cases use a temporary file while others use a memory buffer. To facilitate the future removal of the qemu_bufopen() function, convert all the tests to use a temporary file. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- tests/Makefile

[Qemu-devel] [PATCH v4 01/13] tests: Add utilities for docker testing

docker.py is added with a number of useful subcommands to manager docker images and instances for QEMU docker testing. Subcommands are: run: A wrapper of "docker run" (or "sudo -n docker run" if necessary), which takes care of killing and removing the running container at SIGINT. clean: Tear down

[Qemu-devel] [PATCH v5 18/28] migration: convert savevm to use QIOChannel for writing to files

Convert the exec savevm code to use QIOChannel and QEMUFileChannel, instead of the stdio APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- migration/savevm.c | 8 +--- tests/Makefile | 4 ++-- tests/test-vmstate.c | 11 ++- 3 files changed, 17

[Qemu-devel] [PATCH 03/20] qemu-io: Call blk_set_enable_write_cache() explicitly

Signed-off-by: Kevin Wolf --- qemu-io.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index d7c2f26..260b024 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -50,7 +50,7 @@ static const cmdinfo_t close_cmd = { .oneline= "close t

Re: [Qemu-devel] [PATCH v4 3/9] hw/timer: QOM'ify lm32_timer

On 17 March 2016 at 14:59, wrote: > [I had some problems with my mailserver and the v5 version didn't make it > through. I know there is a v5 version of this patch series and I've tested > with the v5 version] > > > Am 2016-02-22 04:15, schrieb xiaoqiang zhao: >> >> * split the old SysBus init fu

[Qemu-devel] [PATCH v6 07/16] qapi-event: Utilize implicit struct visits

Rather than generate inline per-member visits, take advantage of the 'visit_type_FOO_members()' function for emitting events. This is possible now that implicit structs can be visited like any other. Generated code shrinks accordingly; by initializing a struct based on parameters, through a new ge

Re: [Qemu-devel] basic block tracing question

On Wed, Mar 16, 2016 at 10:52 AM, Peter Maydell wrote: > > If you only emit tracing information after the TB has executed and > returned then you will miss the case where we execute half a TB > and take an exception (eg load/store that page faulted, or system call), > because in that case we'll l

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

On 16/03/2016 13:42, Cornelia Huck wrote: > On Wed, 16 Mar 2016 13:32:59 +0100 > Paolo Bonzini wrote: > >> On 16/03/2016 13:22, Cornelia Huck wrote: > Yeah, it doesn't help that the functions are underdocumented (as in the > "assign" parameter above). >>> My understanding is: >>> >>> -

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

On Wed, Mar 16, 2016 at 07:35:09PM +0100, Laszlo Ersek wrote: > OVMF uses this feature for a few flags. They are all called > "opt/ovmf/...". I followed the advice in "docs/specs/fw_cfg.txt" (which > shouldn't be surprising since I seem to have reviewed every patch for > that file): Wait a second.

Re: [Qemu-devel] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR

On Wed, 16 Mar 2016 09:18:03 +0530 Bharata B Rao wrote: > On Mon, Mar 14, 2016 at 10:47:28AM +0100, Igor Mammedov wrote: > > On Fri, 11 Mar 2016 10:24:29 +0530 > > Bharata B Rao wrote: > > > > > Hi, > > > > > > This is the next version of "Core based CPU hotplug for PowerPC sPAPR" > > > tha

[Qemu-devel] [PATCH v2 1/4] hw/audio: QOM'ify cs4231.c

Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/audio/cs4231.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c index caf97c1..30690f9 100644 --- a/hw/audio/cs4231.c +++ b/hw/audio/

[Qemu-devel] [PULL 14/21] hw/arm: Add ASPEED AST2400 SoC model

From: Andrew Jeffery While the ASPEED AST2400 SoC[1] has a broad range of capabilities this implementation is minimal, comprising an ARM926 processor, ASPEED VIC and timer devices, and a 8250 UART. [1] http://www.aspeedtech.com/products.php?fPath=20&rId=376 Signed-off-by: Andrew Jeffery Messag

Re: [Qemu-devel] [PATCH 1/3] hw/net/spapr_llan: Extract rx buffer code into separate functions

On 16/03/2016 13:16, Thomas Huth wrote: > Refactor the code a little bit by extracting the code that reads > and writes the receive buffer list page into separate functions. > There should be no functional change in this patch, this is just > a preparation for the upcoming extensions that introdu

Re: [Qemu-devel] [PATCH V4] hw/pxb: add chassis_nr property

hi On 03/15/2016 07:44 PM, Marcel Apfelbaum wrote: On 03/15/2016 10:00 AM, Cao jin wrote: And I have another personal question: In qemu design, it seems every pci bridge reside in a separate chassis, what`s benefit? why don`t put them all in the main chassis? Please have a look on pci-to-

[Qemu-devel] [PATCH 1/2] e1000: Fixing interrupts pace.

This patch introduces an upper bound for number of interrupts per second. Without this bound an interrupt storm can occur as it has been observed on Windows 10 when disabling the device. According to the SPEC - Intel PCI/PCI-X Family of Gigabit Ethernet Controllers Software Developer's Manual, sec

Re: [Qemu-devel] [PATCH v3 0/2] spapr: QMP: add query-hotpluggable-cpus

On Wed, 16 Mar 2016 20:29:59 +0100 Christian Borntraeger wrote: > On 03/15/2016 02:24 PM, Igor Mammedov wrote: > > Changes since v2: > > - rebase on top of hte lates spapr cpu hotpug series > > - add 'vcpus-count' field, pkre...@redhat.com > > - s/CpuInstanceProps/CpuInstanceProperties/ > > -

[Qemu-devel] [PULL 13/15] qapi: Make BlockdevOptions doc example closer to reality

From: Eric Blake Although we don't want to repeat the entire BlockdevOptions QMP command in the example, it helps if we aren't needlessly diverging (the initial example was written before we had committed the actual QMP interface). Use names that match what is found in qapi/block-core.json, such

Re: [Qemu-devel] [PATCH v6 16/16] qapi: Consolidate object visitors

Eric Blake writes: > Rather than having two separate visitor callbacks with items > already broken out, pass the actual QAPISchemaObjectType object > to the visitor. This lets the visitor access things like > type.is_implicit() without needing another parameter, resolving > a TODO from previous

Re: [Qemu-devel] [PATCH][RFC] IOMMU: Add Support to VFIO devices with vIOMMU present

On Tue, Mar 15, 2016 at 12:53 PM, Michael S. Tsirkin wrote: > On Sat, Mar 12, 2016 at 06:13:17PM +0200, Aviv B.D. wrote: > > From: "Aviv B.D." > > > > * Fix bug that prevent qemu from starting up when vIOMMU and VFIO > > device are present. > > * Advertise Cache Mode capability in iommu ca

Re: [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c

在 2016年03月17日 00:30, Paolo Bonzini 写道: On 16/03/2016 10:24, xiaoqiang zhao wrote: s->voice_out = AUD_open_out(&s->card, s->voice_out, "mm_ac97.out", s, ac97_out_cb, &as); AUD_open_out should not be done before realize. Paolo I wil move it to DeviceClasss::realize in

[Qemu-devel] [PATCH 2/2] ARM: Virt: Use gpio_key for power button

From: Shannon Zhao There is a problem for power button that it will not work if an early system_powerdown request happens before guest gpio driver loads. Fix this problem by using gpio_key. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH] qdev_try_create(): Assert that devices we put onto the system bus are SysBusDevices

On 16 March 2016 at 14:14, Andreas Färber wrote: > Am 16.03.2016 um 15:11 schrieb Peter Maydell: >> If qdev_try_create() is passed NULL for the bus, it will automatically >> put the newly created device onto the default system bus. However >> if the device is not actually a SysBusDevice then this

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

I frankly think it's overengineered, but it's already much better and if it helps converging to a compromise why not. Alternatives to your proposals follow: On 17/03/2016 14:13, Michael S. Tsirkin wrote: > > QEMU command line: > A. -fw-cfg RFQDN/PATH prepends usr/. So users will not get co

[Qemu-devel] [PULL 21/29] block: Use blk_co_preadv() for blk_read()

This patch introduces blk_co_preadv() as a central function on the BlockBackend level that is supposed to handle all read requests from the BB to its root BDS eventually. Signed-off-by: Kevin Wolf --- block/block-backend.c | 64 --- block/io.c

[Qemu-devel] [PULL 21/40] ivshmem: Assert interrupts are set up once

An interrupt is set up when the interrupt's file descriptor is received. Each message applies to the next interrupt vector. Therefore, each vector cannot be set up more than once. ivshmem_add_kvm_msi_virq() half-heartedly tries not to rely on this by doing nothing then, but that's not going to re

Re: [Qemu-devel] Timer interrupts for -M raspi2

Hi Andrew, Yeah, that's what I think. I believe I must be overlooking something but I just can't find what. With regards to the ARM Generic timer, I have set the enable bit[0] for CNTP_CTL and also I've set CNTP_TVAL, that's why I think the interrupt is triggered on the real hardware. I

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

On Fri, Mar 18, 2016 at 01:09:35PM +0100, Kevin Wolf wrote: > Am 17.03.2016 um 18:51 hat Daniel P. Berrange geschrieben: > > Add a block driver that is capable of supporting any full disk > > encryption format. This utilizes the previously added block > > encryption code, and at this time supports

Re: [Qemu-devel] [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

On Wed, Mar 16, 2016 at 06:57:01PM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 08, 2016 at 01:30:50PM -0500, Gabriel Somlo wrote: > > Allowing for the future possibility of implementing AML-based > > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > > acquire the global ACPI lock wh

Re: [Qemu-devel] [PATCH 2/5] trace: [all] Add "guest_vmem" event

Peter Maydell writes: > On 23 February 2016 at 18:22, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> +### Guest events, keep at bottom >> + >> +# @vaddr: Access' virtual address. >> +# @size : Access' size (bytes). >> +# @store: Whether the access is a store. >> +# >> +# Start virtua

[Qemu-devel] [PULL 19/21] bcm2835_property: implement framebuffer control/configuration properties

From: Grégory ESTRADE The property channel driver now interfaces with the framebuffer device to query and set framebuffer parameters. As a result of this, the "get ARM RAM size" query now correctly returns the video RAM base address (not total RAM size), and the ram-size property is no longer rel

[Qemu-devel] [PULL 07/40] ivshmem-test: Improve test case /ivshmem/single

Test state of registers after reset. Test reading Interrupt Status clears it. Test (invalid) read of Doorbell. Add more comments. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-8-git-send-email-arm...@redhat.com> --- tests/ivshmem-test.c | 23 ++

[Qemu-devel] [RFC v1 00/11] Base enabling patches for MTTCG

Hi, This RFC patch set aims to provide the basic framework for MTTCG. I've tried to pull together the non-contentious bits that other trees can then build on. This is because we have multiple potential solutions for things like deferring work and handling atomics. The idea being that those bits co

Re: [Qemu-devel] [PATCH v4] net: Allocating Large sized arrays to heap

On Thu, Mar 17, 2016 at 09:17:40PM +0530, Pooja Dhannawat wrote: > nc_sendv_compat has a huge stack usage of 69680 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Pooja Dhannawat > --- > net/net.c | 13 + > 1 file changed, 9 insertions(+), 4 dele

[Qemu-devel] [PULL 06/21] i.MX: Allow GPT timer to rollover.

From: Jean-Christophe Dubois GPT timer need to rollover when it reaches 0x. It also need to reset to 0 when in "restart mode" and crossing the compare 1 register. Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois Message-id: 6e2b36117a249a78bf822dd59a390368f407136e.145

[Qemu-devel] [PATCH for-2.6 08/14] pc-bios/s390-ccw: add simplified virtio call

From: "Eugene (jno) Dvurechenski" Add virtio_run(VirtioCmd) call to use simple declarative approach. Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/virtio.c | 17 + pc-bios/s390-ccw/virtio.h | 9 + 2 files changed, 26 insert

[Qemu-devel] [PULL 08/29] block: Drop BB name from bad option error

From: Max Reitz The information which BB is concerned does not seem useful enough to justify its existence in most other place (which may be related to qemu printing the -drive parameter in question anyway, and for blockdev-add the attribution is naturally unambiguous). Furthermore, as of a futur

Re: [Qemu-devel] [PATCH v4 6/9] hw/timer: QOM'ify milkymist_sysctl

[I had some problems with my mailserver and the v5 version didn't make it through. I know there is a v5 version of this patch series and I've tested with the v5 version] Am 2016-02-22 04:15, schrieb xiaoqiang zhao: * split the old SysBus init function into an instance_init and a Device reali

Re: [Qemu-devel] [PATCH 0/2] e1000: Introducing an upper bound of interrupts

On 03/17/2016 10:37 AM, Sameeh Jubran wrote: This patch series introduces an upper bound for the number of interrupts per second. This feature is supported by the real hardware, however up until now it wasn't implemented in e1000. This feature is very significant, it can prevent an interrupt stor

[Qemu-devel] [PATCH v4 00/17] blockdev: Further BlockBackend work

This series appears to reinvent itself with every revision. This time, its main implication is that BBs are no longer automatically treated as monitor-owned, and that a BB's name is tightly tied to the monitor reference (it is considered equivalent to that reference). v4: - Tightly tied a BB's na

[Qemu-devel] [PATCH v2 10/16] nfs: replace aio_poll with bdrv_drain

Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/nfs.c | 50 ++ 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 7220e89..5cebb83 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -48,6 +48,7

[Qemu-devel] [PULL v2 07/13] crypto: add support for the serpent cipher algorithm

New cipher algorithms 'serpent-128', 'serpent-192' and 'serpent-256' are defined for the Serpent algorithm. The nettle and gcrypt cipher backends are updated to support the new cipher and a test vector added to the cipher test suite. The new algorithm is enabled in the LUKS block encryption driver

[Qemu-devel] [PULL 10/40] ivshmem: Rewrite specification document

This started as an attempt to update ivshmem_device_spec.txt for clarity, accuracy and completeness while working on its code, and quickly became a full rewrite. Since the diff would be useless anyway, I'm using the opportunity to rename the file to ivshmem-spec.txt. I tried hard to ensure the ne

Re: [Qemu-devel] [PATCH] qemu-ga: drop unused local err variable

Quoting Stefan Hajnoczi (2016-03-16 10:16:02) > Commit 125b310e1d62e3a1dc1e7758563e598957ca7ae4 ("qemu-ga: move > channel/transport functionality into wrapper class") stopped using the > local err variable in channel_event_cb(). > > This patch deletes the unused variable. > > Signed-off-by: Stefa

[Qemu-devel] [PATCH v5 1/7] block: add flag to indicate that no I/O will be performed

When opening an image it is useful to know whether the caller intends to perform I/O on the image or not. In the case of encrypted images this will allow the block driver to avoid having to prompt for decryption keys when we merely want to query header metadata about the image. eg qemu-img info Th

[Qemu-devel] [PULL 33/40] ivshmem: Inline check_shm_size() into its only caller

Improve the error messages while there. Signed-off-by: Markus Armbruster Message-Id: <1458066895-20632-34-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- hw/misc/ivshmem.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --

[Qemu-devel] [PULL 13/21] hw/intc: Add (new) ASPEED VIC device model

From: Andrew Jeffery Implement a basic ASPEED VIC device model for the AST2400 SoC[1], with enough functionality to boot an aspeed_defconfig Linux kernel. The model implements the 'new' (revised) register set: While the hardware exposes both the new and legacy register sets, accesses to the model

  1   2   >