Re: [Qemu-devel] [RFC PATCH v2 3/3] VFIO: Type1 IOMMU mapping support for vGPU

2016-03-11 Thread Tian, Kevin
> From: Neo Jia > Sent: Friday, March 11, 2016 2:11 PM > > > Hi Jike, > > > > > > For vGPU, what we have is just a virtual device and a fake IOMMU group, > > > therefore > > > the actual interaction with the real GPU should be managed by the GPU > > > vendor driver. > > > > > > > Hi, Neo, > > > >

Re: [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb()

2016-03-11 Thread Alberto Garcia
On Fri 11 Mar 2016 02:31:31 AM CET, Wen Congyang wrote: > On 03/10/2016 08:13 PM, Alberto Garcia wrote: >> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's >> an I/O error in a Quorum child. However sacb->aiocb must be >> correctly initialized for this to happen. read_quorum_children()

Re: [Qemu-devel] [PATCH] target-arm: Fix descriptor address masking in ARM address translation

2016-03-11 Thread Peter Maydell
On 4 March 2016 at 23:04, Sergey Sorokin wrote: > There is a bug in ARM address translation regime with a long-descriptor > format. On the descriptor reading its address is formed from an index > which is a part of the input address. And on the first iteration this index > is incorrectly masked wi

Re: [Qemu-devel] [PATCH] Whitelist sysinfo call

2016-03-11 Thread Eduardo Otubo
On Mon, Mar 07, 2016 at 10=34=46AM +0100, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > Newer version of nss-softokn libraries (> 3.16.2.3) use sysinfo call > so qemu using rbd image hang after start when run in sandbox mode. > > To allow using rbd images in sandbox mode we have to wh

Re: [Qemu-devel] [PATCH v3 1/3] hw/timer: Add ASPEED timer device model

2016-03-11 Thread Peter Maydell
On 5 March 2016 at 11:29, Andrew Jeffery wrote: > Implement basic AST2400 timer functionality: Up to 8 timers can > independently be configured, enabled, reset and disabled. A couple of > hardware features are not implemented, namely clock value matching and > pulse generation, but the implementat

Re: [Qemu-devel] [PATCH v2 2/4] monitor: Separate QUORUM_REPORT_BAD events according to the node name

2016-03-11 Thread Alberto Garcia
On Thu 10 Mar 2016 09:35:32 PM CET, Eric Blake wrote: >> @@ -572,6 +572,10 @@ static unsigned int qapi_event_throttle_hash(const void >> *key) >> hash += g_str_hash(qdict_get_str(evstate->data, "id")); >> } >> >> +if (evstate->event == QAPI_EVENT_QUORUM_REPORT_BAD) { >> +

Re: [Qemu-devel] [PATCH v3 2/3] hw/intc: Add (new) ASPEED VIC device model

2016-03-11 Thread Peter Maydell
On 5 March 2016 at 11:29, Andrew Jeffery wrote: > Implement a basic ASPEED VIC device model, enough to boot a Linux kernel > configured with aspeed_defconfig. The model implements the 'new' > (revised) register set and while the hardware exposes both the new and > legacy register sets, accesses to

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v13 16/16] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2016-03-11 Thread Alexey Kardashevskiy
On 03/04/2016 03:51 PM, David Gibson wrote: On Tue, Mar 01, 2016 at 08:10:41PM +1100, Alexey Kardashevskiy wrote: This adds support for Dynamic DMA Windows (DDW) option defined by the SPAPR specification which allows to have additional DMA window(s) This implements DDW for emulated and VFIO dev

Re: [Qemu-devel] [PATCH v3 3/3] hw/arm: Add ASPEED AST2400 machine model

2016-03-11 Thread Peter Maydell
On 5 March 2016 at 11:29, Andrew Jeffery wrote: > Adds an AST2400 ARM machine[1], based around an AST2400 SOC containing an > ARM926 processor, ASPEED VIC and timer devices, and a 8250 UART. The new > machine type is functional enough to boot an aspeed_defconfig Linux > kernel to userspace. > > [1

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2016-03-11 Thread PeteVine
Another OS that works: https://static.redox-os.org/redox-installer.iso -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893208 Title: qemu on ARM hosts can't boot i386 image Status in QEMU: Confir

Re: [Qemu-devel] [PATCH v1] hw: fix error reporting for missing option ROMs

2016-03-11 Thread Daniel P. Berrange
On Thu, Mar 10, 2016 at 01:25:08PM -0700, Eric Blake wrote: > On 03/10/2016 10:28 AM, Daniel P. Berrange wrote: > > If QEMU fails to load any of the VGA ROMs, it prints a message > > to stderr and then carries on as if everything was fine, despite > > the VGA interface not being functional. This ex

Re: [Qemu-devel] Multi-threaded TCG Projects [GSoC 2016]

2016-03-11 Thread Alex Bennée
Subhashish Pradhan writes: > Hello again! > > I skimmed a bit through the recommended reading list; I would scan them > this weekend. I would also like to hack on and understand the code. Are > there any small tasks or bug reports that I can start with? > > I presume I would have to work with th

[Qemu-devel] [PATCH v2 1/2] postcopy: listen thread is never joined

2016-03-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We don't join the listen thread, it does its own cleanup. Mark as detached not joinable. Signed-off-by: Dr. David Alan Gilbert Reported-by: Paolo Bonzini Reviewed-by: Eric Blake --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v2 2/2] postcopy: Remove the x-

2016-03-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Postcopy seems to have survived a cycle with only a few fixes, and Jiri has the current libvirt wired up and working ( https://www.redhat.com/archives/libvir-list/2016-March/msg00080.html ) so remove the experimental tag. Signed-off-by: Dr. David Alan Gilbert Revi

[Qemu-devel] [PATCH v2 0/2] Postcopy fix and x- removal

2016-03-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This fix should go after Denis's use-after-free fix. The first one is a minor bug fix that Paolo spotted. The second removes the 'x-' experimental prefix now that things seem to be running OK, and Jiri has libvirt working with it. Dave v2 Update the 'since

[Qemu-devel] [PULL for-2.6 05/11] s390x/cpu: Add CPU property links

2016-03-11 Thread Cornelia Huck
From: Matthew Rosato Link each CPUState as property machine/cpu[n] during initialization. Add a hotplug handler to s390-virtio-ccw machine and set the state during plug. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand Message-Id: <1457112875-5209-6-git-send-email-mjros...@linux.vn

[Qemu-devel] [PULL for-2.6 03/11] s390x/cpu: Get rid of side effects when creating a vcpu

2016-03-11 Thread Cornelia Huck
From: Matthew Rosato In preparation for hotplug, defer some CPU initialization until the device is actually being realized, including cpu_exec_init. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand Message-Id: <1457112875-5209-4-git-send-email-mjros...@linux.vnet.ibm.com> Signed-of

[Qemu-devel] [PULL for-2.6 06/11] s390x/cpu: Add error handling to cpu creation

2016-03-11 Thread Cornelia Huck
From: Matthew Rosato Check for and propogate errors during s390 cpu creation. Signed-off-by: Matthew Rosato Message-Id: <1457112875-5209-7-git-send-email-mjros...@linux.vnet.ibm.com> Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio.c | 2 +- target-s390x/

[Qemu-devel] [PULL for-2.6 09/11] s390x: Introduce machine definition macros

2016-03-11 Thread Cornelia Huck
From: Janosch Frank Most of the machine definition code looks the same between different machine versions. The new DEFINE_CCW_MACHINE macro makes defining a new machine easier by inserting standard machine version definitions. This also makes it possible to propagate values between machine versio

[Qemu-devel] [PULL for-2.6 04/11] s390x/cpu: Tolerate max_cpus

2016-03-11 Thread Cornelia Huck
From: Matthew Rosato Once hotplug is enabled, interrupts may come in for CPUs with an address > smp_cpus. Allocate for this and allow search routines to look beyond smp_cpus. Signed-off-by: Matthew Rosato Message-Id: <1457112875-5209-5-git-send-email-mjros...@linux.vnet.ibm.com> Reviewed-by: D

[Qemu-devel] [PULL for-2.6 01/11] s390x/cpu: Cleanup init in preparation for hotplug

2016-03-11 Thread Cornelia Huck
From: Matthew Rosato Ensure a valid cpu_model is set upfront by setting the default value directly into the MachineState when none is specified. This is needed to ensure hotplugged CPUs share the same cpu_model. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand Message-Id: <1457112

[Qemu-devel] [PULL for-2.6 00/11] s390x patches for 2.6

2016-03-11 Thread Cornelia Huck
The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20160311

[Qemu-devel] [PULL for-2.6 02/11] s390x/cpu: Set initial CPU state in common routine

2016-03-11 Thread Cornelia Huck
From: Matthew Rosato Both initial and hotplugged CPUs need to set the same initial state. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand Message-Id: <1457112875-5209-3-git-send-email-mjros...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio.c | 4

[Qemu-devel] [PULL for-2.6 10/11] s390x: Introduce S390MachineClass

2016-03-11 Thread Cornelia Huck
From: Janosch Frank As we now have the new machine definitions, that let us disable/enable machine options more easily, we need a way to save them and make them publicly available. The new s390-virtio-ccw.h header exports the s390 ccw machine state and class, so they can be easily used in other

[Qemu-devel] [PULL for-2.6 08/11] pc-bios/s390-ccw: fix old bug in ptr increment

2016-03-11 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" We need to increment by the size of the structure, whereas 'ns' is 'uint8_t *'. Acked-by: Christian Borntraeger Acked-by: Cornelia Huck Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c | 2 +- 1 file chang

[Qemu-devel] [PULL for-2.6 11/11] s390x/cpu: use g_new0

2016-03-11 Thread Cornelia Huck
Let's use g_new0 to allocate cpu_states. Suggested-by: Thomas Huth Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c index 4ea9040..7c6e281 100644

[Qemu-devel] [PULL for-2.6 07/11] s390x/cpu: Allow hotplug of CPUs

2016-03-11 Thread Cornelia Huck
From: Matthew Rosato Implement cpu hotplug routine and add the machine hook. Signed-off-by: Matthew Rosato Reviewed-by: David Hildenbrand Message-Id: <1457112875-5209-8-git-send-email-mjros...@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 10 ++ ta

Re: [Qemu-devel] [PATCH] input-linux: switch over to -object

2016-03-11 Thread Paolo Bonzini
On 11/03/2016 08:38, Gerd Hoffmann wrote: > This patches makes input-linux use -object instead a new command line > switch. So, instead of the switch ... > > -input-linux /dev/input/event$nr > > ... you must create an object this way: > > -object input-linux,id=$name,evdev=/dev/input/

[Qemu-devel] [PULL v1 06/18] io: set correct error object in background reader test thread

2016-03-11 Thread Daniel P. Berrange
The reader thread was accidentally setting the error pointer intended for the writer thread. If both threads set errors this would result in QEMU abort'ing due to the error already being set. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/io-channel-helpers.c | 2 +- 1 f

[Qemu-devel] [PULL v1 05/18] io: wait for incoming client in socket test

2016-03-11 Thread Daniel P. Berrange
Exercise the GSource code for server sockets by calling qio_channel_wait() prior to accepting the incoming client. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/test-io-channel-socket.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test-io-channel-socket.c

[Qemu-devel] [PULL v1 00/18] Merge I/O channel fixes for Win32

2016-03-11 Thread Daniel P. Berrange
The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-io-win32-2016-03-11-1

[Qemu-devel] [PULL v1 02/18] io: use bind() to check for IPv4/6 availability

2016-03-11 Thread Daniel P. Berrange
Currently the test-io-channel-socket.c test uses getifaddrs to see if an IPv4/6 address is present on any host NIC, as a way to determine if IPv4/6 sockets can be used. This is problematic because getifaddrs is not available on Win32. Rather than testing indirectly via getifaddrs, just create a so

[Qemu-devel] [PULL v1 03/18] io: initialize sockets in test program

2016-03-11 Thread Daniel P. Berrange
The win32 sockets layer requires that socket_init() is called otherwise nothing will work. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/test-io-channel-socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-s

[Qemu-devel] [PULL v1 04/18] io: bind to socket before creating QIOChannelSocket

2016-03-11 Thread Daniel P. Berrange
In the QIOChannelSocket test we create a socket file descriptor and then try to create a QIOChannelSocket. This works on Linux, but fails on Win32 because it is not valid to call getsockname() on an unbound socket. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/test-io-c

[Qemu-devel] [PULL v1 01/18] osdep: fix socket_error() to work with Mingw64

2016-03-11 Thread Daniel P. Berrange
Historically QEMU has had a socket_error() macro that was defined to map to WSASocketError(). The os-win32.h header file would define errno constants that mapped to the WSA error constants. This worked fine with Mingw32 since its header files never defined any errno values, nor did it even provide

[Qemu-devel] [PULL v1 14/18] char: remove qemu_chr_finish_socket_connection method

2016-03-11 Thread Daniel P. Berrange
The qemu_chr_finish_socket_connection method is multiplexing two different actions into one method. Each caller of it though, only wants one specific action. The code is shorter & clearer if we thus remove the method and just inline the specific actions where needed. Signed-off-by: Daniel P. Berra

[Qemu-devel] [PULL v1 07/18] io: assert errors before asserting content in I/O test

2016-03-11 Thread Daniel P. Berrange
When checking the results of an I/O operation test, assert that the error objects are NULL before asserting on the content. This is found to give more useful indication of the problem when diagnosing test failures. Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- tests/io-channe

[Qemu-devel] [PULL v1 18/18] osdep: remove use of socket_error() from all code

2016-03-11 Thread Daniel P. Berrange
Now that QEMU wraps the Win32 sockets methods to automatically set errno upon failure, there is no reason for callers to use the socket_error() method. They can rely on accessing errno even on Win32. Remove all use of socket_error() from general code, leaving it as a static method in oslib-win32.c

[Qemu-devel] [PULL v1 15/18] char: remove socket_try_connect method

2016-03-11 Thread Daniel P. Berrange
The qemu_chr_open_socket_fd() method multiplexes three different actions into one method. The socket_try_connect() method is one of its callers, but it only ever want one specific action performed. By inlining that action into socket_try_connect() we see that there is not in fact any failure scenar

[Qemu-devel] [PULL v1 08/18] io: fix copy+paste mistake in socket error message

2016-03-11 Thread Daniel P. Berrange
s/write/read/ in the error message reported after readmsg() fails Reviewed-by: Paolo Bonzini Signed-off-by: Daniel P. Berrange --- io/channel-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/channel-socket.c b/io/channel-socket.c index bf66a78..5f087e6 100644 ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

2016-03-11 Thread Thomas Huth
On 10.03.2016 23:27, Cédric Le Goater wrote: > On 03/10/2016 07:01 PM, Thomas Huth wrote: >> On 09.03.2016 22:17, Thomas Huth wrote: >>> On 09.03.2016 21:04, Cédric Le Goater wrote: >> I have been maintaining a port of Ben's patchset on the latest qemu for other parts which sh

Re: [Qemu-devel] [PATCH v4 1/5] replay: character devices

2016-03-11 Thread Paolo Bonzini
On 11/03/2016 07:19, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 10/03/2016 12:55, Pavel Dovgalyuk wrote: >>> gdbstub which also acts as a backend is not recorded to allow controlling >>> the replaying through gdb. >> >> Perhaps the monitor too? > > Right. I'

[Qemu-devel] [PULL v1 10/18] io: introduce qio_channel_create_socket_watch

2016-03-11 Thread Daniel P. Berrange
From: Paolo Bonzini Sockets are not in the same namespace as file descriptors on Windows. As an initial step, introduce separate APIs for file descriptor and socket watches. Signed-off-by: Paolo Bonzini --- include/io/channel-watch.h | 20 +++- io/channel-socket.c| 6 +

[Qemu-devel] [PULL v1 09/18] io: pass HANDLE to g_source_add_poll on Win32

2016-03-11 Thread Daniel P. Berrange
From: Paolo Bonzini Reviewed-by: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- io/channel-watch.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/io/channel-watch.c b/io/channel-watch.c index 931fa4d..5373605 100644 --- a/io/channel-watch.c +++ b/io/cha

[Qemu-devel] [PULL v1 13/18] io: implement socket watch for win32 using WSAEventSelect+select

2016-03-11 Thread Daniel P. Berrange
From: Paolo Bonzini On Win32 we cannot directly poll on socket handles. Instead we create a Win32 event object and associate the socket handle with the event. When the event signals readyness we then have to use select to determine which events are ready. Creating Win32 events is moderately heavy

[Qemu-devel] [PULL v1 12/18] io: remove checking of EWOULDBLOCK

2016-03-11 Thread Daniel P. Berrange
Since we now canonicalize WSAEWOULDBLOCK into EAGAIN there is no longer any need to explicitly check EWOULDBLOCK for Win32. Signed-off-by: Daniel P. Berrange --- io/channel-command.c | 6 ++ io/channel-file.c| 6 ++ io/channel-socket.c | 6 ++ 3 files changed, 6 insertions(+), 1

[Qemu-devel] [PULL v1 11/18] io: use qemu_accept to ensure SOCK_CLOEXEC is set

2016-03-11 Thread Daniel P. Berrange
The QIOChannelSocket code mistakenly uses the bare accept() function which does not set SOCK_CLOEXEC. Signed-off-by: Daniel P. Berrange --- io/channel-socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io/channel-socket.c b/io/channel-socket.c index 775bb9f..9b5f2d8

[Qemu-devel] [PULL v1 16/18] char: remove qemu_chr_open_socket_fd method

2016-03-11 Thread Daniel P. Berrange
The qemu_chr_open_socket_fd method takes care of either doing a synchronous socket connect, or creating a listener socket. Part of the work when creating the listener socket is to register a watch for incoming clients. The caller of qemu_chr_open_socket_fd may not want this watch created, as it mig

[Qemu-devel] [PULL v1 17/18] osdep: add wrappers for socket functions

2016-03-11 Thread Daniel P. Berrange
The windows socket functions look identical to the normal POSIX sockets functions, but instead of setting errno, the caller needs to call WSAGetLastError(). QEMU has tried to deal with this incompatibility by defining a socket_error() method that callers must use that abstracts the difference betwe

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-11 Thread Jitendra Kolhe
On 3/11/2016 12:55 PM, Li, Liang Z wrote: On 3/10/2016 3:19 PM, Roman Kagan wrote: On Fri, Mar 04, 2016 at 02:32:47PM +0530, Jitendra Kolhe wrote: Even though the pages which are returned to the host by virtio-balloon driver are zero pages, the migration algorithm will still end up scanning the

Re: [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode

2016-03-11 Thread Paolo Bonzini
On 10/03/2016 10:40, Christian Borntraeger wrote: > On 03/10/2016 10:03 AM, Christian Borntraeger wrote: >> On 03/10/2016 02:51 AM, Fam Zheng wrote: >> [...] >>> The aio_poll() inside "blk_set_aio_context(s->conf->conf.blk, s->ctx)" looks >>> suspicious: >>> >>>main thread

Re: [Qemu-devel] [PATCH v2 4/5] spapr: check if cpu core is already present

2016-03-11 Thread Igor Mammedov
On Thu, 10 Mar 2016 20:15:23 +0530 Bharata B Rao wrote: > On Thu, Mar 10, 2016 at 11:39:46AM +0100, Igor Mammedov wrote: > > On Thu, 10 Mar 2016 11:32:44 +0530 > > Bharata B Rao wrote: > > > > > On Thu, Mar 10, 2016 at 04:22:43PM +1100, David Gibson wrote: > > > > On Wed, Mar 09, 2016 at 11

[Qemu-devel] [PATCH v16 1/8] unblock backup operations in backing file

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index 0e165f9..c78cf47 100644 --- a/block.c +++ b/block.c @@ -1273,6 +1273,24 @@ void bdrv_set_backing_hd(BlockDrive

[Qemu-devel] [PATCH v16 5/8] auto complete active commit

2016-03-11 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

[Qemu-devel] [PATCH v16 0/8] Block replication for continuous checkpoints

2016-03-11 Thread Changlong Xie
Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features/BlockReplication Usage: Please refer to docs/block-replication.txt This patch series is

[Qemu-devel] [PATCH v16 2/8] Backup: clear all bitmap when doing block checkpoint

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c| 15 +++ include/block/block_int.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/block/backup.c b/block/backup

[Qemu-devel] [PATCH v16 8/8] support replication driver in blockdev-add

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/q

[Qemu-devel] [PATCH v16 3/8] Link backup into block core

2016-03-11 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v16 4/8] docs: block replication's description

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 238 + 1 file changed, 238 insertions(+) create mode 100644 docs/block-replication.txt

[Qemu-devel] [PATCH v16 6/8] Introduce new APIs to do replication operation

2016-03-11 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 94 +++ replication.h| 175 +++

[Qemu-devel] [PATCH v16 7/8] Implement new driver for block replication

2016-03-11 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 619 2 files changed, 620 insertions(+) create mode 100

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-11 Thread Li, Liang Z
> >>> I wonder if it is the scanning for zeros or sending the whiteout > >>> which affects the total migration time more. If it is the former > >>> (as I would > >>> expect) then a rather local change to is_zero_range() to make use of > >>> the mapping information before scanning would get you all

Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah

2016-03-11 Thread Stefan Hajnoczi
On Fri, Mar 11, 2016 at 01:00:09AM +0530, rutu.shah...@gmail.com wrote: > From: Rutuja Shah Hi Rutuja, In addition to the commit message/description issue that Eric raised, please use scripts/checkpatch.pl to check if your changes cause lines to exceed 80 characters. QEMU coding style is 80 char

Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-03-11 Thread alvise rigo
Hi Paolo, On Mon, Mar 7, 2016 at 10:18 PM, Paolo Bonzini wrote: > > > On 04/03/2016 15:28, alvise rigo wrote: >> A small update on this. I have a working implementation of the "halted >> state" mechanism for waiting all the pending flushes to be completed. >> However, the way I'm going back to th

[Qemu-devel] [PATCH v2] hw: fix error reporting for missing option ROMs

2016-03-11 Thread Daniel P. Berrange
If QEMU fails to load any of the VGA ROMs, it prints a message to stderr and then carries on as if everything was fine, despite the VGA interface not being functional. This extends the the various rom_add_*() methods in loader.h to accept a 'Error **errp' parameter. The VGA device realizefn() impls

Re: [Qemu-devel] [RFC PATCH v2 1/9] exec: Remove cpu from cpus list during cpu_exec_exit()

2016-03-11 Thread Thomas Huth
On 11.03.2016 05:54, Bharata B Rao wrote: > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It > should be removed from cpu_exec_exit(). > > cpu_exec_exit() is called from generic CPU::instance_finalize and some > archs like PowerPC call it from CPU unrealizefn. So ensure that we

Re: [Qemu-devel] [RFC PATCH v2 2/9] exec: Do vmstate unregistration from cpu_exec_exit()

2016-03-11 Thread Thomas Huth
On 11.03.2016 05:54, Bharata B Rao wrote: > cpu_exec_init() does vmstate_register for the CPU device. This needs to be > undone from cpu_exec_exit(). This change is needed to support CPU hot > removal. > > Signed-off-by: Bharata B Rao > --- > exec.c | 9 + > 1 file changed, 9 insertions(

[Qemu-devel] [Bug 1556044] [NEW] Redox GUI hangs with 100% CPU

2016-03-11 Thread PeteVine
Public bug reported: Booting into Redox OS cli on ARM with qemu-system-i386 works fine. However, starting the Redox GUI (orbital) brings up the graphical interface and then starts using 100% CPU. I'd guess it's related to mouse detection and handling. The OS image is fully usable on x86. https:

Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah

2016-03-11 Thread Christian Borntraeger
On 03/10/2016 08:30 PM, rutu.shah...@gmail.com wrote: > From: Rutuja Shah [...] > -s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec(); > +s->tick_offset_vmstate = s->tick_offset + delta / NANOSECONDS_PER_SECOND; [...] While technically correct, I do not like these chang

Re: [Qemu-devel] [RFC PATCH v2 3/9] cpu: Reclaim vCPU objects

2016-03-11 Thread Thomas Huth
On 11.03.2016 05:54, Bharata B Rao wrote: > From: Gu Zheng > > In order to deal well with the kvm vcpus (which can not be removed without any > protection), we do not close KVM vcpu fd, just record and mark it as stopped > into a list, so that we can reuse it for the appending cpu hot-add request

Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah

2016-03-11 Thread Paolo Bonzini
On 11/03/2016 12:44, Christian Borntraeger wrote: >> -s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec(); >> > +s->tick_offset_vmstate = s->tick_offset + delta / >> > NANOSECONDS_PER_SECOND; > [...] > > While technically correct, I do not like these changes. The inter

Re: [Qemu-devel] Multi-threaded TCG Projects [GSoC 2016]

2016-03-11 Thread Subhashish Pradhan
Hello again! I skimmed a bit through the recommended reading list; I would scan them this weekend. I would also like to hack on and understand the code. Are there any small tasks or bug reports that I can start with? I presume I would have to work with these[1] source repositories not the main qe

Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah

2016-03-11 Thread Christian Borntraeger
On 03/11/2016 01:07 PM, Paolo Bonzini wrote: > > > On 11/03/2016 12:44, Christian Borntraeger wrote: >>> -s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec(); +s->tick_offset_vmstate = s->tick_offset + delta / NANOSECONDS_PER_SECOND; >> [...] >> >> While techn

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-11 Thread Alberto Garcia
On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: > @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { > bool rewrite_corrupted;/* true if the driver must rewrite-on-read > corrupted > * block if Quorum is reached. > */ > +u

Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah

2016-03-11 Thread Paolo Bonzini
On 11/03/2016 13:12, Christian Borntraeger wrote: > On 03/11/2016 01:07 PM, Paolo Bonzini wrote: >> >> >> On 11/03/2016 12:44, Christian Borntraeger wrote: -s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec(); > +s->tick_offset_vmstate = s->tick_offset + delta /

[Qemu-devel] [PULL 0/4] migration fixes

2016-03-11 Thread Amit Shah
The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git ta

[Qemu-devel] [PULL 1/4] migration: fix warning for source_return_path_thread

2016-03-11 Thread Amit Shah
From: Peter Xu max_len is not necessary, while it brings a warning during compilation when specify "-Wstack-usage=100". Replacing using sizeof(). Signed-off-by: Peter Xu Message-Id: <1457503932-31763-1-git-send-email-pet...@redhat.com> Signed-off-by: Amit Shah --- migration/migration.c |

[Qemu-devel] [PULL 4/4] postcopy: Remove the x-

2016-03-11 Thread Amit Shah
From: "Dr. David Alan Gilbert" Postcopy seems to have survived a cycle with only a few fixes, and Jiri has the current libvirt wired up and working ( https://www.redhat.com/archives/libvir-list/2016-March/msg00080.html ) so remove the experimental tag. Signed-off-by: Dr. David Alan Gilbert Revi

[Qemu-devel] [PULL 2/4] migration: fix use-after-free in loadvm_postcopy_handle_run_bh

2016-03-11 Thread Amit Shah
From: "Denis V. Lunev" MigrationState is destroyed before we can come into bottom half. Signed-off-by: Denis V. Lunev Reviewed-by: Dr. David Alan Gilbert CC: Juan Quintela CC: Amit Shah CC: Dr. David Alan Gilbert Message-Id: <1457537708-8622-1-git-send-email-...@openvz.org> Signed-off-by: A

[Qemu-devel] [PULL 3/4] postcopy: listen thread is never joined

2016-03-11 Thread Amit Shah
From: "Dr. David Alan Gilbert" We don't join the listen thread, it does its own cleanup. Mark as detached not joinable. Signed-off-by: Dr. David Alan Gilbert Reported-by: Paolo Bonzini Reviewed-by: Eric Blake Message-Id: <1457690016-9070-2-git-send-email-dgilb...@redhat.com> Signed-off-by: Am

Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] quorum: Fix crash in quorum_aio_cb()

2016-03-11 Thread Max Reitz
On 10.03.2016 11:10, Alberto Garcia wrote: > On Wed 09 Mar 2016 05:54:55 PM CET, Max Reitz wrote: >> On 09.03.2016 17:11, Alberto Garcia wrote: >>> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's >>> an I/O error in a Quorum child. However sacb->aiocb must be >>> correctly initialized

Re: [Qemu-devel] [PATCH v12 3/3] qmp: add monitor command to add/remove a child

2016-03-11 Thread Alberto Garcia
On Thu 10 Mar 2016 03:49:41 AM CET, Changlong Xie wrote: > From: Wen Congyang > > The new QMP command name is x-blockdev-change. It's just for adding/removing > quorum's child now, and doesn't support all kinds of children, all kinds of > operations, nor all block drivers. So it is experimental no

Re: [Qemu-devel] [V6 2/4] hw/core: Add AMD IOMMU to machine properties

2016-03-11 Thread Michael S. Tsirkin
On Sun, Feb 21, 2016 at 09:10:58PM +0300, David Kiarie wrote: > Add IOMMU as a string to machine properties which is > used to control whether and the type of IOMMU to emulate > > Signed-off-by: David Kiarie > --- > hw/core/machine.c | 28 > include/hw/boards.h |

Re: [Qemu-devel] [V6 4/4] hw/pci-host: Emulate AMD IOMMU

2016-03-11 Thread Michael S. Tsirkin
On Sun, Feb 21, 2016 at 09:11:00PM +0300, David Kiarie wrote: > Add AMD IOMMU emulation support to q35 chipset > > Signed-off-by: David Kiarie > --- > hw/pci-host/piix.c| 1 + > hw/pci-host/q35.c | 14 -- > include/hw/i386/intel_iommu.h | 1 + > 3 files chan

Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah

2016-03-11 Thread Christian Borntraeger
On 03/11/2016 01:26 PM, Paolo Bonzini wrote: > > > On 11/03/2016 13:12, Christian Borntraeger wrote: >> On 03/11/2016 01:07 PM, Paolo Bonzini wrote: >>> >>> >>> On 11/03/2016 12:44, Christian Borntraeger wrote: > -s->tick_offset_vmstate = s->tick_offset + delta / > get_ticks_per_sec(

Re: [Qemu-devel] [PATCH] pc: acpi: remove AML for empty/not used GPE handlers

2016-03-11 Thread Michael S. Tsirkin
On Thu, Mar 03, 2016 at 02:56:35PM +0100, Igor Mammedov wrote: > ACPI spec requires GPE handlers only for GPE events > that hardware implements. > So remove AML for not supported by QEMU device model > events. > > Signed-off-by: Igor Mammedov Looks valid but is guest visible. Repost after the re

Re: [Qemu-devel] [PATCH v4 01/10] tests: pc: acpi: piix4: add sparse CPU hotplug case

2016-03-11 Thread Michael S. Tsirkin
On Fri, Feb 26, 2016 at 02:59:19PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Seems to give warnings likely because expected files changed upstream. I skipped this patch in series, pls rebase it. We also really need to find a better way to test this than just adding more variant

Re: [Qemu-devel] [PATCH v4 06/15] block: Hide HBitmap in block dirty bitmap interface

2016-03-11 Thread Max Reitz
On 08.03.2016 05:44, Fam Zheng wrote: > HBitmap is an implementation detail of block dirty bitmap that should be > hidden > from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying > HBitmapIter. > > A small difference in the interface is, before, an HBitmapIter is initialized >

Re: [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work

2016-03-11 Thread Max Reitz
On 08.03.2016 05:44, Fam Zheng wrote: > v4: Rebase. > Add rev-by from John in patches 1-5, 7, 8. > Remove BdrvDirtyBitmap typedef from dirty-bitmap.h in patch 4. [Max] > Add assertion on bm->meta in patch 9. [John] > > Two major features are added to block dirty bitmap (and underlying

Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay

2016-03-11 Thread Stefan Hajnoczi
On Thu, Mar 10, 2016 at 02:56:20PM +0300, Pavel Dovgalyuk wrote: > @@ -135,7 +138,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind, > > void replay_bh_schedule_event(QEMUBH *bh) > { > -if (replay_mode != REPLAY_MODE_NONE) { > +if (replay_mode != REPLAY_MODE_NONE && events_enab

Re: [Qemu-devel] [PATCH v4 5/5] replay: introduce block devices record/replay

2016-03-11 Thread Stefan Hajnoczi
On Thu, Mar 10, 2016 at 02:56:20PM +0300, Pavel Dovgalyuk wrote: > +static void block_request_create(uint64_t reqid, BlockDriverState *bs, > + Coroutine *co) > +{ > +Request *req = g_new(Request, 1); > +*req = (Request) { > +.co = co, > +.bh =

Re: [Qemu-devel] Memory on stellaris board

2016-03-11 Thread Aurelio Remonda
I don't quite understand what you mean with non-round-number, are you suggesting we only accept for example: 64K-128K-256K-512K-1024k(or 1M)-2048K(or 2M) 4096K(or 4M)-8192K(or 8M)-16384K(or 16M) If that's the case we will never have, for example, the exact default dc0 value (0x00ff007f) because you

[Qemu-devel] [PATCH] iotests: Correct 081's reference output

2016-03-11 Thread Max Reitz
The newly added type parameter for the QUORUM_REPORT_BAD event changed the output of iotest 081, so the reference should be amended accordingly. Signed-off-by: Max Reitz --- tests/qemu-iotests/081.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/081.out

[Qemu-devel] [Bug 1556044] Re: Redox GUI hangs with 100% CPU on ARM

2016-03-11 Thread PeteVine
** Summary changed: - Redox GUI hangs with 100% CPU + Redox GUI hangs with 100% CPU on ARM -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1556044 Title: Redox GUI hangs with 100% CPU on ARM Status

Re: [Qemu-devel] [PATCH] iotests: Correct 081's reference output

2016-03-11 Thread Alberto Garcia
On Fri 11 Mar 2016 03:14:47 PM CET, Max Reitz wrote: > The newly added type parameter for the QUORUM_REPORT_BAD event changed > the output of iotest 081, so the reference should be amended > accordingly. > > Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

2016-03-11 Thread Cédric Le Goater
On 03/11/2016 11:04 AM, Thomas Huth wrote: > On 10.03.2016 23:27, Cédric Le Goater wrote: >> On 03/10/2016 07:01 PM, Thomas Huth wrote: >>> On 09.03.2016 22:17, Thomas Huth wrote: On 09.03.2016 21:04, Cédric Le Goater wrote: >>> > I have been maintaining a port of Ben's patchset on th

Re: [Qemu-devel] [PATCH v4 06/15] block: Hide HBitmap in block dirty bitmap interface

2016-03-11 Thread Max Reitz
On 11.03.2016 14:54, Max Reitz wrote: > On 08.03.2016 05:44, Fam Zheng wrote: >> HBitmap is an implementation detail of block dirty bitmap that should be >> hidden >> from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying >> HBitmapIter. >> >> A small difference in the interface

Re: [Qemu-devel] [PATCH] input-linux: switch over to -object

2016-03-11 Thread Kashyap Chamarthy
On Fri, Mar 11, 2016 at 11:01:28AM +0100, Paolo Bonzini wrote: > > > On 11/03/2016 08:38, Gerd Hoffmann wrote: > > This patches makes input-linux use -object instead a new command line Nit: s/instead a/instead of a/ [If you want to fix up when you apply.] > > switch. So, instead of the switch

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-11 Thread Jitendra Kolhe
On 3/11/2016 4:24 PM, Li, Liang Z wrote: I wonder if it is the scanning for zeros or sending the whiteout which affects the total migration time more. If it is the former (as I would expect) then a rather local change to is_zero_range() to make use of the mapping information before scanning woul

Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs

2016-03-11 Thread Thomas Huth
On 11.03.2016 15:22, Cédric Le Goater wrote: > On 03/11/2016 11:04 AM, Thomas Huth wrote: >> On 10.03.2016 23:27, Cédric Le Goater wrote: >>> On 03/10/2016 07:01 PM, Thomas Huth wrote: On 09.03.2016 22:17, Thomas Huth wrote: > On 09.03.2016 21:04, Cédric Le Goater wrote: >> I

  1   2   3   >