On 10.03.2016 11:10, Alberto Garcia wrote: > On Wed 09 Mar 2016 05:54:55 PM CET, Max Reitz <mre...@redhat.com> wrote: >> On 09.03.2016 17:11, Alberto Garcia wrote: >>> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's >>> an I/O error in a Quorum child. However sacb->aiocb must be >>> correctly initialized for this to happen. read_quorum_children() and >>> read_fifo_child() are not doing this, which results in a QEMU crash. >>> >>> Signed-off-by: Alberto Garcia <be...@igalia.com> >>> --- >>> block/quorum.c | 12 +++++++----- >>> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> Reviewed-by: Max Reitz <mre...@redhat.com> >> >> Although I'm wondering whether we could have just used acb->common.bs >> instead of sacb->aiocb->bs in quorum_aio_cb(). I guess that >> sacb->aiocb is supposed to be equal to &acb->common. > > acb->common.bs is the Quorum BDS, sacb->aiocb->bs is the child BDS.
You're right, thanks for explaining. Max
signature.asc
Description: OpenPGP digital signature
