Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal

2016-03-08 Thread Janosch Frank
On 03/07/2016 05:35 PM, Janosch Frank wrote: > On 03/07/2016 10:17 AM, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> >> --- >> >> This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or >> squashed into it if we want strict synchronization). >> --- >> scripts/dump-guest-memory.p

[Qemu-devel] [PULL V2 09/12] rocker: allow user to specify rocker world by property

2016-03-08 Thread Jason Wang
From: Jiri Pirko Add property to specify rocker world. All ports will be assigned to this world. Signed-off-by: Jiri Pirko Signed-off-by: Jason Wang --- hw/net/rocker/rocker.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/hw/net/rocker/rocke

[Qemu-devel] [PULL V2 12/12] net: check packet payload length

2016-03-08 Thread Jason Wang
From: Prasad J Pandit While computing IP checksum, 'net_checksum_calculate' reads payload length from the packet. It could exceed the given 'data' buffer size. Add a check to avoid it. Reported-by: Liu Ling Signed-off-by: Prasad J Pandit Signed-off-by: Jason Wang --- net/checksum.c | 10

Re: [Qemu-devel] [PATCH] net/filter: rename qemu_netfilter_pass_to_next() to qemu_netfilter_iterate()

2016-03-08 Thread Yang Hongyang
Hi Chen, What's the motivation that you want to change this name? The function actually is not intent to iterate every filter. On Mon, Mar 7, 2016 at 6:03 PM, Zhang Chen wrote: > This API will iterate the filters attached to netdev > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang

Re: [Qemu-devel] [PATCH v2] vfio/igd: handle q35 machine type

2016-03-08 Thread Gerd Hoffmann
On Mo, 2016-03-07 at 14:41 -0700, Alex Williamson wrote: > On Fri, 4 Mar 2016 09:41:53 +0100 > Gerd Hoffmann wrote: > > > Basically skip the lpc quirks with -M q35. > > Applies on top of the vfio-igd patch series by alex. > > > > Signed-off-by: Gerd Hoffmann > > --- > > hw/vfio/pci-quirks.c |

Re: [Qemu-devel] [PATCH 6/8] usb: fix unbounded stack for usb_mtp_add_str

2016-03-08 Thread Gerd Hoffmann
> static void usb_mtp_add_str(MTPData *data, const char *str) > { > +#define __WSTR_LEN (256) > uint32_t len = strlen(str)+1; > -wchar_t wstr[len]; > +wchar_t wstr[__WSTR_LEN]; I think we should g_malloc() here. cheers, Gerd

Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict

2016-03-08 Thread Markus Armbruster
Peter Xu writes: > Suggested-by: Paolo Bonzini > CC: Markus Armbruster > CC: Kevin Wolf > CC: qemu-bl...@nongnu.org > Signed-off-by: Peter Xu > --- > block/qapi.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/block/qapi.c b/block/qapi.c > index db2d3fb..687e577

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Markus Armbruster
Cc: Kevin, because he added the array in question. Peter Xu writes: > Suggested-by: Paolo Bonzini > CC: Luiz Capitulino > Signed-off-by: Peter Xu > --- > qobject/qdict.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/qobject/qdict.c b/qobject/qdict.c

[Qemu-devel] [PATCH v2 1/3] vmdk: Switch to heap arrays for vmdk_write_cid

2016-03-08 Thread Fam Zheng
It is only called once for each opened image, so we can do it the easy way. Reviewed-by: Peter Xu Signed-off-by: Fam Zheng --- block/vmdk.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index a8db5d9..1ec2452 100644 -

[Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

2016-03-08 Thread Fam Zheng
All three functions are not in hot path (all run once for the BDS lifecycle), so it's okay to convert to g_malloc0. Fam Fam Zheng (3): vmdk: Switch to heap arrays for vmdk_write_cid vmdk: Switch to heap arrays for vmdk_read_cid vmdk: Switch to heap arrays for vmdk_parent_open block/vmdk.

[Qemu-devel] [PATCH v2 3/3] vmdk: Switch to heap arrays for vmdk_parent_open

2016-03-08 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/vmdk.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index c68f456..03be7f0 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -343,15 +343,16 @@ static int vmdk_reopen_prepare(BDRVReopenState *st

[Qemu-devel] [PATCH v2 2/3] vmdk: Switch to heap arrays for vmdk_read_cid

2016-03-08 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/vmdk.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 1ec2452..c68f456 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -242,15 +242,17 @@ static void vmdk_free_last_extent(BlockDriverState *bs) static

Re: [Qemu-devel] [PATCH] qapi-visit: Honor prefix of discriminator enum

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > On 02/17/2016 05:05 AM, Markus Armbruster wrote: >> Let's check for completeness. Calls of c_enum_const(): >> >> * QAPISchemaEnumType.c_null() and (with your patch) gen_visit_union() >> call it like >> >> c_enum_const(TYPE.name, MEMBER, TYPE.prefix) >> >> where ME

Re: [Qemu-devel] [PATCHv2 1/3] target-ppc: Split out SREGS get/put functions

2016-03-08 Thread Greg Kurz
On Tue, 8 Mar 2016 11:37:02 +1100 David Gibson wrote: > On Mon, Mar 07, 2016 at 01:26:24PM +1100, David Gibson wrote: > > Currently the getting and setting of Power MMU registers (sregs) take up > > large inline chunks of the kvm_arch_get_registers() and > > kvm_arch_put_registers() functions. E

Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict

2016-03-08 Thread Fam Zheng
On Tue, 03/08 09:12, Markus Armbruster wrote: > Peter Xu writes: > > > Suggested-by: Paolo Bonzini > > CC: Markus Armbruster > > CC: Kevin Wolf > > CC: qemu-bl...@nongnu.org > > Signed-off-by: Peter Xu > > --- > > block/qapi.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-08 Thread Samuel Thibault
Jason Wang, on Tue 08 Mar 2016 10:48:27 +0800, wrote: > ./scripts/checkpatch.pl > 0001-slirp-Adding-IPv6-ICMPv6-Echo-and-NDP-autoconfigurat.patch > ERROR: return is not a function, parentheses are not required > #177: FILE: slirp/ip6.h:65: > +return (a->s6_addr[prefix_len / 8] & ((1U << (8 - (p

Re: [Qemu-devel] [PATCH] scripts: Fix dump-guest-memory.py for MemoryRegion.ram_block removal

2016-03-08 Thread Fam Zheng
On Tue, 03/08 08:54, Janosch Frank wrote: > On 03/07/2016 05:35 PM, Janosch Frank wrote: > > On 03/07/2016 10:17 AM, Fam Zheng wrote: > >> Signed-off-by: Fam Zheng > >> > >> --- > >> > >> This goes after "[PATCH v2 4/7] memory: Drop MemoryRegion.ram_addr" (or > >> squashed into it if we want stric

Re: [Qemu-devel] [PATCH V2] hw/acpi: fix Q35 support for legacy Windows OS

2016-03-08 Thread Igor Mammedov
On Mon, 7 Mar 2016 21:14:37 +0200 Marcel Apfelbaum wrote: > Legacy Windows operating systems like Windows XP and Windows 2003 > require _DIS method to be present for all interrupt links. > > PC machines already have a no-op implemented for GSI links, add > it also in Q35. > > Signed-off-by: Ma

Re: [Qemu-devel] [PULL 00/14] Net patches

2016-03-08 Thread Zhang Chen
On 03/08/2016 03:56 PM, Jason Wang wrote: On 03/08/2016 03:50 PM, Wen Congyang wrote: On 03/08/2016 03:33 PM, Jason Wang wrote: On 03/08/2016 12:51 PM, Peter Maydell wrote: On 7 March 2016 at 10:12, Jason Wang wrote: The following changes since commit 1464ad45cd6cdeb0b5c1a54d3d3791396e47e

Re: [Qemu-devel] [PATCH v5 5/5] nvdimm acpi: add _CRS

2016-03-08 Thread Igor Mammedov
On Mon, 7 Mar 2016 18:19:46 +0200 "Michael S. Tsirkin" wrote: > On Mon, Mar 07, 2016 at 05:17:19PM +0100, Igor Mammedov wrote: > > > > So what would happen when PCI MMIO BAR would be mapped over above range, > > > > since guest thinks it's free to use it as unused resource? > > > > > > IIRC,

Re: [Qemu-devel] [RFC PATCH v1 05/10] cpu: Abstract CPU core type

2016-03-08 Thread Igor Mammedov
On Tue, 8 Mar 2016 14:57:10 +1100 David Gibson wrote: > On Mon, Mar 07, 2016 at 11:40:11AM +0100, Igor Mammedov wrote: > > On Mon, 7 Mar 2016 14:01:55 +0530 > > Bharata B Rao wrote: > > > > > On Mon, Mar 07, 2016 at 02:36:55PM +1100, David Gibson wrote: > > > > On Fri, Mar 04, 2016 at 07:07

Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-08 Thread Samuel Thibault
Jason Wang, on Tue 08 Mar 2016 10:15:57 +0800, wrote: > Build works but get some warnings: > > > slirp/ip6_icmp.c: In function 'icmp6_send_error': > slirp/ip6_icmp.c:84:5: warning: implicit declaration of function > 'inet_ntop' [-Wimplicit-function-declaration] > inet_ntop(AF_INET6, &rip->ip

Re: [Qemu-devel] [PULL 00/14] Net patches

2016-03-08 Thread Wen Congyang
On 03/08/2016 05:06 PM, Zhang Chen wrote: > > > On 03/08/2016 03:56 PM, Jason Wang wrote: >> >> On 03/08/2016 03:50 PM, Wen Congyang wrote: >>> On 03/08/2016 03:33 PM, Jason Wang wrote: On 03/08/2016 12:51 PM, Peter Maydell wrote: > On 7 March 2016 at 10:12, Jason Wang wrote: >> The

Re: [Qemu-devel] [RFC PATCH] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-08 Thread Michael S. Tsirkin
On Mon, Mar 07, 2016 at 04:02:15PM -0800, Greg KH wrote: > On Mon, Mar 07, 2016 at 06:55:43PM -0500, Gabriel Somlo wrote: > > Allowing for the future possibility of implementing AML-based > > (i.e., firmware-triggered) access to the QEMU fw_cfg device, > > acquire the global ACPI lock when accessin

Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict

2016-03-08 Thread Peter Xu
On Tue, Mar 08, 2016 at 09:12:45AM +0100, Markus Armbruster wrote: > Peter Xu writes: > > const char *format = composite ? "%*s%s:\n" : "%*s%s: "; > > Unrelated to your patch: ugh! > > Printf formats should be literals whenever possible, to make it easy for > the compiler to warn you wh

Re: [Qemu-devel] [RFC PATCH v1 08/10] spapr: CPU hotplug support

2016-03-08 Thread Igor Mammedov
On Tue, 8 Mar 2016 15:27:39 +1100 David Gibson wrote: > On Mon, Mar 07, 2016 at 11:59:42AM +0530, Bharata B Rao wrote: > > On Mon, Mar 07, 2016 at 02:49:06PM +1100, David Gibson wrote: > > > On Fri, Mar 04, 2016 at 12:24:19PM +0530, Bharata B Rao wrote: > > > > Set up device tree entries for

Re: [Qemu-devel] [PATCH] vmdk: Create streamOptimized as version 3

2016-03-08 Thread Radoslav Gerganov
On 17.09.2015 08:04, Fam Zheng wrote: > VMware products accept only version 3 for streamOptimized, let's bump > the version. > > Reported-by: Radoslav Gerganov > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Hi Fam, I am really so

Re: [Qemu-devel] [PATCH v2] ui/console: add escape sequence \e[5, 6n

2016-03-08 Thread Gerd Hoffmann
> +static void console_respond_str(QemuConsole *s, const char *buf) > +{ > +TextCell *c; > +int y1; > +while (*buf) { > +if (s->x >= s->width) { > +s->x = 0; > +console_put_lf(s); > +} > +y1 = (s->y_base + s->y) % s->total_height; > +

Re: [Qemu-devel] [PATCH] vnc: send cursor when a new client is connecting

2016-03-08 Thread Gerd Hoffmann
On Mi, 2016-03-02 at 14:32 +, Frediano Ziglio wrote: > If you have hardware cursor and you are reconnecting the VNC client > you need to send the cursor. Failing to do so make the cursor invisible > till is changed. > > Signed-off-by: Frediano Ziglio added to ui patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 7/8] migration: fix unbounded stack for source_return_path_thread

2016-03-08 Thread Juan Quintela
Peter Xu wrote: > Suggested-by: Paolo Bonzini > CC: Juan Quintela > CC: Amit Shah > Signed-off-by: Peter Xu > --- > migration/migration.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index 0129d9f..f1a3976 1006

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix snapshot=on cache modes

2016-03-08 Thread Kevin Wolf
Am 07.03.2016 um 19:24 hat Max Reitz geschrieben: > On 07.03.2016 13:26, Kevin Wolf wrote: > > Since commit 91a097e, we end up with a somewhat weird cache mode > > configuration with snapshot=on: The commit broke the cache mode > > inheritance for the snapshot overlay so that it is opened as > > wr

Re: [Qemu-devel] [PATCH v2 00/13] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-03-08 Thread Jason Wang
On 02/23/2016 01:37 AM, Leonid Bloch wrote: > Hello All, > > This is v2 of the patches, after the initial reviews. > > For convenience, the same patches are available at: > https://github.com/daynix/qemu-e1000e/tree/e1000e-submit-v2 > > Best regards, > Leonid. Btw, I've had some basic testing on

Re: [Qemu-devel] [Qemu-block] [PATCH] qed: fix bdrv_qed_drain

2016-03-08 Thread Stefan Hajnoczi
On Mon, Mar 07, 2016 at 10:22:58PM +0100, Paolo Bonzini wrote: > On 07/03/2016 21:56, Stefan Hajnoczi wrote: > > I think the timer concept itself is troublesome. A radical approach but > > limited to changing QED itself is to drop the timer and instead keep a > > timestamp for the last allocating

Re: [Qemu-devel] [PULL 00/14] Net patches

2016-03-08 Thread Peter Maydell
On 8 March 2016 at 16:06, Zhang Chen wrote: > I found the reason for this problem is that > unix_connect() have not connect to sock_path before iov_send(). > It need time to establish connection. so can we fix it with usleep() > like this: > > recv_sock = unix_connect(sock_path, NULL); > g

Re: [Qemu-devel] [Qemu-block] [PATCH] qed: fix bdrv_qed_drain

2016-03-08 Thread Kevin Wolf
Am 07.03.2016 um 21:56 hat Stefan Hajnoczi geschrieben: > On Mon, Mar 07, 2016 at 05:57:41PM +0100, Kevin Wolf wrote: > > Am 23.02.2016 um 14:54 hat Paolo Bonzini geschrieben: > > > > > > > > > On 23/02/2016 13:49, Fam Zheng wrote: > > > > On Tue, 02/23 11:43, Paolo Bonzini wrote: > > > >> > > >

Re: [Qemu-devel] [Qemu-block] [PATCH] qed: fix bdrv_qed_drain

2016-03-08 Thread Kevin Wolf
Am 08.03.2016 um 10:52 hat Stefan Hajnoczi geschrieben: > On Mon, Mar 07, 2016 at 10:22:58PM +0100, Paolo Bonzini wrote: > > On 07/03/2016 21:56, Stefan Hajnoczi wrote: > > > I think the timer concept itself is troublesome. A radical approach but > > > limited to changing QED itself is to drop the

Re: [Qemu-devel] [PATCH v2] ui/console: add escape sequence \e[5, 6n

2016-03-08 Thread Ren Kimura
Thank you for review. OK I'll change these and send version3 later. Ren 2016-03-08 18:40 GMT+09:00 Gerd Hoffmann : > > +static void console_respond_str(QemuConsole *s, const char *buf) > > +{ > > +TextCell *c; > > +int y1; > > +while (*buf) { > > > +if (s->x >= s->width) { >

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2016-03-08 Thread Samuel Thibault
From: Samuel Thibault Signed-off-by: Samuel Thibault --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2f5a338..a316bc3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1217,6 +1217,7 @@ F: scripts/qmp/ T: git git://repo.or.cz/qemu/armbru.git qap

[Qemu-devel] [PULL] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2016-03-08 Thread Samuel Thibault
The following changes since commit 1464ad45cd6cdeb0b5c1a54d3d3791396e47e52f: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-04' into staging (2016-03-06 11:53:27 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thib

Re: [Qemu-devel] strange crash in tracked_request_begin

2016-03-08 Thread Stefan Hajnoczi
On Mon, Mar 07, 2016 at 08:00:49PM +0100, Christian Borntraeger wrote: > On 03/07/2016 06:01 PM, Stefan Hajnoczi wrote: > > On Mon, Mar 07, 2016 at 01:29:08PM +0100, Christian Borntraeger wrote: > >> Folks, > >> > >> I had a crash of a qemu guest in tracked_request_begin. > >> The testcase was a gu

[Qemu-devel] [PATCH] Revert "qed: Implement .bdrv_drain"

2016-03-08 Thread Stefan Hajnoczi
This reverts commit df9a681dc9ad41c9cdeb9ecc5d060ba9abd27e01. Note that commit df9a681dc9ad41c9cdeb9ecc5d060ba9abd27e01 included some unrelated hunks, possibly due to a merge failure or an overlooked squash. This only reverts the qed .bdrv_drain() implementation. The qed .bdrv_drain() implementa

Re: [Qemu-devel] [PATCH v4 01/10] qapi: Assert in places where variants are not handled

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > We are getting closer to the point where we could use one union > as the base or variant type within another union type (as long > as there are no collisions between any possible combination of > member names allowed across all discriminator choices). But > until we get to t

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Kevin Wolf
Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: > Cc: Kevin, because he added the array in question. > > Peter Xu writes: > > > Suggested-by: Paolo Bonzini > > CC: Luiz Capitulino > > Signed-off-by: Peter Xu > > --- > > qobject/qdict.c | 15 +-- > > 1 file changed, 9 in

Re: [Qemu-devel] [PATCH 6/7] target-tricore: Add cmp.f instruction

2016-03-08 Thread Bastian Koppelmann
On 03/01/2016 07:21 PM, Richard Henderson wrote: > On 03/01/2016 08:24 AM, Bastian Koppelmann wrote: >> + >> +lt = float32_lt_quiet(arg1, arg2, &env->fp_status); >> +eq = float32_eq_quiet(arg1, arg2, &env->fp_status); >> +uo = float32_unordered(arg1, arg2, &env->fp_status); > > Do it i

[Qemu-devel] [PATCHv10 03/11] slirp: Adding ICMPv6 error sending

2016-03-08 Thread Samuel Thibault
From: Yann Bordenave Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a received packet is too big, or when its hop limit is 0. Signed-off-by: Yann Bordenave Signed-off-by: Samue

[Qemu-devel] [PATCHv10 0/11] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-08 Thread Samuel Thibault
Hello, This is another respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add TFTP over IPv6. Difference with version 9 is: - split icmp error patch in two - fix sending icmp6 errors on unreachable net or host - forbidding prefix le

[Qemu-devel] [PATCHv10 11/11] slirp: Add IPv6 support to the TFTP code

2016-03-08 Thread Samuel Thibault
From: Thomas Huth Add the handler code for incoming TFTP packets to udp6_input(), and make sure that the TFTP code can send packets with both, udp_output() and udp6_output() by introducing a wrapper function called tftp_udp_output(). Signed-off-by: Thomas Huth Reviewed-by: Samuel Thibault ---

[Qemu-devel] [PATCHv10 07/11] slirp: Reindent after refactoring

2016-03-08 Thread Samuel Thibault
From: Guillaume Subiron No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/tcp_input.c | 104 ++--- slirp/tcp_output.c | 29 --- slirp/tcp_subr.c | 50

[Qemu-devel] [PATCHv10 02/11] slirp: Fix ICMP error sending

2016-03-08 Thread Samuel Thibault
From: Yann Bordenave Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Signed-off-by: Yann Bordenave Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_input.c | 2 +- slirp/ip_icmp.c | 12 ++

[Qemu-devel] [PATCHv10 06/11] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2016-03-08 Thread Samuel Thibault
From: Guillaume Subiron Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to "switch" in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. This patch does not

[Qemu-devel] [PATCHv10 08/11] slirp: Handle IPv6 in TCP functions

2016-03-08 Thread Samuel Thibault
From: Guillaume Subiron This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth -

[Qemu-devel] [PATCHv10 10/11] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-03-08 Thread Samuel Thibault
From: Yann Bordenave This patch adds parameters to manage some new options in the qemu -net command. Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in argument to the qemu command. Defaults parameters are respectively fec0::2, fec0::, /64 and fec0::3. Signed-off-by: Yann B

[Qemu-devel] [PATCHv10 05/11] slirp: Factorizing tcpiphdr structure with an union

2016-03-08 Thread Samuel Thibault
From: Guillaume Subiron This patch factorizes the tcpiphdr structure to put the IPv4 fields in an union, for addition of version 6 in further patch. Using some macros, retrocompatibility of the existing code is assured. This patch also fixes the SLIRP_MSIZE and margin computation in various func

[Qemu-devel] [PATCHv10 09/11] slirp: Adding IPv6 address for DNS relay

2016-03-08 Thread Samuel Thibault
From: Guillaume Subiron This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is developed using this Slirp attribute. sotranslate_in/out/accept() are also updated to manage the IPv6 case so the guest can be able to join the host using one of the Slirp addresses. For now this only po

[Qemu-devel] [PATCHv10 04/11] slirp: Adding IPv6 UDP support

2016-03-08 Thread Samuel Thibault
From: Guillaume Subiron This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Review

[Qemu-devel] [PATCHv10 01/11] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2016-03-08 Thread Samuel Thibault
From: Guillaume Subiron This patch adds the functions needed to handle IPv6 packets. ICMPv6 and NDP headers are implemented. Slirp is now able to send NDP Router or Neighbor Advertisement when it receives Router or Neighbor Solicitation. Using a 64bit-sized IPv6 prefix, the guest is now able to

Re: [Qemu-devel] [PULL 2/5] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-03-08 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@openvz.org) wrote: > On 03/07/2016 03:49 PM, Dr. David Alan Gilbert wrote: > >* Amit Shah (amit.s...@redhat.com) wrote: > >>From: "Denis V. Lunev" > >> > >>There is a possibility to hit an assert in qcow2_get_specific_info that > >>s->qcow_version is undefined. This happens

[Qemu-devel] [PULL 0/1] rng: use simpleq instead of gslist

2016-03-08 Thread Amit Shah
The following changes since commit 97556fe80e4f7252300b3498b3477fb4295153a3: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-03-08 04:53:37 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/virtio-rng.git tags/r

Re: [Qemu-devel] [PATCH v4 03/10] qapi: Make c_type() more OO-like

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > QAPISchemaType.c_type() was a bit awkward. Rather than having two > optional orthogonal boolean flags that should never both be true, > and where all callers should pass a compile-time constant (well, > our use of is_unboxed wasn't constant, but a future patch is about > to

[Qemu-devel] [PULL 1/1] rng: switch request queue to QSIMPLEQ

2016-03-08 Thread Amit Shah
From: Ladi Prosek QSIMPLEQ supports appending to tail in O(1) and is intrusive so it doesn't require extra memory allocations for the bookkeeping data. Suggested-by: Paolo Bonzini Signed-off-by: Ladi Prosek Reviewed-by: Paolo Bonzini Reviewed-by: Amit Shah Message-Id: <1457010971-24771-1-git

Re: [Qemu-devel] [PULL 2/5] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-03-08 Thread Denis V. Lunev
On 03/08/2016 01:45 PM, Dr. David Alan Gilbert wrote: * Denis V. Lunev (d...@openvz.org) wrote: On 03/07/2016 03:49 PM, Dr. David Alan Gilbert wrote: * Amit Shah (amit.s...@redhat.com) wrote: From: "Denis V. Lunev" There is a possibility to hit an assert in qcow2_get_specific_info that s->qc

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-08 Thread Amit Shah
On (Fri) 04 Mar 2016 [15:02:47], Jitendra Kolhe wrote: > > > > > > * Liang Li (liang.z...@intel.com) wrote: > > > > The current QEMU live migration implementation mark the all the > > > > guest's RAM pages as dirtied in the ram bulk stage, all these pages > > > > will be processed and that takes qu

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-08 Thread Amit Shah
On (Thu) 03 Mar 2016 [18:44:24], Liang Li wrote: > The current QEMU live migration implementation mark the all the > guest's RAM pages as dirtied in the ram bulk stage, all these pages > will be processed and that takes quit a lot of CPU cycles. > > From guest's point of view, it doesn't care abou

[Qemu-devel] [PULL 2/6] pc: fw_cfg: move ioport base constant to pc.h

2016-03-08 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Move BIOS_CFG_IOPORT define from pc.c to pc.h, and rename it to FW_CFG_IO_BASE. Cc: Marc Marí Signed-off-by: Gabriel Somlo Reviewed-by: Laszlo Ersek Reviewed-by: Marc Marí Reviewed-by: Michael S. Tsirkin Message-id: 1455906029-25565-3-git-send-email-so...@cmu.edu Si

[Qemu-devel] [PULL 5/6] fw_cfg: document ACPI device node information

2016-03-08 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Signed-off-by: Gabriel Somlo Reviewed-by: Laszlo Ersek Reviewed-by: Marc Marí Reviewed-by: Michael S. Tsirkin Message-id: 1455906029-25565-6-git-send-email-so...@cmu.edu Signed-off-by: Gerd Hoffmann --- docs/specs/fw_cfg.txt | 9 + 1 file changed, 9 insertio

[Qemu-devel] [PULL 1/6] fw_cfg: expose control register size in fw_cfg.h

2016-03-08 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Expose the size of the control register (FW_CFG_CTL_SIZE) in fw_cfg.h. Add comment to fw_cfg_io_realize() pointing out that since the 8-bit data register is always subsumed by the 16-bit control register in the port I/O case, we use the control register width as the *tota

[Qemu-devel] [PULL 0/6] acpi: add fw_cfg device node to dsdt

2016-03-08 Thread Gerd Hoffmann
lease pull, Gerd The following changes since commit 97556fe80e4f7252300b3498b3477fb4295153a3: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-03-08 04:53:37 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-fw

[Qemu-devel] [PULL 6/6] tests: update acpi test data

2016-03-08 Thread Gerd Hoffmann
using tests/acpi-test-data/rebuild-expected-aml.sh Signed-off-by: Gerd Hoffmann --- tests/acpi-test-data/pc/DSDT | Bin 5478 -> 5538 bytes tests/acpi-test-data/pc/DSDT.bridge | Bin 7337 -> 7397 bytes tests/acpi-test-data/q35/DSDT| Bin 8321 -> 8381 bytes tests/acpi-test-data/q3

[Qemu-devel] [PULL 3/6] acpi: pc: add fw_cfg device node to dsdt

2016-03-08 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Add a fw_cfg device node to the ACPI DSDT. While the guest-side firmware can't utilize this information (since it has to access the hard-coded fw_cfg device to extract ACPI tables to begin with), having fw_cfg listed in ACPI will help the guest kernel keep a more accurate

[Qemu-devel] [PULL 4/6] acpi: arm: add fw_cfg device node to dsdt

2016-03-08 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Add a fw_cfg device node to the ACPI DSDT. This is mostly informational, as the authoritative fw_cfg MMIO region(s) are listed in the Device Tree. However, since we are building ACPI tables, we might as well be thorough while at it... Signed-off-by: Gabriel Somlo Review

[Qemu-devel] [PULL 0/3] migration: avx2, 'info migrate' updates

2016-03-08 Thread Amit Shah
The following changes since commit 97556fe80e4f7252300b3498b3477fb4295153a3: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-03-08 04:53:37 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/mi

[Qemu-devel] [PULL 1/3] Postcopy: Fix sync count in info migrate

2016-03-08 Thread Amit Shah
From: "Dr. David Alan Gilbert" I'd missed the sync count off in the postcopy case. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: zhanghailiang Message-id: 1456394631-18010-1-git-send-email-dgilb...@redhat.com Message-Id: <1456394631-18010-1-git-send-email-dgilb...@redhat.com> Signed-off-b

[Qemu-devel] [PULL 3/3] cutils: add avx2 instruction optimization

2016-03-08 Thread Amit Shah
From: Liang Li buffer_find_nonzero_offset() is a hot function during live migration. Now it use SSE2 instructions for optimization. For platform supports AVX2 instructions, use AVX2 instructions for optimization can help to improve the performance of buffer_find_nonzero_offset() about 30% compari

[Qemu-devel] [PULL 2/3] configure: detect ifunc and avx2 attribute

2016-03-08 Thread Amit Shah
From: Liang Li Detect if the compiler can support the ifun and avx2, if so, set CONFIG_AVX2_OPT which will be used to turn on the avx2 instruction optimization. Suggested-by: Paolo Bonzini Suggested-by: Peter Maydell Signed-off-by: Liang Li Message-Id: <1457416397-26671-2-git-send-email-liang

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 00:34, Peter Maydell wrote: >> > I think that, if UEFI secure boot is in use, the UEFI environment >> > variables should also be only accessible from TrustZone, because they >> > store the key database. At least that's how it works on x86, where both >> > pflash devices have the se

Re: [Qemu-devel] [PATCH] Revert "qed: Implement .bdrv_drain"

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 11:11, Stefan Hajnoczi wrote: > This reverts commit df9a681dc9ad41c9cdeb9ecc5d060ba9abd27e01. > > Note that commit df9a681dc9ad41c9cdeb9ecc5d060ba9abd27e01 included some > unrelated hunks, possibly due to a merge failure or an overlooked > squash. This only reverts the qed .bdrv_d

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-08 Thread Ard Biesheuvel
On 8 March 2016 at 19:02, Paolo Bonzini wrote: > > > On 08/03/2016 00:34, Peter Maydell wrote: >>> > I think that, if UEFI secure boot is in use, the UEFI environment >>> > variables should also be only accessible from TrustZone, because they >>> > store the key database. At least that's how it w

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-08 Thread Ard Biesheuvel
On 8 March 2016 at 19:10, Ard Biesheuvel wrote: > On 8 March 2016 at 19:02, Paolo Bonzini wrote: >> >> >> On 08/03/2016 00:34, Peter Maydell wrote: > I think that, if UEFI secure boot is in use, the UEFI environment > variables should also be only accessible from TrustZone, because they

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 13:13, Ard Biesheuvel wrote: > > As far as this QEMU port is concerned, having some flash in secure and > > some in non-secure is going to be useful regardless, and 64 MB is > > plenty for both the code and the data. So if users of the Trustzone > > port (which is disjoint from the

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-08 Thread Ard Biesheuvel
On 8 March 2016 at 19:14, Paolo Bonzini wrote: > > > On 08/03/2016 13:13, Ard Biesheuvel wrote: >> > As far as this QEMU port is concerned, having some flash in secure and >> > some in non-secure is going to be useful regardless, and 64 MB is >> > plenty for both the code and the data. So if users

Re: [Qemu-devel] [PATCH 2/8] block: fix unbounded stack for dump_qdict

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 09:12, Markus Armbruster wrote: > I'm afraid this isn't a good idea. It relies on the non-local argument > that nobody will ever put a key longer than 255 into a qdict that gets > dumped. That may even be the case, but you need to *prove* it, not just > assert it. The weakest acc

Re: [Qemu-devel] [PATCH 3/8] usb: fix unbounded stack for ohci_td_pkt

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 08:00, Peter Xu wrote: > Suggested-by: Paolo Bonzini > CC: Gerd Hoffmann > Signed-off-by: Peter Xu > --- > hw/usb/hcd-ohci.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index 17ed461..c3cd4e2 100644 > -

Re: [Qemu-devel] [PATCH 4/8] usb: fix unbounded stack for xhci_dma_write_u32s

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 08:00, Peter Xu wrote: > First of all, this function cannot be inlined even with always_inline, > so removing inline. Why? always_inline fixes the error for me. > int i; > -uint32_t tmp[len / sizeof(uint32_t)]; > +uint32_t n = len / sizeof(uint32_t); > +#define __BUF

Re: [Qemu-devel] [PATCH 5/8] usb: fix unbounded stack for inotify_watchfn

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 08:20, Peter Maydell wrote: >> > +#define __BUF_LEN (sizeof(struct inotify_event) + NAME_MAX + 1) >> > /* From the man page: atleast one event can be read */ >> > -int len = sizeof(struct inotify_event) + NAME_MAX + 1; >> > int pos; >> > -char buf[len]; >> > +c

Re: [Qemu-devel] [PATCH 5/8] usb: fix unbounded stack for inotify_watchfn

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 08:00, Peter Xu wrote: > Suggested-by: Paolo Bonzini > CC: Gerd Hoffmann > Signed-off-by: Peter Xu > --- > hw/usb/dev-mtp.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index 7391783..e6dae2f 100644 > ---

Re: [Qemu-devel] [PATCH 7/8] migration: fix unbounded stack for source_return_path_thread

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 10:48, Juan Quintela wrote: > Peter Xu wrote: >> Suggested-by: Paolo Bonzini >> CC: Juan Quintela >> CC: Amit Shah >> Signed-off-by: Peter Xu >> --- >> migration/migration.c | 7 --- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/migration/migration.

Re: [Qemu-devel] [PATCH 7/8] migration: fix unbounded stack for source_return_path_thread

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 08:00, Peter Xu wrote: > Suggested-by: Paolo Bonzini > CC: Juan Quintela > CC: Amit Shah > Signed-off-by: Peter Xu > --- > migration/migration.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > inde

Re: [Qemu-devel] [PATCH 8/8] hw/i386: fix unbounded stack for load_multiboot

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 08:00, Peter Xu wrote: > @@ -159,6 +159,12 @@ int load_multiboot(FWCfgState *fw_cfg, > uint8_t *mb_bootinfo_data; > uint32_t cmdline_len; > > +#define __KERN_FNAME_LEN (1024) > +#define __KERN_CMDLINE_LEN (4096) > + > +assert(strlen(kernel_filename) + 1 >= __KERN_FNA

Re: [Qemu-devel] [PATCH v2] kvm: x86: q35: Add support for -machine kernel_irqchip=split for q35

2016-03-08 Thread Paolo Bonzini
On 07/03/2016 20:25, Jan Kiszka wrote: > On 2016-03-07 20:22, Rita Sinha wrote: >> The split IRQ chip mode via KVM_CAP_SPLIT_IRQCHIP was introduced with commit >> 15eafc2e60 but was broken for q35. This patch makes kernel_irqchip=split >> functional for q35. >> >> Signed-off-by: Rita Sinha >> --

Re: [Qemu-devel] [Qemu-block] [PATCH] block/gluster: add support for SEEK_DATA/SEEK_HOLE

2016-03-08 Thread Jeff Cody
On Tue, Mar 08, 2016 at 05:21:48AM +0100, Niels de Vos wrote: > On Mon, Mar 07, 2016 at 01:27:38PM -0500, Jeff Cody wrote: > > On Mon, Mar 07, 2016 at 07:04:15PM +0100, Niels de Vos wrote: > > > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes > > > it possible to detect spars

Re: [Qemu-devel] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 09:24, Fam Zheng wrote: > All three functions are not in hot path (all run once for the BDS lifecycle), > so it's okay to convert to g_malloc0. > > Fam > > > Fam Zheng (3): > vmdk: Switch to heap arrays for vmdk_write_cid > vmdk: Switch to heap arrays for vmdk_read_cid > vm

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-08 Thread Paolo Bonzini
On 08/03/2016 13:16, Ard Biesheuvel wrote: > > > > As far as this QEMU port is concerned, having some flash in secure and > > > > some in non-secure is going to be useful regardless, and 64 MB is > > > > plenty for both the code and the data. So if users of the Trustzone > > > > port (which is di

Re: [Qemu-devel] [PATCH qemu] update-linux-headers: Add userfaultfd.h

2016-03-08 Thread Paolo Bonzini
On 18/02/2016 13:04, Christian Borntraeger wrote: > On 02/15/2016 05:59 AM, Alexey Kardashevskiy wrote: >> > userfailtfd.h is used by post-copy migration so include it to >> > the update-linux-headers.sh as we want it updated altogether with >> > other kernel headers. >> > >> > Signed-off-by: Al

[Qemu-devel] [PATCH 0/8] block: Introduce common read/write function

2016-03-08 Thread Kevin Wolf
BlockBackends support a few different interfaces for reads and writes. Until now they used to forward the requests directly to the BDS layer, which implemented wrappers around one central common read/write function that contained the actual implementation of features provided by the block layer. T

[Qemu-devel] [PATCH 8/8] block: Use blk_co_pwritev() in blk_co_write_zeroes()

2016-03-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/block-backend.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 2947e8c..1c2ea72 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -1465,12 +1465,13 @@ void *blk_ai

[Qemu-devel] [PATCH 3/8] block: Use blk_co_pwritev() for blk_write()

2016-03-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/block-backend.c | 39 ++- block/io.c| 5 + include/block/block_int.h | 3 +++ 3 files changed, 34 insertions(+), 13 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index d97d

[Qemu-devel] [PATCH 7/8] block: Use blk_aio_prwv() for aio_read/write/write_zeroes

2016-03-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/block-backend.c | 104 +++--- 1 file changed, 91 insertions(+), 13 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 579cc09..2947e8c 100644 --- a/block/block-backend.c +++ b/block/block-b

[Qemu-devel] [PATCH 2/8] block: Use blk_co_preadv() for blk_read()

2016-03-08 Thread Kevin Wolf
This patch introduces blk_co_preadv() as a central function on the BlockBackend level that is supposed to handle all read requests from the BB to its root BDS eventually. Signed-off-by: Kevin Wolf --- block/block-backend.c | 64 --- block/io.c

[Qemu-devel] [PATCH 4/8] block: Pull up blk_read_unthrottled() implementation

2016-03-08 Thread Kevin Wolf
Use blk_read(), so that it goes through blk_co_preadv() like all read requests from the BB to the BDS. Signed-off-by: Kevin Wolf --- block/block-backend.c | 12 ++-- block/io.c| 14 -- include/block/block.h | 2 -- 3 files changed, 10 insertions(+), 18 deletions(

Re: [Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-03-08 Thread Ard Biesheuvel
On 8 March 2016 at 19:41, Paolo Bonzini wrote: > > > On 08/03/2016 13:16, Ard Biesheuvel wrote: >> > > > As far as this QEMU port is concerned, having some flash in secure and >> > > > some in non-secure is going to be useful regardless, and 64 MB is >> > > > plenty for both the code and the data.

  1   2   3   4   >