Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/02/2016 09:51, Markus Armbruster wrote: >>> Is it an abuse to "Get LBA Status" to return dirty information? Because in >>> SCSI >>> the command reports "mapped", "allocated" and "anchored" statuses. Does that >>> mean NBD will use a different status set? >> >> Perh

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 09:14, Markus Armbruster wrote: > I completely agree with you that Get LBA Status cannot just reflect the > top layer. But that's not what I meant to propose. Let me try to > explain myself more clearly. > > Consider a QCOW2 image D (for delta) with a backing file B (for base). >

Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized

2016-02-29 Thread Ján Tomko
On Wed, Feb 24, 2016 at 02:27:36PM +0100, Paolo Bonzini wrote: > From: Dimitris Aragiorgis > > In case of daemonize, use the logfile passed with the -D option in > order to redirect stderr to it instead of /dev/null. > > Also remove some unused code in log.h. > > Signed-off-by: Dimitris Aragior

Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 09:57, Ján Tomko wrote: > qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none > -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait > -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize Can you test this patch? diff --git a/util/lo

Re: [Qemu-devel] [PATCH v3 5/8] nvdimm acpi: introduce patched dsm memory

2016-02-29 Thread Michael S. Tsirkin
On Sun, Feb 14, 2016 at 04:51:02PM +0800, Xiao Guangrong wrote: > The dsm memory is used to save the input parameters and store > the dsm result which is filled by QEMU. > > The address of dsm memory is decided by bios and patched into > int32 object named "MEMA" > > Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 09:54, Paolo Bonzini wrote: > > > On 29/02/2016 09:14, Markus Armbruster wrote: >> I completely agree with you that Get LBA Status cannot just reflect the >> top layer. But that's not what I meant to propose. Let me try to >> explain myself more clearly. >> >> Consider a QCOW2 i

Re: [Qemu-devel] [PATCH COLO-Frame v15 00/38] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-02-29 Thread Dr. David Alan Gilbert
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > On 2016/2/27 0:36, Dr. David Alan Gilbert wrote: > >* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > >>* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>>From: root > >>> > >>>This is the 15th version of COLO (Still only s

[Qemu-devel] [PULL 0/1] fw_cfg: unbreak migration compatibility for 2.4 and earlier machines

2016-02-29 Thread Gerd Hoffmann
Hi, fwcfg acpi series which I planned to include here is blocked by unexpected apci test behavior. So I'm sending this patch alone so it doesn't has to wait until our acpi experts figured what is going on (and maybe the fwcfg acpi series then goes through the acpi queue anyway). please pull,

[Qemu-devel] [PULL 1/1] fw_cfg: unbreak migration compatibility for 2.4 and earlier machines

2016-02-29 Thread Gerd Hoffmann
From: Laszlo Ersek When I reviewed Marc's fw_cfg DMA patches, I completely missed that the way we set dma_enabled would break migration. Gerd explained the right way (see reference below): dma_enabled should be set to true by default, and only true->false transitions should be possible: - when

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-29 Thread Igor Mammedov
On Mon, 29 Feb 2016 11:20:19 +0530 Bharata B Rao wrote: > On Fri, Feb 26, 2016 at 12:13:39PM -0600, Michael Roth wrote: > > Quoting Bharata B Rao (2016-02-25 10:22:38) > > > Add sPAPR specific CPU core device that is based on generic CPU core > > > device. > > > Creating this core device will

Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized

2016-02-29 Thread Ján Tomko
On Mon, Feb 29, 2016 at 10:07:47AM +0100, Paolo Bonzini wrote: > > > On 29/02/2016 09:57, Ján Tomko wrote: > > qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none > > -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait > > -pidfile /var/lib/libvirt/qemu/capa

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Fam Zheng
On Mon, 02/29 10:42, Paolo Bonzini wrote: > > > On 29/02/2016 09:54, Paolo Bonzini wrote: > > > > > > On 29/02/2016 09:14, Markus Armbruster wrote: > >> I completely agree with you that Get LBA Status cannot just reflect the > >> top layer. But that's not what I meant to propose. Let me try t

Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 11:04, Ján Tomko wrote: > On Mon, Feb 29, 2016 at 10:07:47AM +0100, Paolo Bonzini wrote: >> >> >> On 29/02/2016 09:57, Ján Tomko wrote: >>> qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none >>> -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowa

[Qemu-devel] [WIP:COLO: 1] Flush colo ram in parallel

2016-02-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Flush the colo ram cache in parallel; use the same number of threads as CPU cores. On a VM with 4 cores, and 4GB RAM, I've seen a reduction from ~20ms to ~16ms using this, which is helpful but not as much as I hoped; I guess one problem might be that all the chan

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-29 Thread Markus Armbruster
Markus Armbruster writes: [...] > Consider a QCOW2 image D (for delta) with a backing file B (for base). > If you open it normally, you see "D over B". Get LBA Status should > certainly claim the "deallocated" state only for blocks that are > allocated neither in D nor B. > > However, you can al

[Qemu-devel] [PULL 1/3] spice/gl: Enable dmabuf only for spice >= 0.13.1

2016-02-29 Thread Gerd Hoffmann
From: Michal Privoznik After 474114b7 the dmabuf feature is enabled whenever spice greater than or equal to spice 0.13.0 is found. This is because two new functions are required: spice_qxl_gl_scanout and spice_qxl_gl_draw_async. These were, however, introduce in 0.13.1 release. Well, technically

[Qemu-devel] [PULL 0/3] ui patch queue

2016-02-29 Thread Gerd Hoffmann
6 16:02:00 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20160229-1 for you to fetch changes up to e220656ce1bd98b482d12ef51344aa46aca4e098: MAINTAINERS: Add an entry for the include/ui/ folder (2016-02-29 10:54

[Qemu-devel] [PULL 3/3] MAINTAINERS: Add an entry for the include/ui/ folder

2016-02-29 Thread Gerd Hoffmann
From: Thomas Huth The ui/ folder is listed in the "Graphics" section, so I think the "include/ui/" folder should be listed there, too. Signed-off-by: Thomas Huth Message-id: 1456392967-20274-4-git-send-email-th...@redhat.com Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 1 + 1 file changed,

Re: [Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine

2016-02-29 Thread Igor Mammedov
On Thu, 25 Feb 2016 21:52:41 +0530 Bharata B Rao wrote: > Implement query cpu-slots that provides information about hot-plugged > as well as hot-pluggable CPU slots that the machine supports. > > TODO: As Eric suggested use enum for type instead of str. > TODO: @hotplug-granularity probably isn'

[Qemu-devel] [PULL 2/3] MAINTAINERS: Add spice-display.h to the SPICE section

2016-02-29 Thread Gerd Hoffmann
From: Thomas Huth Signed-off-by: Thomas Huth Message-id: 1456392967-20274-3-git-send-email-th...@redhat.com Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index caa5260..83ad8f4 100644 --- a/MAINTAINERS +++ b/MAINTAINE

Re: [Qemu-devel] [PULL 2/8] configure: add dma-buf support detection.

2016-02-29 Thread Gerd Hoffmann
Hi, > > if test "$opengl" != "no" ; then > > - opengl_pkgs="epoxy" > > + opengl_pkgs="epoxy libdrm gbm" > > This disables OpenGL entirely if libdrm or mesa-libgbm is unavailable. > Is it intentional? Right now OpenGL has a X11 dependency anyway, so I don't think this is a big problem, libdr

Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized

2016-02-29 Thread Ján Tomko
On Mon, Feb 29, 2016 at 11:17:25AM +0100, Paolo Bonzini wrote: > > > On 29/02/2016 11:04, Ján Tomko wrote: > > On Mon, Feb 29, 2016 at 10:07:47AM +0100, Paolo Bonzini wrote: > >> > >> > >> On 29/02/2016 09:57, Ján Tomko wrote: > >>> qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M

[Qemu-devel] [PULL 1/2] MAINTAINERS: Add some missing entries for USB related files

2016-02-29 Thread Gerd Hoffmann
From: Thomas Huth USB-related docs and include files should go into the USB section of the MAINTAINERS file. Signed-off-by: Thomas Huth Message-id: 1456392967-20274-2-git-send-email-th...@redhat.com Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff -

[Qemu-devel] [PULL 2/2] usb-redirect: Avoid double free of data

2016-02-29 Thread Gerd Hoffmann
From: Fam Zheng If dropping packets, data is freed, the caller's loop should not continue. Reported by ccc-analyzer. Signed-off-by: Fam Zheng Message-id: 1456301288-1592-1-git-send-email-f...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 11 --- 1 file changed, 8 in

[Qemu-devel] [PULL 0/2] usb: redirect bugfix, MAINTAINERS update.

2016-02-29 Thread Gerd Hoffmann
2:00 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20160229-1 for you to fetch changes up to e8ce12d9eaeedeb7f8d9debcd4c9b993903f1abb: usb-redirect: Avoid double free of data (2016-02-29 11:4

Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 12:05, Ján Tomko wrote: >> > > This works for me, but produces a warning: > CCutil/log.o > util/log.c: In function ‘do_qemu_set_log’: > util/log.c:60:40: error: pointer/integer type mismatch in conditional > expression [-Werror] > (is_daemonized() ? logfilename : qe

Re: [Qemu-devel] [PULL 0/8] ppc-for-2.6 queue 20160229

2016-02-29 Thread Peter Maydell
following changes since commit 6e378dd214fbbae8138ff011ec3de7ddf13a445f: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160226' into staging (2016-02-26 > 16:02:00 +) > > are available in the git repository at: > > git://github.com/dgibson/qemu.

Re: [Qemu-devel] [PATCH v4 07/16] register: Add block initialise helper

2016-02-29 Thread Alex Bennée
Alistair Francis writes: > From: Peter Crosthwaite > > Add a helper that will scan a static RegisterAccessInfo Array > and populate a container MemoryRegion with registers as defined. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > V3: > - Fix typo > V2: > - U

Re: [Qemu-devel] [PULL 0/1] fw_cfg: unbreak migration compatibility for 2.4 and earlier machines

2016-02-29 Thread Peter Maydell
On 29 February 2016 at 09:53, Gerd Hoffmann wrote: > Hi, > > fwcfg acpi series which I planned to include here is blocked by unexpected > apci test behavior. So I'm sending this patch alone so it doesn't has to > wait until our acpi experts figured what is going on (and maybe the > fwcfg acpi s

Re: [Qemu-devel] [PATCH v4 08/16] bitops: Add ONES macro

2016-02-29 Thread Alex Bennée
Alistair Francis writes: > From: Peter Crosthwaite > > Little macro that just gives you N ones (justified to LSB). > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > > include/qemu/bitops.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/qemu/bi

[Qemu-devel] [PATCH v4 01/26] crypto: add cryptographic random byte source

2016-02-29 Thread Daniel P. Berrange
There are three backend impls provided. The preferred is gnutls, which is backed by nettle in modern distros. The gcrypt impl is provided for cases where QEMU build against gnutls is disabled, but crypto is still desired. No nettle impl is provided, since it is non-trivial to use the nettle APIs fo

[Qemu-devel] [PATCH v4 02/26] crypto: add support for PBKDF2 algorithm

2016-02-29 Thread Daniel P. Berrange
The LUKS data format includes use of PBKDF2 (Password-Based Key Derivation Function). The Nettle library can provide an implementation of this, but we don't want code directly depending on a specific crypto library backend. Introduce a new include/crypto/pbkdf.h header which defines a QEMU API for

[Qemu-devel] [PATCH v4 06/26] crypto: add support for the cast5-128 cipher algorithm

2016-02-29 Thread Daniel P. Berrange
A new cipher algorithm 'cast-5-128' is defined for the Cast-5 algorithm with 128 bit key size. Smaller key sizes are supported by Cast-5, but nothing in QEMU should use them, so only 128 bit keys are permitted. The nettle and gcrypt cipher backends are updated to support the new cipher and a test

[Qemu-devel] [PATCH v4 07/26] crypto: add support for the serpent cipher algorithm

2016-02-29 Thread Daniel P. Berrange
New cipher algorithms 'serpent-128', 'serpent-192' and 'serpent-256' are defined for the Serpent algorithm. The nettle and gcrypt cipher backends are updated to support the new cipher and a test vector added to the cipher test suite. The new algorithm is enabled in the LUKS block encryption driver

[Qemu-devel] [PATCH v4 00/26] Support LUKS encryption in block devices

2016-02-29 Thread Daniel P. Berrange
This series was previously submitted here: v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04748.html v2: https://lists.gnu.org/archive/html/qemu-block/2016-01/msg00534.html v3: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03176.html This patch series applies as is

[Qemu-devel] [PATCH v4 05/26] crypto: skip testing of unsupported cipher algorithms

2016-02-29 Thread Daniel P. Berrange
We don't guarantee that all crypto backends will support all cipher algorithms, so we should skip tests unless the crypto backend indicates support. Signed-off-by: Daniel P. Berrange --- tests/test-crypto-cipher.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test-

[Qemu-devel] [PATCH v4 11/26] crypto: wire up XTS mode for cipher APIs

2016-02-29 Thread Daniel P. Berrange
Introduce 'XTS' as a permitted mode for the cipher APIs. With XTS the key provided must be twice the size of the key normally required for any given algorithm. This is because the key will be split into two pieces for use in XTS mode. Signed-off-by: Daniel P. Berrange --- crypto/cipher-builtin.c

[Qemu-devel] [PATCH v4 04/26] crypto: add support for anti-forensic split algorithm

2016-02-29 Thread Daniel P. Berrange
The LUKS format specifies an anti-forensic split algorithm which is used to artificially expand the size of the key material on disk. This is an implementation of that algorithm. Signed-off-by: Daniel P. Berrange --- crypto/Makefile.objs| 1 + crypto/afsplit.c| 158

[Qemu-devel] [PATCH v4 03/26] crypto: add support for generating initialization vectors

2016-02-29 Thread Daniel P. Berrange
There are a number of different algorithms that can be used to generate initialization vectors for disk encryption. This introduces a simple internal QCryptoBlockIV object to provide a consistent internal API to the different algorithms. The initially implemented algorithms are 'plain', 'plain64' a

[Qemu-devel] [PATCH v4 08/26] crypto: add support for the twofish cipher algorithm

2016-02-29 Thread Daniel P. Berrange
New cipher algorithms 'twofish-128', 'twofish-192' and 'twofish-256' are defined for the Twofish algorithm. The gcrypt backend does not support 'twofish-192'. The nettle and gcrypt cipher backends are updated to support the new cipher and a test vector added to the cipher test suite. The new algor

[Qemu-devel] [PATCH v4 17/26] tests: refactor python I/O tests helper main method

2016-02-29 Thread Daniel P. Berrange
The iotests.py helper provides a main() method for running tests via the python unit test framework. Not all tests will want to use this, so refactor it to split the testing of compatible formats and platforms into separate helper methods Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/

[Qemu-devel] [PATCH v4 20/26] qcow2: make qcow2_encrypt_sectors encrypt in place

2016-02-29 Thread Daniel P. Berrange
Instead of requiring separate input/output buffers for encrypting data, change qcow2_encrypt_sectors() to assume use of a single buffer, encrypting in place. The current callers all used the same buffer for input/output already. Reviewed-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Danie

[Qemu-devel] [PATCH v4 15/26] qemu-img/qemu-io: don't prompt for passwords if not required

2016-02-29 Thread Daniel P. Berrange
The qemu-img/qemu-io tools prompt for disk encryption passwords regardless of whether any are actually required. Adding a check on bdrv_key_required() avoids this prompt for disk formats which have been converted to the QCryptoSecret APIs. This is just a temporary hack to ensure the block I/O test

[Qemu-devel] [PATCH v4 16/26] tests: redirect stderr to stdout for iotests

2016-02-29 Thread Daniel P. Berrange
The python I/O tests helper for running qemu-img/qemu-io setup stdout to be captured to a pipe, but left stderr untouched. As a result, if something failed in qemu-img/ qemu-io, data written to stderr would get output directly and not line up with data on the test stdout due to buffering. If we ex

[Qemu-devel] [PATCH v4 18/26] tests: add output filter to python I/O tests helper

2016-02-29 Thread Daniel P. Berrange
Add a 'log' method to iotests.py which prints messages to stdout, with optional filtering of data. Port over some standard filters for present in the shell common.filter code. Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/iotests.py | 25 - 1 file changed, 24 i

[Qemu-devel] [PATCH v4 26/26] block: remove support for legecy AES qcow/qcow2 encryption

2016-02-29 Thread Daniel P. Berrange
Refuse to use images with the legacy AES-CBC encryption format in the system emulators. They are still fully supported in the qemu-img, qemu-io & qemu-nbd tools in order to allow data to be liberated and for compatibility with older QEMU versions. Continued support in these tools is not a notable b

[Qemu-devel] [PATCH v4 12/26] crypto: add block encryption framework

2016-02-29 Thread Daniel P. Berrange
Add a generic framework for support different block encryption formats. Upon instantiating a QCryptoBlock object, it will read the encryption header and extract the encryption keys. It is then possible to call methods to encrypt/decrypt data buffers. There is also a mode whereby it will create/ini

[Qemu-devel] [PATCH v4 10/26] crypto: refactor code for dealing with AES cipher

2016-02-29 Thread Daniel P. Berrange
The built-in and nettle cipher backends for AES maintain two separate AES contexts, one for encryption and one for decryption. This is going to be inconvenient for the future code dealing with XTS, so wrap them up in a single struct so there is just one pointer to pass around for both encryptin and

[Qemu-devel] [PATCH v4 25/26] block: remove all encryption handling APIs

2016-02-29 Thread Daniel P. Berrange
Now that all encryption keys must be provided upfront via the QCryptoSecret API and associated block driver properties there is no need for any explicit encryption handling APIs in the block layer. Encryption can be handled transparently within the block driver. We only retain an API for querying w

[Qemu-devel] [PATCH v4 14/26] block: add flag to indicate that no I/O will be performed

2016-02-29 Thread Daniel P. Berrange
When opening an image it is useful to know whether the caller intends to perform I/O on the image or not. In the case of encrypted images this will allow the block driver to avoid having to prompt for decryption keys when we merely want to query header metadata about the image. eg qemu-img info Th

[Qemu-devel] [PATCH v4 09/26] crypto: import an implementation of the XTS cipher mode

2016-02-29 Thread Daniel P. Berrange
The XTS (XEX with tweaked-codebook and ciphertext stealing) cipher mode is commonly used in full disk encryption. There is unfortunately no implementation of it in either libgcrypt or nettle, so we need to provide our own. The libtomcrypt project provides a repository of crypto algorithms under a

[Qemu-devel] [PATCH v4 23/26] qcow: convert QCow to use QCryptoBlock for encryption

2016-02-29 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content. This is only wired up to permit use of the legacy QCow encryption format. Users who wish to have the strong LUKS format should switch to qcow2 instead. With this change it is now required to use the Q

[Qemu-devel] [PATCH v4 22/26] qcow: make encrypt_sectors encrypt in place

2016-02-29 Thread Daniel P. Berrange
Instead of requiring separate input/output buffers for encrypting data, change encrypt_sectors() to assume use of a single buffer, encrypting in place. One current caller all uses the same buffer for input/output already and the other two callers are easily converted todo so. Signed-off-by: Daniel

[Qemu-devel] [PATCH v4 24/26] block: rip out all traces of password prompting

2016-02-29 Thread Daniel P. Berrange
Now that qcow & qcow2 are wired up to get encryption keys via the QCryptoSecret object, nothing is relying on the interactive prompting for passwords. All the code related to password prompting can thus be ripped out. Signed-off-by: Daniel P. Berrange --- hmp.c | 31 -

[Qemu-devel] [PATCH v4 13/26] crypto: implement the LUKS block encryption format

2016-02-29 Thread Daniel P. Berrange
Provide a block encryption implementation that follows the LUKS/dm-crypt specification. This supports all combinations of hash, cipher algorithm, cipher mode and iv generator that are implemented by the current crypto layer. The notable missing feature is support for the 'xts' cipher mode, which

[Qemu-devel] [PATCH v4 21/26] qcow2: convert QCow2 to use QCryptoBlock for encryption

2016-02-29 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content. As well as continued support for the legacy QCow2 encryption format, the appealing benefit is that it enables support for the LUKS format inside qcow2. With the LUKS format it is necessary to store th

Re: [Qemu-devel] [PATCH COLO-Frame v15 00/38] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-02-29 Thread Hailiang Zhang
On 2016/2/29 17:47, Dr. David Alan Gilbert wrote: * Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: On 2016/2/27 0:36, Dr. David Alan Gilbert wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: From: root This is the 15

Re: [Qemu-devel] [PATCH v4 09/16] dma: Add Xilinx Zynq devcfg device model

2016-02-29 Thread Alex Bennée
Alistair Francis writes: > From: Peter Crosthwaite > > Minimal device model for devcfg module of Zynq. DMA capabilities and > interrupt generation supported. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > > default-configs/arm-softmmu.mak | 1 + > hw/dma/M

Re: [Qemu-devel] [PATCH v4 14/16] register: Add GPIO API

2016-02-29 Thread Alex Bennée
Alistair Francis writes: > From: Peter Crosthwaite > > Add GPIO functionality to the register API. This allows association > and automatic connection of GPIOs to bits in registers. GPIO inputs > will attach to handlers that automatically set read-only bits in > registers. GPIO outputs will be u

[Qemu-devel] [PATCH V2 0/3] Introduce filter-redirector

2016-02-29 Thread Zhang Chen
Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter + |

[Qemu-devel] [PATCH V2 3/3] tests/test-filter-redirector: Add unit test for filter-redirector

2016-02-29 Thread Zhang Chen
In this unit test,we will test the filter redirector function. Start qemu with: "-netdev tap,id=qtest-bn0 " "-device rtl8139,netdev=qtest-bn0,id=qtest-e0 " "-chardev socket,id=redirector0,path=%s,server,nowait " "-chardev socket,id=redirector1,path=%s,server,nowait

[Qemu-devel] [PATCH V2 1/3] net/filter-traffic: add filter-traffic.h

2016-02-29 Thread Zhang Chen
We can reuse filter-traffic by filter-mirror, filter-redirector and so on. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- net/filter-mirror.c | 70 +++ net/filter-traffic.h | 71 2 f

[Qemu-devel] [PATCH V2 2/3] net/filter-redirector:Add filter-redirector

2016-02-29 Thread Zhang Chen
Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter + |

Re: [Qemu-devel] [PULL 0/3] ui patch queue

2016-02-29 Thread Peter Maydell
emote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160226' into staging (2016-02-26 > 16:02:00 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-ui-20160229-1 > > for you to fetch changes up to e220656ce1b

Re: [Qemu-devel] [PATCH v4 00/16] data-driven device registers

2016-02-29 Thread Alex Bennée
Alistair Francis writes: > This patch series is based on Peter C's original register API. His > original cover letter is below. > > I have added a new function memory_region_add_subregion_no_print() which > stops memory regions from being printed by 'info mtree'. This is used to > avoid evey reg

Re: [Qemu-devel] [PATCH] net/filter-redirector:Add filter-redirector

2016-02-29 Thread Zhang Chen
On 02/29/2016 03:11 PM, Jason Wang wrote: On 02/24/2016 05:03 PM, Zhang Chen wrote: If queue=rx, filter-redirector will get the packet that guest send, then redirect to outdev(if none, do nothing). but queue=rx/tx/all not related to indev. please look the flow chart below. queue=xxx just work

[Qemu-devel] [PING][PATCH] Use unsigned types for the 'len' argument of all memory read/write functions

2016-02-29 Thread Martin Galvan
When looking at address_space_read_continue I noticed the 'len' variable was a signed int, while it clearly should be a hwaddr or some other unsigned type. I started looking around and saw that this error had spread all over the code. I replaced the signed int by their unsigned counterparts as muc

Re: [Qemu-devel] [WIP:COLO: 1] Flush colo ram in parallel

2016-02-29 Thread Hailiang Zhang
On 2016/2/29 18:19, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Flush the colo ram cache in parallel; use the same number of threads as CPU cores. On a VM with 4 cores, and 4GB RAM, I've seen a reduction from ~20ms to ~16ms using this, which is helpful but not as much as

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-29 Thread Bharata B Rao
On Mon, Feb 29, 2016 at 11:03:16AM +0100, Igor Mammedov wrote: > On Mon, 29 Feb 2016 11:20:19 +0530 > Bharata B Rao wrote: > > > On Fri, Feb 26, 2016 at 12:13:39PM -0600, Michael Roth wrote: > > > Quoting Bharata B Rao (2016-02-25 10:22:38) > > > > Add sPAPR specific CPU core device that is bas

[Qemu-devel] [PATCH] pc-dimm: fix error handling in pc_dimm_check_memdev_is_busy()

2016-02-29 Thread Igor Mammedov
if host_memory_backend_get_memory() were to return error and NULL MemoryRegion, pc_dimm_check_memdev_is_busy() would crash dereferrencing null pointer in memory_region_is_mapped() Also pc_dimm_check_memdev_is_busy():error_setg() would assert if caller passes NULL errp, but assert shouldn't happen

Re: [Qemu-devel] [PATCH COLO-Frame v15 00/38] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-02-29 Thread Dr. David Alan Gilbert
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > On 2016/2/29 17:47, Dr. David Alan Gilbert wrote: > >* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > >>On 2016/2/27 0:36, Dr. David Alan Gilbert wrote: > >>>* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > >I've got a pat

Re: [Qemu-devel] [PULL 0/2] usb: redirect bugfix, MAINTAINERS update.

2016-02-29 Thread Peter Maydell
ng branch > 'remotes/pmaydell/tags/pull-target-arm-20160226' into staging (2016-02-26 > 16:02:00 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-usb-20160229-1 > > for you to fetch changes up to e8ce12d9eaeedeb7f8d9

[Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-02-29 Thread Alvise Rigo
As in the case of tlb_flush(), also tlb_flush_by_mmuidx has to query the TLB flush if it targets another VCPU. To accomplish this, a new async work has been added, together with a new TLBFlushByMMUIdxParams. A bitmap is used to track the MMU indexes to flush. This patch applies to the multi_tcg_v8

Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-02-29 Thread Peter Maydell
On 29 February 2016 at 13:16, Alvise Rigo wrote: > As in the case of tlb_flush(), also tlb_flush_by_mmuidx has to query the > TLB flush if it targets another VCPU. To accomplish this, a new async > work has been added, together with a new TLBFlushByMMUIdxParams. A > bitmap is used to track the MMU

Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 14:21, Peter Maydell wrote: > On 29 February 2016 at 13:16, Alvise Rigo > wrote: >> > As in the case of tlb_flush(), also tlb_flush_by_mmuidx has to query the >> > TLB flush if it targets another VCPU. To accomplish this, a new async >> > work has been added, together with a new T

Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-02-29 Thread Peter Maydell
On 29 February 2016 at 13:50, Paolo Bonzini wrote: > > > On 29/02/2016 14:21, Peter Maydell wrote: >> On 29 February 2016 at 13:16, Alvise Rigo >> wrote: >>> > As in the case of tlb_flush(), also tlb_flush_by_mmuidx has to query the >>> > TLB flush if it targets another VCPU. To accomplish this,

Re: [Qemu-devel] QCow2 compression

2016-02-29 Thread Kevin Wolf
[ Cc: qemu-block ] Am 27.02.2016 um 06:00 hat mgre...@cinci.rr.com geschrieben: > Hello, I am hoping someone here can help me. I am implementing QCow2 > support for a PC emulator project and have a couple questions > regarding compression I haven't been able to figure out on my own. > > First som

Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-02-29 Thread alvise rigo
On Mon, Feb 29, 2016 at 2:55 PM, Peter Maydell wrote: > On 29 February 2016 at 13:50, Paolo Bonzini wrote: >> >> >> On 29/02/2016 14:21, Peter Maydell wrote: >>> On 29 February 2016 at 13:16, Alvise Rigo >>> wrote: > As in the case of tlb_flush(), also tlb_flush_by_mmuidx has to query the

Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 15:02, alvise rigo wrote: > > Yeah, that's the other approach -- really split the things that can > > be async and do real "wait for completion" at points which must > > synchronize. (Needs a little care since DMB is not the only such point.) > > An initial implementation that does

Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx

2016-02-29 Thread alvise rigo
I see the risk. I will come back with something and let you know. Thank you, alvise On Mon, Feb 29, 2016 at 3:06 PM, Paolo Bonzini wrote: > > > On 29/02/2016 15:02, alvise rigo wrote: >> > Yeah, that's the other approach -- really split the things that can >> > be async and do real "wait for com

Re: [Qemu-devel] [PATCH] i8257: fix Terminal Count status

2016-02-29 Thread Paolo Bonzini
On 25/02/2016 13:45, Hervé Poussineau wrote: > When a DMA transfer is done (ie all bytes have been transfered), the > corresponding > Terminal Count bit must be set in the status register. > This bit is already cleared in i8257_read_cont and i8257_write_cont when > required. > > This fixes (at

Re: [Qemu-devel] [PATCH v2 00/15] tests: Introducing docker tests

2016-02-29 Thread Alex Bennée
Fam Zheng writes: > On Tue, 02/16 20:39, Fam Zheng wrote: >> v2: - Fix a few coding style warnings of shellcheck and pylint. >> [Marc-André Lureau] >> - Rename make targets: >> docker-run => docker-test >> docker-build => docker-image >> docker-run-$TEST.sh@$IMAGE =>

Re: [Qemu-devel] [PING][PATCH] Use unsigned types for the 'len' argument of all memory read/write functions

2016-02-29 Thread Paolo Bonzini
On 29/02/2016 13:40, Martin Galvan wrote: > When looking at address_space_read_continue I noticed the 'len' variable was > a signed int, while it clearly should be a hwaddr or some other unsigned type. > I started looking around and saw that this error had spread all over the code. > > I replace

Re: [Qemu-devel] QCow2 compression

2016-02-29 Thread Eric Blake
On 02/26/2016 10:00 PM, mgre...@cinci.rr.com wrote: > Hello, I am hoping someone here can help me. I am implementing QCow2 support > for a PC emulator project and have a couple questions regarding compression I > haven't been able to figure out on my own. [Can you convince your mailer to wrap lo

[Qemu-devel] [PATCH] qcow2: Clarify that compressed cluster offset requires shift

2016-02-29 Thread Eric Blake
The specs for the host cluster offset of a compressed cluster were not clear that the offset is in terms of sectors, and requires a shift by 9 to be a byte offset. Add some more text to make the interpretation obvious. CC: mgre...@cinci.rr.com Signed-off-by: Eric Blake --- docs/specs/qcow2.txt

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-29 Thread Igor Mammedov
On Mon, 29 Feb 2016 18:25:25 +0530 Bharata B Rao wrote: > On Mon, Feb 29, 2016 at 11:03:16AM +0100, Igor Mammedov wrote: > > On Mon, 29 Feb 2016 11:20:19 +0530 > > Bharata B Rao wrote: > > > > > On Fri, Feb 26, 2016 at 12:13:39PM -0600, Michael Roth wrote: > > > > Quoting Bharata B Rao (201

[Qemu-devel] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-29 Thread Programmingkid
I do think this patch is ready to be added to QEMU. I have listened to what you said and implemented your changes. https://patchwork.ozlabs.org/patch/579325/ Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to

Re: [Qemu-devel] [PING][PATCH] Use unsigned types for the 'len' argument of all memory read/write functions

2016-02-29 Thread Martin Galvan
On Mon, Feb 29, 2016 at 11:59 AM, Paolo Bonzini wrote: > Hi Martin, > > despite the apparent simplicity, this patch is very hard to review. I > suggest splitting it in several parts so that the various submaintainers > can look at it. I can take a look at cpus.c, exec.c, kvm-all.c and > include/

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2016-02-29 Thread Zack Callendish
Would the presence of RTC make any difference? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893208 Title: qemu on ARM hosts can't boot i386 image Status in QEMU: Confirmed Status in Linaro QEMU

Re: [Qemu-devel] [PATCH 00/10] s390x: pending patches

2016-02-29 Thread Cornelia Huck
On Tue, 23 Feb 2016 12:19:00 +0100 Cornelia Huck wrote: > Currently pending in my queue are some fixes, improvements and > cleanups. I have one further fix, which I'll send in this thread. > > I'd like to include the s390x cpu hotplug patches as well in my > next pull request once we arrive at

[Qemu-devel] [PATCH] s390x/css: only suspend when enabled by orb

2016-02-29 Thread Cornelia Huck
We must not allow a channel program to suspend if the suspend control bit in the orb had not been specified. Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c i

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-29 Thread Igor Mammedov
On Thu, 25 Feb 2016 14:52:06 -0300 Eduardo Habkost wrote: > On Wed, Feb 24, 2016 at 03:42:18PM +0100, Igor Mammedov wrote: > > On Tue, 23 Feb 2016 18:26:20 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, Feb 23, 2016 at 10:46:45AM +0100, Igor Mammedov wrote: > > > > On Mon, 22 Feb 2016 1

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Clarify that compressed cluster offset requires shift

2016-02-29 Thread Max Reitz
On 29.02.2016 16:11, Eric Blake wrote: > The specs for the host cluster offset of a compressed cluster > were not clear that the offset is in terms of sectors, and requires > a shift by 9 to be a byte offset. Add some more text to make the > interpretation obvious. > > CC: mgre...@cinci.rr.com >

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Clarify that compressed cluster offset requires shift

2016-02-29 Thread Max Reitz
On 29.02.2016 16:42, Max Reitz wrote: > On 29.02.2016 16:11, Eric Blake wrote: >> The specs for the host cluster offset of a compressed cluster >> were not clear that the offset is in terms of sectors, and requires >> a shift by 9 to be a byte offset. Add some more text to make the >> interpretati

Re: [Qemu-devel] QCow2 compression

2016-02-29 Thread Eric Blake
On 02/29/2016 07:59 AM, Eric Blake wrote: >> an L2 entry value of 4A C0 00 00 00 3D 97 50. > > So with default 64k clusters, x = 62 - (16 - 8) = 54. Bits 0-54 are the > host cluster offset, or 0x003d9750, but that is in terms of host > sectors. The comment in block/qcow2.c is telling, and perha

Re: [Qemu-devel] [PATCH v4 RFC 00/17] qcow2: persistent dirty bitmaps

2016-02-29 Thread Vladimir Sementsov-Ogievskiy
On 27.02.2016 00:41, John Snow wrote: Do you have this mirrored in a git repo so I can browse it more effectively? I can't figure out what all the prerequisite patches are, so it will be convenient to just have a repo in that case for the RFC. done: https://src.openvz.org/users/vsementsov/repos

Re: [Qemu-devel] QCow2 compression

2016-02-29 Thread Eric Blake
On 02/29/2016 07:01 AM, Kevin Wolf wrote: >> I have for example a compressed cluster with an L2 entry value of 4A >> C0 00 00 00 3D 97 50. This would lead me to believe the cluster starts >> at offset 0x3D9750 and has a length of 0x2B 512-byte sectors (or 0x2B >> times 0x200 = 0x5600). Added to the

[Qemu-devel] [PATCH RFC] docs: add dirty bitmap postcopy migration docs

2016-02-29 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- There is documentation draft for the feature. Here is nothing about bitmap migration protocol, it is commented in migration/block-dirty-bitmap.c. Capability name differs with other patches. Here - postcopy-bitmaps, and in patches dirty-b

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Clarify that compressed cluster offset requires shift

2016-02-29 Thread Eric Blake
On 02/29/2016 08:46 AM, Max Reitz wrote: >>> Compressed Clusters Descriptor (x = 62 - (cluster_bits - 8)): >>> >>> -Bit 0 - x:Host cluster offset. This is usually _not_ aligned to a >>> -cluster boundary! >>> +Bit 0 - x:Bits 9-(x+9) of host cluster offset.

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Clarify that compressed cluster offset requires shift

2016-02-29 Thread Max Reitz
On 29.02.2016 17:06, Eric Blake wrote: > On 02/29/2016 08:46 AM, Max Reitz wrote: > Compressed Clusters Descriptor (x = 62 - (cluster_bits - 8)): -Bit 0 - x:Host cluster offset. This is usually _not_ aligned to a -cluster boundary! +

  1   2   3   >