Re: [Qemu-devel] [PATCHv9 04/10] slirp: Factorizing tcpiphdr structure with an union

2016-02-23 Thread Thomas Huth
On 22.02.2016 20:28, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch factorizes the tcpiphdr structure to put the IPv4 fields in > an union, for addition of version 6 in further patch. > Using some macros, retrocompatibility of the existing code is assured. > > This patch also fi

Re: [Qemu-devel] [PATCHv9 08/10] slirp: Adding IPv6 address for DNS relay

2016-02-23 Thread Thomas Huth
On 22.02.2016 20:28, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is > developed using this Slirp attribute. > sotranslate_in/out/accept() are also updated to manage the IPv6 case so the > guest can be able to join the host

Re: [Qemu-devel] [PATCH v3 1/2] spapr: skip configuration section during migration of older machines

2016-02-23 Thread Juan Quintela
Greg Kurz wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > This patch fixes the migration of pseries-2.3 from/to QEMU 2.3, but it > breaks migration of the same machine from/to QEMU 2.4

Re: [Qemu-devel] [PATCH v3 2/2] migration: allow machine to enforce configuration section migration

2016-02-23 Thread Juan Quintela
Greg Kurz wrote: > Migration of pseries-2.3 doesn't have configuration section. Unfortunately, > QEMU 2.4/2.4.1/2.5 are buggy and always stream and expect the configuration > section, and break migration both ways. > > This patch introduces a property which allows to enforce a configuration > sect

Re: [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to block_set_io_throttle

2016-02-23 Thread Alberto Garcia
On Mon 22 Feb 2016 05:41:27 PM CET, Eric Blake wrote: >> @@ -2590,6 +2590,18 @@ void qmp_block_set_io_throttle(const char *device, >> int64_t bps, int64_t bps_rd, >> int64_t iops_rd_max, >> bool has_iops_wr_max, >>

[Qemu-devel] [GIT PULL] pseries: Update SLOF firmware image to 20160223

2016-02-23 Thread Alexey Kardashevskiy
in the git repository at: g...@github.com:aik/qemu.git for you to fetch changes up to d618bd06b255fcde2111f5733f48d38f5b2532d6: pseries: Update SLOF firmware image to 20160223 (2016-02-23 18:11:17 +1100) Alexey Kardas

Re: [Qemu-devel] [PATCH 1/1] Postcopy+spice: Pass spice migration data earlier

2016-02-23 Thread Amit Shah
On (Mon) 22 Feb 2016 [17:17:32], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Spice hooks the migration status changes to figure out when to > transmit information to the new spice server; but the migration > status in postcopy doesn't quite fit - the destination start

Re: [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-23 Thread Thomas Huth
On 22.02.2016 20:28, Samuel Thibault wrote: > From: Yann Bordenave > > This patch adds parameters to manage some new options in the qemu -net > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in > argument to the qemu command. > Defaults parameters are respectivel

Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers

2016-02-23 Thread P J P
Hello Jason, +-- On Tue, 23 Feb 2016, Jason Wang wrote --+ | I mean with your patch, driver will only be allowed to set EN0_STOPPG | before EN0_STARTPG. So if a driver want to set STARTPG first, the check | | +if (v < NE2000_PMEM_END && v < s->stop) { | | will prevent the driver f

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

2016-02-23 Thread Juan Quintela
Greg Kurz wrote: > On Fri, 19 Feb 2016 11:11:47 +1100 > David Gibson wrote: > >> On Thu, Feb 18, 2016 at 12:32:11PM +0100, Greg Kurz wrote: >> > QEMU 2.4 broke the migration of old pseries machine with the addition >> > of configuration sections, which are sent unconditionally. >> > >> > We assu

Re: [Qemu-devel] [PATCH COLO-Frame v14 31/40] net/filter: Add a 'status' property for filter object

2016-02-23 Thread Jason Wang
On 02/18/2016 11:27 AM, Hailiang Zhang wrote: >>> +static void netfilter_set_status(Object *obj, const char *str, >>> Error **errp) >>> +{ >>> +NetFilterState *nf = NETFILTER(obj); >>> + >>> +if (!strcmp(str, "enable")) { >>> +nf->enabled = true; >>> +} else if (!strcmp(str, "

Re: [Qemu-devel] [PATCH COLO-Frame v14 32/40] net/filter: Introduce a helper to add a filter to the netdev

2016-02-23 Thread Jason Wang
On 02/18/2016 11:30 AM, Hailiang Zhang wrote: > On 2016/2/18 11:19, Jason Wang wrote: >> >> >> On 02/06/2016 05:28 PM, zhanghailiang wrote: >>> We add a new helper function netdev_add_filter(), >>> this function can help adding a filter object to a netdev. >>> >>> Signed-off-by: zhanghailiang >>

[Qemu-devel] [repost] KVM call minutes for 2016-02-16

2016-02-23 Thread Juan Quintela
Hi [I mistyped qemu-devel@ address on first submission, sorry.] Random ideas that I took for the talk, I hope that some of the active participants can reply with a more coherent view. State of the art (Andreas) - Having very specific socket objects - Dynamic allocation using new parameters - Wh

Re: [Qemu-devel] [RFC PATCH 01/16] doc: Add QBM format specification

2016-02-23 Thread Markus Armbruster
Eric Blake writes: > On 01/26/2016 03:38 AM, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> --- >> docs/specs/qbm.md | 118 >> ++ >> 1 file changed, 118 insertions(+) >> create mode 100644 docs/specs/qbm.md >> >> diff --git a/docs/specs/qb

Re: [Qemu-devel] [PATCH COLO-Frame v14 37/40] COLO: enable buffer filters for PVM

2016-02-23 Thread Jason Wang
On 02/18/2016 11:46 AM, Hailiang Zhang wrote: > On 2016/2/18 11:31, Jason Wang wrote: >> >> >> On 02/06/2016 05:28 PM, zhanghailiang wrote: >>> Enable all buffer filters that added by COLO while >>> go into COLO process, and disable them while exit COLO. >>> >>> Signed-off-by: zhanghailiang >>>

Re: [Qemu-devel] [RFC PATCH v0 7/8] qmp: Implement query cpu-packages

2016-02-23 Thread Igor Mammedov
On Mon, 22 Feb 2016 09:49:40 -0700 Eric Blake wrote: > On 02/21/2016 10:01 PM, Bharata B Rao wrote: > > Signed-off-by: Bharata B Rao > > --- > > hw/cpu/package.c| 19 + > > hw/ppc/spapr.c | 79 > > + > > include/hw/boards

Re: [Qemu-devel] [PATCH COLO-Frame v14 37/40] COLO: enable buffer filters for PVM

2016-02-23 Thread Jason Wang
On 02/18/2016 03:30 PM, Hailiang Zhang wrote: > Hi Jason, > > On 2016/2/18 11:46, Hailiang Zhang wrote: >> On 2016/2/18 11:31, Jason Wang wrote: >>> >>> >>> On 02/06/2016 05:28 PM, zhanghailiang wrote: Enable all buffer filters that added by COLO while go into COLO process, and disable

[Qemu-devel] [PATCH] ipack: Update e-mail address

2016-02-23 Thread Alberto Garcia
I'm not really using the old one anymore. Signed-off-by: Alberto Garcia --- hw/char/ipoctal232.c | 2 +- hw/ipack/ipack.c | 2 +- hw/ipack/tpci200.c | 2 +- include/hw/ipack/ipack.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/char/ipoctal232.c b/hw

[Qemu-devel] [PATCH v2] net: netmap: probe netmap interface for virtio-net header

2016-02-23 Thread Vincenzo Maffione
Previous implementation of has_ufo, has_vnet_hdr, has_vnet_hdr_len, etc. did not really probe for virtio-net header support for the netmap interface attached to the backend. These callbacks were correct for VALE ports, but incorrect for hardware NICs, pipes, monitors, etc. This patch fixes the imp

[Qemu-devel] [PATCH v2] net: netmap: implement virtio-net header probe

2016-02-23 Thread Vincenzo Maffione
Current implementation for netmap backend does not really probe the netmap kernel module to know whether virtio-net header is supported for a specific netmap port. This is only correct for VALE ports, but it is not correct for hardware ports, pipes, etc. This patch properly implements the missing

Re: [Qemu-devel] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm

2016-02-23 Thread Gerd Hoffmann
On Mo, 2016-02-22 at 13:30 +0100, Igor Mammedov wrote: > On Fri, 19 Feb 2016 13:20:24 -0500 > "Gabriel L. Somlo" wrote: > > Gerd, > > if you are going to apply it, you'll need to update > expected tables for acpi test (rebuild-expected-aml.sh) > as a commit on top of this series. Sure? Applied

[Qemu-devel] [PATCH v4 0/2] modify vote rules for flush operation

2016-02-23 Thread Changlong Xie
ChangLog: v4: 1. Introduce QUORUM_FLUSH_ERROR event to notify flush failure. v3: 1. *Note* that, the codes logic is different from what we talked in v2. I just keep flush interface the same logic as quorum read/write, and think it's reasoned. [Ref] http://lists.nongnu.org/archive/html/qemu-devel/2

[Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR

2016-02-23 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/quorum.c | 5 + docs/qmp-events.txt | 18 ++ qapi/event.json | 16 3 files changed, 39 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index f78d4cb..d3c3958 100644 --- a

[Qemu-devel] [PATCH v4 2/2] quorum: modify vote rules for flush operation

2016-02-23 Thread Changlong Xie
Keep flush interface the same logic as quorum read/write, Otherwise in following scenario, we'll encounter unexpected errors. Quorum has two children(A, B). A do flush sucessfully, but B flush failed. This cause the filesystem of guest become read-only with following errors: end_request: I/O erro

Re: [Qemu-devel] [PATCH qemu] memory: Fix IOMMU replay base address

2016-02-23 Thread Alexey Kardashevskiy
On 02/23/2016 05:20 PM, David Gibson wrote: On Tue, Feb 23, 2016 at 01:11:35PM +1100, Alexey Kardashevskiy wrote: On 02/22/2016 11:12 PM, David Gibson wrote: On Mon, Feb 22, 2016 at 10:36:19PM +1100, Alexey Kardashevskiy wrote: On 02/22/2016 05:26 PM, David Gibson wrote: On Mon, Feb 22, 2016

Re: [Qemu-devel] %cpu used by qemu-kvm processes

2016-02-23 Thread Jean-Pierre Ribeauville
Hi, Not yet … I’ ll do that . Is it a chance that it will be different with 2012R2 ? Regards, J.P. De : Felipe Franciosi [mailto:fel...@nutanix.com] Envoyé : lundi 22 février 2016 23:02 À : Jean-Pierre Ribeauville; Daniel P. Berrange Cc : qemu-devel@nongnu.org Objet : Re: [Qemu-devel] %cpu

Re: [Qemu-devel] [PATCH RESEND v2 1/2] qemu-file: Fix qemu_put_compression_data flaw

2016-02-23 Thread Li, Liang Z
Ping ... Liang > -Original Message- > From: Li, Liang Z > Sent: Friday, January 15, 2016 6:06 PM > To: qemu-devel@nongnu.org > Cc: quint...@redhat.com; amit.s...@redhat.com; dgilb...@redhat.com; > zhang.zhanghaili...@huawei.com; Li, Liang Z > Subject: [PATCH RESEND v2 1/2] qemu-file: Fix

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-23 Thread Peter Maydell
On 23 February 2016 at 05:11, hitmoon wrote: > > 在 2016年02月22日 19:03, Peter Maydell 写道: >> You'd basically need to have extra VMState structures for the >> devices themselves which just said "inside this M48txxISAState >> is an M48t59State", and "inside this M48txxSysBusState is a >> M48t59State"

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

2016-02-23 Thread Peter Maydell
On 23 February 2016 at 07:55, Richard Henderson wrote: > On 02/16/2016 03:45 AM, Peter Maydell wrote: >>> >>> Well, it doesn't repro on i686-linux; with a cross-compiler to mingw it >>> still might, but filing the bug will save me setting up the full cross >>> environment to be able to build qemu

Re: [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR

2016-02-23 Thread Changlong Xie
cc: Markus Armbruster On 02/23/2016 05:01 PM, Changlong Xie wrote: Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/quorum.c | 5 + docs/qmp-events.txt | 18 ++ qapi/event.json | 16 3 files changed, 39 insertions(+) diff

Re: [Qemu-devel] [PATCH v15 0/9] Block replication for continuous checkpoints

2016-02-23 Thread Changlong Xie
Ping again ... Thanks -Xie On 02/05/2016 12:17 PM, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features/Block

Re: [Qemu-devel] [PATCH RFC] fw-cfg: support writeable blobs

2016-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2016 at 08:07:17AM +0100, Gerd Hoffmann wrote: > On Mo, 2016-02-22 at 22:12 +0200, Michael S. Tsirkin wrote: > > On Mon, Feb 22, 2016 at 03:26:56PM +0100, Gerd Hoffmann wrote: > > > On Mo, 2016-02-22 at 14:41 +0200, Michael S. Tsirkin wrote: > > > > Useful to send guest data back to

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-02-23 Thread Peter Maydell
On 23 February 2016 at 07:30, Amit Shah wrote: > The following changes since commit 8eb779e4223a18db9838a49ece1bc72cfdfb7761: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-02-22 16:55:41 +) > > are available in the git repository at: > > https://g

Re: [Qemu-devel] [PATCH COLO-Frame v14 37/40] COLO: enable buffer filters for PVM

2016-02-23 Thread Hailiang Zhang
Hi Jason, Thanks for your patience. On 2016/2/23 16:38, Jason Wang wrote: On 02/18/2016 03:30 PM, Hailiang Zhang wrote: Hi Jason, On 2016/2/18 11:46, Hailiang Zhang wrote: On 2016/2/18 11:31, Jason Wang wrote: On 02/06/2016 05:28 PM, zhanghailiang wrote: Enable all buffer filters that

Re: [Qemu-devel] [RFC PATCH 00/16] Qemu Bit Map (QBM) - an overlay format for persistent dirty bitmap

2016-02-23 Thread Markus Armbruster
Kevin Wolf writes: > Am 26.01.2016 um 11:38 hat Fam Zheng geschrieben: >> This series introduces a simple format to enable support of persistence of >> block dirty bitmaps. Block dirty bitmap is the tool to achieve incremental >> backup, and persistence of block dirty bitmap makes incrememtal bac

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-02-23 Thread Amit Shah
On (Tue) 23 Feb 2016 [09:09:46], Peter Maydell wrote: > On 23 February 2016 at 07:30, Amit Shah wrote: > > The following changes since commit 8eb779e4223a18db9838a49ece1bc72cfdfb7761: > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > > staging (2016-02-22 16:55:41 +0

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread Bharata B Rao
On Tue, Feb 23, 2016 at 04:24:31PM +1100, David Gibson wrote: > Hi Andreas, > > I've now found (with Thomas' help) your RFC series for socket/core > based cpu hotplug on x86 > (https://github.com/afaerber/qemu-cpu/compare/qom-cpu-x86). It seems > sensible enough as far as it goes, but doesn't see

Re: [Qemu-devel] [PATCH] fixup! block-migration: acquire AioContext as necessary

2016-02-23 Thread Paolo Bonzini
On 23/02/2016 06:39, Fam Zheng wrote: > BTW, could you also explain the blk_mig_lock() question (*) I had? > > *: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03317.html Sorry, missed that: > >> @@ -597,21 +627,28 @@ static void block_migration_cleanup(void *opaque) >> { >>

Re: [Qemu-devel] CONFIG_EPOLL vs CONFIG_EPOLL_CREATE1

2016-02-23 Thread Matthew Fortune
Fam Zheng writes: > On Mon, 02/22 17:21, Matthew Fortune wrote: > > Hi, > > > > I've recently tried building qemu with a sysroot that has support > > for epoll_create but not epoll_create1. > > > > New code introduced in the following commit uses epoll_create1 but > > guards it using CONFIG_EPOLL

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-23 Thread Igor Mammedov
On Mon, 22 Feb 2016 13:54:32 +1100 David Gibson wrote: > On Fri, Feb 19, 2016 at 04:49:11PM +0100, Igor Mammedov wrote: > > On Fri, 19 Feb 2016 15:38:48 +1100 > > David Gibson wrote: > > > > CCing thread a couple of libvirt guys. > > > > > On Thu, Feb 18, 2016 at 11:37:39AM +0100, Igor Mamme

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-02-23 Thread Paolo Bonzini
On 23/02/2016 10:09, Peter Maydell wrote: > Hi. I'm afraid this doesn't compile for x86-64 Linux: What compiler is this, and does the following compile with no particular extra options? #pragma GCC target("avx2") #include __m256i foo; Paolo

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-23 Thread Markus Armbruster
Max Reitz writes: > On 22.02.2016 09:24, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 17.02.2016 17:20, Kevin Wolf wrote: Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: > On 17.02.2016 11:53, Kevin Wolf wrote: >> Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: >

Re: [Qemu-devel] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm

2016-02-23 Thread Igor Mammedov
On Tue, 23 Feb 2016 09:51:52 +0100 Gerd Hoffmann wrote: > On Mo, 2016-02-22 at 13:30 +0100, Igor Mammedov wrote: > > On Fri, 19 Feb 2016 13:20:24 -0500 > > "Gabriel L. Somlo" wrote: > > > > Gerd, > > > > if you are going to apply it, you'll need to update > > expected tables for acpi test (reb

Re: [Qemu-devel] [PATCH v9 3/5] acpi: pc: add fw_cfg device node to dsdt

2016-02-23 Thread Michael S. Tsirkin
On Fri, Feb 19, 2016 at 01:20:27PM -0500, Gabriel L. Somlo wrote: > Add a fw_cfg device node to the ACPI DSDT. While the guest-side > firmware can't utilize this information (since it has to access > the hard-coded fw_cfg device to extract ACPI tables to begin with), > having fw_cfg listed in ACPI

Re: [Qemu-devel] [PATCH v9 5/5] fw_cfg: document ACPI device node information

2016-02-23 Thread Michael S. Tsirkin
On Fri, Feb 19, 2016 at 01:20:29PM -0500, Gabriel L. Somlo wrote: > Signed-off-by: Gabriel Somlo > Reviewed-by: Laszlo Ersek > Reviewed-by: Marc Marí Reviewed-by: Michael S. Tsirkin > --- > docs/specs/fw_cfg.txt | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/docs/specs/fw

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-23 Thread Stefan Hajnoczi
On Mon, Feb 22, 2016 at 02:56:27PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi, Marc! > > Am I right, that this patch is necessary to reproduce your results from > "QEMU fw_cfg DMA interface"? > > >QEMU commit 2be4f242b50a8 and SeaBIOS commit 908a58c1d5ff > >QEMU startup time: .078 > >BIOS st

Re: [Qemu-devel] [PATCH v9 4/5] acpi: arm: add fw_cfg device node to dsdt

2016-02-23 Thread Michael S. Tsirkin
On Fri, Feb 19, 2016 at 01:20:28PM -0500, Gabriel L. Somlo wrote: > Add a fw_cfg device node to the ACPI DSDT. This is mostly > informational, as the authoritative fw_cfg MMIO region(s) > are listed in the Device Tree. However, since we are building > ACPI tables, we might as well be thorough while

Re: [Qemu-devel] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm

2016-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2016 at 09:51:52AM +0100, Gerd Hoffmann wrote: > On Mo, 2016-02-22 at 13:30 +0100, Igor Mammedov wrote: > > On Fri, 19 Feb 2016 13:20:24 -0500 > > "Gabriel L. Somlo" wrote: > > > > Gerd, > > > > if you are going to apply it, you'll need to update > > expected tables for acpi test

Re: [Qemu-devel] %cpu used by qemu-kvm processes

2016-02-23 Thread Felipe Franciosi
Yes I'd expect it to be very different. Make sure you enable hyperv enlightenment. Also disable USB, that will help too. Cheers, Felipe Sent from my phone On 23 Feb 2016, at 09:01, Jean-Pierre Ribeauville mailto:jpribeauvi...@axway.com>> wrote: Hi, Not yet … I’ ll do that . Is it a chance

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-02-23 Thread Li, Liang Z
> Cc: qemu list; Dr. David Alan Gilbert; Juan Quintela > Subject: Re: [Qemu-devel] [PULL 0/5] migration pull > > On 23 February 2016 at 07:30, Amit Shah wrote: > > The following changes since commit > 8eb779e4223a18db9838a49ece1bc72cfdfb7761: > > > > Merge remote-tracking branch 'remotes/kevin/

Re: [Qemu-devel] [PATCH RESEND v2 1/2] qemu-file: Fix qemu_put_compression_data flaw

2016-02-23 Thread Juan Quintela
"Li, Liang Z" wrote: > Ping ... > > Liang Hi >> We should fix this flaw to make it works with writable QEMUFile. >> >> Signed-off-by: Liang Li >> --- >> migration/qemu-file.c | 23 +-- >> 1 file changed, 21 insertions(+), 2 deletions(-) >> >> diff --git a/migration/qemu-f

Re: [Qemu-devel] [PATCH qemu] memory: Fix IOMMU replay base address

2016-02-23 Thread Paolo Bonzini
On 23/02/2016 10:00, Alexey Kardashevskiy wrote: >>> >>> tce = tcet->table[addr >> tcet->page_shift]; >>> -ret.iova = addr & page_mask; >>> +ret.iova = (addr + iommu->addr) & page_mask; >>> ret.translated_addr = tce & page_mask; >> >> I wondered about that chan

Re: [Qemu-devel] KVM call for agenda for 2016-02-16

2016-02-23 Thread Juan Quintela
Thomas Huth wrote: > On 17.02.2016 23:51, Juan Quintela wrote: >> Eduardo Habkost wrote: >>> On Tue, Feb 16, 2016 at 12:54:57PM +0100, Christian Borntraeger wrote: So my quick and dirty summary of CPU as _I_ understand it (and I only have some part time bandwidth at the moment for that)

Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries

2016-02-23 Thread Greg Kurz
On Tue, 23 Feb 2016 09:31:10 +0100 Juan Quintela wrote: > Greg Kurz wrote: > > On Fri, 19 Feb 2016 11:11:47 +1100 > > David Gibson wrote: > > > >> On Thu, Feb 18, 2016 at 12:32:11PM +0100, Greg Kurz wrote: > >> > QEMU 2.4 broke the migration of old pseries machine with the addition > >> > of

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-23 Thread hitmoon
在 2016年02月23日 17:04, Peter Maydell 写道: On 23 February 2016 at 05:11, hitmoon wrote: 在 2016年02月22日 19:03, Peter Maydell 写道: You'd basically need to have extra VMState structures for the devices themselves which just said "inside this M48txxISAState is an M48t59State", and "inside this M48txxS

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread David Gibson
On Tue, Feb 23, 2016 at 03:10:26PM +0530, Bharata B Rao wrote: > On Tue, Feb 23, 2016 at 04:24:31PM +1100, David Gibson wrote: > > Hi Andreas, > > > > I've now found (with Thomas' help) your RFC series for socket/core > > based cpu hotplug on x86 > > (https://github.com/afaerber/qemu-cpu/compare/q

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread Bharata B Rao
On Tue, Feb 23, 2016 at 03:10:26PM +0530, Bharata B Rao wrote: > > 5) QOM-links > > Andreas, You have often talked about setting up links from machine object > to the CPU objects. Would the below code correctly capture that idea of > yours ? > > #define SPAPR_MACHINE_CPU_CORE_PROP "core" > > /*

Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask

2016-02-23 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Richard Henderson" > Cc: "Paolo Bonzini" , qemu-devel@nongnu.org > Sent: Monday, February 22, 2016 10:56:03 PM > Subject: Re: [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask > > On Mon, Feb 22, 2016 at 11:14:44AM -0

Re: [Qemu-devel] [PATCH COLO-Frame v14 31/40] net/filter: Add a 'status' property for filter object

2016-02-23 Thread Hailiang Zhang
On 2016/2/23 16:34, Jason Wang wrote: On 02/18/2016 11:27 AM, Hailiang Zhang wrote: +static void netfilter_set_status(Object *obj, const char *str, Error **errp) +{ +NetFilterState *nf = NETFILTER(obj); + +if (!strcmp(str, "enable")) { +nf->enabled = true; +} else if (!strc

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-23 Thread Peter Maydell
On 23 February 2016 at 10:02, hitmoon wrote: > I still can NOT understand your intention properly. Can you explain more > clearly? VMState structures should generally mirror the structs they are saving/restoring. The M48txxISAState has an entry that just says "state is an M48t59State struct. Your

Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

2016-02-23 Thread hitmoon
在 2016年02月23日 18:26, Peter Maydell 写道: On 23 February 2016 at 10:02, hitmoon wrote: I still can NOT understand your intention properly. Can you explain more clearly? VMState structures should generally mirror the structs they are saving/restoring. The M48txxISAState has an entry that just sa

Re: [Qemu-devel] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm

2016-02-23 Thread Gerd Hoffmann
On Di, 2016-02-23 at 10:48 +0100, Igor Mammedov wrote: > On Tue, 23 Feb 2016 09:51:52 +0100 > Gerd Hoffmann wrote: > > > On Mo, 2016-02-22 at 13:30 +0100, Igor Mammedov wrote: > > > On Fri, 19 Feb 2016 13:20:24 -0500 > > > "Gabriel L. Somlo" wrote: > > > > > > Gerd, > > > > > > if you are goin

Re: [Qemu-devel] [PATCH qemu] migration/vmstate: document VMStateFlags

2016-02-23 Thread Amit Shah
On (Thu) 21 Jan 2016 [21:39:27], Sascha Silbe wrote: > The VMState API is rather sparsely documented. Start by describing the > meaning of all VMStateFlags. > > Signed-off-by: Sascha Silbe Reviewed-by: Amit Shah > --- > Since I had to dive into the code for debugging the migration breakage > a

Re: [Qemu-devel] [PATCH] qed: fix bdrv_qed_drain

2016-02-23 Thread Paolo Bonzini
On 23/02/2016 06:57, Fam Zheng wrote: +qed_cancel_need_check_timer(s); +qed_need_check_timer_cb(s); +} >>> >>> What if an allocating write is queued (the else branch case)? Its completion >>> will be in bdrv_drain and it could arm the need_check_timer which is w

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-02-23 Thread Peter Maydell
On 23 February 2016 at 09:48, Paolo Bonzini wrote: > On 23/02/2016 10:09, Peter Maydell wrote: >> Hi. I'm afraid this doesn't compile for x86-64 Linux: > > What compiler is this, and does the following compile with no particular > extra options? > > #pragma GCC target("avx2") > #include > __m256i

Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-23 Thread Amit Shah
Hi Denis, On (Tue) 23 Feb 2016 [13:09:26], Amit Shah wrote: > On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote: > > There is a possibility to hit an assert in qcow2_get_specific_info that > > s->qcow_version is undefined. This happens when VM in starting from > > suspended state, i.e. it proc

[Qemu-devel] [PATCH v2] qmp-shell: fix pretty printing of JSON responses

2016-02-23 Thread Daniel P. Berrange
Pretty printing of JSON responses is important to be able to understand large responses from query commands in particular. Unfortunately this was broken during the addition of the verbose flag in commit 1ceca07e48ead0dd2e41576c81d40e6a91cafefd Author: John Snow Date: Wed Apr 29 15:14:04 2

[Qemu-devel] [PATCH 2/3] arm: gic: add "query-gic-capability" interface

2016-02-23 Thread Peter Xu
This is ARM-only command. Signed-off-by: Peter Xu --- monitor.c| 8 qapi-schema.json | 11 +++ qmp-commands.hx | 25 + scripts/qapi.py | 1 + target-arm/machine.c | 7 +++ 5 files changed, 52 insertions(+) diff --git a/mo

[Qemu-devel] [PATCH 1/3] arm: gic: add GICType

2016-02-23 Thread Peter Xu
A new enum type is added to define ARM GIC types. Signed-off-by: Peter Xu --- qapi-schema.json | 17 + 1 file changed, 17 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 8d04897..81654bd 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4083,3 +4083,2

[Qemu-devel] [PATCH 0/3] ARM: add query-gic-capability SMP command

2016-02-23 Thread Peter Xu
This patch is to add ARM-specific command "query-gic-capability". This command can report which kind of GIC device the host/QEMU support. The returned result is in the form of array. One example would be: {"execute": "query-gic-capability"} {"return": ["gicv2-kvm", "gicv2"]} For more information

[Qemu-devel] [PATCH 3/3] arm: implement query-gic-capability

2016-02-23 Thread Peter Xu
For emulated ARM VM, only gicv2 is supported. We need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the capability bits using ioctls. Signed-off-by: Peter Xu --- target-arm/machine.c | 32 +++- 1 file changed, 31 insertions(+), 1 del

Re: [Qemu-devel] [PATCH] qmp-shell: fix pretty printing of JSON responses

2016-02-23 Thread Daniel P. Berrange
On Mon, Feb 22, 2016 at 03:02:03PM -0700, Eric Blake wrote: > On 02/22/2016 10:02 AM, Daniel P. Berrange wrote: > > Pretty printing of JSON responses is important to be able > > to understand large responses from query commands in > > particular, eg > > > > (QEMU) query-chardev > > { u'return':

[Qemu-devel] [PULL 2/6] tusb6010: move from hw/timer to hw/usb

2016-02-23 Thread Gerd Hoffmann
From: Peter Maydell The TUSB6010 is a USB controller (as the name suggests). Move it from hw/timer (where it was accidentally filed in 2013 when we moved everything out of hw/) to hw/usb. Signed-off-by: Peter Maydell Message-id: 1455883404-10976-1-git-send-email-peter.mayd...@linaro.org Signed-

[Qemu-devel] [PULL 1/6] usb: check USB configuration descriptor object

2016-02-23 Thread Gerd Hoffmann
From: Prasad J Pandit When processing remote NDIS control message packets, the USB Net device emulator checks to see if the USB configuration descriptor object is of RNDIS type(2). But it does not check if it is null, which leads to a null dereference error. Add check to avoid it. Reported-by: Q

[Qemu-devel] [PULL 0/6] usb: misc bugfixes

2016-02-23 Thread Gerd Hoffmann
2 16:55:41 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20160223-1 for you to fetch changes up to fa1298c2d623522eda7b4f1f721fcb935abb7360: ohci: allocate timer only once. (2016-02-23 11:1

[Qemu-devel] [PULL 4/6] usb: check RNDIS buffer offsets & length

2016-02-23 Thread Gerd Hoffmann
From: Prasad J Pandit When processing remote NDIS control message packets, the USB Net device emulator uses a fixed length(4096) data buffer. The incoming informationBufferOffset & Length combination could overflow and cross that range. Check control message buffer offsets and length to avoid it.

[Qemu-devel] [PULL 5/6] usb: add pid check at the first of uhci_handle_td()

2016-02-23 Thread Gerd Hoffmann
From: Gonglei pid can be gotten from uhci device memory in uhci_handle_td(), so the guest can trigger assert qemu if we get an invalid pid. And the uhci spec 2.1.2 tells us The Host Controller sets Host Controller Process Error bit to 1 when it detects a fatal error and indicates that the Host Co

[Qemu-devel] [PULL 6/6] ohci: allocate timer only once.

2016-02-23 Thread Gerd Hoffmann
Allocate timer once, at init time, instead of allocating/freeing it all the time when starting/stopping the bus. Simplifies the code, also fixes bugs (memory leak) due to missing checks whenever the time is already allocated or not. Cc: Prasad J Pandit Reported-by: Zuozhi Fzz Signed-off-by: Ger

[Qemu-devel] [PULL 3/6] usb: check RNDIS message length

2016-02-23 Thread Gerd Hoffmann
From: Prasad J Pandit When processing remote NDIS control message packets, the USB Net device emulator uses a fixed length(4096) data buffer. The incoming packet length could exceed this limit. Add a check to avoid it. Signed-off-by: Prasad J Pandit Message-id: 1455648821-17340-2-git-send-email

Re: [Qemu-devel] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm

2016-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2016 at 11:39:05AM +0100, Gerd Hoffmann wrote: > On Di, 2016-02-23 at 10:48 +0100, Igor Mammedov wrote: > > On Tue, 23 Feb 2016 09:51:52 +0100 > > Gerd Hoffmann wrote: > > > > > On Mo, 2016-02-22 at 13:30 +0100, Igor Mammedov wrote: > > > > On Fri, 19 Feb 2016 13:20:24 -0500 > > >

Re: [Qemu-devel] [PATCH] net: check packet payload length

2016-02-23 Thread P J P
Hello Jason, +-- On Tue, 23 Feb 2016, Jason Wang wrote --+ | Let's avoid adding assert() here since it could be triggered by guest. Okay. | I think you need audit all the callers to see if the issue mentioned by | Markus existed first. Yes, I did. As mentioned earlier, some have check for

Re: [Qemu-devel] [PATCH 2/4] s390x/css: Allocate channel_subsys statically

2016-02-23 Thread Cornelia Huck
On Wed, 17 Feb 2016 19:03:12 -0200 Eduardo Habkost wrote: > On Wed, Feb 17, 2016 at 12:43:13PM +0100, Cornelia Huck wrote: > > On Tue, 16 Feb 2016 18:59:05 -0200 > > Eduardo Habkost wrote: > > > > > There's no need to use g_malloc0() to allocate the channel_subsys > > > struct, just use a stati

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-02-23 Thread Li, Liang Z
> On 23 February 2016 at 09:48, Paolo Bonzini wrote: > > On 23/02/2016 10:09, Peter Maydell wrote: > >> Hi. I'm afraid this doesn't compile for x86-64 Linux: > > > > What compiler is this, and does the following compile with no > > particular extra options? > > > > #pragma GCC target("avx2") > > #

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread Igor Mammedov
On Tue, 23 Feb 2016 21:05:04 +1100 David Gibson wrote: > On Tue, Feb 23, 2016 at 03:10:26PM +0530, Bharata B Rao wrote: > > On Tue, Feb 23, 2016 at 04:24:31PM +1100, David Gibson wrote: > > > Hi Andreas, > > > > > > I've now found (with Thomas' help) your RFC series for socket/core > > > based

[Qemu-devel] [PATCH 04/10] s390x: remove {kvm_}s390_virtio_irq()

2016-02-23 Thread Cornelia Huck
This interface was only used by the old virtio machine and therefore is not needed anymore. Reviewed-by: David Hildenbrand Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- target-s390x/cpu.h | 5 - target-s390x/interrupt.c | 11 --- target-s390x/kvm.c | 11 ---

[Qemu-devel] [PATCH 06/10] s390x/virtio: old machine leftovers

2016-02-23 Thread Cornelia Huck
Remove some now unused #defines. Reviewed-By: Sascha Silbe Reviewed-by: Halil Pasic Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c index c320878..8e533ae 100644 --- a/hw/s390x/s390-vir

[Qemu-devel] [PATCH 02/10] s390x/kvm: sync fprs via kvm_run

2016-02-23 Thread Cornelia Huck
From: David Hildenbrand We can now also sync the fprs via kvm_run, avoiding one ioctl. Reviewed-by: Christian Borntraeger Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- target-s390x/kvm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/target-s390x/kvm.c b

[Qemu-devel] [PATCH 03/10] s390x: fix debug statement in trigger_page_fault()

2016-02-23 Thread Cornelia Huck
From: David Hildenbrand When mmu_translate debugging output is enabled, code won't compile. Let's just use the same statement as in trigger_prot_fault(). Acked-by: Cornelia Huck Signed-off-by: David Hildenbrand Signed-off-by: Cornelia Huck --- target-s390x/mmu_helper.c | 2 +- 1 file changed

[Qemu-devel] [PATCH 01/10] linux-headers: update against kvm/next

2016-02-23 Thread Cornelia Huck
Update against commit efef127c, but keep userfaultd.h. Signed-off-by: Cornelia Huck --- linux-headers/asm-arm/unistd.h | 2 ++ linux-headers/asm-powerpc/unistd.h | 13 + linux-headers/asm-s390/kvm.h | 11 +-- linux-headers/asm-s390/unistd.h| 3 ++- linux-heade

[Qemu-devel] [PATCH 10/10] s390x/css: Use static initialization for channel_subsys fields

2016-02-23 Thread Cornelia Huck
From: Eduardo Habkost machine_init() will be gone, but we don't need it if we just initialize the channel_subsys fields statically. Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Eduardo Habkost Message-Id: <1455656347-29033-4-git-send-em

[Qemu-devel] [PATCH 09/10] s390x/css: Allocate channel_subsys statically

2016-02-23 Thread Cornelia Huck
From: Eduardo Habkost There's no need to use g_malloc0() to allocate the channel_subsys struct, just use a static variable. Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Eduardo Habkost Message-Id: <1455656347-29033-3-git-send-email-ehab

[Qemu-devel] [PATCH 08/10] s390x/pci: fix reg/dereg irq functions

2016-02-23 Thread Cornelia Huck
From: Yi Min Zhao Indicator refcounting interfaces are introduced. This patch fixes introducing unneeded indicator mappings and failure to release AISB mappings on deregistration. Signed-off-by: Yi Min Zhao Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.h

[Qemu-devel] [PATCH 07/10] s390x/css: introduce indicator refcounting interfaces

2016-02-23 Thread Cornelia Huck
From: Yi Min Zhao Currently, virtio-ccw uses its own interfaces to keep indicators mapped just once even if the same address has been registered multiple times. These interfaces fit the PCI use case as well. Therefore, move them to css and make them generic interfaces. Signed-off-by: Yi Min Zhao

[Qemu-devel] [PATCH 00/10] s390x: pending patches

2016-02-23 Thread Cornelia Huck
Currently pending in my queue are some fixes, improvements and cleanups. I'd like to include the s390x cpu hotplug patches as well in my next pull request once we arrive at a version everybody is happy with. Cornelia Huck (3): linux-headers: update against kvm/next s390x: remove {kvm_}s390_vi

Re: [Qemu-devel] [PULL 0/5] migration pull

2016-02-23 Thread Peter Maydell
On 23 February 2016 at 10:43, Peter Maydell wrote: > That code fragment you suggest compiles fine normally, but not if I > add -save-temps: > > $ cat /tmp/zz9.c > #pragma GCC target("avx2") > #include > __m256i foo; > $ gcc -g -Wall -o /tmp/zz9.o -c /tmp/zz9.c > $ echo $? > 0 > $ gcc -g -Wall -o

[Qemu-devel] [PATCH 05/10] watchdog/diag288: avoid race condition on expired watchdog

2016-02-23 Thread Cornelia Huck
From: Sascha Silbe When configured to inject an NMI, watchdog_perform_action() may cause the BQL to be temporarily relinquished (inject_nmi() → ... → s390_nmi() → s390_cpu_restart() → run_on_cpu()). When the guest issues diag 288 again in response to the NMI, the diag 288 operation will race agai

Re: [Qemu-devel] [RFC PATCH 00/16] Qemu Bit Map (QBM) - an overlay format for persistent dirty bitmap

2016-02-23 Thread Kevin Wolf
Am 23.02.2016 um 10:14 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 26.01.2016 um 11:38 hat Fam Zheng geschrieben: > >> This series introduces a simple format to enable support of persistence of > >> block dirty bitmaps. Block dirty bitmap is the tool to achieve incremental >

Re: [Qemu-devel] [PATCH] aio-posix: Don't use epoll if epoll_create1 not available

2016-02-23 Thread Stefan Hajnoczi
On Tue, Feb 23, 2016 at 09:20:14AM +0800, Fam Zheng wrote: > Reported-by: Matthew Fortune > Signed-off-by: Fam Zheng > --- > aio-posix.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/aio-posix.c b/aio-posix.c > index fa7f8ab..97e5a0c 100644 > --- a/aio-posix.c

Re: [Qemu-devel] [PATCH qemu] memory: Fix IOMMU replay base address

2016-02-23 Thread David Gibson
On Tue, Feb 23, 2016 at 10:56:57AM +0100, Paolo Bonzini wrote: > > > On 23/02/2016 10:00, Alexey Kardashevskiy wrote: > >>> > >>> tce = tcet->table[addr >> tcet->page_shift]; > >>> -ret.iova = addr & page_mask; > >>> +ret.iova = (addr + iommu->addr) & page_mask; > >>>

Re: [Qemu-devel] [PATCH v2] qmp-shell: fix pretty printing of JSON responses

2016-02-23 Thread Kashyap Chamarthy
On Tue, Feb 23, 2016 at 10:51:46AM +, Daniel P. Berrange wrote: > Pretty printing of JSON responses is important to be able to understand > large responses from query commands in particular. Unfortunately this > was broken during the addition of the verbose flag in > > commit 1ceca07e48ead0d

  1   2   3   4   >