On Wed, 17 Feb 2016 15:32:06 +0800
Jevon Qiao wrote:
> Hi Daniel,
>
> Thank you for reviewing my code, please see my reply in-line.
> On 15/2/16 17:17, Daniel P. Berrange wrote:
> > On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote:
> >> diff --git a/configure b/configure
> >> index 8
+-- On Tue, 16 Feb 2016, Gerd Hoffmann wrote --+
| > @@ -172,11 +172,18 @@ static void do_token_in(USBDevice *s, USBPacket *p)
| > assert(p->ep->nr == 0);
| > +if (s->setup_len > sizeof(s->data_buf)) {
| > +fprintf(stderr,
| > +"usb_generic_handle_packet: ctrl buffe
On 14.02.2016 18:47, Samuel Thibault wrote:
> From: Guillaume Subiron
>
> Basically, this patch adds some switch in various TCP functions to
> prepare them for the IPv6 case.
>
> To have something to "switch" in tcp_input() and tcp_respond(), a new
> argument is used to give them the sa_family o
Add the handler code for incoming TFTP packets to udp6_input(),
and make sure that the TFTP code can send packets with both,
udp_output() and udp6_output() by introducing a wrapper function
called tftp_udp_output().
Signed-off-by: Thomas Huth
---
v2: Changes according to the review of Samuel Thi
Thomas Huth, on Wed 17 Feb 2016 09:40:10 +0100, wrote:
> Add the handler code for incoming TFTP packets to udp6_input(),
> and make sure that the TFTP code can send packets with both,
> udp_output() and udp6_output() by introducing a wrapper function
> called tftp_udp_output().
>
> Signed-off-by:
On Wed, Feb 17, 2016 at 07:51:12AM +, Tian, Kevin wrote:
> > From: Neo Jia [mailto:c...@nvidia.com]
> > Sent: Wednesday, February 17, 2016 3:32 PM
> >
> > On Wed, Feb 17, 2016 at 07:52:53AM +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > The answer is simple, having a UUID as part of the
On 17/2/16 16:01, Greg Kurz wrote:
On Wed, 17 Feb 2016 15:32:06 +0800
Jevon Qiao wrote:
Hi Daniel,
Thank you for reviewing my code, please see my reply in-line.
On 15/2/16 17:17, Daniel P. Berrange wrote:
On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote:
diff --git a/configure b/c
> From: Neo Jia [mailto:c...@nvidia.com]
> Sent: Wednesday, February 17, 2016 3:55 PM
>
> On Wed, Feb 17, 2016 at 07:46:15AM +, Tian, Kevin wrote:
> > > From: Neo Jia
> > > Sent: Wednesday, February 17, 2016 3:26 PM
> > >
> > >
> >
> > >
> > > If your most concern is having this kind of path d
> From: Neo Jia [mailto:c...@nvidia.com]
> Sent: Wednesday, February 17, 2016 4:41 PM
>
> On Wed, Feb 17, 2016 at 07:51:12AM +, Tian, Kevin wrote:
> > > From: Neo Jia [mailto:c...@nvidia.com]
> > > Sent: Wednesday, February 17, 2016 3:32 PM
> > >
> > > On Wed, Feb 17, 2016 at 07:52:53AM +0100,
On 14.02.2016 18:47, Samuel Thibault wrote:
> From: Guillaume Subiron
>
> No code change.
>
> Signed-off-by: Guillaume Subiron
> Signed-off-by: Samuel Thibault
> ---
> slirp/tcp_input.c | 92
> +++---
> slirp/tcp_output.c | 29 +---
On Wed, 17 Feb 2016 16:49:33 +0800
Jevon Qiao wrote:
> On 17/2/16 16:01, Greg Kurz wrote:
> > On Wed, 17 Feb 2016 15:32:06 +0800
> > Jevon Qiao wrote:
> >
> >> Hi Daniel,
> >>
> >> Thank you for reviewing my code, please see my reply in-line.
> >> On 15/2/16 17:17, Daniel P. Berrange wrote:
On 14.02.2016 18:47, Samuel Thibault wrote:
> From: Guillaume Subiron
>
> This patch adds IPv6 case in TCP functions refactored by the last
> patches.
> This also adds IPv6 pseudo-header in tcpiphdr structure.
> Finally, tcp_input() is called by ip6_input().
>
> Signed-off-by: Guillaume Subiron
On 14.02.2016 18:47, Samuel Thibault wrote:
> From: Guillaume Subiron
>
> This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is
> developed using this Slirp attribute.
> sotranslate_in/out/accept() are also updated to manage the IPv6 case so the
> guest can be able to join the host
On Tue, 16 Feb 2016 17:09:52 +
"Dr. David Alan Gilbert" wrote:
> * Laurent Vivier (lviv...@redhat.com) wrote:
> >
> >
> > On 16/02/2016 10:09, Greg Kurz wrote:
> > > On Mon, 15 Feb 2016 15:49:17 +0100
> > > Laurent Vivier wrote:
> > >
> > >> On 15/02/2016 13:58, Greg Kurz wrote:
> >
Thomas Huth, on Wed 17 Feb 2016 10:18:20 +0100, wrote:
> > @@ -204,6 +218,20 @@ tcp_respond(struct tcpcb *tp, struct tcpiphdr *ti,
> > struct mbuf *m,
> > (void) ip_output((struct socket *)0, m);
> > break;
> >
> > + case AF_INET6:
> > + m->m_data += sizeof(struct tcpiphd
On Wed, Feb 17, 2016 at 08:57:08AM +, Tian, Kevin wrote:
> > From: Neo Jia [mailto:c...@nvidia.com]
> > Sent: Wednesday, February 17, 2016 3:55 PM
>
> 'whoever' is too strict here. I don't think UUID is required in all scenarios.
>
> In your scenario:
>
> - You will pass VM UUID when creatin
ping...
COLO prototype is based on this series, but it seems that this
series didn't got enough reviewing and feedback, we will miss
the train of qemu 2.6 version :(
Since COLO is still a prototype, some problems could be fixed in
later developing, and we hope COLO prototype to be merged as quick
Thomas Huth, on Wed 17 Feb 2016 10:28:26 +0100, wrote:
> On 14.02.2016 18:47, Samuel Thibault wrote:
> > From: Guillaume Subiron
> >
> > This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is
> > developed using this Slirp attribute.
> > sotranslate_in/out/accept() are also updated
From: Didier Pallard
Since guest_mask_notifier can not be used in vhost-user mode due
to buffering implied by unix control socket, force
use_mask_notifier on virtio devices of vhost-user interfaces, and
send correct callfd to the guest at vhost start.
Using guest_notifier_mask function in vhost-
On Wed, Feb 17, 2016 at 03:32:06PM +0800, Jevon Qiao wrote:
> Hi Daniel,
>
> Thank you for reviewing my code, please see my reply in-line.
> On 15/2/16 17:17, Daniel P. Berrange wrote:
> >On Sun, Feb 14, 2016 at 01:06:40PM +0800, Jevon Qiao wrote:
> >>+
> >>+static int cephfs_parse_opts(QemuOpts *
Public bug reported:
[Impact]
* vhost-user falls back to virtio-net which causes performance lose
without specifying the vhostforce option. But it should be the default
behavior for vhost-user, since guests using PMD doesn't support msi-x.
[Test Case]
create a vhost-user virtio backend witho
> From: Neo Jia [mailto:c...@nvidia.com]
> Sent: Wednesday, February 17, 2016 5:35 PM
>
> On Wed, Feb 17, 2016 at 08:57:08AM +, Tian, Kevin wrote:
> > > From: Neo Jia [mailto:c...@nvidia.com]
> > > Sent: Wednesday, February 17, 2016 3:55 PM
> >
> > 'whoever' is too strict here. I don't think U
On Tue, Feb 16, 2016 at 05:28:58PM +, Peter Maydell wrote:
> The current documentation of chardev mux=on is rather brief and opaque;
> expand it to hopefully be a bit more helpful.
>
> Signed-off-by: Peter Maydell
> ---
> There was some discussion on #qemu yesterday evening about multiplexing
On Tue, Feb 16, 2016 at 04:38:04PM +0100, Alberto Garcia wrote:
> On Mon 15 Feb 2016 05:40:29 PM CET, Stefan Hajnoczi wrote:
> > On Fri, Feb 05, 2016 at 12:59:10PM +0200, Alberto Garcia wrote:
> >> - With this series we set "a maximum of X operations/second for a
> >>period of T seconds". If w
Hi,
On 16 February 2016 at 00:47, Laurent Vivier wrote:
> Ping?
It looks good to me. But I'd like to see some ack/review from
Alexander or Michael.
Riku
> Le 29/01/2016 17:07, Laurent Vivier a écrit :
>> Original qemu-binfmt-conf.h is only able to write configuration
>> into /proc/sys/fs/binfm
Looks good overall, some comments:
On Wed, Feb 17, 2016 at 11:35:48AM +0200, Victor Kaplansky wrote:
> From: Didier Pallard
>
> Since guest_mask_notifier can not be used in vhost-user mode due
> to buffering implied by unix control socket, force
> use_mask_notifier on virtio devices of vhost-use
Am 16.02.2016 um 19:08 hat Max Reitz geschrieben:
> Signed-off-by: Max Reitz
In the long run, I guess we want to have to separate types, one of which
accepts only BlockBackend names and the other one BB and BDS names.
Though I think that most HMP commands currently require a BB, so this
patch is
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 51 ++-
1 file changed, 26 insertions(+
This series of patches expands the syntax of the qemu-img,
qemu-nbd and qemu-io commands to make them more flexible.
v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html
v2: https://lists.gnu.org/archi
Allow creation of user creatable object types with qemu-io
via a new --object command line arg. This will be used to supply
passwords and/or encryption keys to the various block driver
backends via the recently added 'secret' object type.
# printf letmein > mypasswd.txt
# qemu-io --object secret
Currently qemu-io allows an image filename to be passed on the
command line, but unless using the JSON format, it does not have
a way to set any options except the format eg
qemu-io https://127.0.0.1/images/centos7.iso
qemu-io /home/berrange/demo.qcow2
By contrast when using the interactive she
When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletion
Currently qemu-img allows an image filename to be passed on the
command line, but unless using the JSON format, it does not have
a way to set any options except the format eg
qemu-img info https://127.0.0.1/images/centos7.iso
This adds a --image-opts arg that indicates that the positional
file
Allow creation of user creatable object types with qemu-img
via a new --object command line arg. This will be used to supply
passwords and/or encryption keys to the various block driver
backends via the recently added 'secret' object type.
# printf letmein > mypasswd.txt
# qemu-img info --object
Currently qemu-nbd allows an image filename to be passed on the
command line, but unless using the JSON format, it does not have
a way to set any options except the format eg
qemu-nbd https://127.0.0.1/images/centos7.iso
qemu-nbd /home/berrange/demo.qcow2
This adds a --image-opts arg that i
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-io.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
di
On Mon, Feb 15, 2016 at 04:53:27PM +0100, Kevin Wolf wrote:
> Am 15.02.2016 um 15:33 hat Daniel P. Berrange geschrieben:
> > This series of patches expands the syntax of the qemu-img,
> > qemu-nbd and qemu-io commands to make them more flexible.
> >
> > v0: https://lists.gnu.org/archive/html/qem
Eric Blake writes:
> On 02/16/2016 10:35 AM, Daniel P. Berrange wrote:
>> In my LUKS encryption series, I have a discriminated union for
>> storing options for different encryption formats. See qapi/crypto.json
>> in this file:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg031
On Wed, 17 Feb 2016 15:14:48 +0800
Jevon Qiao wrote:
> Hi Aneesh,
>
> Thank you for reviewing my code, please see my reply in-line.
Jevon,
Please read comments below.
> On 14/2/16 21:38, Aneesh Kumar K.V wrote:
> > Jevon Qiao writes:
> >
> >> The following patch is to fix alignment issue w
This patchset extended the PCI IOMMU Ops. Currently, there is only
one IOMMU op which is to lookup the address space. One more
operation is added to do further interrupt remapping.
This is a RFC patch before moving on to further enable IR for
Intel IOMMU.
Please help review!
Thanks.
Peter
Pete
There could be more than one ops for IOMMU in the future. Renaming
PCIIOMMUFunc to a more specific name better describes what it does,
which is to do address space lookup.
Signed-off-by: Peter Xu
---
hw/pci/pci.c | 2 +-
include/hw/pci/pci.h | 4 ++--
include/hw/pci/pci_bus.h | 2
This patch extended the current PCI IOMMU functions into operation list,
one new op is added to do interrupt remapping.
Currently it is not working since int_remap is always NULL. It only
provide a interface to extend PCI MSI to support interrupt remapping in
the future.
One helper function pci_s
Am 16.02.2016 um 19:08 hat Max Reitz geschrieben:
> There may be BlockBackends which are not returned by blk_by_name(), but
> do exist and have a name.
Really? And if so, isn't this a bug?
I expect that a BB is always either visible to the user and has a name
that is resolved to this BB everywher
On Wed, Feb 17, 2016 at 09:52:04AM +, Tian, Kevin wrote:
> > From: Neo Jia [mailto:c...@nvidia.com]
> > Sent: Wednesday, February 17, 2016 5:35 PM
> >
> > On Wed, Feb 17, 2016 at 08:57:08AM +, Tian, Kevin wrote:
> > > > From: Neo Jia [mailto:c...@nvidia.com]
> > > > Sent: Wednesday, Februa
On 09/02/2016 19:13, Richard Henderson wrote:
>>
>> +{
>> +if ((env->cr[4] & CR4_PKE_MASK) == 0) {
>> +raise_exception_err_ra(env, EXCP06_ILLOP, 0, GETPC());
>> +return;
>> +}
>
> The document I have says #GP for this case, not #UD.
The text says #GP, the "Protected Mode
Am 17.02.2016 um 11:10 hat Daniel P. Berrange geschrieben:
> On Mon, Feb 15, 2016 at 04:53:27PM +0100, Kevin Wolf wrote:
> > Am 15.02.2016 um 15:33 hat Daniel P. Berrange geschrieben:
> > > This series of patches expands the syntax of the qemu-img,
> > > qemu-nbd and qemu-io commands to make them m
On Wed, Feb 17, 2016 at 11:37:52AM +0100, Kevin Wolf wrote:
> Am 17.02.2016 um 11:10 hat Daniel P. Berrange geschrieben:
> > On Mon, Feb 15, 2016 at 04:53:27PM +0100, Kevin Wolf wrote:
> > > Am 15.02.2016 um 15:33 hat Daniel P. Berrange geschrieben:
> > > > This series of patches expands the syntax
From: Chen Fan
this is the part 2 of supporting vfio device with aer enabled, the part 1
has been sent out. the code based on v16 series patchset.
v16 -> this:
main code changed on the 7/10 and 8/10 patches. others patches only
fix some trivial comments or codes sugguested by Marcel.
Chen
From: Chen Fan
the function is used to get affected devices by bus reset.
so here extract it, and can used for aer soon.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 66 +++
1 file changed, 48 insertions(+), 18 deletions(-)
diff --git a/h
From: Chen Fan
when the vfio device encounters an uncorrectable error in host,
the vfio_pci driver will signal the eventfd registered by this
vfio device, resulting in the qemu eventfd handler getting
invoked.
this patch is to pass the error to guest and let the guest driver
recover from the err
From: Chen Fan
when boot up a VM that assigning vfio devices with aer enabled, we
must check the vfio device whether support host bus reset. because
when one error occur. OS driver always recover the device by do a
bus reset, in order to recover the vfio device, qemu must to do a
host bus reset t
From: Chen Fan
squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 75 +++
1 file changed, 44 insertions(+), 31 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
ind
From: Chen Fan
Since we support multi-function hotplug, the function 0 indicates
the closure of the slot, so we have the chance to do the check.
Signed-off-by: Chen Fan
---
hw/pci/pci.c | 29 +
hw/vfio/pci.c| 19 +++
hw/vfio/p
From: Chen Fan
For vfio pcie device, we could expose the extended capability on
PCIE bus. due to add a new pcie capability at the tail of the chain,
in order to avoid config space overwritten, we introduce a copy config
for parsing extended caps. and rebuild the pcie extended config space.
Signe
From: Chen Fan
Calling pcie_aer_init to initilize aer related registers for
vfio device, then reload physical related registers to expose
device capability.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 81 ---
hw/vfio/pci.h | 3 +++
2 fil
> From: Neo Jia [mailto:c...@nvidia.com]
> Sent: Wednesday, February 17, 2016 6:34 PM
>
> >
> > Qemu is not a kernel component. And UUID is OPTIONAL for Qemu.
> >
> > KVM is the kernel component. It doesn't use UUID at all. the relation
> > between
> > UUID and VM is fully maintained in user spac
From: Chen Fan
avoid repeat bus reset, here introduce a sequence ID for each time
bus hot reset, so each vfio device could know whether they've already
been reset for that sequence ID.
Signed-off-by: Chen Fan
---
hw/core/qdev.c | 4 ++--
hw/pci/pci.c | 25 +++
From: Chen Fan
avoid multi-reset host bus, we introduce sequence id to specify which
bus is resetting. and if one of the dependent devices has done a reset.
the others should skip.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 14 ++
hw/vfio/pci.h | 3 +++
2 files changed, 17 insert
Am 16.02.2016 um 19:08 hat Max Reitz geschrieben:
> The monitor does hold references to some BlockBackends so it should have
s/does hold/holds/?
> a list of those BBs; blk_backends is a different list, as it contains
> references to all BBs (after a follow-up patch, that is), and that
> should no
> From: Alex Williamson
> Sent: Wednesday, February 17, 2016 5:39 AM
>
> QEMU provides two fw_cfg files to support IGD. The first holds the
> OpRegion data which holds the Video BIOS Table (VBT). This needs to
> be copied into reserved memory and the address stored in the ASL
> Storage register
> From: Alex Williamson
> Sent: Wednesday, February 17, 2016 5:32 AM
>
> v3:
Alex, thanks a lot for your enhancement, which should make future
vgpu work easier!
>
> Quite a bit of restructuring, functional differences include exposing
> another fw_cfg file to indicate the size of the stolen mem
On 17/02/2016 03:57, Fam Zheng wrote:
> On Tue, 02/16 16:53, Paolo Bonzini wrote:
>> The current implementation of bdrv_qed_drain can cause a double
>> completion of a request.
>>
>> The problem is that bdrv_qed_drain calls qed_plug_allocating_write_reqs
>> unconditionally, but this is not correc
On Tue, 16 Feb 2016 18:59:05 -0200
Eduardo Habkost wrote:
> There's no need to use g_malloc0() to allocate the channel_subsys
> struct, just use a static variable.
The original intention was to model that dynamically somehow, but I
don't see that happening anytime soon, so we can just keep it si
On Tue, 16 Feb 2016 18:59:06 -0200
Eduardo Habkost wrote:
> machine_init() will be gone, but we don't need it if we just
> initialize the channel_subsys fields statically.
>
> Cc: Cornelia Huck
> Cc: Christian Borntraeger
> Cc: Richard Henderson
> Cc: Alexander Graf
> Signed-off-by: Eduardo
On 26.01.2016 13:38, Fam Zheng wrote:
Signed-off-by: Fam Zheng
---
docs/specs/qbm.md | 118 ++
1 file changed, 118 insertions(+)
create mode 100644 docs/specs/qbm.md
diff --git a/docs/specs/qbm.md b/docs/specs/qbm.md
new file mode 100644
On 14.02.2016 18:47, Samuel Thibault wrote:
> From: Yann Bordenave
>
> This patch adds parameters to manage some new options in the qemu -net
> command.
> Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in
> argument to the qemu command.
> Defaults parameters are respectivel
Eric Blake writes:
> When we added support for a user-specified prefix for an enum
> type (commit 351d36e), we forgot to teach the qapi-visit code
> to honor that prefix in the case of using a prefixed enum as
> the discriminator for a flat union. While there is still some
> on-list debate on wh
From: Prasad J Pandit
While computing IP checksum, 'net_checksum_calculate' reads
payload length from the packet. It could exceed the given 'data'
buffer size. Add a check to avoid it.
Reported-by: Liu Ling
Signed-off-by: Prasad J Pandit
---
net/checksum.c | 5 +++--
1 file changed, 3 inserti
Hello Igor, everyone,
we are seemingly running into the issue with "virtio: error trying to
map MMIO memory" on a 'legacy' vhost-net with 64 regions on VMs with
relatively small amount of DIMMs, less than ten of 512Mb and larger
ones for which it could appear literally on every boot. I could
sugge
From: Prasad J Pandit
Due indentation and braces were missing at places, added them.
Signed-off-by: Prasad J Pandit
---
net/checksum.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/net/checksum.c b/net/checksum.c
index e51698c..a8c47e3 100644
--- a/n
P J P writes:
> From: Prasad J Pandit
>
> While computing IP checksum, 'net_checksum_calculate' reads
> payload length from the packet. It could exceed the given 'data'
> buffer size. Add a check to avoid it.
>
> Reported-by: Liu Ling
> Signed-off-by: Prasad J Pandit
> ---
> net/checksum.c |
This patch adds to the vubr test the scattering of incoming
packets to the chain of RX buffer. Also, this patch corrects the
size of the header preceding the packet in RX buffers.
Note that this patch doesn't add the support for mergeable
buffers.
Signed-off-by: Victor Kaplansky
---
tests/vhos
Hi,
> For example, how to locate the path of a given VM?
You go ask libvirt, the domain xml will have the info.
> Whoever is going to configure
> the qemu has to walk through *all* the current vgpu path to locate the UUID to
> match the QEMU's VM UUID.
No. qemu simply uses the path it get pa
On Tue, Feb 16, 2016 at 01:39:36PM +0100, Andrew Jones wrote:
> On Tue, Feb 16, 2016 at 03:50:58PM +0800, Peter Xu wrote:
> > Here, total_size is the size in bytes to be dumped (raw data, which
> > means before compression), while written_size are bytes handled (raw
> > size too).
> >
> > Signed-o
As I understand, the difference between our driver interfaces:
Fam:
methods:
bdrv_dirty_bitmap_set_persistent
all persistent bitmaps are loaded, and they all are enabled
Me:
methods:
bdrv_dirty_bitmap_load \ bitmaps loaded on demand,
by name (by cmd line at qemu sta
On Wed, Feb 17, 2016 at 03:02:28PM +0200, Victor Kaplansky wrote:
> This patch adds to the vubr test the scattering of incoming
> packets to the chain of RX buffer. Also, this patch corrects the
> size of the header preceding the packet in RX buffers.
>
> Note that this patch doesn't add the supp
On 02/17/2016 05:05 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> When we added support for a user-specified prefix for an enum
>> type (commit 351d36e), we forgot to teach the qapi-visit code
>> to honor that prefix in the case of using a prefixed enum as
>> the discriminator for a flat
On 02/17/2016 05:35 AM, P J P wrote:
> From: Prasad J Pandit
>
> Due indentation and braces were missing at places, added them.
>
Cleaning up existing code is best done as part of a series that is
otherwise touching the code; doing it in isolation makes 'git blame'
attribute the wrong author fo
On Wed, 17 Feb 2016 11:09:49 +
"Tian, Kevin" wrote:
> > From: Alex Williamson
> > Sent: Wednesday, February 17, 2016 5:39 AM
> >
> > QEMU provides two fw_cfg files to support IGD. The first holds the
> > OpRegion data which holds the Video BIOS Table (VBT). This needs to
> > be copied into
Am 17.12.2015 um 13:47 hat Paolo Bonzini geschrieben:
> Even without line editing, this makes -qmp vc more pleasant with the
> GTK+ backend. The only issue is that set_echo is invoked very early,
> long before a vc is actually associated with a VirtualConsole. To work
> around this, create a temp
On Wed, 17 Feb 2016 11:16:37 +
"Tian, Kevin" wrote:
> > From: Alex Williamson
> > Sent: Wednesday, February 17, 2016 5:32 AM
> >
> > v3:
>
> Alex, thanks a lot for your enhancement, which should make future
> vgpu work easier!
Yes, there are a number of vGPU enablers in this series, spar
On 17/02/2016 14:53, Kevin Wolf wrote:
> Waiting didn't fix the bug, so I tried a git bisect now and it pointed
> me to this commit.
>
> I'm using HMP with the default vc backend. Starting with this commit,
> the echo is broken sometimes, in a way that the first character in the
> entered comman
Am 16.02.2016 um 19:08 hat Max Reitz geschrieben:
> This function first removed the BlockBackend from the blk_backends list
> and cleared its name so it would no longer be found by blk_name(); since
> blk_next() now iterates through monitor_block_backends (which the BB is
> removed from in hmp_driv
On Sun, Feb 14, 2016 at 05:02:14PM +0200, Michael S. Tsirkin wrote:
> On Sat, Feb 13, 2016 at 12:26:53PM -0500, Kevin O'Connor wrote:
> > On Tue, Feb 09, 2016 at 07:36:12PM +0100, Laszlo Ersek wrote:
> > > In my opinion, the real mess in this case is in the ACPI spec itself. If
> > > you re-read th
Eric Blake writes:
> On 02/16/2016 12:07 PM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> There's no reason to do two malloc's for an alternate type visiting
>>> a QAPI struct; let's just inline the struct directly as the C union
>>> branch of the struct.
>>>
>>> Surprisingly, no clien
Jevon Qiao writes:
> Hi Aneesh,
>
> Thank you for reviewing my code, please see my reply in-line.
> On 14/2/16 21:38, Aneesh Kumar K.V wrote:
>> Jevon Qiao writes:
>>
>>> The following patch is to fix alignment issue when host filesystem block
>>> size
>>> is larger than client msize.
>>>
>>> Th
On Mi, 2016-02-17 at 13:55 +0530, P J P wrote:
> +-- On Tue, 16 Feb 2016, Gerd Hoffmann wrote --+
> | > @@ -172,11 +172,18 @@ static void do_token_in(USBDevice *s, USBPacket *p)
> | > assert(p->ep->nr == 0);
> | > +if (s->setup_len > sizeof(s->data_buf)) {
> | > +fprintf(stderr,
>
On 07.10.2015 00:27, John Snow wrote:
On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote:
Adds qcow2_read_dirty_bitmaps, reading Dirty Bitmap Directory as
specified in docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 155 +
There is VM with 8 GB QCOW2 storage. Real size of the image file is 2 GB.
'drive-mirror' redirected to NBD target creates 8 GB image at destination.
The situation is even worse as zeroes are sent through the channel.
The patch simply adds .bdrv_co_write_zeroes callback to NBD block driver
which wo
On 02/13/2016 03:00 PM, Denis V. Lunev wrote:
With Hyper-V enabled CPU hotplug stops working. The CPU appears in device
manager on Windows but does not appear in peformance monitor and control
panel.
The root of the problem is the following. Windows checks
HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILAB
It's often handy to make executables depend on each other, e.g. make a
test depend on a helper. This doesn't work now, as linker
will attempt to use the helper as an object.
To fix, filter only relevant file types before linking an executable.
Signed-off-by: Michael S. Tsirkin
---
rules.mak | 2
On 17/02/2016 16:15, Michael S. Tsirkin wrote:
> It's often handy to make executables depend on each other, e.g. make a
> test depend on a helper. This doesn't work now, as linker
> will attempt to use the helper as an object.
> To fix, filter only relevant file types before linking an executable
On Wed, Feb 17, 2016 at 04:16:31PM +0100, Paolo Bonzini wrote:
>
>
> On 17/02/2016 16:15, Michael S. Tsirkin wrote:
> > It's often handy to make executables depend on each other, e.g. make a
> > test depend on a helper. This doesn't work now, as linker
> > will attempt to use the helper as an obj
On 17.02.2016 16:08, Denis V. Lunev wrote:
> There is VM with 8 GB QCOW2 storage. Real size of the image file is 2 GB.
> 'drive-mirror' redirected to NBD target creates 8 GB image at destination.
> The situation is even worse as zeroes are sent through the channel.
>
> The patch simply adds .bdrv_
Add data structures and constraints accordingly to docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/Makefile.objs| 2 +-
block/qcow2-dirty-bitmap.c | 47 ++
block/qcow2.h | 34
This series add persistent dirty bitmaps feature to qcow2.
Specification is in docs/spec/qcow2.txt (not merged yet, see
[PATCH v10] spec: add qcow2 bitmaps extension specification)
This series are based on Fam's
[PATCH v2 00/13] Dirty bitmap changes for migration/persistence work
(meta bitmaps not
The patch adds the following command line option:
-dirty-bitmap [option1=val1][,option2=val2]...
Avaliable options are:
name
The name of the bitmap.
Should be unique per 'file'/'node' and per 'for_node'.
node
The node to load and bind the bitmap.
It should be specified as 'id' suboption of one
The function checks existing of the bitmap without loading it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 15 +++
block/qcow2-dirty-bitmap.c | 5 +
block/qcow2.c| 1 +
block/qcow2.h| 1 +
include/block/block
This function loads block dirty bitmap from qcow2.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 110 +
block/qcow2.c | 2 +
block/qcow2.h | 3 ++
include/block/block_int.h | 4 ++
4 files
Test vm can launch and print output in case of fail. This function is
needed for testing erroneous cases
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qe
1 - 100 of 312 matches
Mail list logo
