Re: [Qemu-devel] [PATCH v3 2/5] drivers/hv: Move VMBus hypercall codes into Hyper-V UAPI header

2016-02-12 Thread Andrey Smetanin
On 02/12/2016 12:46 AM, Paolo Bonzini wrote: On 11/02/2016 14:44, Andrey Smetanin wrote: VMBus hypercall codes inside Hyper-V UAPI header will be used by QEMU to implement VMBus host devices support. Signed-off-by: Andrey Smetanin Acked-by: K. Y. Srinivasan Reviewed-by: Roman Kagan CC: G

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-12 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 11.02.2016 um 12:00 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 11.02.2016 um 07:05 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am 10.02.2016 um 13:51

Re: [Qemu-devel] [PATCH 1/4] target-arm: Clean up trap/undef handling of SRS

2016-02-12 Thread Sergey Fedorov
On 11.02.2016 22:11, Peter Maydell wrote: > The SRS instruction is: > * UNDEFINED in Hyp mode > * UNPREDICTABLE in User or System mode > * UNPREDICTABLE if the specified mode isn't accessible > * trapped to EL3 if EL3 is AArch64 and we are at Secure EL1 > > Clean up the code to handle all these

Re: [Qemu-devel] [PATCH 2/4] target-arm: Move get/set_r13_banked() to op_helper.c

2016-02-12 Thread Sergey Fedorov
On 11.02.2016 22:11, Peter Maydell wrote: > Move get/set_r13_banked() from helper.c to op_helper.c. This will > let us add exception-raising code to them, and also puts them > in the same file as get/set_user_reg(), which makes some conceptual > sense. > > (The original reason for the helper.c/op_h

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Sergey Fedorov
On 11.02.2016 22:11, Peter Maydell wrote: > The user-mode versions of get/set_r13_banked() exist just to assert > if they're ever called -- the translate time code should never > emit calls to them because SRS from user mode always UNDEF. > There's no code in the softmmu versions that can't compile

[Qemu-devel] [PATCH RFC] qmp, target-i386: device_list_properties for TYPE_CPU

2016-02-12 Thread Valentin Rakush
This is RFC because there is another implementation option: it is possible to implement this functionality in the object_finalize for all available targets. All targets change will require more testing. Please let me know if all targets should be changed at once. This patch changes qmp_device_list

Re: [Qemu-devel] [PATCH v2 2/6] target-arm: Fix handling of SCR.SMD

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 04:03:25PM +, Peter Maydell wrote: > We weren't quite implementing the handling of SCR.SMD correctly. > The condition governing whether the SMD bit should apply only > for NS state is "is EL3 is AArch32", not "is the current EL AArch32". > Fix the condition, and clarify

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-12 Thread Marcel Apfelbaum
On 02/11/2016 09:41 PM, Eduardo Habkost wrote: On Fri, Feb 05, 2016 at 09:51:07AM +0200, Marcel Apfelbaum wrote: On 02/05/2016 09:49 AM, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Thu, Feb 04, 2016 at 12:55:22PM +0100, Paolo Bonzini wrote: On 04/02/2016 12:41, Andreas Färber

Re: [Qemu-devel] [PATCH 4/4] target-arm: UNDEF in the UNPREDICTABLE SRS-from-System case

2016-02-12 Thread Sergey Fedorov
On 11.02.2016 22:11, Peter Maydell wrote: > Make get_r13_banked() raise an exception at runtime for the > corner case of SRS from System mode, so that we can UNDEF it; > this brings us in to line with the ARM ARM's set of permitted > CONSTRAINED UNPREDICTABLE choices. > > Signed-off-by: Peter Mayde

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-12 Thread Kevin Wolf
Am 12.02.2016 um 09:33 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 11.02.2016 um 12:00 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 11.02.2016 um 07:05 hat Pavel Dovgalyuk geschrieben: > > > > > > From: Kev

Re: [Qemu-devel] [PATCH 6/9] pc: acpi: create MADT.lapic entries only for valid lapics

2016-02-12 Thread Igor Mammedov
On Thu, 11 Feb 2016 14:11:34 -0200 Eduardo Habkost wrote: > On Fri, Feb 05, 2016 at 05:14:41PM +0100, Igor Mammedov wrote: > > On Fri, 5 Feb 2016 13:28:31 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Feb 04, 2016 at 12:47:32PM +0100, Igor Mammedov wrote: > > > > do not assume that all

Re: [Qemu-devel] [PATCH 7/9] pc: acpi: drop not needed intermediate bitmap cpu->found_cpus

2016-02-12 Thread Igor Mammedov
On Thu, 11 Feb 2016 13:59:33 -0200 Eduardo Habkost wrote: > On Fri, Feb 05, 2016 at 05:44:49PM +0100, Igor Mammedov wrote: > > On Fri, 5 Feb 2016 17:19:50 +0100 > > Igor Mammedov wrote: > > > > > On Fri, 5 Feb 2016 13:39:07 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Thu, Feb 04,

Re: [Qemu-devel] cache.direct

2016-02-12 Thread Stefan Hajnoczi
On Thu, Feb 11, 2016 at 03:11:55PM +, Jignasha Vithalani wrote: > How to set cache.direct = on if using aio=native with qemu 2.3 > while mounting with nbd The NBD block driver does not honor -drive cache=on|off. It does not have a client-side cache. Instead you must set the cache mode on the

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-12 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Feb 11, 2016 at 01:51:30PM -0200, Eduardo Habkost wrote: >> On Sat, Feb 06, 2016 at 08:34:07PM +0200, Michael S. Tsirkin wrote: >> > On Fri, Feb 05, 2016 at 12:46:11PM -0200, Eduardo Habkost wrote: >> > > On Fri, Feb 05, 2016 at 12:14:16AM +0200, Michael S.

Re: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-12 Thread Andreas Färber
Am 11.02.2016 um 21:19 schrieb Denis V. Lunev: > From: "Alexey V. Kostyushko" > > With Hyper-V enabled CPU hotplug stops working. The CPU appears in device > manager on Windows but does not appear in peformance monitor and control > panel. > > The root of the problem is the following. Windows ch

Re: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-12 Thread Denis V. Lunev
On 02/12/2016 02:00 PM, Andreas Färber wrote: Am 11.02.2016 um 21:19 schrieb Denis V. Lunev: From: "Alexey V. Kostyushko" With Hyper-V enabled CPU hotplug stops working. The CPU appears in device manager on Windows but does not appear in peformance monitor and control panel. The root of the p

[Qemu-devel] [PATCH] qdev: Start disentangling bus from device

2016-02-12 Thread Andreas Färber
Move bus type and related APIs to a separate file bus.c. This is a first step in breaking up qdev.c into more manageable chunks. Signed-off-by: Andreas Färber --- Here's a first step in breaking up qdev.c, originally prepared as part of my QOM device reset refactoring. Amazingly it still applie

Re: [Qemu-devel] [PATCH 1/5] target-tricore: Add trap handling

2016-02-12 Thread Bastian Koppelmann
On 02/12/2016 03:39 AM, Richard Henderson wrote: > On 02/12/2016 03:01 AM, Bastian Koppelmann wrote: >> +void tricore_cpu_do_interrupt(CPUState *cs) >> +{ >> +TriCoreCPU *cpu = TRICORE_CPU(cs); >> +CPUTriCoreState *env = &cpu->env; >> + >> +/* The stack pointer in A[10] is set to the In

Re: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-12 Thread Andreas Färber
Am 12.02.2016 um 12:08 schrieb Denis V. Lunev: > On 02/12/2016 02:00 PM, Andreas Färber wrote: >> Am 11.02.2016 um 21:19 schrieb Denis V. Lunev: >>> From: "Alexey V. Kostyushko" >>> >>> With Hyper-V enabled CPU hotplug stops working. The CPU appears in >>> device >>> manager on Windows but does no

Re: [Qemu-devel] broken HMP command: info mtree

2016-02-12 Thread Igor Mammedov
On Thu, 11 Feb 2016 16:35:39 +0100 Igor Mammedov wrote: > executing 'info mtree' from monitor prompt causes infinite loop > printing it over and over. > > to reproduce build current master adn run: > > qemu-system-x86_64 -monitor stdio > > and then execute 'info mtree' in monitor prompt > it

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: skip configuration section during migration of older machines

2016-02-12 Thread Greg Kurz
On Fri, 12 Feb 2016 16:24:26 +1100 David Gibson wrote: > On Thu, Feb 11, 2016 at 04:53:40PM +, Dr. David Alan Gilbert wrote: > > * Greg Kurz (gk...@linux.vnet.ibm.com) wrote: > > > On Mon, 08 Feb 2016 16:59:47 +0100 > > > Greg Kurz wrote: > > > > Since QEMU 2.4, we have a configuration s

Re: [Qemu-devel] broken HMP command: info mtree

2016-02-12 Thread Daniel P. Berrange
On Fri, Feb 12, 2016 at 12:15:26PM +0100, Igor Mammedov wrote: > On Thu, 11 Feb 2016 16:35:39 +0100 > Igor Mammedov wrote: > > > executing 'info mtree' from monitor prompt causes infinite loop > > printing it over and over. > > > > to reproduce build current master adn run: > > > > qemu-system-

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-12 Thread Andreas Färber
Am 12.02.2016 um 10:17 schrieb Marcel Apfelbaum: > On 02/11/2016 09:41 PM, Eduardo Habkost wrote: >> On Fri, Feb 05, 2016 at 09:51:07AM +0200, Marcel Apfelbaum wrote: >>> On 02/05/2016 09:49 AM, Markus Armbruster wrote: "Michael S. Tsirkin" writes: > On Thu, Feb 04, 2016 at 12:55:22P

Re: [Qemu-devel] [PATCH] qdev: Start disentangling bus from device

2016-02-12 Thread Peter Maydell
On 12 February 2016 at 11:09, Andreas Färber wrote: > Move bus type and related APIs to a separate file bus.c. > This is a first step in breaking up qdev.c into more manageable chunks. > > Signed-off-by: Andreas Färber > --- > Here's a first step in breaking up qdev.c, originally prepared as par

Re: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-12 Thread Denis V. Lunev
On 02/12/2016 02:13 PM, Andreas Färber wrote: Am 12.02.2016 um 12:08 schrieb Denis V. Lunev: On 02/12/2016 02:00 PM, Andreas Färber wrote: Am 11.02.2016 um 21:19 schrieb Denis V. Lunev: From: "Alexey V. Kostyushko" With Hyper-V enabled CPU hotplug stops working. The CPU appears in device man

Re: [Qemu-devel] [PATCH RFC] qmp, target-i386: device_list_properties for TYPE_CPU

2016-02-12 Thread Andreas Färber
Hi, Am 12.02.2016 um 10:13 schrieb Valentin Rakush: > This is RFC because there is another implementation option: it is > possible to implement this functionality in the object_finalize for > all available targets. All targets change will require more testing. > Please let me know if all targets s

Re: [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-02-12 Thread Dr. David Alan Gilbert
* Denis V. Lunev (d...@openvz.org) wrote: > There is a possibility to hit an assert in qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The

Re: [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-02-12 Thread Paolo Bonzini
On 12/02/2016 13:50, Dr. David Alan Gilbert wrote: > I'll admit to not really understanding what the difference is > between bh and coroutine context; I'd thought if it was all > in the main thread stuff was safe. It's arguably a bug in the block layer code. It assumes that all code called from

Re: [Qemu-devel] cache.direct

2016-02-12 Thread Paolo Bonzini
On 12/02/2016 11:25, Stefan Hajnoczi wrote: > On Thu, Feb 11, 2016 at 03:11:55PM +, Jignasha Vithalani wrote: >> > How to set cache.direct = on if using aio=native with qemu 2.3 >> > while mounting with nbd > The NBD block driver does not honor -drive cache=on|off. It does not > have a clien

Re: [Qemu-devel] broken HMP command: info mtree

2016-02-12 Thread Paolo Bonzini
On 12/02/2016 12:17, Daniel P. Berrange wrote: > On Fri, Feb 12, 2016 at 12:15:26PM +0100, Igor Mammedov wrote: >> On Thu, 11 Feb 2016 16:35:39 +0100 >> Igor Mammedov wrote: >> >>> executing 'info mtree' from monitor prompt causes infinite loop >>> printing it over and over. >>> >>> to reproduce

Re: [Qemu-devel] [PATCH v10] spec: add qcow2 bitmaps extension specification

2016-02-12 Thread Fam Zheng
On Fri, 02/05 11:58, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such bi

Re: [Qemu-devel] [PATCH v3 2/5] drivers/hv: Move VMBus hypercall codes into Hyper-V UAPI header

2016-02-12 Thread Paolo Bonzini
On 12/02/2016 09:10, Andrey Smetanin wrote: >>> >>> -hv_do_hypercall(HVCALL_SIGNAL_EVENT, channel->sig_event, NULL); >>> +hv_do_hypercall(HV_X64_HCALL_SIGNAL_EVENT, channel->sig_event, >>> NULL); >> >> What tree does this apply to? > next-20160211 Ok, I'll check whether I can just merge

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-12 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > > > From:

Re: [Qemu-devel] [PATCH] build: Don't redefine 'inline'

2016-02-12 Thread Peter Maydell
On 9 February 2016 at 18:49, Eric Blake wrote: > Actively redefining 'inline' is wrong for C++, where gcc has an > extension 'inline namespace' which fails to compile if the > keyword 'inline' is replaced by a macro expansion. This will > matter once we start to include "qemu/osdep.h" first from

Re: [Qemu-devel] broken HMP command: info mtree

2016-02-12 Thread Igor Mammedov
On Fri, 12 Feb 2016 14:08:32 +0100 Paolo Bonzini wrote: > On 12/02/2016 12:17, Daniel P. Berrange wrote: > > On Fri, Feb 12, 2016 at 12:15:26PM +0100, Igor Mammedov wrote: > >> On Thu, 11 Feb 2016 16:35:39 +0100 > >> Igor Mammedov wrote: > >> > >>> executing 'info mtree' from monitor prompt

Re: [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client

2016-02-12 Thread Kashyap Chamarthy
On Wed, Feb 10, 2016 at 06:40:58PM +, Daniel P. Berrange wrote: [...] I've applied all the series in this patches, to yesterday's Git master, so I'm here: $ git describe pull-qcrypto-next-2016-02-02-1-378-gf9375d2 > Starting a QEMU system emulator built-in NBD server > > $ qemu-s

Re: [Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

2016-02-12 Thread Marc-André Lureau
Hi On Fri, Feb 12, 2016 at 3:29 AM, Marc-André Lureau wrote: > Hi > > On Mon, Jan 11, 2016 at 10:13 AM, Paolo Bonzini wrote: >> >> >> On 11/01/2016 09:33, Michael Tokarev wrote: >>> 11.12.2015 14:29, Ashley Jonathan wrote: I have experienced a minor difficulty using QEMU with the "-serial p

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-12 Thread Kevin Wolf
Am 12.02.2016 um 14:19 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > > Am 09.02.

[Qemu-devel] [PATCH v1 0/9] arm: Steps towards EL2 support round 6

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, Another round of patches towards EL2 support. This one adds partial Instruction Syndrome generation for Data Aborts while running in AArch64. I don't feel very confident with the way I collect the regsize info used to fill out the SF field. Feedback on that would b

[Qemu-devel] [PATCH v1 1/9] tcg: Add tcg_set_insn_param

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add tcg_set_insn_param as a mechanism to modify an insn parameter after emiting the insn. This is useful for icount and also for embedding fault information for a specific insn. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- tcg/tcg.h | 6 ++

[Qemu-devel] [PATCH v1 3/9] target-arm: Add the thumb/IL flag to syn_data_abort

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/internals.h | 4 +++- target-arm/op_helper.c | 6 -- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/target-arm/internals.h b/target-arm/internals.h index 70bec4a..b1c483b 100644 --- a/target-arm/intern

[Qemu-devel] [PATCH v1 6/9] target-arm/translate-a64.c: Unify some of the ldst_reg decoding

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The various load/store variants under disas_ldst_reg can all reuse the same decoding for opc, size, rt and is_vector. This patch unifies the decoding in preparation for generating instruction syndromes for data aborts. This will allow us to reduce the number of places t

Re: [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object

2016-02-12 Thread Kevin Wolf
Am 05.02.2016 um 20:56 hat Eric Blake geschrieben: > On 02/05/2016 11:12 AM, John Snow wrote: > > Commit 16b0d555 introduced an issue where we are not initializing > > has_filename for the 'next' MapEntry object, which leads to interesting > > errors in Valgrind and Clang -fsanitize=undefined both.

[Qemu-devel] [PATCH v1 2/9] gen-icount: Use tcg_set_insn_param

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use tcg_set_insn_param() instead of directly accessing internal tcg data structures to update an insn param. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- include/exec/gen-icount.h | 16 1 file changed, 8 insertions(+), 8 deleti

[Qemu-devel] [PATCH v1 5/9] target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use extract32 instead of open coding the bit masking when decoding is_signed and is_extended. This streamlines the decoding with some of the other ldst variants. No functional change. Signed-off-by: Edgar E. Iglesias --- target-arm/translate-a64.c | 4 ++-- 1 file ch

[Qemu-devel] [PATCH v1 7/9] target-arm: Add the ARMInsnSyndrome type

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the ARMInsnSyndrome type including helper functions to encode and decode it into an u32. This is in preparation for Instruction Syndrome generation for Data Aborts. No functional change. Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h | 22 +++

[Qemu-devel] [PATCH v1 8/9] target-arm: A64: Create Instruction Syndromes for Data Aborts

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for generating the instruction syndrome for Data Aborts. These syndromes are used by hypervisors for example to trap and emulate memory accesses. We save the decoded data out-of-band with the TBs at translation time. When exceptions hit, the extra data attac

[Qemu-devel] [PATCH] MAINTAINERS: add machine section

2016-02-12 Thread Marcel Apfelbaum
Eduardo and me will maintain it. Signed-off-by: Marcel Apfelbaum Acked-by: Andreas Färber --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d6ee17..a86491a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1200,6 +1200,13 @@ F: docs/*qmp-*

[Qemu-devel] [PATCH v1 4/9] target-arm: Add more fields to the data abort syndrome generator

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add the following flags to the data abort syndrome generator: * isv - Instruction syndrome valid * sas - Syndrome access size * sse - Syndrome sign extend * srt - Syndrome register transfer * sf - Sixty-Four bit register width * ar - Acquire/Release These flags are no

[Qemu-devel] [PATCH v1 9/9] target-arm: Use isyn.swstep.ex to hold the is_ldex state

2016-02-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Switch to using isyn.swstep.ex to hold the is_ldex state for SWStep syndrome generation. No functional change. Signed-off-by: Edgar E. Iglesias --- target-arm/translate-a64.c | 6 +++--- target-arm/translate.c | 6 +++--- target-arm/translate.h | 5 - 3 f

Re: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-12 Thread Igor Mammedov
On Fri, 12 Feb 2016 14:27:25 +0300 "Denis V. Lunev" wrote: > On 02/12/2016 02:13 PM, Andreas Färber wrote: > > Am 12.02.2016 um 12:08 schrieb Denis V. Lunev: > >> On 02/12/2016 02:00 PM, Andreas Färber wrote: > >>> Am 11.02.2016 um 21:19 schrieb Denis V. Lunev: > From: "Alexey V. Kosty

[Qemu-devel] [PATCH 2/4] loader: Add load_image_mr() to load ROM image to a MemoryRegion

2016-02-12 Thread Peter Maydell
Add a new function load_image_mr(), which behaves like load_image_targphys() except that it loads the ROM image to a specified MemoryRegion rather than to a specified physical address. This is useful when a ROM blob needs to be loaded to a particular flash or ROM device but the address of that devi

[Qemu-devel] [PATCH 3/4] hw/arm/virt: Load bios image to MemoryRegion, not physaddr

2016-02-12 Thread Peter Maydell
If we're loading a BIOS image into the first flash device, load it into the flash's memory region specifically, not into the physical address where the flash resides. This will make a difference when the flash might be in the Secure address space rather than the Nonsecure one. Signed-off-by: Peter

[Qemu-devel] [PATCH 0/4] virt: provide secure-only RAM and first flash

2016-02-12 Thread Peter Maydell
This patchset adds some more secure-only devices to the virt board: (1) a 16MB secure-only RAM (2) the first flash device is secure-only The second of these is strictly speaking a breaking change, but I don't expect it in practice to break anybody: (a) there's not much use of the secure support

[Qemu-devel] [PATCH 1/4] hw/arm/virt: Provide a secure-only RAM if booting in Secure mode

2016-02-12 Thread Peter Maydell
If we're booting in Secure mode, provide a secure-only RAM (just 16MB) so that secure firmware has somewhere to run from that won't be accessible to the Non-secure guest. Signed-off-by: Peter Maydell --- hw/arm/virt.c | 26 ++ include/hw/arm/virt.h | 1 + 2 files

[Qemu-devel] [PATCH] char: fix handling of QIO_CHANNEL_ERR_BLOCK

2016-02-12 Thread Daniel P. Berrange
If io_channel_send_full gets QIO_CHANNEL_ERR_BLOCK it and has already sent some of the data, it should return that amount of data, not EAGAIN, as that would cause the caller to re-try already sent data. Unfortunately due to a previous rebase conflict resolution error, the code for dealing with thi

[Qemu-devel] [PATCH 4/4] hw/arm/virt: Make first flash device Secure-only if booting secure

2016-02-12 Thread Peter Maydell
If the virt board is started with the 'secure' property set to request a Secure setup, then make the first flash device be visible only to the Secure world. This is a breaking change, but I don't expect it to be noticed by anybody, because running TZ-aware guests isn't common and those guests are

Re: [Qemu-devel] [PATCH 01/14] cpu: Clean up includes

2016-02-12 Thread Andreas Färber
Am 09.02.2016 um 16:24 schrieb Peter Maydell: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell > --- > qom/cpu.c | 1 + > target-i386/

Re: [Qemu-devel] [PATCH v2 1/6] target-arm: correct CNTFRQ access rights

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 04:03:24PM +, Peter Maydell wrote: > Correct some corner cases we were getting wrong for > CNTFRQ access rights: > * should UNDEF from 32-bit Secure EL1 > * only writable from the highest implemented exception level, >which might not be EL1 now > > To clarify the

Re: [Qemu-devel] [PATCH v10] spec: add qcow2 bitmaps extension specification

2016-02-12 Thread Kevin Wolf
Am 05.02.2016 um 09:58 hat Vladimir Sementsov-Ogievskiy geschrieben: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one typ

Re: [Qemu-devel] broken HMP command: info mtree

2016-02-12 Thread Daniel P. Berrange
On Fri, Feb 12, 2016 at 02:27:23PM +0100, Igor Mammedov wrote: > On Fri, 12 Feb 2016 14:08:32 +0100 > Paolo Bonzini wrote: > > > On 12/02/2016 12:17, Daniel P. Berrange wrote: > > > On Fri, Feb 12, 2016 at 12:15:26PM +0100, Igor Mammedov wrote: > > >> On Thu, 11 Feb 2016 16:35:39 +0100 > > >> I

[Qemu-devel] [PATCH] MAINTAINERS: Drop target-i386 from CPU subsystem

2016-02-12 Thread Andreas Färber
X86CPU QOM type is in good hands and actively maintained these days, so drop it from the generic QOM CPU subsystem. Some refactorings and design questions will still intersect, but review and discussions of individual series can still take place while opting out of general X86CPU patch review. Cc

Re: [Qemu-devel] [PATCH 1/4] target-arm: Clean up trap/undef handling of SRS

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 07:11:46PM +, Peter Maydell wrote: > The SRS instruction is: > * UNDEFINED in Hyp mode > * UNPREDICTABLE in User or System mode > * UNPREDICTABLE if the specified mode isn't accessible > * trapped to EL3 if EL3 is AArch64 and we are at Secure EL1 > > Clean up the co

Re: [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client

2016-02-12 Thread Daniel P. Berrange
On Fri, Feb 12, 2016 at 02:28:33PM +0100, Kashyap Chamarthy wrote: > On Wed, Feb 10, 2016 at 06:40:58PM +, Daniel P. Berrange wrote: > > [...] > > I've applied all the series in this patches, to yesterday's Git master, > so I'm here: > > $ git describe > pull-qcrypto-next-2016-02-02-

Re: [Qemu-devel] [PATCH 2/4] target-arm: Move get/set_r13_banked() to op_helper.c

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 07:11:47PM +, Peter Maydell wrote: > Move get/set_r13_banked() from helper.c to op_helper.c. This will > let us add exception-raising code to them, and also puts them > in the same file as get/set_user_reg(), which makes some conceptual > sense. > > (The original reason

Re: [Qemu-devel] [PATCH COLO-Frame v14 24/40] COLO: Process shutdown command for VM in COLO state

2016-02-12 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > If VM is in COLO FT state, we should do some extra work before normal shutdown > process. SVM will ignore the shutdown command if this command is issued > directly > to it, PVM will send the shutdown command to SVM if it gets this command.

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: > The user-mode versions of get/set_r13_banked() exist just to assert > if they're ever called -- the translate time code should never > emit calls to them because SRS from user mode always UNDEF. > There's no code in the softmmu versio

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Peter Maydell
On 12 February 2016 at 15:12, Edgar E. Iglesias wrote: > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: >> The user-mode versions of get/set_r13_banked() exist just to assert >> if they're ever called -- the translate time code should never >> emit calls to them because SRS from us

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Edgar E. Iglesias
On Fri, Feb 12, 2016 at 04:12:18PM +0100, Edgar E. Iglesias wrote: > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: > > The user-mode versions of get/set_r13_banked() exist just to assert > > if they're ever called -- the translate time code should never > > emit calls to them becau

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Edgar E. Iglesias
On Fri, Feb 12, 2016 at 03:15:22PM +, Peter Maydell wrote: > On 12 February 2016 at 15:12, Edgar E. Iglesias > wrote: > > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: > >> The user-mode versions of get/set_r13_banked() exist just to assert > >> if they're ever called -- the t

Re: [Qemu-devel] [PATCH 4/4] target-arm: UNDEF in the UNPREDICTABLE SRS-from-System case

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 07:11:49PM +, Peter Maydell wrote: > Make get_r13_banked() raise an exception at runtime for the > corner case of SRS from System mode, so that we can UNDEF it; > this brings us in to line with the ARM ARM's set of permitted > CONSTRAINED UNPREDICTABLE choices. Reviewed

[Qemu-devel] [Bug 1545024] [NEW] compiling on armv7 crashes compile qlx.o

2016-02-12 Thread Klaftenegger Felix
Public bug reported: If i try to compile qemu on armv7 cpu i get this error: LINK qemu-nbd CCqemu-img.o LINK qemu-img LINK qemu-io LINK qemu-bridge-helper CCqmp-marshal.o CChw/display/qxl.o {standard input}: Assembler messages: {standard input}:1704: Error: bad instr

Re: [Qemu-devel] [PATCH] char: fix handling of QIO_CHANNEL_ERR_BLOCK

2016-02-12 Thread Paolo Bonzini
On 12/02/2016 15:46, Daniel P. Berrange wrote: > If io_channel_send_full gets QIO_CHANNEL_ERR_BLOCK it > and has already sent some of the data, it should return > that amount of data, not EAGAIN, as that would cause > the caller to re-try already sent data. > > Unfortunately due to a previous re

Re: [Qemu-devel] [Bug 1545024] [NEW] compiling on armv7 crashes compile qlx.o

2016-02-12 Thread Peter Maydell
On 12 February 2016 at 15:13, Klaftenegger Felix <1545...@bugs.launchpad.net> wrote: > Public bug reported: > > If i try to compile qemu on armv7 cpu i get this error: > > LINK qemu-nbd > CCqemu-img.o > LINK qemu-img > LINK qemu-io > LINK qemu-bridge-helper > CCqmp-marshal.o

[Qemu-devel] [PATCH v2 1/4] target-arm: Clean up trap/undef handling of SRS

2016-02-12 Thread Peter Maydell
The SRS instruction is: * UNDEFINED in Hyp mode * UNPREDICTABLE in User or System mode * UNPREDICTABLE if the specified mode isn't accessible * trapped to EL3 if EL3 is AArch64 and we are at Secure EL1 Clean up the code to handle all these cases cleanly, including picking UNDEF as our choice o

[Qemu-devel] [PATCH v2 4/4] target-arm: UNDEF in the UNPREDICTABLE SRS-from-System case

2016-02-12 Thread Peter Maydell
Make get_r13_banked() raise an exception at runtime for the corner case of SRS from System mode, so that we can UNDEF it; this brings us in to line with the ARM ARM's set of permitted CONSTRAINED UNPREDICTABLE choices. Signed-off-by: Peter Maydell Reviewed-by: Sergey Fedorov Reviewed-by: Edgar E

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Sergey Fedorov
On 12.02.2016 18:16, Edgar E. Iglesias wrote: > On Fri, Feb 12, 2016 at 03:15:22PM +, Peter Maydell wrote: >> On 12 February 2016 at 15:12, Edgar E. Iglesias >> wrote: >>> On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: The user-mode versions of get/set_r13_banked() exist j

Re: [Qemu-devel] [PATCH v1 21/22] migration: remove support for non-iovec based write handlers

2016-02-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > All the remaining QEMUFile implementations provide an iovec > based write handler, so the put_buffer callback can be removed > to simplify the code. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Dr. David Alan Gilbert > --- > include/mi

Re: [Qemu-devel] [PATCH] build: Don't redefine 'inline'

2016-02-12 Thread Eric Blake
On 02/12/2016 06:24 AM, Peter Maydell wrote: > On 9 February 2016 at 18:49, Eric Blake wrote: >> Actively redefining 'inline' is wrong for C++, where gcc has an >> extension 'inline namespace' which fails to compile if the >> keyword 'inline' is replaced by a macro expansion. This will >> matter

[Qemu-devel] [PATCH] target-arm: Move bank_number() into internals.h

2016-02-12 Thread Peter Maydell
Move bank_number()'s implementation into internals.h, so it's available in the user-mode-only compile as well. Signed-off-by: Peter Maydell --- Embarrassingly light on testing on that last change. target-arm/helper.c| 25 - target-arm/internals.h | 26 +++

[Qemu-devel] [PATCH v2 0/4] target-arm: Clean up trap/undef handling of SRS

2016-02-12 Thread Peter Maydell
The SRS instruction is a bit of an oddity because it isn't used by Linux these days. Nonetheless it has a bunch of UNPREDICTABLE, UNDEF and trapping behaviour that we weren't correctly implementing: - trap to EL3 if EL3 is AArch64 and we are at Secure EL1 - UNDEFINED in Hyp mode - UNPREDICTABLE

Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Peter Maydell
On 12 February 2016 at 15:16, Edgar E. Iglesias wrote: > On Fri, Feb 12, 2016 at 03:15:22PM +, Peter Maydell wrote: >> On 12 February 2016 at 15:12, Edgar E. Iglesias >> wrote: >> > On Thu, Feb 11, 2016 at 07:11:48PM +, Peter Maydell wrote: >> >> The user-mode versions of get/set_r13_bank

Re: [Qemu-devel] [PATCH v1 22/22] migration: remove qemu_get_fd method from QEMUFile

2016-02-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > Now that there is a set_blocking callback in QEMUFileOps, > and all users needing non-blocking support have been > converted to QIOChannel, there is no longer any codepath > requiring the qemu_get_fd() method for QEMUFile. Remove it > to avoid fur

[Qemu-devel] [PATCH v2 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()

2016-02-12 Thread Peter Maydell
The user-mode versions of get/set_r13_banked() exist just to assert if they're ever called -- the translate time code should never emit calls to them because SRS from user mode always UNDEF. There's no code in the softmmu versions that can't compile in CONFIG_USER_ONLY, and the assertion is not par

[Qemu-devel] [PATCH v2 2/4] target-arm: Move get/set_r13_banked() to op_helper.c

2016-02-12 Thread Peter Maydell
Move get/set_r13_banked() from helper.c to op_helper.c. This will let us add exception-raising code to them, and also puts them in the same file as get/set_user_reg(), which makes some conceptual sense. (The original reason for the helper.c/op_helper.c split was that only op_helper.c had access to

[Qemu-devel] [Bug 1545052] Re: RDMA migration will hang forever if target QEMU fails to load vmstate

2016-02-12 Thread Dr. David Alan Gilbert
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1545052 Title: RDMA migration will hang forever if target QEMU fails to load vmstate Status in QEM

[Qemu-devel] [Bug 1545052] [NEW] RDMA migration will hang forever if target QEMU fails to load vmstate

2016-02-12 Thread Daniel Berrange
Public bug reported: Get a pair of machines with infiniband support. On one host run $ qemu-system-x86_64 -monitor stdio -incoming rdma:ibme: -vnc :1 -m 1000 To start an incoming migration. Now on the other host, run QEMU with an intentionally different configuration (ie different RAM siz

[Qemu-devel] [Bug 1545024] Re: compiling on armv7 crashes compile qlx.o

2016-02-12 Thread Klaftenegger Felix
i have tried gcc4.9 and gcc4.8. both creating this error im using debian 8(jessie) and the host is a odroid-xu4 (http://www.hardkernel.com/main/products/prdt_info.php?g_code=G143452239825&tab_idx=2) spice and spice-platform are build from the last stable the other dependecies are from the debian

Re: [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client

2016-02-12 Thread Kashyap Chamarthy
On Fri, Feb 12, 2016 at 03:00:32PM +, Daniel P. Berrange wrote: > On Fri, Feb 12, 2016 at 02:28:33PM +0100, Kashyap Chamarthy wrote: > > On Wed, Feb 10, 2016 at 06:40:58PM +, Daniel P. Berrange wrote: > > > > [...] > > > > I've applied all the series in this patches, s/series in this pa

[Qemu-devel] [Bug 1545052] Re: RDMA migration will hang forever if target QEMU fails to load vmstate

2016-02-12 Thread Daniel Berrange
FYI is is tested on current GIT master commit fc1ec1acffd29d54c0c4266d30d38b2399d42f4f Merge: f163684 1834ed3 Author: Peter Maydell Date: Thu Feb 11 15:09:33 2016 + Merge remote-tracking branch 'remotes/mjt/tags/pull-trivial- patches-2016-02-11' into staging -- You received this bug

Re: [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context

2016-02-12 Thread Denis V. Lunev
On 02/12/2016 03:55 PM, Paolo Bonzini wrote: On 12/02/2016 13:50, Dr. David Alan Gilbert wrote: I'll admit to not really understanding what the difference is between bh and coroutine context; I'd thought if it was all in the main thread stuff was safe. It's arguably a bug in the block layer co

[Qemu-devel] IVSHMEM support on qemu-system-arm

2016-02-12 Thread sridhar kulkarni
Hi, I am working on a requirement where I need to have shared memory IPC between two guest VM's running different OS. Both VM's use vexpress-A9 boards. I came across the "ivshmem" implementation and have some questions. Whether the "ivshmem" implementation can be used on qemu-system-arm? I under

Re: [Qemu-devel] [PULL 14/15] qemu-char: add logfile facility to all chardev backends

2016-02-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Jan 21, 2016 at 07:16:25AM +0100, Hervé Poussineau wrote: >> Hi, >> >> This patch (commit d0d7708ba29cbcc343364a46bff981e0ff88366f) regresses the >> following command line: >> qemu-system-i386 -nodefaults -chardev vc,id=mon0 -mon chardev=mon0 >> >> Before

Re: [Qemu-devel] [PULL 14/15] qemu-char: add logfile facility to all chardev backends

2016-02-12 Thread Daniel P. Berrange
On Fri, Feb 12, 2016 at 05:49:38PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, Jan 21, 2016 at 07:16:25AM +0100, Hervé Poussineau wrote: > >> Hi, > >> > >> This patch (commit d0d7708ba29cbcc343364a46bff981e0ff88366f) regresses the > >> following command line: >

Re: [Qemu-devel] IVSHMEM support on qemu-system-arm

2016-02-12 Thread Peter Maydell
On 12 February 2016 at 15:05, sridhar kulkarni wrote: > I am working on a requirement where I need to have shared memory IPC between > two guest VM's running different OS. Both VM's use vexpress-A9 boards. I > came across the "ivshmem" implementation and have some questions. Whether > the "ivshmem

Re: [Qemu-devel] [PATCH v1 20/22] migration: support TLS encryption with TCP migration backend

2016-02-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > This extends the TCP migration backend so that it can make use > of QIOChannelTLS to provide transparent TLS encryption. To > trigger enablement the URI on the incoming and outgoing sides > should have 'tls-creds=ID' appended, eg > >tcp:$HOST

[Qemu-devel] [Bug 1545024] Re: compiling on armv7 crashes compile qlx.o

2016-02-12 Thread Klaftenegger Felix
if i try to compile with target-list=i386-linux-user it is working so the problem must the target i386-softmmu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1545024 Title: compiling on armv7 crashe

Re: [Qemu-devel] [PULL 14/15] qemu-char: add logfile facility to all chardev backends

2016-02-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Feb 12, 2016 at 05:49:38PM +0100, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > On Thu, Jan 21, 2016 at 07:16:25AM +0100, Hervé Poussineau wrote: >> >> Hi, >> >> >> >> This patch (commit d0d7708ba29cbcc343364a46bff981e0ff88366f) regress

Re: [Qemu-devel] [PATCH v1 07/22] migration: introduce a new QEMUFile impl based on QIOChannel

2016-02-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Feb 02, 2016 at 05:06:24PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > Introduce a new QEMUFile implementation that is based on > > > the QIOChannel objects. This impl is different from

Re: [Qemu-devel] IVSHMEM support on qemu-system-arm

2016-02-12 Thread Markus Armbruster
sridhar kulkarni writes: > Hi, > I am working on a requirement where I need to have shared memory IPC > between two guest VM's running different OS. Both VM's use vexpress-A9 > boards. I came across the "ivshmem" implementation and have some > questions. Whether the "ivshmem" implementation can b

  1   2   >