Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-10 Thread Denis V. Lunev
On 02/09/2016 10:25 PM, Denis V. Lunev wrote: On 02/09/2016 09:12 PM, John Snow wrote: On 02/09/2016 11:58 AM, Denis V. Lunev wrote: On 02/09/2016 07:49 PM, John Snow wrote: On 02/09/2016 09:37 AM, Denis V. Lunev wrote: On 02/09/2016 05:21 PM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2016 at

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-10 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch factorizes the tcpiphdr structure to put the IPv4 fields in > an union, for addition of version 6 in further patch. > Using some macros, retrocompatibility of the existing code is assured. > > This patch also fi

Re: [Qemu-devel] [PATCHv7 5/9] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2016-02-10 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Guillaume Subiron > > Basically, this patch adds some switch in various TCP functions to > prepare them for the IPv6 case. > > To have something to "switch" in tcp_input() and tcp_respond(), a new > argument is used to give them the sa_family o

Re: [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring

2016-02-10 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Guillaume Subiron > > No code change. > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel Thibault > --- > slirp/tcp_input.c | 99 > +++--- > slirp/tcp_output.c | 29

[Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size()

2016-02-10 Thread Vladimir Sementsov-Ogievskiy
Use pc_dimm_built_list() instead of qmp_pc_dimm_device_list() Actually, Qapi is not related to this internal helper. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio-balloon.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/hw/virtio/

[Qemu-devel] [PATCH 5/5] balloon: Use only 'pc-dimm' type dimm for ballooning

2016-02-10 Thread Vladimir Sementsov-Ogievskiy
For now there are only two dimm's: pc-dimm and nvdimm. This patch is actually needed to disable ballooning on nvdimm. But, to avoid future bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if someone adds new dimm which should be balloon-able, then this ability should be explicitly sp

[Qemu-devel] [PATCH 2/5] pc-dimm: rename pc_dimm_built_list()

2016-02-10 Thread Vladimir Sementsov-Ogievskiy
s/pc_dimm_built_list/pc_dimm_build_list_sorted - need for add pc_dimm_build_list (not sorted) in the next patch - fix typo (built -> build) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Igor Mammedov --- hw/mem/pc-dimm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 1/5] move get_current_ram_size to virtio-balloon.c

2016-02-10 Thread Vladimir Sementsov-Ogievskiy
get_current_ram_size() is used only in virtio-balloon.c This patch moves it into virtio-balloon and make it static, to allow some balloon-specific tuning. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake --- hw/mem/pc-dimm.c| 26

[Qemu-devel] [PATCH v7 0/5] don't use NVDIMM for balooning

2016-02-10 Thread Vladimir Sementsov-Ogievskiy
v7: 02: Reviewed-by: Igor Mammedov 04: object instead of dimm 05: arror_abort instead of NULL for getting size property, remove superfluous include v6: add stubbed pc_dimm_build_list, fix compilation for !CONFIG_MEM_HOTPLUG targets - thx to Cornelia. v5: do not use qapi 0002-0004:

Re: [Qemu-devel] lock-free monitor?

2016-02-10 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > Hi, > > I wondered what it would take to be able to do a lock-free monitor; > > i.e. one that could respond to (some) commands while the qemu big lock is > > held. > > Requires a careful audit of the monit

[Qemu-devel] [PATCH 3/5] pc-dimm: add pc_dimm_build_list()

2016-02-10 Thread Vladimir Sementsov-Ogievskiy
Like pc_dimm_build_list_sorted but not sorted - for cases where sorting is not necessary. Add stubbed version too - for targets without CONFIG_MEM_HOTPLUG. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/mem/pc-dimm.c| 15 +++ include/hw/mem/pc-dimm.h| 3 +

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-10 Thread Michael S. Tsirkin
On Tue, Feb 09, 2016 at 11:46:08AM +0100, Igor Mammedov wrote: > > > > > 2. ACPI approach consumes guest usable RAM to allocate buffer > > > > >and then makes device to DMA data in that RAM. > > > > >That's a design point I don't agree with. > > > > > > > > Blame the broken VM GEN ID s

[Qemu-devel] Tracking the VM making an IO request

2016-02-10 Thread Aarian P. Aleahmad
Hi there I'm a student, engaged in a project in which QEMU is a candidate to be used to make some studies about IO usage etc. I need to track the IO requests made to the block devices (e.g. HDD, SSD, etc.). I check the source code but I was confused. What I want to know is that when an IO request

[Qemu-devel] [PATCH v2 0/4] Deterministic replay extensions

2016-02-10 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations. With these patches one can record and deterministically replay behavior of the system with connected disk drives

[Qemu-devel] [PATCH v2 2/4] icount: remove obsolete warp call

2016-02-10 Thread Pavel Dovgalyuk
qemu_clock_warp call in qemu_tcg_wait_io_event function is not needed anymore, because it is called in every iteration of main_loop_wait. Signed-off-by: Pavel Dovgalyuk --- cpus.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index 898426c..01c9809 10

[Qemu-devel] [PATCH v2 1/4] replay: character devices

2016-02-10 Thread Pavel Dovgalyuk
This patch implements record and replay of character devices. It records chardevs communication in replay mode. Recorded information include data read from backend and counter of bytes written from frontend to backend to preserve frontend internal state. If character device was configured through t

[Qemu-devel] [PATCH v2 3/4] replay: introduce new checkpoint for icount warp

2016-02-10 Thread Pavel Dovgalyuk
qemu_clock_warp function is called to update virtual clock when CPU is sleeping. This function includes replay checkpoint to make execution deterministic in icount mode. Record/replay module flushes async event queue at checkpoints. Some of the events (e.g., block devices operations) include intera

[Qemu-devel] [PATCH v2 4/4] replay: introduce block devices record/replay

2016-02-10 Thread Pavel Dovgalyuk
This patch introduces a set of functions that implement recording and replaying of block devices' operations. These functions form a thin layer between blk_aio_ functions and replay subsystem. All asynchronous block requests are added to the queue to be processed at deterministically invoked record

Re: [Qemu-devel] [PATCHv7 5/9] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 09:35:31 +0100, wrote: > Hmm, this jumps to a "return (error)" statement ... but as far as I can > see, error has never been initialized in this case? Actually those places are unreachable (the address family can only be INET at this point, and only INET or INET6 on

Re: [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 09:42:04 +0100, wrote: > On 08.02.2016 11:28, Samuel Thibault wrote: > > Signed-off-by: Guillaume Subiron > > Signed-off-by: Samuel Thibault > > --- > > slirp/tcp_input.c | 99 > > +++--- > > slirp/tcp_output.c | 2

[Qemu-devel] "trace: split trace_init_file out of trace_init_backends" causes hangs on daemonize

2016-02-10 Thread Christian Borntraeger
Paolo, commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f trace: split trace_init_file out of trace_init_backends causes hangs for libvirt when checking the daemonized process, if the qemu was build with trace-backend=simple. Also calling qemu-system-s390x -machine accel=kvm -S -no-user-config

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-10 Thread Samuel Thibault
That one is tricky, yes :) Thomas Huth, on Wed 10 Feb 2016 09:05:32 +0100, wrote: > > -#define SLIRP_MSIZE (IF_MTU + IF_MAXLINKHDR + offsetof(struct mbuf, m_dat) > > + 6) > > +#define SLIRP_MSIZE\ > > +(offsetof(struct mbuf, m_dat) + IF_MAXLINKHDR + TCPIPHDR_DELTA + > > IF_MTU) > > I'm some

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2016 at 10:51:47AM +0200, Michael S. Tsirkin wrote: > So maybe we should > leave this alone, wait until we see an actual user - this way we can > figure out the implementation constraints better. What I'm definitely interested in seeing is improving the bios_linker_loader API withi

Re: [Qemu-devel] "trace: split trace_init_file out of trace_init_backends" causes hangs on daemonize

2016-02-10 Thread Christian Borntraeger
On 02/10/2016 10:23 AM, Christian Borntraeger wrote: > Paolo, > > > commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f > trace: split trace_init_file out of trace_init_backends > > causes hangs for libvirt when checking the daemonized process, > if the qemu was build with trace-backend=simple.

Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization

2016-02-10 Thread Christian Borntraeger
On 02/09/2016 05:49 PM, Denis V. Lunev wrote: > we should call trace_init_backends() before trace_init_file() for > CONFIG_TRACE_SIMPLE There is no difference for other cases. > > This problem was introduced by the commit > commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f > Author: Paolo Bo

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Didier Pallard
On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berrange wrote: On Thu, Feb 04, 2016 at 04:10:38PM +0200, Michael S. Tsirkin w

Re: [Qemu-devel] [PATCH] hw/intc: fix failure return for xics_alloc_block()

2016-02-10 Thread Greg Kurz
On Mon, 8 Feb 2016 09:31:49 +0100 Greg Kurz wrote: > On Mon, 8 Feb 2016 11:45:19 +1000 > David Gibson wrote: > > > On Fri, Feb 05, 2016 at 09:43:40AM +0100, Greg Kurz wrote: > > > From: Brian W. Hart > > > > > > xics_alloc_block() does not return a clear error code when it > > > fails to al

Re: [Qemu-devel] "x-disable-pcie" virtio-pci property in compat_props (HW_COMPAT_2_4)

2016-02-10 Thread Marcel Apfelbaum
On 02/09/2016 07:38 PM, Laurent Vivier wrote: Hi, I'm playing with a qemu-2.5.0 and pc-i440fx-2.4 machine type, and perhaps I don't understand correctly the compat_props machinery but there is something strange for me: in qemu-2.5.0, hw/virtio/virtio-pci.c: 1880 DEFINE_PROP_BIT("x-disa

Re: [Qemu-devel] [PATCH v19 3/9] pc: add a Virtual Machine Generation ID device

2016-02-10 Thread Laszlo Ersek
On 02/10/16 10:28, Michael S. Tsirkin wrote: > On Wed, Feb 10, 2016 at 10:51:47AM +0200, Michael S. Tsirkin wrote: >> So maybe we should >> leave this alone, wait until we see an actual user - this way we can >> figure out the implementation constraints better. > > What I'm definitely interested i

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

2016-02-10 Thread Stefan Hajnoczi
On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add qmp command to query dirty bitmap contents. This is needed for > external backup. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 55 +++

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-10 Thread Thomas Huth
On 10.02.2016 10:28, Samuel Thibault wrote: > That one is tricky, yes :) > > Thomas Huth, on Wed 10 Feb 2016 09:05:32 +0100, wrote: >>> -#define SLIRP_MSIZE (IF_MTU + IF_MAXLINKHDR + offsetof(struct mbuf, m_dat) >>> + 6) >>> +#define SLIRP_MSIZE\ >>> +(offsetof(struct mbuf, m_dat) + IF_MAXLIN

Re: [Qemu-devel] "x-disable-pcie" virtio-pci property in compat_props (HW_COMPAT_2_4)

2016-02-10 Thread Laurent Vivier
On 10/02/2016 10:52, Marcel Apfelbaum wrote: > On 02/09/2016 07:38 PM, Laurent Vivier wrote: >> Hi, >> >> I'm playing with a qemu-2.5.0 and pc-i440fx-2.4 machine type, and >> perhaps I don't understand correctly the compat_props machinery but >> there is something strange for me: >> >> in qemu-2.

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-10 Thread Stefan Hajnoczi
On Tue, Feb 09, 2016 at 05:41:50PM +0300, Denis V. Lunev wrote: > On 02/09/2016 05:28 PM, Stefan Hajnoczi wrote: > >On Fri, Feb 05, 2016 at 11:28:42AM +0300, Denis V. Lunev wrote: > >>On 02/03/2016 11:14 AM, Fam Zheng wrote: > >>>On Sat, 01/30 13:56, Vladimir Sementsov-Ogievskiy wrote: > Hi all

Re: [Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints

2016-02-10 Thread Stefan Hajnoczi
On Tue, Feb 09, 2016 at 09:31:23AM -0800, Hollis Blanchard wrote: > On 02/09/2016 07:53 AM, Stefan Hajnoczi wrote: > >On Mon, Feb 08, 2016 at 04:03:05PM -0800, Hollis Blanchard wrote: > >>-memory_region_ops_read(void *mr, uint64_t offset, uint64_t value, unsigned > >>size) "mr %p offset %#"PRIx64"

Re: [Qemu-devel] Regarding Cortex-A7 CPU definition

2016-02-10 Thread Peter Maydell
On 10 February 2016 at 05:25, Deepak kumar Raju wrote: > Regarding the questions, we have hw board which has Cortex-A7, so we thought > we have to go with A7 emulation. we were not very sure A15 emulation will be > almost equivalent to A7 emulation. > All we want to do is A7 emulation but now I am

Re: [Qemu-devel] [PATCH 1/3] trace: docs: "simple" backend does support strings

2016-02-10 Thread Stefan Hajnoczi
On Mon, Feb 08, 2016 at 04:03:03PM -0800, Hollis Blanchard wrote: > The simple tracing backend has supported strings for more than three years > (62bab73213ba885426a781eb2741670b9f3cae36). > > Signed-off-by: Hollis Blanchard > --- > docs/tracing.txt | 3 --- > 1 file changed, 3 deletions(-) Tha

Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup

2016-02-10 Thread Laurent Vivier
On 05/02/2016 11:39, Greg Kurz wrote: > This series brings some improvements to the cross-endian support in the > virtio and vhost code: > - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net, > so that backend cross-endian capabilities benefit to both emulated and > vhost

Re: [Qemu-devel] Tracking the VM making an IO request

2016-02-10 Thread Stefan Hajnoczi
On Wed, Feb 10, 2016 at 12:35:54PM +0330, Aarian P. Aleahmad wrote: > I'm a student, engaged in a project in which QEMU is a candidate to be used > to make some studies about IO usage etc. > I need to track the IO requests made to the block devices (e.g. HDD, SSD, > etc.). I check the source code b

Re: [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Ian Campbell
On Tue, 2016-02-09 at 16:50 +, Stefano Stabellini wrote: > > @@ -2218,15 +2127,10 @@ EOF > >  fi > >  > >  if test "$xen_pci_passthrough" != "no"; then > > -  if test "$xen" = "yes" && test "$linux" = "yes" && > > -    test "$xen_ctrl_version" -ge 340; then > > +  if test "$xen" = "yes" && tes

Re: [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > On Tue, 2016-02-09 at 16:50 +, Stefano Stabellini wrote: > > > @@ -2218,15 +2127,10 @@ EOF > > >  fi > > >  > > >  if test "$xen_pci_passthrough" != "no"; then > > > -  if test "$xen" = "yes" && test "$linux" = "yes" && > > > -    test "$xen_ctrl_vers

Re: [Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions

2016-02-10 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch adds IPv6 case in TCP functions refactored by the last > patches. > This also adds IPv6 pseudo-header in tcpiphdr structure. > Finally, tcp_input() is called by ip6_input(). > > Signed-off-by: Guillaume Subiron

[Qemu-devel] [PATCH v2 0/5] Drop support for Xen 4.1 and older from qemu-xen

2016-02-10 Thread Ian Campbell
This is most easily explained by the commit log of the first patch:     Xen 4.2 become unsupported upstream in 09/2015 (see http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the interfaces provided by the toolstack libraries go 4.2 and 4.3 are indistinguishable.   

[Qemu-devel] [PATCH v2 5/5] xen: Drop __XEN_LATEST_INTERFACE_VERSION__ checks from prior to Xen 4.2

2016-02-10 Thread Ian Campbell
We assume (and check for in configure) 4.2 or later now. In reality all of the removed checks are for far older versions. FMT_ioreq_size is no longer needed. Signed-off-by: Ian Campbell --- v2: Drop FMT_ioreq_size too --- hw/display/xenfb.c | 7 --- xen-hvm.c | 19 ++--

[Qemu-devel] [PATCH v2 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Ian Campbell
Xen 4.2 become unsupported upstream in 09/2015 (see http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the interfaces provided by the toolstack libraries go 4.2 and 4.3 are indistinguishable. Therefore drop support for Xen 4.1 and earlier which removes a whole pile of compatibility

[Qemu-devel] [PATCH v2 4/5] xen: move xenforeignmemory compat layer into common place

2016-02-10 Thread Ian Campbell
Now that we no longer support Xen 4.2 and earlier only the <470 case needs this so it can live with all the others. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- include/hw/xen/xen_common.h | 34 ++ 1 file changed, 14 insertions(+), 20 deletions

[Qemu-devel] [PATCH] s390x: remove s390-zipl.rom

2016-02-10 Thread Michael Tokarev
This is an s390 boot rom which was used in s390-virtio machine. but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 "s390x: remove s390-virtio machine", this file isn't used. The only place it is referenced in the code is an unused which I'm modifying too, to refer to s390-ccw.rom instead. C

[Qemu-devel] [PATCH v2 3/5] xen: drop XenXC and associated interface wrappers

2016-02-10 Thread Ian Campbell
Now that 4.2 and earlier are no longer supported "xc_interface *" is always the right type for the xc interface handle. With this we can also simplify the handling of the xenforeignmemory compatibility wrapper by making xenforeignmemory_handle == xc_interface, instead of an xc_interface* and remov

[Qemu-devel] [PATCH v2 2/5] xen: drop xen_xc_hvm_inject_msi wrapper

2016-02-10 Thread Ian Campbell
The xc version is now always present. Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini --- include/hw/xen/xen_common.h | 6 -- xen-hvm.c | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common

[Qemu-devel] [PATCH v2] s390x: remove s390-zipl.rom

2016-02-10 Thread Michael Tokarev
This is an s390 boot rom which was used in s390-virtio machine. but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 "s390x: remove s390-virtio machine", this file isn't used. The only place it is referenced in the code is an unused define ZIPL_FIRMWARE. There's also comment in hw/s390/ipl.c

Re: [Qemu-devel] [PATCH 00/12] tests: Introducing docker tests

2016-02-10 Thread Alex Bennée
Fam Zheng writes: > v1: Since RFC, addressed comments from reviewers, and improved a lot of > things. > Thanks to Daniel, Eric, Paolo, Stefan, for the feedback. > > This series adds a new "docker" make target family to run tests in created > docker containers. > > To begin with, this can be

[Qemu-devel] [Bug 1533848] Re: A workaround for Windows 7 ACPI SLIC table behavior when used with OVMF

2016-02-10 Thread Laszlo Ersek (Red Hat)
Fixed in 37ad223^..ae12374. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1533848 Title: A workaround for Windows 7 ACPI SLIC table behavior

Re: [Qemu-devel] [PATCH] s390x: remove s390-zipl.rom

2016-02-10 Thread Christian Borntraeger
On 02/10/2016 12:06 PM, Michael Tokarev wrote: > This is an s390 boot rom which was used in s390-virtio machine. > but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 > "s390x: remove s390-virtio machine", this file isn't used. > The only place it is referenced in the code is an unused > whic

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-10 Thread Thomas Huth
On 08.02.2016 11:28, Samuel Thibault wrote: > From: Yann Bordenave > > This patch adds parameters to manage some new options in the qemu -net > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in > argument to the qemu command. > Defaults parameters are respectivel

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > But even this doesn't feel completely right, because block drivers are > > already layered and there is no need to hardcode something optional (and > > rarely used) in the hot code path that c

Re: [Qemu-devel] [PATCH] s390x: remove s390-zipl.rom

2016-02-10 Thread Michael Tokarev
10.02.2016 14:35, Christian Borntraeger wrote: > On 02/10/2016 12:06 PM, Michael Tokarev wrote: >> This is an s390 boot rom which was used in s390-virtio machine. >> but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 >> "s390x: remove s390-virtio machine", this file isn't used. >> The only p

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: > On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: > >On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > >>On 02/09/2016 01:21 PM, Michael S. Tsirkin wrote: > >>>On Tue, Feb 09, 2016 at 11:48:13AM +, Daniel P. Berra

Re: [Qemu-devel] [PATCH v2 1/5] xen: drop support for Xen 4.1 and older.

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > Xen 4.2 become unsupported upstream in 09/2015 (see > http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the > interfaces provided by the toolstack libraries go 4.2 and 4.3 are > indistinguishable. > > Therefore drop support for Xen 4.1 and

Re: [Qemu-devel] [PATCH v2 5/5] xen: Drop __XEN_LATEST_INTERFACE_VERSION__ checks from prior to Xen 4.2

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > We assume (and check for in configure) 4.2 or later now. In reality > all of the removed checks are for far older versions. > > FMT_ioreq_size is no longer needed. > > Signed-off-by: Ian Campbell Reviewed-by: Stefano Stabellini > v2: Drop FMT_ioreq_

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Pavel Dovgalyuk
> -Original Message- > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > But even this doesn't feel completely right, because block drivers are > > > already layered and there is no need to hardcode something optional (and > > > r

Re: [Qemu-devel] [PATCH v2 0/5] Drop support for Xen 4.1 and older from qemu-xen

2016-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2016, Ian Campbell wrote: > This is most easily explained by the commit log of the first patch: > >     Xen 4.2 become unsupported upstream in 09/2015 (see > http://wiki.xen.org/wiki/Xen_Release_Features). However as far as the > interfaces provided by the toolstack librarie

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-10 Thread Daniel P. Berrange
On Wed, Feb 10, 2016 at 01:53:49PM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 10, 2016 at 10:35:13AM +0100, Didier Pallard wrote: > > On 02/09/2016 06:04 PM, Daniel P. Berrange wrote: > > >On Tue, Feb 09, 2016 at 05:17:16PM +0100, Didier Pallard wrote: > > >>On 02/09/2016 01:21 PM, Michael S. T

Re: [Qemu-devel] [PATCH v2] s390x: remove s390-zipl.rom

2016-02-10 Thread Cornelia Huck
On Wed, 10 Feb 2016 14:09:46 +0300 Michael Tokarev wrote: > This is an s390 boot rom which was used in s390-virtio machine. > but since commit 3538fb6f89dd9bb2e7e59de2bfad52a45321c744 > "s390x: remove s390-virtio machine", this file isn't used. > The only place it is referenced in the code is an

Re: [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 11:08:55 +0100, wrote: > On 10.02.2016 10:28, Samuel Thibault wrote: > > Thomas Huth, on Wed 10 Feb 2016 09:05:32 +0100, wrote: > >>> -#define SLIRP_MSIZE (IF_MTU + IF_MAXLINKHDR + offsetof(struct mbuf, > >>> m_dat) + 6) > >>> +#define SLIRP_MSIZE\ > >>> +(offse

[Qemu-devel] [PATCH 0/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
To the obvious question of "how did that happen?" I can say we had an unlucky break. Both Jason and me worked on a new different virtio features in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used https://lists.gnu.org/archive/html/qemu-deve

[Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Marcel Apfelbaum
Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h index 6686b10..817bcde 100644 -

[Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features. Fix it by using different bits. Reported-by: Laurent Vivier Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pc

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > -Original Message- > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > But even this doesn't feel completely right, because block drivers are > > > > already layere

Re: [Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 11:47:05 +0100, wrote: > > + ip = mtod(m, struct ip *); > > + ip6 = mtod(m, struct ip6 *); > > + save_ip = *ip; > > + save_ip6 = *ip6; > > Could you do the "save_ip = *ip" within the "case AF_INET" below, and > the "save_ip6 = *ip6" within the case AF_INET6

Re: [Qemu-devel] [PATCH] cirrus_vga: fix off-by-one in blit_region_is_unsafe

2016-02-10 Thread Paolo Bonzini
On 09/02/2016 20:08, Laszlo Ersek wrote: > On 02/09/16 11:59, Paolo Bonzini wrote: >> The "max" value is being compared with >=, but addr + width points to >> the first byte that will _not_ be copied. Subtract one like it is >> already done above for the height. >> >> Cc: Gerd Hoffmann >> Signe

Re: [Qemu-devel] Tracking the VM making an IO request

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 11:23, Stefan Hajnoczi wrote: > On Wed, Feb 10, 2016 at 12:35:54PM +0330, Aarian P. Aleahmad > wrote: >> I'm a student, engaged in a project in which QEMU is a candidate >> to be used to make some studies about IO usage etc. I need to >> track the IO requests made to the block devic

Re: [Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions

2016-02-10 Thread Thomas Huth
On 10.02.2016 13:30, Samuel Thibault wrote: > Thomas Huth, on Wed 10 Feb 2016 11:47:05 +0100, wrote: >>> + ip = mtod(m, struct ip *); >>> + ip6 = mtod(m, struct ip6 *); >>> + save_ip = *ip; >>> + save_ip6 = *ip6; >> >> Could you do the "save_ip = *ip" within the "case AF_INET" below, and >>

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-10 Thread Samuel Thibault
Thomas Huth, on Wed 10 Feb 2016 12:39:10 +0100, wrote: > > +if (!vprefix6) { > > +vprefix6 = "fec0::"; > > Site-local prefixes have already been deprecated (see rfc3879) ... would > it be feasible to use a ULA prefix instead (fd00::/8, > see rfc4193) ? The question is which ULA. Ideal

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

2016-02-10 Thread Paolo Bonzini
On 09/02/2016 17:13, Paolo Bonzini wrote: > The following changes since commit ac1be2ae6b2995b99430c48329eb971b0281acf1: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-02-09' > into staging (2016-02-09 11:42:43 +) > > are available in the git repository at: > > g

Re: [Qemu-devel] [PATCH 15/15] tcg-mips: Use mipsr6 instructions in calls

2016-02-10 Thread James Hogan
Hi Richard, On Tue, Feb 09, 2016 at 09:40:03PM +1100, Richard Henderson wrote: > @@ -1313,28 +1315,30 @@ static void tcg_out_movcond(TCGContext *s, TCGCond > cond, TCGReg ret, > } > } > > -static void tcg_out_call_int(TCGContext *s, tcg_insn_unit *arg, bool tail) > +static void tcg_out_ca

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > But even this doesn't feel completely right, because block drivers are

Re: [Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Laurent Vivier
On 10/02/2016 13:22, Marcel Apfelbaum wrote: > Commits 1811e64c and a6df8adf use the same virtio feature bit 4 > for different features. > > Fix it by using different bits. > > Reported-by: Laurent Vivier > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/virtio-pci.h | 2 +- > 1 file chang

Re: [Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Laurent Vivier
On 10/02/2016 13:22, Marcel Apfelbaum wrote: > Minimizes the possibility to assign > the same bit to different features. > > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/virtio-pci.h | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/hw/virtio/virt

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-10 Thread Daniel P. Berrange
On Wed, Feb 10, 2016 at 01:45:22PM +0100, Samuel Thibault wrote: > Thomas Huth, on Wed 10 Feb 2016 12:39:10 +0100, wrote: > > > +if (!vprefix6) { > > > +vprefix6 = "fec0::"; > > > > Site-local prefixes have already been deprecated (see rfc3879) ... would > > it be feasible to use a ULA

Re: [Qemu-devel] [PATCH v6 3/4] tcg: Add type for vCPU pointers

2016-02-10 Thread Lluís Vilanova
Richard Henderson writes: > On 02/10/2016 08:14 AM, Lluís Vilanova wrote: >> Adds the 'TCGv_env' type for pointers to 'CPUArchState' objects. The >> tracing infrastructure later needs to differentiate between regular >> pointers and pointers to vCPUs. >> >> Also changes all targets to use the new

Re: [Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Laurent Vivier
On 10/02/2016 13:22, Marcel Apfelbaum wrote: > Commits 1811e64c and a6df8adf use the same virtio feature bit 4 > for different features. > > Fix it by using different bits. > > Reported-by: Laurent Vivier > Signed-off-by: Marcel Apfelbaum > --- > hw/virtio/virtio-pci.h | 2 +- > 1 file chang

[Qemu-devel] [PATCH] target-i386/kvm.c: Fix the order of FPU registers in xsave

2016-02-10 Thread Asia Slowinska
Stick to the expected order of the FPU registers in xsave (as specified in the Intel manual.) Otherwise, instructions loading the FPU state don't set it up correctly. To set up FPU, software needs to provide a buffer of 80 bytes storing 8 FPU registers. They are organized in a stack. FPU assumes t

Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

2016-02-10 Thread Halil Pasic
On 02/09/2016 02:15 PM, Sascha Silbe wrote: > Sort the alias table by typename so it's easier to see which aliases > exist. > > Signed-off-by: Sascha Silbe > --- > qdev-monitor.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/qdev-monitor.c b/qdev-moni

Re: [Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Marcel Apfelbaum
On 02/10/2016 03:07 PM, Laurent Vivier wrote: On 10/02/2016 13:22, Marcel Apfelbaum wrote: Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletion

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > > But e

[Qemu-devel] [PATCH V2 1/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features. Fix it by using different bits. Reported-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH V2 0/2] hw/virtio: fix double use of a virtio flag

2016-02-10 Thread Marcel Apfelbaum
To the obvious question of "how did that happen?" I can say we had an unlucky break. Both Jason and me worked on a new different virtio feature in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used https://lists.gnu.org/archive/html/qemu-devel

[Qemu-devel] [PATCH V2 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Marcel Apfelbaum
Minimizes the possibility to assign the same bit to different features. Signed-off-by: Marcel Apfelbaum --- hw/virtio/virtio-pci.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h index 6686b10..e4548c2 100644

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > Am 09.02.2016 um 12:52 hat Pavel Dovgalyuk geschrieben: > > > > > > > From:

Re: [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding

2016-02-10 Thread Andreas Färber
Am 09.02.2016 um 21:57 schrieb Dirk Müller: > See C5.1.5 of the ARMv8 Reference Manual > > Signed-off-by: Dirk Mueller Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nür

Re: [Qemu-devel] [PATCH V2 2/2] hw/virtio: group virtio flags into an enum

2016-02-10 Thread Laurent Vivier
On 10/02/2016 14:31, Marcel Apfelbaum wrote: > Minimizes the possibility to assign > the same bit to different features. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH v6 3/4] tcg: Add type for vCPU pointers

2016-02-10 Thread Lluís Vilanova
Lluís Vilanova writes: > Richard Henderson writes: >> On 02/10/2016 08:14 AM, Lluís Vilanova wrote: >>> Adds the 'TCGv_env' type for pointers to 'CPUArchState' objects. The >>> tracing infrastructure later needs to differentiate between regular >>> pointers and pointers to vCPUs. >>> >>> Also cha

Re: [Qemu-devel] [PATCH] target-arm: Implement DBGDTRRX_EL0/DBGDTRTX_EL0 MSR

2016-02-10 Thread Andreas Färber
Hi Andreas, Am 09.02.2016 um 21:59 schrieb Dirk Müller: > This is used by the ARM JTAG DCC console in the Linux kernel, > but can be ignored in order to continue booting. > > Co-Authored-By: Andreas Schwab If this was co-authored by you, we need a proper Signed-off-by please. > Signed-off-by:

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

2016-02-10 Thread Peter Maydell
On 10 February 2016 at 12:48, Paolo Bonzini wrote: > > > On 09/02/2016 17:13, Paolo Bonzini wrote: >> The following changes since commit ac1be2ae6b2995b99430c48329eb971b0281acf1: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-02-09' >> into staging (2016-02-09 11:42:43 +

Re: [Qemu-devel] [PATCH v2 1/5] target-arm: Add the pmceid0 and pmceid1 registers

2016-02-10 Thread Aaron Lindsay
On Feb 09 15:11, Alistair Francis wrote: > On Tue, Feb 9, 2016 at 9:19 AM, Peter Maydell > wrote: > > On 6 February 2016 at 00:55, Alistair Francis > > wrote: > >> Signed-off-by: Aaron Lindsay > >> Signed-off-by: Alistair Francis > >> Tested-by: Nathan Rossi > >> --- > >> > >> target-arm/cpu

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-10 Thread Kevin Wolf
Am 10.02.2016 um 14:33 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 10.02.2016 um 13:51 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 10.02.2016 um 13:05 hat Pavel Dovgalyuk geschrieben: > > > > > > Am 09.02.

Re: [Qemu-devel] [Qemu-stable] [PATCH] spapr: skip configuration section during migration of older machines

2016-02-10 Thread Greg Kurz
On Mon, 08 Feb 2016 16:59:47 +0100 Greg Kurz wrote: > Since QEMU 2.4, we have a configuration section in the migration stream. > This must be skipped for older machines, like it is already done for x86. > > Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3e33 > Cc: qemu-sta...@nongnu.org > Signed-off

Re: [Qemu-devel] [PATCH 2/6] qmp: add query-block-dirty-bitmap-ranges

2016-02-10 Thread Denis V. Lunev
On 02/10/2016 01:08 PM, Stefan Hajnoczi wrote: On Sat, Jan 30, 2016 at 01:56:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add qmp command to query dirty bitmap contents. This is needed for external backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 55 +

Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2)

2016-02-10 Thread Cédric Le Goater
Hello Corey, On 02/09/2016 07:25 PM, Corey Minyard wrote: > On 02/09/2016 06:13 AM, Cédric Le Goater wrote: >> The first patches are cleanups and prepare ground for an extension of >> the BMC simulator providing a SDR loader using a file. A simple FRU >> support comes next. >> >> The last patches

[Qemu-devel] [PATCH] Rename cpu_get_icount_{locked,biased}

2016-02-10 Thread Christopher Covington
The function does not provide locking but rather adds a bias value. Signed-off-by: Christopher Covington --- cpus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 898426c..50403c4 100644 --- a/cpus.c +++ b/cpus.c @@ -164,7 +164,7 @@ int64_t cpu_

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2016-02-08

2016-02-10 Thread Paolo Bonzini
On 10/02/2016 14:49, Peter Maydell wrote: >> > Self-NACK, this breaks (at least) FreeDOS. > Oops, I read this email five seconds after pushing the merge to master. > Can you send out reverts for the appropriate patches and I'll apply > them direct to master? I can send the fix. Paolo

  1   2   3   >