To the obvious question of "how did that happen?" I can say we had an unlucky break. Both Jason and me worked on a new different virtio features in the same time, and they were both merged in the same pull request. We both saw BIT 3 as the last used https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03041.html
Commits 1811e64c and a6df8adf use the same virtio feature bit 4 for different features. Fix it by using different bits. While at it, group all the virtio flags into an enum to avoid that in the feature. Marcel Apfelbaum (2): hw/virtio: fix double use of a virtio flag hw/virtio: group virtio flags into an enum hw/virtio/virtio-pci.h | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) -- 2.4.3