Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Gives some general guidelines for reporting errors in QEMU. >> >> Signed-off-by: Lluís Vilanova >> --- >> HACKING | 37 + >> 1 file changed, 37 insertions(+) >> >> diff --git a/HACKING b/HACKING >> index

[Qemu-devel] [PATCH] io: improve docs for QIOChannelSocket async functions

2016-02-03 Thread Daniel P. Berrange
In the docs for qio_channel_socket_connect_async, qio_channel_socket_listen_async and qio_channel_socket_dgram_async, mention that the SocketAddress parameters are copied, so can be freed immediately. Signed-off-by: Daniel P. Berrange --- include/io/channel-socket.h | 11 +-- 1 file chan

[Qemu-devel] [PATCH 4/7] target-arm: Update arm_generate_debug_exceptions() to handle EL2/EL3

2016-02-03 Thread Peter Maydell
The arm_generate_debug_exceptions() function as originally implemented assumes no EL2 or EL3. Since we now have much more of an implementation of those now, fix this assumption. Signed-off-by: Peter Maydell --- target-arm/cpu.h | 48 +++- 1 file change

[Qemu-devel] [PATCH 1/7] target-arm: Fix typo in comment in arm_is_secure_below_el3()

2016-02-03 Thread Peter Maydell
Fix a typo where "EL2" was written but "EL3" intended. Signed-off-by: Peter Maydell --- target-arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index b8b3364..52284e9 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -931,7 +

[Qemu-devel] [PATCH 6/7] target-arm: Implement NSACR trapping behaviour

2016-02-03 Thread Peter Maydell
Implement some corner cases of the behaviour of the NSACR register on ARMv8: * if EL3 is AArch64 then accessing the NSACR from Secure EL1 with AArch32 should trap to EL3 * if EL3 is not present or is AArch64 then reads from NS EL1 and NS EL2 return constant 0xc00 It would in theory be poss

[Qemu-devel] [PATCH 0/7] Fix some more EL3 things and enable EL3 for AArch64

2016-02-03 Thread Peter Maydell
This series fixes a couple more minor EL3 related missing parts, and then turns on EL3 for AArch64 CPUs. The minor fixed things are: * implement MDCR_EL3 and SDCR * trap Secure EL1 accesses to SCR and MVBAR to EL3 * add EL3 support to the code that decides whether to generate debug exceptions

[Qemu-devel] [PATCH 3/7] target-arm: Use access_trap_aa32s_el1() for SCR and MVBAR

2016-02-03 Thread Peter Maydell
The registers MVBAR and SCR should have the behaviour of trapping to EL3 if accessed from Secure EL1, but we were incorrectly implementing them to UNDEF (which would trap to EL1). Fix this by using the new access_trap_aa32s_el1() access function. Signed-off-by: Peter Maydell --- target-arm/help

Re: [Qemu-devel] [PATCH v16 00/14] vfio-pci: pass the aer error to guest

2016-02-03 Thread Michael S. Tsirkin
On Wed, Feb 03, 2016 at 04:54:01PM +0800, Chen Fan wrote: > > On 01/17/2016 02:34 AM, Michael S. Tsirkin wrote: > >On Tue, Jan 12, 2016 at 10:43:01AM +0800, Cao jin wrote: > >>From: Chen Fan > >> > >>For now, for vfio pci passthough devices when qemu receives > >>an error from host aer report, cu

Re: [Qemu-devel] [PATCH v3 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

2016-02-03 Thread Peter Maydell
On 1 February 2016 at 22:15, Andrew Baumann wrote: > The SD spec for ACMD41 says that a zero argument is an "inquiry" > ACMD41, which does not start initialisation and is used only for > retrieving the OCR. However, Tianocore EDK2 (UEFI) has a bug [1]: it > first sends an inquiry (zero) ACMD41. If

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-03 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Thomas Huth writes: >>> On 03.02.2016 10:48, Markus Armbruster wrote: David Gibson writes: > On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: >> On 02.02.2016 19:53, Markus Armbruster wrote: >>> Lluís Vil

[Qemu-devel] [RFC PATCH 2/4] tests: Add clang docker test

2016-02-03 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/clang.sh | 16 1 file changed, 16 insertions(+) create mode 100755 tests/docker/clang.sh diff --git a/tests/docker/clang.sh b/tests/docker/clang.sh new file mode 100755 index 000..85fe0a5 --- /dev/null +++ b/tests/docker/clang.sh @@

[Qemu-devel] [RFC PATCH 1/4] tests: Introduce Docker based tests

2016-02-03 Thread Fam Zheng
A new group of targets to spawn docker instances for testing is added: - "make docker" will spawn each available docker image and run all available tests under tests/docker. - "make docker-foo" will spawn image foo and run all available tests. - "make docker X=bar" or "make docker-foo X=bar" w

[Qemu-devel] [RFC PATCH 0/4] tests: Introducing docker tests

2016-02-03 Thread Fam Zheng
This series adds a new "docker" make target family to run tests in created docker containers. To begin with, this can be a place to store standard env/command combinations to build and test QEMU. Secondly, CI usually provides "docker" capability (such as travis [1]), where we define standard/repe

[Qemu-devel] [RFC PATCH 4/4] tests: Add travis container test case

2016-02-03 Thread Fam Zheng
.travis.yml is parsed by an auxiliary python script, to generate the command list out of the matrix. TODO: respect "compiler". Signed-off-by: Fam Zheng --- tests/docker/travis.py | 40 tests/docker/travis.sh | 10 ++ 2 files changed, 50 insertion

[Qemu-devel] [RFC PATCH 3/4] tests: Add mingw 32/64 cross compiling

2016-02-03 Thread Fam Zheng
Only fedora22 has the required toolchain so it's not run elsewhere. Signed-off-by: Fam Zheng --- tests/docker/mingw.sh | 14 ++ 1 file changed, 14 insertions(+) create mode 100755 tests/docker/mingw.sh diff --git a/tests/docker/mingw.sh b/tests/docker/mingw.sh new file mode 100755

Re: [Qemu-devel] [PATCH v9] spec: add qcow2 bitmaps extension specification

2016-02-03 Thread Fam Zheng
On Wed, 02/03 16:45, Vladimir Sementsov-Ogievskiy wrote: > Also current scheme is made like one for snapshots. Okay, then I'll be fine with being consistent. > > > > >>+ > >>+ > >>+=== Bitmap table === > >>+ > >>+Bitmaps are stored using a one-level structure (as opposed to two-level > >>+struc

Re: [Qemu-devel] [PATCH] io: improve docs for QIOChannelSocket async functions

2016-02-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > In the docs for qio_channel_socket_connect_async, > qio_channel_socket_listen_async and > qio_channel_socket_dgram_async, mention that the > SocketAddress parameters are copied, so can be freed > immediately. > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Gives some general guidelines for reporting errors in QEMU. >>> >>> Signed-off-by: Lluís Vilanova >>> --- >>> HACKING | 37 + >>> 1 file changed, 37 insertions(+) >>> >>> di

Re: [Qemu-devel] [PATCH] arm: virt-acpi: each MADT.GICC entry as enabled unconditionally

2016-02-03 Thread Andrew Jones
On Fri, Jan 29, 2016 at 05:07:31PM +0100, Andrew Jones wrote: > On Fri, Jan 29, 2016 at 11:44:24PM +0800, Shannon Zhao wrote: > > >>>And below check in virt.c is not right while it should compare the global > > >>>max_cpus with the max_cpus GIC supports. > > >>> > > >>> if (smp_cpus > max_cpus)

[Qemu-devel] [PATCH] io: introduce helper for creating channels from file descriptors

2016-02-03 Thread Daniel P. Berrange
Depending on what object a file descriptor refers to a different type of IO channel will be needed - either a QIOChannelFile or a QIOChannelSocket. Introduce a qio_channel_new_fd() method which will return the appropriate channel implementation. Signed-off-by: Daniel P. Berrange --- Suggested du

[Qemu-devel] [PATCH] hw/arm/virt: fix max-cpus check

2016-02-03 Thread Andrew Jones
mach-virt doesn't yet support hotplug, but command lines specifying -smp ,maxcpus= don't fail. Of course specifying bigger-num as something bigger than the machine supports, e.g. > 8 on a gicv2 machine, should fail though. This fix also makes mach- virt's max-cpus check truly consistent with the on

Re: [Qemu-devel] [PATCH v5 0/8] Raspberry Pi 2 support

2016-02-03 Thread Peter Maydell
On 29 January 2016 at 22:50, Andrew Baumann wrote: > This patch series adds initial support for Raspberry Pi 2 > (bcm2836). It is heavily based on the original (out of tree) work of > Gregory Estrade, Stefan Weil and others to support Raspberry Pi > 1. Thanks are also due to Peter Crosthwaite for

Re: [Qemu-devel] [RFC PATCH 3/4] tests: Add mingw 32/64 cross compiling

2016-02-03 Thread Stefan Weil
Am 03.02.2016 um 15:36 schrieb Fam Zheng: > Only fedora22 has the required toolchain so it's not run elsewhere. > > Signed-off-by: Fam Zheng > --- > tests/docker/mingw.sh | 14 ++ > 1 file changed, 14 insertions(+) > create mode 100755 tests/docker/mingw.sh > > diff --git a/tests/d

Re: [Qemu-devel] [PATCH v5 8/8] raspi: add raspberry pi 2 machine

2016-02-03 Thread Peter Maydell
The list server seems to have eaten this patch from this series for some reason, so I'm just replying here so we have a copy of it other than in my private email. thanks -- PMM On 29 January 2016 at 22:50, Andrew Baumann wrote: > Reviewed-by: Peter Crosthwaite > Signed-off-by: Andrew Baumann >

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-03 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Thomas Huth writes: On 03.02.2016 10:48, Markus Armbruster wrote: > David Gibson writes: > >> On Tue, Feb 02, 2016 at 10:47:35PM +0100, Thomas Huth wrote: >>> On 02.02.2016 19:53, Marku

Re: [Qemu-devel] [PATCH 2/3] pcdimm: add 'type' field to PCDIMMDeviceInfo

2016-02-03 Thread Eric Blake
On 02/03/2016 05:00 AM, Vladimir Sementsov-Ogievskiy wrote: >>> +# @type: device type: 'pc-dimm' or 'nvdimm' (since 2.6) >>> +# >>> # Since: 2.1 >>> ## >>> { 'struct': 'PCDIMMDeviceInfo', >>> @@ -3934,7 +3936,8 @@ >>> 'node': 'int', >>> 'memdev': 'str', >>>

Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread Eric Blake
On 02/03/2016 03:14 AM, John Paul Adrian Glaubitz wrote: > Signed-off-by: John Paul Adrian Glaubitz > --- > target-m68k/translate.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/target-m68k/translate.c b/target-m68k/translate.c > index 535d7f9..a989961 100644 > --- a/target-m68k/t

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 37 + 1 file

Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread Laurent Vivier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Le 03/02/2016 16:16, Eric Blake a écrit : > On 02/03/2016 03:14 AM, John Paul Adrian Glaubitz wrote: >> Signed-off-by: John Paul Adrian Glaubitz >> --- target-m68k/translate.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/target-

Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread John Paul Adrian Glaubitz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/03/2016 04:16 PM, Eric Blake wrote: > Missing {}. Are you sure this is the version that passed > checkpatch.pl? Yes: glaubitz@z6:..qemu/target-m68k> ../scripts/checkpatch.pl 0002-m68k-Build-the-opcode-table-only-once-to-avoid-multi.patch tot

Re: [Qemu-devel] [RFC PATCH 0/4] tests: Introducing docker tests

2016-02-03 Thread Stefan Hajnoczi
On Wed, Feb 03, 2016 at 10:36:00PM +0800, Fam Zheng wrote: > This series adds a new "docker" make target family to run tests in created > docker containers. > > To begin with, this can be a place to store standard env/command combinations > to > build and test QEMU. > > Secondly, CI usually prov

Re: [Qemu-devel] [Qemu-block] [PATCH] block: add missing call to bdrv_drain_recurse

2016-02-03 Thread Stefan Hajnoczi
On Wed, Dec 23, 2015 at 11:48:25AM +0100, Paolo Bonzini wrote: > This is also needed in bdrv_drain_all, not just in bdrv_drain. > > Signed-off-by: Paolo Bonzini > --- > block/io.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/io.c b/block/io.c > index 841f5b5..bfe2544 100644 >

Re: [Qemu-devel] [PATCH v5 05/10] qemu-io: allow specifying image as a set of options args

2016-02-03 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > Currently qemu-io allows an image filename to be passed on the > command line, but unless using the JSON format, it does not have > a way to set any options except the format eg > > qemu-io https://127.0.0.1/images/centos7.iso > qemu-io /home/b

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-03 Thread Markus Armbruster
Eric Blake writes: > On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: >> NVDIMM for now is planned to use as a backing store for DAX filesystem >> in the guest and thus this memory is excluded from guest memory >> management and LRUs. >> >> In this case libvirt running QEMU along with

Re: [Qemu-devel] [PATCH 2/3] pcdimm: add 'type' field to PCDIMMDeviceInfo

2016-02-03 Thread Markus Armbruster
Eric Blake writes: > On 02/03/2016 05:00 AM, Vladimir Sementsov-Ogievskiy wrote: > +# @type: device type: 'pc-dimm' or 'nvdimm' (since 2.6) +# # Since: 2.1 ## { 'struct': 'PCDIMMDeviceInfo', @@ -3934,7 +3936,8 @@ 'node': 'int',

Re: [Qemu-devel] [PATCH v5 06/10] qemu-nbd: allow specifying image as a set of options args

2016-02-03 Thread Eric Blake
On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > Currently qemu-nbd allows an image filename to be passed on the > command line, but unless using the JSON format, it does not have > a way to set any options except the format eg > >qemu-nbd https://127.0.0.1/images/centos7.iso >qemu-nbd

[Qemu-devel] [PULL 01/13] trace: count number of enabled events

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini This lets trace_event_get_state_dynamic quickly return false. Right now there is hardly any benefit because there are also many assertions and indirections, but the next patch will streamline all of this. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- tra

[Qemu-devel] [PULL 06/13] trace: no need to call trace_backend_init in different branches now

2016-02-03 Thread Stefan Hajnoczi
From: "Denis V. Lunev" original idea to split calling locations was to spawn tracing thread in the final child process according to commit 8a745f2a9296ad2cf6bda33534ed298f2625a4ad Author: Michael Mueller Date: Mon Sep 23 16:36:54 2013 +0200 os_daemonize is now on top of both locat

[Qemu-devel] [PULL 00/13] Tracing patches

2016-02-03 Thread Stefan Hajnoczi
The following changes since commit c65db7705b7926f4a084b93778e4bd5dd3990aad: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-for-peter-2016-02-02' into staging (2016-02-02 18:04:04 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing

[Qemu-devel] [PULL 03/13] trace: fix documentation

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini Mention the ftrace backend too. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1452174932-28657-2-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 10 +- 1 file changed, 5 i

[Qemu-devel] [PULL 05/13] trace: split trace_init_file out of trace_init_backends

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini This is cleaner, and improves error reporting with -daemonize. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1452174932-28657-4-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- qemu-io.c | 2

[Qemu-devel] [PULL 02/13] trace: track enabled events in a separate array

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini This is more cache friendly on the fast path, where we already have the event id available. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/format/events_c.py | 2 +- trace/control-internal.h | 15 +++ trace/contro

[Qemu-devel] [PULL 07/13] trace: add "-trace enable=..."

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini Allow enabling events without going through a file, for example: qemu-system-x86_64 -trace bdrv_aio_writev -trace bdrv_aio_readv or with globbing too: qemu-system-x86_64 -trace 'bdrv_aio_*' if an appropriate backend is enabled (simple, stderr, ftrace). Signed-off-by

[Qemu-devel] [PULL 09/13] log: do not unnecessarily include qom/cpu.h

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini Split the bits that require it to exec/log.h. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1452174932-28657-8-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- bsd-user/main.c | 1 +

[Qemu-devel] [PULL 04/13] trace: split trace_init_events out of trace_init_backends

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini This is cleaner and has two advantages. First, it improves error reporting with -daemonize. Second, multiple "-trace events" options now cumulate. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1452174932-28657-3-gi

[Qemu-devel] [PULL 08/13] trace: add "-trace help"

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini Print a list of trace points Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1452174932-28657-7-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 2 ++ trace/control.c | 21 +

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Markus Armbruster writes: >>> Lluís Vilanova writes: > Gives some general guidelines for reporting errors in QEMU. > > Signed-off-by: Lluís Vilanova > --- > HACKING | 37

Re: [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-03 Thread Programmingkid
On Feb 2, 2016, at 11:36 PM, Eric Blake wrote: > On 02/02/2016 09:21 PM, Programmingkid wrote: > #if defined(__APPLE__) && defined(__MACH__) /* if a physical device experienced an error while being opened */ if (strncmp((*bsd_path ? bsd_path : filename), "/dev/", 5) ==

[Qemu-devel] [PULL 10/13] log: move qemu-log.c into util/ directory

2016-02-03 Thread Stefan Hajnoczi
From: "Denis V. Lunev" log will become common facility with tracepoints support in next step. Signed-off-by: Denis V. Lunev Reviewed-by: Paolo Bonzini Signed-off-by: Paolo Bonzini Message-id: 1452174932-28657-9-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- Makefile.objs

[Qemu-devel] [PULL 11/13] trace: convert stderr backend to log

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini [Also update .travis.yml --enable-trace-backends=stderr --Stefan] Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1452174932-28657-10-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- .travis.yml

[Qemu-devel] [PULL 12/13] trace: switch default backend to "log"

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini This enables integration with other QEMU logging facilities. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Borntraeger Message-id: 1452174932-28657-11-git-send-email-...@openvz.org Signed-off-by: Stefan Hajnoczi --- configure | 2 +- 1 fi

[Qemu-devel] [PULL 13/13] log: add "-d trace:PATTERN"

2016-02-03 Thread Stefan Hajnoczi
From: Paolo Bonzini This is a bit easier to use than "-trace" if you are also enabling other kinds of logging. It is also more discoverable for experienced QEMU users, and accessible from user-mode emulators. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V. Lunev Acked-by: Christian Bornt

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-03 Thread Wei Huang
On 2/3/16 04:46, Peter Maydell wrote: > On 3 February 2016 at 07:15, Michael Tokarev wrote: >> 28.01.2016 21:22, Wei Huang wrote: >>> When QEMU is hook'ed up with libvirt/virsh, the first ACPI reboot >>> request will succeed; but the following shutdown/reboot requests >>> fail to trigger VMs to

Re: [Qemu-devel] [PULL 10/13] log: move qemu-log.c into util/ directory

2016-02-03 Thread Daniel P. Berrange
On Wed, Feb 03, 2016 at 03:47:42PM +, Stefan Hajnoczi wrote: > From: "Denis V. Lunev" > > log will become common facility with tracepoints support in next step. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Paolo Bonzini > Signed-off-by: Paolo Bonzini > Message-id: 1452174932-28657-9-g

Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-03 Thread Eric Blake
On 02/03/2016 08:20 AM, John Paul Adrian Glaubitz wrote: > On 02/03/2016 04:16 PM, Eric Blake wrote: >> Missing {}. Are you sure this is the version that passed >> checkpatch.pl? > > Yes: > > glaubitz@z6:..qemu/target-m68k> ../scripts/checkpatch.pl > 0002-m68k-Build-the-opcode-table-only-once-to

Re: [Qemu-devel] [PATCH] io: introduce helper for creating channels from file descriptors

2016-02-03 Thread Eric Blake
On 02/03/2016 07:55 AM, Daniel P. Berrange wrote: > Depending on what object a file descriptor refers to a different > type of IO channel will be needed - either a QIOChannelFile or > a QIOChannelSocket. Introduce a qio_channel_new_fd() method > which will return the appropriate channel implementat

Re: [Qemu-devel] [RFC PATCH 3/4] tests: Add mingw 32/64 cross compiling

2016-02-03 Thread Eric Blake
On 02/03/2016 07:36 AM, Fam Zheng wrote: > Only fedora22 has the required toolchain so it's not run elsewhere. Not fedora 23 or rawhide? In another year, when F22 is obsolete, this will be dead code unless you meant for it to be >= F22. > > Signed-off-by: Fam Zheng > --- > tests/docker/mingw.s

Re: [Qemu-devel] [PULL 10/13] log: move qemu-log.c into util/ directory

2016-02-03 Thread Denis V. Lunev
On 02/03/2016 07:03 PM, Daniel P. Berrange wrote: On Wed, Feb 03, 2016 at 03:47:42PM +, Stefan Hajnoczi wrote: From: "Denis V. Lunev" log will become common facility with tracepoints support in next step. Signed-off-by: Denis V. Lunev Reviewed-by: Paolo Bonzini Signed-off-by: Paolo Bonz

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-03 Thread Igor Mammedov
On Wed, 03 Feb 2016 16:42:21 +0100 Markus Armbruster wrote: > Eric Blake writes: > > > On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: > >> NVDIMM for now is planned to use as a backing store for DAX filesystem > >> in the guest and thus this memory is excluded from guest memory >

[Qemu-devel] [PATCH 0/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
While there are more formats still missing blockdev-add support, I personally felt like NBD really is one we do need, and also it was pretty simple to do. Therefore, I started with NBD. Maybe I'll follow up with other formats. Max Reitz (2): block/nbd: Reject port parameter without host qapi

[Qemu-devel] [PATCH 1/2] block/nbd: Reject port parameter without host

2016-02-03 Thread Max Reitz
This is better than the generic block layer finding out later that the port parameter has not been used. Signed-off-by: Max Reitz --- block/nbd.c | 4 1 file changed, 4 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 1a90bc7..063c403 100644 --- a/block/nbd.c +++ b/block/nbd.c @@

Re: [Qemu-devel] [PATCH v11 1/2] mirror: Rewrite mirror_iteration

2016-02-03 Thread Max Reitz
On 03.02.2016 02:52, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > The out

Re: [Qemu-devel] [PULL 10/13] log: move qemu-log.c into util/ directory

2016-02-03 Thread Eric Blake
On 02/03/2016 09:03 AM, Daniel P. Berrange wrote: > On Wed, Feb 03, 2016 at 03:47:42PM +, Stefan Hajnoczi wrote: >> From: "Denis V. Lunev" >> >> log will become common facility with tracepoints support in next step. >> >> Signed-off-by: Denis V. Lunev >> Reviewed-by: Paolo Bonzini >> Signed-

Re: [Qemu-devel] [PATCH 1/2] block/nbd: Reject port parameter without host

2016-02-03 Thread Eric Blake
On 02/03/2016 09:33 AM, Max Reitz wrote: > This is better than the generic block layer finding out later that the > port parameter has not been used. > > Signed-off-by: Max Reitz > --- > block/nbd.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/block/nbd.c b/block/nbd.c > index 1

Re: [Qemu-devel] [PATCH 1/2] block/nbd: Reject port parameter without host

2016-02-03 Thread Max Reitz
On 03.02.2016 17:38, Eric Blake wrote: > On 02/03/2016 09:33 AM, Max Reitz wrote: >> This is better than the generic block layer finding out later that the >> port parameter has not been used. >> >> Signed-off-by: Max Reitz >> --- >> block/nbd.c | 4 >> 1 file changed, 4 insertions(+) >> >>

[Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
We have to introduce a new object (BlockdevOptionsNbd) for several reasons: - Neither of InetSocketAddress nor UnixSocketAddress alone is sufficient, because both are supported - We cannot use SocketAddress because NBD does not support an fd, and because it is not a flat union which BlockdevOpt

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Eric Blake
On 02/03/2016 09:33 AM, Max Reitz wrote: > We have to introduce a new object (BlockdevOptionsNbd) for several > reasons: > - Neither of InetSocketAddress nor UnixSocketAddress alone is > sufficient, because both are supported > - We cannot use SocketAddress because NBD does not support an fd, >

[Qemu-devel] [PATCH 7/9] hw/mips_malta: make ITU available to multi-threading processors

2016-02-03 Thread Leon Alrae
Add ITU block to Malta board and make it available to multithreading processors. Signed-off-by: Leon Alrae --- hw/mips/mips_malta.c | 53 1 file changed, 53 insertions(+) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index c5da83f.

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Daniel P. Berrange
On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote: > We have to introduce a new object (BlockdevOptionsNbd) for several > reasons: > - Neither of InetSocketAddress nor UnixSocketAddress alone is > sufficient, because both are supported > - We cannot use SocketAddress because NBD does not

[Qemu-devel] [PATCH 6/9] hw/mips: implement ITC Storage - Bypass View

2016-02-03 Thread Leon Alrae
Bypass View does not cause issuing thread to block and does not affect any of the cells state bit. Read from a FIFO cell returns the value of the oldest entry. Store to a FIFO cell changes the value of the newest entry. Signed-off-by: Leon Alrae --- hw/misc/mips_itu.c | 27 +

[Qemu-devel] [PATCH 8/9] target-mips: check CP0 enabled for CACHE instruction also in R6

2016-02-03 Thread Leon Alrae
Signed-off-by: Leon Alrae --- target-mips/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-mips/translate.c b/target-mips/translate.c index c6e2951..3fb3744 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -17179,6 +17179,7 @@ static void decode_opc_spec

[Qemu-devel] [PATCH 4/9] hw/mips: implement ITC Storage - Empty/Full Sync and Try Views

2016-02-03 Thread Leon Alrae
Empty/Full Synchronized and Try views can be used to access FIFO cells. Store to the FIFO cell pushes the value into the queue, load pops the oldest element from the queue. Cell's Full and Empty bits are automatically updated to reflect new state of the cell. Empty/Full Synchronized View causes th

[Qemu-devel] [PATCH 1/9] hw/mips: implement ITC Configuration Tags

2016-02-03 Thread Leon Alrae
Implement ITC as a single object consisting of two memory regions: * tag_io: ITC Configuration Tags (i.e. ITCAddressMap{0,1} registers) which are accessible by the CPU via CACHE instruction. Also adding MemoryRegion *itc_tag to the CPUMIPSState so that CACHE instruction will dispatch reads/w

[Qemu-devel] [PATCH 0/9] mips: implement Inter-Thread Communication Unit

2016-02-03 Thread Leon Alrae
Inter-Thread Communication Unit (ITU) provides ITC storage which is a gating storage mechanism for efficient communication and data transfer between threads. Each 64-bit location or "cell" within ITC space appears at multiple consecutive addresses, or "views", distinguished by bits [6:3] of the lo

[Qemu-devel] [PATCH 9/9] target-mips: make ITC Configuration Tags accessible to the CPU

2016-02-03 Thread Leon Alrae
Add CP0.ErrCtl register with WST, SPR and ITC bits. In 34K and interAptiv processors these bits are used to enable CACHE instruction access to different arrays. When WST=0, SPR=0 and ITC=1 the CACHE instruction will access ITC tag values. Generally we do not model caches and we have been treating

[Qemu-devel] [PATCH 2/9] hw/mips: add ITC Storage Cells

2016-02-03 Thread Leon Alrae
Define single structure for FIFO and Semaphore cells. Read-only FIFO bit in the ITC cell tag indicates the type of the cell. If the ITC Storage contains both types of cells then FIFOs are located before Semaphores. Since issuing thread can get blocked on the access to a cell (in E/F Synchronized a

Re: [Qemu-devel] [PATCH v5 05/10] qemu-io: allow specifying image as a set of options args

2016-02-03 Thread Daniel P. Berrange
On Wed, Feb 03, 2016 at 08:37:15AM -0700, Eric Blake wrote: > On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: > > Currently qemu-io allows an image filename to be passed on the > > command line, but unless using the JSON format, it does not have > > a way to set any options except the format eg >

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
On 03.02.2016 18:06, Daniel P. Berrange wrote: > On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for several >> reasons: >> - Neither of InetSocketAddress nor UnixSocketAddress alone is >> sufficient, because both are supported

[Qemu-devel] [PATCH v5 2/7] mips/kvm: Implement PRid CP0 register

2016-02-03 Thread James Hogan
Implement saving and restoring to KVM state of the Processor ID (PRid) CP0 register. This allows QEMU to control the PRid exposed to the guest instead of using the default set by KVM. Signed-off-by: James Hogan Reviewed-by: Leon Alrae Cc: Paolo Bonzini Cc: Aurelien Jarno --- target-mips/kvm.c

Re: [Qemu-devel] [PATCH v9] spec: add qcow2 bitmaps extension specification

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 17:41, Fam Zheng wrote: On Wed, 02/03 16:45, Vladimir Sementsov-Ogievskiy wrote: Also current scheme is made like one for snapshots. Okay, then I'll be fine with being consistent. + + +=== Bitmap table === + +Bitmaps are stored using a one-level structure (as opposed to two-lev

Re: [Qemu-devel] [PATCH 3/3] balloon: don't use NVDIMM for ballooning

2016-02-03 Thread Vladimir Sementsov-Ogievskiy
On 03.02.2016 18:42, Markus Armbruster wrote: Eric Blake writes: On 01/27/2016 11:51 PM, Vladimir Sementsov-Ogievskiy wrote: NVDIMM for now is planned to use as a backing store for DAX filesystem in the guest and thus this memory is excluded from guest memory management and LRUs. In this cas

[Qemu-devel] [PATCH v5 3/7] mips/kvm: Implement Config CP0 registers

2016-02-03 Thread James Hogan
Implement saving and restoring to KVM state of the Config CP0 registers (namely Config, Config1, Config2, Config3, Config4, and Config5). These control the features available to a guest, and a few of the fields will soon be writeable by a guest so QEMU needs to know about them so as not to clobber

[Qemu-devel] [PATCH v5 6/7] mips/kvm: Support FPU in MIPS KVM guests

2016-02-03 Thread James Hogan
Support the new KVM_CAP_MIPS_FPU capability, which allows the host's FPU to be exposed to the KVM guest. The capability is enabled if the guest core has an FPU according to its Config1 register. Various config bits are now writeable so that KVM is aware of the configuration (Config1.FP) and so tha

[Qemu-devel] [PATCH 5/9] hw/mips: implement ITC Storage - P/V Sync and Try Views

2016-02-03 Thread Leon Alrae
P/V Synchronized and Try Views can be used to access Semaphore cells. Load returns current value and post-decrements the value in the cell (until it reaches zero). Stores increment the value (until it saturates at 0x). P/V Synchronized View causes the issuing thread to block on read if value i

[Qemu-devel] [PATCH v5 7/7] mips/kvm: Support MSA in MIPS KVM guests

2016-02-03 Thread James Hogan
Support the new KVM_CAP_MIPS_MSA capability, which allows MIPS SIMD Architecture (MSA) to be exposed to the KVM guest. The capability is enabled if the guest core has MSA according to its Config3 register. Various config bits are now writeable so that KVM is aware of the configuration (Config3.MSA

[Qemu-devel] [PATCH v5 0/7] mips/kvm: Support FPU & SIMD (MSA) in MIPS KVM guests

2016-02-03 Thread James Hogan
Here's a v5 refresh of my FPU/MSA patchset for v2.6. Thanks to all who have taken the time to review it so far. This patchset primarily adds support for FPU and MIPS SIMD Architecture (MSA) in MIPS KVM guests to QEMU. It depends on Linux v4.1, specifically my KVM patchset to add the corresponding

[Qemu-devel] [PATCH 3/9] hw/mips: implement ITC Storage - Control View

2016-02-03 Thread Leon Alrae
Control view is used to access the ITC Storage Cell Tags. It never causes the issuing thread to block. Guest can empty the FIFO cell by setting Empty bit to 1. Signed-off-by: Leon Alrae --- hw/misc/mips_itu.c | 104 + 1 file changed, 104 inser

[Qemu-devel] [PATCH v5 5/7] mips/kvm: Support signed 64-bit KVM registers

2016-02-03 Thread James Hogan
Rename kvm_mips_{get,put}_one_reg64() to kvm_mips_{get,put}_one_ureg64() since they take an int64_t pointer, and add separate signed 64-bit accessors. These will be used for double precision floating point registers. Signed-off-by: James Hogan Cc: Paolo Bonzini Cc: Leon Alrae Cc: Aurelien Jarno

[Qemu-devel] [PATCH v5 4/7] mips/kvm: Support unsigned KVM registers

2016-02-03 Thread James Hogan
Add KVM register access functions for the uint32_t type. This is required for FP and MSA control registers, which are represented as unsigned 32-bit integers. Signed-off-by: James Hogan Cc: Paolo Bonzini Cc: Leon Alrae Cc: Aurelien Jarno --- Changes in v3: - Fix big endian (the pointer passed

[Qemu-devel] [PATCH v5 1/7] mips/kvm: Remove a couple of noisy DPRINTFs

2016-02-03 Thread James Hogan
The DPRINTFs in cpu_mips_io_interrupts_pending() and kvm_arch_pre_run() are particularly noisy during normal execution, and also not particularly helpful. Remove them so that more important debug messages can be more easily seen. Signed-off-by: James Hogan Reviewed-by: Leon Alrae Cc: Paolo Bonzi

Re: [Qemu-devel] [PATCH v11 1/2] mirror: Rewrite mirror_iteration

2016-02-03 Thread Max Reitz
On 03.02.2016 02:52, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > The out

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
On 03.02.2016 17:48, Eric Blake wrote: > On 02/03/2016 09:33 AM, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for several >> reasons: >> - Neither of InetSocketAddress nor UnixSocketAddress alone is >> sufficient, because both are supported >> - We cannot use SocketA

Re: [Qemu-devel] [PATCH v7 01/13] machine: Don't allow CPU toplogies with partially filled cores

2016-02-03 Thread Eduardo Habkost
On Mon, Feb 01, 2016 at 10:41:58AM +0100, Igor Mammedov wrote: [...] > > > > How exactly would you migrate a machine today, if you do the > > following? > > > > $ qemu-system-x86_64 -smp 8,sockets=2,cores=2,threads=2,maxcpus=16 > > (QMP) cpu-add id=15 > isn't it the same broken topology? >

Re: [Qemu-devel] [PULL 10/13] log: move qemu-log.c into util/ directory

2016-02-03 Thread Dimitris Aragiorgis
Hi all, A while ago me and Alex [cc'ed] submitted a trivial patch related to logging [1]. Since this patch set here moves the qemu-log.c under util/, our patch will not apply any more. Should we rebase it and resend it against current master? Thanks a lot, dimara [1] https://lists.gnu.org/archiv

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Markus Armbruster
Lluís Vilanova writes: > Gives some general guidelines for reporting errors in QEMU. > > Signed-off-by: Lluís Vilanova I started re-reviewing this, but my suggestions quickly became a rewrite (sorry), so I'm just posting just that. I'll turn it into a proper patch you can include in your serie

[Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-03 Thread Eduardo Habkost
On Thu, Jan 28, 2016 at 06:00:31PM +0100, Igor Mammedov wrote: [...] > It looks like this series might go nowhere but this patch > is not tied to it and useful to us in general > so perhaps you could pick it up after ACKs from > S390/SPAPR maintainers. > > > > > Reviewed-by: Eduardo Habkost We

Re: [Qemu-devel] [PULL 00/13] Tracing patches

2016-02-03 Thread Peter Maydell
On 3 February 2016 at 15:47, Stefan Hajnoczi wrote: > The following changes since commit c65db7705b7926f4a084b93778e4bd5dd3990aad: > > Merge remote-tracking branch > 'remotes/maxreitz/tags/pull-block-for-peter-2016-02-02' into staging > (2016-02-02 18:04:04 +) > > are available in the git

Re: [Qemu-devel] [PATCH v6 1/5] util: Introduce error reporting functions with fatal/abort

2016-02-03 Thread Lluís Vilanova
Markus Armbruster writes: [...] > As to the " " messages: surely you're joking, Mr. Feynman :) BTW, completely off-topic, but I just wanted to say that's a great book :) Cheers, Lluis

Re: [Qemu-devel] [PATCH] rng-random: implement request queue

2016-02-03 Thread Ladi Prosek
Hi Amit, - Original Message - > Hi Ladi, > > Adding Pankaj to CC, he too looked at this recently. > > On (Fri) 22 Jan 2016 [13:19:58], Ladi Prosek wrote: > > If the guest adds a buffer to the virtio queue while another buffer > > is still pending and hasn't been filled and returned by th

[Qemu-devel] [PATCH 1/2] error: Improve documentation some more

2016-02-03 Thread Markus Armbruster
Don't claim error_report_err() always reports to stderr. It actually reports to the current monitor when we have one. Clarify intended use of error_abort and error_fatal. Signed-off-by: Markus Armbruster --- include/qapi/error.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletio

<    1   2   3   4   >