[Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Cao jin
Fix the bug introduced by 595a4f07: function host_pci_config_read() should be pass-by-reference, not value. Signed-off-by: Cao jin --- v3 changelog: 1. Remove cpu_to_le32() since the code only runs on X86. hw/pci-host/piix.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Stefan Weil
Am 02.01.2016 um 09:02 schrieb Cao jin: > Fix the bug introduced by 595a4f07: function host_pci_config_read() should be > pass-by-reference, not value. > > Signed-off-by: Cao jin > --- > v3 changelog: > 1. Remove cpu_to_le32() since the code only runs on X86. > > hw/pci-host/piix.c | 8 +--- >

Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4

2016-01-02 Thread Mark Cave-Ayland
On 02/01/16 04:00, Programmingkid wrote: >> Well they are returning non-zero values, so that's good. After a bit >> more poking, something doesn't make sense - in that same file >> RTL8139::initPCIConfigSpace() claims to set the bus master bit, but if I >> add tracing to hw/pci/pci-host.c then I d

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Cao jin
Hi, Happy new year:) On 01/02/2016 05:06 PM, Stefan Weil wrote: Am 02.01.2016 um 09:02 schrieb Cao jin: Fix the bug introduced by 595a4f07: function host_pci_config_read() should be pass-by-reference, not value. Signed-off-by: Cao jin --- v3 changelog: 1. Remove cpu_to_le32() since the co

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Paolo Bonzini
On 02/01/2016 10:06, Stefan Weil wrote: > Am 02.01.2016 um 09:02 schrieb Cao jin: >> Fix the bug introduced by 595a4f07: function host_pci_config_read() should be >> pass-by-reference, not value. >> >> Signed-off-by: Cao jin >> --- >> v3 changelog: >> 1. Remove cpu_to_le32() since the code only

Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4

2016-01-02 Thread Programmingkid
On Jan 2, 2016, at 4:39 AM, Mark Cave-Ayland wrote: > On 02/01/16 04:00, Programmingkid wrote: > >>> Well they are returning non-zero values, so that's good. After a bit >>> more poking, something doesn't make sense - in that same file >>> RTL8139::initPCIConfigSpace() claims to set the bus mast

Re: [Qemu-devel] [XenGT][IGVT-g] Device model creation failed

2016-01-02 Thread Oleksii Kurochko
Hello. I've tried byt_experimental branch and got some another result. With vgt=1 it failed with some time and got next log: > [ 4859.380332] vGT info:(create_vgt_instance:118) vm_id=21, > low_gm_sz=128MB, high_gm_sz=384MB, fence_sz=4, vgt_primary=1 > [ 4859.389889] vGT info:(create_vgt_instance:

Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card compatible with Mac OS 10.4

2016-01-02 Thread Mark Cave-Ayland
On 02/01/16 17:08, Programmingkid wrote: >> After some head scratching chasing this through for several hours >> yesterday, I've worked out what is happening and have a patchset for >> OpenBIOS which should fix the issue (will post later along with some >> other PCI fixes for testing). >> >> This

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Michael S. Tsirkin
On Sat, Jan 02, 2016 at 10:06:10AM +0100, Stefan Weil wrote: > Am 02.01.2016 um 09:02 schrieb Cao jin: > > Fix the bug introduced by 595a4f07: function host_pci_config_read() should > > be > > pass-by-reference, not value. > > > > Signed-off-by: Cao jin > > --- > > v3 changelog: > > 1. Remove cpu

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Michael S. Tsirkin
On Sat, Jan 02, 2016 at 04:02:20PM +0800, Cao jin wrote: > Fix the bug introduced by 595a4f07: function host_pci_config_read() should be > pass-by-reference, not value. > > Signed-off-by: Cao jin > --- > v3 changelog: > 1. Remove cpu_to_le32() since the code only runs on X86. It really should be

[Qemu-devel] [PATCH v5 1/5] fpu: softfloat: Add normalize_roundpack_float32 function

2016-01-02 Thread chengang
From: Chen Gang It is based on (u)int32_to_float32 function to support float32 packing. Signed-off-by: Chen Gang --- fpu/softfloat.c | 55 + include/fpu/softfloat.h | 8 +++ 2 files changed, 63 insertions(+) diff --git a/fpu/softflo

[Qemu-devel] [PATCH v5 2/5] target-tilegx/helper-fshared.h: Add floating point shared function

2016-01-02 Thread chengang
From: Chen Gang It is used by fsingle and fdouble helpers. Signed-off-by: Chen Gang --- target-tilegx/helper-fshared.h | 56 ++ 1 file changed, 56 insertions(+) create mode 100644 target-tilegx/helper-fshared.h diff --git a/target-tilegx/helper-fshared

[Qemu-devel] [PATCH v5 3/5] target-tilegx/helper-fsingle.c: Implement single floating point

2016-01-02 Thread chengang
From: Chen Gang Signed-off-by: Chen Gang --- target-tilegx/helper-fsingle.c | 200 + 1 file changed, 200 insertions(+) create mode 100644 target-tilegx/helper-fsingle.c diff --git a/target-tilegx/helper-fsingle.c b/target-tilegx/helper-fsingle.c new fil

[Qemu-devel] [PATCH v5 4/5] target-tilegx/helper-fdouble.c: Implement double floating point

2016-01-02 Thread chengang
From: Chen Gang Signed-off-by: Chen Gang --- target-tilegx/helper-fdouble.c | 383 + 1 file changed, 384 insertions(+) create mode 100644 target-tilegx/helper-fdouble.c diff --git a/target-tilegx/helper-fdouble.c b/target-tilegx/helper-fdouble.c new fil

[Qemu-devel] [PATCH v5 5/5] target-tilegx: Integrate floating pointer implementation

2016-01-02 Thread chengang
From: Chen Gang It passes normal building, and gcc testsuite. Signed-off-by: Chen Gang --- target-tilegx/Makefile.objs | 3 ++- target-tilegx/helper.h | 12 + target-tilegx/translate.c | 66 ++--- 3 files changed, 71 insertions(+), 10 del

Re: [Qemu-devel] [PATCH v5 1/5] fpu: softfloat: Add normalize_roundpack_float32 function

2016-01-02 Thread Chen Gang
For sig == 0 case, the original implementation is incorrect (although it passes gcc testsuite), it needs to consider about sign for float_zero. The related fix diff for it is below. After patches v5 are finished reviewing, I shall merge the fix diff below to patch v6, next. Thanks. diff --git a

[Qemu-devel] [PATCH v5 0/5] target-tilegx: Implement floating point instructions

2016-01-02 Thread chengang
From: Chen Gang These patches are the normal floating point implementation, instead of the original temporary one. It passes building, and gcc testsuite. Chen Gang (5): fpu: softfloat: Add normalize_roundpack_float32 function target-tilegx/helper-fshared.h: Add floating point shared functio