[Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants

2015-12-23 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Signed-off-by: Daniel P. Berrange --- qemu-nbd.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --gi

[Qemu-devel] [PATCH v2 02/10] qemu-img: add support for --object command line arg

2015-12-23 Thread Daniel P. Berrange
Allow creation of user creatable object types with qemu-img via a new --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # printf letmein > mypasswd.txt # qemu-img info --object

[Qemu-devel] [PATCH v2 07/10] qemu-img: allow specifying image as a set of options args

2015-12-23 Thread Daniel P. Berrange
Currently qemu-img allows an image filename to be passed on the command line, but unless using the JSON format, it does not have a way to set any options except the format eg qemu-img info https://127.0.0.1/images/centos7.iso This adds a --image-opts arg that indicates that the positional file

[Qemu-devel] [PATCH v2 10/10] qemu-io: use no_argument/required_argument constants

2015-12-23 Thread Daniel P. Berrange
When declaring the 'struct option' array, use the standard constants no_argument/required_argument, instead of magic values 0 and 1. Signed-off-by: Daniel P. Berrange --- qemu-io.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/qemu-io.c b/qe

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 06:06:31PM +0300, Roman Kagan wrote: > On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote: > > This is the actual vs expected diff with both patches applied. > > Interesting... The diff suggests that qemu running in your test > environment has no floppy dri

Re: [Qemu-devel] [PATCH v2 08/10] qemu-nbd: don't overlap long option values with short options

2015-12-23 Thread Eric Blake
On 12/23/2015 10:11 AM, Daniel P. Berrange wrote: > When defining values for long options, the normal practice is > to start numbering from 256, to avoid overlap with the range > of valid values for short options. > > Signed-off-by: Daniel P. Berrange > --- > qemu-nbd.c | 12 ++-- > 1 fi

Re: [Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants

2015-12-23 Thread Eric Blake
On 12/23/2015 10:11 AM, Daniel P. Berrange wrote: > When declaring the 'struct option' array, use the standard > constants no_argument/required_argument, instead of magic > values 0 and 1. > > Signed-off-by: Daniel P. Berrange > --- > qemu-nbd.c | 47 -

Re: [Qemu-devel] [PATCH v2 10/10] qemu-io: use no_argument/required_argument constants

2015-12-23 Thread Eric Blake
On 12/23/2015 10:11 AM, Daniel P. Berrange wrote: > When declaring the 'struct option' array, use the standard > constants no_argument/required_argument, instead of magic > values 0 and 1. > > Signed-off-by: Daniel P. Berrange > --- > qemu-io.c | 30 +++--- > 1 file chang

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Igor Mammedov
On Wed, 23 Dec 2015 20:20:54 +0300 Roman Kagan wrote: > On Wed, Dec 23, 2015 at 06:06:31PM +0300, Roman Kagan wrote: > > On Wed, Dec 23, 2015 at 03:45:29PM +0200, Michael S. Tsirkin wrote: > > > This is the actual vs expected diff with both patches applied. > > > > Interesting... The diff sugge

[Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2015-12-23 Thread Vladimir Sementsov-Ogievskiy
The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an ability to store virtual disk related bitmaps in a qcow2 image. For now there is only one type of such bitmaps: Dirty Tracking Bitmap, which just tracks virtual disk change

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Roman Kagan
On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote: > On Wed, 23 Dec 2015 20:20:54 +0300 > Roman Kagan wrote: > > > ... two 1.44M drives with bogus geometry for q35. > > > > This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE > > being non-zero, and forgot to initia

[Qemu-devel] [PATCH v8 29.5/35] fixup! qapi: Canonicalize missing object to :empty

2015-12-23 Thread Eric Blake
[original message is fine; here's a couple more related changes that can be squashed in] Signed-off-by: Eric Blake --- scripts/qapi-commands.py | 10 +- scripts/qapi.py | 3 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qa

Re: [Qemu-devel] [PATCH 4/7] qemu-io: add support for --object command line arg

2015-12-23 Thread Paolo Bonzini
On 22/12/2015 18:24, Daniel P. Berrange wrote: > I was a little reluctant to move this 'object_create' method into the > qom/ code though, since I hate the idea of the legacy 'QemuOpts' data > anywhere near those nice new APIs. I guess I could perhaps just keep the > qemu_opts_to_qdict() call in

Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args

2015-12-23 Thread Paolo Bonzini
On 23/12/2015 17:55, Daniel P. Berrange wrote: >>> > > A third option would be to keep using positional arguments, but >>> > > add a '--source-opts' *boolean* flag to indicate how to interpret >>> > > the positional arguments. ie without --source-opts we use the >>> > > historic syntax, but with

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2015 at 06:40:12AM +, Gonglei (Arei) wrote: > > From: Kevin O'Connor [mailto:ke...@koconnor.net] > > On Tue, Dec 22, 2015 at 02:14:12AM +, Gonglei (Arei) wrote: > > > Sorry, it doesn't work. What's worse is we cannot stop SeaBIOS stuck by > > > Setting "CONFIG_ENTRY_EXTRASTA

Re: [Qemu-devel] [PATCH] qemu-char: delete send_all/recv_all helper methods

2015-12-23 Thread Paolo Bonzini
On 23/12/2015 14:59, Daniel P. Berrange wrote: > The qemu-char.c contains two helper methods send_all > and recv_all. These are in fact declared in sockets.h > so ought to have been in util/qemu-sockets.c. For added > fun the impl of recv_all is completely missing on Win32. > > Fortunately there

Re: [Qemu-devel] [PULL v1 0/6] Misc crypto changes & fixes

2015-12-23 Thread Peter Maydell
On 23 December 2015 at 11:13, Daniel P. Berrange wrote: > The following changes since commit 5dc42c186d63b7b338594fc071cf290805dcc5a5: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2015-12-22 14:21:42 +) > > are available in the git repository a

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

2015-12-23 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, 21 December 2015 14:57 > On Mon, Dec 21, 2015 at 2:25 PM, Andrew Baumann > wrote: > >> From: qemu-devel- > bounces+andrew.baumann=microsoft@nongnu.org > >> [mailto:qemu-devel- > >> bounces+andrew.baumann=microsoft...

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

2015-12-23 Thread Peter Maydell
On 21 December 2015 at 22:25, Andrew Baumann wrote: >> If you change the VMSTATE layout, you need to bump the version. As >> this is very common code, it may have stricter version bump >> requirements. Last I knew however, there was a way to add new fields >> at the end of VMSD without breaking b

Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5

2015-12-23 Thread Shmulik Ladkani
Hi, On Fri, 18 Dec 2015 09:30:02 +0200 Shmulik Ladkani wrote: > Introduce the place-holder for 2.5 back-compat properties, and the > accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5. Please ignore this series, it'll clash. Recent pull has already introduced HW_COMPAT_2_5 and PC_COM

Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args

2015-12-23 Thread Daniel P. Berrange
On Wed, Dec 23, 2015 at 07:03:34PM +0100, Paolo Bonzini wrote: > > > On 23/12/2015 17:55, Daniel P. Berrange wrote: > >>> > > A third option would be to keep using positional arguments, but > >>> > > add a '--source-opts' *boolean* flag to indicate how to interpret > >>> > > the positional argume

Re: [Qemu-devel] [PATCH 4/7] qemu-io: add support for --object command line arg

2015-12-23 Thread Daniel P. Berrange
On Wed, Dec 23, 2015 at 07:02:01PM +0100, Paolo Bonzini wrote: > > > On 22/12/2015 18:24, Daniel P. Berrange wrote: > > I was a little reluctant to move this 'object_create' method into the > > qom/ code though, since I hate the idea of the legacy 'QemuOpts' data > > anywhere near those nice new

[Qemu-devel] [PATCH] spapr: Introduce SPAPR_COMPAT_2_5

2015-12-23 Thread Shmulik Ladkani
In 240240d5 'pc: Add pc-*-2.6 machine classes' HW_COMPAT_2_5 and PC_COMPAT_2_5 were introduced. Accordingly, introduce SPAPR_COMPAT_2_5 that uses HW_COMPAT_2_5. Signed-off-by: Shmulik Ladkani --- hw/ppc/spapr.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc

Re: [Qemu-devel] [PATCH v2 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

2015-12-23 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, 23 December 2015 11:21 > On 21 December 2015 at 22:25, Andrew Baumann > wrote: > > >> If you change the VMSTATE layout, you need to bump the version. As > >> this is very common code, it may have stricter version bump > >>

[Qemu-devel] [PATCH] s390: Introduce CCW_COMPAT_2_5

2015-12-23 Thread Shmulik Ladkani
In 240240d5 'pc: Add pc-*-2.6 machine classes' HW_COMPAT_2_5 and PC_COMPAT_2_5 were introduced. Accordingly, introduce CCW_COMPAT_2_5 that uses HW_COMPAT_2_5. Signed-off-by: Shmulik Ladkani --- hw/s390x/s390-virtio-ccw.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/s390x/s390

[Qemu-devel] [PATCH v2] vmw_pvscsi: x-disable-pcie, x-old-pci-configuration back-compat props are 2.5 specific

2015-12-23 Thread Shmulik Ladkani
pvscsi's x-disable-pcie and x-old-pci-configuration backward compat properties were introduced in 952970b and d5da3ef: vmw_pvscsi: Introduce 'x-old-pci-configuration' backword compatability property vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property and were placed into H

Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args

2015-12-23 Thread Paolo Bonzini
- Original Message - > From: "Daniel P. Berrange" > To: "Paolo Bonzini" > Cc: "Eric Blake" , "Kevin Wolf" , > qemu-bl...@nongnu.org, qemu-devel@nongnu.org, > "Markus Armbruster" , "Andreas Färber" > Sent: Wednesday, December 23, 2015 8:23:13 PM > Subject: Re: [Qemu-devel] [PATCH 7/7]

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

2015-12-23 Thread Paolo Bonzini
On 22/12/2015 00:33, Peter Crosthwaite wrote: >>> >> >>> >> case 0x80..0x8c >> > >> > Woah! Is that standard C? >> > > Yes, its probably one of the more recent language standards though. > QEMU does use to more modern features liberally. It's actually "case 0x80 ... 0x8c:". >> Notice that this

[Qemu-devel] [PATCH v6 05/16] qapi: Hide tag_name data member of variants

2015-12-23 Thread Eric Blake
Clean up the only remaining external use of the tag_name field of QAPISchemaObjectTypeVariants, by explicitly listing the generated 'type' tag for all variants in the testsuite. Then we can mark the tag_name field as private by adding a leading underscore to prevent any further use. Signed-off-by

[Qemu-devel] [PATCH v6 01/16] net: use Netdev instead of NetClientOptions in client init

2015-12-23 Thread Eric Blake
From: Kővágó, Zoltán This way we no longer need NetClientOptions and can convert Netdev into a flat union. Signed-off-by: Kővágó, Zoltán Reviewed-by: Eric Blake Message-Id: <93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.dirty.ice...@gmail.com> [rework net_client_init1() to pass Net

[Qemu-devel] [PATCH v6 03/16] qapi: Forbid empty unions and useless alternates

2015-12-23 Thread Eric Blake
Empty unions serve no purpose, and while we compile with gcc which permits them, strict C99 forbids them. We could inject a dummy member (and in fact, we do for empty structs), but while empty structs make sense in qapi, empty unions don't add any expressiveness to the QMP language. So prohibit t

[Qemu-devel] [PATCH v6 00/16] qapi netdev_add introspection (post-introspection cleanups subset F)

2015-12-23 Thread Eric Blake
Prerequisites: + my qapi cleanups subset E v8: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html This is the final subset of my original cleanups series v5. The focus here is adding a 'box':true parameter and anonymous flat union base syntax, so that we can finally represent netd

[Qemu-devel] [PATCH v6 11/16] net: Complete qapi-fication of netdev_add

2015-12-23 Thread Eric Blake
We finally have all the required pieces for doing a type-safe representation of netdev_add as a flat union, where the discriminator 'type' now selects which additional members may appear in the "arguments" JSON object sent over QMP, while making no changes to the set of previously-valid QMP command

[Qemu-devel] [PATCH v6 08/16] qapi: support implicit structs in OptsVisitor

2015-12-23 Thread Eric Blake
From: Kővágó, Zoltán They are required for flat unions (you still have to allocate the structs). Signed-off-by: Kővágó, Zoltán Message-Id: <88451f26df139c09b56b1525f3c5afeea43dd3db.1441627175.git.dirty.ice...@gmail.com> [rebase to latest tree] Signed-off-by: Eric Blake --- v6: rebase from or

[Qemu-devel] [PATCH v6 04/16] qapi: Drop useless 'data' member of unions

2015-12-23 Thread Eric Blake
Now that we no longer have any clients of the 'void *data' member injected into unions, we can drop it. Update the testsuite to drop the negative test union-clash-data, and replace it with a positive test in qapi-schema-test that proves that we no longer have a name collision. Signed-off-by: Eric

[Qemu-devel] [PATCH v6 02/16] qapi: Avoid use of 'data' member of qapi unions

2015-12-23 Thread Eric Blake
qapi code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a qapi union. However, directly assigning to this member of the union feels a bit fishy, when we can directly use the rest of the struct instead. Signed-off-by: Eri

[Qemu-devel] [PATCH v6 16/16] qapi: Populate info['name'] for each entity

2015-12-23 Thread Eric Blake
Every non-implicit entity is associated with an 'info' dictionary, but it is not easy to reverse-engineer the name of the top-most entity associated with that 'info'. Our use of 'case_whitelist' (added in commit 893e1f2) is thus currently tied to the owner of a member instead; but now that anonymo

[Qemu-devel] [PATCH v6 07/16] qapi: Implement boxed types for commands/events

2015-12-23 Thread Eric Blake
Turn on the ability to pass command and event arguments in a single boxed parameter. For structs, it makes it possible to pass a single qapi type instead of a breakout of all struct members; for unions, it is now possible to use a union as the data for a command or event. Generated code is unchan

[Qemu-devel] [PATCH v6 13/16] qapi: Use anonymous base in SchemaInfo

2015-12-23 Thread Eric Blake
Now that the generator supports it, we might as well use an anonymous base rather than breaking out a single-use SchemaInfoBase structure. Oddly enough, this change does not affect the resulting introspection output (because we already inline the members of a base type into an object, and had no i

[Qemu-devel] [PATCH v6 15/16] qapi: Use anonymous base in CpuInfo

2015-12-23 Thread Eric Blake
Now that the generator supports it, we might as well use an anonymous base rather than breaking out a single-use CpuInfoBase structure. Signed-off-by: Eric Blake --- v6: new patch --- qapi-schema.json | 20 ++-- scripts/qapi.py | 2 +- 2 files changed, 7 insertions(+), 15 dele

[Qemu-devel] [PATCH v6 06/16] qapi: Plumb in 'box' to qapi generator lower levels

2015-12-23 Thread Eric Blake
A future patch will add support for passing a qapi union type as the 'data' of a command. But to do that, the user function for implementing the command, as called by the generated marshal command, must take the corresponding C struct as a single boxed pointer, rather than a breakdown into one par

[Qemu-devel] [PATCH v6 12/16] qapi: Allow anonymous base for flat union

2015-12-23 Thread Eric Blake
Rather than requiring all flat unions to explicitly create a separate base struct, we want to allow the qapi schema to specify the common fields via an inline dictionary. This is similar to how commands can specify inline types for the arguments. Now that the feature is legal, we can drop the form

Re: [Qemu-devel] [PATCH v6 00/16] qapi netdev_add introspection (post-introspection cleanups subset F)

2015-12-23 Thread Eric Blake
On 12/23/2015 01:55 PM, Eric Blake wrote: > Prerequisites: > + my qapi cleanups subset E v8: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv6f and part of my branch of pending q

[Qemu-devel] [PATCH v6 14/16] qapi: Use anonymous base in Netdev

2015-12-23 Thread Eric Blake
Now that the generator supports it, we might as well use an anonymous base rather than breaking out a single-use NetdevBase structure. Signed-off-by: Eric Blake --- v6: new patch --- qapi-schema.json | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/qapi-

[Qemu-devel] [PATCH v6 09/16] qapi: Change Netdev into a flat union

2015-12-23 Thread Eric Blake
From: Kővágó, Zoltán Except qapi-schema.json, this patch was generated by: find . -name .git -prune -o -type f \! -name '*~' -print0 | \ xargs -0 sed -i \ -e 's/NetClientOptionsKind/NetClientDriver/g' \ -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \ -e 's/netdev->opts/netde

[Qemu-devel] [PATCH v6 10/16] net: Use correct type for bool flag

2015-12-23 Thread Eric Blake
is_netdev is only used as a bool, so make it one. Signed-off-by: Eric Blake --- v6: rebase to latest context --- hw/usb/dev-network.c | 2 +- include/net/net.h| 2 +- net/net.c| 12 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-network.

Re: [Qemu-devel] [PATCH v2 00/14] Add qapi-to-JSON output visitor

2015-12-23 Thread Eric Blake
On 12/21/2015 05:30 PM, Eric Blake wrote: > Prerequisites: > + my qapi cleanups subset E v8: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git qapi-jsonv2 and part of my branch of pending qapi

Re: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations

2015-12-23 Thread Denis V. Lunev
On 12/18/2015 09:10 AM, Denis V. Lunev wrote: On 12/11/2015 12:33 PM, Denis V. Lunev wrote: On 12/04/2015 05:44 PM, Denis V. Lunev wrote: EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Anoth

Re: [Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to do_savevm and hmp_savevm wrapper

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > This would be useful in the next step when QMP version of this call will > be introduced. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Juan Quintela > CC: Amit Shah > CC: Markus Armbruster > CC: Eric Blake > --- > migration/savevm.c | 38 ++

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Max Reitz
On 23.12.2015 11:48, Paolo Bonzini wrote: > bdrv_close is used when ejecting a medium. Is it still? Other than it maybe being indirectly called through bdrv_delete(), it shouldn't be. > Use a drained section to ensure > that all I/O goes to either the o

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > 'name' attribute is made mandatory in distinction with HMP command. > > The patch also moves hmp_savevm implementation into hmp.c. This function > is just a simple wrapper now and does not have knowledge about > migration internals. > > Signed-off-b

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 12:40 AM, Eric Blake wrote: On 12/04/2015 07:44 AM, Denis V. Lunev wrote: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about mig

Re: [Qemu-devel] [PATCH 3/5] qmp: create qmp_delvm command

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > The patch also moves hmp_delvm implementation into hmp.c. This function > is just a simple wrapper now and does not have knowledge about > migration internals. > > Signed-off-by: Denis V. Lunev > CC: Juan Quintela > CC: Amit Shah > CC: Markus Armb

[Qemu-devel] [PATCH v4 2/4] target-tilegx: Add single floating point implementation

2015-12-23 Thread chengang
From: Chen Gang Signed-off-by: Chen Gang --- target-tilegx/helper-fsingle.c | 211 + 1 file changed, 211 insertions(+) create mode 100644 target-tilegx/helper-fsingle.c diff --git a/target-tilegx/helper-fsingle.c b/target-tilegx/helper-fsingle.c new fil

[Qemu-devel] [PATCH v4 4/4] target-tilegx: Integrate floating pointer implementation

2015-12-23 Thread chengang
From: Chen Gang It passes normal building, and gcc testsuite. Signed-off-by: Chen Gang --- target-tilegx/Makefile.objs | 3 ++- target-tilegx/helper.h | 12 + target-tilegx/translate.c | 66 ++--- 3 files changed, 71 insertions(+), 10 del

[Qemu-devel] [PATCH v4 3/4] target-tilegx: Add double floating point implementation

2015-12-23 Thread chengang
From: Chen Gang Signed-off-by: Chen Gang --- target-tilegx/helper-fdouble.c | 382 + 1 file changed, 382 insertions(+) create mode 100644 target-tilegx/helper-fdouble.c diff --git a/target-tilegx/helper-fdouble.c b/target-tilegx/helper-fdouble.c new fil

[Qemu-devel] [PATCH v4 1/4] target-tilegx: Add floating point shared functions

2015-12-23 Thread chengang
From: Chen Gang They are used by fsingle and fdouble helpers. Signed-off-by: Chen Gang --- target-tilegx/helper-fshared.c | 22 + target-tilegx/helper-fshared.h | 55 ++ 2 files changed, 77 insertions(+) create mode 100644 target-tilegx/

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: 086: Add raw format

2015-12-23 Thread Max Reitz
On 23.12.2015 07:26, Fam Zheng wrote: > Raw is as qualified as qcow2 for this test case, add it for more > coverage. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/086 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/XanClic/

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Paolo Bonzini
> On 23.12.2015 11:48, Paolo Bonzini wrote: > > bdrv_close is used when ejecting a medium. > > Is it still? Other than it maybe being indirectly called through > bdrv_delete(), it shouldn't be. Yes, through blk_remove_bs -> bdrv_unref -> bdrv_delete. > >

[Qemu-devel] [PATCH v4 0/4] target-tilegx: Implement floating point instructions

2015-12-23 Thread chengang
From: Chen Gang These patches are the normal floating point implementation, instead of the original temporary one. It passes building, and gcc testsuite. Chen Gang (4): target-tilegx: Add floating point shared functions target-tilegx: Add single floating point implementation target-tilegx

Re: [Qemu-devel] [PATCH 4/5] migration: improve error reporting for load_vmstate

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > The patch adds Error ** parameter to load_vmstate call and fills error > inside. The caller after that properly reports error either through > monitor or via local stderr facility during VM start. > > This helper will be useful too for qmp_loadvm imp

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: make check-block.sh work on out-of-tree builds

2015-12-23 Thread Max Reitz
On 23.12.2015 11:42, Paolo Bonzini wrote: > Since check-block.sh, the "check" script has learnt to find the source > path. On the other hand, it expects common.env to be in the build tree > (both changes made in commit 76c7560, "configure: Enable out-of-tree > iotests", 2014-05-24). So, it is wro

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Max Reitz
On 23.12.2015 22:55, Paolo Bonzini wrote: > >> On 23.12.2015 11:48, Paolo Bonzini wrote: >>> bdrv_close is used when ejecting a medium. >> >> Is it still? Other than it maybe being indirectly called through >> bdrv_delete(), it shouldn't be. > > Yes, through blk_remove_bs -> bdrv_unref -> bdrv_de

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2015-12-23 Thread Max Reitz
On 23.12.2015 18:49, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such bi

Re: [Qemu-devel] [PATCH v4 1/4] target-tilegx: Add floating point shared functions

2015-12-23 Thread Richard Henderson
On 12/23/2015 01:48 PM, cheng...@emindsoft.com.cn wrote: +extern float_status fp_status; No. Locally declared in e.g. main_calc. r~

Re: [Qemu-devel] [PATCH v4 2/4] target-tilegx: Add single floating point implementation

2015-12-23 Thread Richard Henderson
On 12/23/2015 01:48 PM, cheng...@emindsoft.com.cn wrote: +static float32 sfmt_to_float32(uint64_t sfmt) +{ +uint32_t sign = get_fsingle_sign(sfmt); +uint32_t man = get_fsingle_man(sfmt); +uint32_t exp = get_fsingle_exp(sfmt); +float32 f; + +if (get_fsingle_calc(sfmt) == TILEGX

Re: [Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > Unfortunately load_vmstate has a return code (int) and this code is checked > in the other places. Thus we could not just rename it to qmp_loadvm as > returns void. > > Signed-off-by: Denis V. Lunev > CC: Juan Quintela > CC: Amit Shah > CC: Markus

Re: [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Max Reitz
On 23.12.2015 04:14, Fam Zheng wrote: > On Tue, 12/22 17:46, Kevin Wolf wrote: >> Enough innocent images have died because users called 'qemu-img snapshot' >> while >> the VM was still running. Educating the users doesn't seem to be a working >> strategy, so this series adds locking to qcow2 that

[Qemu-devel] [Bug 1323758] Re: Mouse stops working when connected usb-storage-device

2015-12-23 Thread Maarten Jacobs
Magic! I'd been trying to figure out how to prevent my mouse from stopping at apparently random points... Works like magic! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323758 Title: Mouse stops

Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error

2015-12-23 Thread Max Reitz
On 22.12.2015 15:39, John Snow wrote: > > > On 12/22/2015 05:11 AM, Fam Zheng wrote: >> Since a5002d5 (block/qapi: allow best-effort query) we don't return at >> this error, however err must be cleared before passing to >> bdrv_query_snapshot_info_list below, as required by error API. >> >> Signe

Re: [Qemu-devel] [PATCH v2 00/11] iotests: Clean up "mv $TEST_IMG $TEST_IMG.XXX"

2015-12-23 Thread Max Reitz
On 22.12.2015 03:49, Fam Zheng wrote: > v2: Add Max's rev-by in patches 1-9. > Fix quote bugs in patch 10 and split out _img_info filtering patch 11. > > Commit 794d00f71d fixed two "mv" commands into the TEST_IMG override approach. > There are still more occasions of "mv", this series fixes t

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2015-12-23 Thread Eric Blake
On 12/23/2015 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2015-12-23 Thread Eric Blake
On 12/23/2015 12:46 AM, Denis V. Lunev wrote: > From: Olga Krishtal > > While opening the image we want to be sure that we are the > one who works with image, anf if it is not true - s/anf/and/ > opening the image for writing should fail. > > There are 2 ways at the moment: no lock at all and

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

2015-12-23 Thread Peter Crosthwaite
On Wed, Dec 23, 2015 at 12:32 PM, Paolo Bonzini wrote: > > > On 22/12/2015 00:33, Peter Crosthwaite wrote: >> >> case 0x80..0x8c >>> > >>> > Woah! Is that standard C? >>> > >> Yes, its probably one of the more recent language standards though. >> QEMU does use to more modern features lib

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

2015-12-23 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Wednesday, 23 December 2015 15:59 > >>> Notice that this file comes from Linux. I know it's not pretty, but > > Where in Linux exactly? I am actually having trouble finding the > original source. Grepping around linux-next, ther

Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

2015-12-23 Thread Max Reitz
On 23.12.2015 05:12, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > Signed-

Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

2015-12-23 Thread Max Reitz
On 24.12.2015 01:15, Max Reitz wrote: > On 23.12.2015 05:12, Fam Zheng wrote: >> The "pnum < nb_sectors" condition in deciding whether to actually copy >> data is unnecessarily strict, and the qiov initialization is >> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. >> >> Rewrite mirr

[Qemu-devel] [PATCH v2 1/7] bcm2835_mbox: add BCM2835 mailboxes

2015-12-23 Thread Andrew Baumann
This adds the system mailboxes which are used to communicate with a number of GPU peripherals on Pi/Pi2. Signed-off-by: Andrew Baumann --- Notes: v2: * renamed bcm2835_sbm to bcm2835_mbox * dropped bcm2835_arm_control.h (needed defs moved to bcm2835_mbox.c) * documented use of

[Qemu-devel] [PATCH v2 7/7] raspi: add raspberry pi 2 machine

2015-12-23 Thread Andrew Baumann
bcm2835/Pi1 requires more peripherals, and will be added in a later patch series. Signed-off-by: Andrew Baumann --- hw/arm/Makefile.objs | 2 +- hw/arm/raspi.c | 179 +++ 2 files changed, 180 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH v2 0/7] Raspberry Pi 2 support

2015-12-23 Thread Andrew Baumann
This patch series adds initial support for Raspberry Pi 2 (bcm2836). It is heavily based on the original (out of tree) work of Gregory Estrade, Stefan Weil and others to support Raspberry Pi 1. At the end of this series, it is possible to boot a recent raspbian kernel to a serial console using an

[Qemu-devel] [PATCH v2 2/7] bcm2835_property: add bcm2835 property channel

2015-12-23 Thread Andrew Baumann
This sits behind the mailbox interface, and implements request/response queries for system properties. The framebuffer-related properties will be added in a later patch. Signed-off-by: Andrew Baumann --- hw/misc/Makefile.objs | 1 + hw/misc/bcm2835_property.c | 277 +++

[Qemu-devel] [PATCH v2 4/7] bcm2835_peripherals: add rollup device for bcm2835 peripherals

2015-12-23 Thread Andrew Baumann
This device maintains all the non-CPU peripherals on bcm2835 (Pi1) which are also present on bcm2836 (Pi2). It also implements the private address space used for DMA. Signed-off-by: Andrew Baumann --- Notes: v2 changes: * adapted to use common SDHCI emulation hw/arm/Makefile.objs

[Qemu-devel] [PATCH v2 6/7] bcm2836: add bcm2836 soc device

2015-12-23 Thread Andrew Baumann
This is the SoC for Raspberry Pi 2. Signed-off-by: Andrew Baumann --- hw/arm/Makefile.objs | 2 +- hw/arm/bcm2836.c | 135 +++ include/hw/arm/bcm2836.h | 33 3 files changed, 169 insertions(+), 1 deletion(-) create mode 100

[Qemu-devel] [PATCH v2 3/7] bcm2835_ic: add bcm2835 interrupt controller

2015-12-23 Thread Andrew Baumann
Signed-off-by: Andrew Baumann --- Notes: v2 changes: * split inputs to named gpu_irq and arm_irq gpio inputs * use 64-bit gpu_irq and 8-bit arm_irq status rather than 3*32-bit bitfields * added defined names for register offsets * deleted nop realize method * other m

Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > v3: Rebase to master. Why did you drop patch 1? Max > v2: 01: Move bdrv_op_block_all down. [Max] > 02, 04: Add Max's rev-by. > 03: Check has_mode and fix "return;". [Max] > 05: Check target->blk. > Drop superfluous whitespace. [Max] >

[Qemu-devel] [PATCH v2 5/7] bcm2836_control: add bcm2836 ARM control logic

2015-12-23 Thread Andrew Baumann
This module is specific to the bcm2836 (Pi2). It implements the top level interrupt controller, and mailboxes used for inter-processor synchronisation. Signed-off-by: Andrew Baumann --- hw/intc/Makefile.objs | 2 +- hw/intc/bcm2836_control.c | 338 ++

Re: [Qemu-devel] [PATCH v3 2/5] block: Extract blockdev part of qmp_drive_mirror

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > This is the part that will be reused by blockdev-mirror. > > Signed-off-by: Fam Zheng > --- > blockdev.c | 146 > + > 1 file changed, 88 insertions(+), 58 deletions(-) Reviewed-by: Max Reitz

[Qemu-devel] arm64 qemu tests failing in linux-next since 'arm64: kernel: enforce pmuserenr_el0 initialization and restore'

2015-12-23 Thread Guenter Roeck
oblem and how to fix it (presumably in qemu) ? Bisect log is attached below. Reverting commit 60792ad349f3 on top of linux-next fixes the problem. Thanks, Guenter --- # bad: [80c75a0f1d81922bf322c0634d1e1a15825a89e6] Add linux-next specific files for 20151223 # good: [4ef7675344d687a0ef5b0d7c0ce

Re: [Qemu-devel] [PATCH v3 4/5] qmp: Add blockdev-mirror command

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > This will start a mirror job from a named device to another named > device, its relation with drive-mirror is similar with blockdev-backup > to drive-backup. > > In blockdev-mirror, the target node should be prepared by blockdev-add, > which will be responsi

qemu-devel@nongnu.org

2015-12-23 Thread Programmingkid
I'm having problems with the pci_dma_read() function. When using a Mac OS X guest, the data that this function returns is all zeros. After doing a lot of instruction tracing, I tracked the problem to a function called phys_page_find(). It always returns §ions[PHYS_SECTION_UNASSIGNED]. What I wo

Re: [Qemu-devel] [PATCH v3 5/5] iotests: Add test cases for blockdev-mirror

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/041 | 100 > ++--- > tests/qemu-iotests/041.out | 4 +- > 2 files changed, 79 insertions(+), 25 deletions(-) Reviewed-by: Max Reitz Some comments below. >

[Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap

2015-12-23 Thread chengang
From: Chen Gang In this case, real_end is larger than end, which may cause mmap_frag process the incorrect memory region. Signed-off-by: Chen Gang --- linux-user/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 7b459d5..57b0

Re: [Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap

2015-12-23 Thread Chen Gang
Hello all: After this patch, the i386 wine notepad.exe can be bootup and run under sw_64 host. - The initialization is very very slow (about 10 minutes), it is mainly running in find_vma_reserved (consume more than 95% time resource). I guess, it can be optimized. - After initialization,

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-23 Thread Zhu Guihua
On 12/17/2015 05:58 AM, Igor Mammedov wrote: On Wed, 16 Dec 2015 16:46:37 +0100 Andreas Färber wrote: Am 10.12.2015 um 13:35 schrieb Igor Mammedov: wrt CLI can't we do something like this? -device some-cpu-model,socket=x[,core=y[,thread=z]] That's problematic and where my x86 remodeling go

Re: [Qemu-devel] [PATCH] Xen PCI passthrough: convert to realize()

2015-12-23 Thread Cao jin
On 12/23/2015 10:03 PM, Stefano Stabellini wrote: On Wed, 23 Dec 2015, Cao jin wrote: [...] The patch as is fails to build: qemu/hw/xen/xen_pt_config_init.c: In function ‘xen_pt_config_init’: qemu/hw/xen/xen_pt_config_init.c:2061:42: error: ‘rc’ may be used uninitialized in this func r

Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

2015-12-23 Thread Fam Zheng
On Thu, 12/24 01:21, Max Reitz wrote: > On 24.12.2015 01:15, Max Reitz wrote: > > On 23.12.2015 05:12, Fam Zheng wrote: > >> The "pnum < nb_sectors" condition in deciding whether to actually copy > >> data is unnecessarily strict, and the qiov initialization is > >> unnecessarily for bdrv_aio_write

Re: [Qemu-devel] [PATCH v3 0/5] correct some register return values for vxmnet3

2015-12-23 Thread Jason Wang
On 12/23/2015 02:29 PM, Dmitry Fleytman wrote: > Reviewed-by: Dmitry Fleytman > >> On 23 Dec 2015, at 08:06 AM, Miao Yan wrote: >> >> Qemu vmxnet3 emulation doesn't recognize VMXNET3_CMD_GET_DID_LO, >> VMXNET3_CMD_GET_DID_HI and VMXNET3_CMD_GET_DEV_EXTRA_INFO command and >> returns -1 on all of

Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror

2015-12-23 Thread Fam Zheng
On Thu, 12/24 01:26, Max Reitz wrote: > On 23.12.2015 06:59, Fam Zheng wrote: > > v3: Rebase to master. > > Why did you drop patch 1? Because we already have 10f3cd15dd9913f8d959fbd061e6e00c45432093 Fam

[Qemu-devel] [PATCH v8 0/2] mirror: Improve zero write and discard

2015-12-23 Thread Fam Zheng
v8: Rebase onto master (didn't pick up Max's rev-by due to non-trivial code change). The conflict is around removed lines about "max_iov" and "IOV_MAX" due to commit 3515727f3, but this also reveals this series forgot that check. So this revision adds it back: - Two new fields

[Qemu-devel] [PATCH v8 2/2] mirror: Add mirror_wait_for_io

2015-12-23 Thread Fam Zheng
The three lines are duplicated a number of times now, refactor a function. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/mirror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 0081c2e..07ad068 100

<    1   2   3   >