On Thu, 12/24 01:21, Max Reitz wrote: > On 24.12.2015 01:15, Max Reitz wrote: > > On 23.12.2015 05:12, Fam Zheng wrote: > >> The "pnum < nb_sectors" condition in deciding whether to actually copy > >> data is unnecessarily strict, and the qiov initialization is > >> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > >> > >> Rewrite mirror_iteration to fix both flaws. > >> > >> Signed-off-by: Fam Zheng <f...@redhat.com> > >> --- > >> block/mirror.c | 308 > >> +++++++++++++++++++++++++++++++++++---------------------- > >> 1 file changed, 188 insertions(+), 120 deletions(-) > > > > Reviewed-by: Max Reitz <mre...@redhat.com> > > Forgot to note: I think this patch needs a rebase already. >
Thanks for noticing that! I'm rebasing it now. Fam
