Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr/pci: populate PCI DT in reverse order

2015-12-21 Thread Greg Kurz
On Mon, 21 Dec 2015 12:56:24 +1100 David Gibson wrote: > On Thu, Dec 17, 2015 at 09:43:29AM +0100, Greg Kurz wrote: > > On Thu, 3 Dec 2015 15:53:17 +0100 > > Greg Kurz wrote: > > > > > On Tue, 1 Dec 2015 22:48:38 +0100 > > > Thomas Huth wrote: > > > > > > > On 30/11/15 11:45, Greg Kurz wrote:

Re: [Qemu-devel] [PATCH v2] linux-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()

2015-12-21 Thread Laurent Vivier
Le 21/12/2015 03:33, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > When mapping MAP_ANONYMOUS memory fragments, still need notice about to > set it zero, or it will cause issues. Perhaps you can explain in the commit message why this page is not already filled by zeros ? > Signed-

[Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

2015-12-21 Thread P J P
Hello, A stack overflow issue was reported by Mr Qinghao Tang, CC'd here. It occurs while processing the SCSI controller's CTRL_GET_INFO command, as the memset(2) call uses driver supplied 'cmd->iov_size' to initialise the '&info' object. Please see below a proposed patch to fix this issue.

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-12-21 Thread Gonglei (Arei)
Dear Kevin, > -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Sunday, December 20, 2015 10:33 PM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org; Radim Krcmar > Subject: Re: [Qe

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Marcel Apfelbaum
On 12/21/2015 04:59 AM, Cao jin wrote: On 12/20/2015 07:21 PM, Marcel Apfelbaum wrote: On 12/20/2015 12:48 PM, Cao jin wrote: Hi, On 12/20/2015 06:22 PM, Marcel Apfelbaum wrote: [...] + +err_register_bus: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJE

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Cao jin
On 12/21/2015 06:08 PM, Marcel Apfelbaum wrote: On 12/21/2015 04:59 AM, Cao jin wrote: [...] Another question: because some of this series is CCed to qemu-trivial(which means: reviewed-by?) by other maintainer, so next time, do I need to send the whole series with "v2", or the rest? Hi,

Re: [Qemu-devel] [PATCH 01/12] Removed unused variable.

2015-12-21 Thread Peter Crosthwaite
On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite > --- > hw/block/m25p80.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index efc43dd..bfd493f 100644 > -

Re: [Qemu-devel] [PATCH 08/12] Support for N25Q256A/N25Q512A

2015-12-21 Thread Peter Crosthwaite
On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index f0f637e..a41c2f1 100644 > --- a/hw/block/m25p80.c > +++ b/hw

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Cao jin
Hi Paolo On 12/20/2015 07:38 PM, Cao jin wrote: Hi On 12/19/2015 02:01 AM, Paolo Bonzini wrote: On 18/12/2015 12:03, Cao jin wrote: [...] + +err_register_bus: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +object_unref(OBJECT(bus)); I think these should be object_unp

Re: [Qemu-devel] [Xen-devel] new barrier type for paravirt (was Re: [PATCH] virtio_ring: use smp_store_mb)

2015-12-21 Thread David Vrabel
On 20/12/15 09:25, Michael S. Tsirkin wrote: > > I noticed that drivers/xen/xenbus/xenbus_comms.c uses > full memory barriers to communicate with the other side. > For example: > > /* Must write data /after/ reading the consumer index. * */ > mb(); > >

Re: [Qemu-devel] [PATCH 09/12] Support for 6Bytes jdec.

2015-12-21 Thread Peter Crosthwaite
You need to add more notes in commit messages about what you have changed. Specifically here, you need to say something about the arrayification of the Jedec ID. You are also correcting terminology by changing ext_jedec to ext_id which shuld be mentioned. On Wed, Dec 16, 2015 at 4:57 AM, wrote:

Re: [Qemu-devel] [PATCH v2 26/74] pc: acpi: memhp: move MHPD._STA method into SSDT

2015-12-21 Thread Igor Mammedov
On Sun, 20 Dec 2015 15:41:22 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 16, 2015 at 03:47:35PM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - add parentheses around ifctx block > >Suggested-by: Marcel Apfelbaum > > --- > > hw/acpi/memory_hotplug_ac

[Qemu-devel] [PATCH v2 1/2] igd-passthrough-i440FX: convert to realize()

2015-12-21 Thread Cao jin
Signed-off-by: Cao jin --- hw/pci-host/piix.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 715208b..bc0fc59 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -761,7 +761,7 @@ static c

Re: [Qemu-devel] [PATCH 0/9] Add full scatter-gather support for SCSI generic devices

2015-12-21 Thread Alex Pyrgiotis
Hi Paolo, On 12/17/2015 03:13 PM, Paolo Bonzini wrote: > > > On 17/12/2015 14:10, Alex Pyrgiotis wrote: >> Which commands have large payloads and are on the data path, for >> scsi-block? Or is the use case just scsi-generic (e.g. tape devices?)? >> >> If I understand correctly, what you

Re: [Qemu-devel] [PATCH 35/74] pc: acpi: factor out memhp code from build_ssdt() into separate function

2015-12-21 Thread Igor Mammedov
On Sat, 19 Dec 2015 22:18:14 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:41:29AM +0100, Igor Mammedov wrote: > > before consolidating memhp code in memory_hotplug_acpi_table.c > > and for simplifying review, first factor out memhp code into > > new function build_memory_devices

[Qemu-devel] [PATCH v2 2/2] PXB: convert to realize()

2015-12-21 Thread Cao jin
Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index 57f8a37..a95bb3d 100644 --- a/hw/pci-bridge/pci_exp

Re: [Qemu-devel] [PATCH 45/74] pc: acpi: move HPET from DSDT to SSDT

2015-12-21 Thread Igor Mammedov
On Sat, 19 Dec 2015 21:50:41 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:41:39AM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/acpi-build.c | 53 > > ++ > > hw/i386/acpi-dsdt-hpet.dsl | 48 -

Re: [Qemu-devel] [PATCH 02/12] Added reset-pin emulation in model.

2015-12-21 Thread Peter Crosthwaite
On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 38 +- > 1 file changed, 37 insertions(+), 1 deletion(-) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index bfd493f

[Qemu-devel] [PATCH 3/3] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO

2015-12-21 Thread Miao Yan
VMXNET3_CMD_GET_DEV_EXTRA_INFO should return 0 for emulation mode Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 3517aab..5b96a02 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1659,6 +1659,7 @@

[Qemu-devel] [PATCH 0/3] correct some register return values for vxmnet3

2015-12-21 Thread Miao Yan
Qemu vmxnet3 emulation doesn't recognize VMXNET3_CMD_GET_DID_LO, VMXNET3_CMD_GET_DID_HI and VMXNET3_CMD_GET_DEV_EXTRA_INFO command and returns -1 on all of them. This patchset makes them return correct values. Miao Yan (3): net/vmxnet3: return 1 on device activation failure net/vmxnet3: retu

[Qemu-devel] [PATCH 2/3] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command

2015-12-21 Thread Miao Yan
VMXNET3_CMD_GET_DID_LO should return PCI ID of the device and VMXNET3_CMD_GET_DID_HI should return vmxnet3 revision ID. Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 9185408..3517aab 100644 --- a

[Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

2015-12-21 Thread Miao Yan
When reading device status, 0 means device is successfully activated and 1 means error. So return 1 on device activation failure instead of -1; Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c in

Re: [Qemu-devel] [PATCH 03/12] Reset enable and reset memory commands support.

2015-12-21 Thread Peter Crosthwaite
On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index bcb66a5..5e07b57 100644 > --- a/hw/block/m25p

[Qemu-devel] [PATCH] ivshmem: remove redundant assignment, fix crash with msi=off

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau Fix crash when msi=false introduced in 660c97ee (msi_vectors is NULL in this case) Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 7d14222..dcfc8cc 100644 --- a/hw/m

Re: [Qemu-devel] [PATCH 04/12] Changed variable type to allow serial eeprom emulation (changing 0->1).

2015-12-21 Thread Peter Crosthwaite
Your commit message subject line should be a little shorter and lengthier explanations of the patch content go here as a paragraph. You should also have subsystem prefixes to patch subject lines. This patch would be something like: block: m25p80: widen flags variable Extend the width of the flags

Re: [Qemu-devel] [PATCH 05/12] Added support for serial eeproms - AT25128A/AT25256A

2015-12-21 Thread Peter Crosthwaite
Subsystem prefix needed in commit subject (block: m25p80). Bring the mention of specific parts to the paragraph to shorten the subject. On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 5 + > 1 file changed,

[Qemu-devel] [PATCH 1/8] ivshmem: no need for opaque argument

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index f73f0c2..7d14222 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -350,11 +350,11 @@ static

[Qemu-devel] [PATCH 0/8] ivshmem: test msi=off, remove CharDriver

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau This is a ivshmem series with various bits: - add a test for a recently introduced regression - the fix is included in the series but was sent separatly to cc -stable - fix some test leaks - get rid of CharDriver usage for eventfd - simplify event callback Marc-André Lure

[Qemu-devel] [PATCH 6/8] ivshmem: generalize ivshmem_setup_interrupts

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau Call ivshmem_setup_interrupts() with or without MSI, always allocate msi_vectors that is going to be used in all case in the following patch. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 27 +-- 1 file changed, 17 insertions(+), 10 de

[Qemu-devel] [PATCH 2/8] ivshmem: remove redundant assignment, fix crash with msi=off

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau Fix crash when msi=false introduced in 660c97ee (msi_vectors is NULL in this case) Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 7d14222..dcfc8cc 100644 --- a/hw/m

[Qemu-devel] [PATCH 3/8] ivshmem-test: leak fixes

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/ivshmem-test.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c index 03c7b96..d544d5e 100644 --- a/tests/ivshmem-test.c +++ b/tests/i

[Qemu-devel] [PATCH 4/8] libqos: remove some leaks

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau qpci_device_find() returns allocated data, don't leak it. Signed-off-by: Marc-André Lureau --- tests/libqos/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c index 4e630c2..80b1a21 100644 --- a/tests/libqos/pci.c +++ b/t

[Qemu-devel] [PATCH 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau Simplify the interrupt handling by having a single callback on irq&msi cases. Remove usage of CharDriver, replace it with qemu_set_fd_handler(). Use event_notifier_test_and_clear() to read the eventfd. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 55

[Qemu-devel] [PATCH 5/8] ivshmem-test: test both msi & irq cases

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau Recent commit 660c97ee introduced a regression in irq case, make sure this code path is also tested. Signed-off-by: Marc-André Lureau --- tests/ivshmem-test.c | 53 1 file changed, 37 insertions(+), 16 deletions(-) d

[Qemu-devel] [PATCH 8/8] char: remove qemu_chr_open_eventfd

2015-12-21 Thread marcandre . lureau
From: Marc-André Lureau No longer needed by ivshmem. Signed-off-by: Marc-André Lureau --- include/sysemu/char.h | 3 --- qemu-char.c | 13 - 2 files changed, 16 deletions(-) diff --git a/include/sysemu/char.h b/include/sysemu/char.h index aff193f..d355116 100644 --- a/i

Re: [Qemu-devel] [PATCH 06/12] 4byte address mode support added.

2015-12-21 Thread Peter Crosthwaite
Commit subject subsystem prefix (block: m25p80:) needed. On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 31 --- > 1 file changed, 28 insertions(+), 3 deletions(-) > > diff --git a/h

Re: [Qemu-devel] [PATCH 35/74] pc: acpi: factor out memhp code from build_ssdt() into separate function

2015-12-21 Thread Michael S. Tsirkin
On Mon, Dec 21, 2015 at 12:01:07PM +0100, Igor Mammedov wrote: > > Existing code so can be a separate patch on top. > I can do it on top of series if you don't object. I suggested this too so I won't object :) -- MST

Re: [Qemu-devel] [PATCH 07/12] Added support for extend address mode commands.

2015-12-21 Thread Peter Crosthwaite
Subsystem prefix. On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index 6d5d90d..f0f6

Re: [Qemu-devel] [PATCH 45/74] pc: acpi: move HPET from DSDT to SSDT

2015-12-21 Thread Michael S. Tsirkin
On Mon, Dec 21, 2015 at 12:02:52PM +0100, Igor Mammedov wrote: > > > + > > > +if_ctx = aml_if(aml_lor( > > > > Don't split lines like this please. > What style would you prefer? break after a comma: if_ctx = aml_if(aml_lor(aml_equal(a_period, a_zero), > > > > > +

Re: [Qemu-devel] [Xen-devel] new barrier type for paravirt (was Re: [PATCH] virtio_ring: use smp_store_mb)

2015-12-21 Thread Michael S. Tsirkin
On Mon, Dec 21, 2015 at 10:47:49AM +, David Vrabel wrote: > On 20/12/15 09:25, Michael S. Tsirkin wrote: > > > > I noticed that drivers/xen/xenbus/xenbus_comms.c uses > > full memory barriers to communicate with the other side. > > For example: > > > > /* Must write data /afte

Re: [Qemu-devel] [PATCH 10/12] Support for quad commands.

2015-12-21 Thread Peter Crosthwaite
On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Pawel Lenkow Same comments as for earlier patches. Need to clarify authorship and add subsystem prefix and commit paragraph. > --- > hw/block/m25p80.c | 38 -- > 1 file ch

Re: [Qemu-devel] x-input-send-event marked as experimental

2015-12-21 Thread Marcelo Tosatti
On Fri, Dec 18, 2015 at 09:01:33PM +0100, Markus Armbruster wrote: > Marcelo Tosatti writes: > > > Gerd, > > > > commit df5b2adb7398d71016ee469f71e52075ed95e04e > > Author: Gerd Hoffmann > > Date: Tue Nov 25 14:54:17 2014 +0100 > > > > input: move input-send-event into experimental namespa

Re: [Qemu-devel] [PATCH 12/12] Read flag status register command support added.

2015-12-21 Thread Peter Crosthwaite
Subsystem prefix needed and reverse commit subject to start with verb: "block: m25p80: Add Read Flag Status command" On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski Otherwise: Reviewed-by: Peter Crosthwaite Thanks to you and Pawel for

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-21 Thread Vladimir Sementsov-Ogievskiy
On 15.12.2015 19:40, John Snow wrote: On 12/14/2015 11:18 PM, Fam Zheng wrote: On Mon, 12/14 21:05, Max Reitz wrote: On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing dirty bitmaps. Only dirty bitmaps relative to this qcow2 image should be stored in

Re: [Qemu-devel] Jobs 2.0 QAPI [RFC]

2015-12-21 Thread Kevin Wolf
Am 17.12.2015 um 01:50 hat John Snow geschrieben: > In working through a prototype to enable multiple block jobs. A few > problem spots in our API compatibility become apparent. > > In a nutshell, old Blockjobs rely on the "device" to identify the job, > which implies: > > 1) A job is always atta

Re: [Qemu-devel] [PATCH 50/74] pc: acpi: move FDC0 device from DSDT to SSDT

2015-12-21 Thread Igor Mammedov
On Sat, 19 Dec 2015 21:44:55 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:41:44AM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/acpi-build.c | 38 -- > > hw/i386/acpi-dsdt-isa.dsl | 18

Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

2015-12-21 Thread Igor Mammedov
On Sat, 19 Dec 2015 22:34:55 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:41:48AM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/acpi-build.c | 26 +- > > hw/i386/acpi-dsdt.dsl | 40

Re: [Qemu-devel] [PATCH 50/74] pc: acpi: move FDC0 device from DSDT to SSDT

2015-12-21 Thread Michael S. Tsirkin
On Mon, Dec 21, 2015 at 01:42:39PM +0100, Igor Mammedov wrote: > On Sat, 19 Dec 2015 21:44:55 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Dec 10, 2015 at 12:41:44AM +0100, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > hw/i386/acpi-build.c | 38 ++

Re: [Qemu-devel] [PATCH v2 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-21 Thread Igor Mammedov
On Sat, 19 Dec 2015 21:23:22 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 05:17:07PM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - adapt build_prt() for using for PCI0._PRT(), reduces code duplication, > >Suggested-by: Marcel Apfelbaum >

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-21 Thread Andrey Smetanin
On 12/18/2015 09:39 PM, Roman Kagan wrote: On Fri, Dec 18, 2015 at 10:10:11AM -0800, Peter Hornyack wrote: On Fri, Dec 18, 2015 at 8:01 AM, Paolo Bonzini wrote: On 18/12/2015 16:19, Pavel Fedin wrote: As far as i understand this code, KVM_EXIT_HYPERV is called when one of three MSRs are acc

Re: [Qemu-devel] [PATCH 00/74] pc: acpi: convert DSDT to AML API and drop ASL templates support

2015-12-21 Thread Igor Mammedov
On Sat, 19 Dec 2015 22:38:41 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:40:54AM +0100, Igor Mammedov wrote: > > Due to huge size, CCing only cover letter instead of individual patches. > > > > Series consist of 2 parts the 1st part prefixed 'acpi:' adds necessary > > AML API

Re: [Qemu-devel] [PATCH 00/74] pc: acpi: convert DSDT to AML API and drop ASL templates support

2015-12-21 Thread Shannon Zhao
On 2015/12/21 21:00, Igor Mammedov wrote: > On Sat, 19 Dec 2015 22:38:41 +0200 > "Michael S. Tsirkin" wrote: > >> > On Thu, Dec 10, 2015 at 12:40:54AM +0100, Igor Mammedov wrote: >>> > > Due to huge size, CCing only cover letter instead of individual patches. >>> > > >>> > > Series consist of

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-21 Thread Pavel Fedin
Hello! > Yes, we can use KVM_EXIT_REG_IO/MSR_IO for Hyper-V SynIC MSRS's changes > and can even use only one MSR value . So union inside struct > kvm_hyperv_exit is excessive. > > But we still need Vcpu exit to handle VMBus hypercalls by QEMU to > emulate VMBus devices inside QEMU. > > And cur

[Qemu-devel] ODP: [PATCH 02/12] Added reset-pin emulation in model.

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:04, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 38 +- >> 1 file changed, 37 insertions(+), 1 deletion(-) >> >> di

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-21 Thread Vladimir Sementsov-Ogievskiy
On 14.12.2015 23:45, John Snow wrote: On 12/14/2015 03:05 PM, Max Reitz wrote: On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: The new feature for qcow2: storing dirty bitmaps. Only dirty bitmaps relative to this qcow2 image should be stored in it. Strings started from +# are RFC-st

[Qemu-devel] ODP: [PATCH 03/12] Reset enable and reset memory commands support.

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:18, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 15 +++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/hw/block/m25p80.c b/hw/bloc

[Qemu-devel] ODP: [PATCH 04/12] Changed variable type to allow serial eeprom emulation (changing 0->1).

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:23, Peter Crosthwaite pisze: > Your commit message subject line should be a little shorter and > lengthier explanations of the patch content go here as a paragraph. > You should also have subsystem prefixes to patch subject lines. This > patch would be something like: > > b

[Qemu-devel] ODP: [PATCH 05/12] Added support for serial eeproms - AT25128A/AT25256A

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:28, Peter Crosthwaite pisze: > Subsystem prefix needed in commit subject (block: m25p80). Bring the > mention of specific parts to the paragraph to shorten the subject. I accidentally removed word m25p80 from all patches subject. Sorry. > > > On Wed, Dec 16, 2015 at 4:57 AM

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-21 Thread Andrey Smetanin
On 12/21/2015 04:28 PM, Pavel Fedin wrote: Hello! Yes, we can use KVM_EXIT_REG_IO/MSR_IO for Hyper-V SynIC MSRS's changes and can even use only one MSR value . So union inside struct kvm_hyperv_exit is excessive. But we still need Vcpu exit to handle VMBus hypercalls by QEMU to emulate VM

[Qemu-devel] ODP: [PATCH 07/12] Added support for extend address mode commands.

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:41, Peter Crosthwaite pisze: > Subsystem prefix. > > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 28 >> 1 file changed, 28 insertions(+) >> >> diff

[Qemu-devel] ODP: [PATCH 08/12] Support for N25Q256A/N25Q512A

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 11:29, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c >> i

[Qemu-devel] ODP: [PATCH 06/12] 4byte address mode support added.

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:35, Peter Crosthwaite pisze: > Commit subject subsystem prefix (block: m25p80:) needed. > > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >> hw/block/m25p80.c | 31 --- >> 1

Re: [Qemu-devel] [PATCH 1/1] qga: guest-set-user-password - added ability to create new user

2015-12-21 Thread Eric Blake
On 12/20/2015 11:40 PM, Denis V. Lunev wrote: > From: Yuri Pudgorodskiy > > Added optional 'create' flag to guest-set-user-password command. > When it is specified, a new user will be created if it is not > exists yet. s/is not exists/does not exist/ > > The option to the existing command is a

Re: [Qemu-devel] [PATCH 1/1] qga: guest-set-user-password - added ability to create new user

2015-12-21 Thread Denis V. Lunev
On 12/21/2015 05:00 PM, Eric Blake wrote: On 12/20/2015 11:40 PM, Denis V. Lunev wrote: From: Yuri Pudgorodskiy Added optional 'create' flag to guest-set-user-password command. When it is specified, a new user will be created if it is not exists yet. s/is not exists/does not exist/ The opti

Re: [Qemu-devel] [PATCH v9 0/5] implement vNVDIMM

2015-12-21 Thread Xiao Guangrong
On 12/10/2015 11:11 AM, Xiao Guangrong wrote: New version, new week, and unfortunate new ping... :( Ping again to see what happened...

[Qemu-devel] [Bug 1528214] Re: qemu 1.7.0 vhost_net crash

2015-12-21 Thread wang liming
my envionment is centos6.5 and libvirt version is 1.2.14 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1528214 Title: qemu 1.7.0 vhost_net crash Status in QEMU: New Bug description: i find t

[Qemu-devel] [Bug 1528214] [NEW] qemu 1.7.0 vhost_net crash

2015-12-21 Thread wang liming
Public bug reported: i find the crash in /var/crash the crash content is : <4>Pid: 6949, comm: qemu-system-x86 Not tainted 2.6.32-431.el6.x86_64 #1 Powerleader PR2530G2/SC612DI-8F <4>RIP: 0010:[] [] fput+0x9/0x30 <4>RSP: 0018:88015b601d98 EFLAGS: 00010292 <4>RAX: 0382 RBX: fff

[Qemu-devel] ODP: [PATCH 10/12] Support for quad commands.

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:52, Peter Crosthwaite pisze: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Pawel Lenkow > > Same comments as for earlier patches. Need to clarify authorship and > add subsystem prefix and commit paragraph. > >> --- >> hw/bloc

[Qemu-devel] [Bug 1528239] [NEW] Unable to debug PIE binaries with QEMU gdb stub.

2015-12-21 Thread Maxim Ostapenko
Public bug reported: The issue occurs on current trunk: max@max:~/build/qemu$ cat test.c #include int main() { printf("Hello, world!\n"); return 0; } max@max:~/build/qemu$ gcc test.c -fPIC -pie -o bad.x max@max:~/build/qemu$ ./x86_64-linux-user/qemu-x86_64 -g 1234 bad.x ..

[Qemu-devel] ODP: [PATCH 12/12] Read flag status register command support added.

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 12:54, Peter Crosthwaite pisze: > Subsystem prefix needed and reverse commit subject to start with verb: > > "block: m25p80: Add Read Flag Status command" > > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski > > Othe

[Qemu-devel] ODP: [PATCH 09/12] Support for 6Bytes jdec.

2015-12-21 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
W dniu 21.12.2015 o 11:47, Peter Crosthwaite pisze: > You need to add more notes in commit messages about what you have > changed. Specifically here, you need to say something about the > arrayification of the Jedec ID. You are also correcting terminology by > changing ext_jedec to ext_id which s

Re: [Qemu-devel] [Xen-devel] new barrier type for paravirt (was Re: [PATCH] virtio_ring: use smp_store_mb)

2015-12-21 Thread Stefano Stabellini
On Mon, 21 Dec 2015, David Vrabel wrote: > On 20/12/15 09:25, Michael S. Tsirkin wrote: > > > > I noticed that drivers/xen/xenbus/xenbus_comms.c uses > > full memory barriers to communicate with the other side. > > For example: > > > > /* Must write data /after/ reading the consum

[Qemu-devel] [PATCH] MAINTAINERS: update Xen files

2015-12-21 Thread Stefano Stabellini
Add the PV block backend, the Xen mapcache, and hw/i386/xen to the list of Xen related files maintained by me. Signed-off-by: Stefano Stabellini diff --git a/MAINTAINERS b/MAINTAINERS index 55a0fd8..781e695 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -273,9 +273,12 @@ F: */xen* F: hw/char/xen

[Qemu-devel] [PATCH v2 0/3] Use QCryptoSecret for block device passwords

2015-12-21 Thread Daniel P. Berrange
The RBD, Curl and iSCSI block device drivers all need the ability to accept a password to authenticate with the remote network storage server. Currently RBD and iSCSI both just take the password in clear text as part of the block parameters which is insecure (passwords are visible in the process li

[Qemu-devel] [PATCH v2 1/3] rbd: add support for getting password from QCryptoSecret object

2015-12-21 Thread Daniel P. Berrange
Currently RBD passwords must be provided on the command line via $QEMU -drive file=rbd:pool/image:id=myname:\ key=QVFDVm41aE82SHpGQWhBQXEwTkN2OGp0SmNJY0UrSE9CbE1RMUE=:\ auth_supported=cephx This is insecure because the key is visible in the OS process listing. Thi

[Qemu-devel] [PATCH v2 2/3] curl: add support for HTTP authentication parameters

2015-12-21 Thread Daniel P. Berrange
If connecting to a web server which has authentication turned on, QEMU gets a 401 as curl has not been configured with any authentication credentials. This adds 4 new parameters to the curl block driver options, username, passwordid, proxyusername and proxypasswordid. Passwords are provided using

Re: [Qemu-devel] [PATCH 5/5] xen-pvdevice: convert to realize()

2015-12-21 Thread Stefano Stabellini
On Mon, 21 Dec 2015, Cao jin wrote: > On 12/19/2015 02:00 AM, Paolo Bonzini wrote: > > CCing Stefano, who is the maintainer. > > > > "Stefano" isn`t in the list when I use scripts/get_maintainer.pl... Thanks Cao. I have just sent a patch to update the MAINTAINERS file. http://marc.info/?l=qemu-

[Qemu-devel] [PATCH v2 3/3] iscsi: add support for getting CHAP password via QCryptoSecret API

2015-12-21 Thread Daniel P. Berrange
The iSCSI driver currently accepts the CHAP password in plain text as a block driver property. This change adds a new "passwordid" property that accepts the ID of a QCryptoSecret instance. $QEMU \ -object secret,id=sec0,filename=/home/berrange/example.pw \ -drive driver=iscsi,url=iscsi

Re: [Qemu-devel] [PATCH v3 2/4] target-tilegx: Add single floating point implementation

2015-12-21 Thread Richard Henderson
On 12/20/2015 07:30 AM, Chen Gang wrote: > And we have to still check TILEGX_F_CALC_CVT, for they are really two > different format: TILEGX_F_CALC_CVT has no HBIT, but TILEGX_F_CALC_NCVT > has HBIT (which we need process it specially). The both do, in that you re-normalize to produce that HBIT. Th

Re: [Qemu-devel] [PATCH v3 0/5] linux-user: manage SOCK_PACKET socket type

2015-12-21 Thread Riku Voipio
On Fri, Dec 18, 2015 at 04:13:20PM +0100, Laurent Vivier wrote: > Le 29/10/2015 00:12, Peter Maydell a écrit : > > On 28 October 2015 at 20:40, Laurent Vivier wrote: > >> This is obsolete, but if we want to use dhcp with some distros (like debian > >> ppc 8.2 jessie), we need it. > >> > >> bind()

Re: [Qemu-devel] [PATCH 5/5] xen-pvdevice: convert to realize()

2015-12-21 Thread Stefano Stabellini
On Fri, 18 Dec 2015, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/i386/xen/xen_pvdevice.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c > index c218947..a6c93d0 100644 > --- a/hw/i386/xen/xen_pv

[Qemu-devel] [PATCH] qmp: return err msg when powerdown a vm when it isn't in running state

2015-12-21 Thread Qinghua Jin
When send system_powerdown to QMP when the vm isn't in RUN_STATE_RUNNING, it will be ignored by system. So reply a err msg with the situation. Signed-off-by: Qinghua Jin --- qmp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qmp.c b/qmp.c index 0a1fa19..8e43435 100644

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

2015-12-21 Thread Pavel Fedin
Hello! > > It depends. Can i read about these hypercalls somewhere? Is there any > > documentation? > I don't know about a documentation, but you can look at the code of > Hyper-V hypercall handling inside KVM: > > https://github.com/torvalds/linux/blob/master/arch/x86/kvm/hyperv.c#L346 Aha

[Qemu-devel] [PATCH v5 RFC] spec: add qcow2 bitmaps extension specification

2015-12-21 Thread Vladimir Sementsov-Ogievskiy
The new feature for qcow2: storing bitmaps. Only bitmaps, relative to the virtual disk, stored in qcow2 file, should be stored in this qcow2 file. Strings started from +# are RFC-strings, not to be commited of course Signed-off-by: Vladimir Sementsov-Ogievskiy --- v5: - 'Dirty bitmaps' renam

Re: [Qemu-devel] [PATCH] scsi: initialise info object with appropriate size

2015-12-21 Thread Paolo Bonzini
On 21/12/2015 10:43, P J P wrote: > Hello, > > A stack overflow issue was reported by Mr Qinghao Tang, CC'd here. It > occurs while processing the SCSI controller's CTRL_GET_INFO command, as > the memset(2) call uses driver supplied 'cmd->iov_size' to initialise > the '&info' object. > > Plea

Re: [Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode

2015-12-21 Thread Eric Blake
On 12/19/2015 02:24 PM, Samuel Thibault wrote: > Hello, meta-reply > > This is another respin of IPv6 in Qemu -net user mode. > > The following patches first make some refactoring to make current code ready > for IPv6, and do not change the behavior. The actual IPv6 support will then > be > s

Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

2015-12-21 Thread Igor Mammedov
On Sat, 19 Dec 2015 22:34:55 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:41:48AM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/acpi-build.c | 26 +- > > hw/i386/acpi-dsdt.dsl | 40

[Qemu-devel] [PATCH v2 3/4] char: don't assume telnet initialization will not block

2015-12-21 Thread Daniel P. Berrange
The current code for doing telnet initialization is writing to a socket without checking the return status. While it is highly unlikely to be a problem when writing to a bare socket, as the buffers are large enough to prevent blocking, this cannot be assumed safe with TLS sockets. So write the teln

[Qemu-devel] [PATCH v2 0/4] Convert chardevs to QIOChannel & add TLS support

2015-12-21 Thread Daniel P. Berrange
This is an update of patches previously shown in an RFC posting RFC: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00829.html v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04222.html This short series converts the chardev backends to use the new QIOChannel framework

[Qemu-devel] [PATCH v2 2/4] char: convert from GIOChannel to QIOChannel

2015-12-21 Thread Daniel P. Berrange
In preparation for introducing TLS support to the TCP chardev backend, convert existing chardev code from using GIOChannel to QIOChannel. This simplifies the chardev code by removing most of the OS platform conditional code for dealing with file descriptor passing. Signed-off-by: Daniel P. Berrang

[Qemu-devel] [PATCH v2 1/4] char: remove fixed length filename allocation

2015-12-21 Thread Daniel P. Berrange
A variety of places were snprintf()ing into a fixed length filename buffer. Some of the buffers were stack allocated, while another was heap allocated with g_malloc(). Switch them all to heap allocated using g_strdup_printf() avoiding arbitrary length restrictions. This also facilitates later patc

[Qemu-devel] [PATCH v2 4/4] char: introduce support for TLS encrypted TCP chardev backend

2015-12-21 Thread Daniel P. Berrange
This integrates support for QIOChannelTLS object in the TCP chardev backend. If the 'tls-creds=NAME' option is passed with the '-chardev tcp' argument, then it will setup the chardev such that the client is required to establish a TLS handshake when connecting. There is no support for checking the

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

2015-12-21 Thread Paolo Bonzini
On 20/12/2015 12:38, Cao jin wrote: >>> >>> +object_unref(OBJECT(ds)); >>> +object_unref(OBJECT(bds)); >>> +object_unref(OBJECT(bus)); >> >> I think these should be object_unparent, not unref. >> > > But, it seems these 3 objects isn`t added as a child-property via > object_property_

[Qemu-devel] [PATCH] crypto: Fix typo in example

2015-12-21 Thread Eric Blake
The example code wouldn't even compile, since it did not use a consistent spelling for the Error ** parameter. Signed-off-by: Eric Blake --- include/crypto/tlssession.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/crypto/tlssession.h b/include/crypto/tlssession.h i

Re: [Qemu-devel] [PATCH v2 1/3] rbd: add support for getting password from QCryptoSecret object

2015-12-21 Thread Josh Durgin
On 12/21/2015 06:59 AM, Daniel P. Berrange wrote: Currently RBD passwords must be provided on the command line via $QEMU -drive file=rbd:pool/image:id=myname:\ key=QVFDVm41aE82SHpGQWhBQXEwTkN2OGp0SmNJY0UrSE9CbE1RMUE=:\ auth_supported=cephx This is insecure bec

Re: [Qemu-devel] [PATCH v2 3/3] iscsi: add support for getting CHAP password via QCryptoSecret API

2015-12-21 Thread Paolo Bonzini
On 21/12/2015 15:59, Daniel P. Berrange wrote: > The iSCSI driver currently accepts the CHAP password in plain text > as a block driver property. This change adds a new "passwordid" > property that accepts the ID of a QCryptoSecret instance. > > $QEMU \ > -object secret,id=sec0,filename=/

Re: [Qemu-devel] [PATCH v2 3/4] char: don't assume telnet initialization will not block

2015-12-21 Thread Paolo Bonzini
On 21/12/2015 16:42, Daniel P. Berrange wrote: > +ret = qio_channel_write(ioc, init->buf, init->buflen, NULL); > +if (ret < 0) { > +if (ret == QIO_CHANNEL_ERR_BLOCK) { > +ret = 0; > +} else { > +tcp_chr_disconnect(init->chr); > +return F

Re: [Qemu-devel] [PATCH v2 4/4] char: introduce support for TLS encrypted TCP chardev backend

2015-12-21 Thread Paolo Bonzini
On 21/12/2015 16:42, Daniel P. Berrange wrote: > This integrates support for QIOChannelTLS object in the TCP > chardev backend. If the 'tls-creds=NAME' option is passed with > the '-chardev tcp' argument, then it will setup the chardev > such that the client is required to establish a TLS handsha

[Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens

2015-12-21 Thread Daniel P. Berrange
Adds new methods to allow querying the length of the cipher key, block size and initialization vectors. Signed-off-by: Daniel P. Berrange --- crypto/cipher.c| 48 ++ include/crypto/cipher.h| 37 +++ tests

[Qemu-devel] [PATCH 2/6] crypto: add ability to query hash digest len

2015-12-21 Thread Daniel P. Berrange
Add a qcrypto_hash_digest_len() method which allows querying of the raw digest size for a given hash algorithm. Signed-off-by: Daniel P. Berrange --- crypto/hash.c| 15 +++ include/crypto/hash.h| 11 +++ tests/test-crypto-hash.c | 5 + 3 files changed, 31

  1   2   3   >