[Qemu-devel] [PATCH] tcg/arm: improve direct jump

2015-12-10 Thread Aurelien Jarno
Use ldr pc, [pc, #-4] kind of branch for direct jump. This removes the need to flush the icache on TB linking, and allow to remove the limit on the code generation buffer. Cc: Richard Henderson Cc: TeLeMan Cc: Andrzej Zaborowski Signed-off-by: Aurelien Jarno --- include/exec/exec-all.h | 24 +

Re: [Qemu-devel] [PATCH RFC 0/8] scsi-disk: Active/passive ALUA support

2015-12-10 Thread Stefan Hajnoczi
On Fri, Nov 27, 2015 at 03:58:58PM +0100, Hannes Reinecke wrote: > here's now an updated version to enable ALUA and simplified > active/passive multipath support for qemu. > > This patchset relies on having _two_ block devices configured, > and two SCSI disks pointing to those block devices with t

Re: [Qemu-devel] Question about nonblocking stderr and lost logs

2015-12-10 Thread Stefan Hajnoczi
On Mon, Dec 07, 2015 at 02:22:18PM +1100, Sam Bobroff wrote: > On Fri, Dec 04, 2015 at 02:33:01PM +0800, Stefan Hajnoczi wrote: > > On Mon, Nov 30, 2015 at 04:34:47PM +1100, Sam Bobroff wrote: > > > Hi QEMU programmers, > > > > > > While doing some experimental work on QEMU that has involved addin

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Michael S. Tsirkin
On Thu, Dec 10, 2015 at 11:04:54AM +0800, Lan, Tianyu wrote: > > On 12/10/2015 4:07 AM, Michael S. Tsirkin wrote: > >On Thu, Dec 10, 2015 at 12:26:25AM +0800, Lan, Tianyu wrote: > >>On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote: > >>>I thought about what this is doing at the high level, and I do

Re: [Qemu-devel] qemu 2.2 stuck on condition mutex locks on all threads

2015-12-10 Thread Stefan Hajnoczi
On Mon, Dec 07, 2015 at 07:44:24PM -0500, Neil McGill wrote: > Has anyone seen anything like this ? all 4 qemu threads are stuck on a > pthread condition This is incorrect. Thread 4 is blocked in poll(2). > QEMU emulator version 2.2.0 (Debian 1:2.2+dfsg-5expubuntu9.3~cloud0), > Copyright (c) 20

Re: [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 03:59, Zhu Lingshan wrote: > -if (task == NULL || task->status != SCSI_STATUS_GOOD) { > +if ((rc16 != NULL) && ((task == NULL) || (task->status != > SCSI_STATUS_GOOD))) { > +error_setg(errp, "iSCSI: failed to send readcapacity16 command."); > +} You need an "el

Re: [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent

2015-12-10 Thread Peter Lieven
Am 10.12.2015 um 09:55 schrieb Paolo Bonzini: On 10/12/2015 03:59, Zhu Lingshan wrote: -if (task == NULL || task->status != SCSI_STATUS_GOOD) { +if ((rc16 != NULL) && ((task == NULL) || (task->status != SCSI_STATUS_GOOD))) { +error_setg(errp, "iSCSI: failed to send readcapacity

Re: [Qemu-devel] HTTP access to QEMU Git repositories

2015-12-10 Thread Stefan Hajnoczi
On Wed, Dec 09, 2015 at 06:22:35PM +0100, Paolo Bonzini wrote: > On 09/12/2015 18:14, Liguori, Anthony wrote: > > Alex Bennee and Andreas also should have access as owners. I've just > > sent an invite to add Paolo as an owner too. > > Great, I've created github repos for all of: > > git:/

Re: [Qemu-devel] what is the plan for seabios merged into qemu?

2015-12-10 Thread Gerd Hoffmann
On Do, 2015-12-10 at 05:52 +, Han, Huaitong wrote: > Hi, Gerd > > I find pc-bios/bios-256k.bin has not been updated for a long time, even > seabios is released a new version, what is the plan for seabios merged > into qemu? The new seabios version missed -rc0 (hard freeze) by a few days, so I

Re: [Qemu-devel] [v3 1/3] cutils: add avx2 instruction optimization

2015-12-10 Thread Paolo Bonzini
On 09/12/2015 15:57, Richard Henderson wrote: >> I think you means the ' __attribute__((target("avx2")))', I have tried >> this way, the issue here is: >> without the ' -mavx2' option for gcc, there are compiling error: >> '__m256i undeclared', the __attribute__((target("avx2"))) >> can't solv

Re: [Qemu-devel] [PATCH RFC 0/8] scsi-disk: Active/passive ALUA support

2015-12-10 Thread Hannes Reinecke
On 12/10/2015 09:26 AM, Stefan Hajnoczi wrote: On Fri, Nov 27, 2015 at 03:58:58PM +0100, Hannes Reinecke wrote: here's now an updated version to enable ALUA and simplified active/passive multipath support for qemu. This patchset relies on having _two_ block devices configured, and two SCSI disk

Re: [Qemu-devel] [v3 1/3] cutils: add avx2 instruction optimization

2015-12-10 Thread Li, Liang Z
> >> without the ' -mavx2' option for gcc, there are compiling error: > >> '__m256i undeclared', the __attribute__((target("avx2"))) can't solve > >> this issue. Any idea? > > > > You're right that you can't use the normal __m256i, as it doesn't get > > declared. > > It should be declared. *in

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Markus Armbruster
Laszlo Ersek writes: > I've been following this discussion with great interest. > > My opinion should not be considered, because I won't be turning my > opinion into new code, or an agreement to support / maintain code. :) > > My opinion is that > - every single allocation needs to be checked rig

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> In general, code running withing a realize() method should not exit() on >> >> error. Instad, errors should be prop

Re: [Qemu-devel] subpage_write() and duplicated memory_region_ops_write tracepoints

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 01:39, Hollis Blanchard wrote: > > Not sure I understand. Do you mean something like this? > -trace_memory_region_ops_write(mr, addr, tmp, size); > +trace_memory_region_ops_write(mr, addr, mr->ops->write == > subpage_write, tmp, size); There is also a mr->subpage that you can use.

Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-10 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2015 at 3:51 AM, Eric Blake wrote: > On 12/09/2015 05:53 PM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) > > NACK. 'type' is POSIX, and shellcheck is buggy. > > http://pubs.opengrou

Re: [Qemu-devel] [v3 1/3] cutils: add avx2 instruction optimization

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 10:22, Li, Liang Z wrote: without the ' -mavx2' option for gcc, there are compiling error: '__m256i undeclared', the __attribute__((target("avx2"))) can't solve this issue. Any idea? >>> >>> You're right that you can't use the normal __m256i, as it doesn't get >>>

[Qemu-devel] [PATCH 1/1] qcow2: insert assert into qcow2_get_specific_info()

2015-12-10 Thread Denis V. Lunev
s->qcow_version is always set to 2 or 3. Let's assert if this is wrong. Signed-off-by: Denis V. Lunev CC: Roman Kagan CC: Max Reitz CC: Kevin Wolf --- block/qcow2.c | 4 1 file changed, 4 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 88f56c8..b285014 100644 --- a/block/

[Qemu-devel] [PATCH] vfio/common: Check iova with limit not with size

2015-12-10 Thread Pierre Morel
In vfio_listener_region_add(), the code makes sure that the offset in the section is lower than the size of the section. To do this the calculation uses size of the region instead of the region limit (size - 1). This leads to Int128 overflow when the region has been initialized with UINT64_MAX. L

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Dr. David Alan Gilbert
* Lan, Tianyu (tianyu@intel.com) wrote: > On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote: > >I thought about what this is doing at the high level, and I do have some > >value in what you are trying to do, but I also think we need to clarify > >the motivation a bit more. What you are saying is

[Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Done with this admittedly crude Coccinelle semantic patch with manual burial of dead Error * variables squashed in: @@ identifier FUN; expression ERR, EC; @@ -FUN(&ERR); -if (ERR != NULL) { -error_report_err(ERR); -exit(EC); -} +

Re: [Qemu-devel] [RFC PATCH v0 1/9] vl: Don't allow CPU toplogies with partially filled cores

2015-12-10 Thread Daniel P. Berrange
On Thu, Dec 10, 2015 at 11:45:36AM +0530, Bharata B Rao wrote: > Prevent guests from booting with CPU topologies that have partially > filled CPU cores or can result in partially filled CPU cores after CPU > hotplug like > > -smp 15,sockets=1,cores=4,threads=4,maxcpus=16 or > -smp 15,sockets=1,cor

[Qemu-devel] [PATCH 08/12] isa: Trivially convert remaining PCI-ISA bridges to realize()

2015-12-10 Thread Markus Armbruster
These are "ICH9-LPC" and "ebus". Cc: "Michael S. Tsirkin" Cc: Mark Cave-Ayland Signed-off-by: Markus Armbruster --- hw/isa/lpc_ich9.c | 5 ++--- hw/sparc64/sun4u.c | 6 ++ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 1ffc803..8

[Qemu-devel] [PATCH 04/12] etraxfs_eth: Don't use hw_error() in init() method

2015-12-10 Thread Markus Armbruster
Device init() methods aren't supposed to call hw_error(), they should report the error and fail cleanly. Do that. Cc: "Edgar E. Iglesias" Signed-off-by: Markus Armbruster --- hw/net/etraxfs_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/net/etraxfs_eth.c b/hw/n

[Qemu-devel] [PATCH 06/12] hw/arm/virt: Fix property "gic-version" error handling

2015-12-10 Thread Markus Armbruster
virt_set_gic_version() calls exit(1) when passed an invalid property value. Property setters are not supposed to do that. Screwed up in commit b92ad39. Harmless, because the property belongs to a machine. Set an error object instead. Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Mar

[Qemu-devel] [PATCH 05/12] raven: Mark use of hw_error() in realize() FIXME

2015-12-10 Thread Markus Armbruster
Device realize() methods aren't supposed to call hw_error(), they should set an error and fail cleanly. Blindly doing that would be easy enough, but then realize() would fail without undoing its side effects. Just mark it FIXME for now. Cc: "Andreas Färber" Cc: qemu-...@nongnu.org Signed-off-by

[Qemu-devel] [PATCH 00/12] Clean up some hw_error() misuse

2015-12-10 Thread Markus Armbruster
I intend to take this trough my tree, but I'm certainly fine with maintainers picking up their parts if that makes their job easier. Just be clear about it. Markus Armbruster (12): hw: Don't use hw_error() for machine initialization errors omap: Don't use hw_error() in device init() methods

[Qemu-devel] [PATCH 09/12] isa: Clean up error handling around isa_bus_new()

2015-12-10 Thread Markus Armbruster
We can have at most one ISA bus. If you try to create another one, isa_bus_new() complains to stderr and returns null. isa_bus_new() is called in two contexts, machine's init() and device's realize() methods. Since complaining to stderr is not proper in the latter context, convert isa_bus_new()

[Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Markus Armbruster
isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when passed a null bus. Use of hw_error() has always been questionable, because these are used only during machine initialization, and printing CPU registers isn't useful there. Since the previous commit, passing a null bus is a pr

[Qemu-devel] [PATCH 02/12] omap: Don't use hw_error() in device init() methods

2015-12-10 Thread Markus Armbruster
Device init() methods aren't supposed to call hw_error(), they should report the error and fail cleanly. Do that. Cc: Peter Maydell Signed-off-by: Markus Armbruster --- hw/gpio/omap_gpio.c | 19 +++ hw/i2c/omap_i2c.c | 8 ++-- hw/intc/omap_intc.c | 10 +++--- 3 files

[Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in realize() method

2015-12-10 Thread Markus Armbruster
Device realize() methods aren't supposed to call hw_error(), they should set an error and fail cleanly. Do that. Cc: Peter Maydell Cc: qemu-...@nongnu.org Signed-off-by: Markus Armbruster --- hw/timer/arm_mptimer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/tim

[Qemu-devel] [PATCH 11/12] audio: Clean up inappropriate and unreachable use of hw_error()

2015-12-10 Thread Markus Armbruster
audio_init() should not use hw_error(), because dumping CPU registers is unhelpful there, and aborting is wrong, because it can be called called from an audio device's realize() method. The two uses of hw_error() come from commit 0d9acba: * When qemu_new_timer() fails. It couldn't fail back then

[Qemu-devel] [PATCH 12/12] xen-hvm: Mark inappropriate error handling FIXME

2015-12-10 Thread Markus Armbruster
Cc: Stefano Stabellini Cc: xen-de...@lists.xensource.com Signed-off-by: Markus Armbruster --- xen-hvm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/xen-hvm.c b/xen-hvm.c index 3d78a0c..2a93390 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -240,6 +240,7 @@ static void xen_ram_init(PCMa

[Qemu-devel] [PATCH 07/12] sysbus: Don't use hw_error() in machine_init_done_notifiers

2015-12-10 Thread Markus Armbruster
platform_bus_map_irq() and platform_bus_map_mmio() use hw_error() to fail. They run in machine_init_done_notifiers, via platform_bus_init_notify() and link_sysbus_device(). Printing CPU registers is not helpful there. Replace hw_error() by error_report(); exit(1). If these are programming error

[Qemu-devel] [PATCH 01/12] hw: Don't use hw_error() for machine initialization errors

2015-12-10 Thread Markus Armbruster
Printing CPU registers is not helpful during machine initialization. Moreover, these are straightforward configuration or "can get resources" errors, so dumping core isn't appropriate either. Replace hw_error() by error_report(); exit(1). Matches how we report these errors in other machine initia

Re: [Qemu-devel] [PATCH 04/12] etraxfs_eth: Don't use hw_error() in init() method

2015-12-10 Thread Edgar E. Iglesias
On Thu, Dec 10, 2015 at 11:29:24AM +0100, Markus Armbruster wrote: > Device init() methods aren't supposed to call hw_error(), they should > report the error and fail cleanly. Do that. > > Cc: "Edgar E. Iglesias" > Signed-off-by: Markus Armbruster Reviewed-by: Edgar E. Iglesias > --- > hw/

Re: [Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in realize() method

2015-12-10 Thread Peter Maydell
On 10 December 2015 at 10:29, Markus Armbruster wrote: > Device realize() methods aren't supposed to call hw_error(), they > should set an error and fail cleanly. Do that. > > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster > --- > hw/timer/arm_mptimer.c | 5 +++-

Re: [Qemu-devel] [PATCH 02/12] omap: Don't use hw_error() in device init() methods

2015-12-10 Thread Peter Maydell
On 10 December 2015 at 10:29, Markus Armbruster wrote: > Device init() methods aren't supposed to call hw_error(), they should > report the error and fail cleanly. Do that. > > Cc: Peter Maydell > Signed-off-by: Markus Armbruster These are all really "QEMU bug" error paths -- the only place th

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/12] hw: Don't use hw_error() for machine initialization errors

2015-12-10 Thread Peter Maydell
On 10 December 2015 at 10:29, Markus Armbruster wrote: > Printing CPU registers is not helpful during machine initialization. > Moreover, these are straightforward configuration or "can get > resources" errors, so dumping core isn't appropriate either. Replace > hw_error() by error_report(); exit

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 11:19, Markus Armbruster wrote: > +object_property_set_int(OBJECT(cpu), ZYNQ_BOARD_MIDR, "midr", > + > &error_fatal);object_property_set_int(OBJECT(cpu), > + > MPCORE_PERIPHBASE, > +

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/12/2015 10:30, Markus Armbruster wrote: >> My current working assumption is that passing &error_fatal to >> memory_region_init_ram() & friends is okay even in realize() methods and >> their supporting code, except when the allocation can be large. > > I suspect a lot

Re: [Qemu-devel] [PATCH 07/74] acpi: aml: add helper for Opcode Arg2 Arg2 [Dst] AML pattern

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 09:59:16 +0800 Shannon Zhao wrote: > > > On 2015/12/10 7:41, Igor Mammedov wrote: > > Currently AML API doesn't compose terms in form of > > following pattern: > > > >Opcode Arg2 Arg2 [Dst] > > > > but ASL used in piix4/q35 DSDT ACPI tables uses that > > form, so for c

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Laszlo Ersek
On 12/10/15 10:22, Markus Armbruster wrote: > Laszlo Ersek writes: > >> I've been following this discussion with great interest. >> >> My opinion should not be considered, because I won't be turning my >> opinion into new code, or an agreement to support / maintain code. :) >> >> My opinion is th

Re: [Qemu-devel] [PATCH 23/74] acpi: extend aml_and() to accept target argument

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 10:07:43 +0800 Shannon Zhao wrote: > > > On 2015/12/10 7:41, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/aml-build.c | 4 ++-- > > hw/arm/virt-acpi-build.c| 2 +- > > hw/i386/acpi-build.c| 8 +--- > > include/hw/acpi/am

Re: [Qemu-devel] [PATCH for-2.5] virtio-9p-device: add minimal unrealize handler

2015-12-10 Thread Peter Maydell
On 8 December 2015 at 16:19, Michael S. Tsirkin wrote: > On Tue, Dec 08, 2015 at 04:54:57PM +0100, Greg Kurz wrote: >> Since commit 4652f1640e029e1f2433fa77ba6af285 "virtio-9p: add savevm >> handlers", >> if the user hot-unplugs a quiescent 9p device and live migrates, the source >> QEMU crashes

Re: [Qemu-devel] [PATCH] MAINTAINERS: add maintainer to virtio-9p

2015-12-10 Thread Peter Maydell
On 1 December 2015 at 10:50, Aneesh Kumar K.V wrote: > Greg Kurz writes: > >> As suggested by Paolo, I add myself as maintainer for virtio-9p. >> >> Signed-off-by: Greg Kurz > > Acked-by: Aneesh Kumar K.V > >> --- >> MAINTAINERS |1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MA

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Paolo Bonzini writes: > > > On 09/12/2015 10:30, Markus Armbruster wrote: > >> My current working assumption is that passing &error_fatal to > >> memory_region_init_ram() & friends is okay even in realize() methods and > >> their supporting code, e

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 12:21, Dr. David Alan Gilbert wrote: > I guess the use of abort() could tell us > that - however it's a really big assumption that in an OOM case we'd > be able to dump the information. If it's not OOM, but just a multi-gigabyte allocation, we should. Paolo

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Paolo Bonzini
On 10/12/2015 12:06, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 09/12/2015 10:30, Markus Armbruster wrote: >>> My current working assumption is that passing &error_fatal to >>> memory_region_init_ram() & friends is okay even in realize() methods and >>> their supporting code, exce

Re: [Qemu-devel] [PATCH 00/16] pc: Eliminate struct PcGuestInfo

2015-12-10 Thread Marcel Apfelbaum
On 12/08/2015 07:53 PM, Eduardo Habkost wrote: On Mon, Dec 07, 2015 at 08:57:03PM +0200, Marcel Apfelbaum wrote: On 12/02/2015 03:46 AM, Eduardo Habkost wrote: This moves all data from PcGuestInfo to either PCMachineState or PCMachineClass. This series depends on other two series: * [PATCH v3

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 12:19 PM, Markus Armbruster wrote: Done with this admittedly crude Coccinelle semantic patch with manual burial of dead Error * variables squashed in: @@ identifier FUN; expression ERR, EC; @@ -FUN(&ERR); -if (ERR != NULL) { -error

Re: [Qemu-devel] [PATCH 08/12] isa: Trivially convert remaining PCI-ISA bridges to realize()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 12:29 PM, Markus Armbruster wrote: These are "ICH9-LPC" and "ebus". Cc: "Michael S. Tsirkin" Cc: Mark Cave-Ayland Signed-off-by: Markus Armbruster --- hw/isa/lpc_ich9.c | 5 ++--- hw/sparc64/sun4u.c | 6 ++ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH for-2.5] virtio-9p-device: add minimal unrealize handler

2015-12-10 Thread Greg Kurz
On Thu, 10 Dec 2015 11:17:09 + Peter Maydell wrote: > On 8 December 2015 at 16:19, Michael S. Tsirkin wrote: > > On Tue, Dec 08, 2015 at 04:54:57PM +0100, Greg Kurz wrote: > >> Since commit 4652f1640e029e1f2433fa77ba6af285 "virtio-9p: add savevm > >> handlers", > >> if the user hot-unplugs

[Qemu-devel] [PATCH v2 24/74] acpi: extend aml_interrupt() to support multiple irqs

2015-12-10 Thread Igor Mammedov
ASL Interrupt() macro translates to Extended Interrupt Descriptor which supports variable number of IRQs. It will be used for conversion of ASL code for pc/q35 machines that use it for returning several IRQs in _PSR object. Signed-off-by: Igor Mammedov --- v2: - fix incorrect irq number calculat

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-10 Thread Dr. David Alan Gilbert
* Yang Zhang (yang.zhang...@gmail.com) wrote: > On 2015/12/10 18:18, Dr. David Alan Gilbert wrote: > >* Lan, Tianyu (tianyu@intel.com) wrote: > >>On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote: > >>>I thought about what this is doing at the high level, and I do have some > >>>value in what you

Re: [Qemu-devel] [PATCH for-2.5] sparc: allow CASA with ASI 0xa from user space

2015-12-10 Thread Peter Maydell
On 9 December 2015 at 23:24, Mark Cave-Ayland wrote: > On 08/12/15 21:28, Peter Maydell wrote: > >> On 8 December 2015 at 19:59, Richard Henderson wrote: >>> On 12/04/2015 07:01 AM, Alex Zuepke wrote: LEON3 allows the CASA instruction to be used from user space if the ASI is set to 0xa

Re: [Qemu-devel] [PATCH 09/12] isa: Clean up error handling around isa_bus_new()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 12:29 PM, Markus Armbruster wrote: We can have at most one ISA bus. If you try to create another one, isa_bus_new() complains to stderr and returns null. isa_bus_new() is called in two contexts, machine's init() and device's realize() methods. Since complaining to stderr is not p

Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 12:29 PM, Markus Armbruster wrote: isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when passed a null bus. Use of hw_error() has always been questionable, because these are used only during machine initialization, and printing CPU registers isn't useful there. Si

Re: [Qemu-devel] Error handling in realize() methods

2015-12-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/12/2015 12:06, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 09/12/2015 10:30, Markus Armbruster wrote: My current working assumption is that passing &error_fatal to memory_region_init_ram() & friends is okay even in realize() methods and >>

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/12/2015 11:19, Markus Armbruster wrote: >> +object_property_set_int(OBJECT(cpu), ZYNQ_BOARD_MIDR, "midr", >> + &error_fatal);object_property_set_int(OBJECT(cpu), >> + MPCORE_PERIPHBASE, >> + "reset-cbar", >> + &error_fatal);object_property_set_bool(OBJECT(cpu), >

Re: [Qemu-devel] [PATCH 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 83 +++ hw/i386/acpi-dsdt.dsl | 60 - 2 files changed, 83 insertions(+), 60 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 12/10/2015 12:19 PM, Markus Armbruster wrote: >> Done with this admittedly crude Coccinelle semantic patch with manual >> burial of dead Error * variables squashed in: >> >> @@ >> identifier FUN; >> expression ERR, EC; >> @@ >> -FUN(&ERR)

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 11:45:35 +0530 Bharata B Rao wrote: > Hi, > > This is an attempt to define a generic CPU device that serves as a > containing device to underlying arch-specific CPU devices. The > motivation for this is to have an arch-neutral way to specify CPUs > mainly during hotplug. > >

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-10 Thread Dr. David Alan Gilbert
* Grundmann, Christian (christian.grundm...@fabasoft.com) wrote: > Hi, > > qemu-img-ev-2.3.0-29.1.el7.x86_64 > libvirt-daemon-driver-qemu-1.2.8-16.el7_1.4.x86_64 > qemu-kvm-ev-2.3.0-29.1.el7.x86_64 > qemu-kvm-common-ev-2.3.0-29.1.el7.x86_64 > ipxe-roms-qemu-20130517-7.gitc4bce43.el7.noarch > qemu-

Re: [Qemu-devel] qemu 2.2 stuck on condition mutex locks on all threads

2015-12-10 Thread Neil McGill
Thanks Stefan, will check and update neil On 12/10/15, 3:47 AM, Stefan Hajnoczi wrote: On Mon, Dec 07, 2015 at 07:44:24PM -0500, Neil McGill wrote: Has anyone seen anything like this ? all 4 qemu threads are stuck on a pthread condition This is incorrect. Thread 4 is blocked in poll(2). Q

Re: [Qemu-devel] [PATCH 02/12] omap: Don't use hw_error() in device init() methods

2015-12-10 Thread Markus Armbruster
Peter Maydell writes: > On 10 December 2015 at 10:29, Markus Armbruster wrote: >> Device init() methods aren't supposed to call hw_error(), they should >> report the error and fail cleanly. Do that. >> >> Cc: Peter Maydell >> Signed-off-by: Markus Armbruster > > These are all really "QEMU bug

Re: [Qemu-devel] [PATCH 25/74] pc: acpi: memhp: prepare context in SSDT for moving memhp DSDT code

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/Makefile.objs | 2 +- hw/acpi/memory_hotplug_acpi_table.c | 40 + hw/i386/acpi-build.c| 3 +++ include/hw/acpi/memory_hotplug.h| 4 +

Re: [Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in realize() method

2015-12-10 Thread Markus Armbruster
Peter Maydell writes: > On 10 December 2015 at 10:29, Markus Armbruster wrote: >> Device realize() methods aren't supposed to call hw_error(), they >> should set an error and fail cleanly. Do that. >> >> Cc: Peter Maydell >> Cc: qemu-...@nongnu.org >> Signed-off-by: Markus Armbruster >> --- >

Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:40 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 6d37332..50678b5 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-t

[Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Tim Sander
Hi Jan I have seen your patches for AT24Cxx functionality in qemu: https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg05714.html As i am interested in this work i am wondering what happend to this effort? Best regards Tim

Re: [Qemu-devel] [PATCH 04/74] acpi: add aml_lgreater_equal()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:40 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index dc59c08..c1a30a3 100644 --- a/hw/acp

Re: [Qemu-devel] [PATCH 06/74] acpi: add aml_create_qword_field()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 21 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index bb2c9f7..a

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-10 Thread Victor Kaplansky
On Wed, Dec 09, 2015 at 06:06:06PM +0100, Didier Pallard wrote: > On 12/09/2015 04:59 PM, Victor Kaplansky wrote: > >On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: > >>Hi > >> > >>On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard > >> wrote: > >>>unix_send_msgfds is used by vhost-

Re: [Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Jan Kiszka
On 2015-12-10 13:51, Tim Sander wrote: > Hi Jan > > I have seen your patches for AT24Cxx functionality in qemu: > https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg05714.html > > As i am interested in this work i am wondering what happend to this effort? Internally in heavy use (not sure

Re: [Qemu-devel] [PATCH 08/74] acpi: extend aml_add() to accept target argument

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: it allows to express following ASL expression: Add(arg1, arg2, result) usecases that do not need to store result should pass NULL as 3rd arg that would express Add(arg1, arg2,) construct. Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c

Re: [Qemu-devel] [PATCH 09/74] acpi: add aml_decrement() and aml_subtract()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-build.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 3bb19bf..ee34771 100644 --- a/hw

Re: [Qemu-devel] [PATCH 10/74] acpi: add aml_call0() helper

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: it will help to call a method with 0 arguments Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c

Re: [Qemu-devel] qemu AT24Cxx

2015-12-10 Thread Tim Sander
Hi Jan Am Donnerstag, 10. Dezember 2015, 13:57:47 schrieb Jan Kiszka: > > I have seen your patches for AT24Cxx functionality in qemu: > > https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg05714.html > > > > As i am interested in this work i am wondering what happend to this > > effort? >

Re: [Qemu-devel] [PATCH 11/74] acpi: add aml_to_integer()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 50587de..1f599e3 100644 --- a/hw/acpi/am

Re: [Qemu-devel] [PATCH 12/74] acpi: extend aml_shiftright() to accept target argument

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: it allows to express ShiftRight(A,B,C) syntax Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 4 ++-- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff -

Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error()

2015-12-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 12/10/2015 12:29 PM, Markus Armbruster wrote: >> isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when >> passed a null bus. Use of hw_error() has always been questionable, >> because these are used only during machine initialization, and >> printin

Re: [Qemu-devel] [PATCH 07/74] acpi: aml: add helper for Opcode Arg2 Arg2 [Dst] AML pattern

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Currently AML API doesn't compose terms in form of following pattern: Opcode Arg2 Arg2 [Dst] but ASL used in piix4/q35 DSDT ACPI tables uses that form, so for clean conversion of it, AML API should be able to handle an optional 'Dst' argumet used

Re: [Qemu-devel] [PATCH 13/74] acpi: add aml_alias()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index dcaa7e9..6a63477 100644 --- a/hw/acpi/am

Re: [Qemu-devel] [PATCH 14/74] acpi: add aml_sleep()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6a63477..e36b546 100644 --- a/hw/acpi

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-10 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Grundmann, Christian (christian.grundm...@fabasoft.com) wrote: >> Hi, >> >> qemu-img-ev-2.3.0-29.1.el7.x86_64 >> libvirt-daemon-driver-qemu-1.2.8-16.el7_1.4.x86_64 >> qemu-kvm-ev-2.3.0-29.1.el7.x86_64 >> qemu-kvm-common-ev-2.3.0-29.1.el7.x86_64 >> ipxe-roms-q

[Qemu-devel] [PATCH] usb: hcd-ehci: add check to avoid an infinite loop

2015-12-10 Thread P J P
Hello Gerd, An infinite loop issue was reported by Mr Qinghao Tang(CC'd), in the USB EHCI emulator. In that, a malicious isochronous transfer descriptor(iTD) list could unfold an infinite loop in the 'ehci_advance_state' routine, by always setting 'again = 0 or 1'. Please see below a propo

Re: [Qemu-devel] [PATCH v4 2/8] ARM: ACPI: Add GPIO controller in ACPI DSDT table

2015-12-10 Thread Igor Mammedov
On Mon, 7 Dec 2015 15:39:46 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add GPIO controller in ACPI DSDT table. It can be used for gpio event. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Tested-by: Wei Huang > --- > hw/arm/virt-acpi-build.c | 19 +

Re: [Qemu-devel] [PATCH 16/74] acpi: add aml_lor()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 5094826..8cfa65c 100644 --- a/hw/acpi/am

Re: [Qemu-devel] [PATCH 17/74] acpi: add aml_lgreater()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 8cfa65c..b22e7da 100644 --- a/hw/acpi/am

[Qemu-devel] [PATCH for-2.5] Update language files for QEMU 2.5.0

2015-12-10 Thread Peter Maydell
Update translation files (change created via 'make -C po update'). Signed-off-by: Peter Maydell --- po/de_DE.po| 36 ++-- po/fr_FR.po| 36 ++-- po/hu.po | 36 ++-- po/it.po | 36 ++

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-12-10 Thread Grundmann, Christian
Sorry as this is my productionsystem i can't > Am 10.12.2015 um 14:18 schrieb Markus Armbruster : > > "Dr. David Alan Gilbert" writes: > >> * Grundmann, Christian (christian.grundm...@fabasoft.com) wrote: >>> Hi, >>> >>> qemu-img-ev-2.3.0-29.1.el7.x86_64 >>> libvirt-daemon-driver-qemu-1.2.8-1

Re: [Qemu-devel] [PATCH 19/74] acpi: add aml_to_hexstring()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 13 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 7500474..c025801 100644 --- a/hw/a

Re: [Qemu-devel] [PATCH 10/74] acpi: add aml_call0() helper

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 15:04:43 +0200 Marcel Apfelbaum wrote: > On 12/10/2015 01:41 AM, Igor Mammedov wrote: > > it will help to call a method with 0 arguments > > > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/aml-build.c | 8 > > include/hw/acpi/aml-build.h | 1 + > > 2

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Markus Armbruster
Markus Armbruster writes: > Paolo Bonzini writes: > >> On 10/12/2015 11:19, Markus Armbruster wrote: >>> +object_property_set_int(OBJECT(cpu), ZYNQ_BOARD_MIDR, "midr", >>> + &error_fatal);object_property_set_int(OBJECT(cpu), >>> + MPCORE_PERIPHBASE, >>> + "reset-cbar", >>> + &error_fatal);ob

Re: [Qemu-devel] [PATCH for-2.5] Update language files for QEMU 2.5.0

2015-12-10 Thread Stefan Weil
Am 10.12.2015 um 14:34 schrieb Peter Maydell: > Update translation files (change created via 'make -C po update'). > > Signed-off-by: Peter Maydell > --- > po/de_DE.po| 36 ++-- > po/fr_FR.po| 36 ++-- > po/hu.po | 36 +

Re: [Qemu-devel] [PATCH 20/74] acpi: add aml_to_buffer()

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 13 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 14 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index c025801..4b1b496 100644 --- a/hw/a

Re: [Qemu-devel] [PATCH 22/74] acpi: extend aml_or() to accept target argument

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 01:41 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 4 ++-- hw/arm/virt-acpi-build.c| 6 +++--- hw/i386/acpi-build.c| 3 ++- include/hw/acpi/aml-build.h | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 25/74] pc: acpi: memhp: prepare context in SSDT for moving memhp DSDT code

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 14:45:32 +0200 Marcel Apfelbaum wrote: > On 12/10/2015 01:41 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/Makefile.objs | 2 +- > > hw/acpi/memory_hotplug_acpi_table.c | 40 > > + > > hw/i38

Re: [Qemu-devel] [PATCH 58/74] pc: acpi: piix4: move PCI0._PRT() into SSDT

2015-12-10 Thread Igor Mammedov
On Thu, 10 Dec 2015 14:32:11 +0200 Marcel Apfelbaum wrote: > On 12/10/2015 01:41 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/acpi-build.c | 83 > > +++ > > hw/i386/acpi-dsdt.dsl | 60 -

Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors

2015-12-10 Thread Marcel Apfelbaum
On 12/10/2015 02:34 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 12/10/2015 12:19 PM, Markus Armbruster wrote: Done with this admittedly crude Coccinelle semantic patch with manual burial of dead Error * variables squashed in: @@ identifier FUN; expression ERR,

  1   2   3   >